GNU bug report logs - #62704
30.0.50; treesit-install-language-grammar should accept an arg to indicate the installation path.

Previous Next

Full log

Message #13 received at 62704-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Yuan Fu <casouri <at> gmail.com>
Cc: nasyxx <at> gmail.com, 62704-done <at> debbugs.gnu.org
Subject: Re: bug#62704: 30.0.50; treesit-install-language-grammar should
 accept an arg to indicate the installation path.
Date: Mon, 11 Sep 2023 16:35:37 -0700

Yuan Fu <casouri <at> gmail.com> writes:

> Nasy <nasyxx <at> gmail.com> writes:
>
>> Hi,
>>
>> In treesit.el, the ~treesit-install-language-grammar~ function installs
>> the grammar to the default path of
>> ~treesit--install-language-grammar-1~, which is inconvenient for users
>> who want to install the grammar to a custom path.  Adding an optional
>> argument =PATH= to this function and changing the line below would be
>> better.
>>
>>     (condition-case err
>>         (apply #'treesit--install-language-grammar-1
>>                ;; The nil is OUT-DIR.
>> -               (cons nil recipe))
>> +               (cons PATH recipe))
>>       (error
>
> Fair enough. I added a prompt at the end that asks for the target
> directory. Please give it a try (I didn’t test it :-)

No further comments within 5 months, so I assume that the fix worked.
I'm therefore closing this bug report with this message.

If this conclusion is incorrect and this is still an issue, please reply
to this email (use "Reply to all" in your email client) and we can
reopen the bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.