From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 05 15:26:53 2023 Received: (at submit) by debbugs.gnu.org; 5 Apr 2023 19:26:53 +0000 Received: from localhost ([127.0.0.1]:52677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk8mT-0006LB-Em for submit@debbugs.gnu.org; Wed, 05 Apr 2023 15:26:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:40762) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk8mR-0006L4-P8 for submit@debbugs.gnu.org; Wed, 05 Apr 2023 15:26:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk8mR-00055Z-6V for guix-patches@gnu.org; Wed, 05 Apr 2023 15:26:51 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk8mP-0004ev-3y for guix-patches@gnu.org; Wed, 05 Apr 2023 15:26:50 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 49DA23200941; Wed, 5 Apr 2023 15:26:42 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Wed, 05 Apr 2023 15:26:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=mesmtp; t=1680722801; x=1680809201; bh=uKwmWI5 rVPhq2EPXSxGQsiF0NwQ090zeHeJbpas8+zw=; b=raWgOVt3N2bfEXbSkFRE1WQ qZasrWbArl4aj2nO02pOIgKJW7zf47/nqt9HcNxhcjHMsdG0O02+WUWxYENhRUqH Ihu/q7Hi44zCMd4Rt4ICh/JafjrjpVgsrfDz+g4EvqFTovtbrXVl6DcLoaaN59CA CmDrxoqg/OJUzN2JQgf8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1680722801; x=1680809201; bh=uKwmWI5rVPhq2EPXSxGQsiF0NwQ0 90zeHeJbpas8+zw=; b=hgTbtUwmUwytyBCWl6XQCPedn9UXoVNwS9VSBiYcXaMV KoQQqJr2b+zZ3lCRhPqQUqLE9viMQ8nBWJqPCRmEP8OD7ZDCPBcBsSvABXt3D9yz 41oWm+iQrmUsBATrX+XlDHx52P7g1TrXPS3nVd7oKx6VetLZBOFjLXWqPi2cDPmr RgAZ4ETJfYQia3FLzxCDYtlObIIcuakg0aH0ey/B2T+7/g/EyoVo9jCzGh7Sh+6f eyYwXt3IkT2TDFj9gmBYJkaCRuWuj/WVjJD6LIARmrO0HzGQHYwTdd0i2Eoubcru 7zg/T2H+DlVBrf5g3QT6Y5k6e8bPpLYEhh6kvtXTxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejuddgudeflecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghr ihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeegveeftdeggfevgefghfefudelgfduie dtkefhgeegveehfeejheeuffefheevieenucffohhmrghinhepghhithhhuhgsrdgtohhm necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvoh esfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 5 Apr 2023 15:26:41 -0400 (EDT) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] gnu: Zstandard: Update to 1.5.5. Date: Wed, 5 Apr 2023 15:26:37 -0400 Message-Id: <8d9ae0fcc8215c2e7aa0514c814ee8b0966db2e1.1680722796.git.leo@famulari.name> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=64.147.123.19; envelope-from=leo@famulari.name; helo=wout3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) This fixes a corruption bug: https://github.com/facebook/zstd/releases/tag/v1.5.5 * gnu/packages/compression.scm (zstd)[replacement]: New field. (zstd-1.5.5): New variable. --- gnu/packages/compression.scm | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index e58fd65e49..8a78fee107 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -1635,6 +1635,7 @@ (define-public unshield (define-public zstd (package (name "zstd") + (replacement zstd-1.5.5) (version "1.5.0") (source (origin @@ -1721,6 +1722,18 @@ (define-public zstd license:public-domain ; zlibWrapper/examples/fitblk* license:zlib)))) ; zlibWrapper/{gz*.c,gzguts.h} +(define-public zstd-1.5.5 + (package + (inherit zstd) + (version "1.5.5") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/facebook/zstd/releases/download/" + "v" version "/zstd-" version ".tar.gz")) + (sha256 + (base32 "1r1ydmj7ib3g5372yj3k40vl3b9ax0154qg2lqcy7ylwhb69chww")))))) + (define-public pzstd (package/inherit zstd (name "pzstd") -- 2.39.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 11:32:15 2023 Received: (at 62684) by debbugs.gnu.org; 6 Apr 2023 15:32:15 +0000 Received: from localhost ([127.0.0.1]:54738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkRax-0005qD-C7 for submit@debbugs.gnu.org; Thu, 06 Apr 2023 11:32:15 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:35825) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkRav-0005pz-Sl for 62684@debbugs.gnu.org; Thu, 06 Apr 2023 11:32:14 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8C5515C00B6; Thu, 6 Apr 2023 11:32:08 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 06 Apr 2023 11:32:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=mesmtp; t=1680795128; x=1680881528; bh=HhImtXBZNtoCzt6gPxc0SY veUut0g0VZVrtrTYkHbkg=; b=PzFTB0BQegXbEsNWBTGFpZGFjMu/so9NPu8gDy 6+eRFktVG0ItSSnyrNX4KTX7ZZ0VgFV1IId2DyIwjkyyvaC767g7zV7W/GF4g54I R9qL4W8Ilb690fqZtV42ejuDt6hbikoFyV8Fd0fvFFkXHtcEaSEilL0TUNz4wY15 Yn7jw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1680795128; x=1680881528; bh=HhImtXBZNtoCzt6gPxc0SYveUut0g0VZVrt rTYkHbkg=; b=pyxSIUECM7SsfOlIB+ol/By+1anGkh8UIOifAXCfTTVZL5PhPa2 1xJmrEpSDdVut17VyMC9PBBMIUUydljNHMbvL3l0PC7AOW5u56kU3xs+Q4GZEzBz vTvhWkpIv3MTQAtlsuU0SJdLKzbAqJX6vMfUgEsEAAvMpe3lRjeXY+5kRJJ539AX FTjkEVu2NfYND4+CTHkgjvtOYhvCjooSSq/vvxkeWfR50y0pLRp/r7pbcvvz1uM3 GnGbP9DkquPRZIlF8nInIun+dK4uDf2zo1PQy6xPUyVxKeAZ33lOw9dmfRcOcfPG DbDQBCqdUzaLBSrcP1yFjVHaB7OKMvfhclA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejfedgkeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkgggtugesthdtredttd dtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhi rdhnrghmvgeqnecuggftrfgrthhtvghrnhepffehtdeffedtvdeuieefudeujedvkeehff euieejgfdvteelgeehgeefheehuddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <62684@debbugs.gnu.org>; Thu, 6 Apr 2023 11:32:07 -0400 (EDT) Date: Thu, 6 Apr 2023 11:32:04 -0400 From: Leo Famulari To: 62684@debbugs.gnu.org Subject: Re: [PATCH] gnu: Zstandard: Update to 1.5.5. Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62684 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) I've updated my packages based on this patch. So far, so good. From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 07 06:53:23 2023 Received: (at 62684) by debbugs.gnu.org; 7 Apr 2023 10:53:24 +0000 Received: from localhost ([127.0.0.1]:55767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkjid-0000KZ-IE for submit@debbugs.gnu.org; Fri, 07 Apr 2023 06:53:23 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:40086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkjic-0000KL-K4 for 62684@debbugs.gnu.org; Fri, 07 Apr 2023 06:53:23 -0400 Received: by mail-wr1-f53.google.com with SMTP id ffacd0b85a97d-2ef2d5c92f5so141347f8f.0 for <62684@debbugs.gnu.org>; Fri, 07 Apr 2023 03:53:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680864797; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :from:to:cc:subject:date:message-id:reply-to; bh=WotbHz2K8w0OTqnqNVM0aPRVn1E1k+0sLhfSsbah3sc=; b=Wx4SvjLsrbvx/o4hfjZrxVp8bUO3TIGaqjKd3IsDv/BQEcdr5e2hgpW2Ws822HqocE k60DYGXepCTMM9PsJ1HsQVAd0kcsfzalnaHI2MV3Bk1w+WdA6BwTCTpDP/VaWa1ha8F0 jUIty/eTPrxsGqDvl7XhJlyhwB9LVDv9Caf01PFTo2FydK8OL3Ql496senoPQG4ZG5KB FERbgBy+VJFBPsSBEg+Z7NhnmZbIVcrSI42/5XicO0qAAB5MtBWA2Q4B/zYIXqmM98M1 eZkHmbScoMX8sUBUDasZBE6g3+rkjBkhNHCuJPWkXhAUjFD+gl1f1dsI2Ubu9LmVO6jX CUfg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680864797; h=mime-version:message-id:date:references:in-reply-to:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=WotbHz2K8w0OTqnqNVM0aPRVn1E1k+0sLhfSsbah3sc=; b=TkQFwQoKu++QcJAMejjy1J4tUTaEAH6esjLPw70QCAEkYMovq7sfF6FJ02QYwgcPfk hFGDgVB3w9t1ZQwaxp/ulvH6Vzu70GIs1kgKcA5qHx7oMHKauRVMzvCL/FTzOq3FL3pW inWwtgcB55/gcOn+9i9Y+IabRZ62MztuB/sDSmXNrSVbNUiRBM3GPJ/PUuwPfoatGyLR efBUvRjzOLiLm7JfOHbP1wwL1nODyJ7gN8Xk6gn66WhPSutclcVJ5JXUcQdN25t1sKD4 M8uXyMZkGQx9/BaL5zUwceE29wd+Wi4xNuT487K8Lj9MLIaDG0lQ629T17ClC+reVF3n uNbw== X-Gm-Message-State: AAQBX9eB9DFDQq9PKtNc5YpyqNZuyDgOtXSgiWokVrCRcUqsVbI+sLKa +q9K6lLIiKlBT4sDtlxo9kJRouVj85k= X-Google-Smtp-Source: AKy350a9aUimofhJYKb57Y1FRq8e7+6aGPoSS1LNKINg4MaBH/lxNNnLZgDwAQwvZYwhhRylrpFewQ== X-Received: by 2002:adf:dccf:0:b0:2ef:5b62:7873 with SMTP id x15-20020adfdccf000000b002ef5b627873mr789508wrm.4.1680864796744; Fri, 07 Apr 2023 03:53:16 -0700 (PDT) Received: from pfiuh07 ([193.48.40.241]) by smtp.gmail.com with ESMTPSA id f4-20020a7bcd04000000b003ed1f6878a5sm4313549wmj.5.2023.04.07.03.53.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Apr 2023 03:53:16 -0700 (PDT) From: Simon Tournier To: Leo Famulari , 62684@debbugs.gnu.org Subject: Re: [bug#62684] [PATCH] gnu: Zstandard: Update to 1.5.5. In-Reply-To: <8d9ae0fcc8215c2e7aa0514c814ee8b0966db2e1.1680722796.git.leo@famulari.name> References: <8d9ae0fcc8215c2e7aa0514c814ee8b0966db2e1.1680722796.git.leo@famulari.name> Date: Fri, 07 Apr 2023 12:52:40 +0200 Message-ID: <87ile8klqf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62684 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, On mer., 05 avril 2023 at 15:26, Leo Famulari wrote: > + (replacement zstd-1.5.5) > (version "1.5.0") [...] > +(define-public zstd-1.5.5 > + (package > + (inherit zstd) > + (version "1.5.5") > + (source > + (origin > + (method url-fetch) > + (uri (string-append "https://github.com/facebook/zstd/releases/download/" > + "v" version "/zstd-" version ".tar.gz")) > + (sha256 > + (base32 "1r1ydmj7ib3g5372yj3k40vl3b9ax0154qg2lqcy7ylwhb69chww")))))) I am always confused by the implication of such change. --8<---------------cut here---------------start------------->8--- $ ./pre-inst-env guix show zstd | recsel -p name,version name: zstd version: 1.5.5 name: zstd version: 1.5.0 $ ./pre-inst-env guix build zstd@1.5.0 /gnu/store/g8cl62bmsdsqn14yxghdl882zn0ls8n9-zstd-1.5.5-lib /gnu/store/b980xf8i6qmx7iaih1bfnqvaihg37p3b-zstd-1.5.5 /gnu/store/6iysnbm6rb9hm61f7jsqgiry5l9v9yca-zstd-1.5.5-static $ ./pre-inst-env guix build zstd@1.5.0 --no-grafts /gnu/store/3x3dl71d4xm6y4hjwq110hmfyfx0xc6j-zstd-1.5.0-lib /gnu/store/bn6pk5zjjdpdfzb6yfr5psi9pji9w51n-zstd-1.5.0 /gnu/store/wa5pngf2lywgi8vd8k9b1k13wp2acvi4-zstd-1.5.0-static --8<---------------cut here---------------end--------------->8--- Well, maybe something like: --8<---------------cut here---------------start------------->8--- diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index 8a78fee107..5841ea0cf0 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -1637,6 +1637,7 @@ (define-public zstd (name "zstd") (replacement zstd-1.5.5) (version "1.5.0") + (properties `((hidden? . #true))) (source (origin (method url-fetch) @@ -1726,6 +1727,7 @@ (define-public zstd-1.5.5 (package (inherit zstd) (version "1.5.5") + (properties '()) (source (origin (method url-fetch) --8<---------------cut here---------------end--------------->8--- would be less confusing. Note this discussion [1] about similar examples. And this patch [2] as an attempt to address the UX issue. 1: https://yhetil.org/guix/86czvohn86.fsf@gmail.com/ 2: https://yhetil.org/guix/86im5a6ea4.fsf@gmail.com Cheers, simon From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 08 13:07:12 2023 Received: (at 62684) by debbugs.gnu.org; 8 Apr 2023 17:07:12 +0000 Received: from localhost ([127.0.0.1]:59420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plC1v-0003sT-Mo for submit@debbugs.gnu.org; Sat, 08 Apr 2023 13:07:11 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47123) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plC1u-0003sF-75 for 62684@debbugs.gnu.org; Sat, 08 Apr 2023 13:07:10 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 086DD5C0125; Sat, 8 Apr 2023 13:07:05 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 08 Apr 2023 13:07:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:cc:content-type:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=mesmtp; t=1680973625; x=1681060025; bh=1SetfcU/Ii2VEm21NAGxiK7zX+7zeuH+/ehX1sv7PVo=; b= uzMnKpftq8JcHONFgpKzY2Zs27zsYTmIAdmutWQV/yY11GSZPBw+PXiwXU43j71b bgXiAe6W+RubxFzoIwM3zByWxeyRoSCYV+ojTAbcpklvztPskALTNUg6wf/t9Dku stbwuh1ahV9ciuAhOp5qZCdDC15yn9plpSisFyaNL/0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680973625; x=1681060025; bh=1SetfcU/Ii2VE m21NAGxiK7zX+7zeuH+/ehX1sv7PVo=; b=Ek71g9D+1wsYfQvCndAVoPRQsy1dV x6MNYYhYyxsZ34hmOtyb13qXDals7sCBJN6zTAaDr8gmQjBOKB8bAV6CwpIit13K gcFNwP+LrcquQ6RlK1rwIQLGlB2cDEc6A537Uw95nxzlTK3eYitdOtzG2TChsly2 AlYKmoknOEOoa1ATdfLeI3Fq7d1f9stbsjQ5unP3Ggb/SNtkBeHayI0Qule/9Amc W/IcM3H/49r2GXC1CO/kFxM1QRTpMDIDEQZPd7a/61DwsR4c3eGe1VIQpnajbdJ/ lE/MPg92QTkNrw93/gcq0guCMVPnaRm/B39eIs51L261cHykC3O5eOB/w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejjedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvfevuffkfhggtggujgesth dtredttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhu lhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepieetudehfeekueefleegudfhje fgleehfeeluefhfeffgfeuudelhedvjeelieetnecuvehluhhsthgvrhfuihiivgeptden ucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 8 Apr 2023 13:07:04 -0400 (EDT) Date: Sat, 8 Apr 2023 13:07:03 -0400 From: Leo Famulari To: Simon Tournier Subject: Re: [bug#62684] [PATCH] gnu: Zstandard: Update to 1.5.5. Message-ID: References: <8d9ae0fcc8215c2e7aa0514c814ee8b0966db2e1.1680722796.git.leo@famulari.name> <87ile8klqf.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ile8klqf.fsf@gmail.com> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62684 Cc: 62684@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Apr 07, 2023 at 12:52:40PM +0200, Simon Tournier wrote: > Well, maybe something like: [...] > + (properties `((hidden? . #true))) Yes, thank you. Please see version 2 of the patch. I tried using the HIDDEN-PACKAGE procedure for zstd@1.5.0. It doesn't change the derivation, which is good, but I don't know how to un-hide the replacement. So this is good enough, I think. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 08 13:07:23 2023 Received: (at 62684) by debbugs.gnu.org; 8 Apr 2023 17:07:23 +0000 Received: from localhost ([127.0.0.1]:59424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plC27-0003st-0q for submit@debbugs.gnu.org; Sat, 08 Apr 2023 13:07:23 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:43849) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plC24-0003se-R2 for 62684@debbugs.gnu.org; Sat, 08 Apr 2023 13:07:21 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C32E35C0134; Sat, 8 Apr 2023 13:07:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Sat, 08 Apr 2023 13:07:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:message-id:mime-version:reply-to:sender:subject :subject:to:to; s=mesmtp; t=1680973635; x=1681060035; bh=r40ZdjK mnzSaAnQvOhdXdhEY42BXamx6kVfX0iMHYtw=; b=dpQA799FT8CVZpRQckXddu0 vnbbtYzjS3kmgHS31ZHEbZuDcfnG+b8CLJF4K5SiyxcFA2T3tWW3uog5FCZjOleV Tqb2W6q03bi+sLe+ZlylBBBSBWrL3uxOFwtG5ZEECFZMVVe2XgEFhhjAtKuDJRrt DABAUL0NfnBauIcil0jk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:date:feedback-id:feedback-id:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1680973635; x=1681060035; bh=r40ZdjKmnzSaAnQvOhdXdhEY42BX amx6kVfX0iMHYtw=; b=qOo2O2q5ypuzqKU3kh60t+RovKbgNOFsv9Tq8ZyTgP51 qIpx7TyFlQlB/oBRCE4qnvbVv8fXYPkscvI+FHNR5zDNAldx+Sh7dqZ+8a3w0Av1 FE5ydf5nx+VI6ixP+/cU4XKF9F4zCg/lW2RW3EZOjwjLGEeZZqz3uW50m5QDc6w6 2aYtqAItYDffxYIFLjo63UJJcAaTqxXFgJkKC5ONOXokuqLZTWlB5SiHw5uchiaI os+7znB1xQKDCnDALkY/mEhvc/9GQD9Jqdm+nq8Qy6OprBLW+C/SE5mxDOH2u9eK jUGgEdzzpvwTj7ew+C8NC9OatuEOE7MkNd+u8OtboA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdejjedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffoggfgsedtkeertd ertddtnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghr ihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeegveeftdeggfevgefghfefudelgfduie dtkefhgeegveehfeejheeuffefheevieenucffohhmrghinhepghhithhhuhgsrdgtohhm necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvoh esfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <62684@debbugs.gnu.org>; Sat, 8 Apr 2023 13:07:15 -0400 (EDT) From: Leo Famulari To: 62684@debbugs.gnu.org Subject: [PATCH v2] gnu: Zstandard: Update to 1.5.5. Date: Sat, 8 Apr 2023 13:07:12 -0400 Message-Id: X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62684 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This fixes a corruption bug: https://github.com/facebook/zstd/releases/tag/v1.5.5 * gnu/packages/compression.scm (zstd)[replacement]: New field. (zstd-1.5.5): New variable. --- gnu/packages/compression.scm | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/gnu/packages/compression.scm b/gnu/packages/compression.scm index e58fd65e49..1187d12421 100644 --- a/gnu/packages/compression.scm +++ b/gnu/packages/compression.scm @@ -1635,6 +1635,13 @@ (define-public unshield (define-public zstd (package (name "zstd") + ;; Replace to the data corruption bug fixed in Zstd 1.5.5. + ;; https://github.com/facebook/zstd/releases/tag/v1.5.5 + (replacement zstd-1.5.5) + ;; Hide this buggy package in the Guix UI. If you add another + ;; property to this package, adjust the properties in the package + ;; replacement accordingly. + (properties `((hidden? . #true))) (version "1.5.0") (source (origin @@ -1721,6 +1728,20 @@ (define-public zstd license:public-domain ; zlibWrapper/examples/fitblk* license:zlib)))) ; zlibWrapper/{gz*.c,gzguts.h} +(define-public zstd-1.5.5 + (package + (inherit zstd) + ;; Don't hide this package from the UI. + (properties '()) + (version "1.5.5") + (source + (origin + (method url-fetch) + (uri (string-append "https://github.com/facebook/zstd/releases/download/" + "v" version "/zstd-" version ".tar.gz")) + (sha256 + (base32 "1r1ydmj7ib3g5372yj3k40vl3b9ax0154qg2lqcy7ylwhb69chww")))))) + (define-public pzstd (package/inherit zstd (name "pzstd") -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 12 16:44:32 2023 Received: (at 62684-done) by debbugs.gnu.org; 12 Apr 2023 20:44:32 +0000 Received: from localhost ([127.0.0.1]:41905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmhKS-0008RF-BD for submit@debbugs.gnu.org; Wed, 12 Apr 2023 16:44:32 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:33607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pmhKP-0008Qs-2b for 62684-done@debbugs.gnu.org; Wed, 12 Apr 2023 16:44:30 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 94CF73200995; Wed, 12 Apr 2023 16:44:21 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 12 Apr 2023 16:44:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=mesmtp; t=1681332261; x=1681418661; bh=VVXeRawbXmnKcXYVW3nl52I94VpPk82+QFAwXR5dvdE=; b=DMp8Vnaeri3f vipUi3RdavgYO+thm9M6QImAktwL+8lDqHgKAQz8wLldw3kFwWVtDPc5fbb/nyCt 7E+96V1G++WB+Vvg7ASJGgW3zi36UxJcPmmKep9qVJWB67z2kTjadAJMBGnXSg5K yrUw1o3e/nFu3mzP12uaLbAO9GLp6Dk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681332261; x=1681418661; bh=VVXeRawbXmnKc XYVW3nl52I94VpPk82+QFAwXR5dvdE=; b=ay+Cdzw8HfmslENA9mLvrY1nabpRs AnM2DeeNYepj9p9Sj+1L7Y5GqWUpKN4iffipPQMwAyXNb1e3TXggsAJdasu9jzCb J/8QzUajYc6mG49h0Mm9aa1nrxPal0Fq8f1/qyhNF08I24dVdahP3DyVPpxitYIC HXs6H+D0Pypkr2e/a4hU65jKA8kbNh2IlhAQACkEzzfEwT3d8v74fJW8sIHO8r9T 3sXI/uOE0XhEOEHRPvnNeTMtuFtVIX49AJNfQDd2ogVCRrKsZjhZriN8f7lFinZ/ mgdV7EkdYT6elESDFS56SdytlC3yIuHeMt/zQKPITKckJkReD/xHo0p0g== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekiedgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfhfgggtuggjsehttd ertddttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhl rghrihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeehgfelvefhtddtfeehiedtgfehff ffffelvdelhffgkedtteehgfeugfehgeethfenucffohhmrghinhepghhithhhuhgsrdgt ohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplh gvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Feedback-ID: i819c4023:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for <62684-done@debbugs.gnu.org>; Wed, 12 Apr 2023 16:44:20 -0400 (EDT) Date: Wed, 12 Apr 2023 16:44:13 -0400 From: Leo Famulari To: 62684-done@debbugs.gnu.org Subject: Re: [PATCH v2] gnu: Zstandard: Update to 1.5.5. Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62684-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Sat, Apr 08, 2023 at 01:07:12PM -0400, Leo Famulari wrote: > This fixes a corruption bug: > > https://github.com/facebook/zstd/releases/tag/v1.5.5 > > * gnu/packages/compression.scm (zstd)[replacement]: New field. > (zstd-1.5.5): New variable. Pushed as 60c97c60a53686ec321eb541b85e01b6decc2014 From unknown Sun Aug 17 10:26:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 11 May 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator