Subject: bug#62678: closed (Re: [bug#62678] [PATCH] services: nginx: Harden php-location settings.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 07 Jul 2023 14:23:02 +0000

Your bug report

#62678: [PATCH] services: nginx: Harden php-location settings.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
62678: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62678
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#62678] [PATCH] services: nginx: Harden php-location settings.
From: Tobias Geerinckx-Rice <[email-masked]>
To: Bruno Victal <[email-masked]>
Cc: [email-masked]
Date: Fri, 07 Jul 2023 16:22:01 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi Bruno,

Bruno Victal 写道：
> Incorporate advice from [2], which mitigates httpoxy[1] 
> vulnerability and
> disallows passing non-php files to the PHP backend.
>
> [1]: <https://httpoxy.org/>
> [2]: 
> <https://www.nginx.com/resources/wiki/start/topics/examples/phpfcgi/>,
> note 4.

This is a better comment than commit message.  I made it so and 
pushed your changes as commit 
cbc14b3baea457cf2718b85f767d39ff3911ce91.

Thanks!

T G-R

Subject: [PATCH] services: nginx: Harden php-location settings.
From: Bruno Victal <[email-masked]>
To: [email-masked]
Cc: Bruno Victal <[email-masked]>
Date: Wed, 5 Apr 2023 16:34:08 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Incorporate advice from [2], which mitigates httpoxy[1] vulnerability and
disallows passing non-php files to the PHP backend.

[1]: <https://httpoxy.org/>
[2]: <https://www.nginx.com/resources/wiki/start/topics/examples/phpfcgi/>,
note 4.

* gnu/services/web.scm (nginx-php-location): Only pass existing php files to
backend. Mitigate httpoxy vulnerability.
---

Tested with: make check-system TESTS="nginx php-fpm"

 gnu/services/web.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/services/web.scm b/gnu/services/web.scm
index d56e893527..f5ed027bb4 100644
--- a/gnu/services/web.scm
+++ b/gnu/services/web.scm
@@ -1123,6 +1123,10 @@ (define* (nginx-php-location
    (uri "~ \\.php$")
    (body (list
           "fastcgi_split_path_info ^(.+\\.php)(/.+)$;"
+          ;; Mitigate https://httpoxy.org/ vulnerabilities
+          "fastcgi_param HTTP_PROXY \"\";"
+          ;; Only pass existing php files to the backend.
+          "if (!-f $document_root$fastcgi_script_name) { return 404; }"
           (string-append "fastcgi_pass unix:" socket ";")
           "fastcgi_index index.php;"
           (list "include " nginx-package "/share/nginx/conf/fastcgi.conf;")))))

base-commit: 6311493d7a6271bfbc51f4693857f9a12fe9965d
-- 
2.39.2