From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 05 03:38:46 2023 Received: (at submit) by debbugs.gnu.org; 5 Apr 2023 07:38:46 +0000 Received: from localhost ([127.0.0.1]:50797 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjxjC-0004Bl-Ea for submit@debbugs.gnu.org; Wed, 05 Apr 2023 03:38:46 -0400 Received: from lists.gnu.org ([209.51.188.17]:44814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjxjA-0004Bd-Io for submit@debbugs.gnu.org; Wed, 05 Apr 2023 03:38:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjxj5-0007QS-T2 for bug-gnu-emacs@gnu.org; Wed, 05 Apr 2023 03:38:41 -0400 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pjxj3-0005Sk-G4 for bug-gnu-emacs@gnu.org; Wed, 05 Apr 2023 03:38:38 -0400 Received: by mail-wm1-x329.google.com with SMTP id v6-20020a05600c470600b003f034269c96so11161205wmo.4 for ; Wed, 05 Apr 2023 00:38:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680680314; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=fmeCvOPZQlhwXTPwApQRg3n5q9Sx/gnLacsLRf8OkvI=; b=cvq1sub6B/lOWF7iv57BoNBKlRfPsUCiMWd+mdiAqiD/vAVeQw1tMDchPo6fG9uQLX dR9i5vS287Ayi4kENF6Y5FH6c98rnOPBjGweFvtB66lojsYVf0cIjKzo/lN96ifhG+LU SIdXjV70+IsfFj4fKlmCz4ONdoYTgFq4HBP8jv4FCjKw1+ai9iJnSRNsj92qZEgUj6SK B7jNj2y5Cq6zzYxqzkUf/Tkp3g8e3tURcDZ6UWG90ErrTIHXOSPY0Ig+FBMDAvM4GXee 3nWhVJ/zLKhPPZUgnV2x+PD3t1c1Sdpye75zjlqu1wI2P/nUDHsGyKKEHfkUhfQShR76 qgvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680680314; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=fmeCvOPZQlhwXTPwApQRg3n5q9Sx/gnLacsLRf8OkvI=; b=6WoqwBDGXJOarQPCzF8XOcYhXleSI04fQu/rJ62Q/sArxa++vpTae6HlakJnD+ipyv 7IHGS5OWST3kqDgAFz6gF3NIXhGxxe0SRzPnDXL23IUD0iiPtiJ3TTTYLTC2H+w3BxWh QpKQ7pakdytXeUjG2mUyFQApRN3v5z5w8Lkl6zR7nxBctNqCRe3kDTXZLh/ck/HdHaoN z/55Brf/M6xw1JigUO4o/dMKycZ9K25xN+J2RK1oc45zVfy69XYd83tK5ZX6lFyx1o88 sgGzxdNzwlYGD07SgK1cfqbe+vG7a0Wpl8b9oxMHvuDUMOsAa4rcGrVH8y4Ie4nzVwB7 FxbQ== X-Gm-Message-State: AAQBX9fec4Fb4OyGGPeaNgCSbjQiKXubjPBfFQJFLSkVn6Qv2xQzh7JQ 1VCQ7/KUUJrZCM+92C+hzqP1CoIIejM= X-Google-Smtp-Source: AKy350ai37ZUtYkgYt3Y2sPFBIsazxY8we2wyaE5oro0aAKmjQlEuBAoW8TdP8l0aWapNYQKYmndcg== X-Received: by 2002:a7b:ce0e:0:b0:3dc:4b87:a570 with SMTP id m14-20020a7bce0e000000b003dc4b87a570mr3770119wmc.35.1680680314141; Wed, 05 Apr 2023 00:38:34 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id j8-20020adfe508000000b002cfe71153b4sm14162197wrm.60.2023.04.05.00.38.33 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 00:38:33 -0700 (PDT) From: Robert Pluim To: bug-gnu-emacs@gnu.org Subject: 29.0.60; emoji-zoom-increase interacts badly with faces X-Debbugs-No-Ack: yes Date: Wed, 05 Apr 2023 09:38:32 +0200 Message-ID: <87y1n6hj7r.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::329; envelope-from=rpluim@gmail.com; helo=mail-wm1-x329.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --begin-- emacs -Q C-p C-p C-x 8 e + + + + C-u C-x =3D --end-- Visually, this does the right thing: the ';' has its height increased, but the text properties look like this: face ((:height 1.1) font-lock-comment-delimiter-face :hei= ght 1.3310000000000004) fontified t rear-nonsticky t That=CA=BCs not a valid 'face property, unless I=CA=BCm misreading (info "(elisp) Special Properties"), plus the ':height 1.331' bit is wrong, that=CA=BCs (expt 1.1 3), not (expt 1.1 4). Yet it works, the height has been increased. Is this a bug in our interpretation of 'face properties? I can fix the code in `emoji-zoom-increase' to produce something like ((:height 1.4641000000000004) font-lock-comment-delimiter-face) instead, but first I=CA=BCd like to understand what=CA=BCs going on. In GNU Emacs 29.0.60 (build 15, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0) of 2023-03-14 built on rltb Repository revision: 4b6f2a7028b91128934a19f83572f24106782225 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12009000 System Description: Debian GNU/Linux 11 (bullseye) Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 05 04:45:16 2023 Received: (at 62675) by debbugs.gnu.org; 5 Apr 2023 08:45:16 +0000 Received: from localhost ([127.0.0.1]:50855 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjylX-0006Gd-Sm for submit@debbugs.gnu.org; Wed, 05 Apr 2023 04:45:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjylW-0006GQ-Gw for 62675@debbugs.gnu.org; Wed, 05 Apr 2023 04:45:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjylR-0003LH-0Z; Wed, 05 Apr 2023 04:45:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ineQB0+vy7iQrsfJce9o61adL0sWl8aCe5xfUxO2cnU=; b=FPe8dMIy+YQn+PTlX70Y driAkg3/tRIjJpNzm1YumLrF0eHQzrtyljbVB+V89yojdSA1uiPIih+eBSRF/Lv0HVBs+6sW7v9pk jgHM3iSVsqnCruu81fnqBcu963kwLMP+v4aTQlhETz8YDgQ/GJ2+XCT438345TsPG6NAXtGV1FUHE jtAnAsQi7Q86LHSqASMVQVwAF2adgbkwnGsI12LC3ihzUF0plJTVIpuK/zgmSxp9RLVayLhvLrESU 6tXiYMx5qNl5BZnERITUabXHzKYRBGCG4ez/ZTFtRHh6kjfSJdPesJozOmxJ0pA+IJf0gqraNhWsn NVCyAYuIe/og4g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjylQ-00023Z-Aj; Wed, 05 Apr 2023 04:45:08 -0400 Date: Wed, 05 Apr 2023 11:45:35 +0300 Message-Id: <83v8iasonk.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87y1n6hj7r.fsf@gmail.com> (message from Robert Pluim on Wed, 05 Apr 2023 09:38:32 +0200) Subject: Re: bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces References: <87y1n6hj7r.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62675 Cc: 62675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Date: Wed, 05 Apr 2023 09:38:32 +0200 > > > --begin-- > emacs -Q > C-p C-p > C-x 8 e + + + + > C-u C-x = > --end-- > > Visually, this does the right thing: the ';' has its height increased, > but the text properties look like this: > > face ((:height 1.1) font-lock-comment-delimiter-face :height 1.3310000000000004) > fontified t > rear-nonsticky t > > Thatʼs not a valid 'face property, unless Iʼm misreading (info > "(elisp) Special Properties"), plus the ':height 1.331' bit is wrong, > thatʼs (expt 1.1 3), not (expt 1.1 4). Yet it works, the height has > been increased. The first "+" doesn't increase the height, though. > Is this a bug in our interpretation of 'face properties? Face properties can be specified in many strange ways, and the fact that some invalid specifications seem to "work" doesn't mean we have a bug, it just means some invalid faces fall through the cracks. > I can fix the code in `emoji-zoom-increase' to produce something like > > ((:height 1.4641000000000004) font-lock-comment-delimiter-face) > > instead Please do, and thanks. We don't need to understand why some bug seems to work, it is enough to fix the bug. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 05 05:12:41 2023 Received: (at 62675) by debbugs.gnu.org; 5 Apr 2023 09:12:41 +0000 Received: from localhost ([127.0.0.1]:50905 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjzC4-0007D9-Ka for submit@debbugs.gnu.org; Wed, 05 Apr 2023 05:12:41 -0400 Received: from mail-wm1-f47.google.com ([209.85.128.47]:42915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjzC3-0007Cp-Ia for 62675@debbugs.gnu.org; Wed, 05 Apr 2023 05:12:40 -0400 Received: by mail-wm1-f47.google.com with SMTP id m6-20020a05600c3b0600b003ee6e324b19so21565184wms.1 for <62675@debbugs.gnu.org>; Wed, 05 Apr 2023 02:12:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680685953; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=wLBcVoyF7zcEJJbp19NtmrjAecRVGL7cVbjM1KzfhVg=; b=MOpz5eQhbKNCyhc9FIe3bwDL/Q7pW2XZx5/QMlNi5KzfcFCyJGCmotKF15nBIMnoOm Pn9zI2we4K7F3zYiVg3UebaAAhqQSuCy9ubJdmWKNMOSnusoTr7IX23QIyknB2FkRdDo SrkNnJEXlhd5FeTibqmAJn+arAe/VLDdEx+kuK9IjD4EtmDz81khnPFx/8HKrBLNwbmi h82c1iis9SdPhYk3RXi8K8mhYaxvsD6fEO9Gmwbgcv2fNIi+Yofuw96GAhEUUMUr3tsU D5sBIcw9RH/B90wFEDMH7p9b9C+I6gMNB3QTuiAUR9R9A6tn62GhHQ9+B/hxYp+lfZMI 8L3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680685953; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wLBcVoyF7zcEJJbp19NtmrjAecRVGL7cVbjM1KzfhVg=; b=PHf92c0KyizEZGbfZPIQazrU5ZoDXWExOwCoIRXJ9SZw6vbVtiZ1iN9+vwSdJVqC7s MeAytB9OzPk96T4PnuqJFB/Fnezooy2WLj0WuCmd9I9hBg9WrLii88LUEpk4X5MltC0G lGdW/4uytz1pSK3RLcZWECtSXdMlgCExy+MsdD7H4mtq2MAZLOmk3KVEB2rnzVOUl8TX zURD8ZXhsTsuqMXE5kEo1/WBKuN9/251T3DFeK546a1p5OG1pNUWCSIlyTsHmuKIah4d rNNMmZou+J3CSmI+GgRN94j/9jSAG5K8xal3LheH9TuN7axCH8DAwtt1DGAouMqX1TpZ cfTA== X-Gm-Message-State: AAQBX9dhnaZV4TQgqdPe/3XTk1rBOrGEa83Pan0tqIWjMXMAuYG/gsfL PU+F6zyIDyUTxZIIeuI3///PN9o7Vcs= X-Google-Smtp-Source: AKy350aNC3O4ao+liD7LOVF1auH54cb3BTACk7BwfgQlPmAxNB6LeN4rTVzR4rjr9Zi5oLH2dCpLyQ== X-Received: by 2002:a7b:cd87:0:b0:3df:de28:f819 with SMTP id y7-20020a7bcd87000000b003dfde28f819mr4290267wmj.15.1680685952965; Wed, 05 Apr 2023 02:12:32 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id 21-20020a05600c025500b003f04646838esm1508787wmj.39.2023.04.05.02.12.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 02:12:32 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces In-Reply-To: <83v8iasonk.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Apr 2023 11:45:35 +0300") References: <87y1n6hj7r.fsf@gmail.com> <83v8iasonk.fsf@gnu.org> Date: Wed, 05 Apr 2023 11:12:31 +0200 Message-ID: <87ttxuhev4.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62675 Cc: 62675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 05 Apr 2023 11:45:35 +0300, Eli Zaretskii said: >> That=CA=BCs not a valid 'face property, unless I=CA=BCm misreading (= info >> "(elisp) Special Properties"), plus the ':height 1.331' bit is wrong, >> that=CA=BCs (expt 1.1 3), not (expt 1.1 4). Yet it works, the height= has >> been increased. Eli> The first "+" doesn't increase the height, though. Hmm, you=CA=BCre right. Although if I then move to a different place in the buffer, and do 'C-x 8 e +' it does increase the height first time. Is this an interaction with font-lock? Oh, and it doesn=CA=BCt work at eob. And increase followed by decrease doesn=CA=BCt get you back to :height 1.0. And there=CA=BCs no reset. I think I=CA=BCll only fix the first one on emacs-29 :-) >> Is this a bug in our interpretation of 'face properties? Eli> Face properties can be specified in many strange ways, and the fact Eli> that some invalid specifications seem to "work" doesn't mean we ha= ve a Eli> bug, it just means some invalid faces fall through the cracks. OK. I=CA=BCll make the code match the documented behaviour, and not worry about it too much =F0=9F=98=80 >> I can fix the code in `emoji-zoom-increase' to produce something like >>=20 >> ((:height 1.4641000000000004) font-lock-comment-delimiter-face) >>=20 >> instead Eli> Please do, and thanks. We don't need to understand why some bug s= eems Eli> to work, it is enough to fix the bug. This seems to work: diff --git a/lisp/international/emoji.el b/lisp/international/emoji.el index bcd4aac4f29..a9ed6e79cc9 100644 --- a/lisp/international/emoji.el +++ b/lisp/international/emoji.el @@ -708,22 +708,24 @@ emoji-zoom-increase FACTOR is the multiplication factor for the size." (interactive) (set-transient-map emoji-zoom-map t nil "Zoom with %k") - (let* ((factor (or factor 1.1)) - (old (get-text-property (point) 'face)) - (height (or (and (consp old) - (plist-get old :height)) - 1.0)) - (inhibit-read-only t)) - (with-silent-modifications - (if (consp old) - (add-text-properties - (point) (1+ (point)) - (list 'face (plist-put (copy-sequence old) :height (* height fa= ctor)) - 'rear-nonsticky t)) - (add-face-text-property (point) (1+ (point)) - (list :height (* height factor))) - (put-text-property (point) (1+ (point)) - 'rear-nonsticky t))))) + (unless (eobp) + (let* ((factor (or factor 1.1)) + (old (get-text-property (point) 'face)) + (height (or (and (consp old) + (plist-get (car old) :height)) + 1.0)) + (inhibit-read-only t)) + (with-silent-modifications + (if (consp old) + (add-text-properties + (point) (1+ (point)) + (list 'face (cons (plist-put (car old) :height (* height fact= or)) + (cdr old)) + 'rear-nonsticky t)) + (add-face-text-property (point) (1+ (point)) + (list :height (* height factor))) + (put-text-property (point) (1+ (point)) + 'rear-nonsticky t)))))) =20 ;;;###autoload (defun emoji-zoom-decrease () Robert --=20 From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 05 05:54:09 2023 Received: (at 62675) by debbugs.gnu.org; 5 Apr 2023 09:54:09 +0000 Received: from localhost ([127.0.0.1]:50919 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjzqD-0002Up-Em for submit@debbugs.gnu.org; Wed, 05 Apr 2023 05:54:09 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjzqB-0002UW-Ia for 62675@debbugs.gnu.org; Wed, 05 Apr 2023 05:54:08 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjzq5-0002nv-Uz; Wed, 05 Apr 2023 05:54:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=BwxM4z04IyxjBRnCZLsIf9UnTb4W4meFjwStcY2POYI=; b=S4PAEa+dAbdg ARZ1ifvvqK7LPcclorKD67KwmG+HBi5Y6HkZ5tLrU6yoBVRi3aICcrOkc0fOW9NZjiLiM0qcJC2JK hYcm04kbKC2BxOE0/yT1KyZSijtuyuf5i3jAlIjgMY8/OOVTIv7EoDXFvve5Wk00KWNA318PbdhsK JyYDbFnwjcsUKPs9JwCi/tnXiMBX2mWCe8kKyL8UqBK8wJ+eMFmGcnesnRituqWZ64AgOB2dTTJ0d s9Ghq6LuCmuVcjMCnupklvUKz9Wd/fxkrkYV8Mjr37Wrrv3sqCOeoVxsJJBA5AQrx3mhvBOKnW9Dv 8jGQl42BXnqJSV2ekEvv6A==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjzq4-0001mr-Bh; Wed, 05 Apr 2023 05:54:00 -0400 Date: Wed, 05 Apr 2023 12:54:27 +0300 Message-Id: <83mt3mslgs.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87ttxuhev4.fsf@gmail.com> (message from Robert Pluim on Wed, 05 Apr 2023 11:12:31 +0200) Subject: Re: bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces References: <87y1n6hj7r.fsf@gmail.com> <83v8iasonk.fsf@gnu.org> <87ttxuhev4.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62675 Cc: 62675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 62675@debbugs.gnu.org > Date: Wed, 05 Apr 2023 11:12:31 +0200 > > Eli> Please do, and thanks. We don't need to understand why some bug seems > Eli> to work, it is enough to fix the bug. > > This seems to work: Looks reasonable, thanks. Please try both with font-lock-mode ON and OFF, and in the latter case both with some non-default face at point and without. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 05 07:55:33 2023 Received: (at 62675) by debbugs.gnu.org; 5 Apr 2023 11:55:33 +0000 Received: from localhost ([127.0.0.1]:51019 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk1jh-0000RD-02 for submit@debbugs.gnu.org; Wed, 05 Apr 2023 07:55:33 -0400 Received: from mail-wm1-f52.google.com ([209.85.128.52]:45739) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk1je-0000Qw-MF for 62675@debbugs.gnu.org; Wed, 05 Apr 2023 07:55:31 -0400 Received: by mail-wm1-f52.google.com with SMTP id v6-20020a05600c470600b003f034269c96so11579118wmo.4 for <62675@debbugs.gnu.org>; Wed, 05 Apr 2023 04:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680695724; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=IAg0B3O/sOD5MFupIAMDA/y/svRC1lbezEJn3RBUAho=; b=VUJ0F4ChNzP/j4Po+hphP6Sf7jfv2BKLggkxJA7G8P3ykcBU8HUh1CmMknnyJWJoio eJisAs1C7j9FQV4lUmyq1jBTH0ThveME5qlmy1rdtD2F6zHdOF4GuOm2mAtyJ6u/eekE tP+BlnQT9xYA37d1VbvIjiUNuZWzEyavfj7oPm6NmCwbH+8Mc0h7a1CWLuMdaUKDjr6J BPd8TZQVcyTOqnZMtQhqSsxlZ5xRbtJtFfY7v2IJfNqk7zYhAM+tFYZAunhxe6i+lBZM 6i6RlP6aFjv8cuZUgGrI5DgY0IP60P6P6UFRN3nHibM4nOLGkHWYcs5FEHIMlfb+Gx+P 3qow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680695724; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IAg0B3O/sOD5MFupIAMDA/y/svRC1lbezEJn3RBUAho=; b=SxpOgkDMeihghl6jbAcLodTWOo8Uga0/FEmgcuaymqDXD7P/euzlS63TEOQTZcd58P zTCyru4WK/NHgq46rW/zFGiY0ba0bpWn1Cjp7sqSH9f6Mp0JqIBr3goA/WhIi0hOyCEB 7sRG4p7hRSSzG8tjsXc5RmmfYa9dryBylqrvpIHsEyzKIUYVM9sCocdlxqEEAOm4JHKp mbXFw8A1aDP2TW0kL/3QmmsFI1BKaf+bxlj7C+4vSuUhHpsk1C6nQqvmJtO6Kh9/oOfK ekl+bl373FkXAQkw4Iyy48HY0a+XLEsMXDr9/H9SRLDtdzEXGE6CPmGU8vUxzU3uechW 7Zpg== X-Gm-Message-State: AAQBX9cTkx0z4QNzcqwotP/Nh4CxkuvhWCpTEiOGIDMFQwg81kt0TDPd AgocQYJ92fuTxKbPaaXt1I2LZrlqtcc= X-Google-Smtp-Source: AKy350awEyFjrXMYwBehHL7Dr0YJvEfqaVmr8Bg7hWN7d12s6v1kZDoVZMoMZKjjRcAwrar6Crx/xA== X-Received: by 2002:a7b:cd0d:0:b0:3eb:42fc:fb30 with SMTP id f13-20020a7bcd0d000000b003eb42fcfb30mr4731750wmj.32.1680695724120; Wed, 05 Apr 2023 04:55:24 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id i16-20020adffc10000000b002c55ec7f661sm14924882wrr.5.2023.04.05.04.55.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 04:55:23 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces In-Reply-To: <83mt3mslgs.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Apr 2023 12:54:27 +0300") References: <87y1n6hj7r.fsf@gmail.com> <83v8iasonk.fsf@gnu.org> <87ttxuhev4.fsf@gmail.com> <83mt3mslgs.fsf@gnu.org> Date: Wed, 05 Apr 2023 13:55:22 +0200 Message-ID: <87pm8ih7bp.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62675 Cc: 62675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 05 Apr 2023 12:54:27 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 62675@debbugs.gnu.org >> Date: Wed, 05 Apr 2023 11:12:31 +0200 >> Eli> Please do, and thanks. We don't need to understand why some bug seems Eli> to work, it is enough to fix the bug. >> >> This seems to work: Eli> Looks reasonable, thanks. Please try both with font-lock-mode ON and Eli> OFF, and in the latter case both with some non-default face at point Eli> and without. Ah yes, font-lock off makes it all more complex. Tested in those 3 cases. Is this too much for emacs-29? diff --git a/lisp/international/emoji.el b/lisp/international/emoji.el index bcd4aac4f29..ff55170875e 100644 --- a/lisp/international/emoji.el +++ b/lisp/international/emoji.el @@ -708,22 +708,32 @@ emoji-zoom-increase FACTOR is the multiplication factor for the size." (interactive) (set-transient-map emoji-zoom-map t nil "Zoom with %k") - (let* ((factor (or factor 1.1)) - (old (get-text-property (point) 'face)) - (height (or (and (consp old) - (plist-get old :height)) - 1.0)) - (inhibit-read-only t)) - (with-silent-modifications - (if (consp old) - (add-text-properties - (point) (1+ (point)) - (list 'face (plist-put (copy-sequence old) :height (* height factor)) - 'rear-nonsticky t)) - (add-face-text-property (point) (1+ (point)) - (list :height (* height factor))) - (put-text-property (point) (1+ (point)) - 'rear-nonsticky t))))) + (unless (eobp) + (let* ((factor (or factor 1.1)) + (old (get-text-property (point) 'face)) + ;; The text property is either a named face, or a plist + ;; with :height, or a list starting with such a plist, + ;; followed by one or more faces. + (newheight (* (or (and (consp old) + (or (plist-get (car old) :height) + (plist-get old :height))) + 1.0) + factor)) + (inhibit-read-only t)) + (with-silent-modifications + (if (consp old) + (add-text-properties + (point) (1+ (point)) + (list 'face + (if (eq (car old) :height) + (plist-put old :height newheight) + (cons (plist-put (car old) :height newheight) + (cdr old))) + 'rear-nonsticky t)) + (add-face-text-property (point) (1+ (point)) + (list :height newheight)) + (put-text-property (point) (1+ (point)) + 'rear-nonsticky t)))))) ;;;###autoload (defun emoji-zoom-decrease () Robert -- From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 05 08:08:32 2023 Received: (at 62675) by debbugs.gnu.org; 5 Apr 2023 12:08:32 +0000 Received: from localhost ([127.0.0.1]:51025 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk1wG-0000oB-G4 for submit@debbugs.gnu.org; Wed, 05 Apr 2023 08:08:32 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59742) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk1wE-0000nx-BE for 62675@debbugs.gnu.org; Wed, 05 Apr 2023 08:08:31 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk1w8-0006eL-Rp; Wed, 05 Apr 2023 08:08:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=91/sab4frTZ9KSkNFgqkJn4kjfxMrq9ZJDWxVenhyCY=; b=N1i6nBkWR+Qv jmWwE+ZN2jcvZnMgMx9Kabh9epPHq0DlHZ17b/Chb0PVMqbSPq6lO1ZmBXALR+POlpKrd5cwB/gY/ KkZFldoqqNxlF5TQmpNA27cITlLosUyEwuLHX1kfM9fG5R/KG78QrkShmmGZhEinS+xiQ5KUh4IiT ZKkU8D8rDwPxvXn6MRKM7XIOFD0qJ+6zdMsqkfftg+Ga0bCbh0TBfCYRll7fHEwOJrokvhFOrZHXP 59lv7xse/mgLONbYzmqnH0KiskD0IaJhMMTBQlK3IVFlfw6+GhvptWU7PZd3VGJKMdZ81D37WTtG1 6sv9Gg693TsRqyxJJrWs7g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pk1w6-0008AI-Sf; Wed, 05 Apr 2023 08:08:23 -0400 Date: Wed, 05 Apr 2023 15:08:49 +0300 Message-Id: <838rf6sf8u.fsf@gnu.org> From: Eli Zaretskii To: Robert Pluim In-Reply-To: <87pm8ih7bp.fsf@gmail.com> (message from Robert Pluim on Wed, 05 Apr 2023 13:55:22 +0200) Subject: Re: bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces References: <87y1n6hj7r.fsf@gmail.com> <83v8iasonk.fsf@gnu.org> <87ttxuhev4.fsf@gmail.com> <83mt3mslgs.fsf@gnu.org> <87pm8ih7bp.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62675 Cc: 62675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Robert Pluim > Cc: 62675@debbugs.gnu.org > Date: Wed, 05 Apr 2023 13:55:22 +0200 > > Eli> Looks reasonable, thanks. Please try both with font-lock-mode ON and > Eli> OFF, and in the latter case both with some non-default face at point > Eli> and without. > > Ah yes, font-lock off makes it all more complex. Tested in those 3 > cases. Is this too much for emacs-29? Not too much, because this code is new in Emacs 29. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Apr 05 09:53:09 2023 Received: (at 62675) by debbugs.gnu.org; 5 Apr 2023 13:53:09 +0000 Received: from localhost ([127.0.0.1]:51751 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk3ZV-0004Ap-6R for submit@debbugs.gnu.org; Wed, 05 Apr 2023 09:53:09 -0400 Received: from mail-wr1-f44.google.com ([209.85.221.44]:37770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk3ZT-0004Aa-KY for 62675@debbugs.gnu.org; Wed, 05 Apr 2023 09:53:08 -0400 Received: by mail-wr1-f44.google.com with SMTP id y14so36323557wrq.4 for <62675@debbugs.gnu.org>; Wed, 05 Apr 2023 06:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680702781; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=DfTcBcp/gGDeOo3rTgN3jR/Qs4vrIYg26vk4Mp408Mw=; b=LBzUSMmS/E/itRF4z63wkwG3QTS5ezXAv6Bap7fZUP8kaxzwTm/r3g9Hkgr2c2aGR6 +em1hJM1NM917Sm0qg/MxJvFGnbP1nKjKUN+NtTyx3i/iDQUYF/yNKENOmbzzHXXSTPW J9xN5+8DO6j3CHC1sEA1+Gx5oG4HW0WxubuHU6oKDnqP69rkltcPT73/Q0BzSc4l77kw hNwI6Vq5udBlJ8Zk9r13RWsZsfJ7rtGQPw6hSRRKg2DM7tLa6BxvHlj9Od0vsV3W9BMQ UVbqyoOPXBajvBwYnW0OshdQ0rraevoWxUNHTxGKZHTMfslFRXlHbxY8Riyo7ZiktJ0T 4/ZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680702781; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DfTcBcp/gGDeOo3rTgN3jR/Qs4vrIYg26vk4Mp408Mw=; b=P+lyzPP+wBgb3NvSgMKepfK8NSLiEBme26pHZc5KIlAC08SDGJFUQPk0G3VHZMmbFg lYU6FQE3dsoWZ8JdIUm1cmnd35gtqf4Q+cDT8AhM0dfuxD59QhJU+KjHnlNqtaGSApA4 sZd6dVFQxbQYpyoOb3x7sxwgVIZv2YN3aLaJ4SowAMqcIpbqpZgZJXgG7TcxMCJMy3oy 1FrErDNc+8R1mYI03fTMLUhoeBBVNQP+F02ePDSYPU4d9KTx0m/MDlPRH/VD0Ijbposx C24YXCuJC9S1IQC0ApvOpvQbg6dKGlbfAt/5a794/bzfNaT7SV/puVlvrRXGL5Oi39PQ 8gyA== X-Gm-Message-State: AAQBX9fKHAGFwChHybL8GpuCD9FVALZEE0jF1HVYkS7mpoSmuX4zIAOa oOIT0OsHP/ryM2Tw7ncqKWeEsk73B3o= X-Google-Smtp-Source: AKy350Y2R1+IZ/r2aPC3Axc6JfEMcZzvwRWmSUyhWLJCu9mrJ2qJfkgKKlf9B5nvGZoNB0RFnA69Tw== X-Received: by 2002:adf:e352:0:b0:2cf:ef5d:4ee7 with SMTP id n18-20020adfe352000000b002cfef5d4ee7mr3831944wrj.69.1680702781377; Wed, 05 Apr 2023 06:53:01 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id f14-20020adff58e000000b002e52dfb9256sm15154562wro.41.2023.04.05.06.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Apr 2023 06:53:00 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces In-Reply-To: <838rf6sf8u.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 05 Apr 2023 15:08:49 +0300") References: <87y1n6hj7r.fsf@gmail.com> <83v8iasonk.fsf@gnu.org> <87ttxuhev4.fsf@gmail.com> <83mt3mslgs.fsf@gnu.org> <87pm8ih7bp.fsf@gmail.com> <838rf6sf8u.fsf@gnu.org> Date: Wed, 05 Apr 2023 15:53:00 +0200 Message-ID: <87edoyh1vn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62675 Cc: 62675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Wed, 05 Apr 2023 15:08:49 +0300, Eli Zaretskii said: >> From: Robert Pluim >> Cc: 62675@debbugs.gnu.org >> Date: Wed, 05 Apr 2023 13:55:22 +0200 >> Eli> Looks reasonable, thanks. Please try both with font-lock-mode ON and Eli> OFF, and in the latter case both with some non-default face at point Eli> and without. >> >> Ah yes, font-lock off makes it all more complex. Tested in those 3 >> cases. Is this too much for emacs-29? Eli> Not too much, because this code is new in Emacs 29. OK. I guess that means I can add `emoji-zoom-reset' and fix the increase/decrease assymetry there as well. Robert -- From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 07:39:14 2023 Received: (at 62675) by debbugs.gnu.org; 6 Apr 2023 11:39:14 +0000 Received: from localhost ([127.0.0.1]:53576 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkNxR-0004PI-Ri for submit@debbugs.gnu.org; Thu, 06 Apr 2023 07:39:14 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:38641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkNxM-0004Ox-AN; Thu, 06 Apr 2023 07:39:12 -0400 Received: by mail-wr1-f50.google.com with SMTP id q19so36131731wrc.5; Thu, 06 Apr 2023 04:39:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680781142; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=0ygMSiF9AxVR3jYC2TTBF/pmq4kFdzEHfYyVokRBiwA=; b=b6rTdQabbul5qTAkSGmN5NqmWhYZS2hnlqg2n6/Z8hdEeMuOiPZJmiWW1v6ZZyb+s8 o2EzmdAj2ibcp42F4TKj0MndFYuRhwHgzwUsNPW9Dhn4LuyowvwnF59KSA4DN1B5rdIb 0a0vx61jX56EWvBGTPFVF1syLhIE5lquB+o7wyJ8xpfiFj0etVEaS5x0k/9mw5dUkJRc Jpq3wiub3t/gjVBwgMxaJqjPuLyGCsPd0TU7tLGmYAT+rGgNqYD+vMXJaYZAqax5FyE9 piDIRZbmKvWQSIGJOWIUfQHGZRj4PALP89oA8q1FbrEnVtVAtS1i61u1wkXoQFzVSO63 EacQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680781142; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ygMSiF9AxVR3jYC2TTBF/pmq4kFdzEHfYyVokRBiwA=; b=Za+qGKHKwKBtGV3sugVD/8UBYB+4HmnfWZtuIHFGyWo2HMxekSqk+oGq1oTDEG47R/ 0vTgLMmQHeQ6rAb+AM8kJBDN/8iX3I0iW0zkeQl5JuuvhRr6YlnNzTET829HNN+eale1 cUXsjepVGXZXcg9TDURU8g1vBijGUI+wl2D0n7q/5y6ay1XssI2RGkxD553p7lbUbmCN KTH9EIGgP3yLVtKr2C7Bj22VONVvyB1zqnxxHLyMdRiEDbPk+KK9oqz/5EjPpK2wyswX tlnm0Ig1/JOWOwuscBcf8bHN0uSVad1pfdCjPjNTwozILBbT+i2Y7r0Jguhc+UXMszPg /JJQ== X-Gm-Message-State: AAQBX9dl1df5Sf31PkpKqzy7KHWpirBtD4zm4iP95muaHp6KiqZgPRxQ emA5WC+ADvIRLwB8VYKiIBBQnn+ITkU= X-Google-Smtp-Source: AKy350Z8a7i/HQV1S2S1wDxZF44cF6n8OGVTx5WcxlYA6pd0MmKQJ4diayFxzjocofU/Nx5o1wq2xg== X-Received: by 2002:a5d:45c4:0:b0:2d2:5396:ad98 with SMTP id b4-20020a5d45c4000000b002d25396ad98mr6245560wrs.21.1680781141890; Thu, 06 Apr 2023 04:39:01 -0700 (PDT) Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id y8-20020adfe6c8000000b002c559843748sm1584939wrm.10.2023.04.06.04.39.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 04:39:01 -0700 (PDT) From: Robert Pluim To: Eli Zaretskii Subject: Re: bug#62675: 29.0.60; emoji-zoom-increase interacts badly with faces In-Reply-To: <87edoyh1vn.fsf@gmail.com> (Robert Pluim's message of "Wed, 05 Apr 2023 15:53:00 +0200") References: <87y1n6hj7r.fsf@gmail.com> <83v8iasonk.fsf@gnu.org> <87ttxuhev4.fsf@gmail.com> <83mt3mslgs.fsf@gnu.org> <87pm8ih7bp.fsf@gmail.com> <838rf6sf8u.fsf@gnu.org> <87edoyh1vn.fsf@gmail.com> Date: Thu, 06 Apr 2023 13:38:58 +0200 Message-ID: <87a5zlgrzh.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62675 Cc: 62675@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 62675 fixed close 62675 29.1 quit >>>>> On Wed, 05 Apr 2023 15:53:00 +0200, Robert Pluim s= aid: >>>>> On Wed, 05 Apr 2023 15:08:49 +0300, Eli Zaretskii said: >>> From: Robert Pluim >>> Cc: 62675@debbugs.gnu.org >>> Date: Wed, 05 Apr 2023 13:55:22 +0200 >>>=20 Eli> Looks reasonable, thanks. Please try both with font-lock-mode ON = and Eli> OFF, and in the latter case both with some non-default face at poi= nt Eli> and without. >>>=20 >>> Ah yes, font-lock off makes it all more complex. Tested in those 3 >>> cases. Is this too much for emacs-29? Eli> Not too much, because this code is new in Emacs 29. Robert> OK. I guess that means I can add `emoji-zoom-reset' and fix the Robert> increase/decrease assymetry there as well. I=CA=BCve added `emoji-zoom-reset' as well as fixing this bug. Closing. Committed as 470d269ec1f Robert --=20 From unknown Sun Jun 22 04:37:20 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 May 2023 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator