GNU bug report logs - #62653
[PATCH] gnu: emacs-eat: Patch ncurses tic executable.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62653: closed ([PATCH] gnu: emacs-eat: Patch ncurses tic
 executable.)
Date: Tue, 04 Apr 2023 20:19:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 04 Apr 2023 22:18:14 +0200
with message-id <871qkzo0zd.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
has caused the debbugs.gnu.org bug report #62653,
regarding [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62653: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62653
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>, Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Subject: [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
Date: Mon,  3 Apr 2023 14:49:24 -0500

* gnu/packages/emacs-xyz.scm (arguments): Patch tic executable.
---

Reading the code now I found that there's a function that makes a call
to tic from the ncurses package so I patched it.

all best,

jgart

 gnu/packages/emacs-xyz.scm | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index b4edc680ba..9db8a07331 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -27981,7 +27981,14 @@ (define-public emacs-eat
               (invoke "make" "info")))
           (add-before 'install 'build-terminfo-database
             (lambda _
-              (invoke "make" "terminfo"))))))
+              (invoke "make" "terminfo")))
+          (add-before 'install 'patch-ncurses-tic-executable
+            (lambda* (#:key inputs #:allow-other-keys)
+              (substitute*
+                "eat.el"
+                (("\"tic")
+                 (string-append "\""
+                                (search-input-file inputs "/bin/tic")))))))))
     (native-inputs
      (list ncurses texinfo))
     (home-page "https://codeberg.org/akib/emacs-eat")
-- 
2.39.2

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: 62653-done <at> debbugs.gnu.org, jgart <jgart <at> dismail.de>
Subject: Re: [bug#62653] [PATCH] gnu: emacs-eat: Patch ncurses tic executable.
Date: Tue, 04 Apr 2023 22:18:14 +0200

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (arguments): Patch tic executable.
> ---
>
> Reading the code now I found that there's a function that makes a call
> to tic from the ncurses package so I patched it.

Good catch!

I also moved ncurses into inputs, otherwise the executable could
be GC'ed at some point.

Applied. Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.