From unknown Sun Aug 17 10:26:04 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#62646] [PATCH core-updates] gnu: librsvg-2.40: Fix test failure with Pango 1.50. Resent-From: Kaelyn Takata Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 03 Apr 2023 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62646 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 62646@debbugs.gnu.org Cc: Kaelyn Takata X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16805399021646 (code B ref -1); Mon, 03 Apr 2023 16:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Apr 2023 16:38:22 +0000 Received: from localhost ([127.0.0.1]:45100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjNCI-0000QS-7c for submit@debbugs.gnu.org; Mon, 03 Apr 2023 12:38:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:47878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjNCG-0000QL-FR for submit@debbugs.gnu.org; Mon, 03 Apr 2023 12:38:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjNCF-0001Nj-Ud for guix-patches@gnu.org; Mon, 03 Apr 2023 12:38:20 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjNCE-0001xe-2w for guix-patches@gnu.org; Mon, 03 Apr 2023 12:38:19 -0400 Date: Mon, 03 Apr 2023 16:37:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1680539888; x=1680799088; bh=uWb8lGFgDlU5KED3y9uF7bfVw89nJTJXYolgNJJf1Cc=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=TwT2Tte36o4sYy8lhDTI1n5j4R4+96NvGnhaGG3uqYH3f53vDOeioUNJRnxh6aABh 9nxMLfH9XtbgXtj9SeG0chQSytNw9XWJ6Hkdw8edII3tF3i/O9eer9EXgAJNy5YFUX 3l/Vg3kW4aw2PA9yGFUbY2OLjUkYYz7+g0KRxSUeNXqvbFomppUFpByyszczsr5DBr M/huTHQdBUCgyo5f71d19tcnDFSbGOVScdS/t5WDSY/rXESaMchUK3tBsgJrmzIRbq BJWZRZjqMEAnHPv16hnzMAMXosjw81o3a2sidaoOpYS9QnynQQw5+ngCAGvQGTZ4o2 A82F4CI0+B18A== From: Kaelyn Takata Message-ID: <096346acd405f2df58ecf32f3b4fb687790f9a03.1680539830.git.kaelyn.alexi@protonmail.com> Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.131; envelope-from=kaelyn.alexi@protonmail.com; helo=mail-40131.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/gnome.scm (librsvg-2.40): Fix test failure with Pango 1.50. --- gnu/packages/gnome.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index e81882b181..fe5860e93f 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -3725,6 +3725,12 @@ (define-public librsvg-2.40 (("gdk_pixbuf_cache_file =3D .*$") "gdk_pixbuf_cache_file =3D $(TMPDIR)/loaders.cache\n")) #t)) + (add-before 'check 'fix-test-with-pango-1.50 + (lambda _ +=09 ;; Changes between pango 1.48 and 1.50 caused the text to be one +=09 ;; pixel lower in the output image compared to the reference. + (substitute* "tests/fixtures/reftests/bugs/587721-text-transf= orm.svg" +=09 (("660\\.9") "659.9")))) (add-before 'check 'remove-failing-tests (lambda _ (with-directory-excursion "tests/fixtures/reftests" base-commit: cebcf3533ab83233121434254a6ae7b8c35cfa1f -- 2.39.2 From unknown Sun Aug 17 10:26:04 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kaelyn Takata Subject: bug#62646: closed (Re: Fix for librsvg 2.40 on core-updates) Message-ID: References: <096346acd405f2df58ecf32f3b4fb687790f9a03.1680539830.git.kaelyn.alexi@protonmail.com> X-Gnu-PR-Message: they-closed 62646 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 62646@debbugs.gnu.org Date: Sat, 08 Apr 2023 09:53:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1680947582-25232-1" This is a multi-part message in MIME format... ------------=_1680947582-25232-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #62646: [PATCH core-updates] gnu: librsvg-2.40: Fix test failure with Pango= 1.50. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 62646@debbugs.gnu.org. --=20 62646: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62646 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1680947582-25232-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 62646-done) by debbugs.gnu.org; 8 Apr 2023 09:52:39 +0000 Received: from localhost ([127.0.0.1]:57753 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl5FP-0006YN-53 for submit@debbugs.gnu.org; Sat, 08 Apr 2023 05:52:39 -0400 Received: from hera.aquilenet.fr ([185.233.100.1]:59958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl5FN-0006Y6-Gk for 62646-done@debbugs.gnu.org; Sat, 08 Apr 2023 05:52:38 -0400 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id A8EA2635; Sat, 8 Apr 2023 11:52:31 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at hera.aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id QJcY0VT8Olj2; Sat, 8 Apr 2023 11:52:31 +0200 (CEST) Received: from jurong (unknown [IPv6:2001:861:c4:f2f0::c64]) by hera.aquilenet.fr (Postfix) with ESMTPSA id CF5DC5C4; Sat, 8 Apr 2023 11:52:30 +0200 (CEST) Date: Sat, 8 Apr 2023 11:52:29 +0200 From: Andreas Enge To: Kaelyn Subject: Re: Fix for librsvg 2.40 on core-updates Message-ID: References: <-yuU5lP0atxOfIH2n0tY_JcRohzhb2HtmCj8owCxLEvkaOKSIx8nebEwIarFeEZ0Tab2HOVv_zNjWsa9fFNy8Rs7QU0RWPHIvl0FHKrSPlY=@protonmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <-yuU5lP0atxOfIH2n0tY_JcRohzhb2HtmCj8owCxLEvkaOKSIx8nebEwIarFeEZ0Tab2HOVv_zNjWsa9fFNy8Rs7QU0RWPHIvl0FHKrSPlY=@protonmail.com> X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62646-done Cc: guix-devel , 62646-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Am Fri, Apr 07, 2023 at 04:53:15PM +0000 schrieb Kaelyn: > On core-updates, librsvg-2.40 fails to compile due to a single failing test (I've confirmed the failure on x86_64 and i686, though the package is only used/needed on non-x86_64 systems for gtk+ and others; it also affects wine and wine-staging on x86_64 as they are 32-bit packages). I was able to track down the test failure to a text rendering difference between Pango 1.48 and 1.50, which led to the text being one pixel line higher between the reference and output images. On Monday I submitted https://issues.guix.gnu.org/62646 which adds a phase to librsvg-2.40 to adjust the output Y coordinate of the SVG transformation matrix by one for the failing test so that it passes with Pango 1.50. thanks a lot, I added a copyright line for you and pushed. Wine still fails to build due to autogen not building on i686: libtool: compile: gcc -DHAVE_CONFIG_H -I. -I.. -I.. -I../autoopts -DPKGDATADIR=\"/gnu/store/6i60j0fxdsg4qwymas4ymfqlv1azidnc-autogen-5.18.16/share/autogen\" -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -Wall -Werror -Wcast-align -Wmissing-prototypes -Wpointer-arith -Wshadow -Wstrict-prototypes -Wwrite-strings -Wstrict-aliasing=3 -Wextra -Wno-cast-qual -g -O2 -Wno-format-contains-nul -fno-strict-aliasing -c libopts.c -fPIC -DPIC -o .libs/libopts_la-libopts.o In file included from libopts.c:48: usage.c: In function ‘prt_extd_usage.isra’: usage.c:736:38: error: ‘s ’ directive output may be truncated writing 2 bytes into a region of size between 0 and 9 [-Werror=format-truncation=] 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); | ^~~~~~~ usage.c:736:9: note: ‘snprintf’ output between 9 and 18 bytes into a destination of size 12 736 | snprintf(vfmt, sizeof(vfmt), vfmtfmt, (unsigned int)nmlen + 4); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Just in case you wish to continue investigating :) Andreas ------------=_1680947582-25232-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Apr 2023 16:38:22 +0000 Received: from localhost ([127.0.0.1]:45100 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjNCI-0000QS-7c for submit@debbugs.gnu.org; Mon, 03 Apr 2023 12:38:22 -0400 Received: from lists.gnu.org ([209.51.188.17]:47878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjNCG-0000QL-FR for submit@debbugs.gnu.org; Mon, 03 Apr 2023 12:38:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjNCF-0001Nj-Ud for guix-patches@gnu.org; Mon, 03 Apr 2023 12:38:20 -0400 Received: from mail-40131.protonmail.ch ([185.70.40.131]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pjNCE-0001xe-2w for guix-patches@gnu.org; Mon, 03 Apr 2023 12:38:19 -0400 Date: Mon, 03 Apr 2023 16:37:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1680539888; x=1680799088; bh=uWb8lGFgDlU5KED3y9uF7bfVw89nJTJXYolgNJJf1Cc=; h=Date:To:From:Cc:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=TwT2Tte36o4sYy8lhDTI1n5j4R4+96NvGnhaGG3uqYH3f53vDOeioUNJRnxh6aABh 9nxMLfH9XtbgXtj9SeG0chQSytNw9XWJ6Hkdw8edII3tF3i/O9eer9EXgAJNy5YFUX 3l/Vg3kW4aw2PA9yGFUbY2OLjUkYYz7+g0KRxSUeNXqvbFomppUFpByyszczsr5DBr M/huTHQdBUCgyo5f71d19tcnDFSbGOVScdS/t5WDSY/rXESaMchUK3tBsgJrmzIRbq BJWZRZjqMEAnHPv16hnzMAMXosjw81o3a2sidaoOpYS9QnynQQw5+ngCAGvQGTZ4o2 A82F4CI0+B18A== To: guix-patches@gnu.org From: Kaelyn Takata Subject: [PATCH core-updates] gnu: librsvg-2.40: Fix test failure with Pango 1.50. Message-ID: <096346acd405f2df58ecf32f3b4fb687790f9a03.1680539830.git.kaelyn.alexi@protonmail.com> Feedback-ID: 34709329:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=185.70.40.131; envelope-from=kaelyn.alexi@protonmail.com; helo=mail-40131.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Kaelyn Takata X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/gnome.scm (librsvg-2.40): Fix test failure with Pango 1.50. --- gnu/packages/gnome.scm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/gnu/packages/gnome.scm b/gnu/packages/gnome.scm index e81882b181..fe5860e93f 100644 --- a/gnu/packages/gnome.scm +++ b/gnu/packages/gnome.scm @@ -3725,6 +3725,12 @@ (define-public librsvg-2.40 (("gdk_pixbuf_cache_file =3D .*$") "gdk_pixbuf_cache_file =3D $(TMPDIR)/loaders.cache\n")) #t)) + (add-before 'check 'fix-test-with-pango-1.50 + (lambda _ +=09 ;; Changes between pango 1.48 and 1.50 caused the text to be one +=09 ;; pixel lower in the output image compared to the reference. + (substitute* "tests/fixtures/reftests/bugs/587721-text-transf= orm.svg" +=09 (("660\\.9") "659.9")))) (add-before 'check 'remove-failing-tests (lambda _ (with-directory-excursion "tests/fixtures/reftests" base-commit: cebcf3533ab83233121434254a6ae7b8c35cfa1f -- 2.39.2 ------------=_1680947582-25232-1--