GNU bug report logs - #62640
[PATCH] gnu: Add pmbootstrap.

Previous Next

Full log

Message #17 received at 62640 <at> debbugs.gnu.org (full text, mbox):

From: Herman Rimm <herman <at> rimm.ee>
To: André Batista <nandre <at> riseup.net>
Cc: Sughosha <Sughosha <at> proton.me>, 62640 <at> debbugs.gnu.org
Subject: Re: [bug#62640] [PATCH v3] gnu: Add pmbootstrap.
Date: Sat, 24 May 2025 14:59:48 +0200

Hi,

On Fri, May 23, 2025 at 03:41:18PM -0300, Andr� Batista wrote:
> > diff --git a/gnu/local.mk b/gnu/local.mk
> > index 3730d272eae..c4d5e6cb2e4 100644
> > --- a/gnu/local.mk
> > +++ b/gnu/local.mk
> > @@ -566,7 +566,8 @@ GNU_SYSTEM_MODULES =				\
> >    %D%/packages/poedit.scm				\
> >    %D%/packages/polkit.scm			\
> >    %D%/packages/popt.scm				\
> > -  %D%/packages/potassco.scm				\
> > +  %D%/packages/postmarketos.scm			\
> > +  %D%/packages/potassco.scm			\
> 
> IMO, it would be better if you did not touch the potassco.scm line, since
> this format change is unrelated to this commit.
> 
> > +(define-public pmbootstrap
> > +  (package
> > +    (name "pmbootstrap")
> > +    (version "3.4.0")
> > +    (source
> > +     (origin
> > +       (method git-fetch)
> > +       (uri (git-reference
> > +              (url (string-append "https://gitlab.postmarketos.org/"
> > +                                  "postmarketOS/pmbootstrap"))
> > +              (commit version)))
> 
> 'origin' is missing a file-name field which usually goes:
>  (file-name (git-file-name name version))

Thanks, I will make the appropriate changes for the next revision.  I
will also add a wrap phase so pmbootstrap can find the inputs' binaries.

> > +       (sha256
> > +        (base32 "16naj8ykipbrs2a93zaxci1wl045cc9jn7rq8sy76d1rqlqb9mmw"))))
> > +    (build-system pyproject-build-system)
> > +    (arguments
> > +     (list #:test-flags
> > +           ;; Tests require a pmaports git repository in the workdir.
> > +           #~(list (string-append "--deselect=test/core/test_pkgrepo.py"
> > +                                  "::test_pkgrepo_pmaports")
> 
> This is a nitpick of mine, but I find it confusing when keys starting
> with '#' are followed by their arguments on another aligned line which
> also starts with '#' (a gexp this time, not another key). So, I'd suggest
> indenting the arguments with two spaces to ease reading.

Like this?

(arguments
 (list #:test-flags
         ;; Tests require a pmaports git repository in the workdir.
         #~(list (string-append "--deselect=test/core/test_pkgrepo.py"
                                ...))))

I would rather do it like this:

(arguments
 (list
   ;; The first two tests require a pmaports git repository in the workdir.
   #:test-flags #~(list (string-append "--deselect=test/core/test_pkgrepo"
                                       ...))))

> Also, I would also have inserted this package directly on android.scm,
> since this tool is useful for android related activities and it seems
> overkill to create a new file for just one package.

Besides handling the Android bootimg format, I don't think pmbootstrap
is Android related.  Yes, the only other major PostmarketOS project is
pmaports, but I don't think there is an existing module where
pmbootstrap belongs.  Should it be a more general module like: (gnu
packages smartphone)?

Can you please close or merge issue #49577, because the PyPi pmbootstrap
releases are apparently deprecated?

Cheers,
Herman

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.