From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 14:49:53 2023 Received: (at submit) by debbugs.gnu.org; 2 Apr 2023 18:49:53 +0000 Received: from localhost ([127.0.0.1]:42661 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj2m0-0007OL-59 for submit@debbugs.gnu.org; Sun, 02 Apr 2023 14:49:53 -0400 Received: from lists.gnu.org ([209.51.188.17]:35188) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj2lx-0007OB-FU for submit@debbugs.gnu.org; Sun, 02 Apr 2023 14:49:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj2lw-0001pB-AC for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 14:49:48 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj2ls-0007Xm-Mt for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 14:49:47 -0400 From: Spencer Baugh To: bug-gnu-emacs@gnu.org Subject: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] Date: Sun, 02 Apr 2023 14:49:41 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=64.215.233.18; envelope-from=sbaugh@janestreet.com; helo=mxout5.mail.janestreet.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) 1. emacs -Q 2. C-h k and in the menu bar, click on "Edit", then "Paste from Kill Menu", then "(any string)". 3. See error printed in *Messages*: event-basic-type: Wrong type argument: integer-or-marker-p, "(any string)" 4. Type "foobar" and kill it 5. C-h k and in the menu bar, click on "Edit", then "Paste from Kill Menu", then "foobar". 6. See error printed in *Messages*: event-basic-type: Wrong type argument: integer-or-marker-p, #("foobar" 0 6 (fontified t)) This happens on both Emacs 28 and Emacs 29. It looks like this is happening because help--read-key-sequence calls event-basic-type on the last element of the key sequence returned from read-key-sequence, which in this case is a string. The following patch fixes it (that is, makes describe-key complete successfully and show appropriate help), but I'm not sure if it's right. diff --git a/lisp/help.el b/lisp/help.el index 83be85b1ee4..73ac793f4aa 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1021,8 +1021,8 @@ help--read-key-sequence (raw-seq (this-single-command-raw-keys)) (keyn (when (> (length seq) 0) (aref seq (1- (length seq))))) - (base (event-basic-type keyn)) - (modifiers (event-modifiers keyn))) + (base (and (integer-or-marker-p keyn) (event-basic-type keyn))) + (modifiers (and (integer-or-marker-p keyn) (event-modifiers keyn)))) (cond ((zerop (length seq))) ;FIXME: Can this happen? ((and no-mouse-movement (eq base 'mouse-movement)) nil) -- In GNU Emacs 29.0.60 (build 3, x86_64-pc-linux-gnu, X toolkit, cairo version 1.15.12, Xaw scroll bars) of 2023-03-13 built on igm-qws-u22796a Repository revision: e759905d2e0828eac4c8164b09113b40f6899656 Repository branch: emacs-29 Windowing system distributor 'The X.Org Foundation', version 11.0.12011000 System Description: CentOS Linux 7 (Core) Configured using: 'configure --with-x-toolkit=lucid --with-modules --with-gif=ifavailable' Configured features: CAIRO DBUS FREETYPE GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: bug-reference-prog-mode: t jane-fe-minor-mode: t editorconfig-mode: t which-function-mode: t global-git-commit-mode: t magit-auto-revert-mode: t auto-revert-mode: t shell-dirtrack-mode: t windmove-mode: t savehist-mode: t save-place-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tab-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t context-menu-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/csharp-mode hides /home/sbaugh/.local/src/emacs29/lisp/progmodes/csharp-mode /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/eldoc hides /home/sbaugh/.local/src/emacs29/lisp/emacs-lisp/eldoc /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/auctex/lpath hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/dictionary/lpath /home/sbaugh/.local/src/emacs29/lisp/net/dictionary hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/dictionary/dictionary /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/caml-font hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/ocaml/caml-font /home/sbaugh/.local/src/emacs29/lisp/org/org-version hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-version /home/sbaugh/.local/src/emacs29/lisp/org/org-loaddefs hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-loaddefs /home/sbaugh/.local/src/emacs29/lisp/org/org-keys hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-keys /home/sbaugh/.local/src/emacs29/lisp/org/ol hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol /home/sbaugh/.local/src/emacs29/lisp/org/ob-perl hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-perl /home/sbaugh/.local/src/emacs29/lisp/org/ob-core hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-core /home/sbaugh/.local/src/emacs29/lisp/org/ox hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox /home/sbaugh/.local/src/emacs29/lisp/org/ol-rmail hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-rmail /home/sbaugh/.local/src/emacs29/lisp/org/ob-octave hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-octave /home/sbaugh/.local/src/emacs29/lisp/org/ob-comint hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-comint /home/sbaugh/.local/src/emacs29/lisp/org/ol-w3m hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-w3m /home/sbaugh/.local/src/emacs29/lisp/org/ob-org hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-org /home/sbaugh/.local/src/emacs29/lisp/org/ox-texinfo hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-texinfo /home/sbaugh/.local/src/emacs29/lisp/org/org-inlinetask hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-inlinetask /home/sbaugh/.local/src/emacs29/lisp/org/ol-mhe hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-mhe /home/sbaugh/.local/src/emacs29/lisp/org/ob-ocaml hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-ocaml /home/sbaugh/.local/src/emacs29/lisp/org/ob-clojure hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-clojure /home/sbaugh/.local/src/emacs29/lisp/org/ox-publish hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-publish /home/sbaugh/.local/src/emacs29/lisp/org/ol-irc hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-irc /home/sbaugh/.local/src/emacs29/lisp/org/ob-calc hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-calc /home/sbaugh/.local/src/emacs29/lisp/org/ox-odt hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-odt /home/sbaugh/.local/src/emacs29/lisp/org/org-id hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-id /home/sbaugh/.local/src/emacs29/lisp/org/ol-gnus hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-gnus /home/sbaugh/.local/src/emacs29/lisp/org/ob-matlab hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-matlab /home/sbaugh/.local/src/emacs29/lisp/org/ox-icalendar hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-icalendar /home/sbaugh/.local/src/emacs29/lisp/org/org-footnote hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-footnote /home/sbaugh/.local/src/emacs29/lisp/org/ol-bibtex hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-bibtex /home/sbaugh/.local/src/emacs29/lisp/org/ob-lisp hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-lisp /home/sbaugh/.local/src/emacs29/lisp/org/ob-C hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-C /home/sbaugh/.local/src/emacs29/lisp/org/ox-org hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-org /home/sbaugh/.local/src/emacs29/lisp/org/org-indent hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-indent /home/sbaugh/.local/src/emacs29/lisp/org/ol-info hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-info /home/sbaugh/.local/src/emacs29/lisp/org/ob-maxima hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-maxima /home/sbaugh/.local/src/emacs29/lisp/org/ob-awk hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-awk /home/sbaugh/.local/src/emacs29/lisp/org/ox-man hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-man /home/sbaugh/.local/src/emacs29/lisp/org/org-goto hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-goto /home/sbaugh/.local/src/emacs29/lisp/org/ox-md hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-md /home/sbaugh/.local/src/emacs29/lisp/org/ol-eshell hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-eshell /home/sbaugh/.local/src/emacs29/lisp/org/ob-lua hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-lua /home/sbaugh/.local/src/emacs29/lisp/org/org-habit hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-habit /home/sbaugh/.local/src/emacs29/lisp/org/ob-R hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-R /home/sbaugh/.local/src/emacs29/lisp/org/ol-eww hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-eww /home/sbaugh/.local/src/emacs29/lisp/org/ob-makefile hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-makefile /home/sbaugh/.local/src/emacs29/lisp/org/ox-latex hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-latex /home/sbaugh/.local/src/emacs29/lisp/org/ol-docview hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-docview /home/sbaugh/.local/src/emacs29/lisp/org/ob-lob hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-lob /home/sbaugh/.local/src/emacs29/lisp/org/ox-beamer hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-beamer /home/sbaugh/.local/src/emacs29/lisp/org/org-faces hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-faces /home/sbaugh/.local/src/emacs29/lisp/org/ob hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob /home/sbaugh/.local/src/emacs29/lisp/org/ox-html hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-html /home/sbaugh/.local/src/emacs29/lisp/org/org-feed hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-feed /home/sbaugh/.local/src/emacs29/lisp/org/ol-bbdb hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ol-bbdb /home/sbaugh/.local/src/emacs29/lisp/org/ob-lilypond hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-lilypond /home/sbaugh/.local/src/emacs29/lisp/org/ox-ascii hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ox-ascii /home/sbaugh/.local/src/emacs29/lisp/org/ob-latex hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-latex /home/sbaugh/.local/src/emacs29/lisp/org/org hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org /home/sbaugh/.local/src/emacs29/lisp/org/ob-tangle hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-tangle /home/sbaugh/.local/src/emacs29/lisp/org/org-tempo hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-tempo /home/sbaugh/.local/src/emacs29/lisp/org/org-duration hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-duration /home/sbaugh/.local/src/emacs29/lisp/org/ob-sqlite hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-sqlite /home/sbaugh/.local/src/emacs29/lisp/org/org-entities hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-entities /home/sbaugh/.local/src/emacs29/lisp/org/ob-table hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-table /home/sbaugh/.local/src/emacs29/lisp/org/ob-js hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-js /home/sbaugh/.local/src/emacs29/lisp/org/org-table hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-table /home/sbaugh/.local/src/emacs29/lisp/org/ob-sql hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-sql /home/sbaugh/.local/src/emacs29/lisp/org/org-timer hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-timer /home/sbaugh/.local/src/emacs29/lisp/org/org-element hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-element /home/sbaugh/.local/src/emacs29/lisp/org/ob-java hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-java /home/sbaugh/.local/src/emacs29/lisp/org/org-ctags hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-ctags /home/sbaugh/.local/src/emacs29/lisp/org/ob-shell hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-shell /home/sbaugh/.local/src/emacs29/lisp/org/ob-groovy hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-groovy /home/sbaugh/.local/src/emacs29/lisp/org/org-src hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-src /home/sbaugh/.local/src/emacs29/lisp/org/org-datetree hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-datetree /home/sbaugh/.local/src/emacs29/lisp/org/ob-haskell hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-haskell /home/sbaugh/.local/src/emacs29/lisp/org/org-plot hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-plot /home/sbaugh/.local/src/emacs29/lisp/org/org-compat hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-compat /home/sbaugh/.local/src/emacs29/lisp/org/ob-screen hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-screen /home/sbaugh/.local/src/emacs29/lisp/org/ob-fortran hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-fortran /home/sbaugh/.local/src/emacs29/lisp/org/org-protocol hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-protocol /home/sbaugh/.local/src/emacs29/lisp/org/org-crypt hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-crypt /home/sbaugh/.local/src/emacs29/lisp/org/ob-sed hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-sed /home/sbaugh/.local/src/emacs29/lisp/org/ob-gnuplot hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-gnuplot /home/sbaugh/.local/src/emacs29/lisp/org/org-pcomplete hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-pcomplete /home/sbaugh/.local/src/emacs29/lisp/org/org-colview hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-colview /home/sbaugh/.local/src/emacs29/lisp/org/ob-scheme hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-scheme /home/sbaugh/.local/src/emacs29/lisp/org/ob-forth hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-forth /home/sbaugh/.local/src/emacs29/lisp/org/org-num hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-num /home/sbaugh/.local/src/emacs29/lisp/org/org-clock hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-clock /home/sbaugh/.local/src/emacs29/lisp/org/ob-exp hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-exp /home/sbaugh/.local/src/emacs29/lisp/org/org-mouse hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-mouse /home/sbaugh/.local/src/emacs29/lisp/org/org-capture hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-capture /home/sbaugh/.local/src/emacs29/lisp/org/ob-sass hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-sass /home/sbaugh/.local/src/emacs29/lisp/org/ob-eval hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-eval /home/sbaugh/.local/src/emacs29/lisp/org/ob-ref hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-ref /home/sbaugh/.local/src/emacs29/lisp/org/ob-emacs-lisp hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-emacs-lisp /home/sbaugh/.local/src/emacs29/lisp/org/org-mobile hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-mobile /home/sbaugh/.local/src/emacs29/lisp/org/ob-ruby hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-ruby /home/sbaugh/.local/src/emacs29/lisp/org/ob-eshell hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-eshell /home/sbaugh/.local/src/emacs29/lisp/org/org-lint hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-lint /home/sbaugh/.local/src/emacs29/lisp/org/org-agenda hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-agenda /home/sbaugh/.local/src/emacs29/lisp/org/org-macro hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-macro /home/sbaugh/.local/src/emacs29/lisp/org/org-attach-git hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-attach-git /home/sbaugh/.local/src/emacs29/lisp/org/ob-processing hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-processing /home/sbaugh/.local/src/emacs29/lisp/org/ob-css hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-css /home/sbaugh/.local/src/emacs29/lisp/org/ob-dot hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-dot /home/sbaugh/.local/src/emacs29/lisp/org/org-list hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-list /home/sbaugh/.local/src/emacs29/lisp/org/org-macs hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-macs /home/sbaugh/.local/src/emacs29/lisp/org/org-attach hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-attach /home/sbaugh/.local/src/emacs29/lisp/org/org-archive hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/org-archive /home/sbaugh/.local/src/emacs29/lisp/org/ob-python hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-python /home/sbaugh/.local/src/emacs29/lisp/org/ob-plantuml hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-plantuml /home/sbaugh/.local/src/emacs29/lisp/org/ob-ditaa hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/lisp/ob-ditaa /home/sbaugh/.local/src/emacs29/lisp/org/ob-julia hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/contrib/lisp/ob-julia /home/sbaugh/.local/src/emacs29/lisp/org/ol-man hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/contrib/lisp/ol-man /home/sbaugh/.local/src/emacs29/lisp/org/ox-koma-letter hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/org/contrib/lisp/ox-koma-letter /home/sbaugh/.emacs.d/elpa/dash-2.19.1/dash hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/dash/dash /home/sbaugh/.emacs.d/elpa/dash-2.19.1/dash-functional hides /usr/local/home/sbaugh/workspaces/fe-47828/+share+/app/emacs/elisp/contrib/dash/dash-functional Features: (quail emacs-news-mode descr-text magit-imenu git-rebase etags repeat fileloop etrace elp two-column sml-mode sml-move sml-defs sml-util sml-compat org-datetree completion diary-lib diary-loaddefs cal-iso cal-move mule-diag ispell reveal semantic/symref/grep semantic/symref semantic/util-modes semantic/util semantic semantic/tag semantic/lex semantic/fw mode-local cedet reposition pulse mule-util ibuffer ibuffer-loaddefs timezone face-remap url-http-ntlm ntlm hmac-md5 hex-util md4 man em-unix em-term term disp-table ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-extpipe em-cmpl em-dirs esh-var em-basic em-banner em-alias esh-mode eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util make-mode pcmpl-unix pcmpl-gnu rect cus-edit cus-start cus-load finder lisp-mnt url-misc network-stream url-cache debbugs-gnu debbugs-compat debbugs soap-client url-http url-gw nsm rng-xsd xsd-regexp textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check shadow mail-extr emacsbug sql tabify oc-basic org-capture shortdoc dabbrev misc ob-ditaa ob-plantuml org-clock org-colview org-crypt org-ctags org-habit org-mouse org-plot org-protocol ox-odt rng-loc rng-uri rng-parse rng-match rng-dt rng-util rng-pttrn nxml-parse nxml-ns nxml-enc xmltok nxml-util ox-latex ox-icalendar org-agenda ox-html table ox-ascii ox-publish ox org-element org-persist org-id org-refile avl-tree generator cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs novice vc-hg sort ol-eww eww xdg url-queue mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range gnus-win gnus nnheader range wid-edit ol-docview doc-view jka-compr image-mode exif ol-bibtex bibtex ol-bbdb ol-w3m ol-doi org-link-doi log-view vc-git vc vc-dispatcher texinfo texinfo-loaddefs misearch multi-isearch bug-reference dired-aux sh-script treesit hl-line display-line-numbers executable cl-print help-fns radix-tree find-dired goto-addr tramp tramp-loaddefs trampver tramp-integration files-x tramp-compat parse-time iso8601 ls-lisp jane-project jane-merlin merlin-imenu merlin-xref xref merlin-cap merlin jane-async-merlin jane-completion jane-common jane-fe-menu ecaml_plugin linum view gopcaml magit-bookmark bookmark image+ advice image-file image-converter editorconfig editorconfig-core editorconfig-core-handle editorconfig-fnmatch whitespace jane-auto-modes vba-mode markdown-mode color jane jane-micro-features grep jane-diff unified-test-mode shell-file core core-buffer core-error core-util ert pp ewoc debug backtrace jane-sexp jane-ocaml jane-tuareg-theme tuareg tuareg-compat tuareg-opam skeleton flymake-proc flymake warnings smie caml-types caml-help caml-emacs find-file compile jane-cr jane-align jane-deprecated jane-smerge gnu-elpa-keyring-update jane-ocp-indent ocp-indent cl jane-util page-ext dired-x magit-extras project magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff diff-mode git-commit log-edit message sendmail yank-media puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 mm-util ietf-drums mail-prsvr mailabbrev mail-utils gmm-utils mailheader pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor shell server magit-mode transient edmacro kmacro magit-git magit-section magit-utils crm dash cl-extra help-mode windmove org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-src ob-comint org-pcomplete pcomplete org-list org-footnote org-faces org-entities time-date noutline outline icons ob-emacs-lisp ob-core ob-eval org-cycle org-table ol rx org-fold org-fold-core org-keys oc org-loaddefs find-func cal-menu calendar cal-loaddefs org-version org-compat org-macs format-spec gdb-mi bindat gud easy-mmode comint ansi-osc ansi-color ring ffap thingatpt vundo pcase cyberpunk-theme savehist saveplace vundo-autoloads magit-autoloads csv-mode-autoloads magit-section-autoloads cyberpunk-theme-autoloads url-http-ntlm-autoloads url-auth git-commit-autoloads with-editor-autoloads finder-inf info dash-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile url-vars cl-loaddefs cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 2222181 268198) (symbols 48 69243 2) (strings 32 319255 34424) (string-bytes 1 12232202) (vectors 16 139420) (vector-slots 8 5377201 353952) (floats 8 669 703) (intervals 56 254854 2268) (buffers 976 402) (heap 1024 865236 188241)) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 15:07:00 2023 Received: (at 62626) by debbugs.gnu.org; 2 Apr 2023 19:07:00 +0000 Received: from localhost ([127.0.0.1]:42670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj32a-0007pp-2x for submit@debbugs.gnu.org; Sun, 02 Apr 2023 15:07:00 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:58683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj32Y-0007pa-KP for 62626@debbugs.gnu.org; Sun, 02 Apr 2023 15:06:58 -0400 From: Spencer Baugh To: 62626@debbugs.gnu.org Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] In-Reply-To: (Spencer Baugh's message of "Sun, 02 Apr 2023 14:49:41 -0400") References: Date: Sun, 02 Apr 2023 15:06:53 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62626 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Spencer Baugh writes: > 1. emacs -Q > 2. C-h k and in the menu bar, click on "Edit", then "Paste from Kill > Menu", then "(any string)". > 3. See error printed in *Messages*: > event-basic-type: Wrong type argument: integer-or-marker-p, "(any string)" describe-key is also broken with context-menu-mode in a different way, btw. It generates the help buffer fine, but the last key in the sequence is wrong. It looks like read-key-sequence returns a numeric index into the menu for that key, counting up from from the last menu entry and starting at 1, and then the help buffer is interpreting that number as a key. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 07:47:42 2023 Received: (at 62626) by debbugs.gnu.org; 6 Apr 2023 11:47:42 +0000 Received: from localhost ([127.0.0.1]:53597 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkO5d-00074T-MG for submit@debbugs.gnu.org; Thu, 06 Apr 2023 07:47:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41838) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkO5b-000743-Lw for 62626@debbugs.gnu.org; Thu, 06 Apr 2023 07:47:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkO5S-0005tr-LR; Thu, 06 Apr 2023 07:47:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=aK4IMesQ58nFdT6ouWiBRdn9o+1EeY2bcXfKubtRchs=; b=GcdJAN/o7GG/C44uNII9 iZ7OTDAO5JnrrKcDkICR4rcqYsFSjsijp6DL3EqtM+HEaakennrU7lpUykoaf92q6GRUd+ochJXEL FQrIECDQeoPrx9U2ryqQOw3cdRvzmW576GJ6uL9DDg3mLEH+Ya9ye5shvIglTtI4pNexcm7kM93Uz QJoG3kOx5P1Ta8FYNEfIbIc+OP72zakW1UO+VkhVwZQstxvDgrG05k1zSgDqI3A1A+axq4YymOOyM o6qawknWYptN4AJxTktBGtQbZaBbZ03hwbk/7WGJ9C+hxwp9hHpghepT4VGdMsq1EoQIbPPyvKXPp m8wlhmMf+FVXGQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkO5R-0001ju-OX; Thu, 06 Apr 2023 07:47:30 -0400 Date: Thu, 06 Apr 2023 14:47:58 +0300 Message-Id: <83cz4hqljl.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh , Stefan Monnier In-Reply-To: (message from Spencer Baugh on Sun, 02 Apr 2023 14:49:41 -0400) Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62626 Cc: 62626@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Date: Sun, 02 Apr 2023 14:49:41 -0400 > > > 1. emacs -Q > 2. C-h k and in the menu bar, click on "Edit", then "Paste from Kill > Menu", then "(any string)". > 3. See error printed in *Messages*: > event-basic-type: Wrong type argument: integer-or-marker-p, "(any string)" > 4. Type "foobar" and kill it > 5. C-h k and in the menu bar, click on "Edit", then "Paste from Kill > Menu", then "foobar". > 6. See error printed in *Messages*: > event-basic-type: Wrong type argument: integer-or-marker-p, #("foobar" 0 6 (fontified t)) > > This happens on both Emacs 28 and Emacs 29. AFAICT, this has been broken since Emacs 27. > It looks like this is happening because help--read-key-sequence calls > event-basic-type on the last element of the key sequence returned from > read-key-sequence, which in this case is a string. Yes. > The following patch fixes it (that is, makes describe-key complete > successfully and show appropriate help), but I'm not sure if it's right. > > diff --git a/lisp/help.el b/lisp/help.el > index 83be85b1ee4..73ac793f4aa 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -1021,8 +1021,8 @@ help--read-key-sequence > (raw-seq (this-single-command-raw-keys)) > (keyn (when (> (length seq) 0) > (aref seq (1- (length seq))))) > - (base (event-basic-type keyn)) > - (modifiers (event-modifiers keyn))) > + (base (and (integer-or-marker-p keyn) (event-basic-type keyn))) > + (modifiers (and (integer-or-marker-p keyn) (event-modifiers keyn)))) > (cond > ((zerop (length seq))) ;FIXME: Can this happen? > ((and no-mouse-movement (eq base 'mouse-movement)) nil) Doesn't the above break "C-h c" and "C-h k" for mouse click events? They yield a symbol like down-mouse-1 as KEYN, so are rejected by your proposed condition. I suggest the below instead. I'm just not sure about what to do with RAW-SEQ (which is returned as the cdr of the cons cell value of this function). Emacs 26 returned nil there, so we are "bug-compatible" with it after applying the below. But since this is a general-purpose utility function, perhaps we should return the same value as SEQ there? I mean, what does "untranslated" mean for such "events"? An alternative solution for the original problem would be to teach event-basic-type and event-modifiers about "events" that happen to be strings. Stefan, any comments or better ideas? diff --git a/lisp/help.el b/lisp/help.el index 6eac037..299042f 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -1012,7 +1012,7 @@ help--read-key-sequence (unwind-protect (let (last-modifiers key-list) ;; If yank-menu is empty, populate it temporarily, so that - ;; "Select and Paste" menu can generate a complete event. + ;; "Paste from Kill Menu" menu can generate a complete event. (when (null (cdr yank-menu)) (setq saved-yank-menu (copy-sequence yank-menu)) (menu-bar-update-yank-menu "(any string)" nil)) @@ -1031,8 +1031,14 @@ help--read-key-sequence (raw-seq (this-single-command-raw-keys)) (keyn (when (> (length seq) 0) (aref seq (1- (length seq))))) - (base (event-basic-type keyn)) - (modifiers (event-modifiers keyn))) + ;; The "Paste from Kill Menu" menu-bar item has the + ;; text-to-yank, a string, as its last "event" + ;; component, and those are not supported by + ;; 'event-basic-type' and 'event-modifiers'. + (str-from-menu (stringp keyn)) + (base (and (not str-from-menu) (event-basic-type keyn))) + (modifiers (and (not str-from-menu) + (event-modifiers keyn)))) (cond ((zerop (length seq))) ;FIXME: Can this happen? ((and no-mouse-movement (eq base 'mouse-movement)) nil) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 07:48:54 2023 Received: (at 62626) by debbugs.gnu.org; 6 Apr 2023 11:48:54 +0000 Received: from localhost ([127.0.0.1]:53605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkO6o-00076q-7M for submit@debbugs.gnu.org; Thu, 06 Apr 2023 07:48:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46426) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkO6l-00076X-T7 for 62626@debbugs.gnu.org; Thu, 06 Apr 2023 07:48:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkO6g-000658-Ev; Thu, 06 Apr 2023 07:48:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=k8UrM8gbveET0ZBNyivCJRBWVtXN6Uo093WoR9Gnvrw=; b=Eaz469qOsnolglKwJYxv PjxAlhaYDndky57qsqC6v1OdPSgyBGefVJLtA7jJpg2WJbSRvlSOPdUQRjdv7xcSakiZEhbDqIM9k aMCtid+0+CglnqjZw7IX0d07a11tiB7xTciuLuelI8Urq356OK5rEFuRfEo1nuXeSRo6EgCAGMKbo O1FiunocCRGThCoiydVAdhis353HmiTjoEy0DkLI4yrsFOENYhMUl9/vkI/QLZKqHLDH4zVOYItZN 6bQvCpecFgcbTp2jT5bZ01Y0CliFB7IIsBq4vtsZBwRfcLV0YMJi4vOy3DJxad4y3LsfAhXvAZzuS aFX8PK5fqr7cLw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkO6d-0001vA-GY; Thu, 06 Apr 2023 07:48:43 -0400 Date: Thu, 06 Apr 2023 14:49:13 +0300 Message-Id: <83bkk1qlhi.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Sun, 02 Apr 2023 15:06:53 -0400) Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] References: MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62626 Cc: 62626@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Date: Sun, 02 Apr 2023 15:06:53 -0400 > > describe-key is also broken with context-menu-mode in a different way, > btw. It generates the help buffer fine, but the last key in the > sequence is wrong. It looks like read-key-sequence returns a numeric > index into the menu for that key, counting up from from the last menu > entry and starting at 1, and then the help buffer is interpreting that > number as a key. Please provide a recipe (and perhaps report this as a different bug, unless my proposed solution happens to fix this one as well, by sheer luck). Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 09:07:56 2023 Received: (at 62626) by debbugs.gnu.org; 6 Apr 2023 13:07:57 +0000 Received: from localhost ([127.0.0.1]:53647 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkPLI-0001CV-JX for submit@debbugs.gnu.org; Thu, 06 Apr 2023 09:07:56 -0400 Received: from mxout1.mail.janestreet.com ([38.105.200.78]:36587) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkPLD-0001CD-SU for 62626@debbugs.gnu.org; Thu, 06 Apr 2023 09:07:55 -0400 From: Spencer Baugh To: Eli Zaretskii Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] In-Reply-To: <83bkk1qlhi.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Apr 2023 14:49:13 +0300") References: <83bkk1qlhi.fsf@gnu.org> Date: Thu, 06 Apr 2023 09:07:46 -0400 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62626 Cc: 62626@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> From: Spencer Baugh >> Date: Sun, 02 Apr 2023 15:06:53 -0400 >> >> describe-key is also broken with context-menu-mode in a different way, >> btw. It generates the help buffer fine, but the last key in the >> sequence is wrong. It looks like read-key-sequence returns a numeric >> index into the menu for that key, counting up from from the last menu >> entry and starting at 1, and then the help buffer is interpreting that >> number as a key. > > Please provide a recipe (and perhaps report this as a different bug, > unless my proposed solution happens to fix this one as well, by sheer > luck). > > Thanks. Ah I wasn't clear, it's also an issue with yank-menu. Probably basically the same bug? Recipe: 1. emacs -Q 2. M-x context-menu-mode RET 3. Type "foobar" and kill it 4. C-h k and right click, then "Paste from Kill Menu", then "(any string)". 5. Observe the help buffer claims the key sequence was: C-a From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 09:49:19 2023 Received: (at 62626) by debbugs.gnu.org; 6 Apr 2023 13:49:19 +0000 Received: from localhost ([127.0.0.1]:53686 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkPzL-0002Hf-Cv for submit@debbugs.gnu.org; Thu, 06 Apr 2023 09:49:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40350) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkPzJ-0002HS-MI for 62626@debbugs.gnu.org; Thu, 06 Apr 2023 09:49:18 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkPzD-0000jT-Ek; Thu, 06 Apr 2023 09:49:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=j/kyEAQNOdgZR2tPmZD0+SHjOlyR70wB5L6ZyWaXMHA=; b=f2BDx1iCg1Jlpw4Jgrve iRDnXhn6bRcVHsn4uCNLAzgobFphT7F1sc6Lwh9jg+oAuEFiV9g/qdpecxFzNxUmEpbqKsUkWo1+r 2IYN+DwuRFmF7PE0GnjAZDLHjGNmksvkm4NmBuQhV43ccjY+LN5yCLvTZR0Dww2n0K7ymEiP8eldA L60zIjPcMSKT8SW9PxhjFSnxlNnjsQfYXxH0XsoCLpS4dUjGR25ADhmNjFG8YyIeb2Uk3z4glRCkJ sDzuKnhKgthVkq56O4GHIneCMULk7JNUgDLXXhMZJKScE+kqN+bIat+Xdi+2oHv1KJTe79q7neaL4 972Hg/1tJ+i1vA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkPzC-0005y9-V9; Thu, 06 Apr 2023 09:49:11 -0400 Date: Thu, 06 Apr 2023 16:49:40 +0300 Message-Id: <834jptqfwr.fsf@gnu.org> From: Eli Zaretskii To: Spencer Baugh In-Reply-To: (message from Spencer Baugh on Thu, 06 Apr 2023 09:07:46 -0400) Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] References: <83bkk1qlhi.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62626 Cc: 62626@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Spencer Baugh > Cc: 62626@debbugs.gnu.org > Date: Thu, 06 Apr 2023 09:07:46 -0400 > > Eli Zaretskii writes: > > > Please provide a recipe (and perhaps report this as a different bug, > > unless my proposed solution happens to fix this one as well, by sheer > > luck). > > > > Thanks. > > Ah I wasn't clear, it's also an issue with yank-menu. Probably > basically the same bug? Recipe: > > 1. emacs -Q > 2. M-x context-menu-mode RET > 3. Type "foobar" and kill it > 4. C-h k and right click, then "Paste from Kill Menu", then "(any string)". > 5. Observe the help buffer claims the key sequence was: > C-a Thanks. It's a separate issue, although most probably related. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 10:08:06 2023 Received: (at 62626) by debbugs.gnu.org; 6 Apr 2023 14:08:06 +0000 Received: from localhost ([127.0.0.1]:54619 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkQHV-0003AV-Or for submit@debbugs.gnu.org; Thu, 06 Apr 2023 10:08:05 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkQHS-0003A1-Lk for 62626@debbugs.gnu.org; Thu, 06 Apr 2023 10:08:04 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 5CD591000DC; Thu, 6 Apr 2023 10:07:57 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 9429E1000BE; Thu, 6 Apr 2023 10:07:55 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1680790075; bh=845Yo60gpnowXbGbXKGji+2A0XP6T4TR2beESDqFnew=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=cKGm/ClPfhA590HDt+BDGsNt1094e8BCwOqMGMyFcGuPOnNOwdLMZB0icV6NABcZO aWDFXxXV+simfXcwcFysLzaocxQm0S7NsPzPWwaUB5iFKse+AUtRG0EAD7wgKNxnWw syjaNOsR/IqNhAgeh9SEKW/FfCBout43VH7zCHlWC0bURHG0ArY6Yjt7CijeS6pZJ0 0zROeoZcZNKZTDTeGUzsIM15fN2zzeUvmdBRAyUfgltFU6QFLnVM+0XqYVjdoZZDwn 2kDvngrp6Sezz1zJU3zDO1lULvtuV3JRp4+6ItQnAnoQxWguKeSKgbl9fGhyPVhCtM eQCTQIoDRXWNQ== Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 70A28123205; Thu, 6 Apr 2023 10:07:55 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] In-Reply-To: <83cz4hqljl.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 06 Apr 2023 14:47:58 +0300") Message-ID: References: <83cz4hqljl.fsf@gnu.org> Date: Thu, 06 Apr 2023 10:07:47 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.236 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62626 Cc: Spencer Baugh , 62626@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > An alternative solution for the original problem would be to teach > event-basic-type and event-modifiers about "events" that happen to be > strings. Since `read-key-sequence` returns those, we should probably teach `event-*` functions to deal with them. But since they don't agree with `eventp`, maybe we should also consider deprecating such "weird keys". FWIW, that very same "Paste from Kill Menu" is constructed differently in `context-menu-region` where it doesn't suffer from this problem (it uses integers instead of strings, as keys). Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 08 08:43:19 2023 Received: (at 62626) by debbugs.gnu.org; 8 Apr 2023 12:43:20 +0000 Received: from localhost ([127.0.0.1]:57982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl7uZ-000850-Hi for submit@debbugs.gnu.org; Sat, 08 Apr 2023 08:43:19 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl7uY-00084n-D6 for 62626@debbugs.gnu.org; Sat, 08 Apr 2023 08:43:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl7uQ-0007WZ-3p; Sat, 08 Apr 2023 08:43:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=m8U4o8bjiBmi8Rgzx1B/bJNHsnMxzPbOyZE1IrtmQTw=; b=QIVUDsgWK8Hwaox2bsd1 mbPlcOHo9JcCVKFWXpkBSpUTrOIzLHmq9uTJqVxHFPpyLk3lyboiSCFgcN5/t8wnC0xTi1yRd3NT9 vMFScZvI/uCbG4AXmc3VczM/4FtD2UFxs9Db0EajrwMq/Voj6b8l1Lvj+A4H2DKVHRYI+hQvPrqGg VpF8DYmkifEQbJDeLmSWcdqMomMT98CxYG+/XQisukDOXe1ma1alcerIg8E+gXXFRS4SM6mvI2sXT q4chHKpIPkDZ+AyQSl/8Je1bIM0yezW/EJ3BJikXiZUFAwTqf6DcHL3AE459ObY8mHlPE7pgUwDpj j/P2+cjormY+jg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pl7uP-00012T-CZ; Sat, 08 Apr 2023 08:43:09 -0400 Date: Sat, 08 Apr 2023 15:43:43 +0300 Message-Id: <83ttxqmtmo.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Thu, 06 Apr 2023 10:07:47 -0400) Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] References: <83cz4hqljl.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62626 Cc: sbaugh@janestreet.com, 62626@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Spencer Baugh , 62626@debbugs.gnu.org > Date: Thu, 06 Apr 2023 10:07:47 -0400 > > > An alternative solution for the original problem would be to teach > > event-basic-type and event-modifiers about "events" that happen to be > > strings. > > Since `read-key-sequence` returns those, we should probably teach > `event-*` functions to deal with them. Done. > But since they don't agree with `eventp`, maybe we should also consider > deprecating such "weird keys". Patches welcome (and this is not for the release branch anyway). > FWIW, that very same "Paste from Kill Menu" is constructed differently in > `context-menu-region` where it doesn't suffer from this problem (it > uses integers instead of strings, as keys). Aren't those integer indices the reason why the recipe below: emacs -Q M-x context-menu-mode RET Type "foobar" and kill it C-h k and right click, then "Paste from Kill Menu", then select string Observe the help buffer claims the key sequence was: C-a ^^^ shows the bogus "C-a" at the end of the sequence? I believe C-a comes from the index 1 that read-key-sequence returns at the end of the sequence: [(down-mouse-3 (# 146 (422 . 257) 1959895390 nil 146 (52 . 3) nil (422 . 209) (8 . 16))) paste-from-menu 1] From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 08 11:42:50 2023 Received: (at 62626) by debbugs.gnu.org; 8 Apr 2023 15:42:50 +0000 Received: from localhost ([127.0.0.1]:59344 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plAiI-0007Nv-A8 for submit@debbugs.gnu.org; Sat, 08 Apr 2023 11:42:50 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:8668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plAiG-0007Nj-Bz for 62626@debbugs.gnu.org; Sat, 08 Apr 2023 11:42:48 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 1BC4C1000CA; Sat, 8 Apr 2023 11:42:43 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 02E5B1000BD; Sat, 8 Apr 2023 11:42:42 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1680968562; bh=Ae/7aEhtmzFfB8Nf1EPg3z5B/AOYdrZ9dPRideB4a2A=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=TKYZKN8TzCLbsaxX5lBvItChvL8SdR/Z5ZC44+UVpwJHq+HzJfSvNDxhztVXgxMaJ 8WcjK0nPArER40NaJUgMk6odwMe1OBQ/hpOcOc0TAOh9qH3OtqMPgsp4uE9h/GX7xg qkO/B2760xSNBuAqrqu5wjF43GUxQUaSsyiFRbUJjbEXckmUXRGKdGdETyXfN5uWV7 sc3QNpZJEyvmm4kiSz8s13SrwNdkNli9+xfxpa674tUhlmcHgjrScOvctca0lnLO30 un7mLFyVYKOWn99kM0YhyLVMXzpU8l0JmajdsW4lcLjFHhVz8c08bVte+1Dzxi8bAp Idnjbvw+ifY3g== Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id CCBD81233B7; Sat, 8 Apr 2023 11:42:41 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] In-Reply-To: <83ttxqmtmo.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 08 Apr 2023 15:43:43 +0300") Message-ID: References: <83cz4hqljl.fsf@gnu.org> <83ttxqmtmo.fsf@gnu.org> Date: Sat, 08 Apr 2023 11:42:40 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.234 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62626 Cc: sbaugh@janestreet.com, 62626@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Aren't those integer indices the reason why the recipe below: > > emacs -Q > M-x context-menu-mode RET > Type "foobar" and kill it > C-h k and right click, then "Paste from Kill Menu", then select string > Observe the help buffer claims the key sequence was: > C-a > ^^^ > shows the bogus "C-a" at the end of the sequence? Indeed. We should probably use something like (intern (format "entry-%d" i)) to avoid confusion. `context-menu-mode` code has a few other differences with the "normal" menu (e.g. it fails to truncate long strings, etc...), so we should consolidate the two codes to keep the best of each. Stefan From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 08 13:13:00 2023 Received: (at 62626) by debbugs.gnu.org; 8 Apr 2023 17:13:00 +0000 Received: from localhost ([127.0.0.1]:59431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plC7X-000417-QY for submit@debbugs.gnu.org; Sat, 08 Apr 2023 13:13:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41682) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1plC7V-00040u-HR for 62626@debbugs.gnu.org; Sat, 08 Apr 2023 13:12:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plC7P-0004Ge-RO; Sat, 08 Apr 2023 13:12:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=yMgH16HfX75mmYzhG38lKH3bNmh1CfK8u75tXdzY220=; b=FeUhgYCAghICDRxZA1YJ I2Zr5gDDucrKcowIWDmmaVJfeYJUBKQ8d+CggLLyY9VCedzfCIBPP6CxKLOST3NaACdsrUFgmwc3R hyWQDsuma4RSRWN0hSJY1MkBJiwEXYZAA3cJSQ39uxyzv7M8dopDD2Ub+CP8JXOBMtx748eG3zCS0 vmHfHeOeZbs4ppnYr3qTxeFgEjf1NRVjDqibcO2HqQ9fGzvYU9C3pCPnP7I00iVV700faM4LSffCd lX5JFqq1jA0xj7eRIt4cUouZYZEQw1Qc6psj+vrHueTWfuukud1zvsybXYecEOJPnYi9xgUH8e6tP 0LdQ+j7cLbJsdg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1plC7P-0003Vj-04; Sat, 08 Apr 2023 13:12:51 -0400 Date: Sat, 08 Apr 2023 20:13:25 +0300 Message-Id: <83fs9amh56.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sat, 08 Apr 2023 11:42:40 -0400) Subject: Re: bug#62626: 29.0.60; describe-key errors on Edit =?utf-8?Q?=E2=86=92?= Paste from Kill Ring =?utf-8?Q?=E2=86=92?= [any item] References: <83cz4hqljl.fsf@gnu.org> <83ttxqmtmo.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62626 Cc: sbaugh@janestreet.com, 62626@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: sbaugh@janestreet.com, 62626@debbugs.gnu.org > Date: Sat, 08 Apr 2023 11:42:40 -0400 > > > Aren't those integer indices the reason why the recipe below: > > > > emacs -Q > > M-x context-menu-mode RET > > Type "foobar" and kill it > > C-h k and right click, then "Paste from Kill Menu", then select string > > Observe the help buffer claims the key sequence was: > > C-a > > ^^^ > > shows the bogus "C-a" at the end of the sequence? > > Indeed. We should probably use something > like (intern (format "entry-%d" i)) to avoid confusion. Done. > `context-menu-mode` code has a few other differences with the "normal" > menu (e.g. it fails to truncate long strings, etc...), so we should > consolidate the two codes to keep the best of each. Well, each of these two approaches has its ugly aspects, so... From debbugs-submit-bounces@debbugs.gnu.org Fri Aug 29 16:46:21 2025 Received: (at control) by debbugs.gnu.org; 29 Aug 2025 20:46:22 +0000 Received: from localhost ([127.0.0.1]:43470 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1us5zI-0005Eg-Pf for submit@debbugs.gnu.org; Fri, 29 Aug 2025 16:46:21 -0400 Received: from mxout5.mail.janestreet.com ([64.215.233.18]:48023) by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1us5zF-0005DN-Ud for control@debbugs.gnu.org; Fri, 29 Aug 2025 16:46:18 -0400 From: Spencer Baugh To: control@debbugs.gnu.org Subject: control message for bug #62626 Date: Fri, 29 Aug 2025 16:46:12 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=janestreet.com; s=waixah; t=1756500372; bh=wncfX5GcXCTytt0VfJf2+eT+IwM+h/LqwYB2bWquJ50=; h=From:To:Subject:Date; b=o4aopmsjj5KRSXoWcDeIKtk0UgOv0/73fqRnW/DCF/Zk3E/8URyE8GJt7q7hwnT7E tPdlC9QDttar0NfNzv1aYUYqIc0nIanWNCo7agPfaEpikw6fVDbetM6gQdJLV2yjMW AaoOs2mVLUu9kMQNRJ7BsKTDVOUyjUw2UUUtRmBq5yKcSZleIYKMaAoWKUTayE+NY0 yiv7r2/7wS8TEHBN4X5jKjdOgoPHlJQ0tgecXzUdCNOwQAWj4N+mLNPzaVLvJTY5bp crR5odn/8Eedn7a+HV+bi1px4kR+ImL4j2/CmUb6scTEr45NZ8oHOMvkN8R5oycUsA +Uu7nIee3X36A== X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 62626 30.2 quit This is fixed in Emacs 30.