GNU bug report logs - #62621
29.0.60; uniquify can't make buffers unique based on things other than filename

Previous Next

Full log

Message #122 received at 62621 <at> debbugs.gnu.org (full text, mbox):

From: Spencer Baugh <sbaugh <at> janestreet.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Dmitry Gutov <dmitry <at> gutov.dev>, 62621 <at> debbugs.gnu.org,
 Spencer Baugh <sbaugh <at> catern.com>
Subject: Re: bug#62621: 29.0.60; uniquify can't make buffers unique based on
 things other than filename
Date: Thu, 3 Aug 2023 07:54:22 -0400

[Message part 1 (text/plain, inline)]

On reflection that specific test case is of dubious value, and since it's
failing on Windows it means the behavior isn't even consistent anyway. So
just delete it.

On Thu, Aug 3, 2023, 04:00 Eli Zaretskii <eliz <at> gnu.org> wrote:

> Ping!  Can this test failure be fixed, please?
>
> > Cc: dmitry <at> gutov.dev, 62621 <at> debbugs.gnu.org, sbaugh <at> catern.com
> > Date: Wed, 26 Jul 2023 18:18:25 +0300
> > From: Eli Zaretskii <eliz <at> gnu.org>
> >
> > > From: Spencer Baugh <sbaugh <at> janestreet.com>
> > > Cc: dmitry <at> gutov.dev,  62621 <at> debbugs.gnu.org,  sbaugh <at> catern.com
> > > Date: Mon, 24 Jul 2023 15:18:23 -0400
> > >
> > > > OK, how about this?
> > >
> > > Oops, that one didn't include the updated
> > > project-uniquify-dirname-transform docstring.  The right patch now:
> >
> > Thanks, installed, with some minor changes as followup.
> >
> > The new test uniquify-home fails for me on MS-Windows:
> >
> >   Test uniquify-home backtrace:
> >     signal(ert-test-failed (((should (equal (mapcar #'buffer-name bufs)
> >     ert-fail(((should (equal (mapcar #'buffer-name bufs) '("~<test>" "~<
> >     (if (unwind-protect (setq value-27 (apply fn-25 args-26)) (setq form
> >     (let (form-description-29) (if (unwind-protect (setq value-27 (apply
> >     (let ((value-27 'ert-form-evaluation-aborted-28)) (let (form-descrip
> >     (let* ((fn-25 #'equal) (args-26 (condition-case err (let ((signal-ho
> >     (save-excursion (setq bufs (cons (find-file-noselect "~") bufs)) (se
> >     (let (bufs) (save-excursion (setq bufs (cons (find-file-noselect "~"
> >     (closure (t) nil (let (bufs) (save-excursion (setq bufs (cons (find-
> >     ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test
> >     ert-run-test(#s(ert-test :name uniquify-home :documentation "uniquif
> >     ert-run-or-rerun-test(#s(ert--stats :selector (not ...) :tests [...
> >     ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil
> >     ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp))))
> >     ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco
> >     eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n
> >     command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/uniquify-tests.el" "
> >     command-line()
> >     normal-top-level()
> >   Test uniquify-home condition:
> >       (ert-test-failed
> >        ((should (equal (mapcar ... bufs) '("~<test>" "~<>"))) :form
> >       (equal ("~" "nonexistent") ("~<test>" "~<>")) :value nil
> >       :explanation
> >       (list-elt 0
> >                 (arrays-of-different-length 1 7 "~" "~<test>"
> >                                             first-mismatch-at 1))))
> >
> > The idea of the test is not clear to me, so I cannot tell what could
> > be the reasons.  Feel free to ask me to test changes or ask questions
> > about what happens on this Windows system while running the test.
> >
> >
> >
> >
>

[Message part 2 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.