GNU bug report logs - #62620
30.0.50; Unused unwind-protect in verilog-mode

Previous Next

Package: emacs;

Reported by: Basil Contovounesios <contovob <at> tcd.ie>

Date: Sun, 2 Apr 2023 16:41:02 UTC

Severity: minor

Tags: patch

Found in version 30.0.50

Fixed in version 30.1

Done: Basil Contovounesios <contovob <at> tcd.ie>

Bug is archived. No further changes may be made.

Full log

Message #10 received at control <at> debbugs.gnu.org (full text, mbox):

From: Basil Contovounesios <contovob <at> tcd.ie>
To: Mattias Engdegård <mattiase <at> acm.org>
Cc: 62620-done <at> debbugs.gnu.org, Wilson Snyder <wsnyder <at> wsnyder.org>
Subject: Re: bug#62620: 30.0.50; Unused unwind-protect in verilog-mode
Date: Tue, 18 Apr 2023 11:25:07 +0100

close 62620 30.1
quit

Mattias Engdegård [2023-04-04 11:57 +0200] wrote:

> 2 apr. 2023 kl. 18.39 skrev Basil Contovounesios <contovob <at> tcd.ie>:
>
>> -    (with-temp-buffer "*Verilog-Diff*"
>
> That's a nice catch. I didn't find any other instance of that particular mistake in Emacs; there is one in GNU ELPA (sketch-mode.el).

Thanks for checking.
I can submit a patch there later if no-one beats me to it.

> (The patch looks superficially fine to me but I haven't actually tested it.)

Thanks, now pushed:

Fix verilog-diff-file-with-buffer
0d2fdf6e36d 2023-04-18 11:14:38 +0100
https://git.sv.gnu.org/cgit/emacs.git/commit/?id=0d2fdf6e36d

Hopefully Wilson gets a chance to look at and upstream the patch soon.

-- 
Basil
This bug report was last modified 2 years and 123 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.