From unknown Sat Sep 20 03:14:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62620 <62620@debbugs.gnu.org> To: bug#62620 <62620@debbugs.gnu.org> Subject: Status: 30.0.50; Unused unwind-protect in verilog-mode Reply-To: bug#62620 <62620@debbugs.gnu.org> Date: Sat, 20 Sep 2025 10:14:12 +0000 retitle 62620 30.0.50; Unused unwind-protect in verilog-mode reassign 62620 emacs submitter 62620 Basil Contovounesios severity 62620 minor tag 62620 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 12:40:02 2023 Received: (at submit) by debbugs.gnu.org; 2 Apr 2023 16:40:03 +0000 Received: from localhost ([127.0.0.1]:42488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj0kL-0000sJ-ED for submit@debbugs.gnu.org; Sun, 02 Apr 2023 12:40:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:47718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj0kH-0000s3-SV for submit@debbugs.gnu.org; Sun, 02 Apr 2023 12:40:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pj0kH-0003Cu-Mc for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 12:39:57 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pj0kC-0006sK-F3 for bug-gnu-emacs@gnu.org; Sun, 02 Apr 2023 12:39:57 -0400 Received: by mail-wm1-x333.google.com with SMTP id o32so15720579wms.1 for ; Sun, 02 Apr 2023 09:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1680453589; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=ZJtA0otOGbcOIZysd1j9/Bi/X8FO1TPJixHp2bPe+lw=; b=a/MAX58sEhEqXVqF6FT8xR9hp7uSbYAsOLLKkVXeIB8pAllw02JldgyKQNRbEOlTli OuguHsATKEat7OlyqCLuWGSFwc+i9mIcxGBda9TLn2i8ufRvtygzFztHDXwh2FmyF9p+ ya/h129CoTvV/SRTg/qvybEqVLTJpJZ+0x0EjFjqxlHgypJGtDOcKTdlurJiv9REDUtF vRX0SnJMVFyo3gzJJzP1vHF/tAVdFaOl0D3Tke8HBLiB+ovFoGVxeoEQ1y/+0ur9quE9 3+oAb6UcPgJujODv3283ZS7QakcLLccsEDE6REHYjCy5NQLOBSBKO/GkwuXpb9bwudKe uz2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680453589; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZJtA0otOGbcOIZysd1j9/Bi/X8FO1TPJixHp2bPe+lw=; b=LB/hwSe/vX4oZ4bd8gXpNh5GpxL0BKXPK8e+SVtoN7eqq3U5CiQY4yO/RMFhkQXV3T GgREVwOLa5mxeolD59gKksuaE0QbDqTMO/I8Si4HnGKH3gTA8M4FnowJ3BvNP1zvA+lM DXuZr1zho+IPbQXJ72dOMHksq4E5095oTqMxspdKeCe9rHcYba5J7yUjFEyokcYWpVOg ILONmDc9WullwI/kZC0D0NmGGlbw5DquO7VODpeAo0I4Z3zm9zTg66vkNc9jDnsMT7Vw FtP/UqzngRo+ZH7tPTu3EOpK0jWABWwzUm7YKXUWwACcT/tUN7Hu7iSIOCY+5JBycdZ9 cUmw== X-Gm-Message-State: AO0yUKWEKr+6i01XWPJo6KkW3tDvuJWMqH8KkbD8GXOzj6tJ5VBkfX1L rbc66N9wsq5mnlahcOO8u8v9D8OksYNjnIA2cT8= X-Google-Smtp-Source: AK7set/CO8N4btwF9U6GPlOkmOEnGNhpeyKq6w72IEn1rnyIpMdt1wAqMn0QWO0ft5jT0BGoqSYoRA== X-Received: by 2002:a7b:cd88:0:b0:3ee:7061:1bdd with SMTP id y8-20020a7bcd88000000b003ee70611bddmr24395466wmj.4.1680453588858; Sun, 02 Apr 2023 09:39:48 -0700 (PDT) Received: from localhost ([51.37.77.228]) by smtp.gmail.com with ESMTPSA id g20-20020a05600c4ed400b003ee8a1bc220sm17144210wmq.1.2023.04.02.09.39.48 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 09:39:48 -0700 (PDT) From: Basil Contovounesios To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Unused unwind-protect in verilog-mode X-Debbugs-Cc: Wilson Snyder , Mattias =?utf-8?Q?Engde?= =?utf-8?Q?g=C3=A5rd?= Date: Sun, 02 Apr 2023 17:39:47 +0100 Message-ID: <87cz4m44rw.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::333; envelope-from=contovob@tcd.ie; helo=mail-wm1-x333.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Severity: minor Tags: patch As Mattias pointed out in https://bugs.gnu.org/62599#14, byte-compiling verilog-mode currently emits the following warning: In verilog-diff-file-with-buffer: progmodes/verilog-mode.el:11894:26: Warning: =E2=80=98unwind-protect=E2= =80=99 without unwind forms The following patch tries to address that: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fix-verilog-diff-file-with-buffer.patch >From 619aad44b8877ff3e2def7cd42660f5c4fe0b5f3 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sun, 2 Apr 2023 16:46:33 +0100 Subject: [PATCH] Fix verilog-diff-file-with-buffer * lisp/progmodes/verilog-mode.el: Fix commentary to avoid implying XEmacs defines diff-command. (verilog-diff-file-with-buffer): Claim compatibility with Emacs 21 rather than XEmacs in commentary, since the latter does not seem to define diff-command. Use get-buffer in place of likely thinko with-temp-buffer + BUFNAME + current-buffer. Fix unused unwind-protect: move temporary file deletion to its unwind forms. Avoid race condition between file existence check and deletion. Handle list-valued diff-switches. Avoid passing empty argument to diff-command. --- lisp/progmodes/verilog-mode.el | 54 ++++++++++++++++++---------------- 1 file changed, 29 insertions(+), 25 deletions(-) diff --git a/lisp/progmodes/verilog-mode.el b/lisp/progmodes/verilog-mode.el index ac6fd382a46..9199119b602 100644 --- a/lisp/progmodes/verilog-mode.el +++ b/lisp/progmodes/verilog-mode.el @@ -356,7 +356,9 @@ verilog--suppressed-warnings (eval-and-compile ;; Both xemacs and emacs (condition-case nil - (require 'diff) ; diff-command and diff-switches + ;; `diff-command' and `diff-switches', + ;; although XEmacs lacks the former. + (require 'diff) (error nil)) (condition-case nil (require 'compile) ; compilation-error-regexp-alist-alist @@ -11883,31 +11885,33 @@ verilog-diff-file-with-buffer This requires the external program `diff-command' to be in your `exec-path', and uses `diff-switches' in which you may want to have \"-u\" flag. Ignores WHITESPACE if t, and writes output to stdout if SHOW." - ;; Similar to `diff-buffer-with-file' but works on XEmacs, and doesn't - ;; call `diff' as `diff' has different calling semantics on different - ;; versions of Emacs. + ;; Similar to `diff-buffer-with-file' but works on Emacs 21, and + ;; doesn't call `diff' as `diff' has different calling semantics on + ;; different versions of Emacs. (if (not (file-exists-p f1)) - (message "Buffer `%s' has no associated file on disk" (buffer-name b2)) - (with-temp-buffer "*Verilog-Diff*" - (let ((outbuf (current-buffer)) - (f2 (make-temp-file "vm-diff-auto-"))) - (unwind-protect - (progn - (with-current-buffer b2 - (save-restriction - (widen) - (write-region (point-min) (point-max) f2 nil 'nomessage))) - (call-process diff-command nil outbuf t - diff-switches ; User may want -u in diff-switches - (if whitespace "-b" "") - f1 f2) - ;; Print out results. Alternatively we could have call-processed - ;; ourself, but this way we can reuse diff switches - (when show - (with-current-buffer outbuf (message "%s" (buffer-string)))))) - (sit-for 0) - (when (file-exists-p f2) - (delete-file f2)))))) + (message "Buffer `%s' has no associated file on disk" b2) + (let ((outbuf (get-buffer "*Verilog-Diff*")) + (f2 (make-temp-file "vm-diff-auto-"))) + (unwind-protect + ;; User may want -u in `diff-switches'. + (let ((args `(,@(if (listp diff-switches) + diff-switches + (list diff-switches)) + ,@(and whitespace '("-b")) + ,f1 ,f2))) + (with-current-buffer b2 + (save-restriction + (widen) + (write-region (point-min) (point-max) f2 nil 'nomessage))) + (apply #'call-process diff-command nil outbuf t args) + ;; Print out results. Alternatively we could have call-processed + ;; ourself, but this way we can reuse diff switches. + (when show + (with-current-buffer outbuf (message "%s" (buffer-string))))) + (sit-for 0) + (condition-case nil + (delete-file f2) + (error nil)))))) (defun verilog-diff-report (b1 b2 diffpt) "Report differences detected with `verilog-diff-auto'. -- 2.34.1 --=-=-= Content-Type: text/plain Note that this function may have never worked in XEmacs, at least judging from the diff.el in the following version I have locally: C-u M-x version XEmacs 21.4 (patch 24) "Standard C" [Lucid] (x86_64-linux-gnu, Mule) of Mon Jun 21 2021 on lgw01-amd64-053 It might be easy to avoid Emacs-isms in verilog-diff-file-with-buffer, but considering verilog-diff-file-with-buffer probably never worked in XEmacs, and XEmacs support is on its way out[0], I made no such changes. [0]: https://github.com/veripool/verilog-mode/issues/1822#issuecomment-1422508926 Note also that verilog-diff-file-with-buffer until now called with-temp-buffer with the name of a buffer previously created in verilog-diff-auto. I assume the intention was to instead call with-current-buffer, so I made an analogous change. The patch lists some further fixes. WDYT? Thanks, -- Basil In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-04-02 built on blc Repository revision: 97e35b149874a105a9975853a7fcd6f0034ddeab Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101003 System Description: Ubuntu 22.04.2 LTS Configured using: 'configure CC=gcc-12 'CFLAGS=-Og -ggdb3' --prefix=/home/blc/.local --with-file-notification=yes --with-x --with-x-toolkit=lucid PKG_CONFIG_PATH=/home/blc/.local/lib/pkgconfig:' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LC_MONETARY: en_IE.UTF-8 value of $LC_NUMERIC: en_IE.UTF-8 value of $LC_TIME: en_IE.UTF-8 value of $LANG: en_GB.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 36607 9341) (symbols 48 5171 0) (strings 32 13873 1627) (string-bytes 1 377563) (vectors 16 9294) (vector-slots 8 148577 11610) (floats 8 23 25) (intervals 56 248 0) (buffers 984 10)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 04 05:57:31 2023 Received: (at 62620) by debbugs.gnu.org; 4 Apr 2023 09:57:31 +0000 Received: from localhost ([127.0.0.1]:46604 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjdPv-0002q5-Ds for submit@debbugs.gnu.org; Tue, 04 Apr 2023 05:57:31 -0400 Received: from mail1458c50.megamailservers.eu ([91.136.14.58]:41756 helo=mail267c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjdPr-0002pp-S3 for 62620@debbugs.gnu.org; Tue, 04 Apr 2023 05:57:29 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1680602240; bh=QiYEKTrKQi4k57T1+ZTGqT0fzytNDbtnxAMHFzkGQYI=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=tGgl8bE7HgHHNCIDOZxMM9mMn2HalEUZ3QM2W7zy3A/w3pzrwOzj1V1IBKsXt5dLn deqfIlU60WrF5KIKcBfPgItNAmZLug+sGseHYBSDXtW3rxXdbndiwhoBiJCU4+28NX 3uDSQAE6fhZL5mVkcrG2usO/TVwE04MSqMnOWW8E= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail267c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 3349vHYb051081; Tue, 4 Apr 2023 09:57:19 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Subject: Re: bug#62620: 30.0.50; Unused unwind-protect in verilog-mode From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87cz4m44rw.fsf@tcd.ie> Date: Tue, 4 Apr 2023 11:57:17 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87cz4m44rw.fsf@tcd.ie> To: Basil Contovounesios X-Mailer: Apple Mail (2.3654.120.0.1.14) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeiledgvdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepveekffdujefhkeehvdfgffeikefghfefvdekueffleegfeekueelhfejieefkefgnecukfhppedukeekrdduhedtrdduieehrddvfeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudekkedrudehtddrudeihedrvdefhedphhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpmhgrihhlfhhrohhmpehmrghtthhirghsvgesrggtmhdrohhrghdpnhgspghrtghpthhtohepfedprhgtphhtthhopegtohhnthhovhhosgesthgtugdrihgvpdhrtghpthhtohepiedviedvtdesuggvsggsuhhgshdrghhnuhdrohhrghdprhgtphhtthhopeifshhnhiguvghrseifshhnhiguvghrrdhorhhg X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 62620 Cc: Wilson Snyder , 62620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 2 apr. 2023 kl. 18.39 skrev Basil Contovounesios : > - (with-temp-buffer "*Verilog-Diff*" That's a nice catch. I didn't find any other instance of that particular = mistake in Emacs; there is one in GNU ELPA (sketch-mode.el). (The patch looks superficially fine to me but I haven't actually tested = it.) From debbugs-submit-bounces@debbugs.gnu.org Tue Apr 18 06:25:25 2023 Received: (at control) by debbugs.gnu.org; 18 Apr 2023 10:25:25 +0000 Received: from localhost ([127.0.0.1]:57889 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poiWa-0005RR-R2 for submit@debbugs.gnu.org; Tue, 18 Apr 2023 06:25:25 -0400 Received: from mail-wr1-f42.google.com ([209.85.221.42]:48405) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1poiWR-0005LX-BN for control@debbugs.gnu.org; Tue, 18 Apr 2023 06:25:16 -0400 Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-2f7c281a015so1447105f8f.1 for ; Tue, 18 Apr 2023 03:25:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1681813509; x=1684405509; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oWujNo2Kop4SPcGKsr/+YaeAqcEHGy201v17OBOARTM=; b=Htq9JinsQ1UalskNtgZGz5roks0++xcylYc4bIlWgcH46MEqck5UfgMzc4K7BsnPSY Zz0AXiiZNYfPxEKzMpIvL4QQSWj+BoPWl9R31ZUqNCMgU5e07CtqqGfxD6Nj/Xo+jmFB 4Ky1cAXC1bhwxSUK5TD8U+CVrHoiMiccSBYHNH0B6l4JVJvACS170o7/Cc1cTO1Tcf5B 9LY2d30PeM3rtb1LVU6cRyHrb8wzuWIKr/A7EBR77v9vJA0erb4DnVivExvXV3oTXA9Q 96NNxeyuuwOA5kh/RQ5inNt8YI9RUWH/pHvH32bfjSninzGLNhbhKRGFJRbzVtJDkpMK 9ovg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681813509; x=1684405509; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=oWujNo2Kop4SPcGKsr/+YaeAqcEHGy201v17OBOARTM=; b=XyJKj7LCpzXUGTuzBv9WW2l4z4M0prib1A8BIhW/oBOlml80j1i9Hgmj/ROMoC6rfU 0PDX68KtV+GTxO2jBUACQEP9Ux1qwjLO0AwfyEs/qgkkKjkUOEERBjtfPU3lqnfVol5M gCfolRkI3hRM0n92v0Idz9LOUKJUl/k8NpfwxTVbJiujlV5lQlMHxN0DbIGhwoUGISbA 2COGx8wXwI3HLwaV8XxIAZEApg5QuL1dZcTsWejPhxh0g9b8qP4Xbgn9gY/lbafjpGis W3tg9BXPM5hE+6ON5QsF5lj8mKK7a8+0zmVlGRkNgwRzLXy6tzkOp0hHAyhOlmMVkzbs njbw== X-Gm-Message-State: AAQBX9czuPi21ySIohQ2WXjxyjJ/wF6S9INrZkOuhjzsLc3yAhCOlqzO bpSp5ZNgXs0hPp+tBppqqyR/wA== X-Google-Smtp-Source: AKy350ZYQ5CDcCtftmOsS80Y755+oY8tjZwudwnIaMtAwINTaxoF6f5xhLv53VeRRx7s2FJym/Fnyg== X-Received: by 2002:a5d:5243:0:b0:2ee:c42e:a54e with SMTP id k3-20020a5d5243000000b002eec42ea54emr1312329wrc.50.1681813509435; Tue, 18 Apr 2023 03:25:09 -0700 (PDT) Received: from localhost ([217.173.96.166]) by smtp.gmail.com with ESMTPSA id t12-20020a5d460c000000b002c561805a4csm12721275wrq.45.2023.04.18.03.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 03:25:08 -0700 (PDT) From: Basil Contovounesios To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#62620: 30.0.50; Unused unwind-protect in verilog-mode In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Tue, 4 Apr 2023 11:57:17 +0200") References: <87cz4m44rw.fsf@tcd.ie> Date: Tue, 18 Apr 2023 11:25:07 +0100 Message-ID: <87edohv664.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: 62620-done@debbugs.gnu.org, Wilson Snyder X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 62620 30.1 quit Mattias Engdeg=C3=A5rd [2023-04-04 11:57 +0200] wrote: > 2 apr. 2023 kl. 18.39 skrev Basil Contovounesios : > >> - (with-temp-buffer "*Verilog-Diff*" > > That's a nice catch. I didn't find any other instance of that particular = mistake in Emacs; there is one in GNU ELPA (sketch-mode.el). Thanks for checking. I can submit a patch there later if no-one beats me to it. > (The patch looks superficially fine to me but I haven't actually tested i= t.) Thanks, now pushed: Fix verilog-diff-file-with-buffer 0d2fdf6e36d 2023-04-18 11:14:38 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D0d2fdf6e36d Hopefully Wilson gets a chance to look at and upstream the patch soon. --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 08:18:40 2023 Received: (at 62620) by debbugs.gnu.org; 21 Apr 2023 12:18:40 +0000 Received: from localhost ([127.0.0.1]:39548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pppiq-0001hI-9A for submit@debbugs.gnu.org; Fri, 21 Apr 2023 08:18:40 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:59637) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pppin-0001h3-Kc for 62620@debbugs.gnu.org; Fri, 21 Apr 2023 08:18:39 -0400 Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1a92513abebso23945715ad.2 for <62620@debbugs.gnu.org>; Fri, 21 Apr 2023 05:18:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1682079511; x=1684671511; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0Skl8UsI5UKURs3NQTHcGixNVXEQjCWpqeP37G1gSNw=; b=R+5hQsl78zn9wVWrpstMVdVqcjwO8RdTrHJDkMqUjTt1XaV/TnK0SuBRJkygtwNpcq h+7szZW4CWCj3oEnZ3zYv7DBoRDfXAwymFkxDlwHdKTtbhfOqo8u5sTTveQCVVf7gbl8 yHOxRcNaFW7vZxo0YVXFrsTKeAfqms3aHTIH7oOqCYAESQSFGQ2CWZHxb6vS3wP31iOS MTM3jB5w6tXq2OFTuLkO37DnljkJJI2I1rAUfW4C/qpaxGd6kqBzOl8ntgB7nLZP9vTj KyAJHlB+Mvmyf/v7wpGQC/rc/j8xx4fKNEbyDzSDn4BYrTTqCoS4HhxUqMukvOCNxZc9 078w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682079511; x=1684671511; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0Skl8UsI5UKURs3NQTHcGixNVXEQjCWpqeP37G1gSNw=; b=HDHZS46Kyq1sFqaVHJRt9la2XHPclHUCcda847Ou3Rs2vOs8XmERyBnBgUG41s03gW BBG1cYWTUoUgUk/PzKxme7ADeHUGOtUXXRX2r42pNGc6QC72RSZiAMlCei1TdCmFygZk AgVqE2e7Aub/h5QnSETRa/2LL1PnDjVVkErMMiVCs0a/BjtOP672UPZ6FwXSDClUzdNF dMhtFogWhxK48XqCfMtddXyZRNKhiQuJ5A4jCVcvO2hwAo8lyRDMwhVcezmO26wbeDGf kwZON17VOgip5hhwYJuxA36a9HlbhLXV5/2aDgwPzMWqLLLA3VgGU0SYfmVmreX/UCqX 7iCA== X-Gm-Message-State: AAQBX9eNVTsdTWyUE6BDJKjv22aQp1/WCohsHKA42/TMGTk1sQ1sraJh TQlh5++0jbKv9kMYbeFd8bk24g== X-Google-Smtp-Source: AKy350a76yVPmToV4FUOt6KUgf0pfiYXG5pNQYlDnGJxi1eyu3eLpTUE+aGy+R/6dDOifc/suFFhsw== X-Received: by 2002:a17:903:748:b0:1a6:81fc:b585 with SMTP id kl8-20020a170903074800b001a681fcb585mr4413607plb.41.1682079511470; Fri, 21 Apr 2023 05:18:31 -0700 (PDT) Received: from localhost ([93.107.213.101]) by smtp.gmail.com with ESMTPSA id j12-20020a170902c3cc00b001a04d27ee92sm2659342plj.241.2023.04.21.05.18.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Apr 2023 05:18:31 -0700 (PDT) From: Basil Contovounesios To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#62620: 30.0.50; Unused unwind-protect in verilog-mode In-Reply-To: <87edohv664.fsf@tcd.ie> (Basil Contovounesios's message of "Tue, 18 Apr 2023 11:25:07 +0100") References: <87cz4m44rw.fsf@tcd.ie> <87edohv664.fsf@tcd.ie> Date: Fri, 21 Apr 2023 13:18:28 +0100 Message-ID: <87y1mlh1ij.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62620 Cc: 62620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Basil Contovounesios [2023-04-18 11:25 +0100] wrote: > Mattias Engdeg=C3=A5rd [2023-04-04 11:57 +0200] wrote: >> 2 apr. 2023 kl. 18.39 skrev Basil Contovounesios : >>> - (with-temp-buffer "*Verilog-Diff*" >> That's a nice catch. I didn't find any other instance of that particular= mistake in Emacs; there is one in GNU ELPA (sketch-mode.el). > > Thanks for checking. > I can submit a patch there later if no-one beats me to it. Now merged: https://github.com/dalanicolai/sketch-mode/pull/6 --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 10:22:00 2023 Received: (at 62620) by debbugs.gnu.org; 21 Apr 2023 14:22:00 +0000 Received: from localhost ([127.0.0.1]:40879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppreC-0007ny-8a for submit@debbugs.gnu.org; Fri, 21 Apr 2023 10:22:00 -0400 Received: from mail70c50.megamailservers.eu ([91.136.10.80]:40940) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppre8-0007nn-SN for 62620@debbugs.gnu.org; Fri, 21 Apr 2023 10:21:58 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1682086915; bh=hSfpJ2iKBtECaALVKzYBbr15eFbLBc08EhcVblq2Tx0=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=HMhgds19kd5ayfrwq/Jf9W15SUcgELn3uHXOAkpjHFJ55HR8eLz6kAbAM2ni9BkWy SKSOYUJj3YEVJCzJ/Lus7A0UJwTxoF0raqWekR1FmIYMN1NnslkufWVX/gHFVowRoP w261j3HOo8K1lAbp8ze5ajUxEhWDjrtdayTU8OCI= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail70c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 33LELqA0011615; Fri, 21 Apr 2023 14:21:54 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#62620: 30.0.50; Unused unwind-protect in verilog-mode From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87y1mlh1ij.fsf@tcd.ie> Date: Fri, 21 Apr 2023 16:21:52 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: <87cz4m44rw.fsf@tcd.ie> <87edohv664.fsf@tcd.ie> <87y1mlh1ij.fsf@tcd.ie> To: Basil Contovounesios X-Mailer: Apple Mail (2.3654.120.0.1.15) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrfedtgedgjeegucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthhqmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepheetteelgedujeffgfffleeggfehkefgtdekgedtkeeutdfhueeujeehffeifeegnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepudekkedrudehtddrudeihedrvdefheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpedukeekrdduhedtrdduieehrddvfeehpdhhvghlohepshhmthhptghlihgvnhhtrdgrphhplhgvpdhmrghilhhfrhhomhepmhgrthhtihgrshgvsegrtghmrdhorhhgpdhnsggprhgtphhtthhopedvpdhrtghpthhtoheptghonhhtohhvohgssehttggurdhivgdprhgtphhtthhopeeivdeivddtseguvggssghughhsrdhgnhhurdhorhhg X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 62620 Cc: 62620@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) 21 apr. 2023 kl. 14.18 skrev Basil Contovounesios : > Now merged: https://github.com/dalanicolai/sketch-mode/pull/6 Thanks for doing the legwork. Since this particular mistake doesn't seem = to be more prevalent, I'm not going to bother with adding a warning for = it unless someone talks me into it. From unknown Sat Sep 20 03:14:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 20 May 2023 11:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator