From unknown Sun Aug 17 22:02:51 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#6262 <6262@debbugs.gnu.org> To: bug#6262 <6262@debbugs.gnu.org> Subject: Status: Please learn the compiler that defface needs a doc string Reply-To: bug#6262 <6262@debbugs.gnu.org> Date: Mon, 18 Aug 2025 05:02:51 +0000 retitle 6262 Please learn the compiler that defface needs a doc string reassign 6262 emacs submitter 6262 Lennart Borgman severity 6262 normal tag 6262 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 15:48:33 2010 Received: (at submit) by debbugs.gnu.org; 24 May 2010 19:48:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGddZ-0004E4-71 for submit@debbugs.gnu.org; Mon, 24 May 2010 15:48:33 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGddX-0004Dv-CP for submit@debbugs.gnu.org; Mon, 24 May 2010 15:48:31 -0400 Received: from lists.gnu.org ([199.232.76.165]:59668) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OGddS-0006Gz-Ms for submit@debbugs.gnu.org; Mon, 24 May 2010 15:48:26 -0400 Received: from [140.186.70.92] (port=41069 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGddN-00026g-NA for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 15:48:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGddI-0004Nj-IJ for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 15:48:21 -0400 Received: from mail-gw0-f41.google.com ([74.125.83.41]:50243) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGddI-0004Ne-DG for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 15:48:16 -0400 Received: by gwb19 with SMTP id 19so937032gwb.0 for ; Mon, 24 May 2010 12:48:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:from:date :message-id:subject:to:content-type; bh=YhqCUmbefRcwBMbEq6Wr7kohanN/I5dZ5tRquFmd1fc=; b=u/Ivu/Ufr2zwU1tMSGfvs5c5yhLbeGr8obXGpc+e3QvxODZJ0c5Oif6MM0bNgozo97 Wtg/DbIZeuVtbQpnV3LD4rDUIiswHkSdrVhdzKP8nMQPPKoEqlE8SGWsuPhWiImvvH4K Uqna4ms+oRGf8nsV/7WcF+PE3/Fpb6SgyN3rc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=daFaY+1fth3lkOQyiTGCWW2hXOQIi5VJ0SYY21PtSgjeS7gM575Q5cKQzCoi/7JuXG gTIo953bl3KF3jpFqHA64PnlGG9uljrYhRvq4pFSHbOfKH1Yg9/P8EyvMFPMpYEheo2O c0hOzUGiT5tkccusXR5wHFr+h4U6ekpd4ULi4= Received: by 10.100.246.26 with SMTP id t26mr7432128anh.112.1274730493739; Mon, 24 May 2010 12:48:13 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.177.20 with HTTP; Mon, 24 May 2010 12:47:50 -0700 (PDT) From: Lennart Borgman Date: Mon, 24 May 2010 21:47:50 +0200 Message-ID: Subject: Please learn the compiler that defface needs a doc string To: Emacs Bugs Content-Type: text/plain; charset=UTF-8 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -4.8 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -4.8 (----) Otherwise I will have to learn myself that. From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 02:54:27 2010 Received: (at 6262) by debbugs.gnu.org; 26 May 2010 06:54:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHAVX-0003w1-4I for submit@debbugs.gnu.org; Wed, 26 May 2010 02:54:27 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHAVV-0003vw-DH for 6262@debbugs.gnu.org; Wed, 26 May 2010 02:54:25 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OHAVP-00031E-UW; Wed, 26 May 2010 02:54:19 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19452.50587.701065.851521@fencepost.gnu.org> Date: Wed, 26 May 2010 02:54:19 -0400 From: Glenn Morris To: 6262@debbugs.gnu.org In-Reply-To: References: Subject: Re: bug#6262: Please learn the compiler that defface needs a doc string X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 6262 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Lennart Borgman wrote (on Mon, 24 May 2010 at 21:47 +0200): > Otherwise I will have to learn myself that. Please teach yourself how to make a proper bug report. Like many of your other reports, this is lacking details. Please explain clearly what the problem actually is. From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 12:57:11 2010 Received: (at 6262) by debbugs.gnu.org; 26 May 2010 16:57:11 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHJup-0000RQ-6F for submit@debbugs.gnu.org; Wed, 26 May 2010 12:57:11 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHJum-0000RH-QL for 6262@debbugs.gnu.org; Wed, 26 May 2010 12:57:09 -0400 Received: by gyh4 with SMTP id 4so3119307gyh.3 for <6262@debbugs.gnu.org>; Wed, 26 May 2010 09:57:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=6Q1n3OsGVAo9f4sJZmZnHrE9GRNcFNep47K3N/nvqZs=; b=w5YBfUU/FNSx5BviycVLzHupJv9pOfgWSSrB1/e8sXkKopCc8wIe/N18dPIz69wmWD gboJj666o60TeF7GQxG4HEI+/ksXkA5vZBdZP+RsTtcOTmq2JkNRoCrK8otzfi64TXYC hR9GyGK3b57fbrRflsQ4eovWZ2neQ3fy0BFqM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=Tdi5Jjz7vQvEyRCy/skcy3f74P97fUZRy+5VH9TNclNnLd+lDPmR/N682phyxOMHEb jT8elqxy26GdBuZU6VljAYD+35cVGH7wqfM4buu4j3qdVetG/PyD9nrKN8HFgEsQN7JL Jp8bZhG615QvZ/F8l6xjQgSKC7zMp9zsHFo2U= Received: by 10.101.211.34 with SMTP id n34mr11086333anq.185.1274893017776; Wed, 26 May 2010 09:56:57 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.177.20 with HTTP; Wed, 26 May 2010 09:51:09 -0700 (PDT) In-Reply-To: <19452.50587.701065.851521@fencepost.gnu.org> References: <19452.50587.701065.851521@fencepost.gnu.org> From: Lennart Borgman Date: Wed, 26 May 2010 18:51:09 +0200 Message-ID: Subject: Re: bug#6262: Please learn the compiler that defface needs a doc string To: Glenn Morris Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 6262 Cc: 6262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Wed, May 26, 2010 at 8:54 AM, Glenn Morris wrote: > > Lennart Borgman wrote (on Mon, 24 May 2010 at 21:47 +0200): > >> Otherwise I will have to learn myself that. > > Please teach yourself how to make a proper bug report. > > Like many of your other reports, this is lacking details. Sorry, I will try. > Please explain clearly what the problem actually is. If you forget to add a doc string to defface it compiles "fine", i.e. without any warnings, but you get trouble later. From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 13:54:30 2010 Received: (at 6262) by debbugs.gnu.org; 26 May 2010 17:54:30 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHKoH-0001Tx-KJ for submit@debbugs.gnu.org; Wed, 26 May 2010 13:54:29 -0400 Received: from mail-fx0-f44.google.com ([209.85.161.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHKoF-0001Tr-Bc for 6262@debbugs.gnu.org; Wed, 26 May 2010 13:54:28 -0400 Received: by fxm20 with SMTP id 20so413076fxm.3 for <6262@debbugs.gnu.org>; Wed, 26 May 2010 10:54:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=2Erz+1DJSvQL2mApcOAAifw5XnuE6zWoLa8yiMGzWgY=; b=sq2SN86/T505VYSHnBvMgUHak2QOAT0iCB00uMvQD7lVv6iT4jrQpMAAD1/4o33gSR 9qmd1ez3QAjPPvgR9WGM/suQgdzYPaguK2KLmoDx/bvls7DadhmK6VxL9rSXt3/o1nGJ RmBr050LGm8vbK0XO5Dq4kXsXdxatl/LKefy0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=tTV6eY88ycTq9M/MWc1EIOjLs2RBAdGRVuVAH+PPK3HAblAG3OzRR/aIzmMxFwBvTH UoV/cxhTvfFDnee4i7FPnvCJBju8FhpFoXftAlXf0JF0mbl8SeveqcdfkeclOgi/aMRN sAYGt+BA2xh5yjlmufZ/fyi3AMPtVMzHng0yA= Received: by 10.204.81.134 with SMTP id x6mr4200262bkk.32.1274896461203; Wed, 26 May 2010 10:54:21 -0700 (PDT) MIME-Version: 1.0 Received: by 10.204.32.15 with HTTP; Wed, 26 May 2010 10:54:01 -0700 (PDT) In-Reply-To: References: <19452.50587.701065.851521@fencepost.gnu.org> From: Juanma Barranquero Date: Wed, 26 May 2010 19:54:01 +0200 Message-ID: Subject: Re: bug#6262: Please learn the compiler that defface needs a doc string To: Lennart Borgman Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 6262 Cc: Glenn Morris , 6262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.8 (--) On Wed, May 26, 2010 at 18:51, Lennart Borgman wrote: > If you forget to add a doc string to defface it compiles "fine", i.e. > without any warnings, but you get trouble later. That's still quite vague. What kind of trouble? Do you have a step-by-step recipe? Juanma From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 14:10:21 2010 Received: (at 6262) by debbugs.gnu.org; 26 May 2010 18:10:21 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHL3b-0001cB-2u for submit@debbugs.gnu.org; Wed, 26 May 2010 14:10:19 -0400 Received: from mail-gy0-f172.google.com ([209.85.160.172]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHL3Z-0001c0-JB for 6262@debbugs.gnu.org; Wed, 26 May 2010 14:10:18 -0400 Received: by gyh4 with SMTP id 4so3187302gyh.3 for <6262@debbugs.gnu.org>; Wed, 26 May 2010 11:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type; bh=mbpLeH11loXvlbbwHlxU7ansTYInTK1bxOvKMx3F/vc=; b=B6azK1s1ZL7kg4AlJbjOwvISAh1HrBnzWae5qSmtZn4I9PA61s5MAyfP4wsJVC9Wjd vyiPaty2Ulmmc0ZkprgkgXS0a8rhvi9d6F0P0rSkZoAoLHryBpBE+9nUz6EmQpvRAJyI L/pZBBZdn0LfHf5gs0NoeAXkquN+2KBuUaHF0= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; b=CvtXmYuITlmuyYfqLDzvmt/5hI2DUVwdCeZp/sDrzPF93tHnMi/3m56es69+CgcSKg jBDRRsXsS4NTppyAbz6++e/sMV92exuy6p44zzifcRJwQ82ws/p9Idnkogyn23HatxfZ eJLdw0APAuwE3cfpJ6ce26jAonJd3DVeffls4= Received: by 10.101.130.30 with SMTP id h30mr11726222ann.7.1274897409499; Wed, 26 May 2010 11:10:09 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.177.20 with HTTP; Wed, 26 May 2010 11:09:48 -0700 (PDT) In-Reply-To: References: <19452.50587.701065.851521@fencepost.gnu.org> From: Lennart Borgman Date: Wed, 26 May 2010 20:09:48 +0200 Message-ID: Subject: Re: bug#6262: Please learn the compiler that defface needs a doc string To: Juanma Barranquero Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -2.9 (--) X-Debbugs-Envelope-To: 6262 Cc: Glenn Morris , 6262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.9 (--) On Wed, May 26, 2010 at 7:54 PM, Juanma Barranquero wrote: > On Wed, May 26, 2010 at 18:51, Lennart Borgman > wrote: > >> If you forget to add a doc string to defface it compiles "fine", i.e. >> without any warnings, but you get trouble later. > > That's still quite vague. What kind of trouble? Do you have a > step-by-step recipe? Try to compile this (defface my-face '((t (:foreground "black" :background "OrangeRed"))) :group 'web-vcs) You get a warning (I misremembered), but no error. However you get an error when you try to load it. If you just eval the definition you get no warning. It would be quite nice if you got an error in both cases - especially since it is rather unlikely that you are very used to defining faces and that it is a bit special (although good) that the doc string is required. I think there is a similar problem with define-minor-mode, but I am not quite sure now. From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 14:28:05 2010 Received: (at 6262) by debbugs.gnu.org; 26 May 2010 18:28:05 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHLKm-0002Jl-R5 for submit@debbugs.gnu.org; Wed, 26 May 2010 14:28:05 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHLKl-0002JN-A6 for 6262@debbugs.gnu.org; Wed, 26 May 2010 14:28:03 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OHLKh-0006K9-2w; Wed, 26 May 2010 14:27:59 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19453.26670.986944.928676@fencepost.gnu.org> Date: Wed, 26 May 2010 14:27:58 -0400 From: Glenn Morris To: Lennart Borgman In-Reply-To: References: <19452.50587.701065.851521@fencepost.gnu.org> Subject: Re: bug#6262: Please learn the compiler that defface needs a doc string X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 6262 Cc: Juanma Barranquero , 6262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Lennart Borgman wrote (on Wed, 26 May 2010 at 20:09 +0200): > Try to compile this > > (defface my-face > '((t (:foreground "black" :background "OrangeRed"))) > :group 'web-vcs) Please, try to start at this point next time. > You get a warning (I misremembered), but no error. However you get an > error when you try to load it. > > If you just eval the definition you get no warning. You are asking for argument type checking. It is akin to asking for the compiler to warn about this: (load 'not-a-string) Pay attention to the compilation warning you do get, which indicates there is a problem. From debbugs-submit-bounces@debbugs.gnu.org Wed May 26 14:50:14 2010 Received: (at 6262) by debbugs.gnu.org; 26 May 2010 18:50:15 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHLgE-0002UN-4D for submit@debbugs.gnu.org; Wed, 26 May 2010 14:50:14 -0400 Received: from mail-gw0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OHLgB-0002UD-Va for 6262@debbugs.gnu.org; Wed, 26 May 2010 14:50:12 -0400 Received: by gwj15 with SMTP id 15so2302886gwj.3 for <6262@debbugs.gnu.org>; Wed, 26 May 2010 11:50:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:mime-version:received:in-reply-to :references:from:date:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=evTpnlnounJ3f6S6cPXsP+PwAymw1l0Adml7zgkMWFI=; b=x2/8XCqMbeRFqA5O0Ga/f0DclJ9jFo6TLYC+HT4gNn/AS+oBMmgRVSkEY/GZ0SDaOH K8DWE4gziU/QKKtdkUstg/nNnVTULakejSRj9fdmYIfaF76k1Un8VXjJL0H/fvBc55c7 73cZkl1QxiS92z/KT4hIRnqB6Ntv84QyPmxyQ= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type:content-transfer-encoding; b=fzxpa2YHXGX8AU99rjinrR59BtkaAq7Ok93PSED0LxHV+Q3z7pnoyAghb8aTfR2oly uo67BVs212CthtDlIl8l2HKEW37631Un9O2NjHcrsXAo8H3BlZyPRWhrmMloskAmZKFf M2Xhk4v3pWsq3tx0N722jQkkwylRVNNjv1Q8Y= Received: by 10.101.211.14 with SMTP id n14mr11233594anq.152.1274899803029; Wed, 26 May 2010 11:50:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.100.177.20 with HTTP; Wed, 26 May 2010 11:49:40 -0700 (PDT) In-Reply-To: <19453.26670.986944.928676@fencepost.gnu.org> References: <19452.50587.701065.851521@fencepost.gnu.org> <19453.26670.986944.928676@fencepost.gnu.org> From: Lennart Borgman Date: Wed, 26 May 2010 20:49:40 +0200 Message-ID: Subject: Re: bug#6262: Please learn the compiler that defface needs a doc string To: Glenn Morris Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.1 (---) X-Debbugs-Envelope-To: 6262 Cc: Juanma Barranquero , 6262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.1 (---) On Wed, May 26, 2010 at 8:27 PM, Glenn Morris wrote: > > Lennart Borgman wrote (on Wed, 26 May 2010 at 20:09 +0200): > >> Try to compile this >> >> (defface my-face >> =C2=A0 '((t (:foreground "black" :background "OrangeRed"))) >> =C2=A0 :group 'web-vcs) > > Please, try to start at this point next time. > >> You get a warning (I misremembered), but no error. However you get an >> error when you try to load it. >> >> If you just eval the definition you get no warning. > > You are asking for argument type checking. If you do eval-buffer with the above declaration in the buffer you get a call to custom-declare-face. A check there would be good. defcustom has such a check. define-minor-mode lacks it just as defface. > It is akin to asking for the compiler to warn about this: > > (load 'not-a-string) I guess you mean that the macros are just expanded during compilation and no call to the result is done until loading of the file. If that is what you mean then my suggestion above should work fine. Otherwise could you please explain what you mean? > Pay attention to the compilation warning you do get, which indicates > there is a problem. There is an error. Is there any reason the compile can't say that in this c= ase? From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 16:24:50 2011 Received: (at control) by debbugs.gnu.org; 21 Sep 2011 20:24:50 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TLd-0005di-KA for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:24:49 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TLb-0005da-Pb for control@debbugs.gnu.org; Wed, 21 Sep 2011 16:24:48 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R6TLE-0005sQ-Q7 for control@debbugs.gnu.org; Wed, 21 Sep 2011 22:24:24 +0200 Date: Wed, 21 Sep 2011 22:20:58 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #6262 X-MailScanner-ID: 1R6TLE-0005sQ-Q7 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1317241464.90992@nAd5OAFqo2SluauMuD3vbg X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) tags 6262 fixed close 6262 24.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 16:36:28 2011 Received: (at 6262) by debbugs.gnu.org; 21 Sep 2011 20:36:28 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TWt-0006gx-2m for submit@debbugs.gnu.org; Wed, 21 Sep 2011 16:36:28 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R6TWp-0006gX-6U for 6262@debbugs.gnu.org; Wed, 21 Sep 2011 16:36:23 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R6TWR-00069A-V2; Wed, 21 Sep 2011 22:35:59 +0200 From: Lars Magne Ingebrigtsen To: Lennart Borgman Subject: Re: bug#6262: Please learn the compiler that defface needs a doc string In-Reply-To: (Lennart Borgman's message of "Wed, 26 May 2010 20:09:48 +0200") Date: Wed, 21 Sep 2011 22:20:55 +0200 Message-ID: References: <19452.50587.701065.851521@fencepost.gnu.org> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Colder's _Heat_: "Fade Away" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1R6TWR-00069A-V2 X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1317242160.33528@nCow3Yvk2gd2zSqbU7md+A X-Spam-Status: No X-Spam-Score: -2.6 (--) X-Debbugs-Envelope-To: 6262 Cc: Juanma Barranquero , 6262@debbugs.gnu.org, Glenn Morris X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.6 (--) Lennart Borgman writes: > Try to compile this > > (defface my-face > '((t (:foreground "black" :background "OrangeRed"))) > :group 'web-vcs) > > You get a warning (I misremembered), but no error. However you get an > error when you try to load it. > > If you just eval the definition you get no warning. I now get: Debugger entered--Lisp error: (error "Keyword web-vcs is missing an argument") So this seems to have been fixed now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From unknown Sun Aug 17 22:02:51 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Oct 2011 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator