GNU bug report logs - #62606
[PATCH] function to align mode-line elements to right

Previous Next

Package: emacs;

Reported by: hugo <at> heagren.com

Date: Sun, 2 Apr 2023 04:48:03 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: hugo <at> heagren.com
Subject: bug#62606: closed (Re: bug#62606: [PATCH] function to align
 mode-line elements to right)
Date: Thu, 06 Jul 2023 07:36:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#62606: [PATCH] function to align mode-line elements to right

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 62606 <at> debbugs.gnu.org.

-- 
62606: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62606
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: hugo <at> heagren.com
Cc: 62606-done <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: Re: bug#62606: [PATCH] function to align mode-line elements to right
Date: Thu, 06 Jul 2023 10:35:20 +0300
> Date: Sun, 02 Jul 2023 13:43:21 +0100
> From: hugo <at> heagren.com
> Cc: monnier <at> iro.umontreal.ca, 62606 <at> debbugs.gnu.org
> 
> > This will need suitable additions to NEWS
> 
> New patch attached with addition to NEWS (and a version tag for the
> defcustom, which I forgot last time). I haven't marked the news item
> with +++ or ---, wasn't sure whether I've done everything I need to yet.
> 
> > and the manual
> 
> I've added documentation to the 'Mode Line Variables' section of the
> Elisp manual. This seemed to be where similar things were documented.
> Updated my commit message to reflect this.
> 
> >> I'v already assinged copyright -- I've contributed to Emacs before.
> > Yes, I see it now, sorry. (I didn't find it before because your name
> > appears in the list of assignment with a typo. Should be fixed soon.)
> 
> Do I need to update my AUTHORs entry with this new change?
> 
> Hope that's all good.

Thanks, installed on the master branch, and closing the bug.

In the future, please mention the bug number in the log message, when
that number becomes known to you (basically, if you post an updated
patch, the bug number should already be known).

[Message part 3 (message/rfc822, inline)]
From: hugo <at> heagren.com
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] function to align mode-line elements to right
Date: Sat, 01 Apr 2023 23:27:31 +0100
[Message part 4 (text/plain, inline)]
I wanted to be able to right-align some elements of the mode-line. I
used `tab-bar-format-align-right' as a base and modified it to work with
the mode-line.

The functin aligns to the right /fringe/ rather than the margin because
some modes (e.g. [visual-fill-column-mode]) mess around the margin size,
but the right-align should be unaffected by this.

Patch attached. I want to know that the code is good before I do NEWS
and docs etc. Obviously it would be useful to document this in info
(elisp) Mode Line Variables and maybe in the `mode-line-format'
docstring.

Blue skies,

Hugo


[visual-fill-column-mode]
<https://codeberg.org/joostkremers/visual-fill-column>
[0001-Support-right-align-in-mode-line.patch (text/x-diff, attachment)]

This bug report was last modified 1 year and 183 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.