From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 18:21:00 2023 Received: (at submit) by debbugs.gnu.org; 1 Apr 2023 22:21:01 +0000 Received: from localhost ([127.0.0.1]:38670 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pijam-0003CJ-7D for submit@debbugs.gnu.org; Sat, 01 Apr 2023 18:21:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:36424) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pijaj-0003CB-DS for submit@debbugs.gnu.org; Sat, 01 Apr 2023 18:20:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pijaj-00023X-0r for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 18:20:57 -0400 Received: from mail-wm1-x32c.google.com ([2a00:1450:4864:20::32c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pijag-0001qb-1Z for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 18:20:56 -0400 Received: by mail-wm1-x32c.google.com with SMTP id l37so14943188wms.2 for ; Sat, 01 Apr 2023 15:20:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1680387648; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date:message-id:reply-to; bh=g632fcOcR6uFyaNmyuXaGoh11MMV1Awfc40Etg14K8w=; b=P9gLeN9NwjMKbuM37Ub1BypR4DMDAb1ytIy3Gk64oe+85eqrK7+fJHCq7gJ7nAOdG3 f6xLHYa5mQ9maoe6RG5YHfH70C5YoirqxR2RdSQ19Md3byseOy3TWSeW2Ma1vJ3Sjzla x4+0waksIOUKf2DJdq9mpX8H3WOlqzQP1jR3WtTFXmZkDrok8SSaAcIQ/FeVDAfjsxeI 6se1tfSHhq1Fj8eXui9KBr8tM6uEYsKmEcLlpg8JF6H+TAmLNpX9C5an1LQnDZ4cQVw0 NmHSXaNlS4k0+hnby9L1tivrBQW0i0Lz3qKGC4aWZdzBQATd9MxTq8+SV94crmlGSyfE kifw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680387648; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=g632fcOcR6uFyaNmyuXaGoh11MMV1Awfc40Etg14K8w=; b=ZMqQAZ6zI1JQrgAEIIsrJbOIFbNgF2NnsdLJYrjvPapjEEI5UfKw0luV11ngD9iPkd ObSNa8zRN25ysTYCABdo+O7/FYanPPAyCxdS0/0yuso+e6H00KIIc7/cBPNst0E89D0W 8m/fpHXuYqHtu170UmTGhgCmBpuzbVAkjfoh328ObkXqQG2S8zD0pvna02+M+DZE6jBa r54H1qcj9n5ee1oLlhOA4Q08OL3AkGYLxf69Kkxc7gGG/yQ9TUVqu2pQY5VzCONzol6G 7xdSHJ5GcxlSiOpMCDiRCXvpIiwM0DHgLB8jh1/vTgZbH9rk9u/Q+vC+xdttj4ySuWSk mvyA== X-Gm-Message-State: AO0yUKXNOdC/EhVS+EN/Xi5ozuav/MGUFOPY+pA8MtmVayKcnp8xthYD SCraBLBUERTSegoIPJ3KNgRFHfqKzL0AnkRIJ+I= X-Google-Smtp-Source: AK7set95SxIyaM5pSCjqG3uwPXXQkb652645Gdde3dGGBUt9mjmEyrjLcnVDbNahEp4ZFrweLgvGGw== X-Received: by 2002:a7b:ca4a:0:b0:3ea:e582:48dd with SMTP id m10-20020a7bca4a000000b003eae58248ddmr23145889wml.34.1680387648143; Sat, 01 Apr 2023 15:20:48 -0700 (PDT) Received: from localhost ([109.78.116.250]) by smtp.gmail.com with ESMTPSA id p12-20020a05600c358c00b003ef6f87118dsm14810888wmq.42.2023.04.01.15.20.46 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Apr 2023 15:20:47 -0700 (PDT) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Improve ibuffer-diff-with-file Date: Sat, 01 Apr 2023 23:20:46 +0100 Message-ID: <875yafkzwh.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::32c; envelope-from=contovob@tcd.ie; helo=mail-wm1-x32c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Byte-compiling ibuf-ext.el currently emits the following warning: In ibuffer-diff-buffer-with-file-1: ibuf-ext.el:1660:8: Warning: =E2=80=98unwind-protect=E2=80=99 without unw= ind forms Trying out ibuffer-diff-with-file, I also see some undesirable behaviour: 0. emacs -Q 1. M-x find-library RET ibuf-ext RET 2. C-o 3. M-x find-library RET ibuffer RET 4. C-o 5. M-x ibuffer RET 6. * u =3D The resulting *Ibuffer Diff* buffer opens with two empty lines and point on the second, and closes with two 'Diff finished' sentinel lines. The attached patch fixes these issues, bringing ibuffer-diff-with-file more in line with its apparent inspiration, diff-buffer-with-file. WDYT? BTW, just curious: why is diff-command called through the shell in diff-no-select (and ibuffer-diff-with-file), rather than directly? Thanks, --=20 Basil --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Improve-ibuffer-diff-with-file.patch >From 9d6d39c237bbe4a4cb333d1258b4e732988ee8e0 Mon Sep 17 00:00:00 2001 From: "Basil L. Contovounesios" Date: Sat, 1 Apr 2023 15:14:34 +0100 Subject: [PATCH] Improve ibuffer-diff-with-file * lisp/ibuf-ext.el (ibuffer-diff-with-file): Link to diff-command in docstring. Make Diff buffer read-only from outset and inhibit as needed to avoid surprises. Check whether diff-command supports --label. Leave point at BOB and clean up any excess newline inserted by ibuffer-diff-buffer-with-file-1. Prefer pop-to-buffer-same-window over switch-to-buffer. (ibuffer-diff-buffer-with-file-1): Add docstring. Remove unused unwind-protect and copypasta from diff-no-select. Use diff-file-local-copy, string-join, and redisplay in place of analogues. Condition --label use on availability, and label buffers consistently with diff-no-select. Leave empty line between runs. Let diff-sentinel delete temporary files. Leave point at EOB for next run. --- lisp/ibuf-ext.el | 93 ++++++++++++++++++++++++------------------------ 1 file changed, 46 insertions(+), 47 deletions(-) diff --git a/lisp/ibuf-ext.el b/lisp/ibuf-ext.el index ed4c8a04db7..550b5ed0e6a 100644 --- a/lisp/ibuf-ext.el +++ b/lisp/ibuf-ext.el @@ -1650,68 +1650,67 @@ ibuffer-jump-to-buffer (error "No buffer with name %s" name) (goto-char buf-point))))) +(declare-function diff-check-labels "diff" (&optional force)) +(declare-function diff-file-local-copy "diff" (file-or-buf)) (declare-function diff-sentinel "diff" (code &optional old-temp-file new-temp-file)) (defun ibuffer-diff-buffer-with-file-1 (buffer) - (let ((bufferfile (buffer-local-value 'buffer-file-name buffer)) - (tempfile (make-temp-file "buffer-content-"))) - (when bufferfile - (unwind-protect - (progn - (with-current-buffer buffer - (write-region nil nil tempfile nil 'nomessage)) - (let* ((old (expand-file-name bufferfile)) - (new (expand-file-name tempfile)) - (oldtmp (file-local-copy old)) - (newtmp (file-local-copy new)) - (switches diff-switches) - (command - (mapconcat - 'identity - `(,diff-command - ;; Use explicitly specified switches - ,@(if (listp switches) switches (list switches)) - ,@(if (or old new) - (list "-L" (shell-quote-argument old) - "-L" (shell-quote-argument - (format "Buffer %s" (buffer-name buffer))))) - ,(shell-quote-argument (or oldtmp old)) - ,(shell-quote-argument (or newtmp new))) - " "))) - (let ((inhibit-read-only t)) - (insert command "\n") - (diff-sentinel - (call-process shell-file-name nil - (current-buffer) nil - shell-command-switch command)) - (insert "\n"))))) - (sit-for 0) - (when (file-exists-p tempfile) - (delete-file tempfile))))) + "Compare BUFFER with its associated file, if any. +Unlike `diff-no-select', insert output into current buffer +without erasing it." + (when-let ((old (buffer-file-name buffer))) + (defvar diff-use-labels) + (let* ((new buffer) + (oldtmp (diff-file-local-copy old)) + (newtmp (diff-file-local-copy new)) + (switches diff-switches) + (command + (string-join + `(,diff-command + ,@(if (listp switches) switches (list switches)) + ,@(and (eq diff-use-labels t) + (list "--label" (shell-quote-argument old) + "--label" (shell-quote-argument (format "%S" new)))) + ,(shell-quote-argument (or oldtmp old)) + ,(shell-quote-argument (or newtmp new))) + " ")) + (inhibit-read-only t)) + (insert ?\n command ?\n) + (diff-sentinel (call-process shell-file-name nil t nil + shell-command-switch command) + oldtmp newtmp) + (goto-char (point-max))) + (redisplay))) ;;;###autoload (defun ibuffer-diff-with-file () "View the differences between marked buffers and their associated files. If no buffers are marked, use buffer at point. -This requires the external program \"diff\" to be in your `exec-path'." +This requires the external program `diff-command' to be in your +`exec-path'." (interactive) (require 'diff) - (let ((marked-bufs (ibuffer-get-marked-buffers))) - (when (null marked-bufs) - (setq marked-bufs (list (ibuffer-current-buffer t)))) - (with-current-buffer (get-buffer-create "*Ibuffer Diff*") - (setq buffer-read-only nil) - (buffer-disable-undo (current-buffer)) - (erase-buffer) - (buffer-enable-undo (current-buffer)) + (let ((marked-bufs (or (ibuffer-get-marked-buffers) + (list (ibuffer-current-buffer t)))) + (diff-buf (get-buffer-create "*Ibuffer Diff*"))) + (with-current-buffer diff-buf + (setq buffer-read-only t) + (buffer-disable-undo) + (let ((inhibit-read-only t)) + (erase-buffer)) + (buffer-enable-undo) (diff-mode) + (diff-check-labels) (dolist (buf marked-bufs) (unless (buffer-live-p buf) (error "Buffer %s has been killed" buf)) - (ibuffer-diff-buffer-with-file-1 buf)) - (setq buffer-read-only t))) - (switch-to-buffer "*Ibuffer Diff*")) + (ibuffer-diff-buffer-with-file-1 buf)) + (goto-char (point-min)) + (when (= (following-char) ?\n) + (let ((inhibit-read-only t)) + (delete-char 1)))) + (pop-to-buffer-same-window diff-buf))) ;;;###autoload (defun ibuffer-copy-filename-as-kill (&optional arg) -- 2.39.2 --=-=-= Content-Type: text/plain In GNU Emacs 30.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2023-04-01 built on tia Repository revision: 626f2f744104bc14c28456134cf75ff2f16d9901 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101007 System Description: Debian GNU/Linux 12 (bookworm) Configured using: 'configure 'CFLAGS=-Og -ggdb3' -C --prefix=/home/blc/.local --enable-checking=structs --with-file-notification=yes --with-x-toolkit=lucid --with-x' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP X11 XAW3D XDBE XIM XINPUT2 XPM LUCID ZLIB Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search time-date subr-x mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 36572 9347) (symbols 48 5171 0) (strings 32 13854 1584) (string-bytes 1 377429) (vectors 16 9294) (vector-slots 8 148577 13143) (floats 8 23 25) (intervals 56 245 0) (buffers 984 10)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 18:59:23 2023 Received: (at control) by debbugs.gnu.org; 1 Apr 2023 22:59:23 +0000 Received: from localhost ([127.0.0.1]:38695 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pikBv-0004PO-By for submit@debbugs.gnu.org; Sat, 01 Apr 2023 18:59:23 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:35766) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pikBt-0004PA-IO for control@debbugs.gnu.org; Sat, 01 Apr 2023 18:59:22 -0400 Received: by mail-wr1-f41.google.com with SMTP id l27so25811354wrb.2 for ; Sat, 01 Apr 2023 15:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1680389955; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=+rQYj8zjGGeG6YxDCvb8yTYHpVOvRrAD7h0VpKUYv/A=; b=KzWtrqjCLLJxFZ6xMjiOJJqYhjBlOWFSR1n6Od6pf1uj+dmPBJjCSOOh9xf0pvvAwY /hliW+IBTT1mOMPkuxgomohbSA3/R4hEZNd9WZbXVVXcrX+vyxF5wcddGKFesivX6ozg +uf8Qm6GdNHdQVl+NHefuOt8/FKk69fLLO2DhjjNnF/43m0aJIk2/pclduhggAIaEc/S ALC+zxHqgQbExNYDwcNVh5ThVv9Zan0c6pNMkBVtXQf3YJfsGDh3G7bcnXvtRtYYMZLa WcsUayhusH4tmp8wNykuXlkDKFC6AOhJ3i6X2RPcJxfhqa6Y7eeXOTZphsfBd7wILU+r 4/pg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680389955; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=+rQYj8zjGGeG6YxDCvb8yTYHpVOvRrAD7h0VpKUYv/A=; b=QbaM6vb+P09HkQ1Rv2II4rFBDWjJD03QXdH+w3Z/xmyI7b0JZqG0RqSCYjTUxoQxiZ ksjpTmE6ksFC8zCqcgt4rJyTi0tWYRiyVEjOBLHbrDwrRqkzlx/Nn+BPyLorCxQWB5wx Pnut0WinqbJQ21JxXmIpEfHJEQM+2VmJfDyhe6ysHkV+9RiWnQthMEU7l2Qal5eATInf GHwy6kaZ3jhmSYysqurL57SqOP2o3tGfz+d0PlR0daQrV4u2tNqik5dhuFKJEAmcanBk +WGCZDzdRbuqzlfIKvu74OQJRyTM1J6/cordHZubIsdSCH0VXWMsDeZAWDj9auqEeMqH VONQ== X-Gm-Message-State: AAQBX9cY873uQbGZQmxXrJSRwTrGn/EWwgsqPD5dvOfrsvvR9iSjvc33 yvERamxaEUwdL3JfylM9SWGTL4BMEzZpatMGMXI= X-Google-Smtp-Source: AKy350ay3nswwqQi0/IU+KcycvPPmRbIrt580Sl326ZOurr1wlqV7KbC3Ez3LCwegcnxO4Z3EI9FIA== X-Received: by 2002:a5d:5410:0:b0:2cf:e336:cb14 with SMTP id g16-20020a5d5410000000b002cfe336cb14mr10917114wrv.10.1680389955417; Sat, 01 Apr 2023 15:59:15 -0700 (PDT) Received: from localhost ([109.78.116.250]) by smtp.gmail.com with ESMTPSA id z7-20020a7bc7c7000000b003ed1f111fdesm7356311wmk.20.2023.04.01.15.59.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 01 Apr 2023 15:59:15 -0700 (PDT) From: "Basil L. Contovounesios" To: control@debbugs.gnu.org Subject: control message for bug #62599 Date: Sat, 01 Apr 2023 23:59:14 +0100 Message-ID: <878rfbnr99.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 62599 + patch severity 62599 minor found 62599 24.5.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 04:25:03 2023 Received: (at 62599) by debbugs.gnu.org; 2 Apr 2023 08:25:03 +0000 Received: from localhost ([127.0.0.1]:39190 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pit1K-00064v-Po for submit@debbugs.gnu.org; Sun, 02 Apr 2023 04:25:03 -0400 Received: from mail238c50.megamailservers.eu ([91.136.10.248]:50324 helo=mail56c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pit1G-00064M-2k for 62599@debbugs.gnu.org; Sun, 02 Apr 2023 04:24:59 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1680423895; bh=bexNbK2tvhxFQV7w5RRqYrggFQWtDdO/WzB2g+jqjRg=; h=From:Subject:Date:Cc:To:From; b=B0JX0xJ2td6Z1p96Iy/FomEoY65c5KPEubsDH4D3W7OvQ/jYAvxl720/CR4Rc+CZz pmhV4r/2g94R6wXb+Ons2fP9oBJBje0s0AvSCCgNZAir/UkUvodpAmL8HOeSSk/wgd PCkedX1D/xtJDw3n5JkluzQQxxxpDzeR2jr45Opk= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail56c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 3328OrUw115314; Sun, 2 Apr 2023 08:24:55 +0000 From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Subject: bug#62599: 30.0.50; Improve ibuffer-diff-with-file Message-Id: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> Date: Sun, 2 Apr 2023 10:24:52 +0200 To: "Basil L. Contovounesios" X-Mailer: Apple Mail (2.3654.120.0.1.14) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeihedgtdduucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpefhtgfgggfukfffvefvofesthhqmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepudekueejlefgkeejjeegudevvefhgfekudeggedvfeejfefgleetjedtvedvhfeunecukfhppedukeekrdduhedtrdduieehrddvfeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudekkedrudehtddrudeihedrvdefhedphhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpmhgrihhlfhhrohhmpehmrghtthhirghsvgesrggtmhdrohhrghdpnhgspghrtghpthhtohepvddprhgtphhtthhopegtohhnthhovhhosgesthgtugdrihgvpdhrtghpthhtohepiedvheelleesuggvsggsuhhgshdrghhnuhdrohhrgh X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 62599 Cc: 62599@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Thank you -- I'm no buffer expert but see no obvious flaws. `verilog-diff-file-with-buffer` in verilog-mode.el looks vaguely = similar, down to the dodgy unwind-protect, but it has stronger = compatibility requirements so it probably can't use more recent diff = machinery. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 09:31:39 2023 Received: (at 62599) by debbugs.gnu.org; 2 Apr 2023 13:31:39 +0000 Received: from localhost ([127.0.0.1]:39349 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pixo3-0000qA-5k for submit@debbugs.gnu.org; Sun, 02 Apr 2023 09:31:39 -0400 Received: from mail1442c50.megamailservers.eu ([91.136.14.42]:39168 helo=mail264c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pixny-0000pu-Mj for 62599@debbugs.gnu.org; Sun, 02 Apr 2023 09:31:37 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1680442288; bh=htjc39zLyEwOtgpdT+H4NMVimfRQjW6kDNFbNO8L3rk=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=OToCoTX5MBYmhyoXse/e+LKgCWUB5p0oZ81Mhfv3dBQimFKoHI5YjIZAQa6vkyjqR B2Ao5myhf0e591EaR0H/F7aQ+C6LpUrkiYFvIHZ+veUzggzQ1BJBgmhWPWeUy0QGE/ K1jIDxDdex3ZVmc3fheNGcrMJCmq5UY/mWeK1Yws= Feedback-ID: mattiase@acm.or Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se [188.150.165.235]) (authenticated bits=0) by mail264c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 332DVPOc030880; Sun, 2 Apr 2023 13:31:27 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.14\)) Subject: Re: bug#62599: 30.0.50; Improve ibuffer-diff-with-file From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> Date: Sun, 2 Apr 2023 15:31:25 +0200 Content-Transfer-Encoding: 7bit Message-Id: <6CCFD86F-2969-44EF-AD78-F60CD4DC3401@acm.org> References: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> To: "Basil L. Contovounesios" X-Mailer: Apple Mail (2.3654.120.0.1.14) X-VADE-SPAMSTATE: clean X-VADE-SPAMSCORE: -100 X-VADE-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeihedgieehucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecujffquffvqffrkfetpdfqfgfvpdfgpfggqdevhedtnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenucfjughrpegtggfuhfgjffevgffkfhfvofesthejmhdthhdtvdenucfhrhhomhepofgrthhtihgrshcugfhnghguvghgnohrugcuoehmrghtthhirghsvgesrggtmhdrohhrgheqnecuggftrfgrthhtvghrnhepgfeufeelteduvedvkeevvdfhgeehjedvjeeigedvudefheegffejudefjefhjeffnecukfhppedukeekrdduhedtrdduieehrddvfeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepudekkedrudehtddrudeihedrvdefhedphhgvlhhopehsmhhtphgtlhhivghnthdrrghpphhlvgdpmhgrihhlfhhrohhmpehmrghtthhirghsvgesrggtmhdrohhrghdpnhgspghrtghpthhtohepvddprhgtphhtthhopegtohhnthhovhhosgesthgtugdrihgvpdhrtghpthhtohepiedvheelleesuggvsggsuhhgshdrghhnuhdrohhrgh X-Origin-Country: SE X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 62599 Cc: 62599@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) > Thank you -- I'm no buffer expert but see no obvious flaws. (No obvious flaws with your patch, that is.) From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 12:44:20 2023 Received: (at 62599) by debbugs.gnu.org; 2 Apr 2023 16:44:20 +0000 Received: from localhost ([127.0.0.1]:42512 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj0oV-00010I-Ld for submit@debbugs.gnu.org; Sun, 02 Apr 2023 12:44:19 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:38859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj0oS-000103-4K for 62599@debbugs.gnu.org; Sun, 02 Apr 2023 12:44:18 -0400 Received: by mail-wm1-f42.google.com with SMTP id l15-20020a05600c4f0f00b003ef6d684102so13039292wmq.3 for <62599@debbugs.gnu.org>; Sun, 02 Apr 2023 09:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1680453850; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=rxTJ77Qo97k/QQkcykzaUU/+j7IdvkW3ZUX7nKn7GZY=; b=fwy2w8HvypYeNybveI9RCc5QqRuJ9YZBIRWkXLYgHkBuBuBnQTfn//TyphO6EvFNAA Qoi93HKgU1a8mO8W6CV70FloQAT+vcFD6oKbaRPq8slyeF9EZzMJMthP2fOTZ/kshRIY BrjTG2bQebD0X80QvUYHUY5j/oppzD5FgOpiTZQUG5OqZ+SQCi3AKhffJvVj8SjXijKy LnOkbR2pHCUZPSbkgVxu7LImDW+GaE9cCIQiqgtEBnFo3mk8XVlTmiKDzlK9ZFGzTnXR as4s9L3+EDJRdH0TVL32IideVwgiTm4PDRe4wNgPU88r6l96mtCoKGfROlmKKH52wbmf LGjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680453850; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=rxTJ77Qo97k/QQkcykzaUU/+j7IdvkW3ZUX7nKn7GZY=; b=ov5mWAT7vqWgNElwneXBcrnEhfk9aVh4qEyVXbsxw7cZcjACkrVdMSRLMIHuFbQTvr qTAHWFmr1+UMw44CT+eCrnoPDqgMDeYo5atNQe5KGTEJWSviYGI90DEyxN0m7BiNoM3U P0sQ9BtImwcJyQSouykAgqPosQy9FpBFrKlA6IKIMXvJ2CKnfJC103dUtgGgRCSUFUh2 74awqOrPo5rwKej4oIdT59eFdjPCmYxwVupBxtKMhFlUvjgqGEYPLTwkguoDjCb4q6st 1Bq5NE+IXRIe9qoAo0zYU0XJxZi5G9joKMuMZMy5AzfbK6edUrylHfvvorUUhenwUaFq x+Zg== X-Gm-Message-State: AO0yUKVqAu491hnYhUH1iOtugfXmf+hhGab0WnLioJHeP8svr2llBSjE oDK5zvJd/nQN40rRBikba2nBJ1oR1N1Vz3pT6BU= X-Google-Smtp-Source: AK7set86V/CCyDiKInT74C+mtBSnFU9PiaPFFrv9pK03OKOPLN9qxazDeqmeWEI82mYcq8u3HhMZ7w== X-Received: by 2002:a05:600c:204:b0:3ea:d620:57a7 with SMTP id 4-20020a05600c020400b003ead62057a7mr26172412wmi.8.1680453850219; Sun, 02 Apr 2023 09:44:10 -0700 (PDT) Received: from localhost ([51.37.77.228]) by smtp.gmail.com with ESMTPSA id v20-20020a7bcb54000000b003ed2c0a0f37sm9476087wmj.35.2023.04.02.09.44.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 09:44:09 -0700 (PDT) From: Basil Contovounesios To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#62599: 30.0.50; Improve ibuffer-diff-with-file In-Reply-To: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 2 Apr 2023 10:24:52 +0200") References: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> Date: Sun, 02 Apr 2023 17:44:09 +0100 Message-ID: <87zg7q2q06.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62599 Cc: 62599@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd [2023-04-02 10:24 +0200] wrote: > Thank you -- I'm no buffer expert but see no obvious flaws. Thanks for reviewing. I'll wait a few more days for comments before pushing. > `verilog-diff-file-with-buffer` in verilog-mode.el looks vaguely > similar, down to the dodgy unwind-protect, but it has stronger > compatibility requirements so it probably can't use more recent diff > machinery. Oh, that reminded me that call-process has a DISPLAY parameter. I guess in ibuffer-diff-buffer-with-file-1 we're still interested in calling redisplay after diff-sentinel, though: Basil L. Contovounesios [2023-04-01 23:20 +0100] wrote: > + (diff-sentinel (call-process shell-file-name nil t nil > + shell-command-switch command) > + oldtmp newtmp) > + (goto-char (point-max))) > + (redisplay))) I opened https://bugs.gnu.org/62620 for the Verilog case. Thanks, --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 12:45:13 2023 Received: (at 62599) by debbugs.gnu.org; 2 Apr 2023 16:45:13 +0000 Received: from localhost ([127.0.0.1]:42517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj0pN-00012C-2O for submit@debbugs.gnu.org; Sun, 02 Apr 2023 12:45:13 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:52897) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj0pI-00011s-1y for 62599@debbugs.gnu.org; Sun, 02 Apr 2023 12:45:11 -0400 Received: by mail-wm1-f49.google.com with SMTP id l37so15721538wms.2 for <62599@debbugs.gnu.org>; Sun, 02 Apr 2023 09:45:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1680453902; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fTSqhIca0UNPloBn5WamevaH7RcCto5DCbN8bZZLou0=; b=U5QSsnvSEtJiG2mCzf0jJmXW0TMvkrXviMrg0WWO2253fNGzk14TPsP0+7iX7TAJ1K yLLF49+VTKrn6MTw2FGlpNXOKTiVCvjgFVPCHWI1AN71O5lX6S7m8FGSDPyU2mTwoLXk PsWPQbZKiIx6VYlNrmgSr8LFh7Jw88mVV0mJ204lVNWG9q1uhaeiGi9BsZYLhABHojR2 iZe4AX5WrNUdsjSJPbC78g7kFkq9BXG6CdULlIqoFrXOSjpk0LB/5GCjhMgbBHJ19QKC 14rjpLwqA8pzOev/AhaoNSCxEFFUP4f29id/qtGqqo26Rcof1eyT127ri272hn4l3qyc q5Tw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680453902; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=fTSqhIca0UNPloBn5WamevaH7RcCto5DCbN8bZZLou0=; b=Jy//ez22kDEmup3FGKDpBdJRffiVXg8OWDxTp2m3+NFf5tIZVJM7CArHNEw/HVZaXU KPhJX3SQGwphYeQXy2Bc09FpsYO9m/RQxNv8Z++ARmpWHva7KmexzqYg6xXxckDtoGHu KgXklcUf4BGf+jeR2p2SDAYGQCsE7+LRT0FMv/Z5ZENjPp2oJ633gaV+AQFLhSV5XPjG rWxoSJpOdLS3wicnnzw72CqM1j2YZCa/yisbgvg+mNdQF6X0BEZBc+m1xIEoi8iYZ43K GqkojQ3sCaAoIY6Avt+MdmSASaE8gN0CPUt0qPJR2eJ3Xis9HxOWKDT3uQd5PdvtqxO0 CgCg== X-Gm-Message-State: AO0yUKXFiuVMA6zb8Krv1zSVBQ7s+spEsTolmEf67D4WHskAPSA5tynA DEf41WULZ0lhmZSsE7WWcl2rkg== X-Google-Smtp-Source: AK7set/mX50vZYP4JVBprYzH3Jl6LlXH7JfKt7Q7NK/uVXrVDjywczGyQYXhf9/06QZXuy4D8YD7uw== X-Received: by 2002:a05:600c:204d:b0:3ed:e6c8:f11d with SMTP id p13-20020a05600c204d00b003ede6c8f11dmr24801807wmg.7.1680453902425; Sun, 02 Apr 2023 09:45:02 -0700 (PDT) Received: from localhost ([51.37.77.228]) by smtp.gmail.com with ESMTPSA id w20-20020a05600c475400b003f034c76e85sm13666117wmo.38.2023.04.02.09.45.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Apr 2023 09:45:02 -0700 (PDT) From: Basil Contovounesios To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#62599: 30.0.50; Improve ibuffer-diff-with-file In-Reply-To: <6CCFD86F-2969-44EF-AD78-F60CD4DC3401@acm.org> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sun, 2 Apr 2023 15:31:25 +0200") References: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> <6CCFD86F-2969-44EF-AD78-F60CD4DC3401@acm.org> Date: Sun, 02 Apr 2023 17:45:01 +0100 Message-ID: <87v8ie2pyq.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62599 Cc: 62599@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd [2023-04-02 15:31 +0200] wrote: >> Thank you -- I'm no buffer expert but see no obvious flaws. > > (No obvious flaws with your patch, that is.) Good - I try to keep my obvious character flaws out of my patches ;). --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 08 06:56:32 2023 Received: (at control) by debbugs.gnu.org; 8 Apr 2023 10:56:32 +0000 Received: from localhost ([127.0.0.1]:57810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl6FE-0000EX-Ag for submit@debbugs.gnu.org; Sat, 08 Apr 2023 06:56:32 -0400 Received: from mail-wr1-f41.google.com ([209.85.221.41]:46604) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pl6F8-0000B7-9T for control@debbugs.gnu.org; Sat, 08 Apr 2023 06:56:29 -0400 Received: by mail-wr1-f41.google.com with SMTP id v29so745282wra.13 for ; Sat, 08 Apr 2023 03:56:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1680951380; x=1683543380; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BMD5J0fNJ2EUWnh08zMIjrx06AyxHgbqhygU8/wwO8Q=; b=ZyeAqfyEbHcESH58lYhdn7/enZ0LbOGn9JSXvevjaDW27EB+Ohh+2Qut0ZIfcrEMH/ erRMsRrZ0ZldmD3g7LdHwEB8wBWe0k3P6sWNESFm+n5zJEpW1+/KepJHnl2jzcjZILQs bDwHTbw0LV+LaKoQw3RmBfGZL3uFHr85timVydIb0o6Mw++Typa5fUqR27NXfl3+M4qi NlRsZn3cNfw1/Ta8g+sofksbjpFVGkYUzeWYdkgt5uinBkolFEXcVSuhiXbTpxwvbbvR 0/EfgNqL7m8CkUWGBpf5C/mewTML65FQZkHJTci+aaQkffmLtqABbWNEEIHJbXd/TOEQ HeGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680951380; x=1683543380; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=BMD5J0fNJ2EUWnh08zMIjrx06AyxHgbqhygU8/wwO8Q=; b=IaU/Jt1wx3alL98yXe0rYUx8RTXtcQrheX/KfIcm3cGHf62lBMphRkMTMICx0nMQVY 5c7CySYnJa3BwN/40qoIjlWow2m5ajH9Su3SjW4qXJO6svML9P7r7N0tytLrGYYv6G0P +nB3uT4zWcXju5z8eHBP+rvu6S0a6tp7GrK5EQBKe2FwOj4FWeMXx1mbuy3wN3IsjUDa 7RhGajmsEWK8vSGSPQRaeH0WwW5tk0C7L++fl2D5YxpI88rIU4BXO5WD3pVMgc0ihrdw Bpki81nf8iYrrVcXW6Tc9ET2HrthAqzF1W/kQNdplNb00gIIQDEdQRkDD3nK9A79HhoD 89cA== X-Gm-Message-State: AAQBX9fjGvIi+ibxm7lOp7pbuujtPu2HDWVBcJlAag3UKkul7anWHbjg 3HEBaSjU87VXc909SytshhnzWg== X-Google-Smtp-Source: AKy350bg9H8FjO7Xy03HxpX6kZc+gVJx/QerHGMs90L2XCLqk8h8SRcuhrWkGXtEqqy5q37gtIY1lw== X-Received: by 2002:a5d:4a43:0:b0:2cf:e3a9:c189 with SMTP id v3-20020a5d4a43000000b002cfe3a9c189mr3652684wrs.3.1680951380506; Sat, 08 Apr 2023 03:56:20 -0700 (PDT) Received: from localhost ([51.37.96.208]) by smtp.gmail.com with ESMTPSA id z18-20020adfec92000000b002efbb93c461sm935829wrn.25.2023.04.08.03.56.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 03:56:19 -0700 (PDT) From: Basil Contovounesios To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#62599: 30.0.50; Improve ibuffer-diff-with-file In-Reply-To: <87zg7q2q06.fsf@tcd.ie> (Basil Contovounesios's message of "Sun, 02 Apr 2023 17:44:09 +0100") References: <8C7E5ED2-1FC7-42F8-AF1F-F4F6024DE033@acm.org> <87zg7q2q06.fsf@tcd.ie> Date: Sat, 08 Apr 2023 11:56:18 +0100 Message-ID: <87ile6hcbx.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: 62599-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 62599 30.1 quit Basil Contovounesios [2023-04-02 17:44 +0100] wrote: > Mattias Engdeg=C3=A5rd [2023-04-02 10:24 +0200] wrote: > >> Thank you -- I'm no buffer expert but see no obvious flaws. > > Thanks for reviewing. I'll wait a few more days for comments before > pushing. Done and closing. Improve ibuffer-diff-with-file 10b58633b56 2023-04-08 11:51:43 +0100 https://git.sv.gnu.org/cgit/emacs.git/commit/?id=3D10b58633b56 Thanks, --=20 Basil From unknown Tue Jun 17 22:09:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 06 May 2023 11:24:10 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator