GNU bug report logs - #6259
24.0.50; `uniquify.el' advises `create-file-buffer'

Previous Next

Package: emacs;

Reported by: "Drew Adams" <drew.adams <at> oracle.com>

Date: Mon, 24 May 2010 17:04:03 UTC

Severity: minor

Tags: confirmed

Merged with 1338

Found in versions 24.0.50, 24.3.50, 25.0.94

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: "Drew Adams" <drew.adams <at> oracle.com>
Cc: 6259 <at> debbugs.gnu.org
Subject: bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer'
Date: Sun, 01 May 2016 19:53:00 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> And since uniquify is the default now, it should probably be fixed:
>
> --------
>
> create-file-buffer is a compiled Lisp function in `files.el'.
>
> (create-file-buffer ARG1)
>
> :around advice: `uniquify--create-file-buffer-advice'
>
> --------

And amusingly enough, there's this comment in the file:

;; The below solution works because generate-new-buffer-name is called
;; only by rename-buffer (which, as of 19.29, is never called from C) and
;; generate-new-buffer, which is called only by Lisp functions
;; create-file-buffer and rename-uniquely. 

This isn't...  er...  very true any more.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
This bug report was last modified 3 years and 143 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.