From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 13:03:35 2010 Received: (at submit) by debbugs.gnu.org; 24 May 2010 17:03:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGb3u-0002wO-Sb for submit@debbugs.gnu.org; Mon, 24 May 2010 13:03:35 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGb3r-0002wI-OZ for submit@debbugs.gnu.org; Mon, 24 May 2010 13:03:32 -0400 Received: from lists.gnu.org ([199.232.76.165]:33063) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1OGb3n-0002NJ-2P for submit@debbugs.gnu.org; Mon, 24 May 2010 13:03:27 -0400 Received: from [140.186.70.92] (port=54749 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OGb3f-0004pS-L9 for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 13:03:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OGb3Y-0007Om-KW for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 13:03:19 -0400 Received: from rcsinet10.oracle.com ([148.87.113.121]:42006) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGb3Y-0007OY-BU for bug-gnu-emacs@gnu.org; Mon, 24 May 2010 13:03:12 -0400 Received: from acsinet15.oracle.com (acsinet15.oracle.com [141.146.126.227]) by rcsinet10.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o4OH38Qa001535 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 24 May 2010 17:03:09 GMT Received: from acsmt355.oracle.com (acsmt355.oracle.com [141.146.40.155]) by acsinet15.oracle.com (Switch-3.4.2/Switch-3.4.1) with ESMTP id o4OFc0dK009406 for ; Mon, 24 May 2010 17:03:07 GMT Received: from abhmt004.oracle.com by acsmt353.oracle.com with ESMTP id 293569471274720586; Mon, 24 May 2010 10:03:06 -0700 Received: from dradamslap1 (/130.35.178.194) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 24 May 2010 10:03:06 -0700 From: "Drew Adams" To: Subject: 24.0.50; `uniquify.el' advises `create-file-buffer' Date: Mon, 24 May 2010 10:03:04 -0700 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.5931 Thread-Index: Acr7YvmM49X4LnhXQRCZ8GdQLJ6k+w== X-Auth-Type: Internal IP X-Source-IP: acsinet15.oracle.com [141.146.126.227] X-CT-RefId: str=0001.0A090201.4BFAB14E.0109:SCFMA922111,ss=1,fgs=0 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) 1. I thought that distributed Emacs code was not supposed to use `defadvice'. `uniquify.el' uses it. 2. That advice makes the doc for `create-file-buffer' incorrect: emacs -Q C-h f create-file-buffer RET There is nothing about the function being advised. Now turn on `Use Directory Names in Buffer Names' from the `Options' menu. C-h f create-file-buffer RET You now see this added to the doc string: This function is advised. After-advice `create-file-buffer-uniquify': Uniquify buffer names with parts of directory name. Now turn using directory names back off again, using the same menu item. C-h f create-file-buffer RET still says the same thing. It _seems_ to be saying (and it will be read this way) that buffer names are currently being uniquified with parts of buffer names - which is incorrect. 3. Besides all that, "uniquify" is not a word (OK, in English anyone can invent a word, but it is not a well-known term). So any such doc should be rephrased to say what actually happens to the buffer name. In GNU Emacs 24.0.50.1 (i386-mingw-nt5.1.2600) of 2010-05-23 on G41R2F1 Windowing system distributor `Microsoft Corp.', version 5.1.2600 configured using `configure --with-gcc (3.4) --no-opt --cflags -Ic:/xpm/include' From debbugs-submit-bounces@debbugs.gnu.org Mon May 24 14:35:35 2010 Received: (at 6259-quiet) by debbugs.gnu.org; 24 May 2010 18:35:35 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGcUw-0003dD-SJ for submit@debbugs.gnu.org; Mon, 24 May 2010 14:35:35 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OGcUw-0003d8-6g for 6259-quiet@debbugs.gnu.org; Mon, 24 May 2010 14:35:34 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1OGcUr-000838-Ts; Mon, 24 May 2010 14:35:29 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19450.50929.882134.545061@fencepost.gnu.org> Date: Mon, 24 May 2010 14:35:29 -0400 From: Glenn Morris To: 6259-quiet@debbugs.gnu.org Subject: Re: bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer' In-Reply-To: References: X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: blue X-Ran: -_[mh3mv!4D,h@qY7y(/7'tTjckK;E],9fn19+7$G1WgF~-w1fU%0{mGfH41=];n5LMX`# X-Spam-Score: -6.1 (------) X-Debbugs-Envelope-To: 6259-quiet X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.1 (------) Item 1 is a duplicate of bug#1338. 2 and 3 seem minor issues. From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 22:23:27 2014 Received: (at 6259) by debbugs.gnu.org; 10 Feb 2014 03:23:27 +0000 Received: from localhost ([127.0.0.1]:33144 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WChSw-0005B7-Bx for submit@debbugs.gnu.org; Sun, 09 Feb 2014 22:23:26 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:51470) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WChSu-0005Ay-8P for 6259@debbugs.gnu.org; Sun, 09 Feb 2014 22:23:24 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WChSd-00052A-HL; Mon, 10 Feb 2014 04:23:07 +0100 From: Lars Ingebrigtsen To: "Drew Adams" Subject: Re: bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer' References: Date: Sun, 09 Feb 2014 19:21:54 -0800 In-Reply-To: (Drew Adams's message of "Mon, 24 May 2010 10:03:04 -0700") Message-ID: <87ob2fhctp.fsf@building.gnus.org> User-Agent: Gnus/5.13001 (Ma Gnus v0.10) Emacs/24.3.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1WChSd-00052A-HL X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392607388.28244@wYIACghsUcMjhd+2SEBVVQ X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6259 Cc: 6259@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) "Drew Adams" writes: > 1. I thought that distributed Emacs code was not supposed to use > `defadvice'. `uniquify.el' uses it. > > 2. That advice makes the doc for `create-file-buffer' incorrect: > > emacs -Q > > C-h f create-file-buffer RET > > There is nothing about the function being advised. And since uniquify is the default now, it should probably be fixed: -------- create-file-buffer is a compiled Lisp function in `files.el'. (create-file-buffer ARG1) :around advice: `uniquify--create-file-buffer-advice' -------- -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sun Feb 09 22:23:30 2014 Received: (at control) by debbugs.gnu.org; 10 Feb 2014 03:23:30 +0000 Received: from localhost ([127.0.0.1]:33147 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WChT0-0005BP-0z for submit@debbugs.gnu.org; Sun, 09 Feb 2014 22:23:30 -0500 Received: from hermes.netfonds.no ([80.91.224.195]:51476) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WChSx-0005BF-Nq for control@debbugs.gnu.org; Sun, 09 Feb 2014 22:23:28 -0500 Received: from [204.14.154.233] (helo=building.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1WChSi-00052I-Ng for control@debbugs.gnu.org; Mon, 10 Feb 2014 04:23:13 +0100 Date: Sun, 09 Feb 2014 19:22:00 -0800 Message-Id: <87mwhzhctj.fsf@building.gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #6259 X-MailScanner-ID: 1WChSi-00052I-Ng X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1392607393.87508@STB2QgIZYX6F0i1RDDNrIg X-Spam-Status: No X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) tags 6259 confirmed From debbugs-submit-bounces@debbugs.gnu.org Sun May 01 13:53:13 2016 Received: (at 6259) by debbugs.gnu.org; 1 May 2016 17:53:13 +0000 Received: from localhost ([127.0.0.1]:60940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awvYM-0005sk-1S for submit@debbugs.gnu.org; Sun, 01 May 2016 13:53:13 -0400 Received: from hermes.netfonds.no ([80.91.224.195]:40162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1awvYH-0005sZ-75 for 6259@debbugs.gnu.org; Sun, 01 May 2016 13:53:08 -0400 Received: from cm-84.215.1.64.getinternet.no ([84.215.1.64] helo=mouse) by hermes.netfonds.no with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.84_2) (envelope-from ) id 1awvYC-0000oy-IO; Sun, 01 May 2016 19:53:04 +0200 From: Lars Ingebrigtsen To: "Drew Adams" Subject: Re: bug#6259: 24.0.50; `uniquify.el' advises `create-file-buffer' References: <87ob2fhctp.fsf@building.gnus.org> Date: Sun, 01 May 2016 19:53:00 +0200 In-Reply-To: <87ob2fhctp.fsf@building.gnus.org> (Lars Ingebrigtsen's message of "Sun, 09 Feb 2014 19:21:54 -0800") Message-ID: <87y47tzmv7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 6259 Cc: 6259@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Lars Ingebrigtsen writes: > And since uniquify is the default now, it should probably be fixed: > > -------- > > create-file-buffer is a compiled Lisp function in `files.el'. > > (create-file-buffer ARG1) > > :around advice: `uniquify--create-file-buffer-advice' > > -------- And amusingly enough, there's this comment in the file: ;; The below solution works because generate-new-buffer-name is called ;; only by rename-buffer (which, as of 19.29, is never called from C) and ;; generate-new-buffer, which is called only by Lisp functions ;; create-file-buffer and rename-uniquely. This isn't... er... very true any more. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Jun 27 22:56:31 2016 Received: (at control) by debbugs.gnu.org; 28 Jun 2016 02:56:32 +0000 Received: from localhost ([127.0.0.1]:58601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHjCR-0003u1-Of for submit@debbugs.gnu.org; Mon, 27 Jun 2016 22:56:31 -0400 Received: from mail-oi0-f49.google.com ([209.85.218.49]:33081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bHjCQ-0003tk-Bo for control@debbugs.gnu.org; Mon, 27 Jun 2016 22:56:30 -0400 Received: by mail-oi0-f49.google.com with SMTP id u201so5018257oie.0 for ; Mon, 27 Jun 2016 19:56:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:from:date:message-id:subject:to; bh=nCX2AaS6vO0o6Mp3Qz/pC15aj1tSUpq1ZyPFyUVqygw=; b=QvKD7IWMVVhgIkwsgTEluFQ3Nlrl6g1yhLOIy95/dU/1pBD+nFGr4RcS18N4RkFu0Y pyBIdj+aQmt5CpEt+F+HUXjLBdhwe9FTjIkFQ5McbBRt1pQ3OSyY+CfD6Lu6jHevm6JE KSlQJ3HsSE3cztt9af+OICcVUnJ4b4lW3Vj7GdY4fi87ZjBOsp2bA7N5AicHP1LpemP9 Je73Ap8OYM3TLLVjO6wCdORkhBZg812kGZDaDChstDyqMq4q73piMzwuvk5nLygQ3F5+ gzuft9zYrtntC3xbtQg0QvrT8n/0xxxG++BgNlYJiQARYKgmYo7Q057Nr2sCucI/CVBQ /bhw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:from:date:message-id:subject :to; bh=nCX2AaS6vO0o6Mp3Qz/pC15aj1tSUpq1ZyPFyUVqygw=; b=TDENrvQvvTENrBclie0BXjYT7gOp2UsW+9N4FcpDine4A9SqVvkhcpY+U57sFnh0/h LpTKXALniQsSwkCe/8QSw0apHcoWCD6Z7+6xOIzbKCZdOZstr+O+NXyDWFdSZJ6YFgxA IRTzo+oWlhHHwX/+w8pXoOxcnpfStuZhqqaUc8HYK0dhz9BMN7ruuwVS/3YTCWUincnI YnaVsKjZt9qnVLoXTcf3w35+S6j+fjKCKGA+YzxTNse3yk8JsX9d2apnRy3KVlaR6tyx jLWRGfZQ9M4ilYrY2NsUspvy6TvPRxoljUTOqqqYXnE785iLmBF3Kn0wWBxQc/s9Cjcn TIbg== X-Gm-Message-State: ALyK8tJS3S/LkF2X3vBfumtKws6/293toHluI8vUa6uHZE12oTxfRik0dP6IXGoSPzyhjFpWp/hLYyZD+Qq10w== X-Received: by 10.202.207.16 with SMTP id f16mr239817oig.178.1467082584707; Mon, 27 Jun 2016 19:56:24 -0700 (PDT) MIME-Version: 1.0 Received: by 10.157.52.238 with HTTP; Mon, 27 Jun 2016 19:56:24 -0700 (PDT) From: Noam Postavsky Date: Mon, 27 Jun 2016 22:56:24 -0400 X-Google-Sender-Auth: iY04zho9OJGJ0GniQZklVXqWtnM Message-ID: Subject: uniquify advice To: GNU bug tracker automated control server Content-Type: text/plain; charset=UTF-8 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) merge 1338 6259 quit From unknown Tue Jun 17 21:54:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 25 Jan 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator