GNU bug report logs - #62578
30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell

Previous Next

Full log

Message #23 received at 62578 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: 62578 <at> debbugs.gnu.org
Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous
 processes in Eshell
Date: Sun, 02 Apr 2023 08:29:27 +0300

> Date: Sat, 1 Apr 2023 17:58:59 -0700
> From: Jim Porter <jporterbugs <at> gmail.com>
> Cc: 62578 <at> debbugs.gnu.org
> 
> On 4/1/2023 12:40 AM, Jim Porter wrote:
> > My only concern there is making Emacs do something reasonable when 
> > piping data into it, but I can just try a few things out, and if it 
> > really doesn't work, the existing tests in my patch are hopefully still 
> > better than nothing.
> 
> Ok, that wasn't too hard. How does this look?

LGTM, thanks.

One minor nit: 'message' in a batch session prints to stderr, not to
stdout.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.