From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 00:41:18 2023 Received: (at submit) by debbugs.gnu.org; 1 Apr 2023 04:41:18 +0000 Received: from localhost ([127.0.0.1]:35072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piT3F-0005X1-Dy for submit@debbugs.gnu.org; Sat, 01 Apr 2023 00:41:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:39804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piT3D-0005Wt-6S for submit@debbugs.gnu.org; Sat, 01 Apr 2023 00:41:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piT3C-0002vF-FC for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 00:41:14 -0400 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1piT3A-00016F-59 for bug-gnu-emacs@gnu.org; Sat, 01 Apr 2023 00:41:13 -0400 Received: by mail-pj1-x102f.google.com with SMTP id mp3-20020a17090b190300b0023fcc8ce113so27603270pjb.4 for ; Fri, 31 Mar 2023 21:41:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680324070; x=1682916070; h=subject:from:to:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=16Mk9Q39/oG8ny6w3bjxh4qO/edPbk24QPqRPMKmstc=; b=WC8lG2yLegQ4ByI2+08uNb/YEPRB0y94LsVUMK1qGHElx20X6UBZlFG8eYxZ+bnIe4 v5k5lfVA7FPxp5/LQM2MMsow9wfCaRB69Oblse4w7UvVaaZMfShrYB7K/jNaIn52ZYUU MwZCXaMGbsRPnVXt+3xbrykYdWCfKHn5XATA1khaTK3GT8ANCvVr0JTDzLkbaXLUDHgm exYHR9YK+D+tQZse0vxjeB/6IxSgpetHbEhEKDyDnbd0Oz+OixGPdVUmTeiQlCpUR0u5 COFZMM6S0zdVQqTZe/mbZtyyARcDL9z06S5QBZ7grpi1i9CBHcBixjLSRmb60zonVcse tWQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680324070; x=1682916070; h=subject:from:to:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=16Mk9Q39/oG8ny6w3bjxh4qO/edPbk24QPqRPMKmstc=; b=qDBWE2gc71TKAav95NLHC/X/74tSWI/3vLOOGdPEaeYk+y6rwsfsTGJZwggZ6yrqmC 0peKS04bEBbDVLP3R5KRDacs1rJQ5W3AHQi5HxdXQo8I9RqlLHS3ctTJgC/GwMO36sIn E0ZqmeCl7zlrvU9LDSizlp5lyaREvACCTq+4gtOnsFdQrYxby+4zOXnIwphO5QlHGus2 zbN/kTgJQebU4m67YdKmTgopmuAynFp7Gt50rFSrtuTEXZvzKVS4cFPiZXJmQZyJa2Tq Cx/YXEgIieW5ZGuKqyH14OuuZIfrASuPq1/VujjbhrUYCJlQx1kJNWJxuvtWIsJ6GCg6 3T8A== X-Gm-Message-State: AAQBX9dAcZg6ZwC19ek2JDn6cgBFuHY44+w+/AL0KRIecvN3zHkL8GPI /kRxq6PLvoYSBiTBc6KrCR7VGCBjs2E= X-Google-Smtp-Source: AKy350Y+JyyPCBlryhgRhIFPZVnpML8nXweprGbKcJFeglgCEMtqMz6goV63XFEqMY3HXEL3MNb/og== X-Received: by 2002:a17:903:2112:b0:1a0:549d:39a1 with SMTP id o18-20020a170903211200b001a0549d39a1mr24658687ple.32.1680324070122; Fri, 31 Mar 2023 21:41:10 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id v21-20020a1709028d9500b001a064cff3c5sm2395830plo.43.2023.03.31.21.41.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 21:41:09 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------1hBYTXI8nmKJ7zhidd4XceRi" Message-ID: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> Date: Fri, 31 Mar 2023 21:41:09 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US To: bug-gnu-emacs@gnu.org From: Jim Porter Subject: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Received-SPF: pass client-ip=2607:f8b0:4864:20::102f; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x102f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------1hBYTXI8nmKJ7zhidd4XceRi Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit As far as I understand it, Eshell only uses synchronous processes on MS-DOS (where 'make-process' doesn't exist). Since I don't build Emacs for MS-DOS, and I expect not many others do either, I'm worried that this support will regress. To avoid that, here are some regression tests. It also fixes a small bug with how Eshell updated its internal markers when using synchronous processes. This mostly affects the tests, but could also cause unexpected behavior when using some of Eshell's buffer-navigation commands. --------------1hBYTXI8nmKJ7zhidd4XceRi Content-Type: text/plain; charset=UTF-8; name="0001-Add-tests-for-synchronous-processes-in-Eshell.patch" Content-Disposition: attachment; filename="0001-Add-tests-for-synchronous-processes-in-Eshell.patch" Content-Transfer-Encoding: base64 RnJvbSBmNmEwZjJkNzRmY2FjNDRhNGZhZWIzYzBiNzMxODRkNTQ5OGVjNTI1IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMzEgTWFyIDIwMjMgMjE6MzI6NDQgLTA3MDAKU3ViamVjdDogW1BB VENIXSA7IEFkZCB0ZXN0cyBmb3Igc3luY2hyb25vdXMgcHJvY2Vzc2VzIGluIEVzaGVsbAoK Tm9ybWFsbHksIEVzaGVsbCBvbmx5IHVzZXMgc3luY2hyb25vdXMgcHJvY2Vzc2VzIG9uIE1T LURPUywgc28gdGhpcyBpcwpoYXJkIHRvIHRlc3QuICBUbyBnZXQgYXJvdW5kIHRoaXMsIGxl dCB0aGUgdGVzdHMgZXhwbGljaXRseSByZXF1ZXN0CnN5bmNocm9ub3VzIHByb2Nlc3Nlcy4K CiogbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwgKGVzaGVsbC1zdXBwb3J0cy1hc3luY2hyb25v dXMtcHJvY2Vzc2VzKToKTmV3IHZhcmlhYmxlLi4uCihlc2hlbGwtZ2F0aGVyLXByb2Nlc3Mt b3V0cHV0KTogLi4uIHVzZSBpdCwgYW5kIHJlbW92ZSBzb21lIGluY29ycmVjdApjb2RlIHVw ZGF0aW5nIEVzaGVsbCdzIGludGVybmFsIG1hcmtlcnMgKHRoZSBhc3luYyBjb2RlIHBhdGgg ZG9lc24ndApkbyB0aGlzLCBzbyBuZWl0aGVyIHNob3VsZCB0aGUgc3luYyBwYXRoKS4KCiog bGlzcC9lc2hlbGwvZXNoLWNtZC5lbCAoZXNoZWxsLWV4ZWN1dGUtcGlwZWxpbmUpOiBVc2UK J2VzaGVsbC1zdXBwb3J0cy1hc3luY2hyb25vdXMtcHJvY2Vzc2VzJy4KCiogdGVzdC9saXNw L2VzaGVsbC9lc2gtcHJvYy10ZXN0cy5lbAooZXNoLXByb2MtdGVzdC9zeW5jaHJvbm91cy1w cm9jL3NpbXBsZS9pbnRlcmFjdGl2ZSkKKGVzaC1wcm9jLXRlc3Qvc3luY2hyb25vdXMtcHJv Yy9zaW1wbGUvY29tbWFuZC1yZXN1bHQpCihlc2gtcHJvYy10ZXN0L3N5bmNocm9ub3VzLXBy b2MvcGlwZWxpbmUvaW50ZXJhY3RpdmUpCihlc2gtcHJvYy10ZXN0L3N5bmNocm9ub3VzLXBy b2MvcGlwZWxpbmUvY29tbWFuZC1yZXN1bHQpOiBOZXcgdGVzdHMuCi0tLQogbGlzcC9lc2hl bGwvZXNoLWNtZC5lbCAgICAgICAgICAgICB8ICAyICstCiBsaXNwL2VzaGVsbC9lc2gtcHJv Yy5lbCAgICAgICAgICAgIHwgIDkgKysrKy0tLS0KIHRlc3QvbGlzcC9lc2hlbGwvZXNoLXBy b2MtdGVzdHMuZWwgfCAzNSArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmls ZXMgY2hhbmdlZCwgNDAgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbApp bmRleCBkNTIzN2VlMWYwNC4uYjgwNTk2ZjJjYWQgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxs L2VzaC1jbWQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbApAQCAtODkyLDcgKzg5 Miw3IEBAIGVzaGVsbC1leGVjdXRlLXBpcGVsaW5lCiAgICAgIChzZXQgaGVhZHByb2Mgbmls KQogICAgICAoc2V0IHRhaWxwcm9jIG5pbCkKICAgICAgKHByb2duCi0gICAgICAgLChpZiAo ZmJvdW5kcCAnbWFrZS1wcm9jZXNzKQorICAgICAgICwoaWYgZXNoZWxsLXN1cHBvcnRzLWFz eW5jaHJvbm91cy1wcm9jZXNzZXMKIAkgICAgYChlc2hlbGwtZG8tcGlwZWxpbmVzICxwaXBl bGluZSkKICAgICAgICAgICBgKGxldCAoKHRhaWwtaGFuZGxlcyAoZXNoZWxsLWR1cGxpY2F0 ZS1oYW5kbGVzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVzaGVsbC1jdXJy ZW50LWhhbmRsZXMpKSkKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1wcm9jLmVsIGIv bGlzcC9lc2hlbGwvZXNoLXByb2MuZWwKaW5kZXggYTg2ZTc1MDI3OTUuLjI5NzZmNTY5NGQ3 IDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lc2gtcHJvYy5lbAorKysgYi9saXNwL2VzaGVs bC9lc2gtcHJvYy5lbApAQCAtOTcsNiArOTcsOSBAQCBlc2hlbGwta2lsbC1ob29rCiAKIDs7 OyBJbnRlcm5hbCBWYXJpYWJsZXM6CiAKKyhkZWZ2YXIgZXNoZWxsLXN1cHBvcnRzLWFzeW5j aHJvbm91cy1wcm9jZXNzZXMgKGZib3VuZHAgJ21ha2UtcHJvY2VzcykKKyAgIk5vbi1uaWwg aWYgRXNoZWxsIGNhbiBjcmVhdGUgYXN5bmNocm9ub3VzIHByb2Nlc3Nlcy4iKQorCiAoZGVm dmFyIGVzaGVsbC1jdXJyZW50LXN1YmpvYi1wIG5pbCkKIAogKGRlZnZhciBlc2hlbGwtcHJv Y2Vzcy1saXN0IG5pbApAQCAtMjk2LDcgKzI5OSw3IEBAIGVzaGVsbC1nYXRoZXItcHJvY2Vz cy1vdXRwdXQKICAgICAgICAgICAgICAgICAoY29kaW5nLXN5c3RlbS1jaGFuZ2UtZW9sLWNv bnZlcnNpb24gbG9jYWxlLWNvZGluZy1zeXN0ZW0KICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3VuaXgpKSkpCiAgICAgKGNvbmQKLSAg ICAgKChmYm91bmRwICdtYWtlLXByb2Nlc3MpCisgICAgIChlc2hlbGwtc3VwcG9ydHMtYXN5 bmNocm9ub3VzLXByb2Nlc3NlcwogICAgICAgKHVubGVzcyAob3IgOzsgRklYTUU6IEl0J3Mg bm90IGN1cnJlbnRseSBwb3NzaWJsZSB0byB1c2UgYQogICAgICAgICAgICAgICAgICAgOzsg c3RkZXJyIHByb2Nlc3MgZm9yIHJlbW90ZSBmaWxlcy4KICAgICAgICAgICAgICAgICAgIChm aWxlLXJlbW90ZS1wIGRlZmF1bHQtZGlyZWN0b3J5KQpAQCAtMzkyLDEwICszOTUsNiBAQCBl c2hlbGwtZ2F0aGVyLXByb2Nlc3Mtb3V0cHV0CiAJICAgIChzZXRxIGxiZWcgbGVuZCkKIAkg ICAgKHNldC1idWZmZXIgcHJvYy1idWYpKQogCSAgKHNldC1idWZmZXIgb2xkYnVmKSkKLSAg ICAgICAgKHJlcXVpcmUgJ2VzaC1tb2RlKQotICAgICAgICAoZGVjbGFyZS1mdW5jdGlvbiBl c2hlbGwtdXBkYXRlLW1hcmtlcnMgImVzaC1tb2RlIiAocG1hcmspKQotICAgICAgICAoZGVm dmFyIGVzaGVsbC1sYXN0LW91dHB1dC1lbmQpICAgICAgICAgO0RlZmluZWQgaW4gZXNoLW1v ZGUuZWwuCi0JKGVzaGVsbC11cGRhdGUtbWFya2VycyBlc2hlbGwtbGFzdC1vdXRwdXQtZW5k KQogCTs7IFNpbXVsYXRlIHRoZSBlZmZlY3Qgb2YgZXNoZWxsLXNlbnRpbmVsLgogCShlc2hl bGwtY2xvc2UtaGFuZGxlcwogICAgICAgICAgKGlmIChudW1iZXJwIGV4aXQtc3RhdHVzKSBl eGl0LXN0YXR1cyAtMSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLXByb2Mt dGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsCmluZGV4IDhl MDJmYmI1NDk3Li44Mzk5ZmJkZWViOSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VzaGVsbC9l c2gtcHJvYy10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3Rz LmVsCkBAIC0xOTEsNiArMTkxLDQxIEBAIGVzaC1wcm9jLXRlc3QvcGlwZWxpbmUtY29ubmVj dGlvbi10eXBlL2xhc3QKICAgICAgKHVubGVzcyAoZXEgc3lzdGVtLXR5cGUgJ3dpbmRvd3Mt bnQpCiAgICAgICAgInN0ZG91dFxuc3RkZXJyXG4iKSkpKQogCisMCis7OyBTeW5jaHJvbm91 cyBwcm9jZXNzZXMKKworKGVydC1kZWZ0ZXN0IGVzaC1wcm9jLXRlc3Qvc3luY2hyb25vdXMt cHJvYy9zaW1wbGUvaW50ZXJhY3RpdmUgKCkKKyAgIlRlc3QgdGhhdCBzeW5jaHJvbm91cyBw cm9jZXNzZXMgd29yayBpbiBhbiBpbnRlcmFjdGl2ZSBzaGVsbC4iCisgIChza2lwLXVubGVz cyAoZXhlY3V0YWJsZS1maW5kICJlY2hvIikpCisgIChsZXQgKChlc2hlbGwtc3VwcG9ydHMt YXN5bmNocm9ub3VzLXByb2Nlc3NlcyBuaWwpKQorICAgICh3aXRoLXRlbXAtZXNoZWxsCisg ICAgIChlc2hlbGwtbWF0Y2gtY29tbWFuZC1vdXRwdXQgIiplY2hvIGhlbGxvIgorICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICJcXGBoZWxsb1xuIikpKSkKKworKGVydC1k ZWZ0ZXN0IGVzaC1wcm9jLXRlc3Qvc3luY2hyb25vdXMtcHJvYy9zaW1wbGUvY29tbWFuZC1y ZXN1bHQgKCkKKyAgIlRlc3QgdGhhdCBzeW5jaHJvbm91cyBwcm9jZXNzZXMgd29yayB2aWEg YGVzaGVsbC1jb21tYW5kLXJlc3VsdCcuIgorICAoc2tpcC11bmxlc3MgKGV4ZWN1dGFibGUt ZmluZCAiZWNobyIpKQorICAobGV0ICgoZXNoZWxsLXN1cHBvcnRzLWFzeW5jaHJvbm91cy1w cm9jZXNzZXMgbmlsKSkKKyAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LWVxdWFsICIqZWNo byBoZWxsbyIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJoZWxsb1xuIikp KQorCisoZXJ0LWRlZnRlc3QgZXNoLXByb2MtdGVzdC9zeW5jaHJvbm91cy1wcm9jL3BpcGVs aW5lL2ludGVyYWN0aXZlICgpCisgICJUZXN0IHRoYXQgc3luY2hyb25vdXMgcGlwZWxpbmVz IHdvcmsgaW4gYW4gaW50ZXJhY3RpdmUgc2hlbGwuIgorICAoc2tpcC11bmxlc3MgKGFuZCAo ZXhlY3V0YWJsZS1maW5kICJlY2hvIikKKyAgICAgICAgICAgICAgICAgICAgKGV4ZWN1dGFi bGUtZmluZCAicmV2IikpKQorICAobGV0ICgoZXNoZWxsLXN1cHBvcnRzLWFzeW5jaHJvbm91 cy1wcm9jZXNzZXMgbmlsKSkKKyAgICAod2l0aC10ZW1wLWVzaGVsbAorICAgICAoZXNoZWxs LW1hdGNoLWNvbW1hbmQtb3V0cHV0ICIqZWNobyBoZWxsbyB8ICpyZXYiCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIlxcYG9sbGVoXG4iKSkpKQorCisoZXJ0LWRlZnRl c3QgZXNoLXByb2MtdGVzdC9zeW5jaHJvbm91cy1wcm9jL3BpcGVsaW5lL2NvbW1hbmQtcmVz dWx0ICgpCisgICJUZXN0IHRoYXQgc3luY2hyb25vdXMgcGlwZWxpbmVzIHdvcmsgdmlhIGBl c2hlbGwtY29tbWFuZC1yZXN1bHQnLiIKKyAgKHNraXAtdW5sZXNzIChhbmQgKGV4ZWN1dGFi bGUtZmluZCAiZWNobyIpCisgICAgICAgICAgICAgICAgICAgIChleGVjdXRhYmxlLWZpbmQg InJldiIpKSkKKyAgKGxldCAoKGVzaGVsbC1zdXBwb3J0cy1hc3luY2hyb25vdXMtcHJvY2Vz c2VzIG5pbCkpCisgICAgKGVzaGVsbC1jb21tYW5kLXJlc3VsdC1lcXVhbCAiKmVjaG8gaGVs bG8gfCAqcmV2IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIm9sbGVoXG4i KSkpCisKIAwKIDs7IEtpbGxpbmcgcHJvY2Vzc2VzCiAKLS0gCjIuMjUuMQoK --------------1hBYTXI8nmKJ7zhidd4XceRi-- From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 02:06:53 2023 Received: (at 62578) by debbugs.gnu.org; 1 Apr 2023 06:06:54 +0000 Received: from localhost ([127.0.0.1]:35264 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piUO5-0008HV-Id for submit@debbugs.gnu.org; Sat, 01 Apr 2023 02:06:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56546) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piUO3-0008HI-QK for 62578@debbugs.gnu.org; Sat, 01 Apr 2023 02:06:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUNy-0008Po-CB; Sat, 01 Apr 2023 02:06:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=aTM7ezfirHZr5MyJAR8vFXQ4n6Vl2inydP+9i2SXjds=; b=oxiY9V7+M/h6 QnNehia88MCYAMm7BsDquqvJuSu9YNzhUrBF75yfzp2+VDzIDqnOWex6FSTPszWV+6qkFiMoONd7T lmeSmPAyxkIroDmJWXFZVzce1e7dN6Blhny3CYUpJxR5h0EVukAP0We1OCcQKg1rRW9Iat+8PE2Zc yNT8ZxT7cEU3GBF73ZKoyGfBH7JAEcouYnxL6JpXz43QZC3ERoZeRBtrfOpzKhvH55DH17VleV47J F0+gZwCl5iukymg0/A6giO+Rpe3tCpUnnIucKXsgbaQNbPtjanFUzoCZ6jHNqh1iPZ8gyPV9XoU5C OZPSnBDD2axCQEZzB6vROg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUNx-0007n8-9b; Sat, 01 Apr 2023 02:06:45 -0400 Date: Sat, 01 Apr 2023 09:07:00 +0300 Message-Id: <83355k16gr.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> (message from Jim Porter on Fri, 31 Mar 2023 21:41:09 -0700) Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62578 Cc: 62578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 31 Mar 2023 21:41:09 -0700 > From: Jim Porter > > As far as I understand it, Eshell only uses synchronous processes on > MS-DOS (where 'make-process' doesn't exist). Since I don't build Emacs > for MS-DOS, and I expect not many others do either, I'm worried that > this support will regress. To avoid that, here are some regression tests. Thanks. > +(ert-deftest esh-proc-test/synchronous-proc/simple/interactive () > + "Test that synchronous processes work in an interactive shell." > + (skip-unless (executable-find "echo")) This will always skip on MS-DOS, since "echo" is not available as an external program OOTB, only if GNU Coreutils are installed. And even if Coreutils _are_ installed, a command that invokes "echo" will most probably invoke the shell builtin instead. > + (skip-unless (and (executable-find "echo") > + (executable-find "rev"))) Likewise here: "rev" is not expected to be available on MS-DOS. I think you need to rethink these tests in a way that uses different commands. My suggestion is to use the Emacs executable, since that is always available when running these tests. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 03:16:46 2023 Received: (at 62578) by debbugs.gnu.org; 1 Apr 2023 07:16:46 +0000 Received: from localhost ([127.0.0.1]:35318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVTi-0001qd-9F for submit@debbugs.gnu.org; Sat, 01 Apr 2023 03:16:46 -0400 Received: from mail-pl1-f177.google.com ([209.85.214.177]:38592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVTh-0001qN-8Q for 62578@debbugs.gnu.org; Sat, 01 Apr 2023 03:16:45 -0400 Received: by mail-pl1-f177.google.com with SMTP id ja10so23541535plb.5 for <62578@debbugs.gnu.org>; Sat, 01 Apr 2023 00:16:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680333399; x=1682925399; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=4V0nKdknrxRz6oLM970Uiitno/73pdiRjfr1cJFYh/4=; b=LaOtRZXfJpGvy64Krje+cqE6pGr8CXiaAwSAxUj/grU+QWYVEEdqoZyyYy+0+GdzGe SGBZaLtlSYKQOKzH+UrEvC4OZQASGu4qcu2lt/pSeUBMm7c3UcXONIlm2gzlfdRFMXPn YgDP4D4md8VT1qI+VpNj3wb1bbw3BScQlyPWtfsmqMG80KwWUyJ0cPkDC+G34PE41JMK /ECoaOj+mkLS5D+y9gUmt10zopmLKPoDL6+qUfU/hnoDTRuiR3zKmJ/Eoyj/I0mKbaBz 9mq62FQo+S4FXpvDwENTGsXFCTOTHI5ZdOUSmoIYfutM5RnHmnbKQSHLnicHXVK5sF0J Zbbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680333399; x=1682925399; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4V0nKdknrxRz6oLM970Uiitno/73pdiRjfr1cJFYh/4=; b=dKubTYZXyUGegHbfBiFRAhpq5CVwAYOOvvlqHlAtziOhh76IyVhDdcZsWd28F24gEa NssmsBbgIFFzvzHCR0apHPETzc7D7b8urniNwofk9LIzLdSYoAX/V/xkzDwhuTTLq4dJ vqzXEWpavSgz2rcbuZCmJ/r9C21zsHCo5bjZZF7z3cFbjVVDwC0YzN4XBndnZZRYQZk6 SaBl5BkUT+TYqBKIQodOfUThNEaIX/a2nSNAP+0s2MDoTAAVG/GmqwZ4JLMhqUyWNnKh Z26N3uahSlBTMDATNMa2EiC3FXvaa+qtXQKbOWXwIklnHQbeOV7wIWAohkHhlWAG/GeQ G5XA== X-Gm-Message-State: AAQBX9cA3q0JubzGslUQNAMXHEtLVqGUCwPmMauLX2hHqP40mC1Ar1se jsFMMpNjRk3jplZf3hyRN57iZG6qbHg= X-Google-Smtp-Source: AKy350aH34pk8uFMeeb1NF7WacAss8oFq3yUeQ9W3cmYUEPXLPLzb5XcFbCVnK8yY8uvNIcQRp5GBg== X-Received: by 2002:a17:90b:1c8b:b0:234:d78:9b4c with SMTP id oo11-20020a17090b1c8b00b002340d789b4cmr32625282pjb.18.1680333398694; Sat, 01 Apr 2023 00:16:38 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id g11-20020a17090a300b00b00233e860f69esm6047531pjb.56.2023.04.01.00.16.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Apr 2023 00:16:38 -0700 (PDT) Message-ID: Date: Sat, 1 Apr 2023 00:16:38 -0700 MIME-Version: 1.0 Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Content-Language: en-US To: Eli Zaretskii References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> <83355k16gr.fsf@gnu.org> From: Jim Porter In-Reply-To: <83355k16gr.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62578 Cc: 62578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/31/2023 11:07 PM, Eli Zaretskii wrote: >> Date: Fri, 31 Mar 2023 21:41:09 -0700 >> From: Jim Porter >> >> +(ert-deftest esh-proc-test/synchronous-proc/simple/interactive () >> + "Test that synchronous processes work in an interactive shell." >> + (skip-unless (executable-find "echo")) > > This will always skip on MS-DOS, since "echo" is not available as an > external program OOTB, only if GNU Coreutils are installed. And even > if Coreutils _are_ installed, a command that invokes "echo" will most > probably invoke the shell builtin instead. My main goal here is to test synchronous subprocesses on platforms *other than* MS-DOS, since these new tests aren't really necessary on MS-DOS itself: there are plenty of existing Eshell tests that create processes, and they'd *all* use synchronous subprocesses on MS-DOS. As for calling a shell builtin, Eshell should translate "*echo" to "/path/to/echo" (or "C:/path/to/echo.exe") before calling it, so it shouldn't use a shell builtin here. You're right though that the tests probably require GNU Coreutils to be installed (this is also true of quite a few existing Eshell tests though). >> + (skip-unless (and (executable-find "echo") >> + (executable-find "rev"))) > > Likewise here: "rev" is not expected to be available on MS-DOS. To make this work in more places, I could switch "rev" to something that's actually in GNU Coreutils. Maybe "wc". > I think you need to rethink these tests in a way that uses different > commands. My suggestion is to use the Emacs executable, since that is > always available when running these tests. Since these tests are meant to check the "synchronous subprocess" code in Eshell on non-MS-DOS platforms, I'd say it's ok. However, I can change my patch if you prefer. I could either: 1) Add a comment to the tests explaining that they're just meant to simulate some of MS-DOS's limitations on non-MS-DOS systems, or 2) Rework these tests so they work the same on both MS-DOS and other systems. Personally, I lean softly towards (1), partly because the Eshell test suite probably breaks in quite a few other places on MS-DOS anyway. However, it shouldn't be too hard to do (2) instead. What do you think? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 03:22:14 2023 Received: (at 62578) by debbugs.gnu.org; 1 Apr 2023 07:22:14 +0000 Received: from localhost ([127.0.0.1]:35323 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVZ0-00020a-3f for submit@debbugs.gnu.org; Sat, 01 Apr 2023 03:22:14 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55896) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVYy-00020O-Lb for 62578@debbugs.gnu.org; Sat, 01 Apr 2023 03:22:12 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piVYt-0003xo-1j; Sat, 01 Apr 2023 03:22:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=EgezDUkpgWIH3XTpYsYnKRpKXkILc9bIVygEyRDcZcE=; b=sfmBJLRfWidR m4gsZR8GLyt1ygJPzsyUEkSgii4CcJ0B6d0HndC1GPZ8v49hK5rxijeLjv1X4BcO3xl/8EkLu0mUi 7PqhJU1ch5HEYBrbayrARaTKL6NvjCHKzAL1TyqNUHUFSF1uB2O2gPECkG8WUDNwVOxhjPseMbqs+ uMXCd7xWhGuajOFATH7/MrIjA6tjPrgqE+nCewFd1jc0KMUYYvcNEv1/ayDtGd6rEKvldzrHdhU7a OvVFXMyt2dyZOR/krK+8iJ51Qvn0NRFg8iyloT33xZIE48YBXS/RkDkuMqp0AU5SrxtBaANOzF2TL irYC4Ks9dmEBDE8mrANz0w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piVYs-0005fm-8a; Sat, 01 Apr 2023 03:22:06 -0400 Date: Sat, 01 Apr 2023 10:22:22 +0300 Message-Id: <83r0t4yslt.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Sat, 1 Apr 2023 00:16:38 -0700) Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> <83355k16gr.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62578 Cc: 62578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 1 Apr 2023 00:16:38 -0700 > Cc: 62578@debbugs.gnu.org > From: Jim Porter > > Since these tests are meant to check the "synchronous subprocess" code > in Eshell on non-MS-DOS platforms, I'd say it's ok. However, I can > change my patch if you prefer. I could either: > > 1) Add a comment to the tests explaining that they're just meant to > simulate some of MS-DOS's limitations on non-MS-DOS systems, or > > 2) Rework these tests so they work the same on both MS-DOS and other > systems. > > Personally, I lean softly towards (1), partly because the Eshell test > suite probably breaks in quite a few other places on MS-DOS anyway. > However, it shouldn't be too hard to do (2) instead. > > What do you think? I don't understand why not use Emacs instead of all those external commands. That solves all the problems nicely and portably, and still allows you to do anything you want. But it's your call, eventually. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 03:40:23 2023 Received: (at 62578) by debbugs.gnu.org; 1 Apr 2023 07:40:23 +0000 Received: from localhost ([127.0.0.1]:35355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVqZ-0002Yc-C2 for submit@debbugs.gnu.org; Sat, 01 Apr 2023 03:40:23 -0400 Received: from mail-pj1-f43.google.com ([209.85.216.43]:42872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVqY-0002YH-4k for 62578@debbugs.gnu.org; Sat, 01 Apr 2023 03:40:22 -0400 Received: by mail-pj1-f43.google.com with SMTP id h12-20020a17090aea8c00b0023d1311fab3so25879758pjz.1 for <62578@debbugs.gnu.org>; Sat, 01 Apr 2023 00:40:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680334816; x=1682926816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=bzIW043IxdkwinfaAcQgyr9dsPWq8FhqlfamAJPGV3I=; b=mLVmvI3zhh4PMKR1jSqYpDhbv9cfYEryVRZxF/YzOh37EDbn+nzm2iUWeDpx6p2AEj NPE073sxDE0rST2txO2oPaGEoD+sef0CAH6IQOKP/Fyf4v2D43qmvMCFJzWow+YwNoOy sdQ0zLX4YuFQVQm5SrH4MtWoB4GORctv50Tv+xJskJxqMlxdZcCiw/hTqRkepxstJpcs satpGg8Vmng2OWuZ+IvUVQTztL0IuyoC5aDGAH4EyJHh5RsXjFk/p4+p4vJ3kBmjplr5 1NjJuqtv/qp46CvTPPS1DmKydFE2ccBiMmD/oUDsOue3RI1/p8k/ZlsxS7B8LIFQVRI8 qVUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680334816; x=1682926816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=bzIW043IxdkwinfaAcQgyr9dsPWq8FhqlfamAJPGV3I=; b=I8KXfis1U8Osnv7TS9mp5k9Gu+sqpAsgEjxcqzamf+Cw0VuRGze79C+VUoV1aqcJZa EtvKnevnFweZGPm8s+70cW2zD+gcFh6anBMopMlrHUNjxvk6/prfiMrObXX7XFCvqJ5S z5lhJtCzzZVScstts26Y4cIwtuyvP8Qq2h5ZRHfr3M6oq4jmrQiOrUUASvFXSclXRDIX 22qBM68vDL/kuiUGoxmhncMYtXNWNQICNYWZ7cIZj/x2FjbWR6QRiGhgOUR1WUThNe6x trP2ep3o6hWSrLjKxRFRMJL20oqoO2/R8jsZdqcqV/enOR9rIhRVaNvOfobxa3nlKCfJ YCyg== X-Gm-Message-State: AAQBX9dJMGcYohcRD9NKERBG0UVAldXkZPDfUsVK+wqTto0jUxVl8iqI ay/rwj5xgRdx05pcdmndHG4= X-Google-Smtp-Source: AKy350YnSMDeha6GYQEFIrFgSyHmCRiJFM0QUt4h5wHMBsSkXCez40czeK+EkfMWKWdBFU4CEtTD8Q== X-Received: by 2002:a17:90b:1b03:b0:23f:3ee2:8ec6 with SMTP id nu3-20020a17090b1b0300b0023f3ee28ec6mr34565300pjb.11.1680334816446; Sat, 01 Apr 2023 00:40:16 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id m8-20020a170902768800b001a1a9a639c2sm2732068pll.134.2023.04.01.00.40.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Apr 2023 00:40:16 -0700 (PDT) Message-ID: Date: Sat, 1 Apr 2023 00:40:16 -0700 MIME-Version: 1.0 Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Content-Language: en-US To: Eli Zaretskii References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> <83355k16gr.fsf@gnu.org> <83r0t4yslt.fsf@gnu.org> From: Jim Porter In-Reply-To: <83r0t4yslt.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62578 Cc: 62578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 4/1/2023 12:22 AM, Eli Zaretskii wrote: > I don't understand why not use Emacs instead of all those external > commands. That solves all the problems nicely and portably, and still > allows you to do anything you want. Mostly just so that the tests are easier to understand, but for these newly-added ones, I think they should be easy enough to understand no matter what. I'll try using Emacs. My only concern there is making Emacs do something reasonable when piping data into it, but I can just try a few things out, and if it really doesn't work, the existing tests in my patch are hopefully still better than nothing. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 20:59:09 2023 Received: (at 62578) by debbugs.gnu.org; 2 Apr 2023 00:59:10 +0000 Received: from localhost ([127.0.0.1]:38748 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pim3p-0001bH-B0 for submit@debbugs.gnu.org; Sat, 01 Apr 2023 20:59:09 -0400 Received: from mail-pj1-f52.google.com ([209.85.216.52]:34776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pim3m-0001an-O3 for 62578@debbugs.gnu.org; Sat, 01 Apr 2023 20:59:07 -0400 Received: by mail-pj1-f52.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso11132180pjc.1 for <62578@debbugs.gnu.org>; Sat, 01 Apr 2023 17:59:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680397141; x=1682989141; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=rYP0yT7FKuS+zDf115aZjRzGW9liejvd1Xbh/MMYJCQ=; b=iUHrwVBgWwSXoK/49shme33EQ/RsmzMJLPfMA6JJoe0QTVGe/cwrPRwyVuVIKUv7f4 DTKo9Yh4Hp60QDheFcg7NJsqBaOYsE3dxGyleiCbxMPgucFvgfJbCyIo1gprVP+4nnTm zCMx+xh2TBjwgxA8r5zGqRMVdUit/8J1eTdZqCVGgmmp6gNqQGlvGZc3qHJkgx8zmd9H 1u6NHSz1pjdNZ6zpaLyrtuWTnbF8ACrqkbohpKgfNKzgpZ07Ubl9hyYJnRdxtTryF0UC dQeww5OcW5VzW29PNupCqYRAz0sx3N63VYJjhuUHfTa2GAWFCplfnweEk+okG/euIgqv 19Pw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680397141; x=1682989141; h=in-reply-to:references:cc:to:from:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=rYP0yT7FKuS+zDf115aZjRzGW9liejvd1Xbh/MMYJCQ=; b=l0w6EAFfKyGm12oY/jchzBqq5svAeK990WAEbORDcFd1ZuQ2bvEbOHRrM1jLU4iPt3 bI1KnMyZ/+nPza5nnaSwaHAUYgnQMZp3ncI30ZgjoI1ZjaUFB6zPuTeK0P0DWFxF/jGc SmaaDR6y/4OS7U8phTtbur1SREBVOmDgfdP1aj7BkfDbr9eNeniFKC2Wc3U8/6mdNBjT PpEsj+EZXSMVOwccWAwQKCSnyI3UpWMt0zR8whBD5EJajOYJau82KpwJR9iTlkh2U02v gNlGWt+/ztvkCiwC4vHuc3Kzb1EbT2ZWzPh30/dFOaNVFoCTF3MDFPjSLETvHrE+U85m XuCQ== X-Gm-Message-State: AO0yUKVv6Y1KGR42R7oUsg9urdqOAGQKmJbSuMPjgZnA8ifz9IlywuOt KjNp4BSPeq+7Sz+HayNXBcuFEPx8uIE= X-Google-Smtp-Source: AK7set9Ds/NDaklElUS0aJEifWzKDTln/1Z9ujKXKB2OAZJlQjhscUmD2tS/C94qKFA8S1D2VTYBvw== X-Received: by 2002:a05:6a20:bf18:b0:dc:43e8:54b7 with SMTP id gc24-20020a056a20bf1800b000dc43e854b7mr25674873pzb.43.1680397140592; Sat, 01 Apr 2023 17:59:00 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id a18-20020a656412000000b005136b93f8e9sm3698128pgv.14.2023.04.01.17.58.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Apr 2023 17:58:59 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------0jXuapdzQaxVncyPwdFdtCJg" Message-ID: Date: Sat, 1 Apr 2023 17:58:59 -0700 MIME-Version: 1.0 Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> <83355k16gr.fsf@gnu.org> <83r0t4yslt.fsf@gnu.org> In-Reply-To: X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62578 Cc: 62578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------0jXuapdzQaxVncyPwdFdtCJg Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/1/2023 12:40 AM, Jim Porter wrote: > My only concern there is making Emacs do something reasonable when > piping data into it, but I can just try a few things out, and if it > really doesn't work, the existing tests in my patch are hopefully still > better than nothing. Ok, that wasn't too hard. How does this look? --------------0jXuapdzQaxVncyPwdFdtCJg Content-Type: text/plain; charset=UTF-8; name="0001-Add-tests-for-synchronous-processes-in-Eshell.patch" Content-Disposition: attachment; filename="0001-Add-tests-for-synchronous-processes-in-Eshell.patch" Content-Transfer-Encoding: base64 RnJvbSBmNWU4ZmFkNjBjMDBhY2JiOGNkN2NkODJhY2YxYmFlMjFlMDFhYWZiIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMzEgTWFyIDIwMjMgMjE6MzI6NDQgLTA3MDAKU3ViamVjdDogW1BB VENIXSA7IEFkZCB0ZXN0cyBmb3Igc3luY2hyb25vdXMgcHJvY2Vzc2VzIGluIEVzaGVsbAoK Tm9ybWFsbHksIEVzaGVsbCBvbmx5IHVzZXMgc3luY2hyb25vdXMgcHJvY2Vzc2VzIG9uIE1T LURPUywgc28gdGhpcyBpcwpoYXJkIHRvIHRlc3QuICBUbyBnZXQgYXJvdW5kIHRoaXMsIGxl dCB0aGUgdGVzdHMgZXhwbGljaXRseSByZXF1ZXN0CnN5bmNocm9ub3VzIHByb2Nlc3Nlcy4K CiogbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwgKGVzaGVsbC1zdXBwb3J0cy1hc3luY2hyb25v dXMtcHJvY2Vzc2VzKToKTmV3IHZhcmlhYmxlLi4uCihlc2hlbGwtZ2F0aGVyLXByb2Nlc3Mt b3V0cHV0KTogLi4uIHVzZSBpdCwgYW5kIHJlbW92ZSBzb21lIGluY29ycmVjdApjb2RlIHVw ZGF0aW5nIEVzaGVsbCdzIGludGVybmFsIG1hcmtlcnMgKHRoZSBhc3luYyBjb2RlIHBhdGgg ZG9lc24ndApkbyB0aGlzLCBzbyBuZWl0aGVyIHNob3VsZCB0aGUgc3luYyBwYXRoKS4KCiog bGlzcC9lc2hlbGwvZXNoLWNtZC5lbCAoZXNoZWxsLWV4ZWN1dGUtcGlwZWxpbmUpOiBVc2UK J2VzaGVsbC1zdXBwb3J0cy1hc3luY2hyb25vdXMtcHJvY2Vzc2VzJy4KCiogdGVzdC9saXNw L2VzaGVsbC9lc2gtcHJvYy10ZXN0cy5lbAooZXNoLXByb2MtdGVzdC9lbWFjcy1jb21tYW5k KTogTmV3IGZ1bmN0aW9uLgooZXNoLXByb2MtdGVzdC9lbWFjcy1lY2hvLCBlc2gtcHJvYy10 ZXN0L2VtYWNzLXVwY2FzZSk6IE5ldyB2YXJpYWJsZXMuCihlc2gtcHJvYy10ZXN0L3N5bmNo cm9ub3VzLXByb2Mvc2ltcGxlL2ludGVyYWN0aXZlKQooZXNoLXByb2MtdGVzdC9zeW5jaHJv bm91cy1wcm9jL3NpbXBsZS9jb21tYW5kLXJlc3VsdCkKKGVzaC1wcm9jLXRlc3Qvc3luY2hy b25vdXMtcHJvYy9waXBlbGluZS9pbnRlcmFjdGl2ZSkKKGVzaC1wcm9jLXRlc3Qvc3luY2hy b25vdXMtcHJvYy9waXBlbGluZS9jb21tYW5kLXJlc3VsdCk6IE5ldyB0ZXN0cy4KLS0tCiBs aXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgIHwgIDIgKy0KIGxpc3AvZXNoZWxs L2VzaC1wcm9jLmVsICAgICAgICAgICAgfCAgOSArKystLS0KIHRlc3QvbGlzcC9lc2hlbGwv ZXNoLXByb2MtdGVzdHMuZWwgfCA1MiArKysrKysrKysrKysrKysrKysrKysrKysrKysrKysK IDMgZmlsZXMgY2hhbmdlZCwgNTcgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsIGIvbGlzcC9lc2hlbGwvZXNoLWNt ZC5lbAppbmRleCBkNTIzN2VlMWYwNC4uYjgwNTk2ZjJjYWQgMTAwNjQ0Ci0tLSBhL2xpc3Av ZXNoZWxsL2VzaC1jbWQuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbApAQCAtODky LDcgKzg5Miw3IEBAIGVzaGVsbC1leGVjdXRlLXBpcGVsaW5lCiAgICAgIChzZXQgaGVhZHBy b2MgbmlsKQogICAgICAoc2V0IHRhaWxwcm9jIG5pbCkKICAgICAgKHByb2duCi0gICAgICAg LChpZiAoZmJvdW5kcCAnbWFrZS1wcm9jZXNzKQorICAgICAgICwoaWYgZXNoZWxsLXN1cHBv cnRzLWFzeW5jaHJvbm91cy1wcm9jZXNzZXMKIAkgICAgYChlc2hlbGwtZG8tcGlwZWxpbmVz ICxwaXBlbGluZSkKICAgICAgICAgICBgKGxldCAoKHRhaWwtaGFuZGxlcyAoZXNoZWxsLWR1 cGxpY2F0ZS1oYW5kbGVzCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGVzaGVs bC1jdXJyZW50LWhhbmRsZXMpKSkKZGlmZiAtLWdpdCBhL2xpc3AvZXNoZWxsL2VzaC1wcm9j LmVsIGIvbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwKaW5kZXggYTg2ZTc1MDI3OTUuLjI5NzZm NTY5NGQ3IDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lc2gtcHJvYy5lbAorKysgYi9saXNw L2VzaGVsbC9lc2gtcHJvYy5lbApAQCAtOTcsNiArOTcsOSBAQCBlc2hlbGwta2lsbC1ob29r CiAKIDs7OyBJbnRlcm5hbCBWYXJpYWJsZXM6CiAKKyhkZWZ2YXIgZXNoZWxsLXN1cHBvcnRz LWFzeW5jaHJvbm91cy1wcm9jZXNzZXMgKGZib3VuZHAgJ21ha2UtcHJvY2VzcykKKyAgIk5v bi1uaWwgaWYgRXNoZWxsIGNhbiBjcmVhdGUgYXN5bmNocm9ub3VzIHByb2Nlc3Nlcy4iKQor CiAoZGVmdmFyIGVzaGVsbC1jdXJyZW50LXN1YmpvYi1wIG5pbCkKIAogKGRlZnZhciBlc2hl bGwtcHJvY2Vzcy1saXN0IG5pbApAQCAtMjk2LDcgKzI5OSw3IEBAIGVzaGVsbC1nYXRoZXIt cHJvY2Vzcy1vdXRwdXQKICAgICAgICAgICAgICAgICAoY29kaW5nLXN5c3RlbS1jaGFuZ2Ut ZW9sLWNvbnZlcnNpb24gbG9jYWxlLWNvZGluZy1zeXN0ZW0KICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgJ3VuaXgpKSkpCiAgICAgKGNv bmQKLSAgICAgKChmYm91bmRwICdtYWtlLXByb2Nlc3MpCisgICAgIChlc2hlbGwtc3VwcG9y dHMtYXN5bmNocm9ub3VzLXByb2Nlc3NlcwogICAgICAgKHVubGVzcyAob3IgOzsgRklYTUU6 IEl0J3Mgbm90IGN1cnJlbnRseSBwb3NzaWJsZSB0byB1c2UgYQogICAgICAgICAgICAgICAg ICAgOzsgc3RkZXJyIHByb2Nlc3MgZm9yIHJlbW90ZSBmaWxlcy4KICAgICAgICAgICAgICAg ICAgIChmaWxlLXJlbW90ZS1wIGRlZmF1bHQtZGlyZWN0b3J5KQpAQCAtMzkyLDEwICszOTUs NiBAQCBlc2hlbGwtZ2F0aGVyLXByb2Nlc3Mtb3V0cHV0CiAJICAgIChzZXRxIGxiZWcgbGVu ZCkKIAkgICAgKHNldC1idWZmZXIgcHJvYy1idWYpKQogCSAgKHNldC1idWZmZXIgb2xkYnVm KSkKLSAgICAgICAgKHJlcXVpcmUgJ2VzaC1tb2RlKQotICAgICAgICAoZGVjbGFyZS1mdW5j dGlvbiBlc2hlbGwtdXBkYXRlLW1hcmtlcnMgImVzaC1tb2RlIiAocG1hcmspKQotICAgICAg ICAoZGVmdmFyIGVzaGVsbC1sYXN0LW91dHB1dC1lbmQpICAgICAgICAgO0RlZmluZWQgaW4g ZXNoLW1vZGUuZWwuCi0JKGVzaGVsbC11cGRhdGUtbWFya2VycyBlc2hlbGwtbGFzdC1vdXRw dXQtZW5kKQogCTs7IFNpbXVsYXRlIHRoZSBlZmZlY3Qgb2YgZXNoZWxsLXNlbnRpbmVsLgog CShlc2hlbGwtY2xvc2UtaGFuZGxlcwogICAgICAgICAgKGlmIChudW1iZXJwIGV4aXQtc3Rh dHVzKSBleGl0LXN0YXR1cyAtMSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNo LXByb2MtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsCmlu ZGV4IDhlMDJmYmI1NDk3Li42Mzk1YmRmNGY3MSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2Vz aGVsbC9lc2gtcHJvYy10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9j LXRlc3RzLmVsCkBAIC0xOTEsNiArMTkxLDU4IEBAIGVzaC1wcm9jLXRlc3QvcGlwZWxpbmUt Y29ubmVjdGlvbi10eXBlL2xhc3QKICAgICAgKHVubGVzcyAoZXEgc3lzdGVtLXR5cGUgJ3dp bmRvd3MtbnQpCiAgICAgICAgInN0ZG91dFxuc3RkZXJyXG4iKSkpKQogCisMCis7OyBTeW5j aHJvbm91cyBwcm9jZXNzZXMKKworOzsgVGhlc2UgdGVzdHMgY2hlY2sgdGhhdCBzeW5jaHJv bm91cyBzdWJwcm9jZXNzZXMgKG9ubHkgdXNlZCBvbgorOzsgTVMtRE9TIGJ5IGRlZmF1bHQp IHdvcmsgY29ycmVjdGx5LiAgVG8gaGVscCB0aGVtIHJ1biBvbiBNUy1ET1MgYXMKKzs7IHdl bGwsIHdlIHVzZSB0aGUgRW1hY3MgZXhlY3V0YWJsZSBhcyBvdXIgc3VicHJvY2VzcyB0byB0 ZXN0Cis7OyBhZ2FpbnN0OyB0aGF0IHdheSwgdXNlcnMgZG9uJ3QgbmVlZCB0byBoYXZlIEdO VSBjb3JldXRpbHMgKG9yCis7OyBzaW1pbGFyKSBpbnN0YWxsZWQuCisKKyhkZWZzdWJzdCBl c2gtcHJvYy10ZXN0L2VtYWNzLWNvbW1hbmQgKGNvbW1hbmQpCisgICJFdmFsdWF0ZSBDT01N QU5EIGluIGEgbmV3IEVtYWNzIGJhdGNoIGluc3RhbmNlLiIKKyAgKG1hcGNvbmNhdCAjJ3No ZWxsLXF1b3RlLWFyZ3VtZW50CisgICAgICAgICAgICAgYCgsKGV4cGFuZC1maWxlLW5hbWUg aW52b2NhdGlvbi1uYW1lIGludm9jYXRpb24tZGlyZWN0b3J5KQorICAgICAgICAgICAgICAg Ii1RIiAiLS1iYXRjaCIgIi0tZXZhbCIgLChwcmluMS10by1zdHJpbmcgY29tbWFuZCkpCisg ICAgICAgICAgICAgIiAiKSkKKworKGRlZnZhciBlc2gtcHJvYy10ZXN0L2VtYWNzLWVjaG8K KyAgKGVzaC1wcm9jLXRlc3QvZW1hY3MtY29tbWFuZCAnKG1lc3NhZ2UgImhlbGxvIikpCisg ICJBIGNvbW1hbmQgdGhhdCBwcmludHMgXCJoZWxsb1wiIHRvIHN0ZG91dCB1c2luZyBFbWFj cy4iKQorCisoZGVmdmFyIGVzaC1wcm9jLXRlc3QvZW1hY3MtdXBjYXNlCisgIChlc2gtcHJv Yy10ZXN0L2VtYWNzLWNvbW1hbmQgJyhtZXNzYWdlICIlcyIgKHVwY2FzZSAocmVhZC1zdHJp bmcgIiIpKSkpCisgICJBIGNvbW1hbmQgdGhhdCB1cGNhc2VzIHRoZSB0ZXh0IGZyb20gc3Rk aW4gdXNpbmcgRW1hY3MuIikKKworKGVydC1kZWZ0ZXN0IGVzaC1wcm9jLXRlc3Qvc3luY2hy b25vdXMtcHJvYy9zaW1wbGUvaW50ZXJhY3RpdmUgKCkKKyAgIlRlc3QgdGhhdCBzeW5jaHJv bm91cyBwcm9jZXNzZXMgd29yayBpbiBhbiBpbnRlcmFjdGl2ZSBzaGVsbC4iCisgIChsZXQg KChlc2hlbGwtc3VwcG9ydHMtYXN5bmNocm9ub3VzLXByb2Nlc3NlcyBuaWwpKQorICAgICh3 aXRoLXRlbXAtZXNoZWxsCisgICAgIChlc2hlbGwtbWF0Y2gtY29tbWFuZC1vdXRwdXQgZXNo LXByb2MtdGVzdC9lbWFjcy1lY2hvCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIlxcYGhlbGxvXG4iKSkpKQorCisoZXJ0LWRlZnRlc3QgZXNoLXByb2MtdGVzdC9zeW5j aHJvbm91cy1wcm9jL3NpbXBsZS9jb21tYW5kLXJlc3VsdCAoKQorICAiVGVzdCB0aGF0IHN5 bmNocm9ub3VzIHByb2Nlc3NlcyB3b3JrIHZpYSBgZXNoZWxsLWNvbW1hbmQtcmVzdWx0Jy4i CisgIChsZXQgKChlc2hlbGwtc3VwcG9ydHMtYXN5bmNocm9ub3VzLXByb2Nlc3NlcyBuaWwp KQorICAgIChlc2hlbGwtY29tbWFuZC1yZXN1bHQtZXF1YWwgZXNoLXByb2MtdGVzdC9lbWFj cy1lY2hvCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiaGVsbG9cbiIpKSkK KworKGVydC1kZWZ0ZXN0IGVzaC1wcm9jLXRlc3Qvc3luY2hyb25vdXMtcHJvYy9waXBlbGlu ZS9pbnRlcmFjdGl2ZSAoKQorICAiVGVzdCB0aGF0IHN5bmNocm9ub3VzIHBpcGVsaW5lcyB3 b3JrIGluIGFuIGludGVyYWN0aXZlIHNoZWxsLiIKKyAgKGxldCAoKGVzaGVsbC1zdXBwb3J0 cy1hc3luY2hyb25vdXMtcHJvY2Vzc2VzIG5pbCkpCisgICAgKHdpdGgtdGVtcC1lc2hlbGwK KyAgICAgKGVzaGVsbC1tYXRjaC1jb21tYW5kLW91dHB1dCAoY29uY2F0IGVzaC1wcm9jLXRl c3QvZW1hY3MtZWNobyAiIHwgIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgZXNoLXByb2MtdGVzdC9lbWFjcy11cGNhc2UpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIlxcYEhFTExPXG4iKSkpKQorCisoZXJ0LWRlZnRlc3QgZXNo LXByb2MtdGVzdC9zeW5jaHJvbm91cy1wcm9jL3BpcGVsaW5lL2NvbW1hbmQtcmVzdWx0ICgp CisgICJUZXN0IHRoYXQgc3luY2hyb25vdXMgcGlwZWxpbmVzIHdvcmsgdmlhIGBlc2hlbGwt Y29tbWFuZC1yZXN1bHQnLiIKKyAgKGxldCAoKGVzaGVsbC1zdXBwb3J0cy1hc3luY2hyb25v dXMtcHJvY2Vzc2VzIG5pbCkpCisgICAgKGVzaGVsbC1jb21tYW5kLXJlc3VsdC1lcXVhbCAo Y29uY2F0IGVzaC1wcm9jLXRlc3QvZW1hY3MtZWNobyAiIHwgIgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgZXNoLXByb2MtdGVzdC9lbWFjcy11cGNhc2Up CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiSEVMTE9cbiIpKSkKKwogDAog OzsgS2lsbGluZyBwcm9jZXNzZXMKIAotLSAKMi4yNS4xCgo= --------------0jXuapdzQaxVncyPwdFdtCJg-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 01:29:17 2023 Received: (at 62578) by debbugs.gnu.org; 2 Apr 2023 05:29:17 +0000 Received: from localhost ([127.0.0.1]:38979 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piqHF-0000pI-HK for submit@debbugs.gnu.org; Sun, 02 Apr 2023 01:29:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42800) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piqHE-0000p3-89 for 62578@debbugs.gnu.org; Sun, 02 Apr 2023 01:29:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piqH8-0001mV-Nm; Sun, 02 Apr 2023 01:29:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/5niVr959ivTUQ5aQASbTp7E8oPL8xsc6O+0j1uuQD8=; b=EL5owTNpoa7N s7xCE/wjVTlvDZK8F3/sd1p1W/e3fxjL2KxzvwpGEXOMEJyJY8nWOsLqmQTwnGjaAIVxIP0ygXB/Z VjSYvLqjHWEZz+PGVk/TEzJYkpF158bVQDagLAmCCAKbchPTBexZiOgXSKmaHqUXzQ84kbc04RLrb NXM8I9FqlU6QsS9sSKDB0xEUwtDDLN/d8J8q9PjC/ta6acWExj9cAULSLBMI5vNInQPSn2+XPL52E qp78FWYPSDSYKV8djxn5THWtb4OZbKmsmWDIXUVICgxcaYwZ3SnmdoQxJnjoG+dc7icavhPqeG0dJ RgnPABCEugPLYaXzbqvFPA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piqH6-000507-IF; Sun, 02 Apr 2023 01:29:08 -0400 Date: Sun, 02 Apr 2023 08:29:27 +0300 Message-Id: <837cuuyhqg.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Sat, 1 Apr 2023 17:58:59 -0700) Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> <83355k16gr.fsf@gnu.org> <83r0t4yslt.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62578 Cc: 62578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 1 Apr 2023 17:58:59 -0700 > From: Jim Porter > Cc: 62578@debbugs.gnu.org > > On 4/1/2023 12:40 AM, Jim Porter wrote: > > My only concern there is making Emacs do something reasonable when > > piping data into it, but I can just try a few things out, and if it > > really doesn't work, the existing tests in my patch are hopefully still > > better than nothing. > > Ok, that wasn't too hard. How does this look? LGTM, thanks. One minor nit: 'message' in a batch session prints to stderr, not to stdout. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 01:51:39 2023 Received: (at 62578) by debbugs.gnu.org; 2 Apr 2023 05:51:39 +0000 Received: from localhost ([127.0.0.1]:39000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piqcs-0001oS-Gd for submit@debbugs.gnu.org; Sun, 02 Apr 2023 01:51:39 -0400 Received: from mail-pj1-f54.google.com ([209.85.216.54]:40679) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piqcq-0001oG-KK for 62578@debbugs.gnu.org; Sun, 02 Apr 2023 01:51:37 -0400 Received: by mail-pj1-f54.google.com with SMTP id r7-20020a17090b050700b002404be7920aso25506008pjz.5 for <62578@debbugs.gnu.org>; Sat, 01 Apr 2023 22:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680414690; x=1683006690; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=ZLza4aALQxMiEwFbnV8kyfBPMTwDLNuX40P3EnIW2MQ=; b=PxXDRdFiwUjIEo6ea33pY/B/aO42g4kXY+URblWbADjycxFFdlGYHFw9R8rPk6Xc5c RZhSq8jeJ7izCWQ8xTcpOWL4V37WUJupBgaMoagRI1McANfWJF9xb9M2sb9l1S0z3V/A UMFkwP5d7WqkGZHiZh4YNIva5bgN6azbkqtIigqbqQbEdDFo+8JwKYPD8NWpL/Xbq084 aXtY46+P3aZKZ3JIKw/o6QG7UVkJlpvo19G19pVfTMGKiG+KCIt8GrGtTA9Wl6YvYsO/ ePek0ar/WtK3cjMsc7UDlFhxpmvlJ9Snivr5oo1fg7pOWLTTvIbp5iWCpM1tCJnbP/Oc m6YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680414690; x=1683006690; h=in-reply-to:from:references:cc:to:content-language:subject :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=ZLza4aALQxMiEwFbnV8kyfBPMTwDLNuX40P3EnIW2MQ=; b=CNhbPTMupcbdkRlglkqxgqM4rKrdcabxbP6XorvSwZGX200IoWJgIpKXNx6qkOcXjx bJckokIVwCTzsy/LsIXlSsT/lkijZ6prlNDOJDTc/2jMXSgmeSWNjbOlhgK0TJiTB+uL s2P+OlCJRs4CSiAlz6i7zDqVb9VhNmNql73lgfKhvK99l7BLHT+APmVqDInB2Aq1gwEb ZKgej2f6xqPZ3bFj5ICgrCzwc4lWyVP7iXywke1PTDnyAsm6+IEaUAp5v0U01ABZBk0S 5fBTahwRM1KpamvDdGOjd8AAHx8VqQR8t0Ch52qIptNeb4qw6IRr2ecWg3zTfp/tcLnH mJrg== X-Gm-Message-State: AAQBX9dOxwZBn39Ff2m8QuE/i7IOEmhitPH0IAUhbkmNadXZOWC2TYKS up5GU57D86eLvYUQxP//d1sRtcGRVFw= X-Google-Smtp-Source: AKy350bET3/vBh/LChmymAyjlbZC2V83JPa3y/2IqHF8FGBOx/n5KFpegStiQiCCYBEzxtgB/aV7JQ== X-Received: by 2002:a17:903:1250:b0:1a2:55ca:6669 with SMTP id u16-20020a170903125000b001a255ca6669mr28527606plh.33.1680414690472; Sat, 01 Apr 2023 22:51:30 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id bf4-20020a170902b90400b001a24bf87e20sm4226469plb.37.2023.04.01.22.51.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Apr 2023 22:51:29 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------SwcDs5cBpnqYqf54BQFgrxuK" Message-ID: <88e50b2b-f49d-c6d5-eefc-09a80c847a8f@gmail.com> Date: Sat, 1 Apr 2023 22:51:30 -0700 MIME-Version: 1.0 Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Content-Language: en-US To: Eli Zaretskii References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> <83355k16gr.fsf@gnu.org> <83r0t4yslt.fsf@gnu.org> <837cuuyhqg.fsf@gnu.org> From: Jim Porter In-Reply-To: <837cuuyhqg.fsf@gnu.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62578 Cc: 62578@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This is a multi-part message in MIME format. --------------SwcDs5cBpnqYqf54BQFgrxuK Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/1/2023 10:29 PM, Eli Zaretskii wrote: > One minor nit: 'message' in a batch session prints to stderr, not to > stdout. !! Thanks for catching that. That actually means there's a small bug (or a missing feature) in Eshell: it doesn't support redirecting stdout and stderr to separate places when using synchronous subprocesses. I've added a note about this to esh-proc.el (fixing it would probably be tricky), and changed 'message' in the tests to be 'princ'. See attached; I'll probably merge this tomorrow unless you catch any remaining issues. --------------SwcDs5cBpnqYqf54BQFgrxuK Content-Type: text/plain; charset=UTF-8; name="0001-Add-tests-for-synchronous-processes-in-Eshell.patch" Content-Disposition: attachment; filename="0001-Add-tests-for-synchronous-processes-in-Eshell.patch" Content-Transfer-Encoding: base64 RnJvbSBlYzFhNWIzY2RhMDk5NDVjYjRiNzQyNzNmOTU2ODI2N2RlNWJkOTZmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IEZyaSwgMzEgTWFyIDIwMjMgMjE6MzI6NDQgLTA3MDAKU3ViamVjdDogW1BB VENIXSA7IEFkZCB0ZXN0cyBmb3Igc3luY2hyb25vdXMgcHJvY2Vzc2VzIGluIEVzaGVsbAoK Tm9ybWFsbHksIEVzaGVsbCBvbmx5IHVzZXMgc3luY2hyb25vdXMgcHJvY2Vzc2VzIG9uIE1T LURPUywgc28gdGhpcyBpcwpoYXJkIHRvIHRlc3QuICBUbyBnZXQgYXJvdW5kIHRoaXMsIGxl dCB0aGUgdGVzdHMgZXhwbGljaXRseSByZXF1ZXN0CnN5bmNocm9ub3VzIHByb2Nlc3Nlcy4K CiogbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwgKGVzaGVsbC1zdXBwb3J0cy1hc3luY2hyb25v dXMtcHJvY2Vzc2VzKToKTmV3IHZhcmlhYmxlLi4uCihlc2hlbGwtZ2F0aGVyLXByb2Nlc3Mt b3V0cHV0KTogLi4uIHVzZSBpdCwgYW5kIHJlbW92ZSBzb21lIGluY29ycmVjdApjb2RlIHVw ZGF0aW5nIEVzaGVsbCdzIGludGVybmFsIG1hcmtlcnMgKHRoZSBhc3luYyBjb2RlIHBhdGgg ZG9lc24ndApkbyB0aGlzLCBzbyBuZWl0aGVyIHNob3VsZCB0aGUgc3luYyBwYXRoKS4KCiog bGlzcC9lc2hlbGwvZXNoLWNtZC5lbCAoZXNoZWxsLWV4ZWN1dGUtcGlwZWxpbmUpOiBVc2UK J2VzaGVsbC1zdXBwb3J0cy1hc3luY2hyb25vdXMtcHJvY2Vzc2VzJy4KCiogdGVzdC9saXNw L2VzaGVsbC9lc2gtcHJvYy10ZXN0cy5lbAooZXNoLXByb2MtdGVzdC9lbWFjcy1jb21tYW5k KTogTmV3IGZ1bmN0aW9uLgooZXNoLXByb2MtdGVzdC9lbWFjcy1lY2hvLCBlc2gtcHJvYy10 ZXN0L2VtYWNzLXVwY2FzZSk6IE5ldyB2YXJpYWJsZXMuCihlc2gtcHJvYy10ZXN0L3N5bmNo cm9ub3VzLXByb2Mvc2ltcGxlL2ludGVyYWN0aXZlKQooZXNoLXByb2MtdGVzdC9zeW5jaHJv bm91cy1wcm9jL3NpbXBsZS9jb21tYW5kLXJlc3VsdCkKKGVzaC1wcm9jLXRlc3Qvc3luY2hy b25vdXMtcHJvYy9waXBlbGluZS9pbnRlcmFjdGl2ZSkKKGVzaC1wcm9jLXRlc3Qvc3luY2hy b25vdXMtcHJvYy9waXBlbGluZS9jb21tYW5kLXJlc3VsdCk6IE5ldyB0ZXN0cy4KLS0tCiBs aXNwL2VzaGVsbC9lc2gtY21kLmVsICAgICAgICAgICAgIHwgIDIgKy0KIGxpc3AvZXNoZWxs L2VzaC1wcm9jLmVsICAgICAgICAgICAgfCAxMSArKysrLS0tCiB0ZXN0L2xpc3AvZXNoZWxs L2VzaC1wcm9jLXRlc3RzLmVsIHwgNTMgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysr CiAzIGZpbGVzIGNoYW5nZWQsIDYwIGluc2VydGlvbnMoKyksIDYgZGVsZXRpb25zKC0pCgpk aWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbCBiL2xpc3AvZXNoZWxsL2VzaC1j bWQuZWwKaW5kZXggZDUyMzdlZTFmMDQuLmI4MDU5NmYyY2FkIDEwMDY0NAotLS0gYS9saXNw L2VzaGVsbC9lc2gtY21kLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKQEAgLTg5 Miw3ICs4OTIsNyBAQCBlc2hlbGwtZXhlY3V0ZS1waXBlbGluZQogICAgICAoc2V0IGhlYWRw cm9jIG5pbCkKICAgICAgKHNldCB0YWlscHJvYyBuaWwpCiAgICAgIChwcm9nbgotICAgICAg ICwoaWYgKGZib3VuZHAgJ21ha2UtcHJvY2VzcykKKyAgICAgICAsKGlmIGVzaGVsbC1zdXBw b3J0cy1hc3luY2hyb25vdXMtcHJvY2Vzc2VzCiAJICAgIGAoZXNoZWxsLWRvLXBpcGVsaW5l cyAscGlwZWxpbmUpCiAgICAgICAgICAgYChsZXQgKCh0YWlsLWhhbmRsZXMgKGVzaGVsbC1k dXBsaWNhdGUtaGFuZGxlcwogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlc2hl bGwtY3VycmVudC1oYW5kbGVzKSkpCmRpZmYgLS1naXQgYS9saXNwL2VzaGVsbC9lc2gtcHJv Yy5lbCBiL2xpc3AvZXNoZWxsL2VzaC1wcm9jLmVsCmluZGV4IGE4NmU3NTAyNzk1Li4wMGUw YzgwMTRlMSAxMDA2NDQKLS0tIGEvbGlzcC9lc2hlbGwvZXNoLXByb2MuZWwKKysrIGIvbGlz cC9lc2hlbGwvZXNoLXByb2MuZWwKQEAgLTk3LDYgKzk3LDkgQEAgZXNoZWxsLWtpbGwtaG9v awogCiA7OzsgSW50ZXJuYWwgVmFyaWFibGVzOgogCisoZGVmdmFyIGVzaGVsbC1zdXBwb3J0 cy1hc3luY2hyb25vdXMtcHJvY2Vzc2VzIChmYm91bmRwICdtYWtlLXByb2Nlc3MpCisgICJO b24tbmlsIGlmIEVzaGVsbCBjYW4gY3JlYXRlIGFzeW5jaHJvbm91cyBwcm9jZXNzZXMuIikK KwogKGRlZnZhciBlc2hlbGwtY3VycmVudC1zdWJqb2ItcCBuaWwpCiAKIChkZWZ2YXIgZXNo ZWxsLXByb2Nlc3MtbGlzdCBuaWwKQEAgLTI5Niw3ICsyOTksNyBAQCBlc2hlbGwtZ2F0aGVy LXByb2Nlc3Mtb3V0cHV0CiAgICAgICAgICAgICAgICAgKGNvZGluZy1zeXN0ZW0tY2hhbmdl LWVvbC1jb252ZXJzaW9uIGxvY2FsZS1jb2Rpbmctc3lzdGVtCiAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICd1bml4KSkpKQogICAgIChj b25kCi0gICAgICgoZmJvdW5kcCAnbWFrZS1wcm9jZXNzKQorICAgICAoZXNoZWxsLXN1cHBv cnRzLWFzeW5jaHJvbm91cy1wcm9jZXNzZXMKICAgICAgICh1bmxlc3MgKG9yIDs7IEZJWE1F OiBJdCdzIG5vdCBjdXJyZW50bHkgcG9zc2libGUgdG8gdXNlIGEKICAgICAgICAgICAgICAg ICAgIDs7IHN0ZGVyciBwcm9jZXNzIGZvciByZW1vdGUgZmlsZXMuCiAgICAgICAgICAgICAg ICAgICAoZmlsZS1yZW1vdGUtcCBkZWZhdWx0LWRpcmVjdG9yeSkKQEAgLTM2Nyw2ICszNzAs OCBAQCBlc2hlbGwtZ2F0aGVyLXByb2Nlc3Mtb3V0cHV0CiAJKGVyYXNlLWJ1ZmZlcikKIAko c2V0LWJ1ZmZlciBvbGRidWYpCiAJKHJ1bi1ob29rLXdpdGgtYXJncyAnZXNoZWxsLWV4ZWMt aG9vayBjb21tYW5kKQorICAgICAgICA7OyBYWFg6IFRoaXMgZG9lc24ndCBzdXBwb3J0IHNl bmRpbmcgc3Rkb3V0IGFuZCBzdGRlcnIgdG8KKyAgICAgICAgOzsgc2VwYXJhdGUgcGxhY2Vz LgogCShzZXRxIGV4aXQtc3RhdHVzCiAJICAgICAgKGFwcGx5ICMnY2FsbC1wcm9jZXNzLXJl Z2lvbgogCQkgICAgIChhcHBlbmQgKGxpc3QgZXNoZWxsLWxhc3Qtc3luYy1vdXRwdXQtc3Rh cnQgKHBvaW50KQpAQCAtMzkyLDEwICszOTcsNiBAQCBlc2hlbGwtZ2F0aGVyLXByb2Nlc3Mt b3V0cHV0CiAJICAgIChzZXRxIGxiZWcgbGVuZCkKIAkgICAgKHNldC1idWZmZXIgcHJvYy1i dWYpKQogCSAgKHNldC1idWZmZXIgb2xkYnVmKSkKLSAgICAgICAgKHJlcXVpcmUgJ2VzaC1t b2RlKQotICAgICAgICAoZGVjbGFyZS1mdW5jdGlvbiBlc2hlbGwtdXBkYXRlLW1hcmtlcnMg ImVzaC1tb2RlIiAocG1hcmspKQotICAgICAgICAoZGVmdmFyIGVzaGVsbC1sYXN0LW91dHB1 dC1lbmQpICAgICAgICAgO0RlZmluZWQgaW4gZXNoLW1vZGUuZWwuCi0JKGVzaGVsbC11cGRh dGUtbWFya2VycyBlc2hlbGwtbGFzdC1vdXRwdXQtZW5kKQogCTs7IFNpbXVsYXRlIHRoZSBl ZmZlY3Qgb2YgZXNoZWxsLXNlbnRpbmVsLgogCShlc2hlbGwtY2xvc2UtaGFuZGxlcwogICAg ICAgICAgKGlmIChudW1iZXJwIGV4aXQtc3RhdHVzKSBleGl0LXN0YXR1cyAtMSkKZGlmZiAt LWdpdCBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoLXByb2MtdGVzdHMuZWwgYi90ZXN0L2xpc3Av ZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsCmluZGV4IDhlMDJmYmI1NDk3Li5mYTIwZWZhNzFl MSAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL2VzaGVsbC9lc2gtcHJvYy10ZXN0cy5lbAorKysg Yi90ZXN0L2xpc3AvZXNoZWxsL2VzaC1wcm9jLXRlc3RzLmVsCkBAIC0xOTEsNiArMTkxLDU5 IEBAIGVzaC1wcm9jLXRlc3QvcGlwZWxpbmUtY29ubmVjdGlvbi10eXBlL2xhc3QKICAgICAg KHVubGVzcyAoZXEgc3lzdGVtLXR5cGUgJ3dpbmRvd3MtbnQpCiAgICAgICAgInN0ZG91dFxu c3RkZXJyXG4iKSkpKQogCisMCis7OyBTeW5jaHJvbm91cyBwcm9jZXNzZXMKKworOzsgVGhl c2UgdGVzdHMgY2hlY2sgdGhhdCBzeW5jaHJvbm91cyBzdWJwcm9jZXNzZXMgKG9ubHkgdXNl ZCBvbgorOzsgTVMtRE9TIGJ5IGRlZmF1bHQpIHdvcmsgY29ycmVjdGx5LiAgVG8gaGVscCB0 aGVtIHJ1biBvbiBNUy1ET1MgYXMKKzs7IHdlbGwsIHdlIHVzZSB0aGUgRW1hY3MgZXhlY3V0 YWJsZSBhcyBvdXIgc3VicHJvY2VzcyB0byB0ZXN0Cis7OyBhZ2FpbnN0OyB0aGF0IHdheSwg dXNlcnMgZG9uJ3QgbmVlZCB0byBoYXZlIEdOVSBjb3JldXRpbHMgKG9yCis7OyBzaW1pbGFy KSBpbnN0YWxsZWQuCisKKyhkZWZzdWJzdCBlc2gtcHJvYy10ZXN0L2VtYWNzLWNvbW1hbmQg KGNvbW1hbmQpCisgICJFdmFsdWF0ZSBDT01NQU5EIGluIGEgbmV3IEVtYWNzIGJhdGNoIGlu c3RhbmNlLiIKKyAgKG1hcGNvbmNhdCAjJ3NoZWxsLXF1b3RlLWFyZ3VtZW50CisgICAgICAg ICAgICAgYCgsKGV4cGFuZC1maWxlLW5hbWUgaW52b2NhdGlvbi1uYW1lIGludm9jYXRpb24t ZGlyZWN0b3J5KQorICAgICAgICAgICAgICAgIi1RIiAiLS1iYXRjaCIgIi0tZXZhbCIgLChw cmluMS10by1zdHJpbmcgY29tbWFuZCkpCisgICAgICAgICAgICAgIiAiKSkKKworKGRlZnZh ciBlc2gtcHJvYy10ZXN0L2VtYWNzLWVjaG8KKyAgKGVzaC1wcm9jLXRlc3QvZW1hY3MtY29t bWFuZCAnKHByaW5jICJoZWxsb1xuIikpCisgICJBIGNvbW1hbmQgdGhhdCBwcmludHMgXCJo ZWxsb1wiIHRvIHN0ZG91dCB1c2luZyBFbWFjcy4iKQorCisoZGVmdmFyIGVzaC1wcm9jLXRl c3QvZW1hY3MtdXBjYXNlCisgIChlc2gtcHJvYy10ZXN0L2VtYWNzLWNvbW1hbmQKKyAgICco cHJpbmMgKHVwY2FzZSAoY29uY2F0IChyZWFkLXN0cmluZyAiIikgIlxuIikpKSkKKyAgIkEg Y29tbWFuZCB0aGF0IHVwY2FzZXMgdGhlIHRleHQgZnJvbSBzdGRpbiB1c2luZyBFbWFjcy4i KQorCisoZXJ0LWRlZnRlc3QgZXNoLXByb2MtdGVzdC9zeW5jaHJvbm91cy1wcm9jL3NpbXBs ZS9pbnRlcmFjdGl2ZSAoKQorICAiVGVzdCB0aGF0IHN5bmNocm9ub3VzIHByb2Nlc3NlcyB3 b3JrIGluIGFuIGludGVyYWN0aXZlIHNoZWxsLiIKKyAgKGxldCAoKGVzaGVsbC1zdXBwb3J0 cy1hc3luY2hyb25vdXMtcHJvY2Vzc2VzIG5pbCkpCisgICAgKHdpdGgtdGVtcC1lc2hlbGwK KyAgICAgKGVzaGVsbC1tYXRjaC1jb21tYW5kLW91dHB1dCBlc2gtcHJvYy10ZXN0L2VtYWNz LWVjaG8KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiXFxgaGVsbG9cbiIp KSkpCisKKyhlcnQtZGVmdGVzdCBlc2gtcHJvYy10ZXN0L3N5bmNocm9ub3VzLXByb2Mvc2lt cGxlL2NvbW1hbmQtcmVzdWx0ICgpCisgICJUZXN0IHRoYXQgc3luY2hyb25vdXMgcHJvY2Vz c2VzIHdvcmsgdmlhIGBlc2hlbGwtY29tbWFuZC1yZXN1bHQnLiIKKyAgKGxldCAoKGVzaGVs bC1zdXBwb3J0cy1hc3luY2hyb25vdXMtcHJvY2Vzc2VzIG5pbCkpCisgICAgKGVzaGVsbC1j b21tYW5kLXJlc3VsdC1lcXVhbCBlc2gtcHJvYy10ZXN0L2VtYWNzLWVjaG8KKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJoZWxsb1xuIikpKQorCisoZXJ0LWRlZnRlc3Qg ZXNoLXByb2MtdGVzdC9zeW5jaHJvbm91cy1wcm9jL3BpcGVsaW5lL2ludGVyYWN0aXZlICgp CisgICJUZXN0IHRoYXQgc3luY2hyb25vdXMgcGlwZWxpbmVzIHdvcmsgaW4gYW4gaW50ZXJh Y3RpdmUgc2hlbGwuIgorICAobGV0ICgoZXNoZWxsLXN1cHBvcnRzLWFzeW5jaHJvbm91cy1w cm9jZXNzZXMgbmlsKSkKKyAgICAod2l0aC10ZW1wLWVzaGVsbAorICAgICAoZXNoZWxsLW1h dGNoLWNvbW1hbmQtb3V0cHV0IChjb25jYXQgZXNoLXByb2MtdGVzdC9lbWFjcy1lY2hvICIg fCAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBlc2gtcHJv Yy10ZXN0L2VtYWNzLXVwY2FzZSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiXFxgSEVMTE9cbiIpKSkpCisKKyhlcnQtZGVmdGVzdCBlc2gtcHJvYy10ZXN0L3N5bmNo cm9ub3VzLXByb2MvcGlwZWxpbmUvY29tbWFuZC1yZXN1bHQgKCkKKyAgIlRlc3QgdGhhdCBz eW5jaHJvbm91cyBwaXBlbGluZXMgd29yayB2aWEgYGVzaGVsbC1jb21tYW5kLXJlc3VsdCcu IgorICAobGV0ICgoZXNoZWxsLXN1cHBvcnRzLWFzeW5jaHJvbm91cy1wcm9jZXNzZXMgbmls KSkKKyAgICAoZXNoZWxsLWNvbW1hbmQtcmVzdWx0LWVxdWFsIChjb25jYXQgZXNoLXByb2Mt dGVzdC9lbWFjcy1lY2hvICIgfCAiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBlc2gtcHJvYy10ZXN0L2VtYWNzLXVwY2FzZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICJIRUxMT1xuIikpKQorCiAMCiA7OyBLaWxsaW5nIHByb2Nl c3NlcwogCi0tIAoyLjI1LjEKCg== --------------SwcDs5cBpnqYqf54BQFgrxuK-- From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 17:25:50 2023 Received: (at 62578-done) by debbugs.gnu.org; 2 Apr 2023 21:25:50 +0000 Received: from localhost ([127.0.0.1]:42851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj5Cw-0003Gy-0k for submit@debbugs.gnu.org; Sun, 02 Apr 2023 17:25:50 -0400 Received: from mail-pl1-f177.google.com ([209.85.214.177]:42764) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj5Cq-0003Gi-SM for 62578-done@debbugs.gnu.org; Sun, 02 Apr 2023 17:25:48 -0400 Received: by mail-pl1-f177.google.com with SMTP id w4so26185644plg.9 for <62578-done@debbugs.gnu.org>; Sun, 02 Apr 2023 14:25:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680470739; x=1683062739; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=SIfTkATice1ltzrRzbmeFrpN/jiAmvsAj7LNot1VIGY=; b=oJNGsQqC0rEX7YtpoBC2EGOKd1vVdfFqevfE1AQmpdyOWf9QphguqNLm9LVxCMhvdd EVD7gJ2O0BdEZER0hBgP0tk0wN+Owc4impGQy84dNvzWnQ/U/nMDn2QWAK6HoZBDSnIO yxRE5WSUCgqKlU2VmWWE2ow2b3ykeP7dkY8Xq54ez3fD1jp+EEgUETY6EwqYFNbLvoVJ 5R5gdSlrZTCy3nAEndcDc/V9CsrGRQOhtnpfZLz81rpJGNzmZGX1bi6vgZr+QsgSJlsb gsZngWjMmIGItaYnTXuY/1DJFa1l8NKKyJtdp8EQwcg7PWw3jruSY77GFc28RWkweDTH TMVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680470739; x=1683062739; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SIfTkATice1ltzrRzbmeFrpN/jiAmvsAj7LNot1VIGY=; b=ew5ntIhXEriq1mR/mYo9qlYTK/T0BPqM7IDVmyjAchL2e1+bqiVaxgHNLWWWiu349O osjOjIlzNcJ7cQrn/3EJrIO5cJqNOQ67+bFCCbwDicRN2bWp+l+iDgI5QceTtu0qpQvU Ya2hu7jlZWTYoHJYd4cijZyjetfKOVW7rUgdEWzGSJRmT3C1dFzMBYyhSSIAnibJ7HYe nhcXb7w2ZkOgZUSKgaaEREeAsdJlGjdvJv5BRUpqMneJKB03z074E5+LHkt4foIl07zT 5pdBGQ77Qvqtt2FYyUq1PebNINid27JXO9OENpSdSxhV3klJb4XXlsQYAFBWHWT6306V PdQg== X-Gm-Message-State: AAQBX9fexbMX7BdvqnogWbPAfwXUTgmbI3yhSiIx1NpBqyJvMC2KAbfJ Rl4RIqSRHL5Q1yOeqmvrZio= X-Google-Smtp-Source: AKy350ZUfMVZxVATNa0rjI44G11TphGReRZ7DCMbmLn6/sczWLcxXdih/ETyAHNcUjyrCUJXSYln9Q== X-Received: by 2002:a17:90a:181:b0:23f:7c82:2468 with SMTP id 1-20020a17090a018100b0023f7c822468mr39455743pjc.31.1680470738784; Sun, 02 Apr 2023 14:25:38 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id x16-20020a170902b41000b0019f3e339fb4sm5174614plr.187.2023.04.02.14.25.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Apr 2023 14:25:38 -0700 (PDT) Message-ID: <4581f368-f3e0-0f21-b1cd-fd5eaef75543@gmail.com> Date: Sun, 2 Apr 2023 14:25:35 -0700 MIME-Version: 1.0 Subject: Re: bug#62578: 30.0.50; [PATCH] Add regression tests for synchronous processes in Eshell Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <8eeb9d54-1ac4-485d-f888-0f89217fc0ca@gmail.com> <83355k16gr.fsf@gnu.org> <83r0t4yslt.fsf@gnu.org> <837cuuyhqg.fsf@gnu.org> <88e50b2b-f49d-c6d5-eefc-09a80c847a8f@gmail.com> In-Reply-To: <88e50b2b-f49d-c6d5-eefc-09a80c847a8f@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62578-done Cc: 62578-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 4/1/2023 10:51 PM, Jim Porter wrote: > I'll probably merge this tomorrow unless you catch any remaining issues. Merged as 00144fa287e. Closing this now. From unknown Mon Aug 18 02:36:57 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 01 May 2023 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator