GNU bug report logs - #62577
[PATCH] refresh: Support select packages SUBSET by module name.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: 宋文武 <iyzsong <at> envs.net>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62577: closed ([PATCH] refresh: Support select packages
 SUBSET by module name.)
Date: Sun, 23 Apr 2023 07:37:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 23 Apr 2023 15:36:02 +0800
with message-id <87v8hn6of1.fsf_-_ <at> envs.net>
and subject line Re: bug#62577: [PATCH] refresh: Support select packages SUBSET by module name.
has caused the debbugs.gnu.org bug report #62577,
regarding [PATCH] refresh: Support select packages SUBSET by module name.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62577: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62577
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: iyzsong <at> envs.net
To: guix-patches <at> gnu.org
Cc: 宋文武 <iyzsong <at> member.fsf.org>
Subject: [PATCH] refresh: Support select packages SUBSET by module name.
Date: Sat,  1 Apr 2023 11:59:30 +0800

From: 宋文武 <iyzsong <at> member.fsf.org>

* guix/scripts/refresh.scm (%options): Support '--select module:NAME'.
(show-help): Adjust accordingly.
(options->update-specs): Honor the module passed by '--select'.
---
 guix/scripts/refresh.scm | 25 ++++++++++++++++++++-----
 1 file changed, 20 insertions(+), 5 deletions(-)

diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index bc6c24967a..d6ac574b1f 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -32,6 +32,7 @@ (define-module (guix scripts refresh)
   #:use-module ((guix scripts build) #:select (%standard-build-options))
   #:use-module (guix store)
   #:use-module (guix utils)
+  #:use-module (guix discovery)
   #:use-module (guix packages)
   #:use-module (guix profiles)
   #:use-module (guix upstream)
@@ -71,8 +72,15 @@ (define %options
                     ((or "core" "non-core")
                      (alist-cons 'select (string->symbol arg)
                                  result))
+                    ((? (cut string-prefix? "module:" <>))
+                     (alist-cons 'select
+                                 (cons 'module
+                                       (string->symbol
+                                        (string-drop
+                                         arg (string-length "module:"))))
+                                 result))
                     (x
-                     (leave (G_ "~a: invalid selection; expected `core' or `non-core'~%")
+                     (leave (G_ "~a: invalid selection; expected `core', `non-core' or `module:NAME'~%")
                             arg)))))
         (option '(#\t "type") #t #f
                 (lambda (opt name arg result)
@@ -141,8 +149,8 @@ (define (show-help)
   (display (G_ "
   -u, --update           update source files in place"))
   (display (G_ "
-  -s, --select=SUBSET    select all the packages in SUBSET, one of
-                         `core' or `non-core'"))
+  -s, --select=SUBSET    select all the packages in SUBSET, one of `core`,
+                         `non-core' or `module:NAME' (eg: module:guile)"))
   (display (G_ "
   -m, --manifest=FILE    select all the packages from the manifest in FILE"))
   (display (G_ "
@@ -257,13 +265,20 @@ (define update-specs
        (let ((select? (match (assoc-ref opts 'select)
                         ('core core-package?)
                         ('non-core (negate core-package?))
-                        (_ (const #t)))))
+                        (_ (const #t))))
+             (modules (match (assoc-ref opts 'select)
+                         (('module . mod)
+                          (list (resolve-interface `(gnu packages ,mod))))
+                         (_ (all-modules (%package-module-path)
+                                         #:warn
+                                         warn-about-load-error)))))
          (map update-spec
               (fold-packages (lambda (package result)
                                (if (select? package)
                                    (keep-newest package result)
                                    result))
-                             '()))))
+                             '()
+                             modules))))
       (some                                       ;user-specified packages
        some)))
 

base-commit: 1c6238794b0058003fa6c827ca0d039764ebe699
-- 
2.39.2

[Message part 3 (message/rfc822, inline)]

From: 宋文武 <iyzsong <at> envs.net>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 62577-done <at> debbugs.gnu.org
Subject: Re: bug#62577: [PATCH] refresh: Support select packages SUBSET by
 module name.
Date: Sun, 23 Apr 2023 15:36:02 +0800

Ludovic Courtès <ludo <at> gnu.org> writes:

>> +The @code{module:NAME} subset refers to all the packages in a specified
>
> s/@code{module:NAME}/@code{module:@var{name}}/
>
> Otherwise LGTM, thanks!

Pushed, thank you for review!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.