GNU bug report logs - #62574
[PATCH] Preserve peer information for web page in eww-readable

Previous Next

Package: emacs;

Reported by: Eshel Yaron <me <at> eshelyaron.com>

Date: Fri, 31 Mar 2023 18:56:02 UTC

Severity: normal

Tags: patch

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62574: closed ([PATCH] Preserve peer information for web page
 in eww-readable)
Date: Sun, 02 Apr 2023 07:41:02 +0000
[Message part 1 (text/plain, inline)]
Your message dated Sun, 02 Apr 2023 10:40:24 +0300
with message-id <83v8iewx3r.fsf <at> gnu.org>
and subject line Re: bug#62574: [PATCH] Preserve peer information for web page in eww-readable
has caused the debbugs.gnu.org bug report #62574,
regarding [PATCH] Preserve peer information for web page in eww-readable
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62574: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62574
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eshel Yaron <me <at> eshelyaron.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Preserve peer information for web page in eww-readable
Date: Fri, 31 Mar 2023 21:55:09 +0300
[Message part 3 (text/plain, inline)]
Tags: patch

Hello,

Here's a small patch that addresses a slight annoyance in EWW.

Cheers,
Eshel

In GNU Emacs 30.0.50 (build 2, x86_64-apple-darwin22.4.0, NS
 appkit-2299.50 Version 13.3 (Build 22E252)) of 2023-03-31 built on
 esmac.lan
Repository revision: 73a320801e9af61a48fd0e803afcd02b059b2338
Repository branch: master
Windowing system distributor 'Apple', version 10.3.2299
System Description:  macOS 13.3

Configured using:
 'configure CFLAGS=-O3 --with-native-compilation --with-json
 --with-tree-sitter'

[0001-Preserve-peer-information-for-web-page-in-eww-readab.patch (text/patch, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Eshel Yaron <me <at> eshelyaron.com>
Cc: 62574-done <at> debbugs.gnu.org
Subject: Re: bug#62574: [PATCH] Preserve peer information for web page in
 eww-readable
Date: Sun, 02 Apr 2023 10:40:24 +0300
> From: Eshel Yaron <me <at> eshelyaron.com>
> Cc: 62574 <at> debbugs.gnu.org
> Date: Sat, 01 Apr 2023 11:58:52 +0300
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Date: Fri, 31 Mar 2023 21:55:09 +0300
> >> From:  Eshel Yaron via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> 
> >> Here's a small patch that addresses a slight annoyance in EWW.
> >
> > Thanks, but can you please post a recipe for showing the effect of
> > this change?
> 
> Sure:
> 
> 1. Start emacs -Q
> 2. Type M-x eww RET https://gnu.org RET
>    (any HTTPS site with a valid certificate will do)
> 3. Notice the green color of the page's title in the header line that
>    indicates that the peer's certificate is valid
>    (You can also check C-h v header-line-format RET to validate that the
>    eww-valid-certificate face is applied to the title portion of the
>    header line)
> 4. Now type R to execute eww-readable
> 5. Note that the color of page's title in the header line changed (it is no longer green)

Thanks, installed on the emacs-29 branch, and closing the bug.


This bug report was last modified 2 years and 110 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.