From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 31 00:18:23 2023 Received: (at submit) by debbugs.gnu.org; 31 Mar 2023 04:18:23 +0000 Received: from localhost ([127.0.0.1]:60032 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pi6DW-0007TG-9R for submit@debbugs.gnu.org; Fri, 31 Mar 2023 00:18:23 -0400 Received: from lists.gnu.org ([209.51.188.17]:38490) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pi6DT-0007T8-Hi for submit@debbugs.gnu.org; Fri, 31 Mar 2023 00:18:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pi6DS-0004sT-Uy for bug-gnu-emacs@gnu.org; Fri, 31 Mar 2023 00:18:18 -0400 Received: from mail-pj1-x1029.google.com ([2607:f8b0:4864:20::1029]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pi6DP-0005Yk-W9 for bug-gnu-emacs@gnu.org; Fri, 31 Mar 2023 00:18:18 -0400 Received: by mail-pj1-x1029.google.com with SMTP id q102so19254585pjq.3 for ; Thu, 30 Mar 2023 21:18:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680236294; x=1682828294; h=to:subject:from:content-language:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=8R8gOFVTa7LaY5ZxmNjtAnx2kIOXmKGRJPUshOCcS8g=; b=ObBO+keguw9rgJN5cuMS6ST9gWxmPPUnSeonLe5hHkR335yuxCkBeIui7yActGf+Eq WtmMP0Wya/45F5stWiqmyId6pWNbWKaGizYJ4J+0Fcx1fIs371vJR4htV8SY48RKIx9x GFOVIEYKgypc1oB08cfiVdIJRIDyilE/RG/bSju6pO8Cb7tll7Qd4aKDg6/COzs06Gfi 9Rh2yQYYsqDiCv1aDOrYXumPJ8l3W8kTlar9QEuOSQa2FYEPv/DkYnHkbT85BPagJzVs d0iQYqHRLE/YBY5fF1+l4W388FML/PXwY09kzOTmZH8bkX+cPstVTiBw6uB5Weq2nN6S RoPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680236294; x=1682828294; h=to:subject:from:content-language:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8R8gOFVTa7LaY5ZxmNjtAnx2kIOXmKGRJPUshOCcS8g=; b=UGcX9K6/IT2VIMkpXt/DQIQIy21OvzwddhqnyIxJRSYhgnNeNEsbenDOPm3wvSCVBT I6/pvClXt2iY/vBrt29MIgbTuXjwNWZ2V2UqWqAwSpQrsSSklOGo2feeZBcFyI861Y43 6uCBYvDg3zEpHfjWKJs4E+Ci/9fNOoT2R88WgiyXpJKMD4WpmSesuXIXXOIcnPISn5vH V7w3k+061698rSBsyuZ8V62oZDCzQ2cPdiJUkPaDUEQS5SmU7NUfZVxQzDuIeIincs8N xjWVOdByEfsU3S++QaxyrjVYhRGElHwA7J5J+QzARog5HWo/VS9DwP3x41nu7L5cRGjq Aw5w== X-Gm-Message-State: AAQBX9dltr/Smqf8UTCdCHF4yze6o+gclPIpQT+8lw1owTywxjM02Sni EvKv3JlLQacLMZyTw0UfyA/r51lS0dU= X-Google-Smtp-Source: AKy350YxHYdOMA57r9vhmmQR17DTDYdNKKR262b7EhqxEnT8n85X/5iRmqcop0ljHEBJEYMqH4DATg== X-Received: by 2002:a17:90a:1997:b0:234:b964:5708 with SMTP id 23-20020a17090a199700b00234b9645708mr28222339pji.5.1680236293917; Thu, 30 Mar 2023 21:18:13 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id qb2-20020a17090b280200b00240015b837fsm9562474pjb.2.2023.03.30.21.18.12 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Mar 2023 21:18:13 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------94F9ogSD3tADBg33XzqF0qw6" Message-ID: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> Date: Thu, 30 Mar 2023 21:18:10 -0700 MIME-Version: 1.0 X-Mozilla-News-Host: news://news.gmane.io:119 Content-Language: en-US From: Jim Porter Subject: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background To: bug-gnu-emacs@gnu.org Received-SPF: pass client-ip=2607:f8b0:4864:20::1029; envelope-from=jporterbugs@gmail.com; helo=mail-pj1-x1029.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --------------94F9ogSD3tADBg33XzqF0qw6 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Starting from "emacs -Q": M-x eshell-command RET *echo hi | *cat & RET You'll see the following error in the *Messages* buffer instead of the result: eshell-eval-command: Unmatched delimiter: (# . #) This is a regression from my fix for bug#53715, which changed how Eshell pipelines return the processes in the pipeline. Attached are some patches to fix it. One for the emacs-29 branch, and one for master. Eli, is it ok to merge the patch for emacs-29? I tried to keep the change as minimal as possible for that branch. The patch for master is a bit more extensive, and also fixes another issue where this would fail due to incorrect syntax in the Eshell command form: (eshell-command "*echo hi &" t) Previously, it turned the command into "*echo hi & >>> #", but that's not right; the "&" needs to go last. For master, I also thought it would be nice to clean up 'eshell-command' slightly (see patch 0002); this just changes it to handle its arguments in the interactive spec. --------------94F9ogSD3tADBg33XzqF0qw6 Content-Type: text/plain; charset=UTF-8; name="emacs-29--0001-Fix-using-background-commands-in-eshell-command.patch" Content-Disposition: attachment; filename*0="emacs-29--0001-Fix-using-background-commands-in-eshell-comma"; filename*1="nd.patch" Content-Transfer-Encoding: base64 RnJvbSA3MGI2MmZjNjE3M2VjMjVkNmM0YzgyZTg2YWY3Y2I0YmFjYzc1YmFhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMzAgTWFyIDIwMjMgMTc6Mzk6MjQgLTA3MDAKU3ViamVjdDogW1BB VENIXSBGaXggdXNpbmcgYmFja2dyb3VuZCBjb21tYW5kcyBpbiAnZXNoZWxsLWNvbW1hbmQn CgpEbyBub3QgbWVyZ2UgdG8gbWFzdGVyLgoKVGhpcyByZWdyZXNzZWQgZHVlIHRvIHRoZSBw YXRjaCBmb3IgYnVnIzUzNzE1LCB3aGljaCBjaGFuZ2VkIGhvdwpFc2hlbGwgcGlwZWxpbmVz IHJldHVybiB0aGUgcHJvY2Vzc2VzIGluIHRoZSBwaXBlbGluZS4KCiogbGlzcC9lc2hlbGwv ZXNoLWNtZC5lbCAoZXNoZWxsLWV2YWwtY29tbWFuZCk6IEFsbG93IHByb2Nlc3MtcGFpcnMu CgoqIHRlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsIChlc2hlbGwtdGVzdC9lc2hl bGwtY29tbWFuZC9zaW1wbGUpCihlc2hlbGwtdGVzdC9lc2hlbGwtY29tbWFuZC9waXBlbGlu ZSkKKGVzaGVsbC10ZXN0L2VzaGVsbC1jb21tYW5kL2JhY2tncm91bmQpCihlc2hlbGwtdGVz dC9lc2hlbGwtY29tbWFuZC9iYWNrZ3JvdW5kLXBpcGVsaW5lKTogTmV3IHRlc3RzLgotLS0K IGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgICAgICAgICAgIHwgIDggKysrKy0tCiB0ZXN0L2xp c3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbCB8IDQ3ICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrCiAyIGZpbGVzIGNoYW5nZWQsIDUyIGluc2VydGlvbnMoKyksIDMgZGVsZXRp b25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC9lc2hlbGwvZXNoLWNtZC5lbCBiL2xpc3AvZXNo ZWxsL2VzaC1jbWQuZWwKaW5kZXggZjRhYzM4NGNjYzUuLjcwNjQ3N2E1ZjQ1IDEwMDY0NAot LS0gYS9saXNwL2VzaGVsbC9lc2gtY21kLmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1jbWQu ZWwKQEAgLTEwMzIsMTggKzEwMzIsMjAgQEAgZXNoZWxsLWV2YWwtY29tbWFuZAogICAgIChz ZXRxIGVzaGVsbC1jdXJyZW50LWNvbW1hbmQgY29tbWFuZCkKICAgICAobGV0KiAoKGRlbGlt IChjYXRjaCAnZXNoZWxsLWluY29tcGxldGUKICAgICAgICAgICAgICAgICAgICAgKGVzaGVs bC1yZXN1bWUtZXZhbCkpKQotICAgICAgICAgICAodmFsIChjYXItc2FmZSBkZWxpbSkpKQor ICAgICAgICAgICAodmFsIChjYXItc2FmZSBkZWxpbSkpCisgICAgICAgICAgICh2YWwtaXMt cHJvY2VzcyAob3IgKGVzaGVsbC1wcm9jZXNzcCB2YWwpCisgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgKGVzaGVsbC1wcm9jZXNzLXBhaXItcCB2YWwpKSkpCiAgICAgICA7OyBJ ZiB0aGUgcmV0dXJuIHZhbHVlIG9mIGBlc2hlbGwtcmVzdW1lLWV2YWwnIGlzIHdyYXBwZWQg aW4gYQogICAgICAgOzsgbGlzdCwgaXQgaW5kaWNhdGVzIHRoYXQgdGhlIGNvbW1hbmQgd2Fz IHJ1biBhc3luY2hyb25vdXNseS4KICAgICAgIDs7IEluIHRoYXQgY2FzZSwgdW53cmFwIHRo ZSB2YWx1ZSBiZWZvcmUgY2hlY2tpbmcgdGhlIGRlbGltaXRlcgogICAgICAgOzsgdmFsdWUu CiAgICAgICAoaWYgKGFuZCB2YWwKLSAgICAgICAgICAgICAgIChub3QgKGVzaGVsbC1wcm9j ZXNzcCB2YWwpKQorICAgICAgICAgICAgICAgKG5vdCB2YWwtaXMtcHJvY2VzcykKICAgICAg ICAgICAgICAgIChub3QgKGVxIHZhbCB0KSkpCiAgICAgICAgICAgKGVycm9yICJVbm1hdGNo ZWQgZGVsaW1pdGVyOiAlUyIgdmFsKQogICAgICAgICA7OyBFc2hlbGwtY29tbWFuZCBleHBl Y3QgYSBsaXN0IGxpa2UgKDxwcm9jZXNzPikgdG8ga25vdyBpZiB0aGUKICAgICAgICAgOzsg Y29tbWFuZCBzaG91bGQgYmUgYXN5bmMgb3Igbm90LgotICAgICAgICAob3IgKGFuZCAoZXNo ZWxsLXByb2Nlc3NwIHZhbCkgZGVsaW0pIHZhbCkpKSkpCisgICAgICAgIChvciAoYW5kIHZh bC1pcy1wcm9jZXNzIGRlbGltKSB2YWwpKSkpKQogCiAoZGVmdW4gZXNoZWxsLXJlc3VtZS1j b21tYW5kIChwcm9jIHN0YXR1cykKICAgIlJlc3VtZSB0aGUgY3VycmVudCBjb21tYW5kIHdo ZW4gYSBwcm9jZXNzIGVuZHMuIgpkaWZmIC0tZ2l0IGEvdGVzdC9saXNwL2VzaGVsbC9lc2hl bGwtdGVzdHMuZWwgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbAppbmRleCAz YzRhOGVjOTdlYS4uYjU3YWJlMzIyNmMgMTAwNjQ0Ci0tLSBhL3Rlc3QvbGlzcC9lc2hlbGwv ZXNoZWxsLXRlc3RzLmVsCisrKyBiL3Rlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVs CkBAIC0xMDUsNiArMTA1LDUzIEBAIGVzaGVsbC10ZXN0L2xpc3AtcmVzZXQtaW4tcGlwZWxp bmUKICAgICAgKGZvcm1hdCB0ZW1wbGF0ZSAiZm9ybWF0IFwiJXNcIiBlc2hlbGwtaW4tcGlw ZWxpbmUtcCIpCiAgICAgICJuaWwiKSkpCiAKKyhlcnQtZGVmdGVzdCBlc2hlbGwtdGVzdC9l c2hlbGwtY29tbWFuZC9zaW1wbGUgKCkKKyAgIlRlc3QgdGhhdCB0aGUgYGVzaGVsbC1jb21t YW5kJyBmdW5jdGlvbiB3cml0ZXMgdG8gdGhlIGN1cnJlbnQgYnVmZmVyLiIKKyAgKHNraXAt dW5sZXNzIChleGVjdXRhYmxlLWZpbmQgImVjaG8iKSkKKyAgKGVydC13aXRoLXRlbXAtZGly ZWN0b3J5IGVzaGVsbC1kaXJlY3RvcnktbmFtZQorICAgIChsZXQgKChlc2hlbGwtaGlzdG9y eS1maWxlLW5hbWUgbmlsKSkKKyAgICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAgIChl c2hlbGwtY29tbWFuZCAiKmVjaG8gaGkiIHQpCisgICAgICAgIChzaG91bGQgKGVxdWFsIChi dWZmZXItc3RyaW5nKSAiaGlcbiIpKSkpKSkKKworKGVydC1kZWZ0ZXN0IGVzaGVsbC10ZXN0 L2VzaGVsbC1jb21tYW5kL3BpcGVsaW5lICgpCisgICJUZXN0IHRoYXQgdGhlIGBlc2hlbGwt Y29tbWFuZCcgZnVuY3Rpb24gd3JpdGVzIHRvIHRoZSBjdXJyZW50IGJ1ZmZlci4KK1RoaXMg dGVzdCB1c2VzIGEgcGlwZWxpbmUgZm9yIHRoZSBjb21tYW5kLiIKKyAgKHNraXAtdW5sZXNz IChhbmQgKGV4ZWN1dGFibGUtZmluZCAiZWNobyIpCisgICAgICAgICAgICAgICAgICAgIChl eGVjdXRhYmxlLWZpbmQgImNhdCIpKSkKKyAgKGVydC13aXRoLXRlbXAtZGlyZWN0b3J5IGVz aGVsbC1kaXJlY3RvcnktbmFtZQorICAgIChsZXQgKChlc2hlbGwtaGlzdG9yeS1maWxlLW5h bWUgbmlsKSkKKyAgICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAgIChlc2hlbGwtY29t bWFuZCAiKmVjaG8gaGkgfCAqY2F0IiB0KQorICAgICAgICAoc2hvdWxkIChlcXVhbCAoYnVm ZmVyLXN0cmluZykgImhpXG4iKSkpKSkpCisKKyhlcnQtZGVmdGVzdCBlc2hlbGwtdGVzdC9l c2hlbGwtY29tbWFuZC9iYWNrZ3JvdW5kICgpCisgICJUZXN0IHRoYXQgYGVzaGVsbC1jb21t YW5kJyB3b3JrcyBmb3IgYmFja2dyb3VuZCBjb21tYW5kcy4iCisgIChza2lwLXVubGVzcyAo ZXhlY3V0YWJsZS1maW5kICJlY2hvIikpCisgIChlcnQtd2l0aC10ZW1wLWRpcmVjdG9yeSBl c2hlbGwtZGlyZWN0b3J5LW5hbWUKKyAgICAobGV0ICgoZXNoZWxsLWhpc3RvcnktZmlsZS1u YW1lIG5pbCkpCisgICAgICA7OyBYWFg6IFdlIGNhbid0IHdyaXRlIHRvIHRoZSBjdXJyZW50 IGJ1ZmZlciBoZXJlLCBzaW5jZQorICAgICAgOzsgYGVzaGVsbC1jb21tYW5kJyB3aWxsIHBy b2R1Y2UgYW4gaW52YWxpZCBjb21tYW5kIGluIHRoYXQKKyAgICAgIDs7IGNhc2UuICBKdXN0 IG1ha2Ugc3VyZSB0aGUgY29tbWFuZCBydW5zIGFuZCBwcm9kdWNlcyBhbiBvdXRwdXQKKyAg ICAgIDs7IGJ1ZmZlci4KKyAgICAgIChlc2hlbGwtY29tbWFuZCAiKmVjaG8gaGkgJiIpCisg ICAgICAod2l0aC1jdXJyZW50LWJ1ZmZlciAiKkVzaGVsbCBBc3luYyBDb21tYW5kIE91dHB1 dCoiCisgICAgICAgIChnb3RvLWNoYXIgKHBvaW50LW1pbikpCisgICAgICAgIChzaG91bGQg KGxvb2tpbmctYXQgIlxcW2VjaG9cXCg8WzAtOV0rPlxcKT9cXF0iKSkpKSkpCisKKyhlcnQt ZGVmdGVzdCBlc2hlbGwtdGVzdC9lc2hlbGwtY29tbWFuZC9iYWNrZ3JvdW5kLXBpcGVsaW5l ICgpCisgICJUZXN0IHRoYXQgYGVzaGVsbC1jb21tYW5kJyB3b3JrcyBmb3IgYmFja2dyb3Vu ZCBjb21tYW5kcy4KK1RoaXMgdGVzdCB1c2VzIGEgcGlwZWxpbmUgZm9yIHRoZSBjb21tYW5k LiIKKyAgKHNraXAtdW5sZXNzIChhbmQgKGV4ZWN1dGFibGUtZmluZCAiZWNobyIpCisgICAg ICAgICAgICAgICAgICAgIChleGVjdXRhYmxlLWZpbmQgImNhdCIpKSkKKyAgKGVydC13aXRo LXRlbXAtZGlyZWN0b3J5IGVzaGVsbC1kaXJlY3RvcnktbmFtZQorICAgIChsZXQgKChlc2hl bGwtaGlzdG9yeS1maWxlLW5hbWUgbmlsKSkKKyAgICAgIDs7IFhYWDogQXMgYWJvdmUsIHdl IGNhbid0IHdyaXRlIHRvIHRoZSBjdXJyZW50IGJ1ZmZlciBoZXJlLgorICAgICAgKGVzaGVs bC1jb21tYW5kICIqZWNobyBoaSB8ICpjYXQgJiIpCisgICAgICAod2l0aC1jdXJyZW50LWJ1 ZmZlciAiKkVzaGVsbCBBc3luYyBDb21tYW5kIE91dHB1dCoiCisgICAgICAgIChnb3RvLWNo YXIgKHBvaW50LW1pbikpCisgICAgICAgIChzaG91bGQgKGxvb2tpbmctYXQgIlxcW2NhdFxc KDxbMC05XSs+XFwpP1xcXSIpKSkpKSkKKwogKGVydC1kZWZ0ZXN0IGVzaGVsbC10ZXN0L2Nv bW1hbmQtcnVubmluZy1wICgpCiAgICJNb2RlbGluZSBzaG91bGQgc2hvdyBubyBjb21tYW5k IHJ1bm5pbmciCiAgICh3aXRoLXRlbXAtZXNoZWxsCi0tIAoyLjI1LjEKCg== --------------94F9ogSD3tADBg33XzqF0qw6 Content-Type: text/plain; charset=UTF-8; name="emacs-30--0001-Fix-using-background-commands-in-eshell-command.patch" Content-Disposition: attachment; filename*0="emacs-30--0001-Fix-using-background-commands-in-eshell-comma"; filename*1="nd.patch" Content-Transfer-Encoding: base64 RnJvbSBiZWQ4Mzc3M2Y0NmM1ZmM3MmU5Njk0MTM5ZGRiYzIwYmEwOTkwYzYyIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMzAgTWFyIDIwMjMgMTk6MzE6MzAgLTA3MDAKU3ViamVjdDogW1BB VENIIDEvMl0gRml4IHVzaW5nIGJhY2tncm91bmQgY29tbWFuZHMgaW4gJ2VzaGVsbC1jb21t YW5kJwoKVGhpcyByZWdyZXNzZWQgZHVlIHRvIHRoZSBwYXRjaCBmb3IgYnVnIzUzNzE1LCB3 aGljaCBjaGFuZ2VkIGhvdwpFc2hlbGwgcGlwZWxpbmVzIHJldHVybiB0aGUgcHJvY2Vzc2Vz IGluIHRoZSBwaXBlbGluZS4KCiogbGlzcC9lc2hlbGwvZXNoLWNtZC5lbCAoZXNoZWxsLXBh cnNlLWNvbW1hbmQpOiBXaGVuIGNyZWF0aW5nCmJhY2tncm91bmQgY29tbWFuZHMsIHdyYXAg dGhlIHByb2Nlc3MoZXMpIGluIGEgY29ucyBjZWxsIHdob3NlIENBUiBpcwonOmVzaGVsbC1i YWNrZ3JvdW5kJy4gIFRoaXMgbGV0cyB1cyB1c2UgZmV3ZXIgaGV1cmlzdGljcy4uLgooZXNo ZWxsLWV2YWwtY29tbWFuZCk6IC4uLiBoZXJlLiAgQWRkaXRpb25hbGx5LCBrZWVwIHRoZSBy ZXN1bHQgYW5kCnRoZSBpbmNvbXBsZXRlIGRlbGltaXRlciBzZXBhcmF0ZS4KCiogbGlzcC9l c2hlbGwvZXNoZWxsLmVsIChlc2hlbGwtY29tbWFuZCk6IENoZWNrICc6ZXNoZWxsLWJhY2tn cm91bmQnCmFuZCB1c2UgYSBtb3JlLXJvYnVzdCBtZXRob2QgZm9yIHNldHRpbmcgdGhlIG91 dHB1dCB0YXJnZXQuCgoqIHRlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVsIChlc2hl bGwtdGVzdC9lc2hlbGwtY29tbWFuZC9zaW1wbGUpCihlc2hlbGwtdGVzdC9lc2hlbGwtY29t bWFuZC9waXBlbGluZSkKKGVzaGVsbC10ZXN0L2VzaGVsbC1jb21tYW5kL2JhY2tncm91bmQp Cihlc2hlbGwtdGVzdC9lc2hlbGwtY29tbWFuZC9iYWNrZ3JvdW5kLXBpcGVsaW5lKTogTmV3 IHRlc3RzLgotLS0KIGxpc3AvZXNoZWxsL2VzaC1jbWQuZWwgICAgICAgICAgIHwgMzAgKysr KysrKysrKy0tLS0tLS0tLS0tLQogbGlzcC9lc2hlbGwvZXNoZWxsLmVsICAgICAgICAgICAg fCAyMSArKysrKy0tLS0tLS0tLS0KIHRlc3QvbGlzcC9lc2hlbGwvZXNoZWxsLXRlc3RzLmVs IHwgNDQgKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdl ZCwgNjUgaW5zZXJ0aW9ucygrKSwgMzAgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvbGlz cC9lc2hlbGwvZXNoLWNtZC5lbCBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKaW5kZXggZDUy MzdlZTFmMDQuLjYwMGEyYzNhZjBiIDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9lc2gtY21k LmVsCisrKyBiL2xpc3AvZXNoZWxsL2VzaC1jbWQuZWwKQEAgLTQyMSw3ICs0MjEsOCBAQCBl c2hlbGwtcGFyc2UtY29tbWFuZAogICAgICAgICAgICAgICAgICAgICAgICAgICAgKHN0cmlu Zz0gKGNhciBlc2hlbGwtLXNlcC10ZXJtcykgIjsiKSkKICAgICAgICAgICAgICAgICAgICAg ICAgKGVzaGVsbC1wYXJzZS1waXBlbGluZSBjbWQpCiAgICAgICAgICAgICAgICAgICAgICBg KGVzaGVsbC1kby1zdWJqb2IKLSAgICAgICAgICAgICAgICAgICAgICAgKGxpc3QgLChlc2hl bGwtcGFyc2UtcGlwZWxpbmUgY21kKSkpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgKGNv bnMgOmVzaGVsbC1iYWNrZ3JvdW5kCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICwo ZXNoZWxsLXBhcnNlLXBpcGVsaW5lIGNtZCkpKSkpCiAgICAgICAgICAgICAgKHNldHEgZXNo ZWxsLS1zZXAtdGVybXMgKGNkciBlc2hlbGwtLXNlcC10ZXJtcykpCiAgICAgICAgICAgICAg KGlmIGVzaGVsbC1pbi1waXBlbGluZS1wCiAgICAgICAgICAgICAgICAgIGNtZApAQCAtMTAz MCw3ICsxMDMxLDEyIEBAIGVzaGVsbC1ldmFsLWFyZ3VtZW50CiAgICAgKGNhZHIgcmVzdWx0 KSkpCiAKIChkZWZ1biBlc2hlbGwtZXZhbC1jb21tYW5kIChjb21tYW5kICZvcHRpb25hbCBp bnB1dCkKLSAgIkV2YWx1YXRlIHRoZSBnaXZlbiBDT01NQU5EIGl0ZXJhdGl2ZWx5LiIKKyAg IkV2YWx1YXRlIHRoZSBnaXZlbiBDT01NQU5EIGl0ZXJhdGl2ZWx5LgorUmV0dXJuIHRoZSBw cm9jZXNzIChvciBoZWFkIGFuZCB0YWlsIHByb2Nlc3NlcykgY3JlYXRlZCBieQorQ09NTUFO RCwgaWYgYW55LiAgSWYgQ09NTUFORCBpcyBhIGJhY2tncm91bmQgY29tbWFuZCwgcmV0dXJu IHRoZQorcHJvY2VzcyhlcykgaW4gYSBjb25zIGNlbGwgbGlrZToKKworICAoOmVzaGVsbC1i YWNrZ3JvdW5kIC4gUFJPQ0VTUykiCiAgIChpZiBlc2hlbGwtY3VycmVudC1jb21tYW5kCiAg ICAgICA7OyBXZSBjYW4ganVzdCBzdGljayB0aGUgbmV3IGNvbW1hbmQgYXQgdGhlIGVuZCBv ZiB0aGUgY3VycmVudAogICAgICAgOzsgb25lLCBhbmQgZXZlcnl0aGluZyB3aWxsIGhhcHBl biBhcyBpdCBzaG91bGQuCkBAIC0xMDQ2LDIwICsxMDUyLDEyIEBAIGVzaGVsbC1ldmFsLWNv bW1hbmQKICAgICAgICAgICAgKGVyYXNlLWJ1ZmZlcikKICAgICAgICAgICAgKGluc2VydCAi Y29tbWFuZDogXCIiIGlucHV0ICJcIlxuIikpKQogICAgIChzZXRxIGVzaGVsbC1jdXJyZW50 LWNvbW1hbmQgY29tbWFuZCkKLSAgICAobGV0KiAoKGRlbGltIChjYXRjaCAnZXNoZWxsLWlu Y29tcGxldGUKLSAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1yZXN1bWUtZXZhbCkpKQot ICAgICAgICAgICAodmFsIChjYXItc2FmZSBkZWxpbSkpKQotICAgICAgOzsgSWYgdGhlIHJl dHVybiB2YWx1ZSBvZiBgZXNoZWxsLXJlc3VtZS1ldmFsJyBpcyB3cmFwcGVkIGluIGEKLSAg ICAgIDs7IGxpc3QsIGl0IGluZGljYXRlcyB0aGF0IHRoZSBjb21tYW5kIHdhcyBydW4gYXN5 bmNocm9ub3VzbHkuCi0gICAgICA7OyBJbiB0aGF0IGNhc2UsIHVud3JhcCB0aGUgdmFsdWUg YmVmb3JlIGNoZWNraW5nIHRoZSBkZWxpbWl0ZXIKLSAgICAgIDs7IHZhbHVlLgotICAgICAg KGlmIChhbmQgdmFsCi0gICAgICAgICAgICAgICAobm90IChlc2hlbGwtcHJvY2Vzc3AgdmFs KSkKLSAgICAgICAgICAgICAgIChub3QgKGVxIHZhbCB0KSkpCi0gICAgICAgICAgKGVycm9y ICJVbm1hdGNoZWQgZGVsaW1pdGVyOiAlUyIgdmFsKQotICAgICAgICA7OyBFc2hlbGwtY29t bWFuZCBleHBlY3QgYSBsaXN0IGxpa2UgKDxwcm9jZXNzPikgdG8ga25vdyBpZiB0aGUKLSAg ICAgICAgOzsgY29tbWFuZCBzaG91bGQgYmUgYXN5bmMgb3Igbm90LgotICAgICAgICAob3Ig KGFuZCAoZXNoZWxsLXByb2Nlc3NwIHZhbCkgZGVsaW0pIHZhbCkpKSkpCisgICAgKGxldCog KHJlc3VsdAorICAgICAgICAgICAoZGVsaW0gKGNhdGNoICdlc2hlbGwtaW5jb21wbGV0ZQor ICAgICAgICAgICAgICAgICAgICAoaWdub3JlIChzZXRxIHJlc3VsdCAoZXNoZWxsLXJlc3Vt ZS1ldmFsKSkpKSkpCisgICAgICAod2hlbiBkZWxpbQorICAgICAgICAoZXJyb3IgIlVubWF0 Y2hlZCBkZWxpbWl0ZXI6ICVTIiBkZWxpbSkpCisgICAgICByZXN1bHQpKSkKIAogKGRlZnVu IGVzaGVsbC1yZXN1bWUtY29tbWFuZCAocHJvYyBzdGF0dXMpCiAgICJSZXN1bWUgdGhlIGN1 cnJlbnQgY29tbWFuZCB3aGVuIGEgcHJvY2VzcyBlbmRzLiIKZGlmZiAtLWdpdCBhL2xpc3Av ZXNoZWxsL2VzaGVsbC5lbCBiL2xpc3AvZXNoZWxsL2VzaGVsbC5lbAppbmRleCA3ZDJjMDMz NWRiMi4uYjcxZjI4M2JmOWYgMTAwNjQ0Ci0tLSBhL2xpc3AvZXNoZWxsL2VzaGVsbC5lbAor KysgYi9saXNwL2VzaGVsbC9lc2hlbGwuZWwKQEAgLTI5MCwyNSArMjkwLDE4IEBAIGVzaGVs bC1jb21tYW5kCiAJICAgIChlc2hlbGwtYWRkLWlucHV0LXRvLWhpc3RvcnkgY29tbWFuZCkp KSkpCiAgICh1bmxlc3MgY29tbWFuZAogICAgIChlcnJvciAiTm8gY29tbWFuZCBzcGVjaWZp ZWQhIikpCi0gIDs7IHJlZGlyZWN0aW9uIGludG8gdGhlIGN1cnJlbnQgYnVmZmVyIGlzIGFj aGlldmVkIGJ5IGFkZGluZyBhbgotICA7OyBvdXRwdXQgcmVkaXJlY3Rpb24gdG8gdGhlIGVu ZCBvZiB0aGUgY29tbWFuZCwgb2YgdGhlIGZvcm0KLSAgOzsgJ0NPTU1BTkQgPj4+ICM8YnVm ZmVyIEJVRkZFUj4nLiAgVGhpcyB3aWxsIG5vdCBpbnRlcmZlcmUgd2l0aAotICA7OyBvdGhl ciByZWRpcmVjdGlvbnMsIHNpbmNlIG11bHRpcGxlIHJlZGlyZWN0aW9ucyBtZXJlbHkgY2F1 c2UgdGhlCi0gIDs7IG91dHB1dCB0byBiZSBjb3BpZWQgdG8gbXVsdGlwbGUgdGFyZ2V0IGxv Y2F0aW9ucwotICAoaWYgYXJnCi0gICAgICAoc2V0cSBjb21tYW5kCi0JICAgIChjb25jYXQg Y29tbWFuZAotCQkgICAgKGZvcm1hdCAiID4+PiAjPGJ1ZmZlciAlcz4iCi0JCQkgICAgKGJ1 ZmZlci1uYW1lIChjdXJyZW50LWJ1ZmZlcikpKSkpKQogICAoc2F2ZS1leGN1cnNpb24KLSAg ICAobGV0ICgoYnVmIChzZXQtYnVmZmVyIChnZW5lcmF0ZS1uZXctYnVmZmVyICIgKmVzaGVs bCBjbWQqIikpKQorICAgIChsZXQgKChzdGRvdXQgKGlmIGFyZyAoY3VycmVudC1idWZmZXIp IHQpKQorICAgICAgICAgIChidWYgKHNldC1idWZmZXIgKGdlbmVyYXRlLW5ldy1idWZmZXIg IiAqZXNoZWxsIGNtZCoiKSkpCiAJICAoZXNoZWxsLW5vbi1pbnRlcmFjdGl2ZS1wIHQpKQog ICAgICAgKGVzaGVsbC1tb2RlKQogICAgICAgKGxldCogKChwcm9jIChlc2hlbGwtZXZhbC1j b21tYW5kCi0JCSAgICAobGlzdCAnZXNoZWxsLWNvbW1hbmRzCi0JCQkgIChlc2hlbGwtcGFy c2UtY29tbWFuZCBjb21tYW5kKSkpKQorICAgICAgICAgICAgICAgICAgICBgKGxldCAoKGVz aGVsbC1jdXJyZW50LWhhbmRsZXMKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAoZXNo ZWxsLWNyZWF0ZS1oYW5kbGVzICxzdGRvdXQgJ2luc2VydCkpCisgICAgICAgICAgICAgICAg ICAgICAgICAgICAoZXNoZWxsLWN1cnJlbnQtc3Viam9iLXApKQorCQkgICAgICAgLChlc2hl bGwtcGFyc2UtY29tbWFuZCBjb21tYW5kKSkpKQogCSAgICAgaW50cgotCSAgICAgKGJ1Zm5h bWUgKGlmIChhbmQgcHJvYyAobGlzdHAgcHJvYykpCisJICAgICAoYnVmbmFtZSAoaWYgKGVx IChjYXItc2FmZSBwcm9jKSA6ZXNoZWxsLWJhY2tncm91bmQpCiAJCQkgICIqRXNoZWxsIEFz eW5jIENvbW1hbmQgT3V0cHV0KiIKIAkJCShzZXRxIGludHIgdCkKIAkJCSIqRXNoZWxsIENv bW1hbmQgT3V0cHV0KiIpKSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC9lc2hlbGwvZXNoZWxs LXRlc3RzLmVsIGIvdGVzdC9saXNwL2VzaGVsbC9lc2hlbGwtdGVzdHMuZWwKaW5kZXggNzQz Y2MyOGI5YjUuLjM5MGY3NWNmYmI5IDEwMDY0NAotLS0gYS90ZXN0L2xpc3AvZXNoZWxsL2Vz aGVsbC10ZXN0cy5lbAorKysgYi90ZXN0L2xpc3AvZXNoZWxsL2VzaGVsbC10ZXN0cy5lbApA QCAtMTA3LDYgKzEwNyw1MCBAQCBlc2hlbGwtdGVzdC9saXNwLXJlc2V0LWluLXBpcGVsaW5l CiAgICAgIChmb3JtYXQgdGVtcGxhdGUgImZvcm1hdCBcIiVzXCIgZXNoZWxsLWluLXBpcGVs aW5lLXAiKQogICAgICAibmlsIikpKQogCisoZXJ0LWRlZnRlc3QgZXNoZWxsLXRlc3QvZXNo ZWxsLWNvbW1hbmQvc2ltcGxlICgpCisgICJUZXN0IHRoYXQgdGhlIGBlc2hlbGwtY29tbWFu ZCcgZnVuY3Rpb24gd3JpdGVzIHRvIHRoZSBjdXJyZW50IGJ1ZmZlci4iCisgIChza2lwLXVu bGVzcyAoZXhlY3V0YWJsZS1maW5kICJlY2hvIikpCisgIChlcnQtd2l0aC10ZW1wLWRpcmVj dG9yeSBlc2hlbGwtZGlyZWN0b3J5LW5hbWUKKyAgICAobGV0ICgoZXNoZWxsLWhpc3Rvcnkt ZmlsZS1uYW1lIG5pbCkpCisgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAoZXNo ZWxsLWNvbW1hbmQgIiplY2hvIGhpIiB0KQorICAgICAgICAoc2hvdWxkIChlcXVhbCAoYnVm ZmVyLXN0cmluZykgImhpXG4iKSkpKSkpCisKKyhlcnQtZGVmdGVzdCBlc2hlbGwtdGVzdC9l c2hlbGwtY29tbWFuZC9waXBlbGluZSAoKQorICAiVGVzdCB0aGF0IHRoZSBgZXNoZWxsLWNv bW1hbmQnIGZ1bmN0aW9uIHdyaXRlcyB0byB0aGUgY3VycmVudCBidWZmZXIuCitUaGlzIHRl c3QgdXNlcyBhIHBpcGVsaW5lIGZvciB0aGUgY29tbWFuZC4iCisgIChza2lwLXVubGVzcyAo YW5kIChleGVjdXRhYmxlLWZpbmQgImVjaG8iKQorICAgICAgICAgICAgICAgICAgICAoZXhl Y3V0YWJsZS1maW5kICJjYXQiKSkpCisgIChlcnQtd2l0aC10ZW1wLWRpcmVjdG9yeSBlc2hl bGwtZGlyZWN0b3J5LW5hbWUKKyAgICAobGV0ICgoZXNoZWxsLWhpc3RvcnktZmlsZS1uYW1l IG5pbCkpCisgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAoZXNoZWxsLWNvbW1h bmQgIiplY2hvIGhpIHwgKmNhdCIgdCkKKyAgICAgICAgKHNob3VsZCAoZXF1YWwgKGJ1ZmZl ci1zdHJpbmcpICJoaVxuIikpKSkpKQorCisoZXJ0LWRlZnRlc3QgZXNoZWxsLXRlc3QvZXNo ZWxsLWNvbW1hbmQvYmFja2dyb3VuZCAoKQorICAiVGVzdCB0aGF0IGBlc2hlbGwtY29tbWFu ZCcgd29ya3MgZm9yIGJhY2tncm91bmQgY29tbWFuZHMuIgorICAoc2tpcC11bmxlc3MgKGV4 ZWN1dGFibGUtZmluZCAiZWNobyIpKQorICAoZXJ0LXdpdGgtdGVtcC1kaXJlY3RvcnkgZXNo ZWxsLWRpcmVjdG9yeS1uYW1lCisgICAgKGxldCAoKG9yaWctcHJvY2Vzc2VzIChwcm9jZXNz LWxpc3QpKQorICAgICAgICAgIChlc2hlbGwtaGlzdG9yeS1maWxlLW5hbWUgbmlsKSkKKyAg ICAgICh3aXRoLXRlbXAtYnVmZmVyCisgICAgICAgIChlc2hlbGwtY29tbWFuZCAiKmVjaG8g aGkgJiIgdCkKKyAgICAgICAgKGVzaGVsbC13YWl0LWZvciAobGFtYmRhICgpIChlcXVhbCAo cHJvY2Vzcy1saXN0KSBvcmlnLXByb2Nlc3NlcykpKQorICAgICAgICAoc2hvdWxkIChlcXVh bCAoYnVmZmVyLXN0cmluZykgImhpXG4iKSkpKSkpCisKKyhlcnQtZGVmdGVzdCBlc2hlbGwt dGVzdC9lc2hlbGwtY29tbWFuZC9iYWNrZ3JvdW5kLXBpcGVsaW5lICgpCisgICJUZXN0IHRo YXQgYGVzaGVsbC1jb21tYW5kJyB3b3JrcyBmb3IgYmFja2dyb3VuZCBjb21tYW5kcy4KK1Ro aXMgdGVzdCB1c2VzIGEgcGlwZWxpbmUgZm9yIHRoZSBjb21tYW5kLiIKKyAgKHNraXAtdW5s ZXNzIChhbmQgKGV4ZWN1dGFibGUtZmluZCAiZWNobyIpCisgICAgICAgICAgICAgICAgICAg IChleGVjdXRhYmxlLWZpbmQgImNhdCIpKSkKKyAgKGVydC13aXRoLXRlbXAtZGlyZWN0b3J5 IGVzaGVsbC1kaXJlY3RvcnktbmFtZQorICAgIChsZXQgKChvcmlnLXByb2Nlc3NlcyAoY29w eS10cmVlIChwcm9jZXNzLWxpc3QpKSkKKyAgICAgICAgICAoZXNoZWxsLWhpc3RvcnktZmls ZS1uYW1lIG5pbCkpCisgICAgICAod2l0aC10ZW1wLWJ1ZmZlcgorICAgICAgICAoZXNoZWxs LWNvbW1hbmQgIiplY2hvIGhpIHwgKmNhdCAmIiB0KQorICAgICAgICAoZXNoZWxsLXdhaXQt Zm9yIChsYW1iZGEgKCkgKGVxdWFsIChwcm9jZXNzLWxpc3QpIG9yaWctcHJvY2Vzc2VzKSkp CisgICAgICAgIChzaG91bGQgKGVxdWFsIChidWZmZXItc3RyaW5nKSAiaGlcbiIpKSkpKSkK KwogKGVydC1kZWZ0ZXN0IGVzaGVsbC10ZXN0L2NvbW1hbmQtcnVubmluZy1wICgpCiAgICJN b2RlbGluZSBzaG91bGQgc2hvdyBubyBjb21tYW5kIHJ1bm5pbmciCiAgICh3aXRoLXRlbXAt ZXNoZWxsCi0tIAoyLjI1LjEKCg== --------------94F9ogSD3tADBg33XzqF0qw6 Content-Type: text/plain; charset=UTF-8; name="emacs-30--0002-Use-the-interactive-spec-to-set-arguments-for-eshell.patch" Content-Disposition: attachment; filename*0="emacs-30--0002-Use-the-interactive-spec-to-set-arguments-for"; filename*1="-eshell.patch" Content-Transfer-Encoding: base64 RnJvbSBlNTA2ZWE0NmUyNDk2N2ZkZGZmNmQ4NmZmOTU5NzY4Njc2NGQ4MjQ0IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBKaW0gUG9ydGVyIDxqcG9ydGVyYnVnc0BnbWFpbC5j b20+CkRhdGU6IFRodSwgMzAgTWFyIDIwMjMgMTk6Mzg6MzAgLTA3MDAKU3ViamVjdDogW1BB VENIIDIvMl0gVXNlIHRoZSAnaW50ZXJhY3RpdmUnIHNwZWMgdG8gc2V0IGFyZ3VtZW50cyBm b3IKICdlc2hlbGwtY29tbWFuZCcKCiogbGlzcC9lc2hlbGwvZXNoZWxsLmVsIChlc2hlbGwt cmVhZC1jb21tYW5kKTogTmV3IGZ1bmN0aW9uLi4uCihlc2hlbGwtY29tbWFuZCk6IC4uLiB1 c2UgaXQuICBBZGRpdGlvbmFsbHksIHJlcXVpcmUgdGhlIENPTU1BTkQKYXJndW1lbnQsIGFu ZCByZW5hbWUgQVJHIHRvIFRPLUNVUlJFTlQtQlVGRkVSLgotLS0KIGxpc3AvZXNoZWxsL2Vz aGVsbC5lbCB8IDM0ICsrKysrKysrKysrKysrKysrKy0tLS0tLS0tLS0tLS0tLS0KIDEgZmls ZSBjaGFuZ2VkLCAxOCBpbnNlcnRpb25zKCspLCAxNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9saXNwL2VzaGVsbC9lc2hlbGwuZWwgYi9saXNwL2VzaGVsbC9lc2hlbGwuZWwKaW5k ZXggYjcxZjI4M2JmOWYuLjE1ZmMyYWU2MzEwIDEwMDY0NAotLS0gYS9saXNwL2VzaGVsbC9l c2hlbGwuZWwKKysrIGIvbGlzcC9lc2hlbGwvZXNoZWxsLmVsCkBAIC0yNzIsMjYgKzI3Miwy OCBAQCBlc2hlbGwtbm9uLWludGVyYWN0aXZlLXAKIAogKGRlY2xhcmUtZnVuY3Rpb24gZXNo ZWxsLWFkZC1pbnB1dC10by1oaXN0b3J5ICJlbS1oaXN0IiAoaW5wdXQpKQogCi07OzsjIyNh dXRvbG9hZAotKGRlZnVuIGVzaGVsbC1jb21tYW5kICgmb3B0aW9uYWwgY29tbWFuZCBhcmcp Ci0gICJFeGVjdXRlIHRoZSBFc2hlbGwgY29tbWFuZCBzdHJpbmcgQ09NTUFORC4KLVdpdGgg cHJlZml4IEFSRywgaW5zZXJ0IG91dHB1dCBpbnRvIHRoZSBjdXJyZW50IGJ1ZmZlciBhdCBw b2ludC4iCi0gIChpbnRlcmFjdGl2ZSkKLSAgKHVubGVzcyBhcmcKLSAgICAoc2V0cSBhcmcg Y3VycmVudC1wcmVmaXgtYXJnKSkKLSAgKGxldCAoKGVzaGVsbC1ub24taW50ZXJhY3RpdmUt cCB0KSkKKyhkZWZ1biBlc2hlbGwtcmVhZC1jb21tYW5kICgmb3B0aW9uYWwgcHJvbXB0KQor ICAiUmVhZCBhbiBFc2hlbGwgY29tbWFuZCBmcm9tIHRoZSBtaW5pYnVmZmVyLCBwcm9tcHRp bmcgd2l0aCBQUk9NUFQuIgorICAobGV0ICgocHJvbXB0IChvciBwcm9tcHQgIkVtYWNzIHNo ZWxsIGNvbW1hbmQ6ICIpKQorICAgICAgICAoZXNoZWxsLW5vbi1pbnRlcmFjdGl2ZS1wIHQp KQogICAgIDs7IEVuYWJsZSBgZXNoZWxsLW1vZGUnIG9ubHkgaW4gdGhpcyBtaW5pYnVmZmVy LgogICAgIChtaW5pYnVmZmVyLXdpdGgtc2V0dXAtaG9vayAobGFtYmRhICgpCiAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKGVzaGVsbC1tb2RlKQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIChlc2hlbGwtY29tbWFuZC1tb2RlICsxKSkKLSAgICAg ICh1bmxlc3MgY29tbWFuZAotICAgICAgICAoc2V0cSBjb21tYW5kIChyZWFkLWZyb20tbWlu aWJ1ZmZlciAiRW1hY3Mgc2hlbGwgY29tbWFuZDogIikpCi0JKGlmIChlc2hlbGwtdXNpbmct bW9kdWxlICdlc2hlbGwtaGlzdCkKLQkgICAgKGVzaGVsbC1hZGQtaW5wdXQtdG8taGlzdG9y eSBjb21tYW5kKSkpKSkKLSAgKHVubGVzcyBjb21tYW5kCi0gICAgKGVycm9yICJObyBjb21t YW5kIHNwZWNpZmllZCEiKSkKKyAgICAgIChsZXQgKChjb21tYW5kIChyZWFkLWZyb20tbWlu aWJ1ZmZlciBwcm9tcHQpKSkKKyAgICAgICAgKHdoZW4gKGVzaGVsbC11c2luZy1tb2R1bGUg J2VzaGVsbC1oaXN0KQorICAgICAgICAgIChlc2hlbGwtYWRkLWlucHV0LXRvLWhpc3Rvcnkg Y29tbWFuZCkpCisgICAgICAgIGNvbW1hbmQpKSkpCisKKzs7OyMjI2F1dG9sb2FkCisoZGVm dW4gZXNoZWxsLWNvbW1hbmQgKGNvbW1hbmQgJm9wdGlvbmFsIHRvLWN1cnJlbnQtYnVmZmVy KQorICAiRXhlY3V0ZSB0aGUgRXNoZWxsIGNvbW1hbmQgc3RyaW5nIENPTU1BTkQuCitJZiBU Ty1DVVJSRU5ULUJVRkZFUiBpcyBub24tbmlsIChpbnRlcmFjdGl2ZWx5LCB3aXRoIHRoZSBw cmVmaXgKK2FyZ3VtZW50KSwgdGhlbiBpbnNlcnQgb3V0cHV0IGludG8gdGhlIGN1cnJlbnQg YnVmZmVyIGF0IHBvaW50LiIKKyAgKGludGVyYWN0aXZlIChsaXN0IChlc2hlbGwtcmVhZC1j b21tYW5kKQorICAgICAgICAgICAgICAgICAgICAgY3VycmVudC1wcmVmaXgtYXJnKSkKICAg KHNhdmUtZXhjdXJzaW9uCi0gICAgKGxldCAoKHN0ZG91dCAoaWYgYXJnIChjdXJyZW50LWJ1 ZmZlcikgdCkpCisgICAgKGxldCAoKHN0ZG91dCAoaWYgdG8tY3VycmVudC1idWZmZXIgKGN1 cnJlbnQtYnVmZmVyKSB0KSkKICAgICAgICAgICAoYnVmIChzZXQtYnVmZmVyIChnZW5lcmF0 ZS1uZXctYnVmZmVyICIgKmVzaGVsbCBjbWQqIikpKQogCSAgKGVzaGVsbC1ub24taW50ZXJh Y3RpdmUtcCB0KSkKICAgICAgIChlc2hlbGwtbW9kZSkKQEAgLTMxOSw3ICszMjEsNyBAQCBl c2hlbGwtY29tbWFuZAogCSAgKHdoaWxlIChhbmQgKGJvbHApIChub3QgKGJvYnApKSkKIAkg ICAgKGRlbGV0ZS1jaGFyIC0xKSkpCiAJKGNsLWFzc2VydCAoYW5kIGJ1ZiAoYnVmZmVyLWxp dmUtcCBidWYpKSkKLQkodW5sZXNzIGFyZworCSh1bmxlc3MgdG8tY3VycmVudC1idWZmZXIK IAkgIChsZXQgKChsZW4gKGlmIChub3QgaW50cikgMgogCQkgICAgICAgKGNvdW50LWxpbmVz IChwb2ludC1taW4pIChwb2ludC1tYXgpKSkpKQogCSAgICAoY29uZAotLSAKMi4yNS4xCgo= --------------94F9ogSD3tADBg33XzqF0qw6-- From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 31 02:28:57 2023 Received: (at 62556) by debbugs.gnu.org; 31 Mar 2023 06:28:57 +0000 Received: from localhost ([127.0.0.1]:60197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pi8Ft-0002e5-6E for submit@debbugs.gnu.org; Fri, 31 Mar 2023 02:28:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pi8Fr-0002ds-U5 for 62556@debbugs.gnu.org; Fri, 31 Mar 2023 02:28:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pi8Fm-00036f-Go; Fri, 31 Mar 2023 02:28:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=bdHI2Iaqg6kZkePSELCG2iohAPWxeSS3NvEH48dzff0=; b=GKnH8Z03OSij mpfwhiFL0eNwRAoJrfWW44nOcmjsPcP78PrcPooInOJ4OceCflQerbDGOyS79f0xAU0QThT3iqTGE K/ScLS1900gE4hGtwwhAUT8hMBY/aurOEPa4YmlX156/5WCDN9BbbP54/CSJaENrewqc/rl2xmQ1S rfENcM8KGs2WWUbR+rwSGdRURa9BXlORJSPUmDHj0ISgDy0jN5ZYBLaRRJFR04OkTKGsiqWCEhR6s iyg0GL1LFvD2nu0nh+3c9HETRrATzmMGbQzfJEBUo0GJ3np4TlsxMTEaJtgDc/rK+Y5QcxjofuyVG yYmEYGrd42bCVvzE08qDgg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pi8Fl-0006s5-GH; Fri, 31 Mar 2023 02:28:49 -0400 Date: Fri, 31 Mar 2023 09:29:03 +0300 Message-Id: <83tty13040.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> (message from Jim Porter on Thu, 30 Mar 2023 21:18:10 -0700) Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 30 Mar 2023 21:18:10 -0700 > From: Jim Porter > > This is a regression from my fix for bug#53715, which changed how > Eshell pipelines return the processes in the pipeline. Attached are some > patches to fix it. One for the emacs-29 branch, and one for master. Looks like there are _two_ patches for master, not one? > Eli, is it ok to merge the patch for emacs-29? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 31 16:09:34 2023 Received: (at 62556) by debbugs.gnu.org; 31 Mar 2023 20:09:34 +0000 Received: from localhost ([127.0.0.1]:34611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piL42-0007AV-GL for submit@debbugs.gnu.org; Fri, 31 Mar 2023 16:09:34 -0400 Received: from mail-pl1-f172.google.com ([209.85.214.172]:43829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piL3z-0007AG-VL for 62556@debbugs.gnu.org; Fri, 31 Mar 2023 16:09:32 -0400 Received: by mail-pl1-f172.google.com with SMTP id kc4so22316980plb.10 for <62556@debbugs.gnu.org>; Fri, 31 Mar 2023 13:09:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680293366; x=1682885366; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=zLhOkkgVmJiLwLMXQowfZTKdQfNceHDjroiMVxTU0eU=; b=DbNSTMYTbW6PkgK0QMNTAA/tnWSIB7iSfV6z25EQRaTZXN+nWsdw9IZbBhA4NrXWmM +iB4qTqlc7lftmVzfScK/UZkcGGscFHxQ+6riFN04Ium225oYw72dbN6Fd3FbSD70MS/ G7M9Yhmy29/yxsgVXnDVmprLxvIZqoUxd6B+STnYTJNuWcBOgdAW7cUpGgPbwJbTTyYH PYeYnYmzd8KaP8De2/4B/zDKvqs3t4KKrxWCYzz9oNxzDIK0ELRD8hnoBFAP9cXZxw0z 5xvo/6RB8jvUKZhVW0GKC8kzRSZb9H7vqWe9R4JcFS4iV8uiOtDMkxP18NsQTAtPRmt8 0E+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680293366; x=1682885366; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zLhOkkgVmJiLwLMXQowfZTKdQfNceHDjroiMVxTU0eU=; b=KOqL9vqfgNNI543J2Usxr+0d8EKX/ysiDAD1cvwqSHrN/XFP0W7gt2RiBYskHTiotX bCHREtObAf2zzPxJ3OhbQhod+pDHdyz4Yjt9L6wohyFuRYvMrvUglzZwM2YWW49LUA/m 0nnrciFTAb9WRQFDfFGozadOT3z6pmseQi8bd/Dnip5LS2lc1liTt6YzId5iviHPuxhv R/CYz15l1c2S2fR19J0qiZJE8v/HsHDOoqUK7AnL07dz3IQhJL6mS5G6ZRCJnr47IcyB Waxchjvgsrv1XEmbhbeqWq4U3Ef4VONvXDxWUGqOIHdtXfAIr4Now5IsoKffou2kSYdH UsSg== X-Gm-Message-State: AAQBX9eZV/wJc76rd3WCSlColgjtC2ZUN8rWoE04U7PZ2M0zdJSW85dD BzcY4E9ke0K9hCZai/XTVXcv6wzDSI0= X-Google-Smtp-Source: AKy350aGVltsniI8dkMqRDEpPBSTG1vZD4Fmv1ZR0DxwzUCrS2m7WRBVQ/QesiWSv/3lE6OrAp+PWg== X-Received: by 2002:a17:90b:1647:b0:240:afb6:b07f with SMTP id il7-20020a17090b164700b00240afb6b07fmr12136902pjb.1.1680293365815; Fri, 31 Mar 2023 13:09:25 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id w9-20020a170902a70900b001a060007fcbsm1927875plq.213.2023.03.31.13.09.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 31 Mar 2023 13:09:25 -0700 (PDT) Message-ID: <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> Date: Fri, 31 Mar 2023 13:09:24 -0700 MIME-Version: 1.0 Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background To: Eli Zaretskii References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> Content-Language: en-US From: Jim Porter In-Reply-To: <83tty13040.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/30/2023 11:29 PM, Eli Zaretskii wrote: >> Date: Thu, 30 Mar 2023 21:18:10 -0700 >> From: Jim Porter >> >> This is a regression from my fix for bug#53715, which changed how >> Eshell pipelines return the processes in the pipeline. Attached are some >> patches to fix it. One for the emacs-29 branch, and one for master. > > Looks like there are _two_ patches for master, not one? Yeah, sorry. That was clumsy wording on my part. >> Eli, is it ok to merge the patch for emacs-29? > > Yes, thanks. Thanks. Merged to emacs-29 as 6419d78fa6f. I'll wait a couple days before merging the patches for master in case anyone else has comments, since they're a bit more substantial. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 02:35:10 2023 Received: (at 62556) by debbugs.gnu.org; 1 Apr 2023 06:35:10 +0000 Received: from localhost ([127.0.0.1]:35295 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piUpS-0000Ye-11 for submit@debbugs.gnu.org; Sat, 01 Apr 2023 02:35:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46170) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piUpQ-0000YN-KK for 62556@debbugs.gnu.org; Sat, 01 Apr 2023 02:35:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUpL-0004BC-4q; Sat, 01 Apr 2023 02:35:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=areD4jInBDwjm9MU0ohxUW6BjWU+Lb0iU5nHQuPZiNU=; b=BgaR/egeO/xa fo0jyoGmHTSC8Afg+8NQuBrta3twqIrPY6jGRriuVY3SRJoWqkx+OO1paWk+SeMK1NXAsbHXP4FoK +m7z84VdD/2Xk7rS9nSH3QpSfWI4TzByE/OG3/InkmTbtIu/V8aky8n0tks/ZwSUdcKKFxBDPgut0 FOvi0rHGfpT/IRcpWn5LDHFfI0U3aYAwOF0i07mElCpU7ojMWMbCJmarP+OSmOvJMVodvzjJSOslS wymUFrm/radQ9NH20VR7LHN14YDnxyxdpFHpEX7hIRC5WwL1Y89a3E9pGSVE9e2Mcwf6ys3V4B0f3 WDv+oTs00aZvxMajVGFo5Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piUpI-0001lx-S4; Sat, 01 Apr 2023 02:35:02 -0400 Date: Sat, 01 Apr 2023 09:35:16 +0300 Message-Id: <83y1ncyusb.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> (message from Jim Porter on Fri, 31 Mar 2023 13:09:24 -0700) Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Fri, 31 Mar 2023 13:09:24 -0700 > Cc: 62556@debbugs.gnu.org > From: Jim Porter > > Thanks. Merged to emacs-29 as 6419d78fa6f. Some of the new tests (and one old as well) fail on MS-Windows: 3 unexpected results: FAILED eshell-test/eshell-command/background FAILED eshell-test/eshell-command/background-pipeline FAILED eshell-test/subcommand-reset-in-pipeline I fixed the first 2, but I don't understand what goes wrong in the last one and why: Test eshell-test/subcommand-reset-in-pipeline backtrace: signal(ert-test-failed (((should (eshell-command-result--equal comma ert-fail(((should (eshell-command-result--equal command (eshell-test (if (unwind-protect (setq value-7 (apply fn-5 args-6)) (setq form-de (let (form-description-9) (if (unwind-protect (setq value-7 (apply f (let ((value-7 'ert-form-evaluation-aborted-8)) (let (form-descripti (let* ((fn-5 #'eshell-command-result--equal) (args-6 (condition-case eshell-command-result-equal("*cat $ | * (closure (t) nil (let* ((fn-31 #'executable-find) (args-32 (conditio ert--run-test-internal(#s(ert--test-execution-info :test #s(ert-test ert-run-test(#s(ert-test :name eshell-test/subcommand-reset-in-pipel ert-run-or-rerun-test(#s(ert--stats :selector ... :tests ... :test-m ert-run-tests((not (or (tag :unstable) (tag :nativecomp))) #f(compil ert-run-tests-batch((not (or (tag :unstable) (tag :nativecomp)))) ert-run-tests-batch-and-exit((not (or (tag :unstable) (tag :nativeco eval((ert-run-tests-batch-and-exit '(not (or (tag :unstable) (tag :n command-line-1(("-L" ";." "-l" "ert" "-l" "lisp/eshell/eshell-tests. command-line() normal-top-level() Test eshell-test/subcommand-reset-in-pipeline condition: (ert-test-failed ((should (eshell-command-result--equal command (eshell-test-command-result command) result)) :form (eshell-command-result--equal "*cat $ | *cat" nil "first") :value nil :explanation (nonequal-result (command "*cat $ | *cat") (result nil) (expected "first")))) FAILED 16/16 eshell-test/subcommand-reset-in-pipeline (1.796875 sec) at lisp/eshell/eshell-tests.el:80 The test that fails is this one: (eshell-command-result-equal (format template "echo $eshell-in-pipeline-p | echo") "first") when it is run for the last template, "*cat $<%s> | *cat". As another annoyance, I get this prompt, and must type "yes RET": passed 1/16 eshell-test/command-running-p (0.203125 sec) passed 2/16 eshell-test/eshell-command/background (0.015625 sec) Buffer "*Eshell Async Command Output*" has a running process; kill it? (yes or no) yes passed 3/16 eshell-test/eshell-command/background-pipeline (2.453125 sec) Any suggestions? From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 03:36:41 2023 Received: (at 62556) by debbugs.gnu.org; 1 Apr 2023 07:36:41 +0000 Received: from localhost ([127.0.0.1]:35341 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVmy-0002RY-Tp for submit@debbugs.gnu.org; Sat, 01 Apr 2023 03:36:41 -0400 Received: from mail-pl1-f175.google.com ([209.85.214.175]:43799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piVmx-0002RH-94 for 62556@debbugs.gnu.org; Sat, 01 Apr 2023 03:36:39 -0400 Received: by mail-pl1-f175.google.com with SMTP id kc4so23545325plb.10 for <62556@debbugs.gnu.org>; Sat, 01 Apr 2023 00:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680334593; x=1682926593; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=aIG2YPPvyptL+0FF+iOWMVMY7ugAB3GdDwgiKeVEiYA=; b=DuHrCJCm85bvshiDSQB22NmAJCTFjs6EQu3F/sMWAPbu0nDPeLNUshgwQUhbeLMD1m oNWtXs3FydsegO7PKmOdb8Cnf617DXuGMM6iu2KYoirHKcQL8SQDdZExIsH1MKwhWFWv ihiIXZ4PLstN4bzCihvwDunBcWkE6tR6+4sIYcmnvq7d620/BRj9JOQtfh75FYhOSqyx HWKJky1kq2Ef5HYxGEaQHmjRFw+Rvj5IDpjoIgqbHJ2ZwS5C1ev+HlMHm400fB6A/I+8 p6jxgwhnCq9thpH7+EI3HUnnpggJlbjkI0pcu79WRXiWXzWgyGtqEHNmnUxOZ+h0zJTW lAkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680334593; x=1682926593; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=aIG2YPPvyptL+0FF+iOWMVMY7ugAB3GdDwgiKeVEiYA=; b=4K7GNbmvVSQ9+qeViFCFSrh4EZ9m+v9t8saptrJKtYMYtnetv5JNeTsjAhKSqYkTlq eA/wJuErJif5QktYKGSXdmIQNFk0waZgCTAsN00SFtyveZW+QQJ0EvTmsuTVoof0ILUK Qoz7U4LoDVvjihJxhrfev3K0FcjBOdAde25q4hnoVYp6v2+InbG0Jpob4bmwAeRoqK5w NHpwj2B/iW1tJ2x30S/NYXcPIV7nkm0H+6H2cmFVCvRy2Hob1wweOFlGfwvJ1lkPx2fX 8V2JJJ6Ije7kXonWsahAq4GRmnfm7fJBhPglcQjJTMQlHA1yNZJqomHR3d9vUnu1QvEi c3UA== X-Gm-Message-State: AAQBX9fYXLXYfzXGUv69N987qT9SJVhuGvVthKoykOJbB1Wj6CJYTa2k HKuR2pvc7z4yYdSNXToVIo4= X-Google-Smtp-Source: AKy350aTeV+wjFeJzQJHeUVk2YMJkuYWAQ9wKDeOhcR76b+RWjrACeA/ZDGtuN6symcaXN1Ha6XJcw== X-Received: by 2002:a17:90b:4c43:b0:230:b0e3:9cad with SMTP id np3-20020a17090b4c4300b00230b0e39cadmr12533297pjb.23.1680334592934; Sat, 01 Apr 2023 00:36:32 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id mh11-20020a17090b4acb00b0023cfbe7d62esm12895888pjb.1.2023.04.01.00.36.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Apr 2023 00:36:32 -0700 (PDT) Message-ID: Date: Sat, 1 Apr 2023 00:36:33 -0700 MIME-Version: 1.0 Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background Content-Language: en-US To: Eli Zaretskii References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> <83y1ncyusb.fsf@gnu.org> From: Jim Porter In-Reply-To: <83y1ncyusb.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 3/31/2023 11:35 PM, Eli Zaretskii wrote: > I fixed the first 2, but I don't understand what goes wrong in the > last one and why: [snip] > Test eshell-test/subcommand-reset-in-pipeline condition: > (ert-test-failed > ((should > (eshell-command-result--equal command > (eshell-test-command-result command) > result)) > :form > (eshell-command-result--equal "*cat $ | *cat" nil "first") > :value nil :explanation > (nonequal-result > (command "*cat $ | *cat") > (result nil) > (expected "first")))) > FAILED 16/16 eshell-test/subcommand-reset-in-pipeline (1.796875 sec) at lisp/eshell/eshell-tests.el:80 Lars reported a similar issue a while back too: . I *think* it's due to a race condition somewhere, but I've had quite a bit of difficulty fixing it. I have a couple ideas though, but they're probably too invasive for the release branch. > As another annoyance, I get this prompt, and must type "yes RET": > > passed 1/16 eshell-test/command-running-p (0.203125 sec) > passed 2/16 eshell-test/eshell-command/background (0.015625 sec) > Buffer "*Eshell Async Command Output*" has a running process; kill it? (yes or no) yes > passed 3/16 eshell-test/eshell-command/background-pipeline (2.453125 sec) > > Any suggestions? Does this patch fix it? ---------------------------------------- diff --git a/test/lisp/eshell/eshell-tests.el b/test/lisp/eshell/eshell-tests.el index bf7ec0389f0..fbff51a8873 100644 --- a/test/lisp/eshell/eshell-tests.el +++ b/test/lisp/eshell/eshell-tests.el @@ -136,6 +136,8 @@ eshell-test/eshell-command/background ;; buffer. (eshell-command "*echo hi &") (with-current-buffer "*Eshell Async Command Output*" + (while (get-buffer-process (current-buffer)) + (accept-process-output)) (goto-char (point-min)) (should (looking-at "\\[echo\\(\\.exe\\)?\\(<[0-9]+>\\)?\\]")))))) @@ -149,6 +151,8 @@ eshell-test/eshell-command/background-pipeline ;; XXX: As above, we can't write to the current buffer here. (eshell-command "*echo hi | *cat &") (with-current-buffer "*Eshell Async Command Output*" + (while (get-buffer-process (current-buffer)) + (accept-process-output)) (goto-char (point-min)) (should (looking-at "\\[cat\\(\\.exe\\)?\\(<[0-9]+>\\)?\\]")))))) From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 04:04:56 2023 Received: (at 62556) by debbugs.gnu.org; 1 Apr 2023 08:04:56 +0000 Received: from localhost ([127.0.0.1]:35403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piWEK-0003U3-E8 for submit@debbugs.gnu.org; Sat, 01 Apr 2023 04:04:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46700) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piWEI-0003To-3k for 62556@debbugs.gnu.org; Sat, 01 Apr 2023 04:04:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piWEC-0002um-LP; Sat, 01 Apr 2023 04:04:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=z5Ap2pS+3FA9g/odVMy9T+OaORI1C7Q6XPlhB6LT4A4=; b=kYWThPkUaFsk Hs//07ABVbbPeX/uKZZLaCRnxHYq6II3Ugn5nbXZgVSA++U0SzXzM1IlYNPgjM1sZlGvmZqXz7+YK UO3+yz/0g2Wbac131Mj70yNa6CjmojqBF4OXwZIrOkqywLExSCsP4GQjpDOfWmf5tvks20uYbqkFX gVc/76yOq0yqpAZwCe2EQXeqG7tIpU0ksI/ba7qMb3a+XwZ+mgLmhC0dfvuaQq7nPS80uT4F9XGNZ uBKofBeNr0Ji61fB2WwGEm8oLfPoAID58MSkmKZXd08lYvIyjKeCw0slRoeEhgVfK8Of+GtIvrxYS UHTqzlz25bCrxYVweezcIA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1piWEB-0003m4-M8; Sat, 01 Apr 2023 04:04:48 -0400 Date: Sat, 01 Apr 2023 11:05:02 +0300 Message-Id: <83pm8oyqmp.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Sat, 1 Apr 2023 00:36:33 -0700) Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> <83y1ncyusb.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 1 Apr 2023 00:36:33 -0700 > Cc: 62556@debbugs.gnu.org > From: Jim Porter > > > As another annoyance, I get this prompt, and must type "yes RET": > > > > passed 1/16 eshell-test/command-running-p (0.203125 sec) > > passed 2/16 eshell-test/eshell-command/background (0.015625 sec) > > Buffer "*Eshell Async Command Output*" has a running process; kill it? (yes or no) yes > > passed 3/16 eshell-test/eshell-command/background-pipeline (2.453125 sec) > > > > Any suggestions? > > Does this patch fix it? Yes, thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Apr 01 13:31:54 2023 Received: (at 62556) by debbugs.gnu.org; 1 Apr 2023 17:31:54 +0000 Received: from localhost ([127.0.0.1]:38528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pif4z-0000sK-Uz for submit@debbugs.gnu.org; Sat, 01 Apr 2023 13:31:54 -0400 Received: from mail-pj1-f46.google.com ([209.85.216.46]:34731) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pif4y-0000s8-IV for 62556@debbugs.gnu.org; Sat, 01 Apr 2023 13:31:52 -0400 Received: by mail-pj1-f46.google.com with SMTP id l9-20020a17090a3f0900b0023d32684e7fso10675655pjc.1 for <62556@debbugs.gnu.org>; Sat, 01 Apr 2023 10:31:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680370306; x=1682962306; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=gnhIWo9y7qaYpt8zBgTpas7XXKSaUq0tU+iJYxqPcn8=; b=kflGsgLsxXDP1eVlio8hdx0uKSmdUU6831kW2i2I0z/AuGvF/IFFZe3uMESQ9vB6jU jtgQwUbyGX6/5zK0G9x+gU46jel4w39X0zaNv77BgZYI9DagWD10JH4jemsGyq4v/Ov9 tl5Q5lwPUUFUtIQj3w5+RLbaJaQaTpHhJy8TwQFvXw6aC70Z43nM5jw+pXoawV+rvy/W atwDStKxOxZHvQloYRx4U0/qqYFS1y5F9AHZMBqWDkrwHuOP1mVpZ0dv6wQ6Yz14E7tz 8oDDEIPaGSqwkFnI4I2bPgwv17/KrSEfWkCXqsBv1DZNMljVI8b4L001AbTjMwG+pw3n ul2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680370306; x=1682962306; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gnhIWo9y7qaYpt8zBgTpas7XXKSaUq0tU+iJYxqPcn8=; b=zuvqiqoF/Ic9hoV9mSzMtmOznFwVRy7qowqNQ+GPwrFA774Ukyx/T/p/BRtxO1mUz4 yoG6MrUduhKC5mqAlEVVSTwOfzPyzE7nDAi7defI7w6PUGa8wil83bGAuFvpr5vV4tEM 4WEqmWfr9ayuD2da/9md2AYJ+o78mZxEVJ7eQpEa38H4gSqnjuOtEq63QPg5Z5pke2tP dBMsMnqPfO1iKlWUzV0VQRu3QA6tj+N2cuAy6HAmnH3pBn1MQV8XcE5c+U6XHbp/nusI TJCiBX/YWxWL1GROYtxETCdp0jKKLNNrJUq1Hs0YAfHmY1rdKGyKp7G3SCgESJ6726p3 eNuQ== X-Gm-Message-State: AAQBX9elR6i8Ku6FrFpueqtCk761gBTRTNgb7S9VZt32GkKsD0Rn2TgR 1FvEk566lDcE1AwK1hkrlw8= X-Google-Smtp-Source: AKy350byBjNV87NjDonONwhpovNLUXuZi55dV1xSVc8mlxQ2qLnvGoCeWcVD2p+DYXGEGDAQK644BQ== X-Received: by 2002:a17:90b:1e01:b0:23f:b35b:7789 with SMTP id pg1-20020a17090b1e0100b0023fb35b7789mr35532713pjb.28.1680370306196; Sat, 01 Apr 2023 10:31:46 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id ix12-20020a170902f80c00b001960706141fsm3621044plb.149.2023.04.01.10.31.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 01 Apr 2023 10:31:45 -0700 (PDT) Message-ID: Date: Sat, 1 Apr 2023 10:31:44 -0700 MIME-Version: 1.0 Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background Content-Language: en-US To: Eli Zaretskii References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> <83y1ncyusb.fsf@gnu.org> <83pm8oyqmp.fsf@gnu.org> From: Jim Porter In-Reply-To: <83pm8oyqmp.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 4/1/2023 1:05 AM, Eli Zaretskii wrote: >> Date: Sat, 1 Apr 2023 00:36:33 -0700 >> Cc: 62556@debbugs.gnu.org >> From: Jim Porter >> >> Does this patch fix it? > > Yes, thanks. Thanks. Pushed as 89e337c3fc9. I'll make sure these issues are addressed in the patches for master and then push them in a day or so, too. From debbugs-submit-bounces@debbugs.gnu.org Sun Apr 02 18:09:11 2023 Received: (at 62556-done) by debbugs.gnu.org; 2 Apr 2023 22:09:11 +0000 Received: from localhost ([127.0.0.1]:42909 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj5ss-0004ZB-UH for submit@debbugs.gnu.org; Sun, 02 Apr 2023 18:09:11 -0400 Received: from mail-pj1-f49.google.com ([209.85.216.49]:44732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj5sr-0004Yl-1f for 62556-done@debbugs.gnu.org; Sun, 02 Apr 2023 18:09:09 -0400 Received: by mail-pj1-f49.google.com with SMTP id qe8-20020a17090b4f8800b0023f07253a2cso28581948pjb.3 for <62556-done@debbugs.gnu.org>; Sun, 02 Apr 2023 15:09:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680473343; x=1683065343; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=tYFRaJtjMWYna+m6f6bfYXtUUUMtGM4Jyn02s68CXq4=; b=bdTTiu0n+RN7IUwVQiKNYP6qcKsbfiGOmDi4GnMJvY4zXRpSHH6FphfZVX7HE+yoMw f0MLyRZykN4xhMH7Ff0xv1v2KDdjmliXhpBPRMGLTY1febO/C+kkvapO/KNZTa22id6x DRteng/lT8VWpLs68YUz4DTB5fUaAdRmPNvWZLk2eT3hepRaVbNXoVOY9EKlgLrYhUUC 9kVZe7YpdKrVhV3l/m3AlMU7VQgyjbZZu5hHYZ/YJBXwTV1eMvAP79u6eWqPBl1ff24T gUv0Q++AmGesu0LUA+bu3wJX0PYp1fK/f8+uOUyL8tOMlcVJJyAF3EqupGp+/6FEq8z+ 0iEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680473343; x=1683065343; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=tYFRaJtjMWYna+m6f6bfYXtUUUMtGM4Jyn02s68CXq4=; b=3apxornSv104QXjUYtG4b2h++F/wIzN2iMryEuuysHyIi2gmPfmZE5aC+cTv1vj7J0 IYqDprQofbGpGk5FIfEPLVqmh9RDBoSXnbKOk52+IP1KWnP6Mcyidi6rc3AkmgKmV5j9 QVlhbbCMm9MyoOR7wHcvbWoNRJ2c92qfQbuB17oez2l8EC0J3nqScY+MVBWvrr0gzxvh /78KB5syG14ZjxfY/esb9xGyhuuIMx+0mnX8yMzjSfcQYiWKbBlO8Tkm996C592bI2pe eGOPcw5Pe+k+2fv1hqx7wKWLQp+BMEJ+RosDaI3k9D7/CFaYTzSciw8VwKUtSaONjxgx kQqw== X-Gm-Message-State: AAQBX9cztxrtP252u71SFqt2Fi+Odyn4bhTmJ+OOvxSf31KQyhnCoH/l cgJIAx3v25WAqYwvuGohA1I3Z7AXYFk= X-Google-Smtp-Source: AKy350bOuaZevmrVNME54SYCFAE7Pear/wsvalQGjk5qVqGPjSBbOgcqRy6evzEjPN03S2MMYNH0pw== X-Received: by 2002:a17:90b:4a46:b0:240:b3ae:d881 with SMTP id lb6-20020a17090b4a4600b00240b3aed881mr18061116pjb.5.1680473343265; Sun, 02 Apr 2023 15:09:03 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id 63-20020a17090a0fc500b0023493354f37sm8444569pjz.26.2023.04.02.15.09.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 02 Apr 2023 15:09:02 -0700 (PDT) Message-ID: Date: Sun, 2 Apr 2023 15:09:01 -0700 MIME-Version: 1.0 Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background Content-Language: en-US From: Jim Porter To: Eli Zaretskii References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> <83y1ncyusb.fsf@gnu.org> <83pm8oyqmp.fsf@gnu.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62556-done Cc: 62556-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 4/1/2023 10:31 AM, Jim Porter wrote: > I'll make sure these issues are addressed in the patches for master and > then push them in a day or so, too. Pushed to master as 093a360251a. Closing this now. Hopefully this works on MS-Windows; I think I wrote it in a way where it should behave the same on all platforms. If not, just let me know, and I'll try to fix it. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 06:32:13 2023 Received: (at 62556) by debbugs.gnu.org; 6 Apr 2023 10:32:13 +0000 Received: from localhost ([127.0.0.1]:53527 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkMua-0008To-Us for submit@debbugs.gnu.org; Thu, 06 Apr 2023 06:32:13 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56924) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkMuY-0008TW-4O for 62556@debbugs.gnu.org; Thu, 06 Apr 2023 06:32:11 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkMuS-0002Kv-MP; Thu, 06 Apr 2023 06:32:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/y6unETV132QW2QVPF0H+tOE2UxnBvn1yMMER0H/94w=; b=BNKjYuSkRmIm JHW1HTlkbj0SohgKkz+wwrqpQZfoPusjlJVtz8jPLuW3bqRzmK/PcoApGfGfIan6ytl+nk+APPg3j zoRSnB0mMAiVsb6qIdxjGx/tiTVYxIOOnCPsZa9XhPa3bpCdynSwhuNfWaq9FS4M8JLstE7EwP3P8 bx0iEfQKb99CrJoKOoI0OHFDoeDUeIqNNqzXeg2K9NV1DNSW7xT/DLLHn7OzssGJUSaw3SSFvOWPI 9VWool9QI1zJD8ElhV77drjTY6UH4EajKwEx4A+5IAXKRGguetSfAax0hqyDp+hd3ik4Sv7Qz/GBQ 76cRi/ICK6D27kraBOgedQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkMuG-0005N8-Na; Thu, 06 Apr 2023 06:32:04 -0400 Date: Thu, 06 Apr 2023 13:32:22 +0300 Message-Id: <83edoxqp1l.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Sun, 2 Apr 2023 15:09:01 -0700) Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> <83y1ncyusb.fsf@gnu.org> <83pm8oyqmp.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 2 Apr 2023 15:09:01 -0700 > From: Jim Porter > Cc: 62556-done@debbugs.gnu.org > > On 4/1/2023 10:31 AM, Jim Porter wrote: > > I'll make sure these issues are addressed in the patches for master and > > then push them in a day or so, too. > > Pushed to master as 093a360251a. Closing this now. > > Hopefully this works on MS-Windows; I think I wrote it in a way where it > should behave the same on all platforms. If not, just let me know, and > I'll try to fix it. Which tests are those? The commit you name has no changes for the test suite, so I'm unsure which tests to run. From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 14:08:12 2023 Received: (at 62556) by debbugs.gnu.org; 6 Apr 2023 18:08:13 +0000 Received: from localhost ([127.0.0.1]:55113 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkU1s-00051k-MU for submit@debbugs.gnu.org; Thu, 06 Apr 2023 14:08:12 -0400 Received: from mail-pl1-f170.google.com ([209.85.214.170]:43610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkU1p-00051R-Uy for 62556@debbugs.gnu.org; Thu, 06 Apr 2023 14:08:10 -0400 Received: by mail-pl1-f170.google.com with SMTP id kc4so38232144plb.10 for <62556@debbugs.gnu.org>; Thu, 06 Apr 2023 11:08:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680804484; x=1683396484; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=1pgQBJhvsNP1SNBhQg/xIYJs6MO+pYoUblu6x40DLfo=; b=AVhlqoEffVC0BbSKZUsByIqHib27z3X0ifiDiSoMKu9RG9sua1G3bOsy0XtT1tTKZC Wp48yQS1covwJ3CVfKXUW0Wx6ckYvIRBMX6ml8/jC5kUpDbe3xy2p49bcM2bV1OR23nZ MZJcMzsujQXFFXd5ihkqYSS+4w6uOZpW6/WHpQAs08OHIHaHVf92L7BmLMB+JKkP6Htb OwTQIHnsNMNHJWos5mvL3Oqh0AVFK5BemITrxwz58dmht6ES2ZJiPwtCAVW4Pugogeip R7/7JBs8fTWuX596dGJOF2V3HJT+CEKz4ZRhqolXM3EC2Ft45rE3TIFJH12WvMB240JG cr4Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680804484; x=1683396484; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1pgQBJhvsNP1SNBhQg/xIYJs6MO+pYoUblu6x40DLfo=; b=rPKu9CfL6EytOXnTAkX2n2ASqHztMSV/XMoq43ZMeJWWV8BgKp4lvSptfV4SpZiDd7 wseIz0HLyS8YWtgBkpRNtU7DTn/cC2jA9sjHJGyT/c9LQmuhf0lmzv0frI/0xiCq8yG/ jwBZx2x5rvMyBgNQ7MQ+RD6+Wzk/Ja9tZpVUTRIidXkTXDoZtx06iZShaTe5LPkivqGp Lr8KqAMLQh6vCIhB4gJvzkPBpwD1p0B8t2yIr9eIa7V6uB/J7om1NfxoCfwjeac+O3O+ lDoOhu2zdSU67WpKBMwrqeqdOfBq0s5L6E/mOIWXRPR01/2pISt7BhCdVGH0zNgcxjMT LOkw== X-Gm-Message-State: AAQBX9c13UTuIW4NO6ZwVpOLeDcyAZFb6sUBkEsUwO+BZrZgKpEt8kBn 7eGg2U5Fkq7BIVG22gdNTvc= X-Google-Smtp-Source: AKy350aEi6abjLtB7ptUZWgyd1ksGoWTWwdiFYFHhlqoqJx5REHV+rtFMdJ4ZDGVX1Vb1L+Y6joXiA== X-Received: by 2002:a05:6a20:499e:b0:da:f473:4ff5 with SMTP id fs30-20020a056a20499e00b000daf4734ff5mr472441pzb.17.1680804483823; Thu, 06 Apr 2023 11:08:03 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id p19-20020a634f53000000b0050be8e0b94csm1369520pgl.90.2023.04.06.11.08.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Apr 2023 11:08:03 -0700 (PDT) Message-ID: Date: Thu, 6 Apr 2023 11:08:05 -0700 MIME-Version: 1.0 Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background Content-Language: en-US To: Eli Zaretskii References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> <83y1ncyusb.fsf@gnu.org> <83pm8oyqmp.fsf@gnu.org> <83edoxqp1l.fsf@gnu.org> From: Jim Porter In-Reply-To: <83edoxqp1l.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 4/6/2023 3:32 AM, Eli Zaretskii wrote: > Which tests are those? The commit you name has no changes for the > test suite, so I'm unsure which tests to run. The commit is 267fca267fe, and the test file I changed is test/lisp/eshell/eshell-tests.el. (That was the commit immediately prior to 093a360251a in my patch series.) From debbugs-submit-bounces@debbugs.gnu.org Thu Apr 06 14:27:53 2023 Received: (at 62556) by debbugs.gnu.org; 6 Apr 2023 18:27:54 +0000 Received: from localhost ([127.0.0.1]:55134 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkUKv-0005dq-Kp for submit@debbugs.gnu.org; Thu, 06 Apr 2023 14:27:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41386) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pkUKt-0005da-Ib for 62556@debbugs.gnu.org; Thu, 06 Apr 2023 14:27:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkUKd-0001AL-Gi; Thu, 06 Apr 2023 14:27:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=+JQUcGmxxfkbs19drx/2WNOkQ35kT3OGvu9jHc/e2yk=; b=QtmOObc1MRq9 Dp91d/l28Cht5D1PZKHaASDIs8cgB1+4+gcH0SVhhmqcdzWvtX/RLhUJYa/M0pLjjSM+QSt9Yn9r0 Og6YMGuIvzec3E/W2UUDlL+nkyJed4CTE2PAeInU+qsDy35PM4YDbMFzRWsKzBKjCbB3q6O66mTBf m3Eiqe4fRW0WzLIxRb0PhME36jealMv+BzLHE6j/yeQWYHhFLPhNfKf6O/UkRysEqx6jtzNNKVTBM Z8Xs1y7IRC34wDVJS1wZx9sYd/ifMzF5DjWNhbwGz0cTTKzdJMYB3qoKD3lkBJEmDuraG5wYPu+is X4FogtCLtVXzuyuTiAmgIg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pkUKX-0000YU-Jv; Thu, 06 Apr 2023 14:27:34 -0400 Date: Thu, 06 Apr 2023 21:28:00 +0300 Message-Id: <83o7o0q30v.fsf@gnu.org> From: Eli Zaretskii To: Jim Porter In-Reply-To: (message from Jim Porter on Thu, 6 Apr 2023 11:08:05 -0700) Subject: Re: bug#62556: 29.0.60; [PATCH] Fix regression when calling 'eshell-command' with a pipeline in the background References: <2bb74356-66ec-d417-5732-e1e18b3df1e3@gmail.com> <83tty13040.fsf@gnu.org> <84b09e1c-7670-0f4d-fb26-ed33010214e5@gmail.com> <83y1ncyusb.fsf@gnu.org> <83pm8oyqmp.fsf@gnu.org> <83edoxqp1l.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62556 Cc: 62556@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 6 Apr 2023 11:08:05 -0700 > Cc: 62556@debbugs.gnu.org > From: Jim Porter > > On 4/6/2023 3:32 AM, Eli Zaretskii wrote: > > Which tests are those? The commit you name has no changes for the > > test suite, so I'm unsure which tests to run. > > The commit is 267fca267fe, and the test file I changed is > test/lisp/eshell/eshell-tests.el. (That was the commit immediately prior > to 093a360251a in my patch series.) Thanks, those tests work on MS-Windows. From unknown Sun Jun 22 00:54:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 05 May 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator