GNU bug report logs - #62550
[PATCH] gnu: Add alienblaster.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Yovan Naumovski <yovan <at> gorski.stream>
Subject: bug#62550: closed (Re: [bug#62550] [PATCH v2] gnu: Add alienblaster.)
Date: Fri, 21 Apr 2023 09:00:04 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#62550: [PATCH] gnu: Add alienblaster.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 62550 <at> debbugs.gnu.org.

-- 
62550: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62550
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Yovan Naumovski via Guix-patches via <guix-patches <at> gnu.org>
Cc: 62550-done <at> debbugs.gnu.org, mirai <at> makinata.eu,
 Yovan Naumovski <yovan <at> gorski.stream>
Subject: Re: [bug#62550] [PATCH v2] gnu: Add alienblaster.
Date: Fri, 21 Apr 2023 10:59:27 +0200

Hello,

Yovan Naumovski via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/games.scm (alienblaster): New variable.

Thank you. I applied your patch with the following changes.

> +       (uri (string-append "http://www.schwardtnet.de/alienblaster/archives/"
> +                           name "-" version ".tgz"))

I replaced name with alienblaster.

> +       (sha256
> +        (base32
> +         "104rfsfsv446n4y52p5zw9h8mhgjyrbca8fpyhnxkkasq141a264"))))
> +    (build-system gnu-build-system)
> +    (inputs (list sdl sdl-mixer))

Nitpick: I moved inputs after arguments… out of habit.

> +    (arguments
> +     (list
> +      #:tests? #f  ; no tests
> +      #:phases
> +      #~(modify-phases %standard-phases
> +          (add-after 'unpack 'fix-sdl-paths
> +            (lambda _
> +              (let ((share (string-append #$output "/share")))
> +                ;; fix name and append path to SDL_mixer.h

Nitpick: I used proper capitalization and typography (missing final
full stop).

> +                (substitute* "src/Makefile"
> +                  (("GAME_NAME=alienBlaster")
> +                   "GAME_NAME=alienblaster")
> +                  (("SDL_FLAGS=\\$\\(shell sdl-config --cflags\\)" line)
> +                   (string-append line " -I" #$sdl-mixer "/include/SDL")))

I replace #$sdl-mixer with #$(this-package-inputs "sdl-mixer") for
compatibility with package transformations.

> +                ;; substitute relative paths in .cfg and source/header files

Nitpick: Here too, I slightly reformatted the comment.

> +                (substitute* (find-files "./cfg")
> +                  (("(\\./)?images") (string-append share "/images")))
> +                (substitute* (list "src/global.h" "src/global.cc")
> +                  (("./images") (string-append share "/images"))
> +                  (("./sound") (string-append share "/sound"))
> +                  (("./cfg") (string-append share "/cfg"))))))
> +
> +          (delete 'configure)
> +
> +          (replace 'install
> +            (lambda _
> +              (let ((bin (string-append #$output "/bin")))
> +                (install-file "alienblaster" bin)
> +                (for-each
> +                 (lambda (dir)
> +                   (copy-recursively dir (string-append #$output "/share/" dir)))
> +                 '("images" "sound" "cfg")))
> +              #t)))))

I removed the trailing #T, which is not necessary in new package style.

Regards,
-- 
Nicolas Goaziou

[Message part 3 (message/rfc822, inline)]

From: Yovan Naumovski <yovan <at> gorski.stream>
To: guix-patches <at> gnu.org
Cc: Yovan Naumovski <yovan <at> gorski.stream>
Subject: [PATCH] gnu: Add alienblaster.
Date: Thu, 30 Mar 2023 22:26:29 +0300

* gnu/packages/games.scm (alienblaster): New variable.
---
 gnu/packages/games.scm | 58 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 58 insertions(+)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 5825b8d936..be42a6a51a 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -3705,6 +3705,64 @@ (define-public mars
 match, cannon keep, and grave-itation pit.")
       (license license:gpl3+))))
 
+(define-public alienblaster
+  (package
+   (name "alienblaster")
+   (version "1.1.0")
+   (source
+    (origin
+     (method url-fetch)
+     (uri (string-append "http://www.schwardtnet.de/alienblaster/archives/"
+                         name "-" version ".tgz"))
+     (sha256
+      (base32
+       "104rfsfsv446n4y52p5zw9h8mhgjyrbca8fpyhnxkkasq141a264"))))
+   (build-system gnu-build-system)
+   (inputs (list sdl sdl-mixer))
+   (arguments
+    '(#:tests? #f ;; no tests
+      #:phases
+      (modify-phases %standard-phases
+        (add-after 'unpack 'fix-sdl-paths
+          (lambda* (#:key inputs outputs #:allow-other-keys)
+            (let* ((out (assoc-ref outputs "out"))
+                   (share (string-append out "/share"))
+                   (sdl-mixer (assoc-ref inputs "sdl-mixer")))
+
+              ;; fix name and append path to SDL_mixer.h
+              (substitute* "src/Makefile"
+                (("GAME_NAME=alienBlaster")
+                 "GAME_NAME=alienblaster")
+                (("SDL_FLAGS=\\$\\(shell sdl-config --cflags\\)" line)
+                 (string-append line " -I" sdl-mixer "/include/SDL")))
+
+              ;; substitute relative paths in .cfg and source/header files
+              (substitute* (find-files "./cfg")
+                (("(\\./)?images") (string-append share "/images")))
+              (substitute* (list "src/global.h" "src/global.cc")
+                (("./images") (string-append share "/images"))
+                (("./sound") (string-append share "/sound"))
+                (("./cfg") (string-append share "/cfg"))))))
+
+        (delete 'configure)
+
+        (replace 'install
+          (lambda* (#:key outputs #:allow-other-keys)
+            (let* ((out (assoc-ref outputs "out"))
+                   (bin (string-append out "/bin")))
+              (install-file "alienblaster" bin)
+              (for-each
+               (lambda (dir)
+                 (copy-recursively dir (string-append out "/share/" dir)))
+               '("images" "sound" "cfg")))
+            #t)))))
+   (home-page "http://www.schwardtnet.de/alienblaster/")
+   (synopsis "Action-loaded 2D arcade shooter game")
+   (description "Alien Blaster is an action-loaded 2D arcade shooter
+game. Your mission in the game is simple: stop the invasion of the aliens by
+blasting them. Simultaneous two-player mode is available.")
+   (license license:gpl2)))
+
 (define glkterm
   (package
    (name "glkterm")
-- 
2.39.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.