From unknown Fri Jun 20 05:37:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62550 <62550@debbugs.gnu.org> To: bug#62550 <62550@debbugs.gnu.org> Subject: Status: [PATCH] gnu: Add alienblaster. Reply-To: bug#62550 <62550@debbugs.gnu.org> Date: Fri, 20 Jun 2025 12:37:05 +0000 retitle 62550 [PATCH] gnu: Add alienblaster. reassign 62550 guix-patches submitter 62550 Yovan Naumovski severity 62550 normal tag 62550 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 30 15:27:05 2023 Received: (at submit) by debbugs.gnu.org; 30 Mar 2023 19:27:05 +0000 Received: from localhost ([127.0.0.1]:59459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phxvN-0002jm-9X for submit@debbugs.gnu.org; Thu, 30 Mar 2023 15:27:05 -0400 Received: from lists.gnu.org ([209.51.188.17]:59166) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phxvJ-0002jL-AL for submit@debbugs.gnu.org; Thu, 30 Mar 2023 15:27:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phxvI-0007K3-FR for guix-patches@gnu.org; Thu, 30 Mar 2023 15:27:00 -0400 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phxvG-0001nR-3V for guix-patches@gnu.org; Thu, 30 Mar 2023 15:27:00 -0400 Received: (Authenticated sender: yovan@gorski.stream) by mail.gandi.net (Postfix) with ESMTPSA id A3860FF806; Thu, 30 Mar 2023 19:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gorski.stream; s=gm1; t=1680204412; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=Yy6PCbxpv3c2oqO9HfZoLZ0OHfY8QC6DGpU/cLFoDuM=; b=lRfspo0IO+H9pYSRvZFiZDnHRB2W1sYtd/vzm/I36/ML+SQDdIut0+1L7bbw/VtKIls5WH YbWZK7KbJEH59PINUmrUXA7xYhoBqRic5FgkrnbP+q6IFDKpZm3nRoSWzmluPr7cAVUfDk UkLF3E8m0M6gZyeGzfy8I39NLJJgz2B31LG26ptkHd8VBcXiHVJsV7rGh/qw434xdBQOCx DBvaTEBFj6fHSvlyFB88m3r2+xR+N0dKi+UKy55pIFgCCoX7kxiuAGsz8uraChgtITtyjT SpgwZSamR2WA8uxFEPkDISCY9kZlV7JU71F35BB/tZZmMdoFSFJtCVwSBiAqQA== From: Yovan Naumovski To: guix-patches@gnu.org Subject: [PATCH] gnu: Add alienblaster. Date: Thu, 30 Mar 2023 22:26:29 +0300 Message-Id: <20230330192629.31655-1-yovan@gorski.stream> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2001:4b98:dc4:8::229; envelope-from=yovan@gorski.stream; helo=relay9-d.mail.gandi.net X-Spam_score_int: -2 X-Spam_score: -0.3 X-Spam_bar: / X-Spam_report: (-0.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FROM_SUSPICIOUS_NTLD=0.499, FROM_SUSPICIOUS_NTLD_FP=1.999, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_PDS_OTHER_BAD_TLD=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.4 (/) X-Debbugs-Envelope-To: submit Cc: Yovan Naumovski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) * gnu/packages/games.scm (alienblaster): New variable. --- gnu/packages/games.scm | 58 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 58 insertions(+) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 5825b8d936..be42a6a51a 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -3705,6 +3705,64 @@ (define-public mars match, cannon keep, and grave-itation pit.") (license license:gpl3+)))) +(define-public alienblaster + (package + (name "alienblaster") + (version "1.1.0") + (source + (origin + (method url-fetch) + (uri (string-append "http://www.schwardtnet.de/alienblaster/archives/" + name "-" version ".tgz")) + (sha256 + (base32 + "104rfsfsv446n4y52p5zw9h8mhgjyrbca8fpyhnxkkasq141a264")))) + (build-system gnu-build-system) + (inputs (list sdl sdl-mixer)) + (arguments + '(#:tests? #f ;; no tests + #:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-sdl-paths + (lambda* (#:key inputs outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (share (string-append out "/share")) + (sdl-mixer (assoc-ref inputs "sdl-mixer"))) + + ;; fix name and append path to SDL_mixer.h + (substitute* "src/Makefile" + (("GAME_NAME=alienBlaster") + "GAME_NAME=alienblaster") + (("SDL_FLAGS=\\$\\(shell sdl-config --cflags\\)" line) + (string-append line " -I" sdl-mixer "/include/SDL"))) + + ;; substitute relative paths in .cfg and source/header files + (substitute* (find-files "./cfg") + (("(\\./)?images") (string-append share "/images"))) + (substitute* (list "src/global.h" "src/global.cc") + (("./images") (string-append share "/images")) + (("./sound") (string-append share "/sound")) + (("./cfg") (string-append share "/cfg")))))) + + (delete 'configure) + + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin"))) + (install-file "alienblaster" bin) + (for-each + (lambda (dir) + (copy-recursively dir (string-append out "/share/" dir))) + '("images" "sound" "cfg"))) + #t))))) + (home-page "http://www.schwardtnet.de/alienblaster/") + (synopsis "Action-loaded 2D arcade shooter game") + (description "Alien Blaster is an action-loaded 2D arcade shooter +game. Your mission in the game is simple: stop the invasion of the aliens by +blasting them. Simultaneous two-player mode is available.") + (license license:gpl2))) + (define glkterm (package (name "glkterm") -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 31 06:41:40 2023 Received: (at 62550) by debbugs.gnu.org; 31 Mar 2023 10:41:40 +0000 Received: from localhost ([127.0.0.1]:60447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piCCR-0001y7-SS for submit@debbugs.gnu.org; Fri, 31 Mar 2023 06:41:40 -0400 Received: from smtpm4.myservices.hosting ([185.26.105.235]:58502) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piCCQ-0001xy-64 for 62550@debbugs.gnu.org; Fri, 31 Mar 2023 06:41:38 -0400 Received: from mail1.netim.hosting (unknown [185.26.106.173]) by smtpm4.myservices.hosting (Postfix) with ESMTP id 87AFE20A4A; Fri, 31 Mar 2023 12:41:36 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mail1.netim.hosting (Postfix) with ESMTP id 3354A800A4; Fri, 31 Mar 2023 12:41:36 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at mail1.netim.hosting Received: from mail1.netim.hosting ([127.0.0.1]) by localhost (mail1-2.netim.hosting [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id N99cW0P2ROVY; Fri, 31 Mar 2023 12:41:35 +0200 (CEST) Received: from [192.168.1.239] (unknown [10.192.1.83]) (Authenticated sender: lumen@makinata.eu) by mail1.netim.hosting (Postfix) with ESMTPSA id 8C7F7800A0; Fri, 31 Mar 2023 12:41:35 +0200 (CEST) Message-ID: <44ee896c-d97a-456a-bb0d-24dfa3e71b7c@makinata.eu> Date: Fri, 31 Mar 2023 11:41:27 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [bug#62550] [PATCH] gnu: Add alienblaster. Content-Language: en-US To: Yovan Naumovski References: <20230330192629.31655-1-yovan@gorski.stream> From: Bruno Victal In-Reply-To: <20230330192629.31655-1-yovan@gorski.stream> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62550 Cc: 62550@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi Yovan, On 2023-03-30 20:26, Yovan Naumovski via Guix-patches via wrote: > + (arguments > + '(#:tests? #f ;; no tests > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'fix-sdl-paths > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (share (string-append out "/share")) > + (sdl-mixer (assoc-ref inputs "sdl-mixer"))) > + > + ;; fix name and append path to SDL_mixer.h > + (substitute* "src/Makefile" > + (("GAME_NAME=alienBlaster") > + "GAME_NAME=alienblaster") > + (("SDL_FLAGS=\\$\\(shell sdl-config --cflags\\)" line) > + (string-append line " -I" sdl-mixer "/include/SDL"))) > + > + ;; substitute relative paths in .cfg and source/header files > + (substitute* (find-files "./cfg") > + (("(\\./)?images") (string-append share "/images"))) > + (substitute* (list "src/global.h" "src/global.cc") > + (("./images") (string-append share "/images")) > + (("./sound") (string-append share "/sound")) > + (("./cfg") (string-append share "/cfg")))))) > + > + (delete 'configure) > + > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (install-file "alienblaster" bin) > + (for-each > + (lambda (dir) > + (copy-recursively dir (string-append out "/share/" dir))) > + '("images" "sound" "cfg"))) > + #t))))) You should use G-Expressions here, i.e. (arguments (list #:tests? #f ; no tests #:phases #~(modify-phases %standard-phases (add-after 'unpack 'fix-sdl-paths (lambda* (#:key inputs #:allow-other-keys) (let ((out (assoc-ref outputs "out")) (share (string-append #$output "/share")) (sdl-mixer (assoc-ref inputs "sdl-mixer"))) ;; fix name and append path to SDL_mixer.h (substitute* "src/Makefile" (("GAME_NAME=alienBlaster") "GAME_NAME=alienblaster") (("SDL_FLAGS=\\$\\(shell sdl-config --cflags\\)" line) (string-append line " -I" sdl-mixer "/include/SDL"))) ;; substitute relative paths in .cfg and source/header files (substitute* (find-files "./cfg") (("(\\./)?images") (string-append share "/images"))) (substitute* (list "src/global.h" "src/global.cc") (("./images") (string-append share "/images")) (("./sound") (string-append share "/sound")) (("./cfg") (string-append share "/cfg")))))) … ) Take a look at the existing packages that use G-Expressions for inspiration. (examples that come to mind are mympd, libavif, autokey, rng-tools, dropwatch, nvme-cli, …) > + (home-page "http://www.schwardtnet.de/alienblaster/") > + (synopsis "Action-loaded 2D arcade shooter game") > + (description "Alien Blaster is an action-loaded 2D arcade shooter > +game. Your mission in the game is simple: stop the invasion of the aliens by > +blasting them. Simultaneous two-player mode is available.") Keep the sentences separated with two spaces between them. (Texinfo syntax) Thanks, Bruno From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 31 12:04:12 2023 Received: (at 62550) by debbugs.gnu.org; 31 Mar 2023 16:04:12 +0000 Received: from localhost ([127.0.0.1]:34313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piHEZ-0008Pn-KS for submit@debbugs.gnu.org; Fri, 31 Mar 2023 12:04:12 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:50871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piHEW-0008PZ-Qx for 62550@debbugs.gnu.org; Fri, 31 Mar 2023 12:04:10 -0400 Received: (Authenticated sender: yovan@gorski.stream) by mail.gandi.net (Postfix) with ESMTPSA id B2BD3FF803; Fri, 31 Mar 2023 16:04:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gorski.stream; s=gm1; t=1680278642; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=4qrJbRfX/c48Ozjss7HYBSfBlEmA9zupJmeNWnwiqaY=; b=LxShCMpw7bHJIeb95is3iG0//Fbvr/qrsMplZagxyRs9txu94ezDzkBqACkQhGtxySvltI qArj+ADSRw0OdzVStXoUUZ8DP+ikjXdKtXL2wT/MCFnhjVsC4cmpd5L7nKHaUE59tmxuJF /H3jBTfW3kRqWchMi55AJw1uQ29Kh+E3qE5RsmrKHnUGN388+Si91hhuZ693Rd68WYhpce xL8fPmZohaKq+5xEZ1npDOsdNqARvVyW+bH3sSq88rouErmlW8bv4TUnosRcMz8NmhBmOj EDh21C+7rFArgZ+JoBe4ZoIT5Gzy+7CcXpxPCUfp9ssUstKox+nN5b493lCiuQ== From: Yovan Naumovski To: 62550@debbugs.gnu.org Subject: [PATCH v2] gnu: Add alienblaster. Date: Fri, 31 Mar 2023 19:03:46 +0300 Message-Id: <20230331160346.25800-1-yovan@gorski.stream> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Thank you for your tips and feedback Bruno! * gnu/packages/games.scm (alienblaster): New variable. --- gnu/packages/games.scm | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 T_PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: gorski.stream (stream)] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [217.70.183.199 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at https://www.dnswl.org/, low trust [217.70.183.199 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 2.0 FROM_SUSPICIOUS_NTLD_FP From abused NTLD 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD X-Debbugs-Envelope-To: 62550 Cc: mirai@makinata.eu, Yovan Naumovski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Thank you for your tips and feedback Bruno! * gnu/packages/games.scm (alienblaster): New variable. --- gnu/packages/games.scm | 55 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm index 5825b8d936..394f68cd50 100644 --- a/gnu/packages/games.scm +++ b/gnu/packages/games.scm @@ -3705,6 +3705,61 @@ (define-public mars match, cannon keep, and grave-itation pit.") (license license:gpl3+)))) +(define-public alienblaster + (package + (name "alienblaster") + (version "1.1.0") + (source + (origin + (method url-fetch) + (uri (string-append "http://www.schwardtnet.de/alienblaster/archives/" + name "-" version ".tgz")) + (sha256 + (base32 + "104rfsfsv446n4y52p5zw9h8mhgjyrbca8fpyhnxkkasq141a264")))) + (build-system gnu-build-system) + (inputs (list sdl sdl-mixer)) + (arguments + (list + #:tests? #f ; no tests + #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'fix-sdl-paths + (lambda _ + (let ((share (string-append #$output "/share"))) + ;; fix name and append path to SDL_mixer.h + (substitute* "src/Makefile" + (("GAME_NAME=alienBlaster") + "GAME_NAME=alienblaster") + (("SDL_FLAGS=\\$\\(shell sdl-config --cflags\\)" line) + (string-append line " -I" #$sdl-mixer "/include/SDL"))) + + ;; substitute relative paths in .cfg and source/header files + (substitute* (find-files "./cfg") + (("(\\./)?images") (string-append share "/images"))) + (substitute* (list "src/global.h" "src/global.cc") + (("./images") (string-append share "/images")) + (("./sound") (string-append share "/sound")) + (("./cfg") (string-append share "/cfg")))))) + + (delete 'configure) + + (replace 'install + (lambda _ + (let ((bin (string-append #$output "/bin"))) + (install-file "alienblaster" bin) + (for-each + (lambda (dir) + (copy-recursively dir (string-append #$output "/share/" dir))) + '("images" "sound" "cfg"))) + #t))))) + (home-page "http://www.schwardtnet.de/alienblaster/") + (synopsis "Action-loaded 2D arcade shooter game") + (description "Alien Blaster is an action-loaded 2D arcade shooter +game. Your mission in the game is simple: stop the invasion of the aliens by +blasting them. Simultaneous two-player mode is available.") + (license license:gpl2))) + (define glkterm (package (name "glkterm") -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Fri Apr 21 04:59:39 2023 Received: (at submit) by debbugs.gnu.org; 21 Apr 2023 08:59:39 +0000 Received: from localhost ([127.0.0.1]:39259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppmcF-0001g9-9o for submit@debbugs.gnu.org; Fri, 21 Apr 2023 04:59:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:39542) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ppmcD-0001g0-P3 for submit@debbugs.gnu.org; Fri, 21 Apr 2023 04:59:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppmcD-0001PW-9b for guix-patches@gnu.org; Fri, 21 Apr 2023 04:59:37 -0400 Received: from relay4-d.mail.gandi.net ([2001:4b98:dc4:8::224]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ppmcB-00057n-1B for guix-patches@gnu.org; Fri, 21 Apr 2023 04:59:36 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by mail.gandi.net (Postfix) with ESMTPSA id 6A242E0007; Fri, 21 Apr 2023 08:59:28 +0000 (UTC) From: Nicolas Goaziou To: Yovan Naumovski via Guix-patches via Subject: Re: [bug#62550] [PATCH v2] gnu: Add alienblaster. References: <20230330192629.31655-1-yovan@gorski.stream> <20230331160346.25800-1-yovan@gorski.stream> Date: Fri, 21 Apr 2023 10:59:27 +0200 In-Reply-To: <20230331160346.25800-1-yovan@gorski.stream> (Yovan Naumovski via Guix-patches via's message of "Fri, 31 Mar 2023 19:03:46 +0300") Message-ID: <87a5z1626o.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2001:4b98:dc4:8::224; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 62550-done@debbugs.gnu.org, mirai@makinata.eu, Yovan Naumovski X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Hello, Yovan Naumovski via Guix-patches via writes: > * gnu/packages/games.scm (alienblaster): New variable. Thank you. I applied your patch with the following changes. > + (uri (string-append "http://www.schwardtnet.de/alienblaster/archi= ves/" > + name "-" version ".tgz")) I replaced name with alienblaster. > + (sha256 > + (base32 > + "104rfsfsv446n4y52p5zw9h8mhgjyrbca8fpyhnxkkasq141a264")))) > + (build-system gnu-build-system) > + (inputs (list sdl sdl-mixer)) Nitpick: I moved inputs after arguments=E2=80=A6 out of habit. > + (arguments > + (list > + #:tests? #f ; no tests > + #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'fix-sdl-paths > + (lambda _ > + (let ((share (string-append #$output "/share"))) > + ;; fix name and append path to SDL_mixer.h Nitpick: I used proper capitalization and typography (missing final full stop). > + (substitute* "src/Makefile" > + (("GAME_NAME=3DalienBlaster") > + "GAME_NAME=3Dalienblaster") > + (("SDL_FLAGS=3D\\$\\(shell sdl-config --cflags\\)" lin= e) > + (string-append line " -I" #$sdl-mixer "/include/SDL")= )) I replace #$sdl-mixer with #$(this-package-inputs "sdl-mixer") for compatibility with package transformations. > + ;; substitute relative paths in .cfg and source/header f= iles Nitpick: Here too, I slightly reformatted the comment. > + (substitute* (find-files "./cfg") > + (("(\\./)?images") (string-append share "/images"))) > + (substitute* (list "src/global.h" "src/global.cc") > + (("./images") (string-append share "/images")) > + (("./sound") (string-append share "/sound")) > + (("./cfg") (string-append share "/cfg")))))) > + > + (delete 'configure) > + > + (replace 'install > + (lambda _ > + (let ((bin (string-append #$output "/bin"))) > + (install-file "alienblaster" bin) > + (for-each > + (lambda (dir) > + (copy-recursively dir (string-append #$output "/share= /" dir))) > + '("images" "sound" "cfg"))) > + #t))))) I removed the trailing #T, which is not necessary in new package style. Regards, --=20 Nicolas Goaziou From unknown Fri Jun 20 05:37:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 19 May 2023 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator