Subject: bug#62525: closed (Re: bug#62525: [PATCH] services: configuration: Fix garbage output in configuration->documentation.)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 30 Mar 2023 02:42:03 +0000

Your bug report

#62525: [PATCH] services: configuration: Fix garbage output in configuration->documentation.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
62525: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62525
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#62525: [PATCH] services: configuration: Fix garbage output in configuration->documentation.
From: Maxim Cournoyer <[email-masked]>
To: Bruno Victal <[email-masked]>
Cc: [email-masked]
Date: Wed, 29 Mar 2023 22:41:38 -0400
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

Bruno Victal <[email-masked]> writes:

> Fixes <https://issues.guix.gnu.org/57958>.
>
> * gnu/services/configuration.scm (define-configuration-helper): Remove call
> to display within default-value-thunk.
> ---
>  gnu/services/configuration.scm | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
> index 174c2f20d2..ed9d95f906 100644
> --- a/gnu/services/configuration.scm
> +++ b/gnu/services/configuration.scm
> @@ -264,7 +264,6 @@ (define (define-configuration-helper serialize? serializer-prefix syn)
>                        (serializer field-serializer)
>                        (default-value-thunk
>                          (lambda ()
> -                          (display '#,(id #'stem #'% #'stem))
>                            (if (maybe-value-set? (syntax->datum field-default))
>                                field-default
>                                (configuration-missing-default-value

This one also :-).

-- 
Thanks,
Maxim

Subject: [PATCH] services: configuration: Fix garbage output in configuration->documentation.
From: Bruno Victal <[email-masked]>
To: [email-masked]
Cc: Bruno Victal <[email-masked]>, [email-masked]
Date: Wed, 29 Mar 2023 17:06:10 +0100
List-Id: <debbugs-submit.debbugs.gnu.org>

Fixes <https://issues.guix.gnu.org/57958>.

* gnu/services/configuration.scm (define-configuration-helper): Remove call
to display within default-value-thunk.
---
 gnu/services/configuration.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 174c2f20d2..ed9d95f906 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -264,7 +264,6 @@ (define (define-configuration-helper serialize? serializer-prefix syn)
                       (serializer field-serializer)
                       (default-value-thunk
                         (lambda ()
-                          (display '#,(id #'stem #'% #'stem))
                           (if (maybe-value-set? (syntax->datum field-default))
                               field-default
                               (configuration-missing-default-value
-- 
2.39.1