GNU bug report logs - #62525
[PATCH] services: configuration: Fix garbage output in configuration->documentation.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 62525 in the body.
You can then email your comments to 62525 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>, maxim.cournoyer <at> gmail.com
Subject: [PATCH] services: configuration: Fix garbage output in
 configuration->documentation.
Date: Wed, 29 Mar 2023 17:06:10 +0100

Fixes <https://issues.guix.gnu.org/57958>.

* gnu/services/configuration.scm (define-configuration-helper): Remove call
to display within default-value-thunk.
---
 gnu/services/configuration.scm | 1 -
 1 file changed, 1 deletion(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 174c2f20d2..ed9d95f906 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -264,7 +264,6 @@ (define (define-configuration-helper serialize? serializer-prefix syn)
                       (serializer field-serializer)
                       (default-value-thunk
                         (lambda ()
-                          (display '#,(id #'stem #'% #'stem))
                           (if (maybe-value-set? (syntax->datum field-default))
                               field-default
                               (configuration-missing-default-value
-- 
2.39.1

Message #10 received at 62525-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 62525-done <at> debbugs.gnu.org
Subject: Re: bug#62525: [PATCH] services: configuration: Fix garbage output
 in configuration->documentation.
Date: Wed, 29 Mar 2023 22:41:38 -0400

Hello,

Bruno Victal <mirai <at> makinata.eu> writes:

> Fixes <https://issues.guix.gnu.org/57958>.
>
> * gnu/services/configuration.scm (define-configuration-helper): Remove call
> to display within default-value-thunk.
> ---
>  gnu/services/configuration.scm | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
> index 174c2f20d2..ed9d95f906 100644
> --- a/gnu/services/configuration.scm
> +++ b/gnu/services/configuration.scm
> @@ -264,7 +264,6 @@ (define (define-configuration-helper serialize? serializer-prefix syn)
>                        (serializer field-serializer)
>                        (default-value-thunk
>                          (lambda ()
> -                          (display '#,(id #'stem #'% #'stem))
>                            (if (maybe-value-set? (syntax->datum field-default))
>                                field-default
>                                (configuration-missing-default-value

This one also :-).

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.