From unknown Sat Aug 16 13:51:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62524: [PATCH] Support displaying all package maintainers Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Mar 2023 15:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 62524@debbugs.gnu.org Cc: philipk@posteo.net, monnier@iro.umontreal.ca X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168010396914614 (code B ref -1); Wed, 29 Mar 2023 15:33:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Mar 2023 15:32:49 +0000 Received: from localhost ([127.0.0.1]:54754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phXn7-0003ne-EZ for submit@debbugs.gnu.org; Wed, 29 Mar 2023 11:32:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:34366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phXn5-0003nV-IH for submit@debbugs.gnu.org; Wed, 29 Mar 2023 11:32:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phXmz-00036H-Rq for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 11:32:43 -0400 Received: from mail.hostpark.net ([212.243.197.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phXmx-0000Ji-N7 for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 11:32:41 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 23893164B4; Wed, 29 Mar 2023 17:32:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:from:from:received:received; s=sel2011a; t=1680103937; bh=n4PrNlVEqiW6moyq76XWZc7dFZZJWKOjKzLYgLnw1Lw=; b= yX9hmSJfoXTcaArF+0T7VDgMT6GLiE17cQSGI3sTXejoFMOTCuevNfe3MXgz8SrK h/e7xYr+OVbNVE3muUArqQbYKtW3Yo0xcMKPKl5aHKsBqlR3cCfKhtM65Jg6UwDX 4fJKSooMzdk+6CsLvdl+v5BgAtBoo8DoDBK4mDhWyD8= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id tw6DMU5TSqaP; Wed, 29 Mar 2023 17:32:17 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id BB6D5164DF; Wed, 29 Mar 2023 17:32:17 +0200 (CEST) From: Jonas Bernoulli Date: Wed, 29 Mar 2023 17:32:14 +0200 Message-Id: <20230329153214.752-1-jonas@bernoul.li> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) If the package's new `:maintainers' extra property is non-nil, then display all of the specified maintainers, if any, like we already do for `:authors'. If the value is nil, then fall back to the old `:maintainer' property. We cannot just allow the existing `:maintainer' property to be a list of maintainers, because that would break older versions of this function. We also cannot just ignore `:maintainer', because all ELPAs still have to be updated to include `:maintainers' in archive-contents. Even once all ELPAs have been updated to include `:maintainers', they have to continue to also include `:maintainer', for the benefit of older versions of this function / package.el / Emacs. To avoid this duplication, `package' would have to be distributed on GNU ELPA as a "core" package. * lisp/emacs-lisp/package.el (describe-package-1): Use new :maintainers package extra property from "archive-contents, if non-nil. --- lisp/emacs-lisp/package.el | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index f92afe56b76..487dfac252f 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2696,7 +2696,8 @@ describe-package-1 (status (if desc (package-desc-status desc) "orphan")) (incompatible-reason (package--incompatible-p desc)) (signed (if desc (package-desc-signed desc))) - (maintainer (cdr (assoc :maintainer extras))) + (maintainers (or (cdr (assoc :maintainers extras)) + (cdr (assoc :maintainer extras)))) (authors (cdr (assoc :authors extras))) (news (and-let* (pkg-dir ((not built-in)) @@ -2831,19 +2832,21 @@ describe-package-1 'action 'package-keyword-button-action) (insert " ")) (insert "\n")) - (when maintainer - (package--print-help-section "Maintainer") - (package--print-email-button maintainer)) - (when authors + (when maintainers + (unless (car-safe (car maintainers)) + (setq maintainers (list maintainers))) (package--print-help-section - (if (= (length authors) 1) - "Author" - "Authors")) - (package--print-email-button (pop authors)) - ;; If there's more than one author, indent the rest correctly. - (dolist (name authors) - (insert (make-string 13 ?\s)) - (package--print-email-button name))) + (if (cdr maintainers) "Maintainers" "Maintainer")) + (dolist (maintainer maintainers) + (when (bolp) + (insert (make-string 13 ?\s))) + (package--print-email-button maintainer))) + (when authors + (package--print-help-section (if (cdr authors) "Authors" "Author")) + (dolist (author authors) + (when (bolp) + (insert (make-string 13 ?\s))) + (package--print-email-button author))) (let* ((all-pkgs (append (cdr (assq name package-alist)) (cdr (assq name package-archive-contents)) (let ((bi (assq name package--builtins))) -- 2.39.2 From unknown Sat Aug 16 13:51:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62524: [PATCH] Support displaying all package maintainers Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Mar 2023 16:40:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 62524@debbugs.gnu.org Cc: philipk@posteo.net, monnier@iro.umontreal.ca X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.168010796021189 (code B ref -1); Wed, 29 Mar 2023 16:40:01 +0000 Received: (at submit) by debbugs.gnu.org; 29 Mar 2023 16:39:20 +0000 Received: from localhost ([127.0.0.1]:54842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phYpT-0005Vg-Sw for submit@debbugs.gnu.org; Wed, 29 Mar 2023 12:39:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:50200) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phYpS-0005VZ-29 for submit@debbugs.gnu.org; Wed, 29 Mar 2023 12:39:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phYpO-0006WZ-4j for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 12:39:15 -0400 Received: from mail.hostpark.net ([212.243.197.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phYpL-0003ZP-9o for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 12:39:13 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 288411625C; Wed, 29 Mar 2023 18:39:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1680107947; bh=ebyXkX3eBUoBSvE2dbN1tJY2 J8xIwr+OEATSe1VOQfE=; b=3LVb3aQ8T+VlpkDKbCKcLNs9dnTFsCOyhWJGXsth 9m9AL5An0i33fXwUDssf6M51pDo/hWBFWcIj1qb3fnv2OoW+HpyaGJ72rmPCN86o NFfiYxhkE7FRXHGbH3KjbtirMHZ+IfWwkY+prw8pf0tE3DRbTtw7mJBEBHnVQBtt 0Vw= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id YRb00CmEZcx0; Wed, 29 Mar 2023 18:39:07 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id CB69816289; Wed, 29 Mar 2023 18:39:07 +0200 (CEST) From: Jonas Bernoulli In-Reply-To: <20230329153214.752-1-jonas@bernoul.li> References: <20230329153214.752-1-jonas@bernoul.li> Date: Wed, 29 Mar 2023 18:39:05 +0200 Message-ID: <87y1nf4imu.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > + (unless (car-safe (car maintainers)) > + (setq maintainers (list maintainers))) s/car-safe/proper-list-p/ From unknown Sat Aug 16 13:51:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62524: Support displaying all package maintainers References: <20230329153214.752-1-jonas@bernoul.li> In-Reply-To: <20230329153214.752-1-jonas@bernoul.li> Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 05 Apr 2023 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 62524@debbugs.gnu.org Received: via spool by 62524-submit@debbugs.gnu.org id=B62524.168070625323014 (code B ref 62524); Wed, 05 Apr 2023 14:51:02 +0000 Received: (at 62524) by debbugs.gnu.org; 5 Apr 2023 14:50:53 +0000 Received: from localhost ([127.0.0.1]:52406 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk4TM-0005z5-Sp for submit@debbugs.gnu.org; Wed, 05 Apr 2023 10:50:53 -0400 Received: from mail.hostpark.net ([212.243.197.30]:41238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pk4TL-0005yi-6p for 62524@debbugs.gnu.org; Wed, 05 Apr 2023 10:50:52 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id E826B1636F for <62524@debbugs.gnu.org>; Wed, 5 Apr 2023 16:50:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :subject:subject:from:from:received:received; s=sel2011a; t= 1680706249; bh=vuh/5QdF0Ko6aYeGx5hK8W6Oi12a3saCBWInVqRxLYc=; b=P enE1qDjel39QsxJLfai2Zx+2p33Zj8YD5rcXdDOQH5mKhNcQr5EE6RbsMdo0DsCB AfkfKF2rx1Nt+2EzlHI0cyhEATb+j4A65UgQWC5Wm9EsMcci0px4qtZZnl6+9ASg E4d7NpLiwiUQIZB2YNklMQfO7oPNhC+uxdOCN7SRMU= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail1.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id wn_sAvtZcHxm for <62524@debbugs.gnu.org>; Wed, 5 Apr 2023 16:50:49 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id ADA981626C for <62524@debbugs.gnu.org>; Wed, 5 Apr 2023 16:50:49 +0200 (CEST) From: Jonas Bernoulli Date: Wed, 05 Apr 2023 16:50:49 +0200 Message-ID: <87edoyjsc6.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) [ I am re-sending this message because the MDS refused to deliver the previous iteration. Stefan, your reply contained a header "Cc: ??@debbugs.gnu.org". ] Stefan Monnier writes: >> Even once all ELPAs have been updated to include `:maintainers', they >> have to continue to also include `:maintainer', for the benefit of >> older versions of this function / package.el / Emacs. > > We could drop `:maintainer` within a few years, tho: this info is not > super-important and it would impact only users of older Emacsen. That's the plan. >> To avoid this duplication, `package' would have to be distributed on >> GNU ELPA as a "core" package. > > That still wouldn't help those users who didn't upgrade their built-in > `package.el`. I hope that we can eventually not only make Package available on GNU Elpa, but also get users of older Emacs releases to update to that version, see 87tty24ap2.fsf@bernoul.li > Other than that: OK with me. So should I go ahead and install this now (on master, I assume)? Once that is done, I'll update the elpa-admin equivalent for Melpa. I plan to only include :maintainers in archive-contents if there actually are multiple maintainers. That way there is less duplicated data, and I recommend you do the same in elpa-admin. Oh, and the comment you added to package-buffer-info in 4e6f98cd505ed56 is wrong; shall I just replace "single string" with "single cons-cell"? Cheers, Jonas From unknown Sat Aug 16 13:51:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62524: [PATCH] Support displaying all package maintainers Resent-From: Jonas Bernoulli Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Apr 2023 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Monnier Cc: philipk@posteo.net, 62524@debbugs.gnu.org Received: via spool by 62524-submit@debbugs.gnu.org id=B62524.168263061629945 (code B ref 62524); Thu, 27 Apr 2023 21:24:01 +0000 Received: (at 62524) by debbugs.gnu.org; 27 Apr 2023 21:23:36 +0000 Received: from localhost ([127.0.0.1]:59934 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps95U-0007mv-7X for submit@debbugs.gnu.org; Thu, 27 Apr 2023 17:23:36 -0400 Received: from mail.hostpark.net ([212.243.197.30]:39340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ps95P-0007mi-2v for 62524@debbugs.gnu.org; Thu, 27 Apr 2023 17:23:35 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 99C6F164BF; Thu, 27 Apr 2023 23:23:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-type:content-type:mime-version:message-id:date:date :references:in-reply-to:subject:subject:from:from:received :received; s=sel2011a; t=1682630609; bh=0H3kypxmKNg3nwY3+58sznJV UpzmABs7l/VrnP/vp88=; b=RuZAEmYhSGYiSBnKN8hBrdLdq4F0tj1h4fasA/wy jY+D0/mz0GjPV8fPGS27MpvDzZsflgSASy3VXP/6B1gCdakHqpcQuZgDYWEBqMez NXf/F+JBgeix34O8ASFFt7cO5tlGe2XbEaF+xTQUH7S1eDGcDw5Ort2H5GJ/bAAX yk0= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id MWJRncbhjJqt; Thu, 27 Apr 2023 23:23:29 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id 56964164A3; Thu, 27 Apr 2023 23:23:29 +0200 (CEST) From: Jonas Bernoulli In-Reply-To: References: <20230329153214.752-1-jonas@bernoul.li> <87o7o2jz5j.fsf@bernoul.li> Date: Thu, 27 Apr 2023 23:23:27 +0200 Message-ID: <87y1mdf29c.fsf@bernoul.li> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Monnier writes: > [ Sorry 'bout the delay. ] > >>> Other than that: OK with me. >> So should I go ahead and install this now (on master I assume)? > > Yes, please. No problem ;P I've just done that. Jonas From unknown Sat Aug 16 13:51:07 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62524: [PATCH] Support displaying all package maintainers Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 01 May 2023 02:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62524 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jonas Bernoulli Cc: philipk@posteo.net, 62524@debbugs.gnu.org Received: via spool by 62524-submit@debbugs.gnu.org id=B62524.168290707727845 (code B ref 62524); Mon, 01 May 2023 02:12:01 +0000 Received: (at 62524) by debbugs.gnu.org; 1 May 2023 02:11:17 +0000 Received: from localhost ([127.0.0.1]:38624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptJ0W-0007F3-P8 for submit@debbugs.gnu.org; Sun, 30 Apr 2023 22:11:16 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:22462) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ptJ0U-0007Ep-8I for 62524@debbugs.gnu.org; Sun, 30 Apr 2023 22:11:15 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 799B680991; Sun, 30 Apr 2023 22:11:08 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5B645805F3; Sun, 30 Apr 2023 22:11:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1682907067; bh=61u13BVM7DDfmZbm9qOK+EorwZZUV0vQ9/8euLgV6fY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=bqKEWzLUoV7JRLahcMUAmBwKi0qmZOcoOWfrBzTCqV8RZOtUvD8aA1NMBHNelQyvI GnrTZnkdQYp0fxFuRht11zFAJAu3PR2mA5OTnmsmV5Owg/LNF9OgeWJhmbLWVcZwJu dZyMywUIhElgRW2aVWD3n7hjEZ8gR31mtqh8TGFq9E7db96HIm5yEHQ1qd5V+4Qs8j j0JM+arOfYJ/FVqrw/bWqH20i4ynAHtEYRC8UEe1dZnZIH44BSx42p7ieVqwZdJRRR RSzr20xYXB59UmER8RjIgbDNOAJ+O3Dw/i0eM7E0nchkuRM5uS4TYNRMWy0T9XFwqJ A2Af2It83u9kw== Received: from pastel (unknown [45.72.217.176]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 3557D120433; Sun, 30 Apr 2023 22:11:07 -0400 (EDT) From: Stefan Monnier In-Reply-To: <87y1mdf29c.fsf@bernoul.li> (Jonas Bernoulli's message of "Thu, 27 Apr 2023 23:23:27 +0200") Message-ID: References: <20230329153214.752-1-jonas@bernoul.li> <87o7o2jz5j.fsf@bernoul.li> <87y1mdf29c.fsf@bernoul.li> Date: Sun, 30 Apr 2023 22:11:06 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL 0.113 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > I've just done that. Thanks, Jonas! Stefan From unknown Sat Aug 16 13:51:07 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Jonas Bernoulli Subject: bug#62524: closed (Re: bug#62524: [PATCH] Support displaying all package maintainers) Message-ID: References: <20230329153214.752-1-jonas@bernoul.li> X-Gnu-PR-Message: they-closed 62524 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 62524@debbugs.gnu.org Date: Fri, 01 Sep 2023 19:37:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1693597022-4512-1" This is a multi-part message in MIME format... ------------=_1693597022-4512-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #62524: [PATCH] Support displaying all package maintainers which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 62524@debbugs.gnu.org. --=20 62524: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62524 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1693597022-4512-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 62524-done) by debbugs.gnu.org; 1 Sep 2023 19:36:46 +0000 Received: from localhost ([127.0.0.1]:33985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc9wk-0001AF-6F for submit@debbugs.gnu.org; Fri, 01 Sep 2023 15:36:46 -0400 Received: from mail-lj1-x22d.google.com ([2a00:1450:4864:20::22d]:57854) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qc9wi-0001A2-Qq for 62524-done@debbugs.gnu.org; Fri, 01 Sep 2023 15:36:45 -0400 Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2bd0d135ca3so42364161fa.3 for <62524-done@debbugs.gnu.org>; Fri, 01 Sep 2023 12:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693596989; x=1694201789; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=TF/4otphnoDEDFHBlq3leeSY7I8dW6p+xyn1culdAdY=; b=oZqNTeOG3hhQ0s9tf/EV4IE5UCGihzHbhNBEHuYlCvumcRASFsEVZg8inC52LVKWpw kce/uiSu0x0JO+ea+VzDBQoLmUAJRkD11zXqKuI5HOciwwr19MzoOiSW1LF04LtlLS3I zit4ERRvAdD8k/Kg4fvefwZibM6XUzK971I0BiEcrxPwgh0vVzFgURIm+eETo+Q42cFq sIzXVQn2Pi0W9MjQYgVGxpnLXuonAOlAXqRxXl9loA7a2c/sN1dUZUsPRKiNWGZfUoAX cM/h1vyHsl6tSfLDVmhfCEe9OYqxsFOD5ZJ3N8+6Maa5uRKIC31tleIthpvHjzEFdr3n VMJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693596989; x=1694201789; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=TF/4otphnoDEDFHBlq3leeSY7I8dW6p+xyn1culdAdY=; b=jA2MHRcDj08tPZqvFvC4HnUSfEqbpMZM4K7CieFklMtDEs0X1ikZviJdcSgTkrsg8A EwF3rAM7khcKH6p6oRZIpgxVEwMaqiJl9OVHtCFdpEeaByu9N9FgC+1iBXseBCWNDI6T CfRe3wEjBeLMF7f12jacP6Fxs/oynZ1jfv9FeaX0+iDFC7/rI2ObQXqwGtgW7zsY0Cf0 CXieudX3aPVQ3yYQ0Mq5i/WTXcpi0JvdxjJorbymqAUMv37VEvgCPfkFHNDfIe7Ui4nx srAETLecu5QtmYhVd4+dpT/JUQQpAMpapmUI61nj0X1KI9GFNHVhkIm8jI/nsTVwOKlz WePw== X-Gm-Message-State: AOJu0YzRUzVXKIaN/7jjU69phNvf8GTgHMRxJybYIE5J+zEr8ls9Y7Sx WVsCvdrtrxs5WeRUJ2IwSfo8+ZzTf6v1n0W48qU= X-Google-Smtp-Source: AGHT+IFPNgOdhW5P9ndIIh5AO4Jj74/WjX4lBOW/6H901L4nFReQyYTsbqWnJb3bYseCufe0pj31rpb4d8L61ncE1Bc= X-Received: by 2002:a2e:8718:0:b0:2bc:eafa:cfaa with SMTP id m24-20020a2e8718000000b002bceafacfaamr2184763lji.53.1693596989161; Fri, 01 Sep 2023 12:36:29 -0700 (PDT) MIME-Version: 1.0 References: <20230329153214.752-1-jonas@bernoul.li> <87o7o2jz5j.fsf@bernoul.li> <87y1mdf29c.fsf@bernoul.li> In-Reply-To: From: Stefan Kangas Date: Fri, 1 Sep 2023 21:36:18 +0200 Message-ID: Subject: Re: bug#62524: [PATCH] Support displaying all package maintainers To: Stefan Monnier Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62524-done Cc: philipk@posteo.net, Jonas Bernoulli , 62524-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) This bug was accidentally left open, closing it now. ------------=_1693597022-4512-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 29 Mar 2023 15:32:49 +0000 Received: from localhost ([127.0.0.1]:54754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phXn7-0003ne-EZ for submit@debbugs.gnu.org; Wed, 29 Mar 2023 11:32:49 -0400 Received: from lists.gnu.org ([209.51.188.17]:34366) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phXn5-0003nV-IH for submit@debbugs.gnu.org; Wed, 29 Mar 2023 11:32:48 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phXmz-00036H-Rq for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 11:32:43 -0400 Received: from mail.hostpark.net ([212.243.197.30]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phXmx-0000Ji-N7 for bug-gnu-emacs@gnu.org; Wed, 29 Mar 2023 11:32:41 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.hostpark.net (Postfix) with ESMTP id 23893164B4; Wed, 29 Mar 2023 17:32:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h= content-transfer-encoding:mime-version:x-mailer:message-id:date :date:subject:subject:from:from:received:received; s=sel2011a; t=1680103937; bh=n4PrNlVEqiW6moyq76XWZc7dFZZJWKOjKzLYgLnw1Lw=; b= yX9hmSJfoXTcaArF+0T7VDgMT6GLiE17cQSGI3sTXejoFMOTCuevNfe3MXgz8SrK h/e7xYr+OVbNVE3muUArqQbYKtW3Yo0xcMKPKl5aHKsBqlR3cCfKhtM65Jg6UwDX 4fJKSooMzdk+6CsLvdl+v5BgAtBoo8DoDBK4mDhWyD8= X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net Received: from mail.hostpark.net ([127.0.0.1]) by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224) with ESMTP id tw6DMU5TSqaP; Wed, 29 Mar 2023 17:32:17 +0200 (CEST) Received: from customer (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.hostpark.net (Postfix) with ESMTPSA id BB6D5164DF; Wed, 29 Mar 2023 17:32:17 +0200 (CEST) From: Jonas Bernoulli To: bug-gnu-emacs@gnu.org Subject: [PATCH] Support displaying all package maintainers Date: Wed, 29 Mar 2023 17:32:14 +0200 Message-Id: <20230329153214.752-1-jonas@bernoul.li> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@bernoul.li; helo=mail.hostpark.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: philipk@posteo.net, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) If the package's new `:maintainers' extra property is non-nil, then display all of the specified maintainers, if any, like we already do for `:authors'. If the value is nil, then fall back to the old `:maintainer' property. We cannot just allow the existing `:maintainer' property to be a list of maintainers, because that would break older versions of this function. We also cannot just ignore `:maintainer', because all ELPAs still have to be updated to include `:maintainers' in archive-contents. Even once all ELPAs have been updated to include `:maintainers', they have to continue to also include `:maintainer', for the benefit of older versions of this function / package.el / Emacs. To avoid this duplication, `package' would have to be distributed on GNU ELPA as a "core" package. * lisp/emacs-lisp/package.el (describe-package-1): Use new :maintainers package extra property from "archive-contents, if non-nil. --- lisp/emacs-lisp/package.el | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index f92afe56b76..487dfac252f 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -2696,7 +2696,8 @@ describe-package-1 (status (if desc (package-desc-status desc) "orphan")) (incompatible-reason (package--incompatible-p desc)) (signed (if desc (package-desc-signed desc))) - (maintainer (cdr (assoc :maintainer extras))) + (maintainers (or (cdr (assoc :maintainers extras)) + (cdr (assoc :maintainer extras)))) (authors (cdr (assoc :authors extras))) (news (and-let* (pkg-dir ((not built-in)) @@ -2831,19 +2832,21 @@ describe-package-1 'action 'package-keyword-button-action) (insert " ")) (insert "\n")) - (when maintainer - (package--print-help-section "Maintainer") - (package--print-email-button maintainer)) - (when authors + (when maintainers + (unless (car-safe (car maintainers)) + (setq maintainers (list maintainers))) (package--print-help-section - (if (= (length authors) 1) - "Author" - "Authors")) - (package--print-email-button (pop authors)) - ;; If there's more than one author, indent the rest correctly. - (dolist (name authors) - (insert (make-string 13 ?\s)) - (package--print-email-button name))) + (if (cdr maintainers) "Maintainers" "Maintainer")) + (dolist (maintainer maintainers) + (when (bolp) + (insert (make-string 13 ?\s))) + (package--print-email-button maintainer))) + (when authors + (package--print-help-section (if (cdr authors) "Authors" "Author")) + (dolist (author authors) + (when (bolp) + (insert (make-string 13 ?\s))) + (package--print-email-button author))) (let* ((all-pkgs (append (cdr (assq name package-alist)) (cdr (assq name package-archive-contents)) (let ((bi (assq name package--builtins))) -- 2.39.2 ------------=_1693597022-4512-1--