From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 10:32:39 2023 Received: (at submit) by debbugs.gnu.org; 28 Mar 2023 14:32:40 +0000 Received: from localhost ([127.0.0.1]:50474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phANL-0002hb-LE for submit@debbugs.gnu.org; Tue, 28 Mar 2023 10:32:39 -0400 Received: from lists.gnu.org ([209.51.188.17]:57592) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phANK-0002hT-87 for submit@debbugs.gnu.org; Tue, 28 Mar 2023 10:32:38 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phANJ-0006IQ-D2 for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 10:32:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phANJ-0007i8-5U for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 10:32:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=MBN0vCel8QUOxOvZ1LWQPStWi7jK1hFiZJMCXoqKs2Y=; b=SUq60v6EaeBTW0 5DYErRcacjgG8/lF4CPGHjv5szr5SkhpvukGJSyTw2oamGYdNbk1uAbvOiYoNRbMBd22fLkUIMgSf bf+n6oKXip6ITDtJz9RdZn4jwTYT2G4CDq+t2xiHd8bdSdobCQUY/X7LPfHe6KnSx40Q90uiBERxg rRWOp2v8dTKkCXa0dJH9nWvW+C52yXUMDQBJUYRxmjMfY2OZOP6nzivWJ0X8I+/rs9gGIIEINAnEs fveQZgaa8m6qK6rOi/5uFimnzC6EAy9r9bn+VuUNzrnJ1wN+ZSbm7tdcVTgYTK0Pxs8v8CT06taz5 OpsQ4O+dMW5SgwC/HqkQ==; Received: from p5b326472.dip0.t-ipconnect.de ([91.50.100.114] helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phANI-0002GN-Am for bug-gnu-emacs@gnu.org; Tue, 28 Mar 2023 10:32:36 -0400 From: Arash Esbati To: emacs-bugs Subject: 29.0.60; Docstring of `read-char-choice' Date: Tue, 28 Mar 2023 16:32:21 +0200 Message-ID: <86tty52bgq.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi all, docstring of `read-char-choice' lacks any information about INHIBIT-KEYBOARD-QUIT: ,----[ C-h f read-char-choice RET ] | read-char-choice is a native-compiled Lisp function in =E2=80=98subr.el= =E2=80=99. |=20 | (read-char-choice PROMPT CHARS &optional INHIBIT-KEYBOARD-QUIT) |=20 | Read and return one of CHARS, prompting for PROMPT. | Any input that is not one of CHARS is ignored. |=20 | By default, the minibuffer is used to read the key | non-modally (see =E2=80=98read-char-from-minibuffer=E2=80=99). If | =E2=80=98read-char-choice-use-read-key=E2=80=99 is non-nil, the modal =E2= =80=98read-key=E2=80=99 | function is used instead (see =E2=80=98read-char-choice-with-read-key=E2= =80=99). |=20 | Probably introduced at or before Emacs version 24.1. |=20 `---- INHIBIT-KEYBOARD-QUIT is passed to `read-char-choice-with-read-key'; I'd say it is sufficient to say something like: If =E2=80=98read-char-choice-use-read-key=E2=80=99 is non-nil, the modal = =E2=80=98read-key=E2=80=99 function is used instead (see =E2=80=98read-char-choice-with-read-key=E2= =80=99) and the optional INHIBIT-KEYBOARD-QUIT is passed to it. Best, Arash From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 13:29:16 2023 Received: (at 62502) by debbugs.gnu.org; 28 Mar 2023 17:29:16 +0000 Received: from localhost ([127.0.0.1]:50649 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phD8F-0001YB-PB for submit@debbugs.gnu.org; Tue, 28 Mar 2023 13:29:16 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phD8E-0001Xv-Ay for 62502@debbugs.gnu.org; Tue, 28 Mar 2023 13:29:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phD89-000268-01 for 62502@debbugs.gnu.org; Tue, 28 Mar 2023 13:29:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=7CBXvq9FtlHbDJtcSvNcux+Nhz+VT6Yje6tqclk3aLM=; b=Ch6/WeMVEgACyhN4IJN/ DTQFw8gGpQtANGF+CxmFNLxj+RSXv62v7ynDHOXzSWvU7PimkL9hKkyoWTeVK0XEHp3HhWgx4pJ9c 9ddw/m1LJYrBOKrMeHLFEMtwGtQIqJN1/j5OPeASnaOOQ/YGz+D+nzuB7iTUvJD6cV08EZwboQDyi l2btRA6DleN6AJ45uonKze77mRr8OfTTdkJ0ptn9DRsouOufYD+GGBf15Yv5hSSH9s047EqvnF2Do FX0yDjlANm0qdSDVB7a7GQiH1hbedWPkF2HrGsYiCZPrwS7pZP/t7BVt7nId0nzj+Cq0xu/pQk5TZ A0sJWXkiUHoCng==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phD86-000326-Dw; Tue, 28 Mar 2023 13:29:07 -0400 Date: Tue, 28 Mar 2023 20:29:11 +0300 Message-Id: <83tty47pjs.fsf@gnu.org> From: Eli Zaretskii To: Arash Esbati In-Reply-To: <86tty52bgq.fsf@gnu.org> (message from Arash Esbati on Tue, 28 Mar 2023 16:32:21 +0200) Subject: Re: bug#62502: 29.0.60; Docstring of `read-char-choice' References: <86tty52bgq.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62502 Cc: 62502@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Arash Esbati > Date: Tue, 28 Mar 2023 16:32:21 +0200 > > docstring of `read-char-choice' lacks any information about > INHIBIT-KEYBOARD-QUIT: That's because by default that argument is ignored. > INHIBIT-KEYBOARD-QUIT is passed to `read-char-choice-with-read-key'; I'd > say it is sufficient to say something like: > > If ‘read-char-choice-use-read-key’ is non-nil, the modal ‘read-key’ > function is used instead (see ‘read-char-choice-with-read-key’) and > the optional INHIBIT-KEYBOARD-QUIT is passed to it. Is it really useful? I believe read-char-choice-with-read-key is kept for possible backward compatibility; new Lisp programs that want to use read-char-choice-with-read-key should just call it directly, and in its doc string this argument is documented. So I'm not sure we should do anything about this issue. From debbugs-submit-bounces@debbugs.gnu.org Tue Mar 28 14:34:10 2023 Received: (at 62502) by debbugs.gnu.org; 28 Mar 2023 18:34:10 +0000 Received: from localhost ([127.0.0.1]:50692 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phE93-0003Ll-TR for submit@debbugs.gnu.org; Tue, 28 Mar 2023 14:34:10 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58168) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phE90-0003LB-Nw for 62502@debbugs.gnu.org; Tue, 28 Mar 2023 14:34:07 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phE8t-0005tP-VC for 62502@debbugs.gnu.org; Tue, 28 Mar 2023 14:34:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=UvofefAqvWhQ8XhzOxP5MJa4P/QrHmE0FiP6JMRnMvc=; b=jGPrzTqveqSBuPIy4zOf umFxwo4FvSkS8ypJpiZpZyNVovqF5osurLgmoIf27OC5AnkZb9erXFePGmlLR+1q3Chk5QTvPyZU7 GamkSqO0ZUDSNBKr/30aETHm+BF5ltYfVfHVjy9bMhTi43RRsfZBHJ7O4szzha64Yd/zkI00u54LX 6NSNcWalYTHamFYyEBCfNcJzz4V1E9z1Ny9e34sTa0Jia4azyRJC0oQvNVakHe04oWGsyoG1UE9jd saIJJkmbddda1NNjDQ6WhD3Oj5eWs5reDOAiU/j+4qP8zK88sb8fQyTjbE+nLfmHqxle40YjaLDSP RS1oqMQDIKFDkA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phE8t-0000mm-1c; Tue, 28 Mar 2023 14:33:59 -0400 Date: Tue, 28 Mar 2023 21:34:04 +0300 Message-Id: <83sfdo7mjn.fsf@gnu.org> From: Eli Zaretskii To: arash@gnu.org In-Reply-To: <83tty47pjs.fsf@gnu.org> (message from Eli Zaretskii on Tue, 28 Mar 2023 20:29:11 +0300) Subject: Re: bug#62502: 29.0.60; Docstring of `read-char-choice' References: <86tty52bgq.fsf@gnu.org> <83tty47pjs.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62502 Cc: 62502@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 62502@debbugs.gnu.org > Date: Tue, 28 Mar 2023 20:29:11 +0300 > From: Eli Zaretskii > > > From: Arash Esbati > > Date: Tue, 28 Mar 2023 16:32:21 +0200 > > > > docstring of `read-char-choice' lacks any information about > > INHIBIT-KEYBOARD-QUIT: > > That's because by default that argument is ignored. > > > INHIBIT-KEYBOARD-QUIT is passed to `read-char-choice-with-read-key'; I'd > > say it is sufficient to say something like: > > > > If ‘read-char-choice-use-read-key’ is non-nil, the modal ‘read-key’ > > function is used instead (see ‘read-char-choice-with-read-key’) and > > the optional INHIBIT-KEYBOARD-QUIT is passed to it. > > Is it really useful? I believe read-char-choice-with-read-key is kept > for possible backward compatibility; new Lisp programs that want to > use read-char-choice-with-read-key should just call it directly, and > in its doc string this argument is documented. > > So I'm not sure we should do anything about this issue. Since the state of documentation of this and related functions/variables was unsatisfactory, I ended up fixing it, and as part of that also mentioned what happens with INHIBIT-KEYBOARD-QUIT. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 29 03:26:59 2023 Received: (at 62502-done) by debbugs.gnu.org; 29 Mar 2023 07:26:59 +0000 Received: from localhost ([127.0.0.1]:51193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phQCw-0002NN-MO for submit@debbugs.gnu.org; Wed, 29 Mar 2023 03:26:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:32922) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phQCv-0002N9-4T for 62502-done@debbugs.gnu.org; Wed, 29 Mar 2023 03:26:58 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phQCp-0001PY-I1 for 62502-done@debbugs.gnu.org; Wed, 29 Mar 2023 03:26:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=wbwkq9rNNu3woVig/YWanDcTp04b6n6ly3g2sBAUQTk=; b=BmJQ/ZiLkvqRro0J3C78 dQKT0nDBapvYtAkTmm5Bao3JITawKIG8VaD2mGkvW3xJlxLD2NHHgzRmtzkXfMPfsoL/vtTFtv0kH 9dw93TtncqXHrOiR61MIX/0oUKz/v9yl7CEJiPXDm8laXmPMbsrT1XfHGnIceiIVElqRmWXsAQq5r exCDe27rlthAP8za5OZFIC4WNaf5L3jZIHf/ulF7ROXlf6drkdmGubtLIFVle0vXEWio6x7jq5boA f5O6AAO5GkKownbFyTvCpurm71eUtzrGxEui3L1+VmELdb44OYeenEm4UDMulODX2c6M+TQTBd62O XLCZxCZOWwDoxg==; Received: from p5b326472.dip0.t-ipconnect.de ([91.50.100.114] helo=MUTANT) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phQCp-00027E-0I; Wed, 29 Mar 2023 03:26:51 -0400 From: Arash Esbati To: Eli Zaretskii Subject: Re: bug#62502: 29.0.60; Docstring of `read-char-choice' In-Reply-To: <83sfdo7mjn.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Mar 2023 21:34:04 +0300") References: <86tty52bgq.fsf@gnu.org> <83tty47pjs.fsf@gnu.org> <83sfdo7mjn.fsf@gnu.org> Date: Wed, 29 Mar 2023 09:26:36 +0200 Message-ID: <86355of26r.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62502-done Cc: 62502-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > Since the state of documentation of this and related > functions/variables was unsatisfactory, I ended up fixing it, and as > part of that also mentioned what happens with INHIBIT-KEYBOARD-QUIT. Yes, the documentation is in much better shape now. Thanks for fixing this. I'm closing this report. Best, Arash From unknown Fri Aug 15 17:24:24 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 26 Apr 2023 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator