GNU bug report logs - #62488
[PATCH] Update emacs-lemon

Previous Next

Full log

View this message in rfc822 format

From: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: "62488 <at> debbugs.gnu.org" <62488 <at> debbugs.gnu.org>
Subject: [bug#62488] [PATCH] Update emacs-lemon
Date: Wed, 29 Mar 2023 00:06:41 +0000

[Message part 1 (text/plain, inline)]

Hello,

Here is two requested updates to the patch

Kind regards,
Baptiste

________________________________
From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Sent: Monday, March 27, 2023 5:23 PM
To: Baptiste Strazzulla <bstrazzull <at> hotmail.fr>
Cc: 62488 <at> debbugs.gnu.org <62488 <at> debbugs.gnu.org>
Subject: Re: [bug#62488] [PATCH] Update emacs-lemon

Hello,

Baptiste Strazzulla <bstrazzull <at> hotmail.fr> writes:

> * gnu/packages/emacs-xyz.scm (emacs-lemon-version): Update to 2.1.0

Thank you.

>  (define-public emacs-lemon
> -  (let ((commit "37a6e6d6ef0900ca19c820a2dbc122c7fe6d86cf")
> +  (let ((commit "b10e992a25757a91723c7d554a5fa8e14291e702")
>          (revision "0"))
>      (package
>        (name "emacs-lemon")
> -      (version (git-version "2.0.0" revision commit))
> +      (version (git-version "2.1.0" revision commit))

Since the commit matches the version bump, you can drop the `revision'
binding and `git-version' call. Version is simply "2.1.0". Could you
send an updated patch?

I noticed the package contains some tests. Would you try to run them, in
a subsequent patch?

Regards,
--
Nicolas Goaziou

[Message part 2 (text/html, inline)]

[0001-gnu-emacs-lemon-Update-to-2.1.0.patch (application/octet-stream, attachment)]

[0002-gnu-emacs-lemon-Add-tests.patch (application/octet-stream, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.