GNU bug report logs - #62463
[PATCH] services: fstrim: Fix schedule ungexp.

Previous Next

Package: guix-patches;

Reported by: Bruno Victal <mirai <at> makinata.eu>

Date: Sun, 26 Mar 2023 15:19:02 UTC

Severity: normal

Tags: patch

Done: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH] services: fstrim: Fix schedule ungexp.
Date: Sun, 26 Mar 2023 16:17:22 +0100
Previously, only the first level of the list would be quoted,
resulting in a schedule of the sort:
'(next-second (range 0 60 30))
being incorrectly ungexp'd into:
(list next-second (0 30))

* gnu/services/linux.scm (fstrim-mcron-job): Fix schedule ungexp.
---
 gnu/services/linux.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/services/linux.scm b/gnu/services/linux.scm
index d085b375a2..439848919d 100644
--- a/gnu/services/linux.scm
+++ b/gnu/services/linux.scm
@@ -234,7 +234,7 @@ (define (fstrim-mcron-job config)
        ;; lists are ungexp'd correctly since @var{schedule}
        ;; can be either a procedure, a string or a list.
        #$(if (list? schedule)
-             `(list ,@schedule)
+             #~'(#$@schedule)
              schedule)
        (lambda ()
          (system* #$(file-append package "/sbin/fstrim")
-- 
2.39.1





This bug report was last modified 2 years and 110 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.