GNU bug report logs - #6246
24.0.50; Circular dependencies in lib-src/Makefile.in

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 6246 in the body.
You can then email your comments to 6246 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 24.0.50; Circular dependencies in lib-src/Makefile.in
Date: Sat, 22 May 2010 03:54:57 -0400

Building Emacs outside of the source tree triggers the following
warnings from Make:

  make[2]: Circular /home/e/eliz/bzr/emacs/trunk/lib-src/rcs2log <- /home/e/eliz/bzr/emacs/trunk/lib-src/rcs2log dependency dropped.
  make[2]: Circular /home/e/eliz/bzr/emacs/trunk/lib-src/vcdiff <- /home/e/eliz/bzr/emacs/trunk/lib-src/vcdiff dependency dropped.
  make[2]: Circular /home/e/eliz/bzr/emacs/trunk/lib-src/rcs-checkin <- /home/e/eliz/bzr/emacs/trunk/lib-src/rcs-checkin dependency dropped.
  make[2]: Circular /home/e/eliz/bzr/emacs/trunk/lib-src/grep-changelog <- /home/e/eliz/bzr/emacs/trunk/lib-src/grep-changelog dependency dropped.

I think the problem is that we have both VPATH and an explicit
dependency for these files in lib-src/Makefile.in.


In GNU Emacs 24.0.50.1 (x86_64-unknown-linux-gnu, GTK+ Version 2.12.9)
 of 2010-05-22 on fencepost
configured using `configure  '--with-jpeg=no' '--with-png=no' '--with-gif=no' '--with-tiff=no''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: nil
  value of $XMODIFIERS: nil
  locale-coding-system: nil
  default enable-multibyte-characters: t

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
ESC [ > 0 ; 1 3 6 ; 0 c C-x C-f b u TAB t r TAB DEL 
y TAB RET C-s c i r c u C-a C-@ ESC O B ESC O B ESC 
O B ESC O B ESC O B ESC O B ESC O B ESC O B ESC w C-x 
b RET ESC x r e p o r t - e m TAB RET

Recent messages:
("./build/src/emacs")
For information about GNU Emacs and the GNU system, type C-h C-a.
Loading vc-bzr...done
Mark saved where search started
Mark set

Load-path shadows:
None found.

Features:
(shadow sort gnus-util mail-extr message sendmail regexp-opt rfc822 mml
easymenu mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231
rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils
gmm-utils mailheader emacsbug multi-isearch vc-bzr sha1 hex-util tooltip
ediff-hook vc-hooks lisp-float-type mwheel x-win x-dnd tool-bar dnd
fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer
select scroll-bar mldrag mouse jit-lock font-lock syntax facemenu
font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan
thai tai-viet lao korean japanese hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese case-table epa-hook
jka-cmpr-hook help simple abbrev loaddefs button minibuffer faces
cus-face files text-properties overlay md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote
make-network-process dynamic-setting font-render-setting gtk x-toolkit x
multi-tty emacs)

Message #10 received at 6246-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 6246-done <at> debbugs.gnu.org
Subject: Re: bug#6246: 24.0.50; Circular dependencies in lib-src/Makefile.in
Date: Sat, 22 May 2010 14:05:09 +0200

2010-05-22 09:54, Eli Zaretskii skrev:
> Building Emacs outside of the source tree triggers the following
> warnings from Make:
>
>    make[2]: Circular /home/e/eliz/bzr/emacs/trunk/lib-src/rcs2log<- /home/e/eliz/bzr/emacs/trunk/lib-src/rcs2log dependency dropped.
>    make[2]: Circular /home/e/eliz/bzr/emacs/trunk/lib-src/vcdiff<- /home/e/eliz/bzr/emacs/trunk/lib-src/vcdiff dependency dropped.
>    make[2]: Circular /home/e/eliz/bzr/emacs/trunk/lib-src/rcs-checkin<- /home/e/eliz/bzr/emacs/trunk/lib-src/rcs-checkin dependency dropped.
>    make[2]: Circular /home/e/eliz/bzr/emacs/trunk/lib-src/grep-changelog<- /home/e/eliz/bzr/emacs/trunk/lib-src/grep-changelog dependency dropped.
>
> I think the problem is that we have both VPATH and an explicit
> dependency for these files in lib-src/Makefile.in.
>
>

I seen this but ignored it. These scripts doesn't seem to be very important, I 
never had any problems running an uninstalled emacs without them.  I don't use 
RCS, vcdiff seems to be used only for SCCS, and I didn't find any usage of 
grep-changelog.

I have checked in a fix.

	Jan D.

Message #11 received at 6246-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Jan Djärv <jan.h.d <at> swipnet.se>
Cc: 6246-done <at> debbugs.gnu.org
Subject: Re: bug#6246: 24.0.50; Circular dependencies in lib-src/Makefile.in
Date: Sat, 22 May 2010 15:53:10 +0300

> Date: Sat, 22 May 2010 14:05:09 +0200
> From: Jan Djärv <jan.h.d <at> swipnet.se>
> CC: 6246-done <at> debbugs.gnu.org
> 
> I have checked in a fix.

Thanks.  But the fix uses "cp -p", which I think is not portable.

Message #12 received at 6246-done <at> debbugs.gnu.org (full text, mbox):

From: Jan Djärv <jan.h.d <at> swipnet.se>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 6246-done <at> debbugs.gnu.org
Subject: Re: bug#6246: 24.0.50; Circular dependencies in lib-src/Makefile.in
Date: Sat, 22 May 2010 15:26:44 +0200

Eli Zaretskii skrev 2010-05-22 14.53:
>> Date: Sat, 22 May 2010 14:05:09 +0200
>> From: Jan Djärv<jan.h.d <at> swipnet.se>
>> CC: 6246-done <at> debbugs.gnu.org
>>
>> I have checked in a fix.
>
> Thanks.  But the fix uses "cp -p", which I think is not portable.

No, cp -p was there before, those lines are unchanged:

bzr diff -r100411 Makefile.in
=== modified file 'lib-src/Makefile.in'
--- lib-src/Makefile.in	2010-05-15 01:05:11 +0000
+++ lib-src/Makefile.in	2010-05-22 13:12:23 +0000
...
-rcs2log: $(srcdir)/rcs2log
+stamp-rcs2log: $(srcdir)/rcs2log
 	-cp -p $(srcdir)/rcs2log rcs2log
+	touch $@

-rcs-checkin: $(srcdir)/rcs-checkin
+stamp-rcs-checkin: $(srcdir)/rcs-checkin
 	-cp -p $(srcdir)/rcs-checkin rcs-checkin
+	touch $@

-grep-changelog: $(srcdir)/grep-changelog
+stamp-grep-changelog: $(srcdir)/grep-changelog
 	-cp -p $(srcdir)/grep-changelog grep-changelog
+	touch $@

-vcdiff: $(srcdir)/vcdiff
+stamp-vcdiff: $(srcdir)/vcdiff
 	-cp -p $(srcdir)/vcdiff vcdiff
+	touch $@


cp -p was introduced in 2003:

2003-01-20  Richard M. Stallman  <rms <at> gnu.org>

        * Makefile.in (rcs2log, rcs-checkin, grep-changelog, vcdiff):
        New targets.

	Jan D.

	Jan D.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.