From unknown Sat Aug 09 13:08:16 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62453 <62453@debbugs.gnu.org> To: bug#62453 <62453@debbugs.gnu.org> Subject: Status: 30.0.50; Semicolon in view-lossage yields wrong alignment Reply-To: bug#62453 <62453@debbugs.gnu.org> Date: Sat, 09 Aug 2025 20:08:16 +0000 retitle 62453 30.0.50; Semicolon in view-lossage yields wrong alignment reassign 62453 emacs submitter 62453 Eshel Yaron severity 62453 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 01:33:29 2023 Received: (at submit) by debbugs.gnu.org; 26 Mar 2023 05:33:29 +0000 Received: from localhost ([127.0.0.1]:43868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgJ0S-0001cj-Vq for submit@debbugs.gnu.org; Sun, 26 Mar 2023 01:33:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:60374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgJ0Q-0001cb-F2 for submit@debbugs.gnu.org; Sun, 26 Mar 2023 01:33:26 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgJ0Q-00051u-5J for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 01:33:26 -0400 Received: from mail.eshelyaron.com ([107.175.124.16] helo=eshelyaron.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgJ0N-0003WT-R1 for bug-gnu-emacs@gnu.org; Sun, 26 Mar 2023 01:33:25 -0400 From: Eshel Yaron DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1679808802; bh=kuYFDSQ40ZlOkMuW9tlDOa+ohn1P7kddTH8/qGMo/UY=; h=From:To:Subject:Date:From; b=pZckc/jdkPA0bBoUUkZXx1myOL66kC95SBSr6i7iHz4MjAT59L3DnZ4GvT9c6/s3z PL9CKFkVJEif0rJd+fKk1uDWJnTPDjcSCJL3tHhLY9wrZe8I5DC+0R8KbvP2EgoAWO yCRXQelsfeW3uZIu5PUMxL/HkS461VUO/AUtHThWVSaScowkS5myacgPDXouQFCXYa PlvYoCrYNCxe9GfWyo9LjEptZvnTUgiq8qgL32BNN+S4HorSEUdS0W12XHofT1wCE7 zdOt6j70uQuCn0dvkJtE7b5qxHhV+8jfAZXCA4DABsQVhSD3rbQZFA5vU4o+LTNazB pIvMYtM96o2ug== To: bug-gnu-emacs@gnu.org Subject: 30.0.50; Semicolon in view-lossage yields wrong alignment Date: Sun, 26 Mar 2023 08:33:18 +0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=107.175.124.16; envelope-from=me@eshelyaron.com; helo=eshelyaron.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) It seems like key sequences that end with a semicolon hinder the alignment in the `view-lossage` output buffer. This is a regression with respect to the (IMO correct) behavior in Emacs 27. With Emacs from master: 1. emacs -Q 2. type C-; 3. type ; 4. type C-h l 5. The *Help* buffer now shows: C- ; ;; nil ; ;; self-insert-command C-h l ;; view-lossage Note that all three lines are formatted incorrectly compared to what we get with Emacs 27: C-; ;; nil ; ;; self-insert-command C-h l ;; view-lossage Thanks, Eshel In GNU Emacs 30.0.50 (build 29, x86_64-apple-darwin22.3.0, NS appkit-2299.40 Version 13.2.1 (Build 22D68)) of 2023-03-25 built on esmac Repository revision: db7e95531ac36ae842787b6c5f2859d0642c78cc Repository branch: master Windowing system distributor 'Apple', version 10.3.2299 System Description: macOS 13.2.1 Configured using: 'configure CFLAGS=-O3 --with-native-compilation --with-json --with-tree-sitter' Configured features: ACL DBUS GIF GLIB GMP GNUTLS JPEG JSON LCMS2 LIBXML2 MODULES NATIVE_COMP NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TIFF TOOLKIT_SCROLL_BARS TREE_SITTER WEBP XIM ZLIB Important settings: value of $LC_CTYPE: UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils time-date cl-loaddefs comp comp-cstr warnings icons subr-x rx cl-seq cl-macs gv cl-extra help-mode bytecomp byte-compile cl-lib rmc iso-transl tooltip cconv eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs theme-loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue cocoa ns lcms2 multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 78358 8406) (symbols 48 7093 0) (strings 32 19420 1908) (string-bytes 1 594120) (vectors 16 15982) (vector-slots 8 279688 11110) (floats 8 30 46) (intervals 56 223 0) (buffers 984 12)) From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 05:24:08 2023 Received: (at 62453) by debbugs.gnu.org; 26 Mar 2023 09:24:08 +0000 Received: from localhost ([127.0.0.1]:44061 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgMbg-0007y4-3X for submit@debbugs.gnu.org; Sun, 26 Mar 2023 05:24:08 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51644) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgMbd-0007xX-Co for 62453@debbugs.gnu.org; Sun, 26 Mar 2023 05:24:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgMbX-0006bA-Q4; Sun, 26 Mar 2023 05:23:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=1dk+w4pdFAwQSglDhGYdnUQIYNgExT2AanL0NLahDBY=; b=cBjYuHeyO8iw HZwWzhQy1Ie+TvUMOvpmqWo9a9XvWjyTi2TDJZF1PXCajE7CoA5FMij2DilFgMvexUTe4/dC/E2Tm WoXlD20455VdjXYLObaq0eH77MFfxWLfbD/2OuoVG2D38yZz+7RhjPWXVwrhHeONXTF7ByfvSk+sX Ptn59K1wmeIL1DfyoKGjJLjHgKDjNxDhr+15xWDPsy0z+PH+WDB5ZYDfdJQCWFiQPpaT0Hx7ZOMGe LW+o8U8vzZUMTcQRcCxv4Rg+Ixlj7W1zrAMecCP+tC/zBLIgsVs6BweZVbh3klXIBGAcF2JWw6gCq IGaSVo4WtcHj/QsVA9I/ng==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgMbV-0000cF-3e; Sun, 26 Mar 2023 05:23:59 -0400 Date: Sun, 26 Mar 2023 12:23:56 +0300 Message-Id: <83wn33ams3.fsf@gnu.org> From: Eli Zaretskii To: Eshel Yaron , Stefan Monnier In-Reply-To: (bug-gnu-emacs@gnu.org) Subject: Re: bug#62453: 30.0.50; Semicolon in view-lossage yields wrong alignment References: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62453 Cc: 62453@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 26 Mar 2023 08:33:18 +0300 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > > It seems like key sequences that end with a semicolon hinder the > alignment in the `view-lossage` output buffer. This is a regression > with respect to the (IMO correct) behavior in Emacs 27. > > With Emacs from master: > 1. emacs -Q > 2. type C-; > 3. type ; > 4. type C-h l > 5. The *Help* buffer now shows: > > C- ; ;; nil > ; ;; self-insert-command > C-h l ;; view-lossage > > Note that all three lines are formatted incorrectly compared to what we > get with Emacs 27: > > C-; ;; nil > ; ;; self-insert-command > C-h l ;; view-lossage Does the patch below give good results? Stefan, any better ideas? It looks like relying on comment-indent is quite fragile here, as keys can include a semi-colon, which will be interpreted as beginning a comment in too many places. I wonder whether the two extra bindings I add below really plug all the holes. diff --git a/lisp/help.el b/lisp/help.el index 3e94b50..13e61c0 100644 --- a/lisp/help.el +++ b/lisp/help.el @@ -689,6 +689,10 @@ view-lossage (with-current-buffer standard-output (goto-char (point-min)) (let ((comment-start ";; ") + ;; Prevent 'comment-indent' from handling a single + ;; semicolon as the beginning of a comment. + (comment-start-skip ";; ") + (comment-use-syntax nil) (comment-column 24)) (while (not (eobp)) (comment-indent) From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 05:39:20 2023 Received: (at 62453) by debbugs.gnu.org; 26 Mar 2023 09:39:20 +0000 Received: from localhost ([127.0.0.1]:44074 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgMqN-0008Ln-JZ for submit@debbugs.gnu.org; Sun, 26 Mar 2023 05:39:19 -0400 Received: from mail.eshelyaron.com ([107.175.124.16]:40478 helo=eshelyaron.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgMqL-0008Lf-OT for 62453@debbugs.gnu.org; Sun, 26 Mar 2023 05:39:18 -0400 From: Eshel Yaron DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=eshelyaron.com; s=mail; t=1679823557; bh=DL0NtvPySUHCsrkSxM/iMd2ehe2Yq4ytW9iqn+cIopg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=tNAM8CmsZ2Jtwl/0cekQUlk5frdoPkL8ojl5mkItp0Z04e9y8sKqdmi5YkrDVQtBh QSHYE1+25V2uarmJvIyifYJmAnaGo6E1LVSmm2fkFPbyGAkJRERWQvWuZ2HrP+Qd2m DlzJi4U4M2HP6G0gNZe6ak/9Ppp+mF9tO9JCwMu9FPsKyE+dQXx1bRKI6I3cHnMoVW D+wJ3IgCX5ZoqWEVaEZq41yWkpFGBFiMXjb4PwY5UdTBY2MB/yGL4LXAKcKLJYw8AZ ImwlbPLeMamza4HE01pY+K6JHGtVpdkGHUYZMOrkeC0hRA4uChMV8mI0F78YvU6+0z O2YfrWO7mYWYQ== To: Eli Zaretskii Subject: Re: bug#62453: 30.0.50; Semicolon in view-lossage yields wrong alignment In-Reply-To: <83wn33ams3.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Mar 2023 12:23:56 +0300") References: <83wn33ams3.fsf@gnu.org> Date: Sun, 26 Mar 2023 12:39:13 +0300 Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 62453 Cc: Stefan Monnier , 62453@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Date: Sun, 26 Mar 2023 08:33:18 +0300 >> From: Eshel Yaron via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> It seems like key sequences that end with a semicolon hinder the >> alignment in the `view-lossage` output buffer. This is a regression >> with respect to the (IMO correct) behavior in Emacs 27. >> >> [...] > > Does the patch below give good results? Thanks, that works well AFAICT from a few experiments. > Stefan, any better ideas? It looks like relying on comment-indent is > quite fragile here, as keys can include a semi-colon, which will be > interpreted as beginning a comment in too many places. I wonder > whether the two extra bindings I add below really plug all the holes. > > diff --git a/lisp/help.el b/lisp/help.el > index 3e94b50..13e61c0 100644 > --- a/lisp/help.el > +++ b/lisp/help.el > @@ -689,6 +689,10 @@ view-lossage > (with-current-buffer standard-output > (goto-char (point-min)) > (let ((comment-start ";; ") > + ;; Prevent 'comment-indent' from handling a single > + ;; semicolon as the beginning of a comment. > + (comment-start-skip ";; ") > + (comment-use-syntax nil) > (comment-column 24)) > (while (not (eobp)) > (comment-indent) From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 11:11:17 2023 Received: (at 62453) by debbugs.gnu.org; 26 Mar 2023 15:11:17 +0000 Received: from localhost ([127.0.0.1]:45693 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgS1d-0006Ex-Ef for submit@debbugs.gnu.org; Sun, 26 Mar 2023 11:11:17 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:33193) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgS1b-0006Ej-AV for 62453@debbugs.gnu.org; Sun, 26 Mar 2023 11:11:15 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id A31B580D1A; Sun, 26 Mar 2023 11:11:09 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 462ED80C97; Sun, 26 Mar 2023 11:11:08 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1679843468; bh=tavPJLUyPniTkESYN9bDr9nbbqL76CWkCj+r3TnufaY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=KX18mLduXeTxbYxYvbSPYvsa695sqhb27Zmh/ovL+QEzftEsoxk+p5qB2RvcaZXrB /W1bl79pZywQZtinTGpSgfaKNQfl3R08DWIXQXq2ADazgqQLkFRQcUd+Cd/pNPzzNb tHs2SXfiPBWkVTWrPDrMNJV/LJ+YobjoGFsWyAqGUILE48B0JanzAV267yYvAYXg3g hURaOAKLPzJFcfvPzCgraEKc1UqqMMJgxIzsgBQ2yHaV1iL445CCGCZex/H5Kn03mP 7xVgT71NDhmWo4ur25x5XGZAC49fVokgWaHGRj3S9D3z61deJy4+D8udrslTH20urL HudmMrY3OlxHg== Received: from pastel (unknown [216.154.34.24]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id E3F501232AE; Sun, 26 Mar 2023 11:11:07 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#62453: 30.0.50; Semicolon in view-lossage yields wrong alignment In-Reply-To: <83wn33ams3.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Mar 2023 12:23:56 +0300") Message-ID: References: <83wn33ams3.fsf@gnu.org> Date: Sun, 26 Mar 2023 11:11:06 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.023 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62453 Cc: Eshel Yaron , 62453@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Stefan, any better ideas? It looks like relying on comment-indent is > quite fragile here, Agreed. > as keys can include a semi-colon, which will be > interpreted as beginning a comment in too many places. I wonder > whether the two extra bindings I add below really plug all the holes. Here's another problem: C-x 5 2 ;; make-frame-command ;; handle-switch-frame ;; handle-switch-frame ;; handle-switch-frame ;; handle-switch-frame ;; handle-switch-frame ;; handle-switch-frame ;; handle-switch-frame ;; handle-switch-frame C- ; ;; nil ; ;; self-insert-command C-h l ;; view-lossage I'm not sure why there's no `switch-frame` event but it absence leads to incorrectly indenting the `;; handle-switch-frame`. We're probably better off indenting "by hand". Stefan From debbugs-submit-bounces@debbugs.gnu.org Sun Mar 26 11:27:49 2023 Received: (at 62453) by debbugs.gnu.org; 26 Mar 2023 15:27:49 +0000 Received: from localhost ([127.0.0.1]:45713 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgSHd-0006eb-BB for submit@debbugs.gnu.org; Sun, 26 Mar 2023 11:27:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgSHb-0006eL-6l for 62453@debbugs.gnu.org; Sun, 26 Mar 2023 11:27:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgSHU-0001FU-Rh; Sun, 26 Mar 2023 11:27:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=0UE1jJcv+F5YT1HMO0+qfS+dP+ZiH/Orhn7iMjLZNCg=; b=KJHyB9uSWUCd az2MPN+ZV18WoAmT2zmCc/386Y+b1iSvGLHBnKd4H36B8qlvLUVQbIRPFe815I6i2Kl8M3BFFaT4b vNH379QaBfCtenv1TtA5ZmA8JypQOabkJeUvBtZJTdYmlteEnctlPYtsIImPyUaGpuFFfw1IP6i5D 5LT2Vcnr3V1HARsnfHbSjZLV1ytcSvHpvkp+TgTntIP+sqGkvVe5H6pjpz4mfPVwHJayDs7+e86T2 Xb3SYIRyNvtRCbT9PM528CuY9q7kv9xxPHWAK7vF2cTVk3wkNwHS4SON2d0AartoQKab2toLbAUDN USP8L94/LPP5UeMHJVB+TQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgSHU-0007FA-8C; Sun, 26 Mar 2023 11:27:40 -0400 Date: Sun, 26 Mar 2023 18:27:40 +0300 Message-Id: <83jzz3a5xv.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 26 Mar 2023 11:11:06 -0400) Subject: Re: bug#62453: 30.0.50; Semicolon in view-lossage yields wrong alignment References: <83wn33ams3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62453 Cc: me@eshelyaron.com, 62453@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eshel Yaron , 62453@debbugs.gnu.org > Date: Sun, 26 Mar 2023 11:11:06 -0400 > > We're probably better off indenting "by hand". That'd be my conclusion as well. But that's definitely not for the release branch. Come to think of that, why not use the :align-to display spec to align the command descriptions? From debbugs-submit-bounces@debbugs.gnu.org Mon Mar 27 03:08:19 2023 Received: (at 62453) by debbugs.gnu.org; 27 Mar 2023 07:08:19 +0000 Received: from localhost ([127.0.0.1]:46357 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pggxn-0000uL-DD for submit@debbugs.gnu.org; Mon, 27 Mar 2023 03:08:19 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:34339) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pggxl-0000u4-T2 for 62453@debbugs.gnu.org; Mon, 27 Mar 2023 03:08:18 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6922D6000B; Mon, 27 Mar 2023 07:08:09 +0000 (UTC) From: Juri Linkov To: Eli Zaretskii Subject: Re: bug#62453: 30.0.50; Semicolon in view-lossage yields wrong alignment In-Reply-To: <83jzz3a5xv.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Mar 2023 18:27:40 +0300") Organization: LINKOV.NET References: <83wn33ams3.fsf@gnu.org> <83jzz3a5xv.fsf@gnu.org> Date: Mon, 27 Mar 2023 10:00:56 +0300 Message-ID: <86jzz2he53.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 62453 Cc: me@eshelyaron.com, Stefan Monnier , 62453@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> We're probably better off indenting "by hand". > > That'd be my conclusion as well. But that's definitely not for the > release branch. > > Come to think of that, why not use the :align-to display spec to align > the command descriptions? This format was intended to be compatible with `edit-kbd-macro`, and it uses such logic in `edmacro-format-keys` for alignment: (make-string (max (- 3 (/ (length desc) 8)) 1) 9) ";; " (if (stringp bind) bind (symbol-name bind)) From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 29 07:58:42 2023 Received: (at 62453) by debbugs.gnu.org; 29 Mar 2023 11:58:42 +0000 Received: from localhost ([127.0.0.1]:51429 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phURu-0003XE-Ch for submit@debbugs.gnu.org; Wed, 29 Mar 2023 07:58:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phURs-0003Wz-Db for 62453@debbugs.gnu.org; Wed, 29 Mar 2023 07:58:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phURm-0001Nk-MA; Wed, 29 Mar 2023 07:58:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=syWfD45witiwPNg67R363fUHR+YY3UXRztZKmDui4hU=; b=Eo8E/uEnJTCD mA8+2Aavbl/81rcnXP3I5osgcBSdMMcCWXfMTN6VEJKH+JdjYf/KBsEAgr5qN3Cua0xFQZrfXcpb4 lLuVKxYTbnfzHQqMYgYcpOV2f60yGW/QZFvW+VXgR0dqtssgTgwEe2LRdMoRXPoMJcdLhqPbeXmVg kDv9zcqjaC4bT6P5Y17G4joRI8kObHhyzEahlejdXqrzY5iEC5JIpdqkLQvePRrRZ76EJKlWswyFG KF8Rqhh5f2bwhAtbKVFWcbelul8pvml4sRCFt0F/de6kKOg/kj9KH8ClpTmaTAzh8UYHA1A0Ne1qa qBNlPArrOfTKQLdNGSaK2g==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phURm-0000Wq-3j; Wed, 29 Mar 2023 07:58:34 -0400 Date: Wed, 29 Mar 2023 14:58:41 +0300 Message-Id: <83h6u37or2.fsf@gnu.org> From: Eli Zaretskii To: Stefan Monnier In-Reply-To: (message from Stefan Monnier on Sun, 26 Mar 2023 11:11:06 -0400) Subject: Re: bug#62453: 30.0.50; Semicolon in view-lossage yields wrong alignment References: <83wn33ams3.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62453 Cc: me@eshelyaron.com, 62453@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Monnier > Cc: Eshel Yaron , 62453@debbugs.gnu.org > Date: Sun, 26 Mar 2023 11:11:06 -0400 > > Here's another problem: > > C-x 5 2 ;; make-frame-command > ;; handle-switch-frame > ;; handle-switch-frame > ;; handle-switch-frame > ;; handle-switch-frame > ;; handle-switch-frame > ;; handle-switch-frame > ;; handle-switch-frame > ;; handle-switch-frame > C- ; ;; nil > ; ;; self-insert-command > C-h l ;; view-lossage > > I'm not sure why there's no `switch-frame` event but it absence leads to > incorrectly indenting the `;; handle-switch-frame`. Yes, but this is not a regression: Emacs 27 behaves the same. So I've now installed my "band-aid" fix on the emacs-29 branch. > We're probably better off indenting "by hand". I will try to come up with a better fix for master, and will also try to stay consistent with edmacro-format-keys while at that.