GNU bug report logs - #62452
30.0.50; [PATCH] Avoid shadowing variables in some Eshell command forms

Previous Next

Package: emacs;

Reported by: Jim Porter <jporterbugs <at> gmail.com>

Date: Sun, 26 Mar 2023 04:49:01 UTC

Severity: normal

Tags: patch

Found in version 30.0.50

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Jim Porter <jporterbugs <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62452: closed (30.0.50; [PATCH] Avoid shadowing variables in
 some Eshell command forms)
Date: Sat, 01 Apr 2023 23:32:01 +0000

[Message part 1 (text/plain, inline)]
Your message dated Sat, 1 Apr 2023 16:31:01 -0700
with message-id <e1f60507-7563-79c3-809a-7e1f6012686c <at> gmail.com>
and subject line Re: bug#62452: 30.0.50; [PATCH] Avoid shadowing variables in some Eshell command forms
has caused the debbugs.gnu.org bug report #62452,
regarding 30.0.50; [PATCH] Avoid shadowing variables in some Eshell command forms
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62452: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62452
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]
From: Jim Porter <jporterbugs <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Avoid shadowing variables in some Eshell command
 forms
Date: Sat, 25 Mar 2023 21:48:13 -0700

[Message part 3 (text/plain, inline)]
To see this in action, start from "emacs -Q -f eshell", then:

  ~ $ setq value "hi there"
  hi there
  ~ $ echo $value
  hi there
  ~ $ echo ${echo $value}
  eshell-temp

The last command should *also* print "hi there", but the variable 
'value' gets shadowed by some internal Eshell code. (A similar problem 
occurs for 'for-items' when using a for loop in Eshell.)

Patch attached.
[0001-Avoid-shadowing-variables-in-some-Eshell-command-for.patch (text/plain, attachment)]
[Message part 5 (message/rfc822, inline)]
From: Jim Porter <jporterbugs <at> gmail.com>
To: 62452-done <at> debbugs.gnu.org
Subject: Re: bug#62452: 30.0.50; [PATCH] Avoid shadowing variables in some
 Eshell command forms
Date: Sat, 1 Apr 2023 16:31:01 -0700

On 3/25/2023 9:48 PM, Jim Porter wrote:
> Patch attached.

Pushed as 97e35b14987. Closing this bug now.
This bug report was last modified 2 years and 104 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.