From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 25 00:51:40 2023 Received: (at submit) by debbugs.gnu.org; 25 Mar 2023 04:51:40 +0000 Received: from localhost ([127.0.0.1]:41840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfvsO-0008Ji-Es for submit@debbugs.gnu.org; Sat, 25 Mar 2023 00:51:40 -0400 Received: from lists.gnu.org ([209.51.188.17]:35998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <873216071@qq.com>) id 1pfvsG-0008JP-9R for submit@debbugs.gnu.org; Sat, 25 Mar 2023 00:51:34 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <873216071@qq.com>) id 1pfvsD-0003VO-Ku for guix-patches@gnu.org; Sat, 25 Mar 2023 00:51:25 -0400 Received: from out203-205-251-36.mail.qq.com ([203.205.251.36]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <873216071@qq.com>) id 1pfvs6-0006g0-Rz for guix-patches@gnu.org; Sat, 25 Mar 2023 00:51:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1679719865; bh=UKJKYUdMMzf6XB86wr14ZIkWwwMyFYoNqBUUlobVf+Q=; h=From:To:Subject:Date; b=MFO8tqujj/5dMu9EwPR9nJJTTSKyzx8aIMXxQhTJnREsY5FsYofOJohMVUaX05FcU xpHCeg6SNTnRq/q93/i+cnl9QsjFCHydGm/kiT0Ejh2SPV9Tvlbgo31hjd7lYbhlXx AVYpzOnyR4ems02vhWbTKDOl1mC37LT38WnD3Yg8= Received: from localhost.localdomain ([112.10.199.221]) by newxmesmtplogicsvrszc1-0.qq.com (NewEsmtp) with SMTP id CC128AD5; Sat, 25 Mar 2023 12:51:01 +0800 X-QQ-mid: xmsmtpt1679719861tf9jd6wxu Message-ID: X-QQ-XMAILINFO: NyTsQ4JOu2J2lsk/Qe7oI39TB05kBVk5bIrBh+Z7VWfpQOjNBkDIO9aoINm67S KG6zLk7d3ZYRVBBYKoTvPKreAVoEJSmbbxEAIfUoGmxFrGBr5mg1gxZVWlXpY4GqVtj9iUWtfr/w FS9eGnpxW6K/R/D7U2zmux8+VWhk63zdPeCc/wl1VFe5VPKM4zMDMDUwY6PtukJxd9Eddsqk+AP9 xInJIriLI4/JMMS5I4sbsMS9ClfV0AENt9uzV3t26QX7KX+TBPo33eJrE/J9bMhTnu4ZeXOKXVbz 5IfRWutTWu6ZIlhoxfTz18bBnyTR0hJRbDBAPb20WzXk1uV2fTS+4vwU9LFj5uadEKE4IQGb9LGc 9+zO2yWdVGnN55IUWxeLpDaD9AgO5OAgQ7BvMyV5wG2wCBbLxTxE/9vhoP2lRjAQzYnIisCqbvNr 2/AGJE0sDd57Ju4vPwtKyJcjM6EqYc2Bs680VVDT9mp2gX7Sb8pOblRRYMg/r/T0ftM2xIpmOS/o 5cYNXPLyYo3ktGsWFYEqpOBggPpncxI3GJROBi5oNN/KJ85DFec4FUSnTNewPDO/YmjuGd0XsNay l94QFb4t0CwQfynwTdlDWe0gizHnrvqIBRJecSDakPNAcY9CAcnlcoJXP7/bP/b5CB6e/HAeRY7P eWrU95EVVEgPrUrwy80SICp467IfIhgLJACsovMh/EJsgJIeJQEzjn/aNOQrxo0hTR/8zkllsR/a guOIZBZ72TvXanPmIj2mxMZ6XbocRP8D01tLChjAN6rWhHRwPx2ZQeumpf+8T4Hket72d0M0G5dh ZbhbkGVuvsbZL+9kk9GrS5jsOrDcp5KKzWFw3r4hVd9VplA3frcJmwY0NqHgzKefaZ6Ssn7Xb3/F jjseEkGHST+BwMBXM95huCTzSa0mIuJH9NDEoWo+Zbk0SePnQFU65ZpSnJctdI2eN223MCJyKw From: Z572 <873216071@qq.com> To: guix-patches@gnu.org Subject: [PATCH] gnu: libicns: fix riscv64 cross-build. Date: Sat, 25 Mar 2023 12:50:59 +0800 X-OQ-MSGID: <6bf44039a4682c178b5d84750cfd68dfc579f02f.1679719815.git.873216071@qq.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=203.205.251.36; envelope-from=873216071@qq.com; helo=out203-205-251-36.mail.qq.com X-Spam_score_int: 11 X-Spam_score: 1.1 X-Spam_bar: + X-Spam_report: (1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) * gnu/packages/image.scm (libicns): fix riscv64 cross-build. [arguments]: when target-riscv64, add phase to update-config-scripts [native-inputs]: when target-riscv64, add config. --- gnu/packages/image.scm | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/gnu/packages/image.scm b/gnu/packages/image.scm index 0da990e63a..81cdcd778e 100644 --- a/gnu/packages/image.scm +++ b/gnu/packages/image.scm @@ -549,6 +549,22 @@ (define-public libicns (base32 "1hjm8lwap7bjyyxsyi94fh5817xzqhk4kb5y0b7mb6675xw10prk")))) (build-system gnu-build-system) + (arguments (if (target-riscv64?) + (list #:phases + #~(modify-phases %standard-phases + (add-after 'unpack 'update-config-scripts + (lambda* (#:key native-inputs inputs #:allow-other-keys) + (for-each (lambda (file) + (install-file + (search-input-file + (or native-inputs inputs) + (string-append "/bin/" file)) ".")) + '("config.guess" "config.sub"))))) ) + '())) + (native-inputs + (if (target-riscv64?) + (list config) + '())) (inputs (list libpng jasper)) (home-page "https://icns.sourceforge.io/") -- 2.39.2 From debbugs-submit-bounces@debbugs.gnu.org Mon Apr 03 07:03:39 2023 Received: (at 62432) by debbugs.gnu.org; 3 Apr 2023 11:03:39 +0000 Received: from localhost ([127.0.0.1]:43424 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjHyN-0002Ml-9M for submit@debbugs.gnu.org; Mon, 03 Apr 2023 07:03:39 -0400 Received: from mail.envs.net ([5.199.136.28]:56032) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pjHyJ-0002MW-7v for 62432@debbugs.gnu.org; Mon, 03 Apr 2023 07:03:37 -0400 Received: from localhost (mail.envs.net [127.0.0.1]) by mail.envs.net (Postfix) with ESMTP id A47C938A008E; Mon, 3 Apr 2023 11:03:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=envs.net; s=modoboa; t=1680519811; bh=0dmh28aXjfJth9MUkM4FdF1WFiOgcf3seNMxIA3YD8A=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SNQ4TFLbUK3QwynpHgZE6seeoNkRvZuhKACmvSPCziYxO5YEiX+iWJ2MfnYHNnqbQ J/DA3eCvMdW7VnXr7VUGHztp/2tcnD8XC9UjZ64FeuUeBlJctxFwXp3n7FX30Pu66J 8s2fKjY7jj/PPjudg1n5d+bQTqF4/bHYooiNKubshsD24sG4EFmKS7dnDaSMQcntB1 EqrCmOiErccYHDS3VNM6cWHL5MH5prYgCk4GSgu/Q+omQ3WPqng/fqcwtOX+/uxQIN QGUL3WApLgUyrHbbK+xge9uEBLZow/8QRTEPERwgVXCczok4ifeg+rX081SqmAO+UG bo404QPHQzIddl4tHiqbG9pGmGtmETePsk8eTjwD/mFMWz4mtTdW99mMFndd/45Ghs D2bJ4kCOQucmPjuENg0hhhyA8byAG/AuUTyMY8LIUxkRjwqhDO926C3NUaivKls0Sb Wa+iaBoYAR0qbWDG2ptIw3zGJRMeVpHy2UqWrMEyHGFziSs/QUQWDEiM0wtdEkFS1N +HauQ94WFyTvac4beVJnjeOHq5ansTciMm2caOgG7Ax4F7BEcEMUxmqAWHJ7Fs2CX5 JoKyd1HeJIVYDBRBaAESp3O/XvlmsIP3TQHBJOYjyeLr9IYR6EofHVZqjmrOlCgWWF nCRTsvJxkiYbfjdmnpIo0JIU= X-Virus-Scanned: Debian amavisd-new at mail.envs.net Received: from mail.envs.net ([127.0.0.1]) by localhost (mail.envs.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0q2w4tIXgI3x; Mon, 3 Apr 2023 11:03:28 +0000 (UTC) Received: from localhost (unknown [36.170.59.59]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.envs.net (Postfix) with ESMTPSA; Mon, 3 Apr 2023 11:03:28 +0000 (UTC) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id e119a3c8; Mon, 3 Apr 2023 11:04:18 +0000 (UTC) From: =?utf-8?B?5a6L5paH5q2m?= To: Z572 <873216071@qq.com> Subject: Re: bug#62432: [PATCH] gnu: libicns: fix riscv64 cross-build. References: Date: Mon, 03 Apr 2023 19:04:18 +0800 In-Reply-To: (873216071@qq.com's message of "Sat, 25 Mar 2023 12:50:59 +0800") Message-ID: <878rf9b51p.fsf@envs.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62432 Cc: 62432@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Z572 <873216071@qq.com> writes: > * gnu/packages/image.scm (libicns): fix riscv64 cross-build. Hello, this message is already in the commit message title, So I think there is no need to repeat it here. Also look in the guix commit log, I think it should be 'gnu: libicns: Fix cross-compilation for riscv64'. > + (arguments (if (target-riscv64?) > + (list #:phases > + #~(modify-phases %standard-phases > + (add-after 'unpack 'update-config-scripts > + (lambda* (#:key native-inputs inputs #:allow-other-keys) > + (for-each (lambda (file) > + (install-file > + (search-input-file > + (or native-inputs inputs) > + (string-append "/bin/" file)) ".")) > + '("config.guess" "config.sub"))))) ) > + '())) > + (native-inputs > + (if (target-riscv64?) > + (list config) > + '())) This updates 'config.guess' and 'config.sub' in a package to fix cross-compilation for riscv64 seems like a common practice (eg: also in your patches #62433, #62544). How about make a procedure for it to save some typing? It could be: ``` (define (autotools-config-updated-package p) "Return package P with @command{config.guess} and @command{config.sub} updated by the @code{config} package" (package (inherit p) ...)) ``` Which could go into (guix transformations). From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 04 08:30:00 2023 Received: (at 62432-done) by debbugs.gnu.org; 4 Jun 2023 12:30:00 +0000 Received: from localhost ([127.0.0.1]:45272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5mrv-0007ws-Lf for submit@debbugs.gnu.org; Sun, 04 Jun 2023 08:30:00 -0400 Received: from mail-ed1-f42.google.com ([209.85.208.42]:49221) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q5mrr-0007w8-TG for 62432-done@debbugs.gnu.org; Sun, 04 Jun 2023 08:29:56 -0400 Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-51640b9ed95so3357416a12.2 for <62432-done@debbugs.gnu.org>; Sun, 04 Jun 2023 05:29:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685881790; x=1688473790; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender:from:to :cc:subject:date:message-id:reply-to; bh=yUt0Kw/D1ysf5W/HxT9fY2mcaNfrWbBriiGjCgOavlw=; b=W3bPB9xG2HJQxY18u4xhCpjuzaElRrM3FKRzmC8cGFa+AIUSSYFB3kfqe+kJFmj5c8 02nAREuFFVS3sqpns/rbEDqNP0nJRcyBfoYFTVUszUNruGYY7ZtFuVjSKdS1XbNN9U/m biqKvyMVlmZ6an6TKzNCf1pUJ1uejtLaSUGoac/APdOsMxQVqDIpsCVUFW4THNFd9/sD 2bj5dpj91/f1q5C/J/C+WPll7sU/uIW1SqV1T3ZvmCAnUr+EcvHYCVZvhG8SA8OUQ98M AFeBZF/FWNb2R3KW1Ut12brixs7/NBQ461AQMzYAhsoWH2NvrYpQ5WRbAODBCI1J4jBy 4FSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685881790; x=1688473790; h=in-reply-to:content-disposition:mime-version:references :mail-followup-to:message-id:subject:cc:to:from:date:sender :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=yUt0Kw/D1ysf5W/HxT9fY2mcaNfrWbBriiGjCgOavlw=; b=eXuZzzZlgobUallbedA17C3xAy2Pex+hcQsiXzrLeBIjhnM2LU9hZePpRN3XBQe6nm BHKHH59tVfZVJm6O5WOQ/FSW7piKb3B+guHuZ3nRfi/EpnIRxrIGXAwCpm8qgBwNidfX AfqGFpjihcs06aH/jA2pH5OjZqI1aNyBx5UhimdRIa7jM8l1u246/YjNXvfDPKWDL+ro mPz1Ss5Q8/eCUzsy4EkBqO4wb+RyIuOza1BISxJXXdhwAIH8fFqkVNP+puR0fL9g2B/e jBk2hXbhwl593z9oj6a7IotP3KM+11VDRJO+y2hc5bGPPMzKrhAAd8SvxRg8C7nIHWPg C5bg== X-Gm-Message-State: AC+VfDwYhwoIoSARSNfWWwTCOF/jEbXRwV+iT+dlhhx0FkPR8P5dE62u waup+5SzsxBLUg4WX38Wmj0= X-Google-Smtp-Source: ACHHUZ5HGwFYEkUqTU1daGHpHgAU2jy1yRAOSlGR4eGwhuf8Ps+CUMDTcr1spq/7gcjOY07UwJRHnw== X-Received: by 2002:a50:ec86:0:b0:510:e902:9690 with SMTP id e6-20020a50ec86000000b00510e9029690mr5996640edr.33.1685881790050; Sun, 04 Jun 2023 05:29:50 -0700 (PDT) Received: from localhost ([2a02:ed3:913:500:b62e:99ff:fef0:7bc0]) by smtp.gmail.com with ESMTPSA id n23-20020aa7c797000000b005027d31615dsm2701442eds.62.2023.06.04.05.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 04 Jun 2023 05:29:49 -0700 (PDT) Date: Sun, 4 Jun 2023 15:29:45 +0300 From: Efraim Flashner To: =?utf-8?B?5a6L5paH5q2m?= Subject: Re: [bug#62432] [PATCH] gnu: libicns: fix riscv64 cross-build. Message-ID: Mail-Followup-To: Efraim Flashner , =?utf-8?B?5a6L5paH5q2m?= , Z572 <873216071@qq.com>, 62432-done@debbugs.gnu.org References: <878rf9b51p.fsf@envs.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="cXpHoKx6RaB9hbmA" Content-Disposition: inline In-Reply-To: <878rf9b51p.fsf@envs.net> X-PGP-Key-ID: 0x41AAE7DCCA3D8351 X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc X-PGP-Fingerprint: A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 62432-done Cc: 62432-done@debbugs.gnu.org, Z572 <873216071@qq.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --cXpHoKx6RaB9hbmA Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Apr 03, 2023 at 07:04:18PM +0800, =E5=AE=8B=E6=96=87=E6=AD=A6 via G= uix-patches via wrote: > Z572 <873216071@qq.com> writes: >=20 > > * gnu/packages/image.scm (libicns): fix riscv64 cross-build. >=20 > Hello, this message is already in the commit message title, So I think > there is no need to repeat it here. Also look in the guix commit log, > I think it should be 'gnu: libicns: Fix cross-compilation for riscv64'. >=20 >=20 > > + (arguments (if (target-riscv64?) > > + (list #:phases > > + #~(modify-phases %standard-phases > > + (add-after 'unpack 'update-config-scripts > > + (lambda* (#:key native-inputs inputs #:= allow-other-keys) > > + (for-each (lambda (file) > > + (install-file > > + (search-input-file > > + (or native-inputs input= s) > > + (string-append "/bin/" = file)) ".")) > > + '("config.guess" "config.su= b"))))) ) > > + '())) > > + (native-inputs > > + (if (target-riscv64?) > > + (list config) > > + '())) >=20 > This updates 'config.guess' and 'config.sub' in a package to fix > cross-compilation for riscv64 seems like a common practice (eg: also in > your patches #62433, #62544). How about make a procedure for it to > save some typing? It could be: >=20 > ``` > (define (autotools-config-updated-package p) > "Return package P with @command{config.guess} and > @command{config.sub} updated by the @code{config} package" > (package (inherit p) > ...)) > ``` >=20 > Which could go into (guix transformations). I would certainly like something like this. I suppose it could be made more general by using find-file to find all occurrences of config.guess and config.sub and replacing those. In the meantime I've pushed this patch after replacing (target-riscv64?) with (and (target-riscv64?) (%current-target-system)). --=20 Efraim Flashner =D7=A8=D7=A0=D7=A9=D7=9C=D7=A4 = =D7=9D=D7=99=D7=A8=D7=A4=D7=90 GPG key =3D A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351 Confidentiality cannot be guaranteed on emails sent or received unencrypted --cXpHoKx6RaB9hbmA Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmR8g7kACgkQQarn3Mo9 g1EHFA/5AafiSh/UgsoHu8CRGn17nBMnh2WPK32YrfOKWo/Rh7pAxoggJda9Udyp 8lBQMu1IZXleA2M6iCmhF3oHhDO0zuNFRVJb7OZ5iuAxFxgKdvfwwhzBHlKMWhZK nhE1raKq2fZCaOeKff68aXrNlkuQ83JD5WGGoJdb9c7BqxBqX0JXToipw8fj93Qo IJho4tPIZDbAPifzOpMdFEabYzvkB+ZXDESjeQirdbf+Nrj+W+vK0SViJlPdVApG +M4CO+Arn3qhCAVy9Mzn1SPVDzEjVblkU+L8opKeH74QJmSFxK+NOSRvqzcvNsRc 7aKYu2tDYQnLJQOMk1e/g6/xfS5+LRhRge+4FERRBULfvVJiwEK2u+LorxxO5lXv NjbEaCmt29kLDsYvQeg7AXb9LWSMXlVzzditZVC3LMwmZ31AJl8XxMK8xluFixZB X4vzfjMMVruEf8E2B72X/+MFBbm0M0DoD05V3526QgOgvUE69VuRwK35Vc8LvPXw FNqcR4IJRcqPjKw33fghzoxc0zPJPv8uTA3pz+3P2I9fe6NxdaiqvY+MthB+0trM FAM6ojtomJDPCn/acu51GWq6vO/cOAJmmQ3+nU9d2zBwfm/g4QM84Ko4jkWF2VUt x46RXpcQhd25EHqcAPCy0yjfWkZAaD5dGm10jBPZxovwWe9PrLM= =QC2j -----END PGP SIGNATURE----- --cXpHoKx6RaB9hbmA-- From unknown Mon Jun 23 07:49:15 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 03 Jul 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator