From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: theo@thornhill.no, bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2023 23:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 62429@debbugs.gnu.org Cc: theo@thornhill.no X-Debbugs-Original-To: Bug Report Emacs X-Debbugs-Original-Xcc: theo@thornhill.no Received: via spool by submit@debbugs.gnu.org id=B.167970180625563 (code B ref -1); Fri, 24 Mar 2023 23:51:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Mar 2023 23:50:06 +0000 Received: from localhost ([127.0.0.1]:41705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfrAb-0006eE-MD for submit@debbugs.gnu.org; Fri, 24 Mar 2023 19:50:05 -0400 Received: from [209.51.188.17] (port=38426 helo=lists.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfrAZ-0006db-Nu for submit@debbugs.gnu.org; Fri, 24 Mar 2023 19:50:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfrAS-0005wR-Va for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 19:49:57 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfrAQ-0000k0-TO for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 19:49:56 -0400 Received: by mail-pl1-x631.google.com with SMTP id o2so3297473plg.4 for ; Fri, 24 Mar 2023 16:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679701789; h=to:date:message-id:subject:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Rf9wMgmUp3qPTAq19f1wAwKvBAfDaqqYnPiHrcNOdFo=; b=n8RnTj6JwY8xDY0DRJK892rVEdkMC/3ko7L11mVpx0yIcRHQRQ3TPQItmEDI7Y3wIh d12MLHWrrQMPdr8MrLerCAznIPIXOmd/odxcmdJ0Ik5YvBlrqnBlboSY67jsw8+Qyc8Z QQW8LT/Z4ntFrrlAeMWtEet7/UkISUBy2yWRpaGBIuvAFZtswEVCQapIyyHt0YP3I3kF 4eDE1/zgGNnZw9t/yLrqBFMherUj2HFX0H15Wx5/He3gEjT+YH9WrinynJKckxC4qJm0 4sWtUEM7SSPGvjgIUsJFDHHEtbnBAv4mNaNZHtAV38IPuYqk+MA/1eLoDrCStJutObJf eyqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679701789; h=to:date:message-id:subject:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Rf9wMgmUp3qPTAq19f1wAwKvBAfDaqqYnPiHrcNOdFo=; b=XV1jPF2bfHE5u04MfTgSQcV5qFtnsGc8KS9tfP1ziWeb6tCWu45FOyrWkPIuOOEySz SlSGjTwMKZfGxl9xirmNH2Tl8PGBrdawMHq9vFaH+K31Vs2hQ3E089Qj8rk7PqoycWv5 yE9UXLjN93aqfzpc7Up8VZmnn9o19qPesCOLvt+dX1mDDbEkv/KvRG7w6wrwohCQsL5N cPzGlfuV2+lvvDg/Ih4HXM9Togeql3niT/uNgrTVT6iZ+j/yvFjJwajfdr8wjNv52m4A swgD2OvxlNgGkUIB+qCnPE60xY1vlhPn3Rn7FODsX6Q3/X8FIZZEuOH/1jFm1cxQ6Jaq +kcQ== X-Gm-Message-State: AAQBX9e0kvg+h01hswZzhUJdYZLei6Fdb4W0jwthOz4hsrVjvM0F0/HM M4TyAkEwYGWOr/oY8HEQfHr3930G1HMYdw== X-Google-Smtp-Source: AKy350ZMZfUEoGJL+FwvF4cRRXQb4+QN5H6j8NMtvfklSbeYHKpwyAallHfLvXY2bkEuqTuNXgRIzQ== X-Received: by 2002:a17:903:2341:b0:19c:e666:a678 with SMTP id c1-20020a170903234100b0019ce666a678mr3962108plh.50.1679701788356; Fri, 24 Mar 2023 16:49:48 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id g9-20020a170902934900b0019f1205bdcbsm14683685plp.147.2023.03.24.16.49.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2023 16:49:46 -0700 (PDT) From: Yuan Fu Content-Type: multipart/mixed; boundary="Apple-Mail=_36B1A9E6-C68B-42E6-A750-6BFFD67864A6" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Message-Id: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> Date: Fri, 24 Mar 2023 16:49:35 -0700 X-Mailer: Apple Mail (2.3731.400.51.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=casouri@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) --Apple-Mail=_36B1A9E6-C68B-42E6-A750-6BFFD67864A6 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii X-Debbugs-CC: theo@thornhill.no Hey Theo, I want to add separate faces for JSX tags and attributes. Otherwise users will be in a world of pain if they want to use different fontification for JSX tag and funcall, and JSX attribute and constant. WDYT? Yuan --Apple-Mail=_36B1A9E6-C68B-42E6-A750-6BFFD67864A6 Content-Disposition: attachment; filename=faces.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="faces.patch" Content-Transfer-Encoding: quoted-printable =46rom=206a52f34fff83908312881b9f46f07bf54597ff6f=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Yuan=20Fu=20=0ADate:=20Fri,=20= 24=20Mar=202023=2016:45:15=20-0700=0ASubject:=20[PATCH]=20Add=20two=20= typescript-ts-mode=20faces=0A=0A*=20= lisp/progmodes/typescript-ts-mode.el:=0A= (typescript-ts-mode-jsx-tag-face)=0A= (typescript-ts-mode-jsx-attribute-face):=20New=20faces.=0A= (typescript-ts-mode--font-lock-settings):=20Use=20new=20faces.=0A---=0A=20= lisp/progmodes/typescript-ts-mode.el=20|=2016=20++++++++++++----=0A=201=20= file=20changed,=2012=20insertions(+),=204=20deletions(-)=0A=0Adiff=20= --git=20a/lisp/progmodes/typescript-ts-mode.el=20= b/lisp/progmodes/typescript-ts-mode.el=0Aindex=20= a9ca85d5d35..207c3f03b88=20100644=0A---=20= a/lisp/progmodes/typescript-ts-mode.el=0A+++=20= b/lisp/progmodes/typescript-ts-mode.el=0A@@=20-41,6=20+41,14=20@@=20= typescript-ts-mode-indent-offset=0A=20=20=20:safe=20'integerp=0A=20=20=20= :group=20'typescript)=0A=20=0A+(defface=20typescript-ts-jsx-tag-face=0A+=20= =20'((t=20.=20(:inherit=20font-lock-function-call-face)))=0A+=20=20"Face=20= for=20HTML=20tags=20like=20
=20and=20

=20in=20JSX.")=0A+=0A= +(defface=20typescript-ts-jsx-attribute-face=0A+=20=20'((t=20.=20= (:inherit=20font-lock-constant-face)))=0A+=20=20"Face=20for=20HTML=20= attributes=20like=20name=20and=20id=20in=20JSX.")=0A+=0A=20(defvar=20= typescript-ts-mode--syntax-table=0A=20=20=20(let=20((table=20= (make-syntax-table)))=0A=20=20=20=20=20;;=20Taken=20from=20the=20= cc-langs=20version=0A@@=20-284,17=20+292,17=20@@=20= typescript-ts-mode--font-lock-settings=0A=20=20=20=20:feature=20'jsx=0A=20= =20=20=20`((jsx_opening_element=0A=20=20=20=20=20=20=20= [(nested_identifier=20(identifier))=20(identifier)]=0A-=20=20=20=20=20=20= @font-lock-function-call-face)=0A+=20=20=20=20=20=20= @typescript-ts-jsx-tag-face)=0A=20=0A=20=20=20=20=20=20= (jsx_closing_element=0A=20=20=20=20=20=20=20[(nested_identifier=20= (identifier))=20(identifier)]=0A-=20=20=20=20=20=20= @font-lock-function-call-face)=0A+=20=20=20=20=20=20= @typescript-ts-jsx-tag-face)=0A=20=0A=20=20=20=20=20=20= (jsx_self_closing_element=0A=20=20=20=20=20=20=20[(nested_identifier=20= (identifier))=20(identifier)]=0A-=20=20=20=20=20=20= @font-lock-function-call-face)=0A+=20=20=20=20=20=20= @typescript-ts-jsx-tag-face)=0A=20=0A-=20=20=20=20=20(jsx_attribute=20= (property_identifier)=20@font-lock-constant-face))=0A+=20=20=20=20=20= (jsx_attribute=20(property_identifier)=20= @typescript-ts-jsx-attribute-face))=0A=20=0A=20=20=20=20:language=20= language=0A=20=20=20=20:feature=20'number=0A--=20=0A2.33.1=0A=0A= --Apple-Mail=_36B1A9E6-C68B-42E6-A750-6BFFD67864A6-- From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 11:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 62429@debbugs.gnu.org, casouri@gmail.com X-Debbugs-Original-To: debbugs-submit@debbugs.gnu.org, Yuan Fu , 62429@debbugs.gnu.org Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.167974520615098 (code B ref 62429); Sat, 25 Mar 2023 11:54:02 +0000 Received: (at 62429) by debbugs.gnu.org; 25 Mar 2023 11:53:26 +0000 Received: from localhost ([127.0.0.1]:41895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2Sc-0003vR-E6 for submit@debbugs.gnu.org; Sat, 25 Mar 2023 07:53:26 -0400 Received: from out-21.mta1.migadu.com ([95.215.58.21]:52287) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2SZ-0003v5-TK for 62429@debbugs.gnu.org; Sat, 25 Mar 2023 07:53:24 -0400 Date: Sat, 25 Mar 2023 06:47:13 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1679723238; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=gZedEOShSxeIKVkJCvYD5OVjELT6SVoKC3PAWBsBKRo=; b=CqRLrAzekeh5T05vj5Y80ZJuICxl22o+wHedCYY7Jb1KCAzKdDwvtZ8wcg22GF6bTQuDys YPx+ljV8Sym5wtzNrutGspZqw5LmcRFOacXrlBu/tkJPIh8gFTHYMNJHsZJIC0QEMe3O9C /hgiOzCBfeNMLxG/vcU+Hp3TdW/oLCHuAJeOvb9qGdWbwDwHoo7EK2k2efJ1lD5q1T57Xt Cp373x+hGOBbrpC/xpxBxFFQ5vSWofFIWgtynkTyfVpDQLFaGYkIshepTjst2+r0aCnxgd EoepeaW5Z9b+/dmUVWyA/jqvJHHK/59wz4GlGJD/mUMIPC8zP/qBhgGnAhn7Kw== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Theodor Thornhill In-Reply-To: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Migadu-Flow: FLOW_OUT X-Spam-Score: 1.1 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On 25 March 2023 00:49:35 CET, Yuan Fu wrote: >X-Debbugs-CC: theo@thornhill.no > >Hey Theo, I want to add separate faces for JSX tags and attributes. >Otherwise users will be in a [...] Content analysis details: (1.1 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 1.1 DATE_IN_PAST_06_12 Date: is 6 to 12 hours before Received: date X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.1 (/) On 25 March 2023 00:49:35 CET, Yuan Fu wrote: >X-Debbugs-CC: theo@thornhill=2Eno > >Hey Theo, I want to add separate faces for JSX tags and attributes=2E >Otherwise users will be in a world of pain if they want to use different >fontification for JSX tag and funcall, and JSX attribute and constant=2E = WDYT? > >Yuan > Sounds reasonable :) Theo From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 12:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu , Stefan Monnier Cc: theo@thornhill.no, 62429@debbugs.gnu.org Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.167974745119377 (code B ref 62429); Sat, 25 Mar 2023 12:31:02 +0000 Received: (at 62429) by debbugs.gnu.org; 25 Mar 2023 12:30:51 +0000 Received: from localhost ([127.0.0.1]:42039 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg32p-00052S-A3 for submit@debbugs.gnu.org; Sat, 25 Mar 2023 08:30:51 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41980) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg32n-00052D-Ma for 62429@debbugs.gnu.org; Sat, 25 Mar 2023 08:30:49 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg32f-00062w-Jx; Sat, 25 Mar 2023 08:30:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jFAhZkCD7M7NHD0z6O6FWDSCChKCDpkQtxFatsv9Pvk=; b=dPYWHPvIBfPa jrfcHcwlgzJOy3NUNY4fibWXm90asRWyPG21RL0YUXdCjmFeB2XzjedJVdIX7eWZkz+4U+mBhxrIA ak1dLs6aMRmmnYtYAkOe1kcSva4oMttDIMHSxnSvz5c/fFF0IIGsgW8me5DhUh4f5Gm+73Xa/fKSj bBpzYP8xgglJLkABhIG4D0v3694dvzzznPodV1t6kdLygQ6JhgtqWKlvUTfbBc/YG4SQMqqBwaTYS WVdog2PoaNQOXaWytUGJI0CaTWX4kwXEoH0C5LYVf0E9/sp81kYFUdoedTcZ8GQx9KsauzuZTZ+Gd ORx4BB68Gvl2EygwXzNbyg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg32f-0002hk-1n; Sat, 25 Mar 2023 08:30:41 -0400 Date: Sat, 25 Mar 2023 15:30:37 +0300 Message-Id: <83lejlc8sy.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> (message from Yuan Fu on Fri, 24 Mar 2023 16:49:35 -0700) References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: theo@thornhill.no > From: Yuan Fu > Date: Fri, 24 Mar 2023 16:49:35 -0700 > > Hey Theo, I want to add separate faces for JSX tags and attributes. > Otherwise users will be in a world of pain if they want to use different > fontification for JSX tag and funcall, and JSX attribute and constant. WDYT? We never had any mode-specific faces for font-lock, AFAIK. Why is this case different? Why not use one of the existing font-lock faces, or even add new ones (but not specific to JSX)? (Adding Stefan.) From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 19:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: theo@thornhill.no, 62429@debbugs.gnu.org, Stefan Monnier Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.167977352211180 (code B ref 62429); Sat, 25 Mar 2023 19:46:01 +0000 Received: (at 62429) by debbugs.gnu.org; 25 Mar 2023 19:45:22 +0000 Received: from localhost ([127.0.0.1]:43553 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9pK-0002uF-8F for submit@debbugs.gnu.org; Sat, 25 Mar 2023 15:45:22 -0400 Received: from mail-pl1-f170.google.com ([209.85.214.170]:33620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9pH-0002tz-UR for 62429@debbugs.gnu.org; Sat, 25 Mar 2023 15:45:20 -0400 Received: by mail-pl1-f170.google.com with SMTP id f22so737625plr.0 for <62429@debbugs.gnu.org>; Sat, 25 Mar 2023 12:45:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679773514; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=+LpkgkdXDJranr+7ZlSvSRDGEmyorfJ+vlhU9qxqaTY=; b=mkYxhmqpE821OZ76Da/iuMA2d1Q2NDNCRo4FLPmtkNIkmb/ywaMLCl/WtLEKqhrYo+ vVIkhqIv2RLD4QyjUGjAplmB/fRXNZUdJ/XA/EM4grQdNxDwfhUDwF8p1sLHxA/l9ojT XT1awHDrG9RsbaZOgnjMDZ3ebJHS+B4UKYYmdxhtF5GMYK69wr21N4+1bzicQ31UWmtb 7nbj9XIQ5tuA4lI9odii3zpOwDu/dZKJ1RCT9+NrBCaO+HeDT0TIk1MotMKtsZ8XumWa GxX3EeSUnrM5z/a4DQVSppVVUUJrdAx9E9UkUibDrcR6wDA3s1ZNofsCLsEquK7xWPoC CB+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679773514; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=+LpkgkdXDJranr+7ZlSvSRDGEmyorfJ+vlhU9qxqaTY=; b=mhvvB5R7uXoWTDVR6LFjZHpEYWzqm8UrWDwsH9w4dohm7WYdNbb6VAojxmaahPoves rQHV7z0pAjbBjMaGrDkg9FfM+oUCChEUnWyn5IQcaclHGjTRNld+Z/Hdr8K5YywwGPM3 e//JrV+PIA3d3EeompF6xT+hBkBS/+kp0B6yrJxnq6bIMcEW/BbkhhlXMEGydTnKOEl9 0K3zglEgST7iM9T7x7AIsOeybdfHPuo891DnT6S6pDNDGpCpO6ST/f4IUy9pEtawInMB jkAz/Zq3Dn3NynA1toslG1NYPkghRVDaUyNSaTw9pkD+jgUFMN+zjO027FOq+6ZWij3M H4cA== X-Gm-Message-State: AAQBX9dhAIy+omRzRqCUXABE+nmuXKl7FISfrFb2oKuN0tUvw/ovGHFs Zb5xT/2jG89mZJNxquYGwec= X-Google-Smtp-Source: AKy350YmIM1iNBrU7BHX/p69aoMLpwryV2kTEljJMp9Sj4z293UsX5CafFRHjC00fw8nfAEMWpQQKw== X-Received: by 2002:a17:90a:b397:b0:23f:7ff6:eba with SMTP id e23-20020a17090ab39700b0023f7ff60ebamr7477963pjr.0.1679773513902; Sat, 25 Mar 2023 12:45:13 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id q6-20020a17090a7a8600b00233e860f69esm1742206pjf.56.2023.03.25.12.45.13 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 25 Mar 2023 12:45:13 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) From: Yuan Fu In-Reply-To: <83lejlc8sy.fsf@gnu.org> Date: Sat, 25 Mar 2023 12:45:01 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mar 25, 2023, at 5:30 AM, Eli Zaretskii wrote: >=20 >> Cc: theo@thornhill.no >> From: Yuan Fu >> Date: Fri, 24 Mar 2023 16:49:35 -0700 >>=20 >> Hey Theo, I want to add separate faces for JSX tags and attributes. >> Otherwise users will be in a world of pain if they want to use = different >> fontification for JSX tag and funcall, and JSX attribute and = constant. WDYT? >=20 > We never had any mode-specific faces for font-lock, AFAIK. Why is > this case different? Why not use one of the existing font-lock faces, > or even add new ones (but not specific to JSX)? >=20 > (Adding Stefan.) IFIAK, css-mode has its own face. These two faces are specific to HTML = and not widely applicable to other languages like other font-lock faces = do. JSX is basically HTML mixed with Javascript, so JSX tags and attributes = are just HTML tags and attributes. Normally it=E2=80=99s fine to just = use some semi-related font-lock face for them; mhtml.el uses = function-call-face and constant-face for tags and attributes. But = because in JSX, HTML tags and attribtues appear in the same buffer with = Javascript code, if we use function-call-face and constant-face for tags = and attributes, it=E2=80=99s impossible to change their appearance and = not affect the functions and constants in Javascript code, because we = are using the same face for JS functions and HTML tags, and JS constants = and HTML attributes. Yuan= From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 04:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: theo@thornhill.no, 62429@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.167980544231930 (code B ref 62429); Sun, 26 Mar 2023 04:38:02 +0000 Received: (at 62429) by debbugs.gnu.org; 26 Mar 2023 04:37:22 +0000 Received: from localhost ([127.0.0.1]:43804 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgI89-0008Iw-RH for submit@debbugs.gnu.org; Sun, 26 Mar 2023 00:37:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40868) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgI87-0008Ij-Ci for 62429@debbugs.gnu.org; Sun, 26 Mar 2023 00:37:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgI81-0001rg-2K; Sun, 26 Mar 2023 00:37:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=rvJ82hPb/dw1ygfg0AfRX3q+qk5YZ6523S4d+6PJUcI=; b=El4nAIzBU0CU5l42GMtF Tsd7Au0g9vkY7m4cNQM31i55bOQmw+wEJHDVviz4HbqdJWWSf7W8VM1lwxyfmDBIdUpOngWIQLe3s 90eAIeQo4FFqABbq6mm6Ltrilmhp3C7A/nW7Hd6LO2KUtalKvduXVBktmeUIzBx5Q1kIQTEw9raE4 8WfX6SHOnsfswreaOPwXLCUtw6JiYAB0R1g/FLFZO0SgtJazMXjd/StzPzW0q6T2d3useCWwJG5DL FESDjk9O2S/etPDPaai63EN8jRhvV/HK5MdO4FRVLEQ96/KZu20X2hvzqgouvsOr0JKCcGQWzlPi5 ZOJURtl/vtQRtg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgI80-0006K7-4Z; Sun, 26 Mar 2023 00:37:12 -0400 Date: Sun, 26 Mar 2023 07:37:11 +0300 Message-Id: <837cv4b020.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> (message from Yuan Fu on Sat, 25 Mar 2023 12:45:01 -0700) References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Sat, 25 Mar 2023 12:45:01 -0700 > Cc: Stefan Monnier , > 62429@debbugs.gnu.org, > theo@thornhill.no > > > On Mar 25, 2023, at 5:30 AM, Eli Zaretskii wrote: > > > > We never had any mode-specific faces for font-lock, AFAIK. Why is > > this case different? Why not use one of the existing font-lock faces, > > or even add new ones (but not specific to JSX)? > > > > (Adding Stefan.) > > IFIAK, css-mode has its own face. These two faces are specific to HTML and not widely applicable to other languages like other font-lock faces do. > > JSX is basically HTML mixed with Javascript, so JSX tags and attributes are just HTML tags and attributes. Normally it’s fine to just use some semi-related font-lock face for them; mhtml.el uses function-call-face and constant-face for tags and attributes. But because in JSX, HTML tags and attribtues appear in the same buffer with Javascript code, if we use function-call-face and constant-face for tags and attributes, it’s impossible to change their appearance and not affect the functions and constants in Javascript code, because we are using the same face for JS functions and HTML tags, and JS constants and HTML attributes. OK, but then how will these JSX-specific faces fit into the overall scheme of treesit-font-lock faces? For example, in what level will they be used, and how will users know what level to set to see these faces in their buffers? These are the downsides of mode-specific faces, and if we think it's important enough to have them, we should resolve these issues when we install such faces. From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Mar 2023 00:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: theo@thornhill.no, 62429@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.168013614014016 (code B ref 62429); Thu, 30 Mar 2023 00:29:02 +0000 Received: (at 62429) by debbugs.gnu.org; 30 Mar 2023 00:29:00 +0000 Received: from localhost ([127.0.0.1]:55258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phgA0-0003dz-3J for submit@debbugs.gnu.org; Wed, 29 Mar 2023 20:29:00 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:37818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phg9y-0003dm-2B for 62429@debbugs.gnu.org; Wed, 29 Mar 2023 20:28:58 -0400 Received: by mail-pl1-f169.google.com with SMTP id o2so16580104plg.4 for <62429@debbugs.gnu.org>; Wed, 29 Mar 2023 17:28:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680136132; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=JVyhCCTWDKYGV95biSDPvKAQ2BI74LxumGCiZtSRe+4=; b=Ch+3AB+oGtKy/rLMo26vkhLlcojWAcJySQO27+DJcjqXuwpWMlr8eJNZRUCGmaG9VA OLgKxIliRHF8fjamnIbghgzDWOa2nhVdWB5Ur0fQHkND542UIjky7tgb68ajhY4sjCQr FEJaVlnWY5AtsT+ug+sMdhivwiwrkhr2jZSSUS90KrTRESIhdfTKd+0ocGh41bgHmxD5 pg4K7akJVWxW2ahch8UyCJzYYNz5Dfs5guvyVYWZfdzICT3b23mll4Jn/HuhQqueEiz7 utzYI5+iAyYMWO+wOSlCSd91PDDHPJF9kutZJSjGt3z0IM7d2KBoGHPVX6mBhpitvx9r EOhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680136132; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JVyhCCTWDKYGV95biSDPvKAQ2BI74LxumGCiZtSRe+4=; b=m2dM9NpbCL4Npowi3IazDQOZ0/KvwfgPJ8Th2xPgSJyjsupMs4VBEdhxvC1MkpgXug tcsOnKfc6uR3WrSvWcn/W/Ji7FE/HuwyEd9JBoy//vGmyJLevuathOkAc+NnIlKOrKkH EHS51sliRhhI0zTj3gP35b9yy2RTW+nREAohRtCzZdgsO7QucgTjUAUp2uHlbH9HZoYB lE8LMcvZhs4y/Dt7t6Bah5+r/67MOgQNgHDZ9sf2YopJqworA0Hr+Wya/ZNeV+zSrc+L UJ3HzlJq42KkoB4/NvueiBbrUa1qQdXyE1R6J4ohU5oWeEbXthjD2V2XUr2hNWUhOycy flcg== X-Gm-Message-State: AAQBX9ekO+fKvUSgy81DmUpMkBP7vxPSNj79wJ/sgAB46GRrYTU7J1Lh 4lULsqphZ+FlslhBNhcB/JU= X-Google-Smtp-Source: AKy350ZzONYdhG2cZJddHIzDhlmAYCR92swWDkQ3xjXLrDZDXUj30c7s0FDvRzIk3FXRyaykh/P9qg== X-Received: by 2002:a17:90a:318d:b0:237:d867:2260 with SMTP id j13-20020a17090a318d00b00237d8672260mr4072928pjb.4.1680136131964; Wed, 29 Mar 2023 17:28:51 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id h5-20020a170902748500b0019c91d3bdb4sm23432033pll.304.2023.03.29.17.28.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 29 Mar 2023 17:28:51 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) From: Yuan Fu In-Reply-To: <837cv4b020.fsf@gnu.org> Date: Wed, 29 Mar 2023 17:28:40 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <9E07A07B-EDF4-436F-8208-01D2CCA7A7AF@gmail.com> References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> <837cv4b020.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mar 25, 2023, at 9:37 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Sat, 25 Mar 2023 12:45:01 -0700 >> Cc: Stefan Monnier , >> 62429@debbugs.gnu.org, >> theo@thornhill.no >>=20 >>> On Mar 25, 2023, at 5:30 AM, Eli Zaretskii wrote: >>>=20 >>> We never had any mode-specific faces for font-lock, AFAIK. Why is >>> this case different? Why not use one of the existing font-lock = faces, >>> or even add new ones (but not specific to JSX)? >>>=20 >>> (Adding Stefan.) >>=20 >> IFIAK, css-mode has its own face. These two faces are specific to = HTML and not widely applicable to other languages like other font-lock = faces do. >>=20 >> JSX is basically HTML mixed with Javascript, so JSX tags and = attributes are just HTML tags and attributes. Normally it=E2=80=99s fine = to just use some semi-related font-lock face for them; mhtml.el uses = function-call-face and constant-face for tags and attributes. But = because in JSX, HTML tags and attribtues appear in the same buffer with = Javascript code, if we use function-call-face and constant-face for tags = and attributes, it=E2=80=99s impossible to change their appearance and = not affect the functions and constants in Javascript code, because we = are using the same face for JS functions and HTML tags, and JS constants = and HTML attributes. >=20 > OK, but then how will these JSX-specific faces fit into the overall > scheme of treesit-font-lock faces? For example, in what level will > they be used, and how will users know what level to set to see these > faces in their buffers? At level 3 for tsx-ts-mode, under the =E2=80=9Cjsx=E2=80=9D feature. So = they are enabled by default. Though it=E2=80=99s true that it=E2=80=99s = not immediately obvious what face to customize. At the very least these = faces appear in the customize group of typescript. We can add something = to the docstring of the major mode, too. >=20 > These are the downsides of mode-specific faces, and if we think it's > important enough to have them, we should resolve these issues when we > install such faces. Yuan= From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Mar 2023 05:26:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: theo@thornhill.no, 62429@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.168015391512306 (code B ref 62429); Thu, 30 Mar 2023 05:26:02 +0000 Received: (at 62429) by debbugs.gnu.org; 30 Mar 2023 05:25:15 +0000 Received: from localhost ([127.0.0.1]:55410 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phkmh-0003CQ-7s for submit@debbugs.gnu.org; Thu, 30 Mar 2023 01:25:15 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39886) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phkmf-0003CB-QG for 62429@debbugs.gnu.org; Thu, 30 Mar 2023 01:25:14 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phkma-00075n-2a; Thu, 30 Mar 2023 01:25:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=W8fEc2IBnBzMxSof1dkSDRJnL9P/krOV+k9gJUtdezU=; b=nUy6ehDV8HHFoUIVDcY/ REjvRMMzHmgTsmZsdTNKjyHgNy+ddrhpu3YLQmwF/rj3DzuNJiY2CNO31RiPVK+G66FsVUf5jCCyN haeoR6weI9F8Dhqz0vTYiQAS07/rWXkg01BjEL3OpwpAmPlu0vBSji5/871qqJNDH2isrBPFysq7C sZf036IgPFDBw0aSryyZwpSzHs8pknCkTfaM+9HbMYHJ9ecagjLuibxR5jEbQvq2w6c60uxBReVl3 4ODg6slVYpguxYsBpKnkvB+OV4KF3JupKt5k9RKWXU4Q/cD05Bx0w9s9IZDlvSMP2+Dblg/5/VMty LAdcaGwuj1ibCQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phkmZ-0001bY-8n; Thu, 30 Mar 2023 01:25:07 -0400 Date: Thu, 30 Mar 2023 08:25:17 +0300 Message-Id: <83wn2y6caq.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <9E07A07B-EDF4-436F-8208-01D2CCA7A7AF@gmail.com> (message from Yuan Fu on Wed, 29 Mar 2023 17:28:40 -0700) References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> <837cv4b020.fsf@gnu.org> <9E07A07B-EDF4-436F-8208-01D2CCA7A7AF@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Wed, 29 Mar 2023 17:28:40 -0700 > Cc: monnier@iro.umontreal.ca, > 62429@debbugs.gnu.org, > theo@thornhill.no > > >> JSX is basically HTML mixed with Javascript, so JSX tags and attributes are just HTML tags and attributes. Normally it’s fine to just use some semi-related font-lock face for them; mhtml.el uses function-call-face and constant-face for tags and attributes. But because in JSX, HTML tags and attribtues appear in the same buffer with Javascript code, if we use function-call-face and constant-face for tags and attributes, it’s impossible to change their appearance and not affect the functions and constants in Javascript code, because we are using the same face for JS functions and HTML tags, and JS constants and HTML attributes. > > > > OK, but then how will these JSX-specific faces fit into the overall > > scheme of treesit-font-lock faces? For example, in what level will > > they be used, and how will users know what level to set to see these > > faces in their buffers? > > At level 3 for tsx-ts-mode, under the “jsx” feature. So they are enabled by default. Though it’s true that it’s not immediately obvious what face to customize. At the very least these faces appear in the customize group of typescript. We can add something to the docstring of the major mode, too. > > > > > These are the downsides of mode-specific faces, and if we think it's > > important enough to have them, we should resolve these issues when we > > install such faces. Then it is fine by me, as long as those measures you mentioned are taken to make sure users know how to customize font-lock with these faces. From unknown Sun Jun 22 11:39:13 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Yuan Fu Subject: bug#62429: closed (Re: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode) Message-ID: References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> X-Gnu-PR-Message: they-closed 62429 X-Gnu-PR-Package: emacs Reply-To: 62429@debbugs.gnu.org Date: Thu, 30 Mar 2023 08:13:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1680163982-29769-1" This is a multi-part message in MIME format... ------------=_1680163982-29769-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #62429: 30.0.50; Add jsx faces to typescript-ts-mode which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 62429@debbugs.gnu.org. --=20 62429: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62429 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1680163982-29769-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 62429-done) by debbugs.gnu.org; 30 Mar 2023 08:12:14 +0000 Received: from localhost ([127.0.0.1]:55690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phnOH-0007iu-Ix for submit@debbugs.gnu.org; Thu, 30 Mar 2023 04:12:13 -0400 Received: from mail-pj1-f51.google.com ([209.85.216.51]:42750) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phnOC-0007iW-I8 for 62429-done@debbugs.gnu.org; Thu, 30 Mar 2023 04:12:09 -0400 Received: by mail-pj1-f51.google.com with SMTP id h12-20020a17090aea8c00b0023d1311fab3so18810871pjz.1 for <62429-done@debbugs.gnu.org>; Thu, 30 Mar 2023 01:12:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680163922; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=AZssTyE2EP0d+pwUmmre+MlzIqnVZiHdtU8jdduMg/I=; b=FTOIZDmQaP9wHsTvMnQNRJaXy6F0u9YVLEuKr9fNTwlPrV5fsZ6I7qCAV19fa8H5JN GkjcQiMV9QeKryxvDJ5pRFu89XF5N6dS09Yh6DeuQCG4rnAWh9HBwMMaAgbw8T44Gm7a gLcDsNzlXpP/mFdcPapuntpiAhEVy5Diw65EupO1IQqGFlspjv2WTtBDzfGZGUiI/T/S CeQoqFSTLqT7CeCk/EcRgwk2YROfH43VBDCdZDuhlX9dM6Wblmr0SmdJvpZyYGiVi+qZ M1J3Rqg1px928NUlJZgYkASXU1fb78NHQLdTRrBCDZbOz8ytUWMg4XIlVuJ2VXl3h0l5 scyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680163922; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AZssTyE2EP0d+pwUmmre+MlzIqnVZiHdtU8jdduMg/I=; b=efG5DocNRptWRVG9Id8Khk9QZNL2ihDnMtulvjHs80QClfkwzYnTn8m+3MtwYsi99N TQbfeGMdfDuxis+aEort7KVEBE29qXLPoEns1miGoL7IJjofe9tkTXE4WkHD9m3kRLc1 Q+SQXLm/sFLtJDKc8PJiVM2nyezvA/mK32Os7f0WA1ZV5ki7hUyTa+LjUxaVNg+b6WmQ ARhyr3j/AmNYQfLF1lSKDpByJt2WWV4GA/wlwgQ/GK3Qyr4Dl0826Yj73ouePSfrGiU2 tkK3ifFADvpQ/jhS6Dk/lfA7WPp+T05gDqpus/L4c5Z6AEbHPkS9Vimx8S+9UmBUvM03 PExw== X-Gm-Message-State: AAQBX9ekAMn1ddcIux3qVJr6rok3KB/607JaIqRoxyiWBFH7D7lgu+8d TVDm5R+YcKmPznr/jP0WG38= X-Google-Smtp-Source: AKy350bZRmSP2Fo5zUm7hUy70fNKNAkAAAtLvdkhVMf1OJrnevxmFLFUHBP8FNNrPcd6DjeGT3RGNg== X-Received: by 2002:a17:90b:1bc2:b0:23d:39e0:142 with SMTP id oa2-20020a17090b1bc200b0023d39e00142mr24822330pjb.42.1680163922445; Thu, 30 Mar 2023 01:12:02 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id g11-20020a17090a300b00b00233e860f69esm2616595pjb.56.2023.03.30.01.12.01 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Mar 2023 01:12:02 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: Re: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode From: Yuan Fu In-Reply-To: <83wn2y6caq.fsf@gnu.org> Date: Thu, 30 Mar 2023 01:11:48 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> <837cv4b020.fsf@gnu.org> <9E07A07B-EDF4-436F-8208-01D2CCA7A7AF@gmail.com> <83wn2y6caq.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 62429-done Cc: theodor thornhill , 62429-done@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mar 29, 2023, at 10:25 PM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Wed, 29 Mar 2023 17:28:40 -0700 >> Cc: monnier@iro.umontreal.ca, >> 62429@debbugs.gnu.org, >> theo@thornhill.no >>=20 >>>> JSX is basically HTML mixed with Javascript, so JSX tags and = attributes are just HTML tags and attributes. Normally it=E2=80=99s fine = to just use some semi-related font-lock face for them; mhtml.el uses = function-call-face and constant-face for tags and attributes. But = because in JSX, HTML tags and attribtues appear in the same buffer with = Javascript code, if we use function-call-face and constant-face for tags = and attributes, it=E2=80=99s impossible to change their appearance and = not affect the functions and constants in Javascript code, because we = are using the same face for JS functions and HTML tags, and JS constants = and HTML attributes. >>>=20 >>> OK, but then how will these JSX-specific faces fit into the overall >>> scheme of treesit-font-lock faces? For example, in what level will >>> they be used, and how will users know what level to set to see these >>> faces in their buffers? >>=20 >> At level 3 for tsx-ts-mode, under the =E2=80=9Cjsx=E2=80=9D feature. = So they are enabled by default. Though it=E2=80=99s true that it=E2=80=99s= not immediately obvious what face to customize. At the very least these = faces appear in the customize group of typescript. We can add something = to the docstring of the major mode, too. >>=20 >>>=20 >>> These are the downsides of mode-specific faces, and if we think it's >>> important enough to have them, we should resolve these issues when = we >>> install such faces. >=20 > Then it is fine by me, as long as those measures you mentioned are > taken to make sure users know how to customize font-lock with these > faces. Cool. I pushed the change. Yuan= ------------=_1680163982-29769-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Mar 2023 23:50:06 +0000 Received: from localhost ([127.0.0.1]:41705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfrAb-0006eE-MD for submit@debbugs.gnu.org; Fri, 24 Mar 2023 19:50:05 -0400 Received: from [209.51.188.17] (port=38426 helo=lists.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfrAZ-0006db-Nu for submit@debbugs.gnu.org; Fri, 24 Mar 2023 19:50:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfrAS-0005wR-Va for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 19:49:57 -0400 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfrAQ-0000k0-TO for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 19:49:56 -0400 Received: by mail-pl1-x631.google.com with SMTP id o2so3297473plg.4 for ; Fri, 24 Mar 2023 16:49:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679701789; h=to:date:message-id:subject:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=Rf9wMgmUp3qPTAq19f1wAwKvBAfDaqqYnPiHrcNOdFo=; b=n8RnTj6JwY8xDY0DRJK892rVEdkMC/3ko7L11mVpx0yIcRHQRQ3TPQItmEDI7Y3wIh d12MLHWrrQMPdr8MrLerCAznIPIXOmd/odxcmdJ0Ik5YvBlrqnBlboSY67jsw8+Qyc8Z QQW8LT/Z4ntFrrlAeMWtEet7/UkISUBy2yWRpaGBIuvAFZtswEVCQapIyyHt0YP3I3kF 4eDE1/zgGNnZw9t/yLrqBFMherUj2HFX0H15Wx5/He3gEjT+YH9WrinynJKckxC4qJm0 4sWtUEM7SSPGvjgIUsJFDHHEtbnBAv4mNaNZHtAV38IPuYqk+MA/1eLoDrCStJutObJf eyqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679701789; h=to:date:message-id:subject:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=Rf9wMgmUp3qPTAq19f1wAwKvBAfDaqqYnPiHrcNOdFo=; b=XV1jPF2bfHE5u04MfTgSQcV5qFtnsGc8KS9tfP1ziWeb6tCWu45FOyrWkPIuOOEySz SlSGjTwMKZfGxl9xirmNH2Tl8PGBrdawMHq9vFaH+K31Vs2hQ3E089Qj8rk7PqoycWv5 yE9UXLjN93aqfzpc7Up8VZmnn9o19qPesCOLvt+dX1mDDbEkv/KvRG7w6wrwohCQsL5N cPzGlfuV2+lvvDg/Ih4HXM9Togeql3niT/uNgrTVT6iZ+j/yvFjJwajfdr8wjNv52m4A swgD2OvxlNgGkUIB+qCnPE60xY1vlhPn3Rn7FODsX6Q3/X8FIZZEuOH/1jFm1cxQ6Jaq +kcQ== X-Gm-Message-State: AAQBX9e0kvg+h01hswZzhUJdYZLei6Fdb4W0jwthOz4hsrVjvM0F0/HM M4TyAkEwYGWOr/oY8HEQfHr3930G1HMYdw== X-Google-Smtp-Source: AKy350ZMZfUEoGJL+FwvF4cRRXQb4+QN5H6j8NMtvfklSbeYHKpwyAallHfLvXY2bkEuqTuNXgRIzQ== X-Received: by 2002:a17:903:2341:b0:19c:e666:a678 with SMTP id c1-20020a170903234100b0019ce666a678mr3962108plh.50.1679701788356; Fri, 24 Mar 2023 16:49:48 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id g9-20020a170902934900b0019f1205bdcbsm14683685plp.147.2023.03.24.16.49.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2023 16:49:46 -0700 (PDT) From: Yuan Fu Content-Type: multipart/mixed; boundary="Apple-Mail=_36B1A9E6-C68B-42E6-A750-6BFFD67864A6" Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Subject: 30.0.50; Add jsx faces to typescript-ts-mode Message-Id: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> Date: Fri, 24 Mar 2023 16:49:35 -0700 To: Bug Report Emacs X-Mailer: Apple Mail (2.3731.400.51.1.1) Received-SPF: pass client-ip=2607:f8b0:4864:20::631; envelope-from=casouri@gmail.com; helo=mail-pl1-x631.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.1 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.1 (-) --Apple-Mail=_36B1A9E6-C68B-42E6-A750-6BFFD67864A6 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii X-Debbugs-CC: theo@thornhill.no Hey Theo, I want to add separate faces for JSX tags and attributes. Otherwise users will be in a world of pain if they want to use different fontification for JSX tag and funcall, and JSX attribute and constant. WDYT? Yuan --Apple-Mail=_36B1A9E6-C68B-42E6-A750-6BFFD67864A6 Content-Disposition: attachment; filename=faces.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="faces.patch" Content-Transfer-Encoding: quoted-printable =46rom=206a52f34fff83908312881b9f46f07bf54597ff6f=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Yuan=20Fu=20=0ADate:=20Fri,=20= 24=20Mar=202023=2016:45:15=20-0700=0ASubject:=20[PATCH]=20Add=20two=20= typescript-ts-mode=20faces=0A=0A*=20= lisp/progmodes/typescript-ts-mode.el:=0A= (typescript-ts-mode-jsx-tag-face)=0A= (typescript-ts-mode-jsx-attribute-face):=20New=20faces.=0A= (typescript-ts-mode--font-lock-settings):=20Use=20new=20faces.=0A---=0A=20= lisp/progmodes/typescript-ts-mode.el=20|=2016=20++++++++++++----=0A=201=20= file=20changed,=2012=20insertions(+),=204=20deletions(-)=0A=0Adiff=20= --git=20a/lisp/progmodes/typescript-ts-mode.el=20= b/lisp/progmodes/typescript-ts-mode.el=0Aindex=20= a9ca85d5d35..207c3f03b88=20100644=0A---=20= a/lisp/progmodes/typescript-ts-mode.el=0A+++=20= b/lisp/progmodes/typescript-ts-mode.el=0A@@=20-41,6=20+41,14=20@@=20= typescript-ts-mode-indent-offset=0A=20=20=20:safe=20'integerp=0A=20=20=20= :group=20'typescript)=0A=20=0A+(defface=20typescript-ts-jsx-tag-face=0A+=20= =20'((t=20.=20(:inherit=20font-lock-function-call-face)))=0A+=20=20"Face=20= for=20HTML=20tags=20like=20

=20and=20

=20in=20JSX.")=0A+=0A= +(defface=20typescript-ts-jsx-attribute-face=0A+=20=20'((t=20.=20= (:inherit=20font-lock-constant-face)))=0A+=20=20"Face=20for=20HTML=20= attributes=20like=20name=20and=20id=20in=20JSX.")=0A+=0A=20(defvar=20= typescript-ts-mode--syntax-table=0A=20=20=20(let=20((table=20= (make-syntax-table)))=0A=20=20=20=20=20;;=20Taken=20from=20the=20= cc-langs=20version=0A@@=20-284,17=20+292,17=20@@=20= typescript-ts-mode--font-lock-settings=0A=20=20=20=20:feature=20'jsx=0A=20= =20=20=20`((jsx_opening_element=0A=20=20=20=20=20=20=20= [(nested_identifier=20(identifier))=20(identifier)]=0A-=20=20=20=20=20=20= @font-lock-function-call-face)=0A+=20=20=20=20=20=20= @typescript-ts-jsx-tag-face)=0A=20=0A=20=20=20=20=20=20= (jsx_closing_element=0A=20=20=20=20=20=20=20[(nested_identifier=20= (identifier))=20(identifier)]=0A-=20=20=20=20=20=20= @font-lock-function-call-face)=0A+=20=20=20=20=20=20= @typescript-ts-jsx-tag-face)=0A=20=0A=20=20=20=20=20=20= (jsx_self_closing_element=0A=20=20=20=20=20=20=20[(nested_identifier=20= (identifier))=20(identifier)]=0A-=20=20=20=20=20=20= @font-lock-function-call-face)=0A+=20=20=20=20=20=20= @typescript-ts-jsx-tag-face)=0A=20=0A-=20=20=20=20=20(jsx_attribute=20= (property_identifier)=20@font-lock-constant-face))=0A+=20=20=20=20=20= (jsx_attribute=20(property_identifier)=20= @typescript-ts-jsx-attribute-face))=0A=20=0A=20=20=20=20:language=20= language=0A=20=20=20=20:feature=20'number=0A--=20=0A2.33.1=0A=0A= --Apple-Mail=_36B1A9E6-C68B-42E6-A750-6BFFD67864A6-- ------------=_1680163982-29769-1-- From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Mar 2023 14:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Yuan Fu Cc: theo@thornhill.no, 62429@debbugs.gnu.org, monnier@iro.umontreal.ca Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.16801867003706 (code B ref 62429); Thu, 30 Mar 2023 14:32:01 +0000 Received: (at 62429) by debbugs.gnu.org; 30 Mar 2023 14:31:40 +0000 Received: from localhost ([127.0.0.1]:59172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phtJT-0000xh-Lu for submit@debbugs.gnu.org; Thu, 30 Mar 2023 10:31:40 -0400 Received: from eggs.gnu.org ([209.51.188.92]:49608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phtJR-0000xT-VG for 62429@debbugs.gnu.org; Thu, 30 Mar 2023 10:31:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phtJL-0003pC-9L; Thu, 30 Mar 2023 10:31:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=Ptz7DtPONMeiju8ato95y1Fbd4QwnXKP8phlGFWXhw0=; b=O7zVLO5co7eWnaIrndVG O54QhWDIFjJt70vEV6dReQGXaJfmtOiMolq2URAT4L8ygzOJ1v1sUmXhMrTJ5+RegDWp1DhGaqN4v 9I48MtUQWkWSpn+cunfXWtoKmiAKzsldwcs2boG/I68ZROFOex4VdmQhvoyDwaP8VVsJdsv/j0qQM Pxmopt0EbvP9kvyuPDBkcqb0RgYh8TdRD32XpXMriwn9kqpQ9Azlevif991KjlEP/PLUfb/A13y8Q yFQlDNXjb5AyO2U0QR2Stsfh0uL/cTOc5GVudrkrOMJUXl2blAYLpXKOcNPbGqKdfXOWaahtcMps6 jzxRojapC9FsVg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phtJK-0000gt-2d; Thu, 30 Mar 2023 10:31:30 -0400 Date: Thu, 30 Mar 2023 17:31:40 +0300 Message-Id: <83mt3u48fn.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Yuan Fu on Thu, 30 Mar 2023 01:11:48 -0700) References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> <837cv4b020.fsf@gnu.org> <9E07A07B-EDF4-436F-8208-01D2CCA7A7AF@gmail.com> <83wn2y6caq.fsf@gnu.org> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Yuan Fu > Date: Thu, 30 Mar 2023 01:11:48 -0700 > Cc: Stefan Monnier , > 62429-done@debbugs.gnu.org, > theodor thornhill > > >>> OK, but then how will these JSX-specific faces fit into the overall > >>> scheme of treesit-font-lock faces? For example, in what level will > >>> they be used, and how will users know what level to set to see these > >>> faces in their buffers? > >> > >> At level 3 for tsx-ts-mode, under the “jsx” feature. So they are enabled by default. Though it’s true that it’s not immediately obvious what face to customize. At the very least these faces appear in the customize group of typescript. We can add something to the docstring of the major mode, too. > >> > >>> > >>> These are the downsides of mode-specific faces, and if we think it's > >>> important enough to have them, we should resolve these issues when we > >>> install such faces. > > > > Then it is fine by me, as long as those measures you mentioned are > > taken to make sure users know how to customize font-lock with these > > faces. > > Cool. I pushed the change. Thanks, but please also tell in the doc string of the mode which font-lock level uses these special faces. From unknown Sun Jun 22 11:39:13 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62429: 30.0.50; Add jsx faces to typescript-ts-mode Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 22:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62429 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: theo@thornhill.no, 62429@debbugs.gnu.org, Stefan Monnier Received: via spool by 62429-submit@debbugs.gnu.org id=B62429.168047347517785 (code B ref 62429); Sun, 02 Apr 2023 22:12:01 +0000 Received: (at 62429) by debbugs.gnu.org; 2 Apr 2023 22:11:15 +0000 Received: from localhost ([127.0.0.1]:42917 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj5ut-0004cn-DS for submit@debbugs.gnu.org; Sun, 02 Apr 2023 18:11:15 -0400 Received: from mail-pl1-f169.google.com ([209.85.214.169]:45714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj5uq-0004cZ-Ta for 62429@debbugs.gnu.org; Sun, 02 Apr 2023 18:11:13 -0400 Received: by mail-pl1-f169.google.com with SMTP id le6so26241191plb.12 for <62429@debbugs.gnu.org>; Sun, 02 Apr 2023 15:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1680473467; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=HQzUBxZ9pGpxFBq9WgpvwKDlBeo7ax/zL3NiN4R+u/c=; b=ORzQGOryvltXsCuuOOUUdNv70kLs1jazyhZmFT10W0YR3NUO3fhmNJcsJZSIeR3tOF oN/pqpWhP7n7p7hXNC0+kIgJwSoV9VbjpWd8V8cDO/tvA9x7do05kyTD6/1fTSAbg3Uw Digri33neS3hVJKI10INPM8dBoX4SlLoyQxN63ZAApjMzy5KPSPP5gA7CCmAqbNIgovH LmaRwqzvhXZ2LppUVB+QpH/H8WP5wq6yIGlPjx7o/NG7qs8UnOt2Hzufo4IxmqAyIK6l vpg7cDNhaOgtuC395VfU9rbsWETWNtL2Fo5ta8FtA1uwcWPf7eYQnci2Hh53ruAaGDEe h7hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680473467; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HQzUBxZ9pGpxFBq9WgpvwKDlBeo7ax/zL3NiN4R+u/c=; b=2f60wrJe0Wu89dulpB2btMqW/h250/Yr7W1mBcXfSYSUyCE/wDaT5dgw0Kp3hYgSYM V+A2f4oto9iyv7qaA++EjQRiJ84NzgyCB2SkZkjo/c+GMiNSN2IfnVLyyBcze8oWA3n4 Uez/X1YT4gmqtni+VwvnXMT+o0SBypoO/FR+Ta8RK0FF+/oXFNs+ees5XiWjM07SwCUL zkrdECcD698RT6+rG4pvjHWqUEs3Erec0qTvtUvtiHnghHj/emoZFjOwHHXc4mHHVGjI s5wubnp/oR6doKNErFireXT7Hu/AhEKwJf1xFj0z+2cB12qamSocy2ODrwPer4Bklvit qyhg== X-Gm-Message-State: AAQBX9cS07gJGkWJhlPtnJWyjIX6F/wgFqu4jd9ye9DuqCGSxMDV+tTl GoZTOEYAWXmA1LWMe/Zhn4g= X-Google-Smtp-Source: AKy350ZcdfvD3i8ilqq4hz6qXSfKnvDzIejG3bDlaFRK/itabipN1MsWzEHBaU+GxziQjorMAeibjg== X-Received: by 2002:a05:6a20:8014:b0:e3:9972:6573 with SMTP id e20-20020a056a20801400b000e399726573mr15470404pza.14.1680473466996; Sun, 02 Apr 2023 15:11:06 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id a5-20020aa78645000000b00627f054a3cdsm5460092pfo.31.2023.04.02.15.11.06 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sun, 02 Apr 2023 15:11:06 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) From: Yuan Fu In-Reply-To: <83mt3u48fn.fsf@gnu.org> Date: Sun, 2 Apr 2023 15:10:55 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <326EC262-DCF5-4067-B553-E40DE3CE19C9@gmail.com> References: <79CDDA5E-421D-4760-B744-F0C661118711@gmail.com> <83lejlc8sy.fsf@gnu.org> <10D725F2-9162-4BC3-B362-1F54719C8313@gmail.com> <837cv4b020.fsf@gnu.org> <9E07A07B-EDF4-436F-8208-01D2CCA7A7AF@gmail.com> <83wn2y6caq.fsf@gnu.org> <83mt3u48fn.fsf@gnu.org> X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Mar 30, 2023, at 7:31 AM, Eli Zaretskii wrote: >=20 >> From: Yuan Fu >> Date: Thu, 30 Mar 2023 01:11:48 -0700 >> Cc: Stefan Monnier , >> 62429-done@debbugs.gnu.org, >> theodor thornhill >>=20 >>>>> OK, but then how will these JSX-specific faces fit into the = overall >>>>> scheme of treesit-font-lock faces? For example, in what level = will >>>>> they be used, and how will users know what level to set to see = these >>>>> faces in their buffers? >>>>=20 >>>> At level 3 for tsx-ts-mode, under the =E2=80=9Cjsx=E2=80=9D = feature. So they are enabled by default. Though it=E2=80=99s true that = it=E2=80=99s not immediately obvious what face to customize. At the very = least these faces appear in the customize group of typescript. We can = add something to the docstring of the major mode, too. >>>>=20 >>>>>=20 >>>>> These are the downsides of mode-specific faces, and if we think = it's >>>>> important enough to have them, we should resolve these issues when = we >>>>> install such faces. >>>=20 >>> Then it is fine by me, as long as those measures you mentioned are >>> taken to make sure users know how to customize font-lock with these >>> faces. >>=20 >> Cool. I pushed the change. >=20 > Thanks, but please also tell in the doc string of the mode which > font-lock level uses these special faces. Done. Yuan=