GNU bug report logs - #62427
tab-bar-new-tab-to now handles cases with multiple side-windows

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62427: closed (tab-bar-new-tab-to now handles cases with
 multiple side-windows)
Date: Mon, 24 Apr 2023 11:51:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Mon, 24 Apr 2023 14:50:38 +0300
with message-id <83h6t5xzw1.fsf <at> gnu.org>
and subject line Re: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows
has caused the debbugs.gnu.org bug report #62427,
regarding tab-bar-new-tab-to now handles cases with multiple side-windows
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62427: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62427
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Benson Chu <bensonchu457 <at> fastmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: tab-bar-new-tab-to now handles cases with multiple side-windows
Date: Fri, 24 Mar 2023 16:07:22 -0500

[Message part 3 (text/plain, inline)]

Hello,

I've noticed that when I call #'tab-bar-new-tab while I'm in a
side-window that has siblings, I get an error from
#'window--sides-check, which happens when #'tab-bar-new-tab calls
#'delete-other-windows. Here's an example of my problem:

(progn
  (display-buffer-in-side-window (get-buffer-create "*hello*")
                                 '((side . right)
                                   (slot . 1)))
  (select-window
   (display-buffer-in-side-window (get-buffer-create "*world*")
                                  '((side . right)
                                    (slot . 2))))
  (tab-bar-new-tab))

The attached patch fixes this issue. Could it be applied to the emacs-29
branch?

Thanks!

[0001-tab-bar-new-tab-to-now-handles-cases-with-multiple-s.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 62427-done <at> debbugs.gnu.org, bensonchu457 <at> fastmail.com
Subject: Re: bug#62427: tab-bar-new-tab-to now handles cases with multiple
 side-windows
Date: Mon, 24 Apr 2023 14:50:38 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Cc: bensonchu457 <at> fastmail.com,  62427 <at> debbugs.gnu.org
> Date: Sun, 23 Apr 2023 19:39:10 +0300
> 
> >> >> On a side-note (side-window? haha), I've got a patch that side-steps
> >> >> (hehe) the issue of modifying the 'window-side parameter completely, by
> >> >> binding to window--sides-inhibit-check to t.
> >> >
> >> > Thanks, window--sides-inhibit-check is a good find.
> >> > Let me test it for a while.
> >>
> >> I still can't find a test case that could be fixed by
> >> window--sides-inhibit-check.  Your original test case is fixed
> >> because you removed (set-window-parameter nil 'window-side nil).
> >> And the test case in bug#53662 doesn't need this line because
> >> it was fixed by adding (ignore-window-parameters t).
> >>
> >> But maybe there are cases where window--sides-inhibit-check
> >> would help, so we could add it as a precaution.
> >
> > Should I install the last patch, or should I wait for more testing?
> 
> The patch works in two known test cases, and no more tests were found,
> so probably it could be installed.

Thanks, installed on emacs-29 branch, and closing the bug.

Benson, any news on your copyright assignment?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.