GNU bug report logs - #62427
tab-bar-new-tab-to now handles cases with multiple side-windows

Previous Next

Full log

View this message in rfc822 format

From: martin rudalics <rudalics <at> gmx.at>
To: Juri Linkov <juri <at> linkov.net>
Cc: 62427 <at> debbugs.gnu.org
Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows
Date: Fri, 19 May 2023 09:31:48 +0200

> +          (when (minibufferp) (select-window (get-mru-window)))

Here and below I'd use

(when (window-minibuffer-p)

because it more clearly demonstrates the idea and also handles the
(unlikely) case where a minibuffer is shown in a normal window.

>             (window-state-put ws nil 'safe)))
>
>           ;; Select the minibuffer when it was active before switching tabs
> @@ -1575,8 +1575,7 @@ tab-bar-new-tab-to
>
>       (when tab-bar-new-tab-choice
>         ;; Handle the case when it's called in the active minibuffer.
> -      (when (minibuffer-selected-window)
> -        (select-window (minibuffer-selected-window)))
> +      (when (minibufferp) (select-window (get-mru-window)))
>         (let ((ignore-window-parameters t)
>               (window--sides-inhibit-check t))
>           (if (eq tab-bar-new-tab-choice 'clone)

You might want to try this with multiple frames (some of them without
their own minibuffer window) jumping from one frame to another within
the scope of 'read-from-minibuffer'.

martin

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.