From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Benson Chu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2023 21:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 62427@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167969238432334 (code B ref -1); Fri, 24 Mar 2023 21:14:02 +0000 Received: (at submit) by debbugs.gnu.org; 24 Mar 2023 21:13:04 +0000 Received: from localhost ([127.0.0.1]:41507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfoie-0008PR-7b for submit@debbugs.gnu.org; Fri, 24 Mar 2023 17:13:04 -0400 Received: from [209.51.188.17] (port=48440 helo=lists.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfodO-0008Eg-TC for submit@debbugs.gnu.org; Fri, 24 Mar 2023 17:07:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfodF-00047q-TN for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 17:07:29 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfodD-0005G1-HR for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 17:07:29 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D1DA23200951 for ; Fri, 24 Mar 2023 17:07:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 24 Mar 2023 17:07:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1679692043; x=1679778443; bh=Ly4i2UbH8LGttjlh6ZLuiaJBM ghkRh7XTR2M8FhAtQc=; b=Qr27Yy1pqM72gG3RNv9JeaOStEGEKkDNzd2WL8qKA 5JioHDx5Er+XwQItbWEVkprVxavhphdq023A8WtoAvW46hk7aHeridGQC4jx23pB digwO7P5ccFycb3lISbdk8mB0948W7+7KBXB7PQPfv4oKT+tyIZ3wRO+SUvLmz6N 8pr6qCfi9lH5R1UDd4Tfuq5InqCtSMfGTZ+7pR77lYI37WgaXh0OKeM1glDnlKQY TFBM0Tq+93pS+bdqV8PUgNOVcRfyFrrSiAkAxCBYdRTyLM5PRDafaBtDvPiWmAk3 cLmnRLGmHDOQo7zQDpL115+LY7N5pAkzlLQRB8+/RUigQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679692043; x=1679778443; bh=Ly4i2UbH8LGttjlh6ZLuiaJBMghkRh7XTR2 M8FhAtQc=; b=N9B/4lczQNDTMolTkmnmLDZeyF2I7MRSn+jEkNi5bGrrwoxXByy 1lD++wbSR/lEePr3IMp5wGVnRsY9hCbL0m0xaBX+7U7N8RXmW9cxIn7aRTWNHdOM UfIZ1FHvTwIapmz/hdCK7CMKcA5MXmasPmMKXbhOxB661tvCXMw2Af49gb26yKRs k4WKAC/rvIppVF2C8JqidMeF2vfl2KLJnOS5yym7UVp5VJruWc5yWEAsDtTd25Mi hT9MPmy+vCujxBIAbx3S6VIY/qZ8n0hxLNkkiqJpLEr4fYc09PyHVZFFM9G0wF6U aEao+z8mZ9oXc1tiLWJQrpBq7Sj4hobbTGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegiedgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesmhdtreertd dttdenucfhrhhomhepuegvnhhsohhnucevhhhuuceosggvnhhsohhntghhuhegheejsehf rghsthhmrghilhdrtghomheqnecuggftrfgrthhtvghrnhepkeettdejieejueegvdekhf dtuedtkefhfffghedtuddvvedvudduiedutefghfeinecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepsggvnhhsohhntghhuhegheejsehfrghsth hmrghilhdrtghomh X-ME-Proxy: Feedback-ID: id5c9466e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 24 Mar 2023 17:07:23 -0400 (EDT) From: Benson Chu Date: Fri, 24 Mar 2023 16:07:22 -0500 Message-ID: <875yapvoxh.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.147.123.25; envelope-from=bensonchu457@fastmail.com; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Mailman-Approved-At: Fri, 24 Mar 2023 17:13:02 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Hello, I've noticed that when I call #'tab-bar-new-tab while I'm in a side-window that has siblings, I get an error from #'window--sides-check, which happens when #'tab-bar-new-tab calls #'delete-other-windows. Here's an example of my problem: (progn (display-buffer-in-side-window (get-buffer-create "*hello*") '((side . right) (slot . 1))) (select-window (display-buffer-in-side-window (get-buffer-create "*world*") '((side . right) (slot . 2)))) (tab-bar-new-tab)) The attached patch fixes this issue. Could it be applied to the emacs-29 branch? Thanks! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-tab-bar-new-tab-to-now-handles-cases-with-multiple-s.patch >From cc8974b45d5726a0f6a8d9ab6566411c118a0769 Mon Sep 17 00:00:00 2001 From: Benson Chu Date: Fri, 24 Mar 2023 15:38:03 -0500 Subject: [PATCH] tab-bar-new-tab-to now handles cases with multiple side-windows Previously, calling tab-bar-new-tab-to only removes the 'window-side property on the currently selected window, and then a call to delete-other-windows was made to ensure that the selected window was the only window. However, if there are other side-windows (with the same side) present, the call to delete-other-windows will fail on the window--sides-check. This is because according to the check, all windows on the same side should have the same 'window-side, and because we only removed the 'window-side parameters on one of the windows, there will be inconsistencies with that window and its parent and siblings. Because of this, the call to delete-other-windows to fail. This patch makes sure that all windows on a given side will have 'window-side set to nil, so that the call to delete-other-windows will not fail. * lisp/tab-bar.el: remove 'window-side from selected window, window's parent, and all window's siblings. --- lisp/tab-bar.el | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index dce6fa735fc..f05abffbcdb 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1556,7 +1556,13 @@ tab-bar-new-tab-to ;; with `delete-other-windows' and `split-window'. (unless (eq tab-bar-new-tab-choice 'clone) (set-window-parameter nil 'window-atom nil) - (set-window-parameter nil 'window-side nil)) + (let ((side (window-parameter nil 'window-side))) + (when side + (walk-window-tree + (lambda (window) + (when (eq side (window-parameter window 'window-side)) + (set-window-parameter window 'window-side nil))) + nil t)))) (let ((ignore-window-parameters t)) (if (eq tab-bar-new-tab-choice 'clone) ;; Create new unique windows with the same layout -- 2.40.0 --=-=-=-- From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 19:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benson Chu Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16797718908471 (code B ref 62427); Sat, 25 Mar 2023 19:19:02 +0000 Received: (at 62427) by debbugs.gnu.org; 25 Mar 2023 19:18:10 +0000 Received: from localhost ([127.0.0.1]:43524 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9P0-0002CY-JX for submit@debbugs.gnu.org; Sat, 25 Mar 2023 15:18:10 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:57859) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9Ow-0002Bk-Ut for 62427@debbugs.gnu.org; Sat, 25 Mar 2023 15:18:07 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 984AF100004; Sat, 25 Mar 2023 19:17:59 +0000 (UTC) From: Juri Linkov In-Reply-To: <875yapvoxh.fsf@fastmail.com> (Benson Chu's message of "Fri, 24 Mar 2023 16:07:22 -0500") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> Date: Sat, 25 Mar 2023 21:14:24 +0200 Message-ID: <86jzz4mynj.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I've noticed that when I call #'tab-bar-new-tab while I'm in a > side-window that has siblings, I get an error from > #'window--sides-check, which happens when #'tab-bar-new-tab calls > #'delete-other-windows. Here's an example of my problem: > ... > The attached patch fixes this issue. Could it be applied to the emacs-29 > branch? Thanks. Unless Eli has objections, I'd like to push the patch to the emacs-29 branch since it correctly fixes the problem. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 04:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.167980436230237 (code B ref 62427); Sun, 26 Mar 2023 04:20:02 +0000 Received: (at 62427) by debbugs.gnu.org; 26 Mar 2023 04:19:22 +0000 Received: from localhost ([127.0.0.1]:43784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgHqj-0007rd-Ub for submit@debbugs.gnu.org; Sun, 26 Mar 2023 00:19:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34492) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgHqi-0007rR-4Y for 62427@debbugs.gnu.org; Sun, 26 Mar 2023 00:19:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgHqb-0004Cy-P4; Sun, 26 Mar 2023 00:19:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jVKe6uUhyxgM9FLlEnIA33/cYWOnk5G0k60QmzgVoYY=; b=BoFdVVKgRWh1 zAWe0ODmpdekYBewpmqFWPa9PfdVwk7j6PYX9I3wY4IPWLXhcuBEb48jI73j/WJVbfaD/9jlg+RzM CMe27WTn+fmIJtb/4fKKPQ69RKFQqJQ4SQB4FKj8DcsdjxThn0BCEBPs0b0TZz6zbNxcp4GRIqKFH vguw+ai9Rva2pA0sfiLj71fMypX47ZI5Rgd36upR0NyrTLPeVLSUDVWPaGS2qOQxcJU+HBIhYCD+U WQZtF+AFOztAVC/g+UM6WkhZHEFQ/KsMhzXklyX3fCgGjVzuSEisaTb6EsMkj+HPnUa9DkaXgKE32 MVg3Kw6gpSJpCi5ka30Pbw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgHqa-0003zd-Rk; Sun, 26 Mar 2023 00:19:13 -0400 Date: Sun, 26 Mar 2023 07:19:12 +0300 Message-Id: <83cz4wb0vz.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86jzz4mynj.fsf@mail.linkov.net> (message from Juri Linkov on Sat, 25 Mar 2023 21:14:24 +0200) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 62427@debbugs.gnu.org > From: Juri Linkov > Date: Sat, 25 Mar 2023 21:14:24 +0200 > > > I've noticed that when I call #'tab-bar-new-tab while I'm in a > > side-window that has siblings, I get an error from > > #'window--sides-check, which happens when #'tab-bar-new-tab calls > > #'delete-other-windows. Here's an example of my problem: > > ... > > The attached patch fixes this issue. Could it be applied to the emacs-29 > > branch? > > Thanks. Unless Eli has objections, I'd like to push the patch > to the emacs-29 branch since it correctly fixes the problem. I'd like first to understand better the code involved and the suggested change in it. Just reading the code of tab-bar-new-tab-to, it looks strange. Why does tab-bar.el care about "window parameters that can cause problems with 'delete-other-windows' and 'split-window'" to begin with? And why removing these parameters from windows is TRT for tab-bar.el to resolve such problems, when it doesn't really "own" those windows? (Also, the patch's commit log message is not according to our conventions, but that's a minor issue.) From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 07:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16799009043514 (code B ref 62427); Mon, 27 Mar 2023 07:09:01 +0000 Received: (at 62427) by debbugs.gnu.org; 27 Mar 2023 07:08:24 +0000 Received: from localhost ([127.0.0.1]:46360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pggxr-0000ub-LC for submit@debbugs.gnu.org; Mon, 27 Mar 2023 03:08:24 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:38973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pggxp-0000uB-Rp for 62427@debbugs.gnu.org; Mon, 27 Mar 2023 03:08:22 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id BCA1CC0005; Mon, 27 Mar 2023 07:08:14 +0000 (UTC) From: Juri Linkov In-Reply-To: <83cz4wb0vz.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 26 Mar 2023 07:19:12 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> Date: Mon, 27 Mar 2023 10:05:40 +0300 Message-ID: <865yamhdx7.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> > I've noticed that when I call #'tab-bar-new-tab while I'm in a >> > side-window that has siblings, I get an error from >> > #'window--sides-check, which happens when #'tab-bar-new-tab calls >> > #'delete-other-windows. Here's an example of my problem: >> > ... >> > The attached patch fixes this issue. Could it be applied to the emacs-29 >> > branch? >> >> Thanks. Unless Eli has objections, I'd like to push the patch >> to the emacs-29 branch since it correctly fixes the problem. > > I'd like first to understand better the code involved and the > suggested change in it. Just reading the code of tab-bar-new-tab-to, > it looks strange. Why does tab-bar.el care about "window parameters > that can cause problems with 'delete-other-windows' and > 'split-window'" to begin with? And why removing these parameters from > windows is TRT for tab-bar.el to resolve such problems, when it > doesn't really "own" those windows? Indeed, maybe 'delete-other-windows' and `split-window' should handle these cases. So since the patch fixes the bug, it could be pushed to emacs-29. Then in master 'delete-other-windows' and `split-window' could be rewritten to handle the 'window-side' parameter. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 13:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.167992421522821 (code B ref 62427); Mon, 27 Mar 2023 13:37:01 +0000 Received: (at 62427) by debbugs.gnu.org; 27 Mar 2023 13:36:55 +0000 Received: from localhost ([127.0.0.1]:46841 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgn1q-0005w0-Vr for submit@debbugs.gnu.org; Mon, 27 Mar 2023 09:36:55 -0400 Received: from eggs.gnu.org ([209.51.188.92]:43944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgn1p-0005vl-HM for 62427@debbugs.gnu.org; Mon, 27 Mar 2023 09:36:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgn1j-00079H-KA; Mon, 27 Mar 2023 09:36:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FpSDMVSqdyDmFmqwUq2mbJhH04kGfHZwRc4RlDu1ZuM=; b=JM4luXWzSbR9 vQqr/Tc0WNbuZvZrElJXeVLP0wSvmKjXrcipRJpnQxNPl4+MBJ9t5jUY2dZKcAYd3Sug4tlYbiqMd 4vaUskjMmdV288OLgnCXZFEJMrgABha9JQP9DQ1ih60JHP+wODI3K6RTPIiIxR3t5AxkpYmaUih7C n6B6Z5afTzgnWeyFcW6AC8s3yTzOTc0f3JApklrIjX42BFVAhAWxtf8KvSMff8m1iMwdADV3ZMsfX YDcUaj1J8d981HIkSDKtae63pF3h4APJD2Fh7XINe9B20zSRB0Wb9Uy+EjA3G3a/dpf7XaWxfMWUu ybe66IOAl5dXBAzyoc/Jrg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgn1i-0003Yt-TI; Mon, 27 Mar 2023 09:36:47 -0400 Date: Mon, 27 Mar 2023 16:36:50 +0300 Message-Id: <83cz4u9uz1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <865yamhdx7.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 27 Mar 2023 10:05:40 +0300) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: bensonchu457@fastmail.com, 62427@debbugs.gnu.org > Date: Mon, 27 Mar 2023 10:05:40 +0300 > > >> > I've noticed that when I call #'tab-bar-new-tab while I'm in a > >> > side-window that has siblings, I get an error from > >> > #'window--sides-check, which happens when #'tab-bar-new-tab calls > >> > #'delete-other-windows. Here's an example of my problem: > >> > ... > >> > The attached patch fixes this issue. Could it be applied to the emacs-29 > >> > branch? > >> > >> Thanks. Unless Eli has objections, I'd like to push the patch > >> to the emacs-29 branch since it correctly fixes the problem. > > > > I'd like first to understand better the code involved and the > > suggested change in it. Just reading the code of tab-bar-new-tab-to, > > it looks strange. Why does tab-bar.el care about "window parameters > > that can cause problems with 'delete-other-windows' and > > 'split-window'" to begin with? And why removing these parameters from > > windows is TRT for tab-bar.el to resolve such problems, when it > > doesn't really "own" those windows? > > Indeed, maybe 'delete-other-windows' and `split-window' > should handle these cases. So since the patch fixes the bug, > it could be pushed to emacs-29. Then in master > 'delete-other-windows' and `split-window' could be rewritten > to handle the 'window-side' parameter. Maybe I'll agree, but I still don't understand the problem well enough. Would you please explain the original problem that led tab-bar.el to care about these window parameters? TIA From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 16:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.167993529716744 (code B ref 62427); Mon, 27 Mar 2023 16:42:02 +0000 Received: (at 62427) by debbugs.gnu.org; 27 Mar 2023 16:41:37 +0000 Received: from localhost ([127.0.0.1]:48318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgpub-0004Lz-52 for submit@debbugs.gnu.org; Mon, 27 Mar 2023 12:41:37 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:53545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgpuW-0004LT-Jy for 62427@debbugs.gnu.org; Mon, 27 Mar 2023 12:41:32 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6D86220005; Mon, 27 Mar 2023 16:41:24 +0000 (UTC) From: Juri Linkov In-Reply-To: <83cz4u9uz1.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 27 Mar 2023 16:36:50 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> Date: Mon, 27 Mar 2023 19:39:25 +0300 Message-ID: <86jzz2f8si.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> >> > I've noticed that when I call #'tab-bar-new-tab while I'm in a >> >> > side-window that has siblings, I get an error from >> >> > #'window--sides-check, which happens when #'tab-bar-new-tab calls >> >> > #'delete-other-windows. Here's an example of my problem: >> >> > ... >> >> > The attached patch fixes this issue. Could it be applied to the emacs-29 >> >> > branch? >> >> >> >> Thanks. Unless Eli has objections, I'd like to push the patch >> >> to the emacs-29 branch since it correctly fixes the problem. >> > >> > I'd like first to understand better the code involved and the >> > suggested change in it. Just reading the code of tab-bar-new-tab-to, >> > it looks strange. Why does tab-bar.el care about "window parameters >> > that can cause problems with 'delete-other-windows' and >> > 'split-window'" to begin with? And why removing these parameters from >> > windows is TRT for tab-bar.el to resolve such problems, when it >> > doesn't really "own" those windows? >> >> Indeed, maybe 'delete-other-windows' and `split-window' >> should handle these cases. So since the patch fixes the bug, >> it could be pushed to emacs-29. Then in master >> 'delete-other-windows' and `split-window' could be rewritten >> to handle the 'window-side' parameter. > > Maybe I'll agree, but I still don't understand the problem well > enough. Would you please explain the original problem that led > tab-bar.el to care about these window parameters? Sorry, I can't explain. I just did that Martin said to do in bug#53662. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 17:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.167993680220203 (code B ref 62427); Mon, 27 Mar 2023 17:07:02 +0000 Received: (at 62427) by debbugs.gnu.org; 27 Mar 2023 17:06:42 +0000 Received: from localhost ([127.0.0.1]:48354 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgqIr-0005Fn-Rv for submit@debbugs.gnu.org; Mon, 27 Mar 2023 13:06:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50186) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgqIq-0005FS-Gp for 62427@debbugs.gnu.org; Mon, 27 Mar 2023 13:06:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgqIk-0005We-E9; Mon, 27 Mar 2023 13:06:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=Pz5CSeoibd5yvJCkDk08kHAto2p0HpJJAh+0680vF4Q=; b=DibERK38SmVE xs5FOigd2oCb+wRiNbbE9TxAmp7ulvF6aFyz5CngZAz76QZ2NNOOLAcdCg6KbD3tlUuJ4VZRKlNLu EoqQnEnVoSHouYlGPc6odqQMtEEerf0pawMbFT8gr3Zdd9NEOWgvgGMqcZI9Ax090m3syD3CCA33J BsbXXgIHmZtu3+vbwKMkT1SoHxjOFw+a/uzpc0S3FUcISj1en6pdfsDYTIJ/3TDP+8x0tczvmD7fb WDK+s2uejJC+GgNKi2CFjrlw/I4O5NoLbaK9JbvhLLV9lAWZOHa0qo6FDn0V3bxA/v8KzX51psOuB LuBaYCrGpRUpp2Lkm5n0kw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgqIP-0007MN-Tz; Mon, 27 Mar 2023 13:06:33 -0400 Date: Mon, 27 Mar 2023 20:06:17 +0300 Message-Id: <83sfdq86pi.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86jzz2f8si.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 27 Mar 2023 19:39:25 +0300) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: bensonchu457@fastmail.com, 62427@debbugs.gnu.org > Date: Mon, 27 Mar 2023 19:39:25 +0300 > > > Maybe I'll agree, but I still don't understand the problem well > > enough. Would you please explain the original problem that led > > tab-bar.el to care about these window parameters? > > Sorry, I can't explain. I just did that Martin said to do > in bug#53662. That's okay, Benson Chu explained it. Let me think about this. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: "Benson Chu" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 17:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Eli Zaretskii" , "Juri Linkov" Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.167993904724099 (code B ref 62427); Mon, 27 Mar 2023 17:45:02 +0000 Received: (at 62427) by debbugs.gnu.org; 27 Mar 2023 17:44:07 +0000 Received: from localhost ([127.0.0.1]:48387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgqt4-0006Gc-TN for submit@debbugs.gnu.org; Mon, 27 Mar 2023 13:44:07 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:47455) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgqt2-0006Fy-Px for 62427@debbugs.gnu.org; Mon, 27 Mar 2023 13:44:05 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 1D7283200958; Mon, 27 Mar 2023 13:43:58 -0400 (EDT) Received: from imap44 ([10.202.2.94]) by compute5.internal (MEProxy); Mon, 27 Mar 2023 13:43:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1679939037; x=1680025437; bh=jI +7uwNSt3r8wbOKtF7UBv6A+Dp3ChXOSJHKb3nGbi4=; b=ouFX+dn6M9+9z6O8O7 HMPoabFUKWrUBmLXYjAQVLb9FZ2VPOcT9Cw3Ktxi0xIyWMYv7DNzr1c621diG01K qGbBzH6BlFIwEn0wN9WXhNuwrELlMF1J/iSELgT2NnNOlBioT0Rjb3EpJoROgxz5 mDFNzHLhQikunHcRfeyzp/KT2Jn3PO3TdI8/8MJsOXnsSXxg9yS3Wt9NFfzBUkag s9QnVIEIi7vhIu8a38mNn15o5FZXMP2IlRpBRq2UvSFtV2tkCxkaP8xuUr69EtuZ npvIBkvYMiSzyKpVU1Tn28vryBFaXlOMaV9AfdywEdyXEL8hcDRehVcutMxlL+IR Xe6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1679939037; x=1680025437; bh=jI+7uwNSt3r8w bOKtF7UBv6A+Dp3ChXOSJHKb3nGbi4=; b=BvSrg+vqwUUAIU4s/awPKtOeYnQtM 1OpBr09fHdW0JC3vT3yUGaacHqi2sLkfChbrDgNWFBHFR44IlhKtAJR24ulsNxNv p2A4K6Xf+KDPVoAvfbHwh1oOhwGpBGi+TF4wQwIf1XtwWEPQHiN8790Vo/3wtgDm t9711IRu845WifpWGtU20V0q1bpJ/LNeurb6I468TeBRNwKoTjvgV60hXL1LLhUQ tDV7tLHjKF6u9R6GD7wbROeI4M5avMRfzCoLN1oqUaZallQJnakoLikvj6iQ2aRQ KAyETIWqx7VulD34bfj4GEYRd8JwG4+1+VtVNgh1SwgBR8ZZHUhXMqR+A== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehvddguddukecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefofgggkfgjfhffhffvvefutgesmhdtreerreertdenucfhrhhomhepfdeu vghnshhonhcuvehhuhdfuceosggvnhhsohhntghhuhegheejsehfrghsthhmrghilhdrtg homheqnecuggftrfgrthhtvghrnhepkeefffethfeikedvhffhvdfhtdefgeehgfdvheet keetvdevgefhhefgueelfffgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpe hmrghilhhfrhhomhepsggvnhhsohhntghhuhegheejsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: id5c9466e:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id A90CB36A0076; Mon, 27 Mar 2023 13:43:56 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-236-g06c0f70e43-fm-20230313.001-g06c0f70e Mime-Version: 1.0 Message-Id: In-Reply-To: <83sfdq86pi.fsf@gnu.org> References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> Date: Mon, 27 Mar 2023 12:43:31 -0500 From: "Benson Chu" Content-Type: multipart/mixed; boundary=df534513f5a34904b7b154017d119737 X-Spam-Score: -0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.5 (-) --df534513f5a34904b7b154017d119737 Content-Type: text/plain Oops, I only replied to Eli. I'll send my explanation, and new patch. > When the variable tab-bar-new-tab-choice is set to t, the intended > behavior is to create a new tab with a single window, and that single > window displaying the current buffer of the currently selected window, > and the new window should have a fresh set of window parameters. > Typically, this is done by first calling delete-other-windows, so the > currently selected window is the only window. The call to > delete-other-windows also ignores window-parameters, so even windows > that have the no-delete-other-windows parameter still get deleted. Then, > the current window is split, to create a fresh new window with fresh > window parameters, and then delete-window is called to delete the > currently selected window. > This strategy doesn't work when the current window is a side-window, > because delete-other-windows has a check which says that a side-window > cannot be the only window in a frame. So, to work around this, we just > remove the window-side parameter beforehand, so the above strategy still > works. > Another way we could do this was to get the current-buffer, then delete > all side-windows. After deleting all side-windows, we know the current > selected window is NOT a side-window, and then we can call > delete-other-windows, split-window, and delete-window. On Mon, Mar 27, 2023, at 12:06 PM, Eli Zaretskii wrote: >> From: Juri Linkov >> Cc: bensonchu457@fastmail.com, 62427@debbugs.gnu.org >> Date: Mon, 27 Mar 2023 19:39:25 +0300 >> >> > Maybe I'll agree, but I still don't understand the problem well >> > enough. Would you please explain the original problem that led >> > tab-bar.el to care about these window parameters? >> >> Sorry, I can't explain. I just did that Martin said to do >> in bug#53662. > > That's okay, Benson Chu explained it. > > Let me think about this. --df534513f5a34904b7b154017d119737 Content-Disposition: attachment; filename*0="0001-tab-bar-new-tab-now-handles-multiple-side-windows.patch" Content-Type: text/x-patch; name="=?UTF-8?Q?0001-tab-bar-new-tab-now-handles-multiple-side-windows.patch?=" Content-Transfer-Encoding: BASE64 RnJvbSA5NTk2ZmU0N2Y4OTljNzc1NjdmNDA1MTk5MGFkZDdhMzFjODcxOGFhIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBCZW5zb24gQ2h1IDxiZW5zb25jaHU0NTdAZ21haWwu Y29tPgpEYXRlOiBGcmksIDI0IE1hciAyMDIzIDE1OjM4OjAzIC0wNTAwClN1YmplY3Q6IFtQ QVRDSF0gOyB0YWItYmFyLW5ldy10YWIgbm93IGhhbmRsZXMgbXVsdGlwbGUgc2lkZS13aW5k b3dzCgo7IFByZXZpb3VzbHksIGNhbGxpbmcgdGFiLWJhci1uZXctdGFiLXRvIG9ubHkgcmVt b3ZlcyB0aGUgJ3dpbmRvdy1zaWRlCjsgcHJvcGVydHkgb24gdGhlIGN1cnJlbnRseSBzZWxl Y3RlZCB3aW5kb3csIGFuZCB0aGVuIGEgY2FsbCB0bwo7IGRlbGV0ZS1vdGhlci13aW5kb3dz IHdhcyBtYWRlIHRvIGVuc3VyZSB0aGF0IHRoZSBzZWxlY3RlZCB3aW5kb3cgd2FzCjsgdGhl IG9ubHkgd2luZG93LgoKOyBIb3dldmVyLCBpZiB0aGVyZSBhcmUgb3RoZXIgc2lkZS13aW5k b3dzICh3aXRoIHRoZSBzYW1lIHNpZGUpCjsgcHJlc2VudCwgdGhlIGNhbGwgdG8gZGVsZXRl LW90aGVyLXdpbmRvd3Mgd2lsbCBmYWlsIG9uIHRoZQo7IHdpbmRvdy0tc2lkZXMtY2hlY2su IFRoaXMgaXMgYmVjYXVzZSBhY2NvcmRpbmcgdG8gdGhlIGNoZWNrLCBhbGwKOyB3aW5kb3dz IG9uIHRoZSBzYW1lIHNpZGUgc2hvdWxkIGhhdmUgdGhlIHNhbWUgJ3dpbmRvdy1zaWRlLCBh bmQKOyBiZWNhdXNlIHdlIG9ubHkgcmVtb3ZlZCB0aGUgJ3dpbmRvdy1zaWRlIHBhcmFtZXRl cnMgb24gb25lIG9mIHRoZQo7IHdpbmRvd3MsIHRoZXJlIHdpbGwgYmUgaW5jb25zaXN0ZW5j aWVzIHdpdGggdGhhdCB3aW5kb3cgYW5kIGl0cwo7IHBhcmVudCBhbmQgc2libGluZ3MuIEJl Y2F1c2Ugb2YgdGhpcywgdGhlIGNhbGwgdG8KOyBkZWxldGUtb3RoZXItd2luZG93cyB0byBm YWlsLgoKOyBUaGlzIHBhdGNoIG1ha2VzIHN1cmUgdGhhdCBhbGwgd2luZG93cyBvbiBhIGdp dmVuIHNpZGUgd2lsbCBoYXZlCjsgJ3dpbmRvdy1zaWRlIHNldCB0byBuaWwsIHNvIHRoYXQg dGhlIGNhbGwgdG8gZGVsZXRlLW90aGVyLXdpbmRvd3MKOyB3aWxsIG5vdCBmYWlsLgoKKiBs aXNwL3RhYi1iYXIuZWwgKHRhYi1iYXItbmV3LXRhYi10byk6IHJlbW92ZSAnd2luZG93LXNp ZGUKZnJvbSBzZWxlY3RlZCB3aW5kb3csIHdpbmRvdydzIHBhcmVudCwgYW5kIGFsbCB3aW5k b3cncwpzaWJsaW5ncy4KCkNvcHlyaWdodC1wYXBlcndvcmstZXhlbXB0OiB5ZXMKLS0tCiBs aXNwL3RhYi1iYXIuZWwgfCA4ICsrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgNyBpbnNlcnRp b25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC90YWItYmFyLmVsIGIv bGlzcC90YWItYmFyLmVsCmluZGV4IGRjZTZmYTczNWZjLi5mMDVhYmZmYmNkYiAxMDA2NDQK LS0tIGEvbGlzcC90YWItYmFyLmVsCisrKyBiL2xpc3AvdGFiLWJhci5lbApAQCAtMTU1Niw3 ICsxNTU2LDEzIEBAIHRhYi1iYXItbmV3LXRhYi10bwogICAgICAgOzsgd2l0aCBgZGVsZXRl LW90aGVyLXdpbmRvd3MnIGFuZCBgc3BsaXQtd2luZG93Jy4KICAgICAgICh1bmxlc3MgKGVx IHRhYi1iYXItbmV3LXRhYi1jaG9pY2UgJ2Nsb25lKQogICAgICAgICAoc2V0LXdpbmRvdy1w YXJhbWV0ZXIgbmlsICd3aW5kb3ctYXRvbSBuaWwpCi0gICAgICAgIChzZXQtd2luZG93LXBh cmFtZXRlciBuaWwgJ3dpbmRvdy1zaWRlIG5pbCkpCisgICAgICAgIChsZXQgKChzaWRlICh3 aW5kb3ctcGFyYW1ldGVyIG5pbCAnd2luZG93LXNpZGUpKSkKKyAgICAgICAgICAod2hlbiBz aWRlCisgICAgICAgICAgICAod2Fsay13aW5kb3ctdHJlZQorICAgICAgICAgICAgIChsYW1i ZGEgKHdpbmRvdykKKyAgICAgICAgICAgICAgICh3aGVuIChlcSBzaWRlICh3aW5kb3ctcGFy YW1ldGVyIHdpbmRvdyAnd2luZG93LXNpZGUpKQorICAgICAgICAgICAgICAgICAoc2V0LXdp bmRvdy1wYXJhbWV0ZXIgd2luZG93ICd3aW5kb3ctc2lkZSBuaWwpKSkKKyAgICAgICAgICAg ICBuaWwgdCkpKSkKICAgICAgIChsZXQgKChpZ25vcmUtd2luZG93LXBhcmFtZXRlcnMgdCkp CiAgICAgICAgIChpZiAoZXEgdGFiLWJhci1uZXctdGFiLWNob2ljZSAnY2xvbmUpCiAgICAg ICAgICAgICA7OyBDcmVhdGUgbmV3IHVuaXF1ZSB3aW5kb3dzIHdpdGggdGhlIHNhbWUgbGF5 b3V0Ci0tIAoyLjQwLjAKCg== --df534513f5a34904b7b154017d119737-- From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2023 12:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Benson Chu" Cc: 62427@debbugs.gnu.org, juri@linkov.net Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168000736630333 (code B ref 62427); Tue, 28 Mar 2023 12:43:01 +0000 Received: (at 62427) by debbugs.gnu.org; 28 Mar 2023 12:42:46 +0000 Received: from localhost ([127.0.0.1]:49141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph8ez-0007tA-TD for submit@debbugs.gnu.org; Tue, 28 Mar 2023 08:42:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ph8ex-0007sw-E4 for 62427@debbugs.gnu.org; Tue, 28 Mar 2023 08:42:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph8er-0007CU-9p; Tue, 28 Mar 2023 08:42:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=KjWKXvTJbg6V63LaNdFEFE25hCpkIxs0rgZDuGRTDDQ=; b=qOnkLgN8M97J TYrs3m7akrWZK4ss7DhWspR/f5YbWYT8Ed/ei1UlSh3tpMglBaSjJdA0cC5W2Aenm+nYg4txeXDkN 2shwZalzsjj5507o/tTJTBLiBc5AflHmUjGLqUfOwzGT6D1A8Qhb49LOc8z5p0pPnEOEpAUhoJC6R UR4NPXGo6pNoYq9vRVF/IKboqs/7vlRh9q534THfApQEQfqipsgFZVdKUmDuA0EroPOo8IyWP5eGH /mho4PMWxwkh30bVtUq5ygeYHaN+1cYwPCr8/2exF0ao0zAssCUENwZReGWPqooVEESKs9mAcWvjA ndc1wO2enQOHAdav4r3Azw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ph8eq-000395-5h; Tue, 28 Mar 2023 08:42:36 -0400 Date: Tue, 28 Mar 2023 15:42:41 +0300 Message-Id: <835yal82ta.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (bensonchu457@fastmail.com) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 27 Mar 2023 12:43:31 -0500 > From: "Benson Chu" > Cc: 62427@debbugs.gnu.org > > > When the variable tab-bar-new-tab-choice is set to t, the intended > > behavior is to create a new tab with a single window, and that single > > window displaying the current buffer of the currently selected window, > > and the new window should have a fresh set of window parameters. > > > Typically, this is done by first calling delete-other-windows, so the > > currently selected window is the only window. The call to > > delete-other-windows also ignores window-parameters, so even windows > > that have the no-delete-other-windows parameter still get deleted. Then, > > the current window is split, to create a fresh new window with fresh > > window parameters, and then delete-window is called to delete the > > currently selected window. > > > This strategy doesn't work when the current window is a side-window, > > because delete-other-windows has a check which says that a side-window > > cannot be the only window in a frame. So, to work around this, we just > > remove the window-side parameter beforehand, so the above strategy still > > works. > > > Another way we could do this was to get the current-buffer, then delete > > all side-windows. After deleting all side-windows, we know the current > > selected window is NOT a side-window, and then we can call > > delete-other-windows, split-window, and delete-window. > > On Mon, Mar 27, 2023, at 12:06 PM, Eli Zaretskii wrote: > >> From: Juri Linkov > >> Cc: bensonchu457@fastmail.com, 62427@debbugs.gnu.org > >> Date: Mon, 27 Mar 2023 19:39:25 +0300 > >> > >> > Maybe I'll agree, but I still don't understand the problem well > >> > enough. Would you please explain the original problem that led > >> > tab-bar.el to care about these window parameters? > >> > >> Sorry, I can't explain. I just did that Martin said to do > >> in bug#53662. > > > > That's okay, Benson Chu explained it. > > > > Let me think about this. After thinking about this, I'm very uncomfortable with removing window parameters like that. These windows don't belong to us, right? They are windows that just happen to be there when the user creates a new tab. So arbitrary removal of their parameters behind the back of the user and possibly some Lisp program which set these parameters is not TRT. Can't we create a completely new window and show the buffer in it? That new window then can have any parameters we want, since it's new. Or am I missing something? From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Benson Chu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2023 16:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org, juri@linkov.net Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168002126423480 (code B ref 62427); Tue, 28 Mar 2023 16:35:02 +0000 Received: (at 62427) by debbugs.gnu.org; 28 Mar 2023 16:34:24 +0000 Received: from localhost ([127.0.0.1]:50585 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phCHA-00066e-1v for submit@debbugs.gnu.org; Tue, 28 Mar 2023 12:34:24 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:42029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phCH8-00066R-GA for 62427@debbugs.gnu.org; Tue, 28 Mar 2023 12:34:23 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 7B4055C01C7; Tue, 28 Mar 2023 12:34:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 28 Mar 2023 12:34:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680021256; x=1680107656; bh=0J G92sLsgLedOiQ9+jB2kcYMxpwhaK5HlXlmgXWVVMs=; b=FK6pGpEF4oSZv2FfSK jXQsakgDCOGBNBMXfHRsr/rf4OSL/X0occzPsavntkaEebq7RvM8QtUnMa7VXwsw gDPkDDPbkzcOQe4CdoOwlQBujN45bVjq0mcGWaF+ysxVpDPEC3eHcz5qpxrsrL7J boa61C6sX+wNoLfxLnuAKLnzPkYqZJ07B4g7UQpzkxah2ijRDwb+S9BIky1d/OKR s4rcFYTCdqBzuPZ/ehKNUiW2rpl45qdc9b4RhrUUxnJzzJB0bojcMYSi4Em487Ya nGBu66QZcaQNaa0gzR1aV5k7xSkDzuNLO8HzE5j3PWHHQZbcW975sA+NPQOQncdJ 9IlQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680021256; x=1680107656; bh=0JG92sLsgLedO iQ9+jB2kcYMxpwhaK5HlXlmgXWVVMs=; b=ZpjiLs1CTueFG2EtgjDSjLSUluvhk cUBXw/mOhnS3ViOxbWsx0pKpfQfdjg4sOjgXfrf2cNrC+1bakKcwZrp7TCeFo5L/ JEy+OMzuUwQNGF7ilTZaWa5POOpofLSdoRB894qmeKNVoHfojIvBiopHdTDOEVCL iDVBDIOICfih0wnHNqnw9ejmI68r6NV6f8vMcmqfwegu96Gk37ACwyaQNdV+Lgrr 7OtGq0PtJCckuXCzbSQoukPMJcfPCnBtzXi97iDMNl1hqzXgv0+BtkHXx8S/r/q0 INZfOXqcLMXBPV9tclGGi1cJl67qEdB6pPP5IPaiJ2Jp2ZcrkQgelVELQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehgedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpeeuvghn shhonhcuvehhuhcuoegsvghnshhonhgthhhugeehjeesfhgrshhtmhgrihhlrdgtohhmqe enucggtffrrghtthgvrhhnpeffteeffeeuieffgfffteevieduhffhgeduudehudeuleet ledtvdegleeljeehleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegsvghnshhonhgthhhugeehjeesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: id5c9466e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Mar 2023 12:34:14 -0400 (EDT) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Benson Chu Date: Tue, 28 Mar 2023 11:17:29 -0500 In-reply-to: <835yal82ta.fsf@gnu.org> Message-ID: <87a5zwzvga.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) > Can't we create a completely new window and show the buffer in it? I'm not sure how easy this is. Typically new windows come from calls to #'split-window, and you can't do that for a side-window. > I'm very uncomfortable with removing window > parameters like that. These windows don't belong to us, right? Let me know if this is wrong, but I am interpreting this statement as: "We shouldn't be modifying the window parameters of the windows that belong to the old tab." Because if that's the case, we're not /really/ modifying the old tab's window-parameters. They're only "removed" "temporarily", for the purposes of creating the new tab. You can see right before we modify any window parameters, we make a call to (tab-bar--tab), which returns a tab data structure, which contain a representation of the current wconf (window configuration) - effectively saving the wconf - including the paramaters. It's kind of like a save excursion: (let ((old-tab-num (tab-bar--current-tab-index tabs)) (old-window-configuration (tab-bar--tab))) ;; modify window-parameters ;; do appropriate splitting ;; Now we have the window layout for the new tab ;; The old tab should have the old-window-configuration (setf (nth old-tab-num tabs) old-window-configuration) ;; The rest of the function ) Maybe this function would read better if the (setf ...) came first. So, we capture the current window configuration at the start of the function, transition the current window configuration into the window configuration for the new tab (which involves mangling window parameters and destroying windows), then we make sure that the old tab has an unmodified window-configuration. When the user switches back to the tab they left, all the window-parameters are still present, untouched. Are you still uncomfortable with doing things this way? Eli Zaretskii writes: >> Date: Mon, 27 Mar 2023 12:43:31 -0500 >> From: "Benson Chu" >> Cc: 62427@debbugs.gnu.org >> >> > When the variable tab-bar-new-tab-choice is set to t, the intended >> > behavior is to create a new tab with a single window, and that single >> > window displaying the current buffer of the currently selected window, >> > and the new window should have a fresh set of window parameters. >> >> > Typically, this is done by first calling delete-other-windows, so the >> > currently selected window is the only window. The call to >> > delete-other-windows also ignores window-parameters, so even windows >> > that have the no-delete-other-windows parameter still get deleted. Then, >> > the current window is split, to create a fresh new window with fresh >> > window parameters, and then delete-window is called to delete the >> > currently selected window. >> >> > This strategy doesn't work when the current window is a side-window, >> > because delete-other-windows has a check which says that a side-window >> > cannot be the only window in a frame. So, to work around this, we just >> > remove the window-side parameter beforehand, so the above strategy still >> > works. >> >> > Another way we could do this was to get the current-buffer, then delete >> > all side-windows. After deleting all side-windows, we know the current >> > selected window is NOT a side-window, and then we can call >> > delete-other-windows, split-window, and delete-window. >> >> On Mon, Mar 27, 2023, at 12:06 PM, Eli Zaretskii wrote: >> >> From: Juri Linkov >> >> Cc: bensonchu457@fastmail.com, 62427@debbugs.gnu.org >> >> Date: Mon, 27 Mar 2023 19:39:25 +0300 >> >> >> >> > Maybe I'll agree, but I still don't understand the problem well >> >> > enough. Would you please explain the original problem that led >> >> > tab-bar.el to care about these window parameters? >> >> >> >> Sorry, I can't explain. I just did that Martin said to do >> >> in bug#53662. >> > >> > That's okay, Benson Chu explained it. >> > >> > Let me think about this. > > After thinking about this, I'm very uncomfortable with removing window > parameters like that. These windows don't belong to us, right? They > are windows that just happen to be there when the user creates a new > tab. So arbitrary removal of their parameters behind the back of the > user and possibly some Lisp program which set these parameters is not > TRT. > > Can't we create a completely new window and show the buffer in it? > That new window then can have any parameters we want, since it's new. > > Or am I missing something? From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2023 17:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benson Chu Cc: 62427@debbugs.gnu.org, juri@linkov.net Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16800234774114 (code B ref 62427); Tue, 28 Mar 2023 17:12:02 +0000 Received: (at 62427) by debbugs.gnu.org; 28 Mar 2023 17:11:17 +0000 Received: from localhost ([127.0.0.1]:50637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phCqq-00014I-PH for submit@debbugs.gnu.org; Tue, 28 Mar 2023 13:11:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:58292) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phCqo-000144-Ju for 62427@debbugs.gnu.org; Tue, 28 Mar 2023 13:11:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phCqi-0002W5-2Y; Tue, 28 Mar 2023 13:11:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=FUZEmEc4tgISthY0c3FWTVLaeCNihXNLibe/wf2XsLk=; b=HOoOrSM7ZCZL Alpcq+MLv2t0ce/uVSJKLSH97A1xaEdGfyXsprSblIT1W69rJHCbj0Rp7fdXkQfXe4CsYj9ANDyDP xzFkg9Xa5ToInTjzhVrRo+BaYmxeWzeuFHMCY+2mpXMHQy9gb07P2YzpT+KjcUc95Ou+DP24pEbY/ 2d9mz0309Wyvis+bn4XZzi0HrMAYIYioebW0jQlW6w5iG5TM5urotp3Axvge22214bLOTwB6Sqlpo 8aOQ3Bi/qUUnZXclRQ79Bvrkc1PWwdDzEHzhShEks3+JWcLo/DGgQUlBophRa3EJHfn+sb3oXI0p9 27X2xZOZmaXbsfsV6yfsGQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phCqg-0004Zd-I8; Tue, 28 Mar 2023 13:11:07 -0400 Date: Tue, 28 Mar 2023 20:11:12 +0300 Message-Id: <83wn307qdr.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87a5zwzvga.fsf@fastmail.com> (message from Benson Chu on Tue, 28 Mar 2023 11:17:29 -0500) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <87a5zwzvga.fsf@fastmail.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Benson Chu > Cc: juri@linkov.net, 62427@debbugs.gnu.org > Date: Tue, 28 Mar 2023 11:17:29 -0500 > > > Can't we create a completely new window and show the buffer in it? > > I'm not sure how easy this is. Typically new windows come from calls to > #'split-window, and you can't do that for a side-window. What does display-buffer do in this case? reuse the same window regardless of any action alists? > > I'm very uncomfortable with removing window > > parameters like that. These windows don't belong to us, right? > > Let me know if this is wrong, but I am interpreting this statement as: > > "We shouldn't be modifying the window parameters of the windows that > belong to the old tab." There doesn't have to be any "old tab". AFAIU, this option's default value is t, so even when you create the first tab, the code you suggest changing will run and mess with the window parameters of the windows that happen to exist at that point. Right? > Because if that's the case, we're not /really/ modifying the old tab's > window-parameters. They're only "removed" "temporarily", for the > purposes of creating the new tab. You can see right before we modify any > window parameters, we make a call to (tab-bar--tab), which returns a tab > data structure, which contain a representation of the current wconf > (window configuration) - effectively saving the wconf - including the > paramaters. It's kind of like a save excursion: > > (let ((old-tab-num (tab-bar--current-tab-index tabs)) > (old-window-configuration (tab-bar--tab))) > ;; modify window-parameters > ;; do appropriate splitting > ;; Now we have the window layout for the new tab > > ;; The old tab should have the old-window-configuration > (setf (nth old-tab-num tabs) old-window-configuration) > > ;; The rest of the function > ) Is this inside unwind-protect, so that any error or quit or throw is caught and the parameters restored? If so, it might be semi-okay. > So, we capture the current window configuration at the start of the > function, transition the current window configuration into the window > configuration for the new tab (which involves mangling window > parameters and destroying windows), then we make sure that the old tab > has an unmodified window-configuration. Ugh! That is _soooo_ inelegant... Also inefficient, and quite fragile (as any code which uses seve/restore window-configuration is). But I guess that ship has sailed long ago. > When the user switches back to the tab they left, all the > window-parameters are still present, untouched. Are you still > uncomfortable with doing things this way? What happens with all kinds of hooks that run due to this saving and restoring window-configuration? they still will see windows without their parameters, right? From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Benson Chu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 28 Mar 2023 18:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org, juri@linkov.net Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16800265379668 (code B ref 62427); Tue, 28 Mar 2023 18:03:01 +0000 Received: (at 62427) by debbugs.gnu.org; 28 Mar 2023 18:02:17 +0000 Received: from localhost ([127.0.0.1]:50680 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phDeC-0002Vs-L9 for submit@debbugs.gnu.org; Tue, 28 Mar 2023 14:02:17 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:53977) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phDeB-0002Vg-79 for 62427@debbugs.gnu.org; Tue, 28 Mar 2023 14:02:15 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id BD1235C016A; Tue, 28 Mar 2023 14:02:09 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Tue, 28 Mar 2023 14:02:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680026529; x=1680112929; bh=0R uQyyb15trxOPhA4G/Er9IU3XXq/G2mtvNc6CbXRlg=; b=DIOnfsRB3JR+6mu4T0 jqe5RYe+Fqg2G0IBr+3uA9/iVmNQlDDFBojPl7FLdlXAcYfS0KFERQR2tSb1nlG8 8e+IM3RdvlXw63TVgcrNl6FNodsi3HbNaAEiVup2vCftPktb26ARVWbTR7vHZuoX ish9jWZDPoB3nNyRTU640XzVtk0deiInr6pt4HMDvcHvCGbUxR2i7BqEzlvkr4su MdYQvEfsfTrwji6UoSfIOEPuMSWWdqwPN1UaNjx0V0VL+xIwDYDYBJHv3wwF6lJS ApAp1H63mbI5GjJaXFpceZzTA6Or3g2Ko+YmH1ikRKivLMHJdmGFQt9XZCueTKJG xuAA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680026529; x=1680112929; bh=0RuQyyb15trxO PhA4G/Er9IU3XXq/G2mtvNc6CbXRlg=; b=gVZOb0MMo7AO5qLHuVVGSy7d471I2 tcnB9wThupcob3ri9wb6AgBUBwmTk+4WMMZRX0u7K674B+zQzX7SVPetcGcuCXJx sEpM3EZNue10tEiHVInaBbS1eIgWLZZ80yLcG7LoXMK0NEJmMXoP3UpAIzOSxfSM rWEUYKNUXWtzGc+P/3CP+Wn2af4olPwehCiFHp05q1aLzj/Rtwi69LaaztOLounG 3lvYHcnj2Sx+CROtbPp7VVcOl9cDm0IMIs0aURvPdFIcPoJQUKVCaAQO8uLbGpua /nMxW/GIm1mqu9Ab/HxXUlFx1Np+6ckniwqbOvWpTz4uhzP5SmMxqPU8Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdehgedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpehffgfhvfevufffjgfkgggtsehttdertddtredtnecuhfhrohhmpeeuvghn shhonhcuvehhuhcuoegsvghnshhonhgthhhugeehjeesfhgrshhtmhgrihhlrdgtohhmqe enucggtffrrghtthgvrhhnpeffteeffeeuieffgfffteevieduhffhgeduudehudeuleet ledtvdegleeljeehleenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpegsvghnshhonhgthhhugeehjeesfhgrshhtmhgrihhlrdgtohhm X-ME-Proxy: Feedback-ID: id5c9466e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 28 Mar 2023 14:02:08 -0400 (EDT) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <87a5zwzvga.fsf@fastmail.com> <83wn307qdr.fsf@gnu.org> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Benson Chu Date: Tue, 28 Mar 2023 12:39:54 -0500 In-reply-to: <83wn307qdr.fsf@gnu.org> Message-ID: <874jq4zrdr.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) > Ugh! That is _soooo_ inelegant... Also inefficient Hehe, I see what you mean, but creating frames is so expensive. These tabs are like lightweight frames for me. What would you suggest be done instead? > Is this inside unwind-protect, so that any error or quit or throw is > caught and the parameters restored? If so, it might be semi-okay. Ahhh, that is a good point. The reason I even noticed this error was that there wasn't an unwind-protect around it, so not only would Emacs not switch to a new tab, but my window paramters for the current tab would be all messed up. > What does display-buffer do in this case? reuse the same window > regardless of any action alists? Huh, that is a gooood question. I will look into what #'display-buffer does. Eli Zaretskii writes: >> From: Benson Chu >> Cc: juri@linkov.net, 62427@debbugs.gnu.org >> Date: Tue, 28 Mar 2023 11:17:29 -0500 >> >> > Can't we create a completely new window and show the buffer in it? >> >> I'm not sure how easy this is. Typically new windows come from calls to >> #'split-window, and you can't do that for a side-window. > > What does display-buffer do in this case? reuse the same window > regardless of any action alists? > >> > I'm very uncomfortable with removing window >> > parameters like that. These windows don't belong to us, right? >> >> Let me know if this is wrong, but I am interpreting this statement as: >> >> "We shouldn't be modifying the window parameters of the windows that >> belong to the old tab." > > There doesn't have to be any "old tab". AFAIU, this option's default > value is t, so even when you create the first tab, the code you > suggest changing will run and mess with the window parameters of the > windows that happen to exist at that point. Right? > >> Because if that's the case, we're not /really/ modifying the old tab's >> window-parameters. They're only "removed" "temporarily", for the >> purposes of creating the new tab. You can see right before we modify any >> window parameters, we make a call to (tab-bar--tab), which returns a tab >> data structure, which contain a representation of the current wconf >> (window configuration) - effectively saving the wconf - including the >> paramaters. It's kind of like a save excursion: >> >> (let ((old-tab-num (tab-bar--current-tab-index tabs)) >> (old-window-configuration (tab-bar--tab))) >> ;; modify window-parameters >> ;; do appropriate splitting >> ;; Now we have the window layout for the new tab >> >> ;; The old tab should have the old-window-configuration >> (setf (nth old-tab-num tabs) old-window-configuration) >> >> ;; The rest of the function >> ) > > Is this inside unwind-protect, so that any error or quit or throw is > caught and the parameters restored? If so, it might be semi-okay. > >> So, we capture the current window configuration at the start of the >> function, transition the current window configuration into the window >> configuration for the new tab (which involves mangling window >> parameters and destroying windows), then we make sure that the old tab >> has an unmodified window-configuration. > > Ugh! That is _soooo_ inelegant... Also inefficient, and quite > fragile (as any code which uses seve/restore window-configuration is). > But I guess that ship has sailed long ago. > >> When the user switches back to the tab they left, all the >> window-parameters are still present, untouched. Are you still >> uncomfortable with doing things this way? > > What happens with all kinds of hooks that run due to this saving and > restoring window-configuration? they still will see windows without > their parameters, right? From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 30 Mar 2023 16:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org, Benson Chu Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168019480318192 (code B ref 62427); Thu, 30 Mar 2023 16:47:01 +0000 Received: (at 62427) by debbugs.gnu.org; 30 Mar 2023 16:46:43 +0000 Received: from localhost ([127.0.0.1]:59339 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phvQB-0004jM-Gv for submit@debbugs.gnu.org; Thu, 30 Mar 2023 12:46:43 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:56095) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1phvQ7-0004iv-4U for 62427@debbugs.gnu.org; Thu, 30 Mar 2023 12:46:39 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1EEE92000D; Thu, 30 Mar 2023 16:46:31 +0000 (UTC) From: Juri Linkov In-Reply-To: <835yal82ta.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 28 Mar 2023 15:42:41 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> Date: Thu, 30 Mar 2023 19:43:35 +0300 Message-ID: <86a5zuw5oo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > After thinking about this, I'm very uncomfortable with removing window > parameters like that. These windows don't belong to us, right? They > are windows that just happen to be there when the user creates a new > tab. So arbitrary removal of their parameters behind the back of the > user and possibly some Lisp program which set these parameters is not > TRT. > > Can't we create a completely new window and show the buffer in it? > That new window then can have any parameters we want, since it's new. > > Or am I missing something? Sometimes the window configuration gets into such inconsistent state that the minibuffer window remains on the window list while the minibuffer is not active. Then creating a new tab fails with such error: Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified window") delete-other-windows-internal(# #) delete-other-windows() tab-bar-new-tab-to() tab-bar-new-tab() Please fix this bug as well. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Benson Chu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 31 Mar 2023 16:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Eli Zaretskii , 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16802798431882 (code B ref 62427); Fri, 31 Mar 2023 16:25:01 +0000 Received: (at 62427) by debbugs.gnu.org; 31 Mar 2023 16:24:03 +0000 Received: from localhost ([127.0.0.1]:34337 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piHXm-0000UI-Jt for submit@debbugs.gnu.org; Fri, 31 Mar 2023 12:24:02 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:34169) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1piHXl-0000To-45 for 62427@debbugs.gnu.org; Fri, 31 Mar 2023 12:24:01 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id ED8495C0178; Fri, 31 Mar 2023 12:23:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 31 Mar 2023 12:23:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1680279835; x=1680366235; bh=Ym dd4dseVMTA7Oev/nXUDE2y5Z+BG45jtHo+vAbL8Gk=; b=npuEJtoH2FpJibMDZ4 Ur1qIfiDqt5tQ6XZAW+1s6S1+Ip+HyWIXZZO07gLKjemE11+B8EKNe/hJdY6MFXW wmWhuFZ71QslRnWLzMMtQeyES+lUO1E8caPC/vfSxrfrUXGNvfJIX9mZkLWYZk7F 0KzXuxTfRKubYjvK/6vmpsz5JAR/m5P1RjyjnZ0K1k1KSaf7MNG1UJkmDtSM44Dg f+SKullGn3c9WwfSKrNT5G3oRlAqQWhsTaxWGfYZC7Z33Wh32nfokhg3X/X21S1b 65sVyov53gZ6abX3lnDCkp9Vux7/pmotopJ3fIxRb9EdB3Em8Se9ADs/qQVQbYnm XwCw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1680279835; x=1680366235; bh=Ymdd4dseVMTA7 Oev/nXUDE2y5Z+BG45jtHo+vAbL8Gk=; b=lUQODykk0LrRee//m+hIy5kb1fISE 7ngQXhHZJOF4YeQvbF6b7+gtg1bHGcpsSE+QNeR8EMJolbzASiZZHZ83T3CEQ7tY DqbadVEggh3JBIeMhCecFAr7aGKqrpo719w6km/lrBX4fFV1mM5aFyqpmDyzypM4 MoHqUy6kFJrEPJPMO2+fZpLJEMhjt7e5RRNgnD3urQG1VXUPfe21piAnPCpYAzRB dmut/wbCrZ0NTXNATha2h/y7+SVR4WYc0VPMxk1NgCkqiQSwx3tBQWIguNHn7VnJ fWkIZQSJVt/EwQeGngW06eKoPSt2yDcJyQa/EOikxLNkGayWwwZO3+M8A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeiuddgleejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesthdtredttdertdenucfhrhhomhepuegvnhhs ohhnucevhhhuuceosggvnhhsohhntghhuhegheejsehfrghsthhmrghilhdrtghomheqne cuggftrfgrthhtvghrnhepffetfeefueeifffgffetveeiudfhhfegudduheduueelteel tddvgeelleejheelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepsggvnhhsohhntghhuhegheejsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: id5c9466e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 31 Mar 2023 12:23:55 -0400 (EDT) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> User-agent: mu4e 1.8.14; emacs 30.0.50 From: Benson Chu Date: Fri, 31 Mar 2023 11:20:23 -0500 In-reply-to: <86a5zuw5oo.fsf@mail.linkov.net> Message-ID: <87cz4oq485.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) > Then creating a new tab fails with > such error: > > Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified window") Sure, I would be happy to investigate the problem! Is there a way to reproduce this bug? I've personally never seen it before. Juri Linkov writes: >> After thinking about this, I'm very uncomfortable with removing window >> parameters like that. These windows don't belong to us, right? They >> are windows that just happen to be there when the user creates a new >> tab. So arbitrary removal of their parameters behind the back of the >> user and possibly some Lisp program which set these parameters is not >> TRT. >> >> Can't we create a completely new window and show the buffer in it? >> That new window then can have any parameters we want, since it's new. >> >> Or am I missing something? > > Sometimes the window configuration gets into such inconsistent state > that the minibuffer window remains on the window list while the > minibuffer is not active. Then creating a new tab fails with > such error: > > Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified window") > delete-other-windows-internal(# #) > delete-other-windows() > tab-bar-new-tab-to() > tab-bar-new-tab() > > Please fix this bug as well. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 01 Apr 2023 18:49:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benson Chu Cc: Eli Zaretskii , 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168037493112272 (code B ref 62427); Sat, 01 Apr 2023 18:49:03 +0000 Received: (at 62427) by debbugs.gnu.org; 1 Apr 2023 18:48:51 +0000 Received: from localhost ([127.0.0.1]:38601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pigHS-0003Bs-N7 for submit@debbugs.gnu.org; Sat, 01 Apr 2023 14:48:51 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:51761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pigHQ-0003BO-DS for 62427@debbugs.gnu.org; Sat, 01 Apr 2023 14:48:48 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id C3D94FF807; Sat, 1 Apr 2023 18:48:41 +0000 (UTC) From: Juri Linkov In-Reply-To: <87cz4oq485.fsf@fastmail.com> (Benson Chu's message of "Fri, 31 Mar 2023 11:20:23 -0500") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> Date: Sat, 01 Apr 2023 21:25:13 +0300 Message-ID: <86pm8nfoja.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Then creating a new tab fails with such error: >> >> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified window") > > Sure, I would be happy to investigate the problem! Is there a way to > reproduce this bug? I've personally never seen it before. Sorry, this bug is not reproducible. It comes out of the blue. And has such consequences that there is no recursive edit, but you still can switch to the minibuffer window that has no prompt with 'C-x o'. >> Sometimes the window configuration gets into such inconsistent state >> that the minibuffer window remains on the window list while the >> minibuffer is not active. Then creating a new tab fails with >> such error: >> >> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified window") >> delete-other-windows-internal(# #) >> delete-other-windows() >> tab-bar-new-tab-to() >> tab-bar-new-tab() From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 18:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benson Chu Cc: Eli Zaretskii , 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168045978916256 (code B ref 62427); Sun, 02 Apr 2023 18:24:01 +0000 Received: (at 62427) by debbugs.gnu.org; 2 Apr 2023 18:23:09 +0000 Received: from localhost ([127.0.0.1]:42630 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj2M9-0004E8-54 for submit@debbugs.gnu.org; Sun, 02 Apr 2023 14:23:09 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:55315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj2M6-0004Dd-Lp for 62427@debbugs.gnu.org; Sun, 02 Apr 2023 14:23:07 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 1C8C41C0004; Sun, 2 Apr 2023 18:22:59 +0000 (UTC) From: Juri Linkov In-Reply-To: <86pm8nfoja.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 01 Apr 2023 21:25:13 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> Date: Sun, 02 Apr 2023 21:20:36 +0300 Message-ID: <867cuukuvj.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified window") >> >> Sure, I would be happy to investigate the problem! Is there a way to >> reproduce this bug? I've personally never seen it before. > > Sorry, this bug is not reproducible. It comes out of the blue. > And has such consequences that there is no recursive edit, > but you still can switch to the minibuffer window that has no prompt > with 'C-x o'. Ok, now here is 100% reproducible case: 0. emacs-29 -Q 1. (setq debug-on-error t enable-recursive-minibuffers t) 2. M-: (or any other prompt like 'M-x') 3. Resize the minibuffer window e.g. with the mouse to at least 4 lines high 4. M-x windmove-swap-states-up RET 5. Click on the bottom window 6. C-x t 2 7. Click on the bottom window 8. C-x t 2 Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") delete-other-windows-internal(# #) delete-other-windows() tab-bar-new-tab-to() tab-new(nil) From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 02 Apr 2023 18:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benson Chu Cc: Eli Zaretskii , 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168046160928804 (code B ref 62427); Sun, 02 Apr 2023 18:54:01 +0000 Received: (at 62427) by debbugs.gnu.org; 2 Apr 2023 18:53:29 +0000 Received: from localhost ([127.0.0.1]:42666 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj2pR-0007UN-2r for submit@debbugs.gnu.org; Sun, 02 Apr 2023 14:53:29 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:55649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pj2pL-0007Ty-1t for 62427@debbugs.gnu.org; Sun, 02 Apr 2023 14:53:23 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 2EB2E240005; Sun, 2 Apr 2023 18:53:09 +0000 (UTC) From: Juri Linkov In-Reply-To: <867cuukuvj.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 02 Apr 2023 21:20:36 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> Date: Sun, 02 Apr 2023 21:51:31 +0300 Message-ID: <86lejajex8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > 1. (setq debug-on-error t enable-recursive-minibuffers t) > 2. M-: (or any other prompt like 'M-x') > 3. Resize the minibuffer window e.g. with the mouse to at least 4 lines high > 4. M-x windmove-swap-states-up RET > 5. Click on the bottom window > 6. C-x t 2 > 7. Click on the bottom window > 8. C-x t 2 > > Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") > delete-other-windows-internal(# #) > delete-other-windows() > tab-bar-new-tab-to() > tab-new(nil) Maybe the simplest fix is just not to create such a broken window configuration: diff --git a/lisp/windmove.el b/lisp/windmove.el index 06ce16c0d42..57511291588 100644 --- a/lisp/windmove.el +++ b/lisp/windmove.el @@ -724,6 +724,8 @@ windmove-swap-states-in-direction nil windmove-wrap-around 'nomini))) (cond ((or (null other-window) (window-minibuffer-p other-window)) (user-error "No window %s from selected window" dir)) + ((window-minibuffer-p (selected-window)) + (user-error "Selected window is the minibuffer")) (t (window-swap-states nil other-window))))) From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Benson Chu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Apr 2023 03:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: Eli Zaretskii , 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168152866720528 (code B ref 62427); Sat, 15 Apr 2023 03:18:02 +0000 Received: (at 62427) by debbugs.gnu.org; 15 Apr 2023 03:17:47 +0000 Received: from localhost ([127.0.0.1]:48003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnWQ6-0005L2-Vf for submit@debbugs.gnu.org; Fri, 14 Apr 2023 23:17:47 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnWQ5-0005Kn-1J for 62427@debbugs.gnu.org; Fri, 14 Apr 2023 23:17:45 -0400 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id B1D3F5C01C7; Fri, 14 Apr 2023 23:17:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute6.internal (MEProxy); Fri, 14 Apr 2023 23:17:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1681528659; x=1681615059; bh=c9 r3kHLkjqifB4arh7/++6V6xKOPGnKpqeV1vxP7I/A=; b=uCnOu7YPWPz4EKa3m8 1OCwq/uCXpLN1sa191BhvaFmR1c0ClwR4hjV5/bZLQdK1Skmj3AApzRwgULCuK9b HljnIiAGQMGWFHS680YKhU//iBHm3OsdDCIKbn0oykLpe+y5x+NrpUFmkqE3hKOF AP1xshDiHyCcK/JtqNv8V/X8pPSYBeapekL3/sqQyAlMVRy0gmbM5Q6Bo+pD4N8x sRcDO/Cau0chA9HghIKXu+/2DpAbIqxAjUnpTbEiBLFT2pGNamv57lMmtZm02G65 lZ3Wn7MpGbb0xjoDbpMTaGW2kebHxivjcT60BH1Lex3a4g8bVfcJt3m8HkhqDhpG iUcg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; t=1681528659; x=1681615059; bh=c9r3kHLkjqifB 4arh7/++6V6xKOPGnKpqeV1vxP7I/A=; b=S8X5Pk7YLj1TglXrAStX8rTKe966H YfJdoRSFZ1FZibOYdQeblqdoMkq5akc+7WanBf8CWApwUlUsOSTmar8es6wr+2bS LfX8o8MeFSeDnjT4M/Bh8yxdGqu7J24DLcrdwzwbCzxwWlk/zN+YU+aGuEy4fhoR vSb+/pV/n7Xv/mwIy/i7sFGMf3/pVC5MvXBU6Jc89XhfwCGcFRiFRK1XWCW41IWG e3qrynbMMITMAFyWatPh5atsvFaQzv0bn3DCvghwnnegkdXWOWnEzH4vJLiczkdb d8dDjyOSJQWX+ZNmSFyNd4ucEaXLczVrW0Lqn6hede/LgWn+g1TtROozw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdeluddgjedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfhgfhffvvefuffgjkfggtgesmhdtreertdertdenucfhrhhomhepuegvnhhs ohhnucevhhhuuceosggvnhhsohhntghhuhegheejsehfrghsthhmrghilhdrtghomheqne cuggftrfgrthhtvghrnhephfeuudekvdeggefhfeeiheehudduleejudeiudfhtefhtdff tdelheeljeegfefgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepsggvnhhsohhntghhuhegheejsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Feedback-ID: id5c9466e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 14 Apr 2023 23:17:38 -0400 (EDT) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> User-agent: mu4e 1.8.14; emacs 29.0.90 From: Benson Chu Date: Fri, 14 Apr 2023 22:03:34 -0500 In-reply-to: <86lejajex8.fsf@mail.linkov.net> Message-ID: <87r0slbzqp.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) --=-=-= Content-Type: text/plain I've done some digging into whether we can mimic OR use display-buffer when creating a new tab, and while we could do this, we also advertise two other behaviors for tab-bar-new-tab-choice that would make the function needlessly complex, as use/mimicry of display-buffer would only help in the case of when tab-bar-new-tab-choice is t. On a side-note (side-window? haha), I've got a patch that side-steps (hehe) the issue of modifying the 'window-side parameter completely, by binding to window--sides-inhibit-check to t. Having bound this, the issues wrt split-window and delete-other-windows is no longer present, and thus we no longer have to touch the 'window-side parameter at all. The same can't be said for the 'window-atom parameter (there's no variable to bind to ignore checks), so it still needs to be removed in order to ensure a safe call to delete-other-windows and split-window. Would this be a better patch? It's now less destructive on existing window parameters. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-tab-bar-new-tab-inhibit-side-window-checks.patch >From 2eaeea1f815b5e6c75947e9373c1b2f8fc539344 Mon Sep 17 00:00:00 2001 From: Benson Chu Date: Fri, 24 Mar 2023 15:38:03 -0500 Subject: [PATCH] ; tab-bar-new-tab inhibit side-window checks ; Previously, calling tab-bar-new-tab-to only removes the 'window-side ; property on the currently selected window, and then a call to ; delete-other-windows was made to ensure that the selected window was ; the only window. We can skip this check by shadowing ; window--sides-inhibit-check to t. * lisp/tab-bar.el (tab-bar-new-tab-to): inhibit side-window checks Copyright-paperwork-exempt: yes --- lisp/tab-bar.el | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index dce6fa735fc..c7983146bf9 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1552,15 +1552,14 @@ tab-bar-new-tab-to ;; Handle the case when it's called in the active minibuffer. (when (minibuffer-selected-window) (select-window (minibuffer-selected-window))) - ;; Remove window parameters that can cause problems - ;; with `delete-other-windows' and `split-window'. - (unless (eq tab-bar-new-tab-choice 'clone) - (set-window-parameter nil 'window-atom nil) - (set-window-parameter nil 'window-side nil)) - (let ((ignore-window-parameters t)) + (let ((ignore-window-parameters t) + (window--sides-inhibit-check t)) (if (eq tab-bar-new-tab-choice 'clone) ;; Create new unique windows with the same layout (window-state-put (window-state-get)) + ;; Remove window parameters that can cause problems + ;; with `delete-other-windows' and `split-window'. + (set-window-parameter nil 'window-atom nil) (delete-other-windows) (if (eq tab-bar-new-tab-choice 'window) ;; Create new unique window from remaining window -- 2.40.0 --=-=-= Content-Type: text/plain Juri Linkov writes: >> 1. (setq debug-on-error t enable-recursive-minibuffers t) >> 2. M-: (or any other prompt like 'M-x') >> 3. Resize the minibuffer window e.g. with the mouse to at least 4 lines high >> 4. M-x windmove-swap-states-up RET >> 5. Click on the bottom window >> 6. C-x t 2 >> 7. Click on the bottom window >> 8. C-x t 2 >> >> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") >> delete-other-windows-internal(# #) >> delete-other-windows() >> tab-bar-new-tab-to() >> tab-new(nil) > > Maybe the simplest fix is just not to create such a broken > window configuration: > > diff --git a/lisp/windmove.el b/lisp/windmove.el > index 06ce16c0d42..57511291588 100644 > --- a/lisp/windmove.el > +++ b/lisp/windmove.el > @@ -724,6 +724,8 @@ windmove-swap-states-in-direction > nil windmove-wrap-around 'nomini))) > (cond ((or (null other-window) (window-minibuffer-p other-window)) > (user-error "No window %s from selected window" dir)) > + ((window-minibuffer-p (selected-window)) > + (user-error "Selected window is the minibuffer")) > (t > (window-swap-states nil other-window))))) --=-=-=-- From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Apr 2023 18:56:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benson Chu Cc: Eli Zaretskii , 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16815849057574 (code B ref 62427); Sat, 15 Apr 2023 18:56:02 +0000 Received: (at 62427) by debbugs.gnu.org; 15 Apr 2023 18:55:05 +0000 Received: from localhost ([127.0.0.1]:50150 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnl3A-0001y5-Ut for submit@debbugs.gnu.org; Sat, 15 Apr 2023 14:55:05 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:32801) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pnl38-0001wi-6M for 62427@debbugs.gnu.org; Sat, 15 Apr 2023 14:55:03 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id D421DFF802; Sat, 15 Apr 2023 18:54:54 +0000 (UTC) From: Juri Linkov In-Reply-To: <87r0slbzqp.fsf@fastmail.com> (Benson Chu's message of "Fri, 14 Apr 2023 22:03:34 -0500") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <87r0slbzqp.fsf@fastmail.com> Date: Sat, 15 Apr 2023 21:42:22 +0300 Message-ID: <86cz45dlll.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > On a side-note (side-window? haha), I've got a patch that side-steps > (hehe) the issue of modifying the 'window-side parameter completely, by > binding to window--sides-inhibit-check to t. Thanks, window--sides-inhibit-check is a good find. Let me test it for a while. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Apr 2023 07:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benson Chu Cc: Eli Zaretskii , 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.1681802971821 (code B ref 62427); Tue, 18 Apr 2023 07:30:02 +0000 Received: (at 62427) by debbugs.gnu.org; 18 Apr 2023 07:29:31 +0000 Received: from localhost ([127.0.0.1]:57602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pofmN-0000DA-Cd for submit@debbugs.gnu.org; Tue, 18 Apr 2023 03:29:31 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:63079) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pofmL-0000Cy-Rg for 62427@debbugs.gnu.org; Tue, 18 Apr 2023 03:29:30 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id BD2BE40010; Tue, 18 Apr 2023 07:29:22 +0000 (UTC) From: Juri Linkov In-Reply-To: <86cz45dlll.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 15 Apr 2023 21:42:22 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <87r0slbzqp.fsf@fastmail.com> <86cz45dlll.fsf@mail.linkov.net> Date: Tue, 18 Apr 2023 09:58:10 +0300 Message-ID: <86jzy9sl80.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> On a side-note (side-window? haha), I've got a patch that side-steps >> (hehe) the issue of modifying the 'window-side parameter completely, by >> binding to window--sides-inhibit-check to t. > > Thanks, window--sides-inhibit-check is a good find. > Let me test it for a while. I still can't find a test case that could be fixed by window--sides-inhibit-check. Your original test case is fixed because you removed (set-window-parameter nil 'window-side nil). And the test case in bug#53662 doesn't need this line because it was fixed by adding (ignore-window-parameters t). But maybe there are cases where window--sides-inhibit-check would help, so we could add it as a precaution. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 22 Apr 2023 09:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16821543472558 (code B ref 62427); Sat, 22 Apr 2023 09:06:01 +0000 Received: (at 62427) by debbugs.gnu.org; 22 Apr 2023 09:05:47 +0000 Received: from localhost ([127.0.0.1]:41677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pq9Bj-0000fC-CU for submit@debbugs.gnu.org; Sat, 22 Apr 2023 05:05:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54714) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pq9Bi-0000ez-Bn for 62427@debbugs.gnu.org; Sat, 22 Apr 2023 05:05:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq9Bc-0001as-F3; Sat, 22 Apr 2023 05:05:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/WGjPaaQMzsn/n0o7GJOqETZUgAszgRVazGHlOIUH9I=; b=FIc5syr4dhdE WFrgSMkX5iizJ6S1X2ub9/cT8HQqlKg6Aa+gLVJsejZH5W3hAg3dA46kSGix8LZuLyUf/LZvQ35qp fhWkfQRHe1cAUphMsoA1xWM/OdkAn9C7LBfnirtjSqeqPcFhXcDrB0+N/l6ts8MN+ddF5Bnn2s7PY dYsctsy8i6kS+9ajPu56iF2wFU41gma7sy4HZJlxgomkB3Stgg396cc9EtW61syCSKEmwR84MmpBQ PQYHVWGvA2rxbH0zg+sZhBXcPvXkP7ThDwya28nWAwxTaIu56uQ/d9D9agQH7w3g0IEsbUMf8kcDJ 12An6ALOFhSZyyeOv9GVlQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pq9Bb-0002g2-LW; Sat, 22 Apr 2023 05:05:39 -0400 Date: Sat, 22 Apr 2023 12:05:58 +0300 Message-Id: <83y1mk1e2x.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86jzy9sl80.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 18 Apr 2023 09:58:10 +0300) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <87r0slbzqp.fsf@fastmail.com> <86cz45dlll.fsf@mail.linkov.net> <86jzy9sl80.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: Eli Zaretskii , 62427@debbugs.gnu.org > Date: Tue, 18 Apr 2023 09:58:10 +0300 > > >> On a side-note (side-window? haha), I've got a patch that side-steps > >> (hehe) the issue of modifying the 'window-side parameter completely, by > >> binding to window--sides-inhibit-check to t. > > > > Thanks, window--sides-inhibit-check is a good find. > > Let me test it for a while. > > I still can't find a test case that could be fixed by > window--sides-inhibit-check. Your original test case is fixed > because you removed (set-window-parameter nil 'window-side nil). > And the test case in bug#53662 doesn't need this line because > it was fixed by adding (ignore-window-parameters t). > > But maybe there are cases where window--sides-inhibit-check > would help, so we could add it as a precaution. Should I install the last patch, or should I wait for more testing? From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 23 Apr 2023 16:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168226818322319 (code B ref 62427); Sun, 23 Apr 2023 16:44:02 +0000 Received: (at 62427) by debbugs.gnu.org; 23 Apr 2023 16:43:03 +0000 Received: from localhost ([127.0.0.1]:46849 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcnm-0005nv-TU for submit@debbugs.gnu.org; Sun, 23 Apr 2023 12:43:03 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:42973) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqcnj-0005n6-Bm for 62427@debbugs.gnu.org; Sun, 23 Apr 2023 12:42:59 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id EC8E3240006; Sun, 23 Apr 2023 16:42:51 +0000 (UTC) From: Juri Linkov In-Reply-To: <83y1mk1e2x.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 22 Apr 2023 12:05:58 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <87r0slbzqp.fsf@fastmail.com> <86cz45dlll.fsf@mail.linkov.net> <86jzy9sl80.fsf@mail.linkov.net> <83y1mk1e2x.fsf@gnu.org> Date: Sun, 23 Apr 2023 19:39:10 +0300 Message-ID: <86cz3u7igx.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> >> On a side-note (side-window? haha), I've got a patch that side-steps >> >> (hehe) the issue of modifying the 'window-side parameter completely, by >> >> binding to window--sides-inhibit-check to t. >> > >> > Thanks, window--sides-inhibit-check is a good find. >> > Let me test it for a while. >> >> I still can't find a test case that could be fixed by >> window--sides-inhibit-check. Your original test case is fixed >> because you removed (set-window-parameter nil 'window-side nil). >> And the test case in bug#53662 doesn't need this line because >> it was fixed by adding (ignore-window-parameters t). >> >> But maybe there are cases where window--sides-inhibit-check >> would help, so we could add it as a precaution. > > Should I install the last patch, or should I wait for more testing? The patch works in two known test cases, and no more tests were found, so probably it could be installed. From unknown Sun Jun 22 03:57:12 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Benson Chu Subject: bug#62427: closed (Re: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows) Message-ID: References: <83h6t5xzw1.fsf@gnu.org> <875yapvoxh.fsf@fastmail.com> X-Gnu-PR-Message: they-closed 62427 X-Gnu-PR-Package: emacs Reply-To: 62427@debbugs.gnu.org Date: Mon, 24 Apr 2023 11:51:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1682337061-2806-1" This is a multi-part message in MIME format... ------------=_1682337061-2806-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #62427: tab-bar-new-tab-to now handles cases with multiple side-windows which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 62427@debbugs.gnu.org. --=20 62427: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62427 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1682337061-2806-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 62427-done) by debbugs.gnu.org; 24 Apr 2023 11:50:26 +0000 Received: from localhost ([127.0.0.1]:47715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqui9-0000hj-PH for submit@debbugs.gnu.org; Mon, 24 Apr 2023 07:50:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55534) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pqui7-0000hV-PL for 62427-done@debbugs.gnu.org; Mon, 24 Apr 2023 07:50:24 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pqui1-0003aK-7N; Mon, 24 Apr 2023 07:50:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZVt4l8zNUEEhplAzIlUVuPzkdPeczkETlAmsBRMZCmE=; b=iAiTyYPQlnsj GWt4+XakUlsSPLIn/cg6z1MN3D9A+weg3WhW42Wjze4oxQUwpZug18sUxVFdFe5NyRVlh4jN3WnX1 OGjekbaCEIEHoLlhz59d1zDb3gw5U43mpXJ8HSYi0Wm624VvmmVpJY3ShuaNfioxS6bDUCoxYWMdL 2BS75lt0mZ+F5WeFxMiBPLH2dNF0ArbPyvwLDKghgwmPtlbSSPiQZtJ73nkDXjh/NwOlqjBZlqjal DosWMrkqSbC1cb4nosGPxuAiSYpyGlsM4CeENm+qm/RNK4ApwtOmU5JqaS/wfQ56Lw9s5ejTTr835 u5QtBFv719Oga5Yu00CXPQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pquhy-0008RM-K1; Mon, 24 Apr 2023 07:50:16 -0400 Date: Mon, 24 Apr 2023 14:50:38 +0300 Message-Id: <83h6t5xzw1.fsf@gnu.org> From: Eli Zaretskii To: Juri Linkov In-Reply-To: <86cz3u7igx.fsf@mail.linkov.net> (message from Juri Linkov on Sun, 23 Apr 2023 19:39:10 +0300) Subject: Re: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <87r0slbzqp.fsf@fastmail.com> <86cz45dlll.fsf@mail.linkov.net> <86jzy9sl80.fsf@mail.linkov.net> <83y1mk1e2x.fsf@gnu.org> <86cz3u7igx.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62427-done Cc: 62427-done@debbugs.gnu.org, bensonchu457@fastmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: bensonchu457@fastmail.com, 62427@debbugs.gnu.org > Date: Sun, 23 Apr 2023 19:39:10 +0300 > > >> >> On a side-note (side-window? haha), I've got a patch that side-steps > >> >> (hehe) the issue of modifying the 'window-side parameter completely, by > >> >> binding to window--sides-inhibit-check to t. > >> > > >> > Thanks, window--sides-inhibit-check is a good find. > >> > Let me test it for a while. > >> > >> I still can't find a test case that could be fixed by > >> window--sides-inhibit-check. Your original test case is fixed > >> because you removed (set-window-parameter nil 'window-side nil). > >> And the test case in bug#53662 doesn't need this line because > >> it was fixed by adding (ignore-window-parameters t). > >> > >> But maybe there are cases where window--sides-inhibit-check > >> would help, so we could add it as a precaution. > > > > Should I install the last patch, or should I wait for more testing? > > The patch works in two known test cases, and no more tests were found, > so probably it could be installed. Thanks, installed on emacs-29 branch, and closing the bug. Benson, any news on your copyright assignment? ------------=_1682337061-2806-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 24 Mar 2023 21:13:04 +0000 Received: from localhost ([127.0.0.1]:41507 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfoie-0008PR-7b for submit@debbugs.gnu.org; Fri, 24 Mar 2023 17:13:04 -0400 Received: from [209.51.188.17] (port=48440 helo=lists.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfodO-0008Eg-TC for submit@debbugs.gnu.org; Fri, 24 Mar 2023 17:07:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfodF-00047q-TN for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 17:07:29 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfodD-0005G1-HR for bug-gnu-emacs@gnu.org; Fri, 24 Mar 2023 17:07:29 -0400 Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.west.internal (Postfix) with ESMTP id D1DA23200951 for ; Fri, 24 Mar 2023 17:07:23 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 24 Mar 2023 17:07:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:content-type:date:date:from:from:in-reply-to :message-id:mime-version:reply-to:sender:subject:subject:to:to; s=fm2; t=1679692043; x=1679778443; bh=Ly4i2UbH8LGttjlh6ZLuiaJBM ghkRh7XTR2M8FhAtQc=; b=Qr27Yy1pqM72gG3RNv9JeaOStEGEKkDNzd2WL8qKA 5JioHDx5Er+XwQItbWEVkprVxavhphdq023A8WtoAvW46hk7aHeridGQC4jx23pB digwO7P5ccFycb3lISbdk8mB0948W7+7KBXB7PQPfv4oKT+tyIZ3wRO+SUvLmz6N 8pr6qCfi9lH5R1UDd4Tfuq5InqCtSMfGTZ+7pR77lYI37WgaXh0OKeM1glDnlKQY TFBM0Tq+93pS+bdqV8PUgNOVcRfyFrrSiAkAxCBYdRTyLM5PRDafaBtDvPiWmAk3 cLmnRLGmHDOQo7zQDpL115+LY7N5pAkzlLQRB8+/RUigQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1679692043; x=1679778443; bh=Ly4i2UbH8LGttjlh6ZLuiaJBMghkRh7XTR2 M8FhAtQc=; b=N9B/4lczQNDTMolTkmnmLDZeyF2I7MRSn+jEkNi5bGrrwoxXByy 1lD++wbSR/lEePr3IMp5wGVnRsY9hCbL0m0xaBX+7U7N8RXmW9cxIn7aRTWNHdOM UfIZ1FHvTwIapmz/hdCK7CMKcA5MXmasPmMKXbhOxB661tvCXMw2Af49gb26yKRs k4WKAC/rvIppVF2C8JqidMeF2vfl2KLJnOS5yym7UVp5VJruWc5yWEAsDtTd25Mi hT9MPmy+vCujxBIAbx3S6VIY/qZ8n0hxLNkkiqJpLEr4fYc09PyHVZFFM9G0wF6U aEao+z8mZ9oXc1tiLWJQrpBq7Sj4hobbTGw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdegiedgudegjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfggtgesmhdtreertd dttdenucfhrhhomhepuegvnhhsohhnucevhhhuuceosggvnhhsohhntghhuhegheejsehf rghsthhmrghilhdrtghomheqnecuggftrfgrthhtvghrnhepkeettdejieejueegvdekhf dtuedtkefhfffghedtuddvvedvudduiedutefghfeinecuvehluhhsthgvrhfuihiivgep tdenucfrrghrrghmpehmrghilhhfrhhomhepsggvnhhsohhntghhuhegheejsehfrghsth hmrghilhdrtghomh X-ME-Proxy: Feedback-ID: id5c9466e:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Fri, 24 Mar 2023 17:07:23 -0400 (EDT) From: Benson Chu To: bug-gnu-emacs@gnu.org Subject: tab-bar-new-tab-to now handles cases with multiple side-windows Date: Fri, 24 Mar 2023 16:07:22 -0500 Message-ID: <875yapvoxh.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=64.147.123.25; envelope-from=bensonchu457@fastmail.com; helo=wout2-smtp.messagingengine.com X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 24 Mar 2023 17:13:02 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) --=-=-= Content-Type: text/plain Hello, I've noticed that when I call #'tab-bar-new-tab while I'm in a side-window that has siblings, I get an error from #'window--sides-check, which happens when #'tab-bar-new-tab calls #'delete-other-windows. Here's an example of my problem: (progn (display-buffer-in-side-window (get-buffer-create "*hello*") '((side . right) (slot . 1))) (select-window (display-buffer-in-side-window (get-buffer-create "*world*") '((side . right) (slot . 2)))) (tab-bar-new-tab)) The attached patch fixes this issue. Could it be applied to the emacs-29 branch? Thanks! --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-tab-bar-new-tab-to-now-handles-cases-with-multiple-s.patch >From cc8974b45d5726a0f6a8d9ab6566411c118a0769 Mon Sep 17 00:00:00 2001 From: Benson Chu Date: Fri, 24 Mar 2023 15:38:03 -0500 Subject: [PATCH] tab-bar-new-tab-to now handles cases with multiple side-windows Previously, calling tab-bar-new-tab-to only removes the 'window-side property on the currently selected window, and then a call to delete-other-windows was made to ensure that the selected window was the only window. However, if there are other side-windows (with the same side) present, the call to delete-other-windows will fail on the window--sides-check. This is because according to the check, all windows on the same side should have the same 'window-side, and because we only removed the 'window-side parameters on one of the windows, there will be inconsistencies with that window and its parent and siblings. Because of this, the call to delete-other-windows to fail. This patch makes sure that all windows on a given side will have 'window-side set to nil, so that the call to delete-other-windows will not fail. * lisp/tab-bar.el: remove 'window-side from selected window, window's parent, and all window's siblings. --- lisp/tab-bar.el | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index dce6fa735fc..f05abffbcdb 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1556,7 +1556,13 @@ tab-bar-new-tab-to ;; with `delete-other-windows' and `split-window'. (unless (eq tab-bar-new-tab-choice 'clone) (set-window-parameter nil 'window-atom nil) - (set-window-parameter nil 'window-side nil)) + (let ((side (window-parameter nil 'window-side))) + (when side + (walk-window-tree + (lambda (window) + (when (eq side (window-parameter window 'window-side)) + (set-window-parameter window 'window-side nil))) + nil t)))) (let ((ignore-window-parameters t)) (if (eq tab-bar-new-tab-choice 'clone) ;; Create new unique windows with the same layout -- 2.40.0 --=-=-=-- ------------=_1682337061-2806-1-- From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Apr 2023 17:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168244423122025 (code B ref 62427); Tue, 25 Apr 2023 17:38:01 +0000 Received: (at 62427) by debbugs.gnu.org; 25 Apr 2023 17:37:11 +0000 Received: from localhost ([127.0.0.1]:53511 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prMbG-0005j9-LK for submit@debbugs.gnu.org; Tue, 25 Apr 2023 13:37:10 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:49431) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prMbD-0005it-TP for 62427@debbugs.gnu.org; Tue, 25 Apr 2023 13:37:09 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 35C1CE000A; Tue, 25 Apr 2023 17:37:00 +0000 (UTC) From: Juri Linkov In-Reply-To: <83h6t5xzw1.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 24 Apr 2023 14:50:38 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <87r0slbzqp.fsf@fastmail.com> <86cz45dlll.fsf@mail.linkov.net> <86jzy9sl80.fsf@mail.linkov.net> <83y1mk1e2x.fsf@gnu.org> <86cz3u7igx.fsf@mail.linkov.net> <83h6t5xzw1.fsf@gnu.org> Date: Tue, 25 Apr 2023 20:25:29 +0300 Message-ID: <86wn1zq456.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Thanks, installed on emacs-29 branch, and closing the bug. >From the docstring of 'tab-bar-new-tab-choice': If the value is the symbol `window', then keep the selected window as a single window on the new tab, and keep all its window parameters except `window-atom' and `window-side'. =========== So still need to remove `window-side' in this case: (progn (display-buffer-in-side-window (get-buffer-create "*hello*") '((side . right) (slot . 1))) (select-window (display-buffer-in-side-window (get-buffer-create "*world*") '((side . right) (slot . 2)))) (tab-bar-move-window-to-tab) (split-window)) This should handle it: diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 61e177c051d..42fc5a23990 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1588,7 +1588,9 @@ tab-bar-new-tab-to (delete-other-windows) (if (eq tab-bar-new-tab-choice 'window) ;; Create new unique window from remaining window - (window-state-put (window-state-get)) + (progn + (set-window-parameter nil 'window-side nil) + (window-state-put (window-state-get))) ;; Create a new window to get rid of old window parameters ;; (e.g. prev/next buffers) of old window. (split-window) (delete-window)))) From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 25 Apr 2023 17:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Benson Chu Cc: Eli Zaretskii , 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168244424122060 (code B ref 62427); Tue, 25 Apr 2023 17:38:01 +0000 Received: (at 62427) by debbugs.gnu.org; 25 Apr 2023 17:37:21 +0000 Received: from localhost ([127.0.0.1]:53517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prMbR-0005jj-Bb for submit@debbugs.gnu.org; Tue, 25 Apr 2023 13:37:21 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:50359) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1prMbM-0005jA-8a for 62427@debbugs.gnu.org; Tue, 25 Apr 2023 13:37:16 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4E1B5240002; Tue, 25 Apr 2023 17:37:08 +0000 (UTC) From: Juri Linkov In-Reply-To: <86lejajex8.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 02 Apr 2023 21:51:31 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> Date: Tue, 25 Apr 2023 20:30:54 +0300 Message-ID: <86h6t3q3nt.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> 1. (setq debug-on-error t enable-recursive-minibuffers t) >> 2. M-: (or any other prompt like 'M-x') >> 3. Resize the minibuffer window e.g. with the mouse to at least 4 lines high >> 4. M-x windmove-swap-states-up RET >> 5. Click on the bottom window >> 6. C-x t 2 >> 7. Click on the bottom window >> 8. C-x t 2 >> >> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") >> delete-other-windows-internal(# #) >> delete-other-windows() >> tab-bar-new-tab-to() >> tab-new(nil) > > Maybe the simplest fix is just not to create such a broken > window configuration: > > diff --git a/lisp/windmove.el b/lisp/windmove.el > index 06ce16c0d42..57511291588 100644 > --- a/lisp/windmove.el > +++ b/lisp/windmove.el > @@ -724,6 +724,8 @@ windmove-swap-states-in-direction > nil windmove-wrap-around 'nomini))) > (cond ((or (null other-window) (window-minibuffer-p other-window)) > (user-error "No window %s from selected window" dir)) > + ((window-minibuffer-p (selected-window)) > + (user-error "Selected window is the minibuffer")) > (t > (window-swap-states nil other-window))))) This is another patch that could be installed either to emacs-29 or master. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 15 May 2023 17:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org, bensonchu457@fastmail.com Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168417203625286 (code B ref 62427); Mon, 15 May 2023 17:34:01 +0000 Received: (at 62427) by debbugs.gnu.org; 15 May 2023 17:33:56 +0000 Received: from localhost ([127.0.0.1]:44280 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyc55-0006Zl-To for submit@debbugs.gnu.org; Mon, 15 May 2023 13:33:56 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:56067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyc54-0006ZW-2e for 62427@debbugs.gnu.org; Mon, 15 May 2023 13:33:54 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4C010240005; Mon, 15 May 2023 17:33:45 +0000 (UTC) From: Juri Linkov In-Reply-To: <86wn1zq456.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 25 Apr 2023 20:25:29 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <87r0slbzqp.fsf@fastmail.com> <86cz45dlll.fsf@mail.linkov.net> <86jzy9sl80.fsf@mail.linkov.net> <83y1mk1e2x.fsf@gnu.org> <86cz3u7igx.fsf@mail.linkov.net> <83h6t5xzw1.fsf@gnu.org> <86wn1zq456.fsf@mail.linkov.net> Date: Mon, 15 May 2023 20:32:28 +0300 Message-ID: <86353xjyab.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Thanks, installed on emacs-29 branch, and closing the bug. > > From the docstring of 'tab-bar-new-tab-choice': > > If the value is the symbol `window', then keep the selected > window as a single window on the new tab, and keep all its > window parameters except `window-atom' and `window-side'. > =========== > > So still need to remove `window-side' in this case: > > diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el > index 61e177c051d..42fc5a23990 100644 > --- a/lisp/tab-bar.el > +++ b/lisp/tab-bar.el > @@ -1588,7 +1588,9 @@ tab-bar-new-tab-to > (delete-other-windows) > (if (eq tab-bar-new-tab-choice 'window) > ;; Create new unique window from remaining window > - (window-state-put (window-state-get)) > + (progn > + (set-window-parameter nil 'window-side nil) > + (window-state-put (window-state-get))) > ;; Create a new window to get rid of old window parameters > ;; (e.g. prev/next buffers) of old window. > (split-window) (delete-window)))) Now installed on emacs-29 branch. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 17:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16842592601398 (code B ref 62427); Tue, 16 May 2023 17:48:01 +0000 Received: (at 62427) by debbugs.gnu.org; 16 May 2023 17:47:40 +0000 Received: from localhost ([127.0.0.1]:47650 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyylv-0000MT-TE for submit@debbugs.gnu.org; Tue, 16 May 2023 13:47:40 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:40013) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyylt-0000MA-TL for 62427@debbugs.gnu.org; Tue, 16 May 2023 13:47:38 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 2C26CFF808 for <62427@debbugs.gnu.org>; Tue, 16 May 2023 17:47:30 +0000 (UTC) From: Juri Linkov In-Reply-To: <86h6t3q3nt.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 25 Apr 2023 20:30:54 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> Date: Tue, 16 May 2023 20:32:56 +0300 Message-ID: <86ttwckwqf.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> 1. (setq debug-on-error t enable-recursive-minibuffers t) >>> 2. M-: (or any other prompt like 'M-x') >>> 3. Resize the minibuffer window e.g. with the mouse to at least 4 lines high >>> 4. M-x windmove-swap-states-up RET >>> 5. Click on the bottom window >>> 6. C-x t 2 >>> 7. Click on the bottom window >>> 8. C-x t 2 >>> >>> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") >>> delete-other-windows-internal(# #) >>> delete-other-windows() >>> tab-bar-new-tab-to() >>> tab-new(nil) >> >> Maybe the simplest fix is just not to create such a broken >> window configuration: >> >> diff --git a/lisp/windmove.el b/lisp/windmove.el >> index 06ce16c0d42..57511291588 100644 >> --- a/lisp/windmove.el >> +++ b/lisp/windmove.el >> @@ -724,6 +724,8 @@ windmove-swap-states-in-direction >> nil windmove-wrap-around 'nomini))) >> (cond ((or (null other-window) (window-minibuffer-p other-window)) >> (user-error "No window %s from selected window" dir)) >> + ((window-minibuffer-p (selected-window)) >> + (user-error "Selected window is the minibuffer")) >> (t >> (window-swap-states nil other-window))))) > > This is another patch that could be installed either to emacs-29 or master. This guard is pushed to master. But the root problem still persists. It can be reproduced in emacs-28/29/30: 0. emacs -Q 1. M-x 2. C-x t 2 3. C-x o ;; switches to the minibuffer 4. C-x t 2 Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") delete-other-windows-internal(# #) delete-other-windows() tab-bar-new-tab-to() tab-new(nil) funcall-interactively(tab-new nil) command-execute(tab-new) From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 17:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16842595782511 (code B ref 62427); Tue, 16 May 2023 17:53:02 +0000 Received: (at 62427) by debbugs.gnu.org; 16 May 2023 17:52:58 +0000 Received: from localhost ([127.0.0.1]:47685 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyyr4-0000eQ-90 for submit@debbugs.gnu.org; Tue, 16 May 2023 13:52:58 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:48101) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyyr1-0000eC-W4 for 62427@debbugs.gnu.org; Tue, 16 May 2023 13:52:57 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id A5444E0002; Tue, 16 May 2023 17:52:48 +0000 (UTC) From: Juri Linkov In-Reply-To: <86ttwckwqf.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 16 May 2023 20:32:56 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> Date: Tue, 16 May 2023 20:52:05 +0300 Message-ID: <861qjgkvui.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > But the root problem still persists. > It can be reproduced in emacs-28/29/30: > > 0. emacs -Q > 1. M-x > 2. C-x t 2 > 3. C-x o ;; switches to the minibuffer > 4. C-x t 2 > > Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") > delete-other-windows-internal(# #) > delete-other-windows() > tab-bar-new-tab-to() > tab-new(nil) > funcall-interactively(tab-new nil) > command-execute(tab-new) Martin, could you please help to debug this problem. Does the error occur because the window configuration is broken? From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 May 2023 18:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168426142115696 (code B ref 62427); Tue, 16 May 2023 18:24:01 +0000 Received: (at 62427) by debbugs.gnu.org; 16 May 2023 18:23:41 +0000 Received: from localhost ([127.0.0.1]:48030 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyzKn-000456-EZ for submit@debbugs.gnu.org; Tue, 16 May 2023 14:23:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:34210) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pyzKl-00044p-9K for 62427@debbugs.gnu.org; Tue, 16 May 2023 14:23:39 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyzKe-00024h-Rp; Tue, 16 May 2023 14:23:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ntnU+GLAzX5mxrPcx7o/9ApZeJMX1WaL3yMzvTK/ssM=; b=XzmNw1jx4FWW XkJcw3vtvBZIbhFR54vkz2TTkM5s7ZaBVsxsFTIpcIAi2zHCu31S+X8Km1CH5A5Jjdr9f1jG3PN3S WDe9jnNzJAyNjnizE0O3BddawkAsOblC+KgtjpLxZKUgB5K/noozkqqx1w0iyZpwTGtcRWZI2Br54 rjrzrK+9Yv2xzUTR5aY/wC7Q+sLvdWh6deReaDB6La3g3EEyG0ERpGSieVqDRRwmRIquO3uCsIqgl MLUWCRObYXImwUWfHF11lPOadRjcUhk0xoTgm5crMfVaVs4zCS8/K/upoDipiLfUm6I78r7tjOkM9 NU4ZI7xje4PTIPhK3eqxYw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pyzKe-0002jp-5e; Tue, 16 May 2023 14:23:32 -0400 Date: Tue, 16 May 2023 21:23:39 +0300 Message-Id: <83a5y4yw2c.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86ttwckwqf.fsf@mail.linkov.net> (message from Juri Linkov on Tue, 16 May 2023 20:32:56 +0300) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Date: Tue, 16 May 2023 20:32:56 +0300 > > This guard is pushed to master. But the root problem still persists. > It can be reproduced in emacs-28/29/30: > > 0. emacs -Q > 1. M-x > 2. C-x t 2 > 3. C-x o ;; switches to the minibuffer > 4. C-x t 2 Why does the last command in this scenario make sense? The below also signals an error: emacs -Q M-x C-x 2 Looks appropriate to me. If you are arguing for a better error message in your case, I'm okay with diagnosing that specific situation and emitting a more focused, user-friendly error. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 08:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168431120910922 (code B ref 62427); Wed, 17 May 2023 08:14:02 +0000 Received: (at 62427) by debbugs.gnu.org; 17 May 2023 08:13:29 +0000 Received: from localhost ([127.0.0.1]:48831 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzCHo-0002q6-Gz for submit@debbugs.gnu.org; Wed, 17 May 2023 04:13:28 -0400 Received: from mout.gmx.net ([212.227.17.22]:51301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzCHm-0002ps-Ci for 62427@debbugs.gnu.org; Wed, 17 May 2023 04:13:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1684311200; i=rudalics@gmx.at; bh=NanqNLK70wtmUNhfp20MJSvzGBpAnqJyi1F4+AiOToM=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=gOoYzhPtE6gG4cmz7Na0mb+DOqv/ZII4Q0+BN3waQ3JWD4QBMnYgbBjXtn5TsQXbT NOjf9ZTneV5p+I+ZvOHybr7p0NlCCSe7xCNngUKt6DT4eyKBmWjsq+3ifz1uXlP2/g HzG50Cf+JAGpynBjYNQ5IaixPWT+1svw6f/Vhtlondzucv96IxwNefdN8FPnZFQSRI YQ4cO6GrixJCjYphNQ7jRVPpB+6ipYBgUUET/0Z9J1P26xmFa/YKjtJZYQRTRuc2RS b+W2pZa2RWBWZeiU0ssdScmWYYUcQnuAql8gnksaK9Qyms+V9x/ZgB0JqtXizxANZN W2xoqyhCo9Nmw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([212.95.5.123]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Mt79F-1qJC6g46v3-00tTfx; Wed, 17 May 2023 10:13:20 +0200 Content-Type: multipart/mixed; boundary="------------72BcL4HJVnsGfFTKQ8r89NtF" Message-ID: <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> Date: Wed, 17 May 2023 10:13:18 +0200 MIME-Version: 1.0 Content-Language: en-US References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <861qjgkvui.fsf@mail.linkov.net> X-Provags-ID: V03:K1:Y/1q6+JWFwy9QHzCYrk4UxjFNrk9881ngnwtavb15L3+w4b+nGB j0ofUnG7EaKoY8e4mobqU5gLmoDdwsI11UO+dB1+e7+5S04Zurwq7phb9QnmtNogy+KPs1V 3DWwSuX5Tsdp/Za+M6o/eyvj4plKDkUc+wUUYRFrtM6e12wiKnNcYQCgHnblnShI1OYvglI vQTDT3jh3oUfuYomKV28Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:w+gX7wSccFc=;gbJM/p1Hn50tFGEy/6h3VHpJwKh FEXQi1ejyLWLESu56bB7zZwciYOcIrgiNUQ4fV+3V3dRq5any60y6okBLMBUrmd3O/DhmU8Rd o/s+vnZTeRwsv6K4tIfwFq3y23Lz7hv5hBflou7MD07wTEDCYrBRgBUf+5JBZZHYYmOt4KiB8 EU40/zqTmMNm8FLBsWXKVuZuOItqHSZ7ZeZY9YEnopAj4CJ4mJrDb/gky4SVbq6wBQeg7pGYV dGAKRx/zdsmfLHCnxxOvoP1e5JirzpCFP80zMJXYHOrLqLHSzkI76PyMDEtMYxb/vfSqiDVvO /UVgvj4gcfTZkY67GisIwfFpEj1kU2tRgr/6TjZbpBHtl14aN8n4SDVU5pWhZTUcApeytchOF MCHRzHVF6eni1qfUN3g7vy9RY/12Jj62XpIAKpHyvtEvOVT1s257XHnCddLCWOIpeN1Sgh/rc ipZJADVTe4t2qiKU84QB+jMntEcuklcyQgqtyeRAjsMl3SIyM8d8QZNlI6a1KridPf3gbo1D2 b99sSbYEvZmywA7TX2t0b5Je08mB0r3J5idmozPS4O5V9SSF6jE+E9RqUpShWtcjHoDXFmqJA 08wAXIxAyINeNYUKV1J8BrO+JJdcGYNA+gtYakn7A0ad59/MS7TZbFMi3cQK9xv12Y+n/E+eW 1+LkijJb49l1U5cV0fpwH3HlbhbCyGhEDNhss45AVlmIBvTFpgbQnK2LIbBn81bcdYYB1H1YM 9OWWULt40OTEe9foEUS6T54TO1QW7FQylRASFkpHfFHBeHM6bMR4XDlr/pzluHQ5T+yzMNdq8 P0lh21f0Z//I4lz3lO+jdOA7yeKVpmeOw8sR0IjUFxQ2l6EOTF4mkwjDXSINCLsvhI5SNeVDw vHp8jgFEGYnkJ4EXG2rpbIOK5bYH6fSWQ45JcjbmGPGafFVa9PLUgRQ6z4gVRT7ERq/7rPX20 c/VGmg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is a multi-part message in MIME format. --------------72BcL4HJVnsGfFTKQ8r89NtF Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >> 0. emacs -Q >> 1. M-x >> 2. C-x t 2 >> 3. C-x o ;; switches to the minibuffer >> 4. C-x t 2 >> >> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") >> delete-other-windows-internal(# #) >> delete-other-windows() >> tab-bar-new-tab-to() >> tab-new(nil) >> funcall-interactively(tab-new nil) >> command-execute(tab-new) > > Martin, could you please help to debug this problem. > > Does the error occur because the window configuration is broken? No. Binding 'ignore-window-parameters' to t skips the usual error message that you "Can't expand minibuffer to full frame". Does the attached patch fix it? martin --------------72BcL4HJVnsGfFTKQ8r89NtF Content-Type: text/x-patch; charset=UTF-8; name="delete-other-windows.diff" Content-Disposition: attachment; filename="delete-other-windows.diff" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL2xpc3Avd2luZG93LmVsIGIvbGlzcC93aW5kb3cuZWwKaW5kZXggMDE2 ZDUzZmZiZGQuLjU5OTRiNjgxNmVmIDEwMDY0NAotLS0gYS9saXNwL3dpbmRvdy5lbAorKysg Yi9saXNwL3dpbmRvdy5lbApAQCAtNDM1NiwxMCArNDM1Niw3IEBAIGRlbGV0ZS1vdGhlci13 aW5kb3dzCiAJICAgIChlcnJvciAiUm9vdCBvZiBhdG9taWMgd2luZG93IGlzIHJvb3Qgd2lu ZG93IG9mIGl0cyBmcmFtZSIpCiAJICAodGhyb3cgJ2RvbmUgKGRlbGV0ZS1vdGhlci13aW5k b3dzIGF0b20tcm9vdCkpKSkKICAgICAgICAoKHdpbmRvdy1wYXJhbWV0ZXIgd2luZG93ICd3 aW5kb3ctc2lkZSkKLQkoZXJyb3IgIkNhbm5vdCBtYWtlIHNpZGUgd2luZG93IHRoZSBvbmx5 IHdpbmRvdyIpKQotICAgICAgICgoYW5kICh3aW5kb3ctbWluaWJ1ZmZlci1wIHdpbmRvdykK LQkgICAgIChub3QgKGVxIHdpbmRvdyAoZnJhbWUtcm9vdC13aW5kb3cgd2luZG93KSkpKQot CShlcnJvciAiQ2FuJ3QgZXhwYW5kIG1pbmlidWZmZXIgdG8gZnVsbCBmcmFtZSIpKSkKKwko ZXJyb3IgIkNhbm5vdCBtYWtlIHNpZGUgd2luZG93IHRoZSBvbmx5IHdpbmRvdyIpKSkKIAog ICAgICAgKGNvbmQKICAgICAgICAoKG9yIGlnbm9yZS13aW5kb3ctcGFyYW1ldGVycwpAQCAt NDM5NSwxNSArNDM5MiwyMSBAQCBkZWxldGUtb3RoZXItd2luZG93cwogICAgICAgICAgICAg ICAoZXJyb3IgbmlsKSkpKQogICAgICAgICAodGhyb3cgJ2RvbmUgbmlsKSkpCiAKLSAgICAg IDs7IElmIFdJTkRPVyBpcyB0aGUgbWFpbiB3aW5kb3cgb2YgaXRzIGZyYW1lIGRvIG5vdGhp bmcuCi0gICAgICAoaWYgKGVxIHdpbmRvdyBtYWluKQotICAgICAgICAgIDs7IEdpdmUgYSBt ZXNzYWdlIHRvIHRoZSB1c2VyIGlmIHRoaXMgaGFzIGJlZW4gY2FsbGVkIGFzIGEKLSAgICAg ICAgICA7OyBjb21tYW5kLgotICAgICAgICAgICh3aGVuIChhbmQgaW50ZXJhY3RpdmUKLSAg ICAgICAgICAgICAgICAgICAgIChub3QgKG9yIGV4ZWN1dGluZy1rYmQtbWFjcm8gbm9uaW50 ZXJhY3RpdmUpKSkKLSAgICAgICAgICAgIChtZXNzYWdlICJObyBvdGhlciB3aW5kb3dzIHRv IGRlbGV0ZSIpKQorICAgICAgKGNvbmQKKyAgICAgICA7OyBJZiBXSU5ET1cgaXMgdGhlIG1h aW4gd2luZG93IG9mIGl0cyBmcmFtZSBkbyBub3RoaW5nLgorICAgICAgICgoZXEgd2luZG93 IG1haW4pCisgICAgICAgIDs7IEdpdmUgYSBtZXNzYWdlIHRvIHRoZSB1c2VyIGlmIHRoaXMg aGFzIGJlZW4gY2FsbGVkIGFzIGEKKyAgICAgICAgOzsgY29tbWFuZC4KKyAgICAgICAgKHdo ZW4gKGFuZCBpbnRlcmFjdGl2ZQorICAgICAgICAgICAgICAgICAgIChub3QgKG9yIGV4ZWN1 dGluZy1rYmQtbWFjcm8gbm9uaW50ZXJhY3RpdmUpKSkKKyAgICAgICAgICAobWVzc2FnZSAi Tm8gb3RoZXIgd2luZG93cyB0byBkZWxldGUiKSkpCisgICAgICAgKChhbmQgKHdpbmRvdy1t aW5pYnVmZmVyLXAgd2luZG93KQorCSAgICAgKG5vdCAoZXEgd2luZG93IChmcmFtZS1yb290 LXdpbmRvdyB3aW5kb3cpKSkpCisJKHVzZXItZXJyb3IgIkNhbid0IGV4cGFuZCBtaW5pYnVm ZmVyIHRvIGZ1bGwgZnJhbWUiKSkKKyAgICAgICAodAogCShkZWxldGUtb3RoZXItd2luZG93 cy1pbnRlcm5hbCB3aW5kb3cgbWFpbikKLQkod2luZG93LS1jaGVjayBmcmFtZSkpCisJKHdp bmRvdy0tY2hlY2sgZnJhbWUpKSkKKwogICAgICAgOzsgQWx3YXlzIHJldHVybiBuaWwuCiAg ICAgICBuaWwpKSkKIAo= --------------72BcL4HJVnsGfFTKQ8r89NtF-- From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16843439909314 (code B ref 62427); Wed, 17 May 2023 17:20:02 +0000 Received: (at 62427) by debbugs.gnu.org; 17 May 2023 17:19:50 +0000 Received: from localhost ([127.0.0.1]:50866 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoY-0002QA-HZ for submit@debbugs.gnu.org; Wed, 17 May 2023 13:19:50 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:50333) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoX-0002Pf-69 for 62427@debbugs.gnu.org; Wed, 17 May 2023 13:19:49 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 4FBA240002; Wed, 17 May 2023 17:19:41 +0000 (UTC) From: Juri Linkov In-Reply-To: <83a5y4yw2c.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 16 May 2023 21:23:39 +0300") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <83a5y4yw2c.fsf@gnu.org> Date: Wed, 17 May 2023 19:32:36 +0300 Message-ID: <86lehmor4r.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> 0. emacs -Q >> 1. M-x >> 2. C-x t 2 >> 3. C-x o ;; switches to the minibuffer >> 4. C-x t 2 > > Why does the last command in this scenario make sense? Because the same works in the step 2 above. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 17:20:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16843439959332 (code B ref 62427); Wed, 17 May 2023 17:20:03 +0000 Received: (at 62427) by debbugs.gnu.org; 17 May 2023 17:19:55 +0000 Received: from localhost ([127.0.0.1]:50869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoc-0002QS-Px for submit@debbugs.gnu.org; Wed, 17 May 2023 13:19:55 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:35875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKoa-0002Pn-B9 for 62427@debbugs.gnu.org; Wed, 17 May 2023 13:19:52 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 7E815240002; Wed, 17 May 2023 17:19:45 +0000 (UTC) From: Juri Linkov In-Reply-To: <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> (martin rudalics's message of "Wed, 17 May 2023 10:13:18 +0200") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> Date: Wed, 17 May 2023 19:39:10 +0300 Message-ID: <86ilcqnbsp.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> 1. M-x >>> 2. C-x t 2 >>> 3. C-x o ;; switches to the minibuffer >>> 4. C-x t 2 >>> >>> Debugger entered--Lisp error: (error "Specified root is not an ancestor of specified win...") >>> delete-other-windows-internal(# #) >>> delete-other-windows() >>> tab-bar-new-tab-to() >>> tab-new(nil) >>> funcall-interactively(tab-new nil) >>> command-execute(tab-new) >> >> Does the error occur because the window configuration is broken? > > No. Binding 'ignore-window-parameters' to t skips the usual error > message that you "Can't expand minibuffer to full frame". Does the > attached patch fix it? This is just a better error message. After 'M-x C-x t 2', 'minibuffer-selected-window' returns non-nil that is used in 'tab-bar-new-tab-to' before calling 'delete-other-windows': ;; Handle the case when it's called in the active minibuffer. (when (minibuffer-selected-window) (select-window (minibuffer-selected-window))) The problem is that after 'M-x C-x t 2 C-x o C-x t 2', 'minibuffer-selected-window' returns nil while the current buffer is the minibuffer. This is because after the first 'C-x t 2', a new window is created by: ;; Create a new window to get rid of old window parameters ;; (e.g. prev/next buffers) of old window. (split-window) (delete-window) so 'minibuffer-selected-window' refers to the deleted window, therefore nil. Would it be possible to update 'minibuf_selected_window' with a new window after deleting the original window? From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 17 May 2023 17:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16843442579897 (code B ref 62427); Wed, 17 May 2023 17:25:01 +0000 Received: (at 62427) by debbugs.gnu.org; 17 May 2023 17:24:17 +0000 Received: from localhost ([127.0.0.1]:50887 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKsr-0002ZY-Cz for submit@debbugs.gnu.org; Wed, 17 May 2023 13:24:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52378) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzKsp-0002ZJ-Ci for 62427@debbugs.gnu.org; Wed, 17 May 2023 13:24:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzKsj-0007ty-Th; Wed, 17 May 2023 13:24:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jnoeJER4o08CVH2L7M9hg8nx/dkcWNGchElB/7pErbc=; b=FOKbYHN7O6pj F7BRjAAzZf5OENDT/rR386S/M1VITUV/9o3l08esfVbl+qCj4uTWH3rJvupo8mQCoKBU0KTunIz4W sOFp6lLb0ACzb3d43q1yjOOWLFNKZrDDq35ESAklrWpSd2aXr/Ift03X/8MFC6CtMCjbGGD97hh4j Ui9sAsjutLYeYiEV3/KKGqZmaKEDNpcddg8iRh5FwfLUwTvjfKiouLCp6tl0NiFVMHzbeiTNSBHxs M2/jAiZW9fkNSyqUug9/4TgbC1pyF3N6ijZ184mhZx5VJzuxbaUcJkS1iA3K7Dt5/q6oN/HCOEeZi rxtnB9XBtOCONNA1MnmlyA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pzKsj-0006Qu-Dm; Wed, 17 May 2023 13:24:09 -0400 Date: Wed, 17 May 2023 20:24:20 +0300 Message-Id: <83y1lmx457.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86lehmor4r.fsf@mail.linkov.net> (message from Juri Linkov on Wed, 17 May 2023 19:32:36 +0300) References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <83a5y4yw2c.fsf@gnu.org> <86lehmor4r.fsf@mail.linkov.net> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Juri Linkov > Cc: 62427@debbugs.gnu.org > Date: Wed, 17 May 2023 19:32:36 +0300 > > >> 0. emacs -Q > >> 1. M-x > >> 2. C-x t 2 > >> 3. C-x o ;; switches to the minibuffer > >> 4. C-x t 2 > > > > Why does the last command in this scenario make sense? > > Because the same works in the step 2 above. In step 2 we are not in the minibuffer. From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 08:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.16843986839048 (code B ref 62427); Thu, 18 May 2023 08:32:02 +0000 Received: (at 62427) by debbugs.gnu.org; 18 May 2023 08:31:23 +0000 Received: from localhost ([127.0.0.1]:51948 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzZ2g-0002Lr-Tw for submit@debbugs.gnu.org; Thu, 18 May 2023 04:31:23 -0400 Received: from mout.gmx.net ([212.227.17.22]:34183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzZ2e-0002Le-J2 for 62427@debbugs.gnu.org; Thu, 18 May 2023 04:31:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1684398674; i=rudalics@gmx.at; bh=3fpagMktxGaXZEGo9tTjSKJwNKeLrPhCXOtJ00BQlzg=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=MITtcgYW0vlGj0nuZwZLIE+3iPEmEQNojUL8Fk+oHLeU9YTLIicWNrD+4lNaA2g8R cFcI1BlDhvkP7neDEs4bnjHbAtIP0iudd8MHtml0milIIuSP5VfL5iQ3aCbb4uvxPG ojJE4nvoN0y7WKmn8ehJlY0dg/K5Z8NvZMks1WXEZW+KcIo+SaM5aRULiNh5Nu78qi Mqq5mNeFkzygltQXBGi17x2bKFf0D3zDx8EsJQk9yur2DetUQMEAbrCNqNz5RA0BZ8 4Cf0H3tbPYzkUeWqkAoG/CJYQIgzIXwW0cJjbEjGT7wY9HMo5NH/A4Ua2Vvzp4xmsK HhgWiY0jwZdwg== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([213.142.97.161]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MTiPl-1pZtxX1RT3-00U2y9; Thu, 18 May 2023 10:31:14 +0200 Message-ID: <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> Date: Thu, 18 May 2023 10:31:13 +0200 MIME-Version: 1.0 Content-Language: en-US References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> <86ilcqnbsp.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86ilcqnbsp.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:XYO0GKA7AzVh+HTurWh9vQ0yklG55XRwgoUigr3Ai4drwpKkbqm nOd1kmkoHzBL/57t7uNLZ9hYUElKOt9mBwcLjkZhLruXK8QNEzMQQrH0I2WCYlN9EvtrY68 WtzBFb+KXcApQgaAp0Jj6+szhmDEubvnmyPlnFneAwNWVej92sHbVy+vMVLT5L5qoV/LYm3 16acYnFWt+bdNbLdOYyUA== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:8UUBNXqtUSA=;nS+hFJhpRqZa3nQBPCLzMRsOJdR dYIzJEohTDo1JyNFv5CANZc8/JVLcee/rlYXQ7JhNPm+ADLlaxjlM0Lj/9OTck2PTRB2hmOmR MADE21ID72btYiQR3oPcaH18HdrU2qNwFgm+Ni8BikcmOoUXe9TatulTllZuwrvsNkjXEVQfV J/c8/NGvrLbLEiUkTrU435uoJEE4GM4dJzi46R+z4zfDP6GGZgFiSgbl6MDrgMqfL8Njri3GE QheKRPiaXC6qmbqanw4uTANhijiBeESRnvM0hMEgUsZAeCtPsRFZNvLEKNvk82VNyR3Cdxbyr tX8rWPT3eTMdPN5HHGuyDtGDJs5CnmcTVcheTPjXBwdjGkeA3na8mKb6v7Cbzm0UcoQWf6h4l Z0A+VtZh4HCW36c7+5psb3X3+7ilzIYaTQ/ONKYTFHlLEzZcZI75q76ZkbBEOVfh++OpcWDgf LC6MxUkf7i/p0dscHKxQ9xratoqUzndhqE3z3PnlBLDH6kRiJcspQNoB8Sf/knLII5zbT5IND F3Dp//A0LVld93y5Di7sUubeAaqx/rY6gYST4ghm4Xrr8zP1bcvH3uWuNdTLnojQAc4Jbdjv+ Oua60EuXaEzMSuvLvv9xoMBXIpvAczUhbYrzwTkbG2CoLBcjwv4fGYJ02vRFVtpM8EjnyUwJV v0j9YHq0yJDSx4x6pIVMeLWbgBiTB2KmywcRUxUrPiVQ2Qu4jPczLWGOb5Rbss32dJnGSAvyb 7S+XhgUdDC0itwwUpEb2yfSlTe44lXrOpvnzVp2PCpHTSl991Shl/46shRsm4zx2fhYSLisxo ANhFbhJ0X1LgI3xnh91xlGSDeYQ5QT9sQ0PSW5VCymPiGGOdqlocV2ISLvuMT4bNpDXDUFXgi BSh3vOnJbsn8U97C0HzC9WLZ1WdL77smh6SeE8ZSTpfSlU48aLIMpG7BiFPdGRkFZH/eJnGAp FnRyygI10tvpl+14eSwAVwkewqc= X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > Would it be possible to update 'minibuf_selected_window' > with a new window after deleting the original window? Not really. We'd change existing behavior that might rely on the fact that 'minibuffer-selected-window' returns nil once it got deleted. Besides, it might not make you happy anyway. With the default of 'minibuffer-follows-selected-frame', a user may correspond with a minibuffer window that resides on another frame than that returned by 'minibuffer-selected-window' and neither minibuf_selected_window nor Vminibuf_scroll_window may make sense any more in such context. Why don't you use 'get-mru-window' on the frame that owns the 'minibuffer-window' instead of 'minibuffer-selected-window'? martin From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 18 May 2023 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168442568427166 (code B ref 62427); Thu, 18 May 2023 16:02:02 +0000 Received: (at 62427) by debbugs.gnu.org; 18 May 2023 16:01:24 +0000 Received: from localhost ([127.0.0.1]:54252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzg4C-000745-5G for submit@debbugs.gnu.org; Thu, 18 May 2023 12:01:24 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:58829) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzg49-00073p-2g for 62427@debbugs.gnu.org; Thu, 18 May 2023 12:01:22 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id D854CFF803; Thu, 18 May 2023 16:01:13 +0000 (UTC) From: Juri Linkov In-Reply-To: <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> (martin rudalics's message of "Thu, 18 May 2023 10:31:13 +0200") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> <86ilcqnbsp.fsf@mail.linkov.net> <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> Date: Thu, 18 May 2023 18:46:28 +0300 Message-ID: <86wn153b43.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Would it be possible to update 'minibuf_selected_window' >> with a new window after deleting the original window? > > Not really. We'd change existing behavior that might rely on the fact > that 'minibuffer-selected-window' returns nil once it got deleted. > > Besides, it might not make you happy anyway. With the default of > 'minibuffer-follows-selected-frame', a user may correspond with a > minibuffer window that resides on another frame than that returned by > 'minibuffer-selected-window' and neither minibuf_selected_window nor > Vminibuf_scroll_window may make sense any more in such context. > > Why don't you use 'get-mru-window' on the frame that owns the > 'minibuffer-window' instead of 'minibuffer-selected-window'? Thanks for the idea, this works perfectly: diff --git a/lisp/tab-bar.el b/lisp/tab-bar.el index 42fc5a23990..0ae7fb44b27 100644 --- a/lisp/tab-bar.el +++ b/lisp/tab-bar.el @@ -1339,8 +1340,7 @@ tab-bar-select-tab (ws ;; `window-state-put' fails when called in the minibuffer - (when (minibuffer-selected-window) - (select-window (minibuffer-selected-window))) + (when (minibufferp) (select-window (get-mru-window))) (window-state-put ws nil 'safe))) ;; Select the minibuffer when it was active before switching tabs @@ -1575,8 +1575,7 @@ tab-bar-new-tab-to (when tab-bar-new-tab-choice ;; Handle the case when it's called in the active minibuffer. - (when (minibuffer-selected-window) - (select-window (minibuffer-selected-window))) + (when (minibufferp) (select-window (get-mru-window))) (let ((ignore-window-parameters t) (window--sides-inhibit-check t)) (if (eq tab-bar-new-tab-choice 'clone) From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: martin rudalics Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2023 07:32:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168448151817938 (code B ref 62427); Fri, 19 May 2023 07:32:01 +0000 Received: (at 62427) by debbugs.gnu.org; 19 May 2023 07:31:58 +0000 Received: from localhost ([127.0.0.1]:55318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzuak-0004fG-32 for submit@debbugs.gnu.org; Fri, 19 May 2023 03:31:58 -0400 Received: from mout.gmx.net ([212.227.17.20]:51981) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pzuah-0004f0-Qh for 62427@debbugs.gnu.org; Fri, 19 May 2023 03:31:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.at; s=s31663417; t=1684481509; i=rudalics@gmx.at; bh=iuRGeu5fgduyVA1D+gXNGkGTQNms3fU1G5eMqaiI+r4=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From:In-Reply-To; b=VvdxBg6CgF/iGg6GDPTG9/PwTmBZ38EbLat1kRlfpPgkHcwvIpcSmgYXIPSJfedlG uDNOAaqXEUIsP86jVipSy5xA7sh9bi6l0Gm3XvvWrYLGQ/AsqEckmXWD2qmxZWezzj bFu3Xo0rgDwWRHNlF/b/AJmQ3RLeynuPjZi7uFt/bFVH4m/C17vxksapgozoHM7SLD sdRAvCIhuXHqPVWyHz2E9W7ffSoVAL+p/b2oc81Bf+Rtb//sSqsN2BoEytKvdDVClJ ZS1lr0fvgfAhmhhRUOyhp3+cC+Wgpq0zQ8NhdR6NNnBKwD34soqNoMjXF9WFEdvBTN 2Afbo1UQB3vjw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.100] ([46.125.249.114]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N3KPq-1q8Kmt2LZa-010OKo; Fri, 19 May 2023 09:31:49 +0200 Message-ID: <2b1dade6-740f-6add-b6f0-4677a1c09789@gmx.at> Date: Fri, 19 May 2023 09:31:48 +0200 MIME-Version: 1.0 Content-Language: en-US References: <875yapvoxh.fsf@fastmail.com> <86jzz4mynj.fsf@mail.linkov.net> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> <86ilcqnbsp.fsf@mail.linkov.net> <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> <86wn153b43.fsf@mail.linkov.net> From: martin rudalics In-Reply-To: <86wn153b43.fsf@mail.linkov.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:E4gaV8BknpeDCfV+4CIpvrVw9ByNoYUm6cTE1RzCiar5IwvoTUo hnVAIxwBRZSDNFvH5yJNwbgcfQNLE3rUSfnsNMf/IRRXLA57b/ImSWmdh5MEDK5Ohtk335B wk8YBEb8ZwAzKsH9Yoky05ZQPzSzfEBNiTAlowsQw8m9S6JJP0VTLBCed538bGQ5mjwmOku OR13s9gc1sc71m3HKrWlg== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:IZvRlICM9hk=;J0ekZdH5D/LDYxhL634TKuY/bK7 MN5tw8gogno53/ji3fRzsZN9CpUq+TdAJ50cvbmX5/npwPd6alXagNltsT+aawoWNT6McOSUY fw+FWo4cN0TkQPTWzMnDcHAznnIcNX2XJ0jDNCf7FpoVR58bDD+vbIWFHgRwaKYhc3Qz1Cu5b SWqLbq75jbccPvpXNVrZZaepGrUTbyVJ2U84ZzypFTikiBCO37Da9g+Q7J8Rz1bP5EEwVksGC 9BX/abheQG6eEy4815szZjPC0BSP14lieTq2rHw86pD8dBFQt8mG0hzfIpO9/jbBOh2ksp9si VrMNo0vORBIs2k1JgPf0OpneF1EjtB4unDzD0+3pCxxJ2oZOGYMtaur8m2bfgqmb8R8xK4dhu cMapF7jVRg4utoJL8U4GBF8NUbAKz99efKe1cOAMH1fbkW7rtUA+liEgT2mI8SfGLNkNuyRQz +gW97KYqPDGZR3iumxr4JMGiJpZ1FPDaREs6ksfy6tgA5IXNqRHTqk3XHmiamDIZHKvHZ2X5o RSr9B1X0qZDDO6HpZjPJk8J2kgoZU0i72EDKleWw8uWA5LIJ5DLxrTk9+ziLu3w8RbuiIrU+F 6DuSqJhAS5hAEZOPAWD5XgCl7VHS23XNxkZB/HnhwRRRnYO4r/dfve4kLiyuoygU7KKCQ289i Ur8YfZ3vn5XyEC5CKlnF0PKRgqiIx+JT7mMJu+Sw1ytoq18MiFZKIoQFeI1BNUKwZkBr+tvb+ 7+obutDembqHcpLVVlFHlRLg9z3kRWINwkqmv0tvSxfvb1pvoWjKWIK4UePvucLiWbO0SwHLL cgathgn3pRZjsE8WlCr4T3iovXPrqS/IM7IMdGV+EFldVjn0Xip8HVzN/eJS0yF5LVphI7rdR 6NJv2HZbayzg/L7StuPViGwXPxFgoD8vEOZ80TwKupjVB3dTBg6DbcEV3Bbzke9EaE9EdgxXC tg/RGw== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > + (when (minibufferp) (select-window (get-mru-window))) Here and below I'd use (when (window-minibuffer-p) because it more clearly demonstrates the idea and also handles the (unlikely) case where a minibuffer is shown in a normal window. > (window-state-put ws nil 'safe))) > > ;; Select the minibuffer when it was active before switching tabs > @@ -1575,8 +1575,7 @@ tab-bar-new-tab-to > > (when tab-bar-new-tab-choice > ;; Handle the case when it's called in the active minibuffer. > - (when (minibuffer-selected-window) > - (select-window (minibuffer-selected-window))) > + (when (minibufferp) (select-window (get-mru-window))) > (let ((ignore-window-parameters t) > (window--sides-inhibit-check t)) > (if (eq tab-bar-new-tab-choice 'clone) You might want to try this with multiple frames (some of them without their own minibuffer window) jumping from one frame to another within the scope of 'read-from-minibuffer'. martin From unknown Sun Jun 22 03:57:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62427: tab-bar-new-tab-to now handles cases with multiple side-windows Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 19 May 2023 18:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62427 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: martin rudalics Cc: 62427@debbugs.gnu.org Received: via spool by 62427-submit@debbugs.gnu.org id=B62427.168452021332292 (code B ref 62427); Fri, 19 May 2023 18:17:02 +0000 Received: (at 62427) by debbugs.gnu.org; 19 May 2023 18:16:53 +0000 Received: from localhost ([127.0.0.1]:57375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q04eq-0008Om-LG for submit@debbugs.gnu.org; Fri, 19 May 2023 14:16:52 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q04el-0008Nw-Ip for 62427@debbugs.gnu.org; Fri, 19 May 2023 14:16:47 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 465C9E0009; Fri, 19 May 2023 18:16:40 +0000 (UTC) From: Juri Linkov In-Reply-To: <2b1dade6-740f-6add-b6f0-4677a1c09789@gmx.at> (martin rudalics's message of "Fri, 19 May 2023 09:31:48 +0200") Organization: LINKOV.NET References: <875yapvoxh.fsf@fastmail.com> <83cz4wb0vz.fsf@gnu.org> <865yamhdx7.fsf@mail.linkov.net> <83cz4u9uz1.fsf@gnu.org> <86jzz2f8si.fsf@mail.linkov.net> <83sfdq86pi.fsf@gnu.org> <835yal82ta.fsf@gnu.org> <86a5zuw5oo.fsf@mail.linkov.net> <87cz4oq485.fsf@fastmail.com> <86pm8nfoja.fsf@mail.linkov.net> <867cuukuvj.fsf@mail.linkov.net> <86lejajex8.fsf@mail.linkov.net> <86h6t3q3nt.fsf@mail.linkov.net> <86ttwckwqf.fsf@mail.linkov.net> <861qjgkvui.fsf@mail.linkov.net> <0c52f6ed-c3e2-6d9e-6d57-6f3779257b25@gmx.at> <86ilcqnbsp.fsf@mail.linkov.net> <3a021a53-814d-3721-31fb-b77f4087a455@gmx.at> <86wn153b43.fsf@mail.linkov.net> <2b1dade6-740f-6add-b6f0-4677a1c09789@gmx.at> Date: Fri, 19 May 2023 21:14:27 +0300 Message-ID: <86lehk9ojh.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> + (when (minibufferp) (select-window (get-mru-window))) > > Here and below I'd use > > (when (window-minibuffer-p) > > because it more clearly demonstrates the idea and also handles the > (unlikely) case where a minibuffer is shown in a normal window. Thanks, now pushed to emacs-29. >> (window-state-put ws nil 'safe))) >> >> ;; Select the minibuffer when it was active before switching tabs >> @@ -1575,8 +1575,7 @@ tab-bar-new-tab-to >> >> (when tab-bar-new-tab-choice >> ;; Handle the case when it's called in the active minibuffer. >> - (when (minibuffer-selected-window) >> - (select-window (minibuffer-selected-window))) >> + (when (minibufferp) (select-window (get-mru-window))) >> (let ((ignore-window-parameters t) >> (window--sides-inhibit-check t)) >> (if (eq tab-bar-new-tab-choice 'clone) > > You might want to try this with multiple frames (some of them without > their own minibuffer window) jumping from one frame to another within > the scope of 'read-from-minibuffer'. I confirm that this works correctly.