GNU bug report logs - #62416
30.0.50; Symbols skipped in the navigation in ruby-ts-mode

Previous Next

Full log

Message #31 received at 62416 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Juri Linkov <juri <at> linkov.net>
Cc: bosko.ivanisevic <at> gmail.com, 62416 <at> debbugs.gnu.org,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: bug#62416: 30.0.50; Symbols skipped in the navigation in 
 ruby-ts-mode
Date: Thu, 30 Mar 2023 00:47:58 -0700

Juri Linkov <juri <at> linkov.net> writes:

>>> This will break other cases, e.g.
>>>    b = %Q{This is a "string"}
>>>    c = %w!foo
>>>     bar
>>>     baz!
>>>    d = %(hello (nested) world)
>>> when point is after "b", 'C-M-f' will move to "c" instead of the end of
>>> line.
>>
>> That is because the string literals aren't recognized as sexps yet. Try
>> this:
>>
>> @@ -1129,8 +1129,11 @@ ruby-ts-mode
>>                              "block"
>>                              "do_block"
>>                              "begin"
>> -                            "binary"
>> -                            "assignment")))
>> +                            "integer"
>> +                            "simple_symbol"
>> +                            "string"
>> +                            "string_array"
>> +                            )))
>
> Thanks, this definitely is an improvement since it handles all mentioned cases.
>
> However, there are still a lot of more things that need fixing.
> When point is on the left curly bracket in
>
>   b = %Q{This is a "string"}
>
> 'C-M-f' doesn't move to the right curly bracket.
> Also double quotes inside the string are not matched by 'C-M-f'.
>
> In
>
>   d = %(hello (nested) world)
>
> 'C-M-f' doesn't move to the closing parens from opening parens.

Have someone fixed these two cases? Because when I tried to invoke
(treesit-forward-sexp), point moved to the closing bracket/paren.

Anyway, I just wonder if there’s any fundamental shortcoming with how
treesit-beginning/end-of-thing works?

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.