From unknown Sat Jun 21 03:10:48 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#62404 <62404@debbugs.gnu.org> To: bug#62404 <62404@debbugs.gnu.org> Subject: Status: --reflink=auto not falling back appropriately to standard copy in all cases Reply-To: bug#62404 <62404@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:10:48 +0000 retitle 62404 --reflink=3Dauto not falling back appropriately to standard c= opy in all cases reassign 62404 coreutils submitter 62404 P=C3=A1draig Brady severity 62404 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 09:03:20 2023 Received: (at submit) by debbugs.gnu.org; 23 Mar 2023 13:03:20 +0000 Received: from localhost ([127.0.0.1]:37491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfKb9-0006eJ-Ui for submit@debbugs.gnu.org; Thu, 23 Mar 2023 09:03:20 -0400 Received: from lists.gnu.org ([209.51.188.17]:52140) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfKb4-0006e8-Eg for submit@debbugs.gnu.org; Thu, 23 Mar 2023 09:03:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pfKb4-0007UT-7p for bug-coreutils@gnu.org; Thu, 23 Mar 2023 09:03:14 -0400 Received: from mail-wm1-x332.google.com ([2a00:1450:4864:20::332]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pfKaz-0000Ta-Hv for bug-coreutils@gnu.org; Thu, 23 Mar 2023 09:03:13 -0400 Received: by mail-wm1-x332.google.com with SMTP id l37so495654wms.2 for ; Thu, 23 Mar 2023 06:03:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679576587; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:sender:from:to:cc:subject :date:message-id:reply-to; bh=XO3mwqDzO04az0nFymZ8chPR205XZXjheOwa1b6qMSQ=; b=lLeZUN7c2t2aa5dR4H4F+Q7EDzm+wLo7SvTRSrhRrWLteP/mSXOkRPvelBYB8Fvf/M 4NLA0w/2IePZnUkqxuBLom4flpIb5HO9rwKufJ4r1jIyXgiUlYfSmEFM7ijWP5a+1hwA ljei8Pjp5Ufi5AoOqzjW094ag3LxiQG8P0kTklAW6uoStnPXGVjKRCQCD4oP0zolz1ar 8y4m7RZZDrWO1uJGbMlvFK9eNKyU09F9hUNr9xN4q5G/ZL+0YzCdzYDJEfa1UI4zu1BR ADAdbR3l7eNgjRraONm+5iptfTGPjrqeGnaG95fg8290LXCqbklt/Ua0H5KpOYO6+UDz sRpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679576587; h=content-transfer-encoding:subject:from:to:content-language :user-agent:mime-version:date:message-id:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XO3mwqDzO04az0nFymZ8chPR205XZXjheOwa1b6qMSQ=; b=sA8Dqh5++CAupyrOsT1LRo8TeDQUedfz9ATrJJYj3v2qt4LEJQNKxTAzOkzpQbV7db GMBWdxW0EStconXVFWHUHM5t7D1pQ2CIwyb1HkPSq80J5jHC2ew6+nZfWgxnots3slAr G6Icop2avjl1Eob7kEqJoLDSFfHJD0V+1Vxc0B2QU5ZdRTOPyNH90TnyiOC8AArSjvSk Iohcy0ZkR605yzhVV4rNAWfz2cCcqGbsaTHIsvjyx793tEY6jZzdbSeMD+6CZk7qpXkS fyds4ED4gFhIRGsci1W64EF37E6JOay58sJ8jacgLgE2fmtqR4Esz28eSv0ubanZIW1j KYzw== X-Gm-Message-State: AO0yUKXDVpEBxC6Wke95Eyh67i3uN+oMJdLvDLu82sCrzUDt2lgvcpYq r+/XnvpGmNfjSdsBMtsjEtE5I6lR1FI= X-Google-Smtp-Source: AK7set/666GLvRlmVK0eP4JonZu1oW7t7Omax9x2yZWigDkfYJyl3FiL4DZPTWCr+vF6OIIkEmBX8w== X-Received: by 2002:a05:600c:2242:b0:3eb:f59f:6daf with SMTP id a2-20020a05600c224200b003ebf59f6dafmr2261642wmm.34.1679576587392; Thu, 23 Mar 2023 06:03:07 -0700 (PDT) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id l15-20020a05600c1d0f00b003eb2e33f327sm6432961wms.2.2023.03.23.06.03.06 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 06:03:07 -0700 (PDT) Message-ID: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> Date: Thu, 23 Mar 2023 13:03:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Content-Language: en-US To: Report bugs to From: =?UTF-8?Q?P=C3=A1draig_Brady?= Subject: --reflink=auto not falling back appropriately on older kernels Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::332; envelope-from=pixelbeat@gmail.com; helo=mail-wm1-x332.google.com X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.25, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Details at https://github.com/termux/termux-packages/issues/15706#issuecomment-1481144831 But in summary, the new --reflink errno checking in coreutils 9.2 is not working appropriately on android 4.9 kernels at least. cheers, Pádraig From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 09:39:11 2023 Received: (at 62404) by debbugs.gnu.org; 23 Mar 2023 13:39:11 +0000 Received: from localhost ([127.0.0.1]:37548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfL9r-0007Wh-6Z for submit@debbugs.gnu.org; Thu, 23 Mar 2023 09:39:11 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:36670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfL9p-0007WU-4w for 62404@debbugs.gnu.org; Thu, 23 Mar 2023 09:39:09 -0400 Received: by mail-wm1-f46.google.com with SMTP id j18-20020a05600c1c1200b003ee5157346cso1206517wms.1 for <62404@debbugs.gnu.org>; Thu, 23 Mar 2023 06:39:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679578743; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:sender:from:to:cc:subject:date :message-id:reply-to; bh=Ot107uAp9j2SqOhG/NIseOQrF7qJf/TSjtJoaDMUwqY=; b=VrmOp1HmTc5fKQA5glcY71jm8PzwTc6ttHT7XeL1zFt1tOYKFbrBLvn+2B+XXtrjkU 1H2ElCoLkkvTDwIaims+LYrZSP0Scvn82PYlORiiQi2cdZkAMdHdQUDFySN0ScEDLEDe Z3ccV0o4wkj/o07SK348FRyjG7Tlh00n95eMn0iW2e6o3oEQBPJN4qn8BP4aL91HjPG6 OPgCtfXy4e8BNWH68cyITjb4zkjpPgo0SJsCcsTzotukawqxQUc5nZwvfnjFj31GLxxR oWhEd8ojlJIitHWOBt7oPfy2l9D0PjkNBUk4zbzKqsV1/ov/0d9q3eyGPHW20S5rULLd Q7Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679578743; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ot107uAp9j2SqOhG/NIseOQrF7qJf/TSjtJoaDMUwqY=; b=PzFoMdUsNHbC4G/NFwa0xnEl23BgafS9NNHwO6d01R9sSijv7NiO8Eebca3ACF292C dlgcXFRV+zykIcKX9h/otkMHVO71EGh4VGy+889HWRV14WMsZ7D3WjPwEjhgBC1OVD6k GsmsN86eguHmXE5E2csyPGoOmQ/KhqfcS5vU/wa1QEwePRC6CsXfTv+CXfPFr8m+hboh ew72z4wsAzxzKxD6P4XW29KQ643lFfISeMqmEZlJSRhW95RhYa9MAIaIzY8dcmYIgeE6 yYH5j9+S8sdG9DUIZ4E9O18emc3BTrYJhbPjS6aZjvNRYKVcB2pS/TojIkAdJCr3mGnq f4yg== X-Gm-Message-State: AO0yUKVUgw0fYWOgKNTlaO5oELXnS+fXBludI3JCoLVJHAGrW+a5tG+W w838JsmRyDt/XdSDKPwLY1adGpHvBg0= X-Google-Smtp-Source: AK7set9moZydvllPPSAXTrkfbwu8N0h1VpetYar650+FKRn+la0si2UX/+pfVA/PYA1dNdmY55miCA== X-Received: by 2002:a05:600c:2148:b0:3ed:290b:dc68 with SMTP id v8-20020a05600c214800b003ed290bdc68mr2201781wml.12.1679578742702; Thu, 23 Mar 2023 06:39:02 -0700 (PDT) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id m20-20020a05600c3b1400b003dc434b39c7sm6845877wms.0.2023.03.23.06.39.01 for <62404@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 06:39:02 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------ANd0D9bWYoWwJC4WIAFxMJd2" Message-ID: Date: Thu, 23 Mar 2023 13:39:01 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Subject: Re: bug#62404: --reflink=auto not falling back appropriately on older kernels Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig_Brady?= To: 62404@debbugs.gnu.org References: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> In-Reply-To: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 62404 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) This is a multi-part message in MIME format. --------------ANd0D9bWYoWwJC4WIAFxMJd2 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 23/03/2023 13:03, Pádraig Brady wrote: > Details at > https://github.com/termux/termux-packages/issues/15706#issuecomment-1481144831 > > But in summary, the new --reflink errno checking in coreutils 9.2 > is not working appropriately on android 4.9 kernels at least. Proposed patch attached. It may be better to key on kernel version rather than __ANDROID__ (along the lines of https://github.com/coreutils/coreutils/commit/ba5e6885d), but that needs more investigation. cheers, Pádraig --------------ANd0D9bWYoWwJC4WIAFxMJd2 Content-Type: text/x-patch; charset=UTF-8; name="copy-clone-android.patch" Content-Disposition: attachment; filename="copy-clone-android.patch" Content-Transfer-Encoding: base64 RnJvbSBhYmM2OTViNjY1MDcyMmFjNTkxZjFiNjZiN2Q2OTcxYmFiMWFjYmMwIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogVGh1LCAyMyBNYXIgMjAyMyAxMzoxOTowNCAr MDAwMApTdWJqZWN0OiBbUEFUQ0hdIGNvcHk6IGZpeCAtLXJlZmxpbms9YXV0byBmYWxsYmFj ayBvbiBhbmRyb2lkCgoqIHNyYy9jb3B5LmMgKGlzX3RyYW5zaWVudF9mYWlsdXJlKTogQSBu ZXcgZnVuY3Rpb24gcmVmYWN0b3JlZApmcm9tIGhhbmRsZV9jbG9uZV9mYWlsKCkuCihpc19D TE9ORU5PVFNVUCk6IFJldmVyc2UgdGhlIHNlbnNlIG9mIHRoZSBlcnJubyBjaGVjayBvbiBh bmRyb2lkLApzbyB0aGF0IHdlIGFzc3VtZSB0aGUgY2xvbmUgaXMgbm90IHN1cHBvcnRlZCB1 bmxlc3Mgd2UKZ2V0IGEgdHJhbnNpZW50IGVycm9yIGxpa2UgRUlPIGV0Yy4KKiBORVdTOiBN ZW50aW9uIHRoZSBidWcgZml4LgpBZGRyZXNzZXMgaHR0cHM6Ly9idWdzLmdudS5vcmcvNjI0 MDQKLS0tCiBORVdTICAgICAgIHwgIDcgKysrKysrKwogc3JjL2NvcHkuYyB8IDIyICsrKysr KysrKysrKysrKysrKysrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwg MiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCAwMzBmMGU1 NDMuLjdiZDEwZTQxMSAxMDA2NDQKLS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC0yLDYgKzIs MTMgQEAgR05VIGNvcmV1dGlscyBORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgLSotIG91dGxpbmUgLSotCiAKICogTm90ZXdvcnRoeSBjaGFuZ2VzIGluIHJlbGVh c2UgPy4/ICg/Pz8/LT8/LT8/KSBbP10KIAorKiogQnVnIGZpeGVzCisKKyAgY3AgLS1yZWxp bms9YXV0byAodGhlIGRlZmF1bHQpLCBtdiwgYW5kIGluc3RhbGwgaGF2ZSBpbXByb3ZlZAor ICBmYWxsIGJhY2sgdG8gYSBzdGFuZGFyZCBjb3B5IG9uIEFuZHJvaWQgc3lzdGVtcy4gIFBy ZXZpb3VzbHkgZGVmYXVsdAorICBjb3B5IG9wZXJhdGlvbnMgY291bGQgZmFpbCB3aXRoICJQ ZXJtaXNzaW9uIGRlbmllZCIgZXJyb3JzIGV0Yy4KKyAgW2lzc3VlIGludHJvZHVjZWQgaW4g Y29yZXV0aWxzLTkuMl0KKwogCiAqIE5vdGV3b3J0aHkgY2hhbmdlcyBpbiByZWxlYXNlIDku MiAoMjAyMy0wMy0yMCkgW3N0YWJsZV0KIApkaWZmIC0tZ2l0IGEvc3JjL2NvcHkuYyBiL3Ny Yy9jb3B5LmMKaW5kZXggMzkxOTc4NzJjLi4xYmUyODE0OWEgMTAwNjQ0Ci0tLSBhL3NyYy9j b3B5LmMKKysrIGIvc3JjL2NvcHkuYwpAQCAtMjc4LDE1ICsyNzgsMzQgQEAgY3JlYXRlX2hv bGUgKGludCBmZCwgY2hhciBjb25zdCAqbmFtZSwgYm9vbCBwdW5jaF9ob2xlcywgb2ZmX3Qg c2l6ZSkKIH0KIAogCisvKiBXaGV0aGVyIHRoZSBlcnJubyBmcm9tIEZJQ0xPTkUsIG9yIGNv cHlfZmlsZV9yYW5nZQorICAgaW5kaWNhdGVzIG9wZXJhdGlvbiBpcyBhIHRyYW5zaWVudCBm YWlsdXJlLgorICAgSS5lLiwgYSBmYWlsdXJlIHRoYXQgd291bGQgaW5kaWNhdGUgdGhlIG9w ZXJhdGlvbiBpcyBzdXBwb3J0ZWQsCisgICBidXQgaGFzIGZhaWxlZCBpbiBhIHRlcm1pbmFs IHdheS4gICovCisKK3N0YXRpYyBib29sCitpc190cmFuc2llbnRfZmFpbHVyZSAoaW50IGVy cikKK3sKKyAgcmV0dXJuIGVyciA9PSBFSU8gfHwgZXJyID09IEVOT01FTQorICAgICAgICAg fHwgZXJyID09IEVOT1NQQyB8fCBlcnIgPT0gRURRVU9UOworfQorCisKIC8qIFdoZXRoZXIg dGhlIGVycm5vIGZyb20gRklDTE9ORSwgb3IgY29weV9maWxlX3JhbmdlCiAgICBpbmRpY2F0 ZXMgb3BlcmF0aW9uIGlzIG5vdCBzdXBwb3J0ZWQgZm9yIHRoaXMgZmlsZSBvciBmaWxlIHN5 c3RlbS4gICovCiAKIHN0YXRpYyBib29sCiBpc19DTE9ORU5PVFNVUCAoaW50IGVycikKIHsK KyNpZmRlZiBfX0FORFJPSURfXworICAvKiBPbiBrZXJuZWwgNC45IGF0IGxlYXN0IHZhcmlv dXMgZXJyb3JzIHdlcmUgcmVwb3J0ZWQsCisgICAgIHNvIHdlIHJldmVyc2UgdGhlIHNlbnNl IG9mIHRoZSBlcnJubyBjaGVjayBoZXJlLiAgKi8KKyAgcmV0dXJuICEgaXNfdHJhbnNpZW50 X2ZhaWx1cmUgKGVycik7CisjZWxzZQogICByZXR1cm4gZXJyID09IEVOT1NZUyB8fCBpc19F Tk9UU1VQIChlcnIpCiAgICAgICAgICB8fCBlcnIgPT0gRUlOVkFMIHx8IGVyciA9PSBFQkFE RgogICAgICAgICAgfHwgZXJyID09IEVYREVWIHx8IGVyciA9PSBFVFhUQlNZOworI2VuZGlm CiB9CiAKIApAQCAtMTE3Nyw4ICsxMTk2LDcgQEAgaGFuZGxlX2Nsb25lX2ZhaWwgKGludCBk c3RfZGlyZmQsIGNoYXIgY29uc3QqIGRzdF9yZWxuYW1lLAogICAgICBhbmQgaW5zdGVhZCBv bmx5IGNhdGVyIGZvciBzcGVjaWZpYyB0cmFuc2llbnQgZXJyb3JzLiAgKi8KICAgYm9vbCB0 cmFuc2llbnRfZmFpbHVyZTsKICAgaWYgKGRlc3RfZGVzYyA8IDApIC8qIGN1cnJlbnRseSBm b3IgZmNsb25lZmlsZWF0KCkuICAqLwotICAgIHRyYW5zaWVudF9mYWlsdXJlID0gZXJybm8g PT0gRUlPIHx8IGVycm5vID09IEVOT01FTQotICAgICAgICAgICAgICAgICAgICAgICAgfHwg ZXJybm8gPT0gRU5PU1BDIHx8IGVycm5vID09IEVEUVVPVDsKKyAgICB0cmFuc2llbnRfZmFp bHVyZSA9IGlzX3RyYW5zaWVudF9mYWlsdXJlIChlcnJubyk7CiAgIGVsc2UgLyogY3VycmVu dGx5IGZvciBGSUNMT05FLiAgKi8KICAgICB0cmFuc2llbnRfZmFpbHVyZSA9ICEgaXNfQ0xP TkVOT1RTVVAgKGVycm5vKTsKIAotLSAKMi4yNi4yCgo= --------------ANd0D9bWYoWwJC4WIAFxMJd2-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 10:55:17 2023 Received: (at 62404) by debbugs.gnu.org; 23 Mar 2023 14:55:17 +0000 Received: from localhost ([127.0.0.1]:39087 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfMLV-0001R6-7y for submit@debbugs.gnu.org; Thu, 23 Mar 2023 10:55:17 -0400 Received: from mail-wr1-f50.google.com ([209.85.221.50]:41524) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfMLT-0001Qs-13 for 62404@debbugs.gnu.org; Thu, 23 Mar 2023 10:55:15 -0400 Received: by mail-wr1-f50.google.com with SMTP id h17so20820633wrt.8 for <62404@debbugs.gnu.org>; Thu, 23 Mar 2023 07:55:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679583308; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:sender:from:to:cc:subject:date :message-id:reply-to; bh=tWEl24165tLM1zRlDOVuctQB+29Z/cwmWs/130GCWUk=; b=ZjgZO7e2pUWITD6VLE96mt563KLicJogcPNZ2TMHvupwo8y4ESZwvOj/jQkt/yaSxz bA0qWSZu7Klr99SgR17OyPREQntDyySU77MoZO350RftEeTGJ4i/j3R/NYSt38lhvOef 47Ru/L0A/KhGuYkuYPVq5tqPoitDNBSidaM26rc3JDC+dLJxRUDnjLIUdVnhRm+AyngB yQA5l9eUFd1gvEoql/LHxvvyhUDAQXJ7eS7nyxu8q9Z2z/kXBlj/NGFiPLca7pIy7I5/ 2UCv7RFlMHkebA/BiL68G9s6nlTKnIZsSp6n1mrqF2q46GlIWifMjnabUo8x/sV2TAfM 5Nsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679583308; h=in-reply-to:references:to:from:content-language:subject:user-agent :mime-version:date:message-id:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tWEl24165tLM1zRlDOVuctQB+29Z/cwmWs/130GCWUk=; b=ZoBdbhr58AZCAZGKg/DGxB97+09DmujBJFUlFkMETcGqKAAkMnIVkknl8MvrOFlO8V us8X+NHoccMNbzq0mYVelRHDollshp5lgysMNzQufhSc+e9xrupZIkSIPuXR5U9dfc5z t4KOyx/5f9xwwMy0qspPuq5/jPgIpFxblSJ5npNLlv8x1Ab8oJIujwqq2S07U+hTTX91 mSJseuz+ajUeCnXn50ldcD6EBOTu5T0jmjoUf/JSupp4HJeycx8gkrh37hZGwJ0URtHk Cd1GGf0vd6WqMVbMScOC2Hn6X0Rk20fKqQgQ9yL7um2lqSDvJ8dAggPuvXinBdL79CiS g0Mg== X-Gm-Message-State: AAQBX9fSEOiXNGyIwu0mf0S5+kItZSzoCPUYgvVot9K5vCebO4LT9//x 2YrL5rtgAonWJAsWkhn+rFEf4eZrha8= X-Google-Smtp-Source: AKy350ZMLx14jyCYN9TctALRMYybpFjHiK+gZadaWVd9dQNEnHxVlrxbKKCsJeOK2O1a0bzDys1GRg== X-Received: by 2002:a5d:4109:0:b0:2d6:6af:4891 with SMTP id l9-20020a5d4109000000b002d606af4891mr2589312wrp.3.1679583308313; Thu, 23 Mar 2023 07:55:08 -0700 (PDT) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id a5-20020a05600c348500b003ee6def283bsm2140723wmq.11.2023.03.23.07.55.07 for <62404@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 07:55:07 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------NQ8hIU80I03HajUXNiu5jPoM" Message-ID: Date: Thu, 23 Mar 2023 14:55:06 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Subject: Re: bug#62404: --reflink=auto not falling back appropriately on older kernels Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig_Brady?= To: 62404@debbugs.gnu.org References: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> In-Reply-To: X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 62404 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) This is a multi-part message in MIME format. --------------NQ8hIU80I03HajUXNiu5jPoM Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 23/03/2023 13:39, Pádraig Brady wrote: > On 23/03/2023 13:03, Pádraig Brady wrote: >> Details at >> https://github.com/termux/termux-packages/issues/15706#issuecomment-1481144831 >> >> But in summary, the new --reflink errno checking in coreutils 9.2 >> is not working appropriately on android 4.9 kernels at least. > > Proposed patch attached. > It may be better to key on kernel version rather than __ANDROID__ > (along the lines of https://github.com/coreutils/coreutils/commit/ba5e6885d), > but that needs more investigation. Actually it seems the errno checking may be too brittle in general, https://www.reddit.com/r/Proxmox/comments/11zieha/cpmvinstall_are_broken_in_unprivileged_containers/ Perhaps we should use the above __ANDROID__ logic in all cases, so that we fallback unless there is a specific reason not to. The attached does that. cheers, Pádraig --------------NQ8hIU80I03HajUXNiu5jPoM Content-Type: text/x-patch; charset=UTF-8; name="copy-clone-fallback.patch" Content-Disposition: attachment; filename="copy-clone-fallback.patch" Content-Transfer-Encoding: base64 RnJvbSBhYjkwZGQ5NzdlM2FjM2NjZjkxYzFlMTU0ZTI0YTA5Y2EzNzI5MjA3IE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/UD1DMz1BMWRyYWlnPTIwQnJhZHk/ PSA8UEBkcmFpZ0JyYWR5LmNvbT4KRGF0ZTogVGh1LCAyMyBNYXIgMjAyMyAxMzoxOTowNCAr MDAwMApTdWJqZWN0OiBbUEFUQ0hdIGNvcHk6IC0tcmVmbGluaz1hdXRvIGZhbGxiYWNrIHRv IHN0YW5kYXJkIGNvcHkgaW4gbW9yZSBjYXNlcwoKKiBzcmMvY29weS5jIChpc190cmFuc2ll bnRfZmFpbHVyZSk6IEEgbmV3IGZ1bmN0aW9uIHJlZmFjdG9yZWQKZnJvbSBoYW5kbGVfY2xv bmVfZmFpbCgpLgooaXNfQ0xPTkVOT1RTVVApOiBNZXJnZSBpbiB0aGUgaGFuZGxpbmcgb2Yg RVBFUk0gYXMgdGhhdCBhbHNvCnBlcnRhaW5zIHRvIGRldGVybWluYXRpb24gb2Ygd2hldGhl ciBjbG9uaW5nIGlzIHN1cHBvcnRlZAppZiB3ZSBldmVyIHVzZSB0aGlzIGZ1bmN0aW9uIGlu IHRoYXQgY29udGV4dC4KKGhhbmRsZV9jbG9uZV9mYWlsKTogVXNlIGlzX3RyYW5zaWVudF9m YWlsdXJlKCkgaW4gYWxsIGNhc2VzLApzbyB0aGF0IHdlIGFzc3VtZSBhIHRlcm1pbmFsIGZh aWx1cmUgaW4gbGVzcyBlcnJubyBjYXNlcy4KKiBORVdTOiBNZW50aW9uIHRoZSBidWcgZml4 LgpBZGRyZXNzZXMgaHR0cHM6Ly9idWdzLmdudS5vcmcvNjI0MDQKLS0tCiBORVdTICAgICAg IHwgIDggKysrKysrKysKIHNyYy9jb3B5LmMgfCA0MSArKysrKysrKysrKysrKysrKysrKysr KysrLS0tLS0tLS0tLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAzMyBpbnNlcnRpb25zKCsp LCAxNiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9ORVdTIGIvTkVXUwppbmRleCAwMzBm MGU1NDMuLjczODAxZDRiZiAxMDA2NDQKLS0tIGEvTkVXUworKysgYi9ORVdTCkBAIC0yLDYg KzIsMTQgQEAgR05VIGNvcmV1dGlscyBORVdTICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgLSotIG91dGxpbmUgLSotCiAKICogTm90ZXdvcnRoeSBjaGFuZ2VzIGluIHJl bGVhc2UgPy4/ICg/Pz8/LT8/LT8/KSBbP10KIAorKiogQnVnIGZpeGVzCisKKyAgY3AgLS1y ZWxpbms9YXV0byAodGhlIGRlZmF1bHQpLCBtdiwgYW5kIGluc3RhbGwgd2lsbAorICBmYWxs IGJhY2sgdG8gYSBzdGFuZGFyZCBjb3B5IGluIG1vcmUgY2FzZXMuCisgIFByZXZpb3VzbHkg Y29waWVzIGNvdWxkIGZhaWwgd2l0aCAiUGVybWlzc2lvbiBkZW5pZWQiIGVycm9ycyBldGMu CisgIG9uIG9sZGVyIGtlcm5lbHMgb3IgdW5wcml2aWxlZ2VkIGNvbnRhaW5lcnMgb24gWkZT IGV0Yy4KKyAgW2lzc3VlIGludHJvZHVjZWQgaW4gY29yZXV0aWxzLTkuMl0KKwogCiAqIE5v dGV3b3J0aHkgY2hhbmdlcyBpbiByZWxlYXNlIDkuMiAoMjAyMy0wMy0yMCkgW3N0YWJsZV0K IApkaWZmIC0tZ2l0IGEvc3JjL2NvcHkuYyBiL3NyYy9jb3B5LmMKaW5kZXggMzkxOTc4NzJj Li4xOWE2MDViZDUgMTAwNjQ0Ci0tLSBhL3NyYy9jb3B5LmMKKysrIGIvc3JjL2NvcHkuYwpA QCAtMjc4LDE1ICsyNzgsMjggQEAgY3JlYXRlX2hvbGUgKGludCBmZCwgY2hhciBjb25zdCAq bmFtZSwgYm9vbCBwdW5jaF9ob2xlcywgb2ZmX3Qgc2l6ZSkKIH0KIAogCisvKiBXaGV0aGVy IHRoZSBlcnJubyBpbmRpY2F0ZXMgb3BlcmF0aW9uIGlzIGEgdHJhbnNpZW50IGZhaWx1cmUu CisgICBJLmUuLCBhIGZhaWx1cmUgdGhhdCB3b3VsZCBpbmRpY2F0ZSB0aGUgb3BlcmF0aW9u IF9pc18gc3VwcG9ydGVkLAorICAgYnV0IGhhcyBmYWlsZWQgaW4gYSB0ZXJtaW5hbCB3YXku ICAqLworCitzdGF0aWMgYm9vbAoraXNfdHJhbnNpZW50X2ZhaWx1cmUgKGludCBlcnIpCit7 CisgIHJldHVybiBlcnIgPT0gRUlPIHx8IGVyciA9PSBFTk9NRU0KKyAgICAgICAgIHx8IGVy ciA9PSBFTk9TUEMgfHwgZXJyID09IEVEUVVPVDsKK30KKworCiAvKiBXaGV0aGVyIHRoZSBl cnJubyBmcm9tIEZJQ0xPTkUsIG9yIGNvcHlfZmlsZV9yYW5nZQogICAgaW5kaWNhdGVzIG9w ZXJhdGlvbiBpcyBub3Qgc3VwcG9ydGVkIGZvciB0aGlzIGZpbGUgb3IgZmlsZSBzeXN0ZW0u ICAqLwogCiBzdGF0aWMgYm9vbAotaXNfQ0xPTkVOT1RTVVAgKGludCBlcnIpCitpc19DTE9O RU5PVFNVUCAoaW50IGVyciwgYm9vbCBwYXJ0aWFsKQogewogICByZXR1cm4gZXJyID09IEVO T1NZUyB8fCBpc19FTk9UU1VQIChlcnIpCiAgICAgICAgICB8fCBlcnIgPT0gRUlOVkFMIHx8 IGVyciA9PSBFQkFERgotICAgICAgICAgfHwgZXJyID09IEVYREVWIHx8IGVyciA9PSBFVFhU QlNZOworICAgICAgICAgfHwgZXJyID09IEVYREVWIHx8IGVyciA9PSBFVFhUQlNZCisgICAg ICAgICB8fCAoZXJyID09IEVQRVJNICYmICEgcGFydGlhbCk7CiB9CiAKIApAQCAtMzM5LDE1 ICszNTIsMTMgQEAgc3BhcnNlX2NvcHkgKGludCBzcmNfZmQsIGludCBkZXN0X2ZkLCBjaGFy ICoqYWJ1Ziwgc2l6ZV90IGJ1Zl9zaXplLAogICAgICAgICAgIHsKICAgICAgICAgICAgIGNv cHlfZGVidWcub2ZmbG9hZCA9IENPUFlfREVCVUdfVU5TVVBQT1JURUQ7CiAKLSAgICAgICAg ICAgIGlmIChpc19DTE9ORU5PVFNVUCAoZXJybm8pKQotICAgICAgICAgICAgICBicmVhazsK LQotICAgICAgICAgICAgLyogY29weV9maWxlX3JhbmdlIG1pZ2h0IG5vdCBiZSBlbmFibGVk IGluIHNlY2NvbXAgZmlsdGVycywKKyAgICAgICAgICAgIC8qIENvbnNpZGVyIEVQRVJNIGlm IG5vdCBjb3BpZWQgYW55IGRhdGEgeWV0LiAgRVBFUk0gY291bGQgb2NjdXIKKyAgICAgICAg ICAgICAgIGlmIGNvcHlfZmlsZV9yYW5nZSBub3QgYmUgZW5hYmxlZCBpbiBzZWNjb21wIGZp bHRlcnMsCiAgICAgICAgICAgICAgICBzbyByZXRyeSB3aXRoIGEgc3RhbmRhcmQgY29weS4g IEVQRVJNIGNhbiBhbHNvIG9jY3VyCiAgICAgICAgICAgICAgICBmb3IgaW1tdXRhYmxlIGZp bGVzLCBidXQgdGhhdCB3b3VsZCBvbmx5IGJlIGluIHRoZSBlZGdlIGNhc2UKICAgICAgICAg ICAgICAgIHdoZXJlIHRoZSBmaWxlIGlzIG1hZGUgaW1tdXRhYmxlIGFmdGVyIGNyZWF0aW5n L3RydW5jYXRpbmcsCiAgICAgICAgICAgICAgICBpbiB3aGljaCBjYXNlIHRoZSAobW9yZSBh Y2N1cmF0ZSkgZXJyb3IgaXMgc3RpbGwgc2hvd24uICAqLwotICAgICAgICAgICAgaWYgKGVy cm5vID09IEVQRVJNICYmICp0b3RhbF9uX3JlYWQgPT0gMCkKKyAgICAgICAgICAgIGlmIChp c19DTE9ORU5PVFNVUCAoZXJybm8sICp0b3RhbF9uX3JlYWQpKQogICAgICAgICAgICAgICBi cmVhazsKIAogICAgICAgICAgICAgLyogRU5PRU5UIHdhcyBzZWVuIHNvbWV0aW1lcyBhY3Jv c3MgQ0lGUyBzaGFyZXMsIHJlc3VsdGluZyBpbgpAQCAtMTE3MiwxNSArMTE4MywxMyBAQCBo YW5kbGVfY2xvbmVfZmFpbCAoaW50IGRzdF9kaXJmZCwgY2hhciBjb25zdCogZHN0X3JlbG5h bWUsCiAgICAgICAgICAgICAgICAgICAgY2hhciBjb25zdCogc3JjX25hbWUsIGNoYXIgY29u c3QqIGRzdF9uYW1lLAogICAgICAgICAgICAgICAgICAgIGludCBkZXN0X2Rlc2MsIGJvb2wg bmV3X2RzdCwgZW51bSBSZWZsaW5rX3R5cGUgcmVmbGlua19tb2RlKQogewotICAvKiBJZiB0 aGUgY2xvbmUgb3BlcmF0aW9uIGlzIGNyZWF0aW5nIHRoZSBkZXN0aW5hdGlvbiwKLSAgICAg dGhlbiBkb24ndCB0cnkgYW5kIGNhdGVyIGZvciBhbGwgbm9uIHRyYW5zaWVudCBmaWxlIHN5 c3RlbSBlcnJvcnMsCi0gICAgIGFuZCBpbnN0ZWFkIG9ubHkgY2F0ZXIgZm9yIHNwZWNpZmlj IHRyYW5zaWVudCBlcnJvcnMuICAqLwotICBib29sIHRyYW5zaWVudF9mYWlsdXJlOwotICBp ZiAoZGVzdF9kZXNjIDwgMCkgLyogY3VycmVudGx5IGZvciBmY2xvbmVmaWxlYXQoKS4gICov Ci0gICAgdHJhbnNpZW50X2ZhaWx1cmUgPSBlcnJubyA9PSBFSU8gfHwgZXJybm8gPT0gRU5P TUVNCi0gICAgICAgICAgICAgICAgICAgICAgICB8fCBlcnJubyA9PSBFTk9TUEMgfHwgZXJy bm8gPT0gRURRVU9UOwotICBlbHNlIC8qIGN1cnJlbnRseSBmb3IgRklDTE9ORS4gICovCi0g ICAgdHJhbnNpZW50X2ZhaWx1cmUgPSAhIGlzX0NMT05FTk9UU1VQIChlcnJubyk7CisgIC8q IElmIHRoZSBjbG9uZSBvcGVyYXRpb24gaXMgbm90IGNyZWF0aW5nIHRoZSBkZXN0aW5hdGlv biAoaS5lLiwgRklDTE9ORSkKKyAgICAgdGhlbiB3ZSBjb3VsZCBwb3NzaWJseSBiZSBtb3Jl IHJlc3RyaWN0aXZlIHdpdGggZXJyb3JzIGRlZW1lZCBub24gdGVybWluYWwuCisgICAgIEhv d2V2ZXIgZG9pbmcgdGhhdCBsaWtlIGluIHRoZSBmb2xsb3dpbmcKKyAgICAgd291bGQgYmUg bW9yZSBjb3VwbGVkIHRvIGRpc3BhcmF0ZSBlcnJubyBoYW5kbGluZyBvbiB2YXJpb3VzIHN5 c3RlbXMuCisgICAgIGlmICgwIDw9IGRlc3RfZGVzYykKKyAgICAgICB0cmFuc2llbnRfZmFp bHVyZSA9ICEgaXNfQ0xPTkVOT1RTVVAgKGVycm5vLCBmYWxzZSk7ICAqLworICBib29sIHRy YW5zaWVudF9mYWlsdXJlID0gaXNfdHJhbnNpZW50X2ZhaWx1cmUgKGVycm5vKTsKIAogICBp ZiAocmVmbGlua19tb2RlID09IFJFRkxJTktfQUxXQVlTIHx8IHRyYW5zaWVudF9mYWlsdXJl KQogICAgIGVycm9yICgwLCBlcnJubywgXygiZmFpbGVkIHRvIGNsb25lICVzIGZyb20gJXMi KSwKLS0gCjIuMjYuMgoK --------------NQ8hIU80I03HajUXNiu5jPoM-- From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 13:30:37 2023 Received: (at control) by debbugs.gnu.org; 23 Mar 2023 17:30:37 +0000 Received: from localhost ([127.0.0.1]:39255 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfOlp-0005W2-5P for submit@debbugs.gnu.org; Thu, 23 Mar 2023 13:30:37 -0400 Received: from mail-wm1-f48.google.com ([209.85.128.48]:41653) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfOlm-0005Vj-PV for control@debbugs.gnu.org; Thu, 23 Mar 2023 13:30:35 -0400 Received: by mail-wm1-f48.google.com with SMTP id r19-20020a05600c459300b003eb3e2a5e7bso1631501wmo.0 for ; Thu, 23 Mar 2023 10:30:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679592628; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=yIjALjpeDTu9zl8vw3kK+pg7Hd1TZ4yInB5GAJUUP5U=; b=lupdfG+2CqcFG1/VHy0WqG0prC+NwlPGgIPYsRZKTgQqg+NIN3RBkZwFpFOQVgUE/t EKDy7oJX5cWpmh5sdLLwwUNathSkxJWFex/2/MsuPa8aSmWg7IOxbHi5mib4lQvXa96X +lql3Djmz8eMov2/K2rDPA2niaQAjJ3mPVDXibAt335oDBAxsF3v/kSilReH/IiJm+6X 51yFu8KzdTp4zsSrcBx5ybyDvJpvGWv2xBZs6owZEeelAvM1eYGWFXYEXo2FhkyXl7mn KnxeECJqHf8Af+a8vjAbwLXmwY55Lb1QgH+TKuyenOKuft/OdTL0mHzF1i37UOKDcvov 5NDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679592628; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=yIjALjpeDTu9zl8vw3kK+pg7Hd1TZ4yInB5GAJUUP5U=; b=m8ETSej3ojv2ZbIlF3p3w8cTJchY4MAvmMUsSf5XvoQeniL5WwubRcpeC/yjM8PYVG kmKmzVYhsi6P94qknArE0GotQKb8WJEhprwl60aXODxgnkbyScMn49u/Ip72W3Z75/wX ygxA4XESLoo+c7OBfVBzgm8urrMIKerndtUdkK/k4WMY/qqt6mVQ2FLOusSZHRoTL/4t RaodKgomTFejWUrUoIzfzBFp3+08NfGixP6hzj0hPVZyugr+K6llfyA7JUawJfoXacao +wxlnGV/iWigpil5LT0ZHAFUj518UYTmlG5K6MPfakTPvXtOcMPSUkq87UZKaMvuvugH Lr0Q== X-Gm-Message-State: AO0yUKXbPjS52IKXPEFpe1VChjTEkma/WKTGFvUCL797iy3yxeERF9w7 YEgen8zWCnfD7HV/8s5Cso5E2gI3gpM= X-Google-Smtp-Source: AK7set9i6jZTKsQmcUuGHcdqvb1MQTQFM0F5WTSTe0Mq4zBaCn0tnTPf6xFd00UH+TzqWVoladA8CA== X-Received: by 2002:a7b:c4ce:0:b0:3eb:4162:7344 with SMTP id g14-20020a7bc4ce000000b003eb41627344mr344400wmk.22.1679592628156; Thu, 23 Mar 2023 10:30:28 -0700 (PDT) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id t7-20020a05600c450700b003edddae1068sm2610055wmo.9.2023.03.23.10.30.27 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 10:30:27 -0700 (PDT) Message-ID: <207a9d1c-eabd-a3bd-6b97-59bd1e266771@draigBrady.com> Date: Thu, 23 Mar 2023 17:30:27 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Subject: Re: bug#62404: Acknowledgement (--reflink=auto not falling back appropriately on older kernels) Content-Language: en-US To: GNU bug tracker automated control server References: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) retitle 62404 --reflink=auto not falling back appropriately to standard copy in all cases stop From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 19:05:52 2023 Received: (at 62404) by debbugs.gnu.org; 23 Mar 2023 23:05:52 +0000 Received: from localhost ([127.0.0.1]:39531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfU0G-0008Tt-5Z for submit@debbugs.gnu.org; Thu, 23 Mar 2023 19:05:52 -0400 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:50034) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfU0E-0008Tg-By for 62404@debbugs.gnu.org; Thu, 23 Mar 2023 19:05:51 -0400 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 48E0216005B; Thu, 23 Mar 2023 15:57:19 -0700 (PDT) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 2uOMMIbTJdNs; Thu, 23 Mar 2023 15:57:18 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A2FE5160082; Thu, 23 Mar 2023 15:57:17 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.9.2 zimbra.cs.ucla.edu A2FE5160082 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=78364E5A-2AF3-11ED-87FA-8298ECA2D365; t=1679612237; bh=zT5YNxVBPHGIegLCkEc7ok6O8iy36a9euPkKQiZhBuA=; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type: Content-Transfer-Encoding; b=N5sVq6UfS7649tMYNC8n8F6m8tE+UxZsvV/HoYJjsf5wK7E3ng2Y/zpYxXy1kdu/7 Xcvo+5/dpSyjSWEBEkWHwYUbDaNHqySuH8tu4znPwAbq0gCMmmQb9mp///gj1LttUm oQoNmrrRVdVOMR58DgeHfGX3tfAqS8HqiSRT+Jl4= X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id av3spuYcd64Z; Thu, 23 Mar 2023 15:57:17 -0700 (PDT) Received: from [131.179.64.200] (Penguin.CS.UCLA.EDU [131.179.64.200]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 859EE16005B; Thu, 23 Mar 2023 15:57:17 -0700 (PDT) Message-ID: <23e4878b-5c48-4b79-ed2d-bc47af0ba26a@cs.ucla.edu> Date: Thu, 23 Mar 2023 15:57:16 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: bug#62404: --reflink=auto not falling back appropriately on older kernels Content-Language: en-US To: =?UTF-8?Q?P=c3=a1draig_Brady?= References: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> From: Paul Eggert Organization: UCLA Computer Science Department In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Spam-Score: -3.4 (---) X-Debbugs-Envelope-To: 62404 Cc: 62404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.4 (----) Thanks for looking into this. On 3/23/23 07:55, P=C3=A1draig Brady wrote: > Perhaps we should use the above __ANDROID__ logic in all cases, > so that we fallback unless there is a specific reason not to. Yes, that sounds better. > +/* Whether the errno indicates operation is a transient failure. > + I.e., a failure that would indicate the operation _is_ supported, > + but has failed in a terminal way. */ I got confused by the terminology here, as "transient failure" has the=20 opposite connotation from terminal failure. I suggest that we remove the=20 function (since it's used only once and its name is confusing) and=20 replace its calling code as suggested below. > - if (errno =3D=3D EPERM && *total_n_read =3D=3D 0) > + if (is_CLONENOTSUP (errno, *total_n_read)) The *total_n_read should be *total_n_read !=3D 0 partly for style and=20 partly to be portable to ancient compilers that don't properly support=20 bool. More important, I suggest leaving is_CLONENOTSUP's API as-is, and=20 changing the 'if' to: if (*total_n_read =3D=3D 0 && is_CLONENOTSUP (errno)) as I don't see why we should treat EPERM differently from ENOSYS etc. > /* Whether the errno from FICLONE, or copy_file_range > indicates operation is not supported for this file or file system. = */ > =20 > static bool > -is_CLONENOTSUP (int err) > +is_CLONENOTSUP (int err, bool partial) Since the code no longer calls is_CLONENOTSUP when FICLONE fails, the=20 comment should be changed to not mention FICLONE. > + /* If the clone operation is not creating the destination (i.e., FIC= LONE) > + then we could possibly be more restrictive with errors deemed non= terminal. > + However doing that like in the following > + would be more coupled to disparate errno handling on various syst= ems. > + if (0 <=3D dest_desc) > + transient_failure =3D ! is_CLONENOTSUP (errno, false); */ > + bool transient_failure =3D is_transient_failure (errno); I had trouble with those two "transient_failure"s lining up, plus the=20 terminology thing mentioned above. I suggest changing this to: /* When FICLONE fails, report failure only with errno values known to mean trouble when FICLONE is supported and called properly. Do do not report failure merely because !is_CLONENOTSUP (errno), as too many systems yield oddball errno values here. */ bool report_failure =3D (errno =3D=3D EIO || errno =3D=3D ENOMEM || errno =3D=3D ENOSPC || errno =3D=3D EDQUOT); and then replace all occurrences of "transient_failure" with=20 "report_failure". From debbugs-submit-bounces@debbugs.gnu.org Thu Mar 23 19:14:46 2023 Received: (at 62404) by debbugs.gnu.org; 23 Mar 2023 23:14:46 +0000 Received: from localhost ([127.0.0.1]:39536 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfU8s-0000FI-9h for submit@debbugs.gnu.org; Thu, 23 Mar 2023 19:14:46 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:46942) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfU8p-0000F5-O4 for 62404@debbugs.gnu.org; Thu, 23 Mar 2023 19:14:44 -0400 Received: by mail-ed1-f41.google.com with SMTP id eg48so1185611edb.13 for <62404@debbugs.gnu.org>; Thu, 23 Mar 2023 16:14:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679613272; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=Ksqzicd6EaRtb0hghGEWAl994jgKdQ7t4rvcQrFyTLM=; b=MEXac+j07Q8Y0a2BWsCqhaYZfUVO/bmY2gOp2jN6+5o+BJO68LLLHOpmZ8visUOkgr l+XIOpiA8t3LKKJZvUOziPS5iveHrX6NqUiowittUIvBuc0YC3l3wvbPv9EcS7+wH/Hb FGOEADloWo36WewytHLIqhI5fBT3rf5IPdposCTgWnLkW20O2b81ArPgMamhjPRkJ0We DoN0/DWnQNUOwD8gyp3prqcPyk+gUqJmUQ9NxgcBulnbsch77hyuk3/ryJoHamVDiZfC KQpYyY9f/I95Q6JwD5SB8bP4yvQrp2h5NSEDhjvQNPjHvG7Vgzbb8zvKRjFcSLjnjg05 4/6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679613272; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Ksqzicd6EaRtb0hghGEWAl994jgKdQ7t4rvcQrFyTLM=; b=4dQ0rR8xyWWuvw4KMX9zvq3cNjuRMf2KKGpOg2qsSkwY1I6W21ICzfZEBaTmM3IaIG PvVnTvCHc0u9ZxS4FfXbZpg8CqlawVloPVmYlXXUTLntTpcBhocfA4w78djlk/2zXnPb cGDQEutGyUb33xs04WGDeCRELm4wVaeAEJhjKu0dXfEStWvK8sA4NKZoVFZNz/Uytd1f SxpOJLDMuyypwg+P4MqvMXpTQITO0NwC8BLGViKv+KUem5Yd/MFIL0DEoh4OgO2T+UlJ sxtlC5yEqr7WyTropM5NEgKKrKZsfA1F2SBxbIYq0JbVgxvsNx8a1cSqQuVvKbak2YN3 0VhA== X-Gm-Message-State: AO0yUKW5JTSNnzefsKsjMo4fAyWKS9eLrsHXTTxpZC0z9RW3Q5o9ygRv zVn860dI766OMQhZP4/yVfK5c7XB1+w= X-Google-Smtp-Source: AK7set/1KJB85YVZKEAwHnNDEbbLkzwv5pkkhH79NwyLkDJgWsQpcNPy/2EJqpRj/absrbufDyGLOw== X-Received: by 2002:a05:600c:3110:b0:3ed:2346:44bd with SMTP id g16-20020a05600c311000b003ed234644bdmr3590570wmo.19.1679612811631; Thu, 23 Mar 2023 16:06:51 -0700 (PDT) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id o19-20020a05600c4fd300b003ea57808179sm3292672wmq.38.2023.03.23.16.06.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 23 Mar 2023 16:06:51 -0700 (PDT) Message-ID: <8411fa9f-70ff-e9fa-85dc-b2e21e70f7fb@draigBrady.com> Date: Thu, 23 Mar 2023 23:06:50 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Subject: Re: bug#62404: --reflink=auto not falling back appropriately on older kernels Content-Language: en-US To: Paul Eggert References: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> <23e4878b-5c48-4b79-ed2d-bc47af0ba26a@cs.ucla.edu> From: =?UTF-8?Q?P=C3=A1draig_Brady?= In-Reply-To: <23e4878b-5c48-4b79-ed2d-bc47af0ba26a@cs.ucla.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 62404 Cc: 62404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 23/03/2023 22:57, Paul Eggert wrote: > Thanks for looking into this. > > On 3/23/23 07:55, Pádraig Brady wrote: > >> Perhaps we should use the above __ANDROID__ logic in all cases, >> so that we fallback unless there is a specific reason not to. > > Yes, that sounds better. > >> +/* Whether the errno indicates operation is a transient failure. >> + I.e., a failure that would indicate the operation _is_ supported, >> + but has failed in a terminal way. */ > > I got confused by the terminology here, as "transient failure" has the > opposite connotation from terminal failure. I suggest that we remove the > function (since it's used only once and its name is confusing) and > replace its calling code as suggested below. > > >> - if (errno == EPERM && *total_n_read == 0) >> + if (is_CLONENOTSUP (errno, *total_n_read)) > > The *total_n_read should be *total_n_read != 0 partly for style and > partly to be portable to ancient compilers that don't properly support > bool. More important, I suggest leaving is_CLONENOTSUP's API as-is, and > changing the 'if' to: > > if (*total_n_read == 0 && is_CLONENOTSUP (errno)) > > as I don't see why we should treat EPERM differently from ENOSYS etc. > > >> /* Whether the errno from FICLONE, or copy_file_range >> indicates operation is not supported for this file or file system. */ >> >> static bool >> -is_CLONENOTSUP (int err) >> +is_CLONENOTSUP (int err, bool partial) > > Since the code no longer calls is_CLONENOTSUP when FICLONE fails, the > comment should be changed to not mention FICLONE. > > >> + /* If the clone operation is not creating the destination (i.e., FICLONE) >> + then we could possibly be more restrictive with errors deemed non terminal. >> + However doing that like in the following >> + would be more coupled to disparate errno handling on various systems. >> + if (0 <= dest_desc) >> + transient_failure = ! is_CLONENOTSUP (errno, false); */ >> + bool transient_failure = is_transient_failure (errno); > > I had trouble with those two "transient_failure"s lining up, plus the > terminology thing mentioned above. I suggest changing this to: > > /* When FICLONE fails, report failure only with errno values known > to mean trouble when FICLONE is supported and called properly. > Do do not report failure merely because !is_CLONENOTSUP (errno), > as too many systems yield oddball errno values here. */ > bool report_failure = (errno == EIO || errno == ENOMEM > || errno == ENOSPC || errno == EDQUOT); > > and then replace all occurrences of "transient_failure" with > "report_failure". Thanks for the review. I'll adjust as suggested. The is_CLONENOTSUP() change _was_ a little contrived since it wasn't actually needed in the new implementation. It would only be needed if we ever wanted to change back to the more aggressive errno checks after FICLONE, in which case the is_CLONENOTSUP() would then be correct. I'll leave it as is and comment for now. thanks, Pádraig From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 24 09:21:11 2023 Received: (at 62404-done) by debbugs.gnu.org; 24 Mar 2023 13:21:11 +0000 Received: from localhost ([127.0.0.1]:40016 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfhLz-0001CH-Et for submit@debbugs.gnu.org; Fri, 24 Mar 2023 09:21:11 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:41593) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfhLt-0001B7-Cm for 62404-done@debbugs.gnu.org; Fri, 24 Mar 2023 09:21:10 -0400 Received: by mail-wm1-f53.google.com with SMTP id r19-20020a05600c459300b003eb3e2a5e7bso1020291wmo.0 for <62404-done@debbugs.gnu.org>; Fri, 24 Mar 2023 06:21:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679664047; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=+Iz5ytTGPZYW34cCLC864PZZBBTpst6kQsfrIeDRgfk=; b=W7wCHMIGLu4UwLdkahiHttosX5EnFdHtLvbfmroyxLsSWNugvTpXXZEFDL3kIsJK/X mWyTt29IlG8EQMbwwathjf8RW1n09gHM/d/epkzItz0pJiVDTSWPRe17OGrEb3hIpBoR ifNyCu/idyQ7FOciGXdRB2l833igIMPrgRibtP0mGbLbYZo3q0j1raYIG080NXXjla2J 4S0rv16hIfkvKd6RS4IkMOWd0IkdT9jxMfJwC9wKYK6oT5vlSpJ6Y0kTo7+JswV9b3Wv T92mSraLF4I3ETw1F0MoY9MjEpo9ZES7rNCMktJVPKIQVS7KDZ9TIDJIooFyeK9cvjrh e0ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679664047; h=content-transfer-encoding:in-reply-to:references:cc:to:from :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+Iz5ytTGPZYW34cCLC864PZZBBTpst6kQsfrIeDRgfk=; b=f4zbaVvo6CqJe+6OSHiVMEywGiULTDNisV2HRxD8l70aJaVsCtMURP6u5r1Srtxf7K aTm8OxZsjbApWs2JP9R5d5c/L6Tl5iUpTYn75XT3iEzMfBZ1v0p5GgS1L8dqP+Rg1U3w 2rMC1U1RlKi3BM1FEzLKCfce481kfCidtNUsldp0fWsNXL3S64PDK7+iZTvK33zJLIv/ ZzQZ8Y9D1UQ9TV87xViY+APOEIHr2njA4hki6/PF2UGvxRq0R1D6dP468sk5SGN7n4Zm mtlFnDrnnkRhFr0RUxNdH0n29rpb3J/WY/F9kgdukgVj/gfc4GQWWYB6W4UBqpsjnrAR Ivwg== X-Gm-Message-State: AO0yUKXicBgEVV29k9x1OU6Ww5fotbgg+tfnR3Znruk6xNRwKpm+hfUU wq0+nhaIO17JrqqR+1c+QAo= X-Google-Smtp-Source: AK7set/OCUgnDhLlvJPG6kMHZJzGoZ0fBBduixhpwYGiDQe5XPGVToxIp43mVqnj1ZrvkWPMy+FNBQ== X-Received: by 2002:a1c:6a04:0:b0:3e2:662:ade6 with SMTP id f4-20020a1c6a04000000b003e20662ade6mr2566432wmc.26.1679664042031; Fri, 24 Mar 2023 06:20:42 -0700 (PDT) Received: from [192.168.1.9] (95-44-90-175-dynamic.agg2.lod.rsl-rtd.eircom.net. [95.44.90.175]) by smtp.googlemail.com with ESMTPSA id f20-20020a1c6a14000000b003edcc2223c6sm4861783wmc.28.2023.03.24.06.20.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Mar 2023 06:20:41 -0700 (PDT) Message-ID: <634c76da-444a-ec74-6fee-1b84eca23a16@draigBrady.com> Date: Fri, 24 Mar 2023 13:20:40 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:109.0) Gecko/20100101 Thunderbird/109.0 Subject: Re: bug#62404: --reflink=auto not falling back appropriately on older kernels Content-Language: en-US From: =?UTF-8?Q?P=C3=A1draig_Brady?= To: Paul Eggert References: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> <23e4878b-5c48-4b79-ed2d-bc47af0ba26a@cs.ucla.edu> <8411fa9f-70ff-e9fa-85dc-b2e21e70f7fb@draigBrady.com> In-Reply-To: <8411fa9f-70ff-e9fa-85dc-b2e21e70f7fb@draigBrady.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Score: -0.9 (/) X-Debbugs-Envelope-To: 62404-done Cc: 62404-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) The fix for this is now pushed at: https://git.sv.gnu.org/gitweb/?p=coreutils.git;a=commitdiff;h=093a8b4bf marking this as done. thanks, Pádraig From debbugs-submit-bounces@debbugs.gnu.org Sat Mar 25 16:34:51 2023 Received: (at 62404) by debbugs.gnu.org; 25 Mar 2023 20:34:51 +0000 Received: from localhost ([127.0.0.1]:43563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgAbC-0004MC-Jh for submit@debbugs.gnu.org; Sat, 25 Mar 2023 16:34:51 -0400 Received: from mail.cs.ucla.edu ([131.179.128.66]:43816) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgAbA-0004Lw-SR for 62404@debbugs.gnu.org; Sat, 25 Mar 2023 16:34:49 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id A1B043C0140A5; Sat, 25 Mar 2023 13:34:42 -0700 (PDT) Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id kZkoUNYwPjyU; Sat, 25 Mar 2023 13:34:42 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by mail.cs.ucla.edu (Postfix) with ESMTP id 14E843C02213D; Sat, 25 Mar 2023 13:34:42 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.cs.ucla.edu 14E843C02213D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cs.ucla.edu; s=9D0B346E-2AEB-11ED-9476-E14B719DCE6C; t=1679776482; bh=E8oxDV1FIno8wkwPEeNAKKKKJBIja0Xfj1c1Nt+s27U=; h=Message-ID:Date:MIME-Version:To:From; b=eMySBkBfo8jH6w2cmYdJPNAQJbPjF4Y2F23NQBQqCINxxlugqQp7BYKe1KN6zB0h2 pP/qw0veHcdFOqMiR8NaZ5YUIy5fy+Ocbu9gcp4RA97Rbm6+QdkoGQwZzjTHRF/g+1 tvjc7/iyUhS17XR6Mntu/Pghk9PsGf3U+bh6drfzmEAnnPsvCqYKM5/nfoE8kFieum zWo8LTVLObCJeAwwst7B6z2vmUz0Up+gvHkr0Z2dIGaKcdw3kGy061X+p1cWd46Ekz LcGBF8xBPi097t+wos2MkiNTOSbRVRtb6je0CjDPYtrKycIuND4xRABFtFpyUap4Se 8NtwGN962jFYA== X-Virus-Scanned: amavisd-new at mail.cs.ucla.edu Received: from mail.cs.ucla.edu ([127.0.0.1]) by localhost (mail.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KMWg-wBeVhWB; Sat, 25 Mar 2023 13:34:42 -0700 (PDT) Received: from [192.168.1.9] (cpe-172-91-119-151.socal.res.rr.com [172.91.119.151]) by mail.cs.ucla.edu (Postfix) with ESMTPSA id E5FD83C0140A5; Sat, 25 Mar 2023 13:34:41 -0700 (PDT) Content-Type: multipart/mixed; boundary="------------ioR1PrcrWod8WYYfkY2O9SwG" Message-ID: <3ac7ec8d-f089-2e9a-6685-72ffa2b0b3bf@cs.ucla.edu> Date: Sat, 25 Mar 2023 13:34:40 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US To: =?UTF-8?Q?P=c3=a1draig_Brady?= References: <5cd3f6b6-5d68-8f92-7856-cb960168ba5f@draigBrady.com> <23e4878b-5c48-4b79-ed2d-bc47af0ba26a@cs.ucla.edu> <8411fa9f-70ff-e9fa-85dc-b2e21e70f7fb@draigBrady.com> <634c76da-444a-ec74-6fee-1b84eca23a16@draigBrady.com> From: Paul Eggert Organization: UCLA Computer Science Department Subject: Re: bug#62404: --reflink=auto not falling back appropriately on older kernels In-Reply-To: <634c76da-444a-ec74-6fee-1b84eca23a16@draigBrady.com> X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: 62404 Cc: 62404@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) This is a multi-part message in MIME format. --------------ioR1PrcrWod8WYYfkY2O9SwG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Thanks for installing that. I found the comments still a bit confusing so I pushed the attached; hope it's OK. It is annoying that in the common case where A is a regular file and B does not exist but will be created on the same file system, the syscalls start out: openat(AT_FDCWD, "B", O_RDONLY|O_PATH|O_DIRECTORY) = -1 ENOENT newfstatat(AT_FDCWD, "A", ...}, 0) = 0 openat(AT_FDCWD, "A", O_RDONLY) = 3 newfstatat(3, "", ..., AT_EMPTY_PATH) = 0 openat(AT_FDCWD, "B", O_WRONLY|O_CREAT|O_EXCL, 0775) = 4 ioctl(4, BTRFS_IOC_CLONE or FICLONE, 3) = -1 EOPNOTSUPP newfstatat(4, "", ..., AT_EMPTY_PATH) = 0 They should be just: openat(AT_FDCWD, "A", O_RDONLY) = 3 newfstatat(3, "", ..., AT_EMPTY_PATH) = 0 openat(AT_FDCWD, "B", O_WRONLY|O_CREAT|O_EXCL, 0775) = 4 ioctl(4, BTRFS_IOC_CLONE or FICLONE, 3) = -1 EOPNOTSUPP newfstatat(4, "", ..., AT_EMPTY_PATH) = 0 as there should be no need to stat the source twice, or to try to open the destination twice. But this is a performance improvement for another day. --------------ioR1PrcrWod8WYYfkY2O9SwG Content-Type: text/x-patch; charset=UTF-8; name="0001-cp-clarify-commentary.patch" Content-Disposition: attachment; filename="0001-cp-clarify-commentary.patch" Content-Transfer-Encoding: base64 RnJvbSA2MjcyODE3ZGUwMDdkMjM2ZjgyNjE2ZGY1OTE2YmUzNzMzM2JhMTYzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBQYXVsIEVnZ2VydCA8ZWdnZXJ0QGNzLnVjbGEuZWR1 PgpEYXRlOiBTYXQsIDI1IE1hciAyMDIzIDA5OjMwOjIyIC0wNzAwClN1YmplY3Q6IFtQQVRD SF0gY3A6IGNsYXJpZnkgY29tbWVudGFyeQoKKiBzcmMvY29weS5jOiBNYWtlIGNvbW1lbnRz IGEgYml0IGNsZWFyZXIuCi0tLQogc3JjL2NvcHkuYyB8IDIyICsrKysrKysrKysrLS0tLS0t LS0tLS0KIDEgZmlsZSBjaGFuZ2VkLCAxMSBpbnNlcnRpb25zKCspLCAxMSBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9zcmMvY29weS5jIGIvc3JjL2NvcHkuYwppbmRleCBmOGJhMDU4 ZDYuLmE4YWExNDkyMCAxMDA2NDQKLS0tIGEvc3JjL2NvcHkuYworKysgYi9zcmMvY29weS5j CkBAIC0yNzgsOSArMjc4LDEwIEBAIGNyZWF0ZV9ob2xlIChpbnQgZmQsIGNoYXIgY29uc3Qg Km5hbWUsIGJvb2wgcHVuY2hfaG9sZXMsIG9mZl90IHNpemUpCiB9CiAKIAotLyogV2hldGhl ciB0aGUgZXJybm8gaW5kaWNhdGVzIHRoZSBvcGVyYXRpb24gaXMgYSB0cmFuc2llbnQgZmFp bHVyZS4KLSAgIEkuZS4sIGEgZmFpbHVyZSB0aGF0IHdvdWxkIGluZGljYXRlIHRoZSBvcGVy YXRpb24gX2lzXyBzdXBwb3J0ZWQsCi0gICBidXQgaGFzIGZhaWxlZCBpbiBhIHRlcm1pbmFs IHdheS4gICovCisvKiBXaGV0aGVyIGFuIGVycm5vIHZhbHVlIEVSUiwgc2V0IGJ5IEZJQ0xP TkUgb3IgY29weV9maWxlX3JhbmdlLAorICAgaW5kaWNhdGVzIHRoYXQgdGhlIGNvcHlpbmcg b3BlcmF0aW9uIGhhcyB0ZXJtaW5hbGx5IGZhaWxlZCwgZXZlbgorICAgdGhvdWdoIGl0IHdh cyBpbnZva2VkIGNvcnJlY3RseSAoc28gdGhhdCwgZS5nLCBFQkFERiBjYW5ub3Qgb2NjdXIp CisgICBhbmQgZXZlbiB0aG91Z2ggIWlzX0NMT05FTk9UU1VQIChFUlIpLiAgKi8KIAogc3Rh dGljIGJvb2wKIGlzX3Rlcm1pbmFsX2Vycm9yIChpbnQgZXJyKQpAQCAtMjg4LDkgKzI4OSw5 IEBAIGlzX3Rlcm1pbmFsX2Vycm9yIChpbnQgZXJyKQogICByZXR1cm4gZXJyID09IEVJTyB8 fCBlcnIgPT0gRU5PTUVNIHx8IGVyciA9PSBFTk9TUEMgfHwgZXJyID09IEVEUVVPVDsKIH0K IAotCi0vKiBXaGV0aGVyIHRoZSBlcnJubyBmcm9tIEZJQ0xPTkUsIG9yIGNvcHlfZmlsZV9y YW5nZSBpbmRpY2F0ZXMKLSAgIHRoZSBvcGVyYXRpb24gaXMgbm90IHN1cHBvcnRlZC9hbGxv d2VkIGZvciB0aGlzIGZpbGUgb3IgcHJvY2Vzcy4gICovCisvKiBTaW1pbGFybHksIHdoZXRo ZXIgRVJSIGluZGljYXRlcyB0aGF0IHRoZSBjb3B5aW5nIG9wZXJhdGlvbiBpcyBub3QKKyAg IHN1cHBvcnRlZCBvciBhbGxvd2VkIGZvciB0aGlzIGZpbGUgb3IgcHJvY2VzcywgZXZlbiB0 aG91Z2ggdGhlCisgICBvcGVyYXRpb24gd2FzIGludm9rZWQgY29ycmVjdGx5LiAgKi8KIAog c3RhdGljIGJvb2wKIGlzX0NMT05FTk9UU1VQIChpbnQgZXJyKQpAQCAtMTE3OCwxNiArMTE3 OSwxNSBAQCBmZF9oYXNfYWNsIChpbnQgZmQpCiAgICBSZXR1cm4gRkFMU0UgaWYgaXQncyBh IHRlcm1pbmFsIGZhaWx1cmUgZm9yIHRoaXMgZmlsZS4gICovCiAKIHN0YXRpYyBib29sCi1o YW5kbGVfY2xvbmVfZmFpbCAoaW50IGRzdF9kaXJmZCwgY2hhciBjb25zdCogZHN0X3JlbG5h bWUsCi0gICAgICAgICAgICAgICAgICAgY2hhciBjb25zdCogc3JjX25hbWUsIGNoYXIgY29u c3QqIGRzdF9uYW1lLAoraGFuZGxlX2Nsb25lX2ZhaWwgKGludCBkc3RfZGlyZmQsIGNoYXIg Y29uc3QgKmRzdF9yZWxuYW1lLAorICAgICAgICAgICAgICAgICAgIGNoYXIgY29uc3QgKnNy Y19uYW1lLCBjaGFyIGNvbnN0ICpkc3RfbmFtZSwKICAgICAgICAgICAgICAgICAgICBpbnQg ZGVzdF9kZXNjLCBib29sIG5ld19kc3QsIGVudW0gUmVmbGlua190eXBlIHJlZmxpbmtfbW9k ZSkKIHsKICAgLyogV2hlbiB0aGUgY2xvbmUgb3BlcmF0aW9uIGZhaWxzLCByZXBvcnQgZmFp bHVyZSBvbmx5IHdpdGggZXJybm8gdmFsdWVzCiAgICAgIGtub3duIHRvIG1lYW4gdHJvdWJs ZSB3aGVuIHRoZSBjbG9uZSBpcyBzdXBwb3J0ZWQgYW5kIGNhbGxlZCBwcm9wZXJseS4KICAg ICAgRG8gbm90IHJlcG9ydCBmYWlsdXJlIG1lcmVseSBiZWNhdXNlICFpc19DTE9ORU5PVFNV UCAoZXJybm8pLAotICAgICBhcyBzeXN0ZW1zIG1heSB5aWVsZCBvZGRiYWxsIGVycm5vIHZh bHVlcyBoZXJlIHdpdGggRklDTE9ORS4KLSAgICAgQWxzbyBpc19DTE9ORU5PVFNVUCgpIGlz IG5vdCBhcHByb3ByaWF0ZSBmb3IgdGhlIHJhbmdlIG9mIGVycm5vcwotICAgICBwb3NzaWJs ZSBmcm9tIGZjbG9uZWZpbGVhdCgpLCBzbyBpdCdzIG1vcmUgY29uc2lzdGVudCB0byBhdm9p ZC4gKi8KKyAgICAgYXMgc3lzdGVtcyBtYXkgeWllbGQgb2RkYmFsbCBlcnJubyB2YWx1ZXMg aGVyZSB3aXRoIEZJQ0xPTkUsCisgICAgIGFuZCBpc19DTE9ORU5PVFNVUCBpcyBub3QgYXBw cm9wcmlhdGUgZm9yIGZjbG9uZWZpbGVhdC4gICovCiAgIGJvb2wgcmVwb3J0X2ZhaWx1cmUg PSBpc190ZXJtaW5hbF9lcnJvciAoZXJybm8pOwogCiAgIGlmIChyZWZsaW5rX21vZGUgPT0g UkVGTElOS19BTFdBWVMgfHwgcmVwb3J0X2ZhaWx1cmUpCi0tIAoyLjM3LjIKCg== --------------ioR1PrcrWod8WYYfkY2O9SwG-- From unknown Sat Jun 21 03:10:48 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 23 Apr 2023 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator