From unknown Wed Aug 20 06:40:47 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#624 <624@debbugs.gnu.org> To: bug#624 <624@debbugs.gnu.org> Subject: Status: 23.0.60; checkin unmodified rcs file fails Reply-To: bug#624 <624@debbugs.gnu.org> Date: Wed, 20 Aug 2025 13:40:47 +0000 retitle 624 23.0.60; checkin unmodified rcs file fails reassign 624 emacs submitter 624 Alex Harsanyi severity 624 normal thanks From harsanyi@mac.com Tue Jul 29 03:08:00 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-7.9 required=4.0 tests=BAYES_00,FOURLA, MURPHY_DRUGS_REL8,RCVD_IN_DNSWL_MED autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at submit) by emacsbugs.donarmstrong.com; 29 Jul 2008 10:08:00 +0000 Received: from fencepost.gnu.org (fencepost.gnu.org [140.186.70.10]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m6TA7uX6016240 for ; Tue, 29 Jul 2008 03:07:57 -0700 Received: from mx10.gnu.org ([199.232.76.166]:43591) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1KNm6i-0007yK-R5 for emacs-pretest-bug@gnu.org; Tue, 29 Jul 2008 06:07:04 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1KNm7T-0005GH-66 for emacs-pretest-bug@gnu.org; Tue, 29 Jul 2008 06:07:56 -0400 Received: from hosted01.westnet.com.au ([203.10.1.211]:52520) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KNm7S-0005Fj-8F for emacs-pretest-bug@gnu.org; Tue, 29 Jul 2008 06:07:51 -0400 Received: from hosted01.westnet.com.au (hosted01.westnet.com.au [127.0.0.1]) by hosted01.westnet.com.au (Postfix) with SMTP id B076D2BEC90 for ; Tue, 29 Jul 2008 18:07:45 +0800 (WST) Received: from [10.0.1.2] (dsl-58-7-58-174.wa.westnet.com.au [58.7.58.174]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by hosted01.westnet.com.au (Postfix) with ESMTP id 165A52BECAF for ; Tue, 29 Jul 2008 18:07:44 +0800 (WST) Mime-Version: 1.0 (Apple Message framework v753.1) Content-Transfer-Encoding: 7bit Message-Id: Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed To: emacs-pretest-bug@gnu.org From: Alex Harsanyi Subject: 23.0.60; checkin unmodified rcs file fails Date: Tue, 29 Jul 2008 18:07:42 +0800 X-Mailer: Apple Mail (2.753.1) X-PMX-Branch: TNG-Outgoing X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) 1/ checkout a RCS file (using C-x v v) 2/ Type C-x v v again Emacs will notice that the file is not modified and will revert it without asking (previous versions used to ask the user). However, after that it will pop-up a log buffer and allow the user to continue with the checkin. Trying to checkin (C-c C-c) will result in an error (since the file is no longer checked out). This happens because `vc-next-action' will revert all the unchanged files form the changeset and remove them from the `read-for-commmit' list. Unfortunately it uses the `delete' function incorrectly, leaving the reverted file in the list if it is the first one. The patch below contains a fix for the problem: --- vc.el 25 Jul 2008 17:08:11 +0800 1.698 +++ vc.el 25 Jul 2008 17:10:35 +0800 @@ -1085,7 +1085,7 @@ merge in the changes into your working c ;; finishing the log entry and committing. (not (and visited (buffer-modified-p)))) (vc-revert-file file) - (delete file ready-for-commit))))) + (setq ready-for-commit (delete file ready-for-commit)))))) ;; Remaining files need to be committed (if (not ready-for-commit) (message "No files remain to be committed") In GNU Emacs 23.0.60.1 (powerpc-apple-darwin8.11.0, *Step 9.0) of 2008-07-29 on karinji.local Windowing system distributor `Apple', version 49.46.48 configured using `configure '--with-ns'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: nil value of $XMODIFIERS: nil locale-coding-system: nil default-enable-multibyte-characters: t Major mode: Java/l Minor modes in effect: show-paren-mode: t global-cwarn-mode: t display-time-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t abbrev-mode: t Recent input: h e l l o C-a C-k C-x C-f / ~ / . e m i n i s-> M-> s-< C-x C-s M-< M-> M-< C-x 5 2 C-x C-f P / P r o C-d / P ~ / P r o E m M-> C-c t C-x C-f M-> + R C S C-x v i C-x C-v C-v C-g C-g C-x v v C-x v v h e l l o C-c C-c C-x 0 M-x r e p o r t Recent messages: Registering (/Users/haral/Other/except.java)... done call-interactively: End of buffer Quit [2 times] Checking out /Users/haral/Other/except.java...done Mark set Press C-c C-c when you are done editing. Enter a change comment. Type C-c C-c when done Checking in /Users/haral/Other/except.java... vc-do-command: Running ci -j -u1 -mhello RCS/except.java,v...FAILED (status 1) From cyd@stupidchicken.com Sat Aug 2 14:33:48 2008 X-Spam-Checker-Version: SpamAssassin 3.2.3-bugs.debian.org_2005_01_02 (2007-08-08) on rzlab.ucr.edu X-Spam-Level: X-Spam-Status: No, score=-3.1 required=4.0 tests=AWL,BAYES_00, MURPHY_DRUGS_REL8 autolearn=ham version=3.2.3-bugs.debian.org_2005_01_02 Received: (at 624-done) by emacsbugs.donarmstrong.com; 2 Aug 2008 21:33:48 +0000 Received: from cyd (CYD.MIT.EDU [18.115.2.24]) by rzlab.ucr.edu (8.13.8/8.13.8/Debian-3) with ESMTP id m72LXj0U008010 for <624-done@emacsbugs.donarmstrong.com>; Sat, 2 Aug 2008 14:33:46 -0700 Received: by cyd (Postfix, from userid 1000) id CE6C757E337; Sat, 2 Aug 2008 17:33:56 -0400 (EDT) From: Chong Yidong To: Alex Harsanyi Cc: 624-done@debbugs.gnu.org Subject: Re: 23.0.60; checkin unmodified rcs file fails Date: Sat, 02 Aug 2008 17:33:56 -0400 Message-ID: <87r6979k57.fsf@stupidchicken.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii > This happens because `vc-next-action' will revert all the unchanged > files form the changeset and remove them from the `read-for-commmit' > list. Unfortunately it uses the `delete' function incorrectly, > leaving the reverted file in the list if it is the first one. The > patch below contains a fix for the problem: Thanks very much. I've checked in your fix. From unknown Wed Aug 20 06:40:47 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: $requester Subject: Internal Control Message-Id: bug archived. Date: Sun, 31 Aug 2008 14:24:03 +0000 User-Agent: Fakemail v42.6.9 # A New Hope # A log time ago, in a galaxy far, far away # something happened. # # Magically this resulted in the following # action being taken, but this fake control # message doesn't tell you why it happened # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator