GNU bug report logs - #62376
30.0.50; global-display-fill-column-indicator-modes broken?

Previous Next

Package: emacs;

Reported by: Rudolf Adamkovič <salutis <at> me.com>

Date: Wed, 22 Mar 2023 12:04:01 UTC

Severity: normal

Found in version 30.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Lars Ingebrigtsen <larsi <at> gnus.org>, 62376 <at> debbugs.gnu.org, Rudolf Adamkovič <salutis <at> me.com>
Subject: bug#62376: 30.0.50; global-display-fill-column-indicator-modes broken?
Date: Wed, 22 Mar 2023 13:52:50 -0400
>> So, today I customized the
>> 
>> > global-display-fill-column-indicator-modes
>> 
>> variable, and it does not work.

I think it's a thinko in the code: we define the variable but the code
hardcode the var's default value instead of looking up the variable's
actual value.

The patch below should fix it.


        Stefan


diff --git a/lisp/emacs-lisp/easy-mmode.el b/lisp/emacs-lisp/easy-mmode.el
index 5721470ad0d..e84207da2df 100644
--- a/lisp/emacs-lisp/easy-mmode.el
+++ b/lisp/emacs-lisp/easy-mmode.el
@@ -509,7 +509,7 @@ define-globalized-minor-mode
          (setq turn-on-function
                `(lambda ()
                   (require 'easy-mmode)
-                  (when (easy-mmode--globalized-predicate-p ,(car predicate))
+                  (when (easy-mmode--globalized-predicate-p ,MODE-predicate)
                     (funcall ,turn-on-function)))))
         (_ (push keyw extra-keywords) (push (pop body) extra-keywords))))
 





This bug report was last modified 2 years and 112 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.