From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Evgeni Kolev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 22 Mar 2023 08:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 62371@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.167947238818114 (code B ref -1); Wed, 22 Mar 2023 08:07:01 +0000 Received: (at submit) by debbugs.gnu.org; 22 Mar 2023 08:06:28 +0000 Received: from localhost ([127.0.0.1]:33395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1petUK-0004i6-6q for submit@debbugs.gnu.org; Wed, 22 Mar 2023 04:06:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:33162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1petUJ-0004hz-4l for submit@debbugs.gnu.org; Wed, 22 Mar 2023 04:06:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1petUI-0001hr-Sg for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 04:06:26 -0400 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1petUH-0001Pg-Br for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 04:06:26 -0400 Received: by mail-qv1-xf2c.google.com with SMTP id m16so4307924qvi.12 for ; Wed, 22 Mar 2023 01:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679472382; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=y398oMGCW8sUIWthLPt7QbY+PIXBtiqTCSkM+5EZVek=; b=VRjcLXuAm4SXVRpQhG+NxjCy+pi688TwEiyAiQIywVf7un0DG89lzboUuXWwcwnBjj Nnqd7U2Rs9OuxHlv8xgkoNB46axe7VKp5eb76uPIzIjJG1H3tlb15AHmy6OGjgeHN8WI itAMNWP+xyBFP7d/sOCou0Ni2rq7oVFKIShVy3WV9UX0BopwRUvSHzRcW0M8J9Pev7mb 7MNOcCc+0hplKLWoM1oyRMzUGxGg6ziECnvIxNUeKQam/qWXGyj/4phMa501zzHAckZU BRnobIdof+4ztiW2cCHbn5bJGXq7BTy2HPc60R2rYxLtX2BzitBRZByaCiGfAof/je7r HeoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679472382; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=y398oMGCW8sUIWthLPt7QbY+PIXBtiqTCSkM+5EZVek=; b=w/QoiX15fYcaLRWTAHf1+bShPF7LFk2JnBOYZTxvKBdfCxDnQDgRHm0yHrdrVJmLRR OVymRXocwCOq43D+Cuj81TZ8DuaHnflI5rmAo9nP8uN475syigzVpgN9GWY9GyeiB8dM /lJKHQzXN5wkRJc8Bp+jtzDAtAUDqQTHXyU/0xrlfx0exbJ422ozYnOJQev9ZCs//m0r ZDWtbOfHyXdGaBAnvGQIykvOskSdRiytFyI/zG4WDSXi9LgEDxumP02ToT6CZ+6S04lR t2+kwExGSJa+nwQs6Ffz6/Uh5iuAUbI0OOEAOEQCBGW3hdwl/XdVSUavGF8j3ThXUqSX 0iCQ== X-Gm-Message-State: AO0yUKVkZ9SfyKfNk6n5YHarXW/QN9ueADZgQW1rXlH6enM/7tOFdGj/ VKLDDB1RPKT6s4JkOnPraKf4WfmKVgbkeUDWA6zSfqjg8Kv0Fzd7 X-Google-Smtp-Source: AK7set8jO9ucXesuKy3OTz/vCMA/KlCp2FNo7vI3n296KTbVM2fHmKVM6Zso6dpZAfV1CJWMaRRXHV8mNR2CGzoag9s= X-Received: by 2002:ad4:4f25:0:b0:56f:fe44:f257 with SMTP id fc5-20020ad44f25000000b0056ffe44f257mr562556qvb.1.1679472382453; Wed, 22 Mar 2023 01:06:22 -0700 (PDT) MIME-Version: 1.0 From: Evgeni Kolev Date: Wed, 22 Mar 2023 10:05:56 +0200 Message-ID: Content-Type: multipart/mixed; boundary="000000000000c4826c05f778a2f0" Received-SPF: pass client-ip=2607:f8b0:4864:20::f2c; envelope-from=evgenysw@gmail.com; helo=mail-qv1-xf2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000c4826c05f778a2f0 Content-Type: text/plain; charset="UTF-8" The docstring inserted with go-ts-mode's C-c C-d was incorrectly prefixed with the receiver "(myStruct).": // (myStruct).act func (m *myStruct) act () {...} The above docstring is not correct because the receiver "myStruct" should not be in the docstring. The issue is caused by imenu and go-ts-mode--defun-name using the same code to determine the defun name. Instead, they should produce different results - imenu should show the "myStruct" prefix, but the docstring should not. This commit fixes the incorrect behavior by introducing an optional SKIP-PREFIX parameter to (go-ts-mode--defun-name). Pressing C-c C-d now inserts just the method name: // act func (m *myStruct) act () {...} * lisp/progmodes/go-ts-mode.el (go-ts-mode--defun-name): New optional parameter SKIP-PREFIX. (go-ts-mode-docstring): Call (go-ts-mode--defun-name t) instead of (treesit-defun-name). --000000000000c4826c05f778a2f0 Content-Type: application/octet-stream; name="0001-Fix-go-ts-mode-incorrect-docstring-inserted-for-meth.patch" Content-Disposition: attachment; filename="0001-Fix-go-ts-mode-incorrect-docstring-inserted-for-meth.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lfjeg3u30 RnJvbSA0M2VjMDg0MTI4NjgwOTk3MzViMjI5ZTRhZWZmNWViMjc2YzRmMDgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFdmdlbmkgS29sZXYgPGV2Z2VueXN3QGdtYWlsLmNvbT4KRGF0 ZTogV2VkLCA4IEZlYiAyMDIzIDE3OjE2OjAyICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGdv LXRzLW1vZGUgaW5jb3JyZWN0IGRvY3N0cmluZyBpbnNlcnRlZCBmb3IgbWV0aG9kcwoKVGhlIGRv Y3N0cmluZyBpbnNlcnRlZCB3aXRoIGdvLXRzLW1vZGUncyBDLWMgQy1kIHdhcyBpbmNvcnJlY3Rs eQpwcmVmaXhlZCB3aXRoIHRoZSByZWNlaXZlciAiKG15U3RydWN0KS4iOgoKICAgIC8vIChteVN0 cnVjdCkuYWN0CiAgICBmdW5jIChtICpteVN0cnVjdCkgYWN0ICgpIHsuLi59CgpUaGUgYWJvdmUg ZG9jc3RyaW5nIGlzIG5vdCBjb3JyZWN0IGJlY2F1c2UgdGhlIHJlY2VpdmVyICJteVN0cnVjdCIK c2hvdWxkIG5vdCBiZSBpbiB0aGUgZG9jc3RyaW5nLgoKVGhlIGlzc3VlIGlzIGNhdXNlZCBieSBp bWVudSBhbmQgZ28tdHMtbW9kZS0tZGVmdW4tbmFtZSB1c2luZyB0aGUgc2FtZQpjb2RlIHRvIGRl dGVybWluZSB0aGUgZGVmdW4gbmFtZS4gSW5zdGVhZCwgdGhleSBzaG91bGQgcHJvZHVjZQpkaWZm ZXJlbnQgcmVzdWx0cyAtIGltZW51IHNob3VsZCBzaG93IHRoZSAibXlTdHJ1Y3QiIHByZWZpeCwg YnV0IHRoZQpkb2NzdHJpbmcgc2hvdWxkIG5vdC4KClRoaXMgY29tbWl0IGZpeGVzIHRoZSBpbmNv cnJlY3QgYmVoYXZpb3IgYnkgaW50cm9kdWNpbmcgYW4gb3B0aW9uYWwKU0tJUC1QUkVGSVggcGFy YW1ldGVyIHRvIChnby10cy1tb2RlLS1kZWZ1bi1uYW1lKS4gUHJlc3NpbmcgQy1jIEMtZApub3cg aW5zZXJ0cyBqdXN0IHRoZSBtZXRob2QgbmFtZToKCiAgICAvLyBhY3QKICAgIGZ1bmMgKG0gKm15 U3RydWN0KSBhY3QgKCkgey4uLn0KCiogbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCAoZ28t dHMtbW9kZS0tZGVmdW4tbmFtZSk6IE5ldyBvcHRpb25hbApwYXJhbWV0ZXIgU0tJUC1QUkVGSVgu IChnby10cy1tb2RlLWRvY3N0cmluZyk6CkNhbGwgKGdvLXRzLW1vZGUtLWRlZnVuLW5hbWUgdCkg aW5zdGVhZCBvZiAodHJlZXNpdC1kZWZ1bi1uYW1lKS4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9nby10 cy1tb2RlLmVsIHwgMTYgKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0 aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9nby10 cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAppbmRleCBlNmU4YWJkNjQ0 NS4uZmRhNmEzNmU0MmQgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwK KysrIGIvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbApAQCAtMjU1LDkgKzI1NSwxMCBAQCBn by10cy1tb2RlCiAoaWYgKHRyZWVzaXQtcmVhZHktcCAnZ28pCiAgICAgKGFkZC10by1saXN0ICdh dXRvLW1vZGUtYWxpc3QgJygiXFwuZ29cXCciIC4gZ28tdHMtbW9kZSkpKQogCi0oZGVmdW4gZ28t dHMtbW9kZS0tZGVmdW4tbmFtZSAobm9kZSkKKyhkZWZ1biBnby10cy1tb2RlLS1kZWZ1bi1uYW1l IChub2RlICZvcHRpb25hbCBza2lwLXByZWZpeCkKICAgIlJldHVybiB0aGUgZGVmdW4gbmFtZSBv ZiBOT0RFLgotUmV0dXJuIG5pbCBpZiB0aGVyZSBpcyBubyBuYW1lIG9yIGlmIE5PREUgaXMgbm90 IGEgZGVmdW4gbm9kZS4iCitSZXR1cm4gbmlsIGlmIHRoZXJlIGlzIG5vIG5hbWUgb3IgaWYgTk9E RSBpcyBub3QgYSBkZWZ1biBub2RlLgorTWV0aG9kcyBhcmUgcHJlZml4ZWQgd2l0aCB0aGUgcmVj ZWl2ZXIgbmFtZSwgdW5sZXNzIFNLSVAtUFJFRklYIGlzIHQuIgogICAocGNhc2UgKHRyZWVzaXQt bm9kZS10eXBlIG5vZGUpCiAgICAgKCJmdW5jdGlvbl9kZWNsYXJhdGlvbiIKICAgICAgKHRyZWVz aXQtbm9kZS10ZXh0CkBAIC0yNjYsMTEgKzI2NywxMCBAQCBnby10cy1tb2RlLS1kZWZ1bi1uYW1l CiAgICAgICB0KSkKICAgICAoIm1ldGhvZF9kZWNsYXJhdGlvbiIKICAgICAgKGxldCogKChyZWNl aXZlci1ub2RlICh0cmVlc2l0LW5vZGUtY2hpbGQtYnktZmllbGQtbmFtZSBub2RlICJyZWNlaXZl ciIpKQotICAgICAgICAgICAgKHR5cGUtbm9kZSAodHJlZXNpdC1zZWFyY2gtc3VidHJlZSByZWNl aXZlci1ub2RlICJ0eXBlX2lkZW50aWZpZXIiKSkKLSAgICAgICAgICAgIChuYW1lLW5vZGUgKHRy ZWVzaXQtbm9kZS1jaGlsZC1ieS1maWVsZC1uYW1lIG5vZGUgIm5hbWUiKSkpCi0gICAgICAgKGNv bmNhdAotICAgICAgICAiKCIgKHRyZWVzaXQtbm9kZS10ZXh0IHR5cGUtbm9kZSkgIikuIgotICAg ICAgICAodHJlZXNpdC1ub2RlLXRleHQgbmFtZS1ub2RlKSkpKQorICAgICAgICAgICAgKHJlY2Vp dmVyICh0cmVlc2l0LW5vZGUtdGV4dCAodHJlZXNpdC1zZWFyY2gtc3VidHJlZSByZWNlaXZlci1u b2RlICJ0eXBlX2lkZW50aWZpZXIiKSkpCisgICAgICAgICAgICAobWV0aG9kICh0cmVlc2l0LW5v ZGUtdGV4dCAodHJlZXNpdC1ub2RlLWNoaWxkLWJ5LWZpZWxkLW5hbWUgbm9kZSAibmFtZSIpKSkp CisgICAgICAgKGlmIHNraXAtcHJlZml4IG1ldGhvZAorICAgICAgICAgKGNvbmNhdCAiKCIgcmVj ZWl2ZXIgIikuIiBtZXRob2QpKSkpCiAgICAgKCJ0eXBlX2RlY2xhcmF0aW9uIgogICAgICAodHJl ZXNpdC1ub2RlLXRleHQKICAgICAgICh0cmVlc2l0LW5vZGUtY2hpbGQtYnktZmllbGQtbmFtZQpA QCAtMzE0LDcgKzMxNCw3IEBAIGdvLXRzLW1vZGUtZG9jc3RyaW5nCiAgICAgICAgIDs7IGdvIHRv IHRvcCBjb21tZW50IGxpbmUKICAgICAgICAgKHdoaWxlIChnby10cy1tb2RlLS1jb21tZW50LW9u LXByZXZpb3VzLWxpbmUtcCkKICAgICAgICAgICAoZm9yd2FyZC1saW5lIC0xKSkKLSAgICAgIChp bnNlcnQgIi8vICIgKHRyZWVzaXQtZGVmdW4tbmFtZSBkZWZ1bi1ub2RlKSkKKyAgICAgIChpbnNl cnQgIi8vICIgKGdvLXRzLW1vZGUtLWRlZnVuLW5hbWUgZGVmdW4tbm9kZSB0KSkKICAgICAgIChu ZXdsaW5lKQogICAgICAgKGJhY2t3YXJkLWNoYXIpKSkpCiAKLS0gCjIuMzkuMQoK --000000000000c4826c05f778a2f0-- From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods References: In-Reply-To: Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 24 Mar 2023 18:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: evgeni.d.kolev@gmail.com Cc: Randy Taylor , 62371@debbugs.gnu.org Received: via spool by 62371-submit@debbugs.gnu.org id=B62371.16796821214363 (code B ref 62371); Fri, 24 Mar 2023 18:22:02 +0000 Received: (at 62371) by debbugs.gnu.org; 24 Mar 2023 18:22:01 +0000 Received: from localhost ([127.0.0.1]:41343 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfm37-00018G-90 for submit@debbugs.gnu.org; Fri, 24 Mar 2023 14:22:01 -0400 Received: from mail-pl1-f173.google.com ([209.85.214.173]:34646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfm34-000181-A7 for 62371@debbugs.gnu.org; Fri, 24 Mar 2023 14:21:59 -0400 Received: by mail-pl1-f173.google.com with SMTP id o11so2622178ple.1 for <62371@debbugs.gnu.org>; Fri, 24 Mar 2023 11:21:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679682112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=yHdBkobi1jY6DSM7PY1WaqPmxK7u2fHSREZf7sjLiEs=; b=KKXYv5JPXIkSFaVZFvTVm35SgiF4EfJN96F4uRhKN5vCSy3lBDw2nmowYokFJnZADm 1FzQcCaZ6OZq0qayBNogIcPJ70ulBnyFibKeckT6XzuYRTVtsYS2Z0wqCvNlVekWKPT5 9TSjWlDdLjOX7ZEdZiPnT21RBGvynL73fWvGxl4eNuCJ1z0P9RTvT8KoQ9dF4CT6NvQN yowKp3e05lsMmD1CvAqnvgh5LvrpadqPD2pzBk30fZrBeswPOgwpH9aRQsasEttdF1VP 8+NjlRb/VlFFnjHd9/d+mWLT98KP9vnZ3Gvp7TSlHzq6xpcY3/H60aK45GC8mTGV8o5W dR4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679682112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yHdBkobi1jY6DSM7PY1WaqPmxK7u2fHSREZf7sjLiEs=; b=YzDMU3ajHjcUWRPHKa5QcubgZ1JXnnHQ+TSFmRUspK1zBaFmhhuWCh8Pb5PDfZ01df tgECTf9/3Jp7RZSiFH/8gxL7PRMiO6hLRAb+qrduEEoByyRpRc7wuOffp3FLyd3gTt01 lbc88vsSm/OdRBv6OXQqcdSlWxmpwwl+szMJ4N+HyRaVBuiy3Gbuh2EnrPMBiBAdnvZU vcZSuDPcXwdaBddN5af/fr1yISH3e5it+mQMZr3+pm3RPdp9VRZ8GWLQBM1B/CPVlS80 pHJ+mlKjft45OkHTJLOTSM1yGNiZOAGtdAN/g9P8eLkFnujbJfHEoTIKXUJYmy8t8Q2C 7wiw== X-Gm-Message-State: AO0yUKUM0ZUUb9CtJCRynwxpZjI1Gcj1ewtiIHbcmgC4gnLIXhLzNmWK +MjDnB/yruNFaJRA8ofw37E= X-Google-Smtp-Source: AK7set+1wa5amTx6gJzVpPs5U6kUAD5yIRjx/MdwCpgGVs/pXzrXCXAW+3x/HWI9p+gZBaUm9aUNZw== X-Received: by 2002:a05:6a20:8009:b0:da:4be2:caff with SMTP id e9-20020a056a20800900b000da4be2caffmr3584791pza.56.1679682112586; Fri, 24 Mar 2023 11:21:52 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id s26-20020aa7829a000000b00628c0988d94sm5579182pfm.55.2023.03.24.11.21.51 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 24 Mar 2023 11:21:52 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.400.51.1.1\)) Message-Id: <13B38FE4-FE4E-4809-9636-78D5F265F79C@gmail.com> Date: Fri, 24 Mar 2023 11:21:38 -0700 X-Mailer: Apple Mail (2.3731.400.51.1.1) X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Evgeni Kolev writes: > The docstring inserted with go-ts-mode's C-c C-d was incorrectly > prefixed with the receiver "(myStruct).": > > // (myStruct).act > func (m *myStruct) act () {...} > > The above docstring is not correct because the receiver "myStruct" > should not be in the docstring. > > The issue is caused by imenu and go-ts-mode--defun-name using the same > code to determine the defun name. Instead, they should produce > different results - imenu should show the "myStruct" prefix, but the > docstring should not. > > This commit fixes the incorrect behavior by introducing an optional > SKIP-PREFIX parameter to (go-ts-mode--defun-name). Pressing C-c C-d > now inserts just the method name: > > // act > func (m *myStruct) act () {...} > Thanks! CC=E2=80=99ing Randy. Yuan From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 00:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Yuan Fu Cc: evgeni.d.kolev@gmail.com, 62371@debbugs.gnu.org Received: via spool by 62371-submit@debbugs.gnu.org id=B62371.167970590632405 (code B ref 62371); Sat, 25 Mar 2023 00:59:02 +0000 Received: (at 62371) by debbugs.gnu.org; 25 Mar 2023 00:58:26 +0000 Received: from localhost ([127.0.0.1]:41785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfsEk-0008Qa-6a for submit@debbugs.gnu.org; Fri, 24 Mar 2023 20:58:26 -0400 Received: from mail-4022.proton.ch ([185.70.40.22]:56669) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pfsEg-0008QH-Sp for 62371@debbugs.gnu.org; Fri, 24 Mar 2023 20:58:24 -0400 Date: Sat, 25 Mar 2023 00:58:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1679705896; x=1679965096; bh=OeJLV21yrErBEeCthuEfKzMs4/JNimosl2IVJR3DCj4=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=JwHhwjdYpJ1MFermv3XZAlM9HsaDHkqT83Zes49aixuAfvuduDDi5bc25pglDWKSm +dF1cobIsQqX08zjJuuUKmervanK9EyUGqGpGhVEtXkJU6iUdbQcQq0buoFsYuV1mO NkIrOzFgYaUshVKs4K3/3ZMRzW+RE8nkIZ+hlK31JJPvB7/ZDa2jRfNBEqIzytUW/U QYH5mucuY+8DwWRBs12aK3MlymWfe1wVgogkUByVfjcLVqE/B2To18ihlrIKjaVYxj BTamVsE1FIdMtZuJ9g5DJ36l4NMWSOPFrlPUgb3vfHG9LN1NfkJCpp9ton3MEbsqdA qPnJxm5Pzf8LQ== From: Randy Taylor Message-ID: In-Reply-To: <13B38FE4-FE4E-4809-9636-78D5F265F79C@gmail.com> References: <13B38FE4-FE4E-4809-9636-78D5F265F79C@gmail.com> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Friday, March 24th, 2023 at 14:21, Yuan Fu wrote:=20 > Evgeni Kolev evgeni.d.kolev@gmail.com writes: >=20 > > The docstring inserted with go-ts-mode's C-c C-d was incorrectly > > prefixed with the receiver "(myStruct).": > >=20 > > // (myStruct).act > > func (m *myStruct) act () {...} > >=20 > > The above docstring is not correct because the receiver "myStruct" > > should not be in the docstring. > >=20 > > The issue is caused by imenu and go-ts-mode--defun-name using the same > > code to determine the defun name. Instead, they should produce > > different results - imenu should show the "myStruct" prefix, but the > > docstring should not. > >=20 > > This commit fixes the incorrect behavior by introducing an optional > > SKIP-PREFIX parameter to (go-ts-mode--defun-name). Pressing C-c C-d > > now inserts just the method name: > >=20 > > // act > > func (m *myStruct) act () {...} >=20 >=20 > Thanks! CC=E2=80=99ing Randy. >=20 > Yuan >=20 Thanks, I was going to look yesterday but I forgot :D. Looks good to me! From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 12:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Evgeni Kolev , Randy Taylor , Dmitry Gutov , Yuan Fu Cc: 62371@debbugs.gnu.org Received: via spool by 62371-submit@debbugs.gnu.org id=B62371.167974668117954 (code B ref 62371); Sat, 25 Mar 2023 12:18:01 +0000 Received: (at 62371) by debbugs.gnu.org; 25 Mar 2023 12:18:01 +0000 Received: from localhost ([127.0.0.1]:41985 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2qO-0004fW-Ld for submit@debbugs.gnu.org; Sat, 25 Mar 2023 08:18:00 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg2qN-0004fK-Gf for 62371@debbugs.gnu.org; Sat, 25 Mar 2023 08:17:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2qH-0002oN-7Z; Sat, 25 Mar 2023 08:17:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=DZeP4gmq7dJY2HBBuoJ2C6BeVFB3fuGSXKuLNoZh4jk=; b=LPuyb+hKyF/O dBcsHcJEMVDFb4VlPolRypUP1ksYQiElJ7tUoq46ldRbR7O+butAgOws6MEEB+sTedYdWY0Jjb/kn avAAFth5gyTz3fD8kCN2jMkuEfve2n4AzNpeMuEKUlay9w5BX2MVdKXiZ9+XUV9lYmijSXRsR4Kdl MM6XSmM9nwsjfTp6dnMAeaP97mwcqlFIv718U2myohSJRJc9QrlEe+CyBt7zPu4b9eQVTzLkHko8N 22hS+Z6mRTmfDSGov2j8HLyXTDWR7DBzTrKOVVDDUC8ExE2uDvh0r6Hi4AsQVXvpLgkP8slQdovQk AApKPFyv7Xipszb8EMrPJg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pg2qG-0002Ey-13; Sat, 25 Mar 2023 08:17:52 -0400 Date: Sat, 25 Mar 2023 15:17:48 +0300 Message-Id: <83o7ohc9eb.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Evgeni Kolev on Wed, 22 Mar 2023 10:05:56 +0200) References: X-Spam-Score: -1.9 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.9 (--) > From: Evgeni Kolev > Date: Wed, 22 Mar 2023 10:05:56 +0200 > > The docstring inserted with go-ts-mode's C-c C-d was incorrectly > prefixed with the receiver "(myStruct).": > > // (myStruct).act > func (m *myStruct) act () {...} > > The above docstring is not correct because the receiver "myStruct" > should not be in the docstring. > > The issue is caused by imenu and go-ts-mode--defun-name using the same > code to determine the defun name. Instead, they should produce > different results - imenu should show the "myStruct" prefix, but the > docstring should not. > > This commit fixes the incorrect behavior by introducing an optional > SKIP-PREFIX parameter to (go-ts-mode--defun-name). Pressing C-c C-d > now inserts just the method name: > > // act > func (m *myStruct) act () {...} > > * lisp/progmodes/go-ts-mode.el (go-ts-mode--defun-name): New optional > parameter SKIP-PREFIX. (go-ts-mode-docstring): > Call (go-ts-mode--defun-name t) instead of (treesit-defun-name). Thanks. Dmitry, Yuan, Randy: any comments? From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Mar 2023 19:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Evgeni Kolev , 62371@debbugs.gnu.org, Yuan Fu , Dmitry Gutov Received: via spool by 62371-submit@debbugs.gnu.org id=B62371.167977305610420 (code B ref 62371); Sat, 25 Mar 2023 19:38:01 +0000 Received: (at 62371) by debbugs.gnu.org; 25 Mar 2023 19:37:36 +0000 Received: from localhost ([127.0.0.1]:43548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9ho-0002i0-Ah for submit@debbugs.gnu.org; Sat, 25 Mar 2023 15:37:36 -0400 Received: from mail-40136.proton.ch ([185.70.40.136]:21385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pg9hl-0002hk-0H for 62371@debbugs.gnu.org; Sat, 25 Mar 2023 15:37:34 -0400 Date: Sat, 25 Mar 2023 19:37:17 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1679773046; x=1680032246; bh=oQ2aiUi6y8KvvKLAnRQ8azRnhhQueu1UEwLt0n0wqAM=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=2iIH58CNayuw3gm7A4UDZ/3Gg7EyLCSalYJS2dGsgyjGTy3Oy1Z3baoTDTGr1NOEr yOLybUDnuy1PPAhVx8tnquWaXJWK+/9V58VwhT0H/9Uh7yYU67A/UUV0b39nQjnyl+ QWViRXCO0PukjkJd6iHwlFz+SgVlNQu1vmSSQY777yLltMcQ1wGrJVXwzGr78kfKyu Iok7kgKAtWJaRPkkRvFuXGhBecdQBt6obF/wJXZhIFBYH17g5vKOhdmhSQMGQ60FVV vJpiUvixYVAqvAWIXtvhEexF1y7YM5RoBQ4R98ORgrlS45Af5GSJQtKE8yHg575x0q GSDt0uAQiGF1A== From: Randy Taylor Message-ID: In-Reply-To: <83o7ohc9eb.fsf@gnu.org> References: <83o7ohc9eb.fsf@gnu.org> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Saturday, March 25th, 2023 at 08:17, Eli Zaretskii wrote: >=20 > > From: Evgeni Kolev evgeni.d.kolev@gmail.com >=20 > > Date: Wed, 22 Mar 2023 10:05:56 +0200 > >=20 > > The docstring inserted with go-ts-mode's C-c C-d was incorrectly > > prefixed with the receiver "(myStruct).": > >=20 > > // (myStruct).act > > func (m *myStruct) act () {...} > >=20 > > The above docstring is not correct because the receiver "myStruct" > > should not be in the docstring. > >=20 > > The issue is caused by imenu and go-ts-mode--defun-name using the same > > code to determine the defun name. Instead, they should produce > > different results - imenu should show the "myStruct" prefix, but the > > docstring should not. > >=20 > > This commit fixes the incorrect behavior by introducing an optional > > SKIP-PREFIX parameter to (go-ts-mode--defun-name). Pressing C-c C-d > > now inserts just the method name: > >=20 > > // act > > func (m *myStruct) act () {...} > >=20 > > * lisp/progmodes/go-ts-mode.el (go-ts-mode--defun-name): New optional > > parameter SKIP-PREFIX. (go-ts-mode-docstring): > > Call (go-ts-mode--defun-name t) instead of (treesit-defun-name). >=20 >=20 > Thanks. >=20 > Dmitry, Yuan, Randy: any comments? I guess my email yesterday didn't make it through or got missed? It looks good to me, feel free to install. From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 01:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii , Evgeni Kolev , Randy Taylor , Yuan Fu Cc: 62371@debbugs.gnu.org Received: via spool by 62371-submit@debbugs.gnu.org id=B62371.167979579715737 (code B ref 62371); Sun, 26 Mar 2023 01:57:02 +0000 Received: (at 62371) by debbugs.gnu.org; 26 Mar 2023 01:56:37 +0000 Received: from localhost ([127.0.0.1]:43715 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgFcb-00045k-95 for submit@debbugs.gnu.org; Sat, 25 Mar 2023 21:56:37 -0400 Received: from mail-wr1-f47.google.com ([209.85.221.47]:36622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgFcY-00045T-LD for 62371@debbugs.gnu.org; Sat, 25 Mar 2023 21:56:35 -0400 Received: by mail-wr1-f47.google.com with SMTP id i9so5316735wrp.3 for <62371@debbugs.gnu.org>; Sat, 25 Mar 2023 18:56:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679795789; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date:message-id:reply-to; bh=nxun73R07nPiYGVzlgTWPwc3i/EQwJ1JYl0QOCxJD9Q=; b=DaUJhDX1qZiOUFYZ8wRrLIKgMuqwaWFNkj3sjLZSM4+p2tC1qCwfj2MaV4+fQN2SZw dWlP0MU6RXgEQStZGht3h9ZnQ69TYMWG5ye6JY0s1m0GOgid+fHfrAlaAV3PnUzCXXtM PZrxddxTdXL7f8S23beVMLD4k16mV3qlnHrLC81NvggJGvLd6x5m6KRpBnmGgvWlvOXi 8CY64gArPdAtnSyBa57SyJICKwAn2wuH2bTfJ0AxY5eDCeIv+HrsgkiwtmpB/jOTUETq 2nzfgpHB+/j6z+B5u5iBFBMcdju6XVnkxC8k/4oMPkVfb+Nb7eSbcXbgSFgLpLWDCvYs cqTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679795789; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nxun73R07nPiYGVzlgTWPwc3i/EQwJ1JYl0QOCxJD9Q=; b=XYYis3geOABtvdzwoENj2MmnOH3As0TWhLkaGk20XLSVLUPRJj66zpxQUNn7FFXcRq s2ca1XlRINu0tMGTtOHOmTGfas9Rys8vSzCC6Ues/9h5NEsSYJA6pRE0Lkcu0wT6FVRf yE6SBgKeVLnIg6JKmFpM8N5Dyk0Wfijq1E+h/fgCWIwIRShH549+yivnojIIVvFQkAae 48dCxbbMLounqzlsKgFjKbpwMqDdaZTxBoCNDz23dSpHPqetLOD+1B7wnPnVW8emK6Q+ wJuaBNzegI9E8zKLNAnFQyKf9MDXnLuKffZyF3mS1Zg4UDh2x4xR6reh6UFFlA4UqLOS FwyA== X-Gm-Message-State: AAQBX9c/Jn70MptDtrx6xNXLolK/UfNZPTEFxKh68P6kFvWKxM2ylYRz hKzuOKcc5KFR1RmcYPWCQQo= X-Google-Smtp-Source: AKy350az47rLIhLf3f1sajmnjcFkFeST/zv0DCf3rEGya72pjQrwfhuh36fRq+0hCFY+l1TZhy9IJw== X-Received: by 2002:a5d:4d11:0:b0:2d2:d324:e44f with SMTP id z17-20020a5d4d11000000b002d2d324e44fmr5660791wrt.16.1679795788391; Sat, 25 Mar 2023 18:56:28 -0700 (PDT) Received: from [192.168.0.2] ([85.132.229.92]) by smtp.googlemail.com with ESMTPSA id c9-20020a5d4cc9000000b002d21379bcabsm21653739wrt.110.2023.03.25.18.56.27 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 25 Mar 2023 18:56:27 -0700 (PDT) Message-ID: <27a58bcf-d74d-efcf-d455-03e44c3d7de6@yandex.ru> Date: Sun, 26 Mar 2023 04:56:25 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Content-Language: en-US References: <83o7ohc9eb.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: <83o7ohc9eb.fsf@gnu.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.9 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.9 (-) On 25/03/2023 14:17, Eli Zaretskii wrote: > Dmitry, Yuan, Randy: any comments? It also looks good to me. The commit message might be a little too verbose, though -- what do you think? From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 04:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: evgeni.d.kolev@gmail.com, Randy Taylor Cc: casouri@gmail.com, 62371@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 62371-submit@debbugs.gnu.org id=B62371.167980525131648 (code B ref 62371); Sun, 26 Mar 2023 04:35:02 +0000 Received: (at 62371) by debbugs.gnu.org; 26 Mar 2023 04:34:11 +0000 Received: from localhost ([127.0.0.1]:43799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgI55-0008EN-5v for submit@debbugs.gnu.org; Sun, 26 Mar 2023 00:34:11 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55952) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgI52-0008E7-Ln for 62371@debbugs.gnu.org; Sun, 26 Mar 2023 00:34:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgI4w-0008VQ-HU; Sun, 26 Mar 2023 00:34:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/XHvvVrKFBoKc7V4yYTASk5imccQcQoFm8sZOEVgdYQ=; b=rjnxBp14LgtP RykaLmT13WrEol+mZVJuf0u7GR6CCWUYQIHpxlA0jM3tD8iiSmWvJnmZT/qsZk8Ne/TrHTeVtQtTA rAgTV9qiqWWRX+fN9qRfeGyn5co6WggyYNNeMRN1/ydHVcZ/ZGZj3QyS/zGQ8hSGcBI+78kEd35Yy mGq+7hvR2pVRrTUYAYC6mPiMvS5E7Nkeg5PJWaeEkyT9A1LOQL9HnQk9rvLTr407Ca8nNi+VhkG38 3xBBXhAEGwbyKjXpKx3rq5vaMhVprjeF9lIZiLZnqeMY+DgEV0HBUzCpg2Izl+0OaKh4P3PvT3tDZ 2dp9wSa0a3y2cWHPjo97Kw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgI4u-00024X-Ku; Sun, 26 Mar 2023 00:34:02 -0400 Date: Sun, 26 Mar 2023 07:34:00 +0300 Message-Id: <838rfkb07b.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Randy Taylor on Sat, 25 Mar 2023 19:37:17 +0000) References: <83o7ohc9eb.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sat, 25 Mar 2023 19:37:17 +0000 > From: Randy Taylor > Cc: Evgeni Kolev , Dmitry Gutov , Yuan Fu , 62371@debbugs.gnu.org > > On Saturday, March 25th, 2023 at 08:17, Eli Zaretskii wrote: > > > > > From: Evgeni Kolev evgeni.d.kolev@gmail.com > > > > > Date: Wed, 22 Mar 2023 10:05:56 +0200 > > > > > > The docstring inserted with go-ts-mode's C-c C-d was incorrectly > > > prefixed with the receiver "(myStruct).": > > > > > > // (myStruct).act > > > func (m *myStruct) act () {...} > > > > > > The above docstring is not correct because the receiver "myStruct" > > > should not be in the docstring. > > > > > > The issue is caused by imenu and go-ts-mode--defun-name using the same > > > code to determine the defun name. Instead, they should produce > > > different results - imenu should show the "myStruct" prefix, but the > > > docstring should not. > > > > > > This commit fixes the incorrect behavior by introducing an optional > > > SKIP-PREFIX parameter to (go-ts-mode--defun-name). Pressing C-c C-d > > > now inserts just the method name: > > > > > > // act > > > func (m *myStruct) act () {...} > > > > > > * lisp/progmodes/go-ts-mode.el (go-ts-mode--defun-name): New optional > > > parameter SKIP-PREFIX. (go-ts-mode-docstring): > > > Call (go-ts-mode--defun-name t) instead of (treesit-defun-name). > > > > > > Thanks. > > > > Dmitry, Yuan, Randy: any comments? > > I guess my email yesterday didn't make it through or got missed? It didn't. But gnu.org had severe DNS problems all day yesterday, so many email messages were delivered with a long delay. I wrote the above before I saw your response. > It looks good to me, feel free to install. I tried, but it failed to apply. Evgeni, could you please resubmit, relative to the emacs-29 branch? From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 05:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov Cc: dev@rjt.dev, evgeni.d.kolev@gmail.com, 62371@debbugs.gnu.org, casouri@gmail.com Received: via spool by 62371-submit@debbugs.gnu.org id=B62371.16798081784823 (code B ref 62371); Sun, 26 Mar 2023 05:23:01 +0000 Received: (at 62371) by debbugs.gnu.org; 26 Mar 2023 05:22:58 +0000 Received: from localhost ([127.0.0.1]:43850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgIqI-0001Fj-I4 for submit@debbugs.gnu.org; Sun, 26 Mar 2023 01:22:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56550) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgIqG-0001FU-V5 for 62371@debbugs.gnu.org; Sun, 26 Mar 2023 01:22:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgIqB-0007wb-Ix; Sun, 26 Mar 2023 01:22:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=PPXP2Ke+KrwWEJFWRxP0jfdPXAoN55AUS55fxtx9b0Y=; b=UHiZMcaEMP5h ZlxWendcFtCxZwW1FKqJQLo/1lKScqqaDQ04nGqBQ4jMFdTgrk4n7CX/KfT8CsW2zJomEALofkzfr LNocncYdhzSB7A5AbAhqBf/GwmMrb4yesgPIdp+kIFwZCEY07V/dcIYx+0Stz1CEqBCE0HOEvdNgA R5zXHmaKCLyaAVNIgwLWRoPDD7Wn/OK9068cvt1s7m/f1g7AnZhst0Cmu8pYXlQ7gP34x08G9cAfB Eo8I7mxmQL9IPPUmNXYt4wop3ZQDgwT0Jw9I06jlxRox/rWrnF5XFL4U3GPQSZsoKaMxjnjRqv49d 1vpEgFSQATJATUMUp1ELDQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgIqA-00009W-Nx; Sun, 26 Mar 2023 01:22:51 -0400 Date: Sun, 26 Mar 2023 08:22:49 +0300 Message-Id: <83y1nk9jdi.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <27a58bcf-d74d-efcf-d455-03e44c3d7de6@yandex.ru> (message from Dmitry Gutov on Sun, 26 Mar 2023 04:56:25 +0300) References: <83o7ohc9eb.fsf@gnu.org> <27a58bcf-d74d-efcf-d455-03e44c3d7de6@yandex.ru> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 26 Mar 2023 04:56:25 +0300 > Cc: 62371@debbugs.gnu.org > From: Dmitry Gutov > > On 25/03/2023 14:17, Eli Zaretskii wrote: > > Dmitry, Yuan, Randy: any comments? > > It also looks good to me. The commit message might be a little too > verbose, though -- what do you think? It could use some editing, yes. From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Randy Taylor Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 26 Mar 2023 11:45:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: evgeni.d.kolev@gmail.com, 62371@debbugs.gnu.org, casouri@gmail.com, dgutov@yandex.ru Received: via spool by 62371-submit@debbugs.gnu.org id=B62371.167983106223730 (code B ref 62371); Sun, 26 Mar 2023 11:45:01 +0000 Received: (at 62371) by debbugs.gnu.org; 26 Mar 2023 11:44:22 +0000 Received: from localhost ([127.0.0.1]:44176 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgOnO-0006Ag-Cz for submit@debbugs.gnu.org; Sun, 26 Mar 2023 07:44:22 -0400 Received: from mail-4323.proton.ch ([185.70.43.23]:59839) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgOnM-0006AQ-A7 for 62371@debbugs.gnu.org; Sun, 26 Mar 2023 07:44:21 -0400 Date: Sun, 26 Mar 2023 11:44:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rjt.dev; s=protonmail3; t=1679831053; x=1680090253; bh=//oIxzRbR82YISVq5e7BVhm9cpDxSOS3XrlAh1dR98U=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector; b=Gd79SoXV2owvUx5rOfVzwf2XaN/5vj+rp+x7OFbUIpsZylXhp2Isoz+rByH7bLDUT vCMCrJ9nJ3JCBO1gD2/3AjGHfEo3gmwz2TjxqAMMRxNdLMlA3ELIn3lg16vA7xnvGP giWEGCwbM+9gDMsZHaNsOExgmQCxKhCzdoTwo7PU22CursMLLYE/qzQINFWAK90Ns3 XRYnFl+R44pN1xz4DMe8pTVYZh5lGoBW9OZLLOS4vU/jH5M3XC0IHLxkn9/bmhqNWw 7WipNuIO8967z8FwPNYynIHWQwqktGfocheiOMECwtv+lWlNPTl7agzyAWEUIqrZh3 B3HNn5TogACtQ== From: Randy Taylor Message-ID: <9M0ZWnOKfTsq_wcsd-YSG8IwTZiVeTX0qroEGvW3kceThXh65Ok1dPpt2gcbaYS6jayromU9F6PdEetzpqht_nDN55fI_HAkrjtQMT0rQgI=@rjt.dev> In-Reply-To: <838rfkb07b.fsf@gnu.org> References: <83o7ohc9eb.fsf@gnu.org> <838rfkb07b.fsf@gnu.org> Feedback-ID: 44397038:user:proton MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sunday, March 26th, 2023 at 00:34, Eli Zaretskii wrote: > > Date: Sat, 25 Mar 2023 19:37:17 +0000 >=20 > > From: Randy Taylor dev@rjt.dev > > Cc: Evgeni Kolev evgeni.d.kolev@gmail.com, Dmitry Gutov dgutov@yandex.r= u, Yuan Fu casouri@gmail.com, 62371@debbugs.gnu.org > >=20 > > On Saturday, March 25th, 2023 at 08:17, Eli Zaretskii eliz@gnu.org wrot= e: > >=20 > > > > From: Evgeni Kolev evgeni.d.kolev@gmail.com > > >=20 > > > > Date: Wed, 22 Mar 2023 10:05:56 +0200 > > > >=20 > > > > The docstring inserted with go-ts-mode's C-c C-d was incorrectly > > > > prefixed with the receiver "(myStruct).": > > > >=20 > > > > // (myStruct).act > > > > func (m *myStruct) act () {...} > > > >=20 > > > > The above docstring is not correct because the receiver "myStruct" > > > > should not be in the docstring. > > > >=20 > > > > The issue is caused by imenu and go-ts-mode--defun-name using the s= ame > > > > code to determine the defun name. Instead, they should produce > > > > different results - imenu should show the "myStruct" prefix, but th= e > > > > docstring should not. > > > >=20 > > > > This commit fixes the incorrect behavior by introducing an optional > > > > SKIP-PREFIX parameter to (go-ts-mode--defun-name). Pressing C-c C-d > > > > now inserts just the method name: > > > >=20 > > > > // act > > > > func (m *myStruct) act () {...} > > > >=20 > > > > * lisp/progmodes/go-ts-mode.el (go-ts-mode--defun-name): New option= al > > > > parameter SKIP-PREFIX. (go-ts-mode-docstring): > > > > Call (go-ts-mode--defun-name t) instead of (treesit-defun-name). > > >=20 > > > Thanks. > > >=20 > > > Dmitry, Yuan, Randy: any comments? > >=20 > > I guess my email yesterday didn't make it through or got missed? >=20 >=20 > It didn't. But gnu.org had severe DNS problems all day yesterday, so > many email messages were delivered with a long delay. I wrote the > above before I saw your response. >=20 > > It looks good to me, feel free to install. >=20 >=20 > I tried, but it failed to apply. Evgeni, could you please resubmit, > relative to the emacs-29 branch? It's for master, this feature didn't make it in to emacs-29. From unknown Sat Jun 21 05:17:39 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Evgeni Kolev Subject: bug#62371: closed (Re: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods) Message-ID: References: <83r0tbafab.fsf@gnu.org> X-Gnu-PR-Message: they-closed 62371 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 62371@debbugs.gnu.org Date: Sun, 26 Mar 2023 12:06:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1679832362-26717-1" This is a multi-part message in MIME format... ------------=_1679832362-26717-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 62371@debbugs.gnu.org. --=20 62371: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D62371 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1679832362-26717-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 62371-done) by debbugs.gnu.org; 26 Mar 2023 12:05:58 +0000 Received: from localhost ([127.0.0.1]:44207 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgP8H-0006wf-TS for submit@debbugs.gnu.org; Sun, 26 Mar 2023 08:05:58 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgP8F-0006wR-CP for 62371-done@debbugs.gnu.org; Sun, 26 Mar 2023 08:05:56 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgP89-0005S1-ET; Sun, 26 Mar 2023 08:05:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=rs/y76Xoqf6rLOMuhDuiKVtA05JjPYFu4l0tjEGBOU0=; b=Cp1tpqVTIsja 9pI1bRoteq/kD3lRaro6hl5U23Kjes45y4CowfSVljlNTo743j7tMmt7uVNtwFRelJH+2vLb1Vm1K DuPTNHZpr3xrENkWK3yk7W8pWIxyq3KMhA9m6857eUj5Tm6A0NFvJjqgzWGY+zqZekUrvapke93vk qajr99DuyyobX/N0amU8LPMbI4heqR4V+vscY71beLpV9fetCxmtVVU9i7+72MJwbmCYwkSulqBJe pj9KoKpFSaYfDUINxucUl1SBebAAbG5IH9DSqz8kVu8UMrxfCUy9wAnQehfIDuJaj68Z3vEobToKd RueOj76kASLuKwjU8mFH1w==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pgP88-0005EE-SF; Sun, 26 Mar 2023 08:05:49 -0400 Date: Sun, 26 Mar 2023 15:05:48 +0300 Message-Id: <83r0tbafab.fsf@gnu.org> From: Eli Zaretskii To: Randy Taylor In-Reply-To: <9M0ZWnOKfTsq_wcsd-YSG8IwTZiVeTX0qroEGvW3kceThXh65Ok1dPpt2gcbaYS6jayromU9F6PdEetzpqht_nDN55fI_HAkrjtQMT0rQgI=@rjt.dev> (message from Randy Taylor on Sun, 26 Mar 2023 11:44:05 +0000) Subject: Re: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods References: <83o7ohc9eb.fsf@gnu.org> <838rfkb07b.fsf@gnu.org> <9M0ZWnOKfTsq_wcsd-YSG8IwTZiVeTX0qroEGvW3kceThXh65Ok1dPpt2gcbaYS6jayromU9F6PdEetzpqht_nDN55fI_HAkrjtQMT0rQgI=@rjt.dev> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 62371-done Cc: evgeni.d.kolev@gmail.com, 62371-done@debbugs.gnu.org, casouri@gmail.com, dgutov@yandex.ru X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Sun, 26 Mar 2023 11:44:05 +0000 > From: Randy Taylor > Cc: evgeni.d.kolev@gmail.com, dgutov@yandex.ru, casouri@gmail.com, 62371@debbugs.gnu.org > > > > It looks good to me, feel free to install. > > > > > > I tried, but it failed to apply. Evgeni, could you please resubmit, > > relative to the emacs-29 branch? > > It's for master, this feature didn't make it in to emacs-29. Thanks, now installed on master, and closing the bug. ------------=_1679832362-26717-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 22 Mar 2023 08:06:28 +0000 Received: from localhost ([127.0.0.1]:33395 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1petUK-0004i6-6q for submit@debbugs.gnu.org; Wed, 22 Mar 2023 04:06:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:33162) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1petUJ-0004hz-4l for submit@debbugs.gnu.org; Wed, 22 Mar 2023 04:06:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1petUI-0001hr-Sg for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 04:06:26 -0400 Received: from mail-qv1-xf2c.google.com ([2607:f8b0:4864:20::f2c]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1petUH-0001Pg-Br for bug-gnu-emacs@gnu.org; Wed, 22 Mar 2023 04:06:26 -0400 Received: by mail-qv1-xf2c.google.com with SMTP id m16so4307924qvi.12 for ; Wed, 22 Mar 2023 01:06:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679472382; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date:message-id:reply-to; bh=y398oMGCW8sUIWthLPt7QbY+PIXBtiqTCSkM+5EZVek=; b=VRjcLXuAm4SXVRpQhG+NxjCy+pi688TwEiyAiQIywVf7un0DG89lzboUuXWwcwnBjj Nnqd7U2Rs9OuxHlv8xgkoNB46axe7VKp5eb76uPIzIjJG1H3tlb15AHmy6OGjgeHN8WI itAMNWP+xyBFP7d/sOCou0Ni2rq7oVFKIShVy3WV9UX0BopwRUvSHzRcW0M8J9Pev7mb 7MNOcCc+0hplKLWoM1oyRMzUGxGg6ziECnvIxNUeKQam/qWXGyj/4phMa501zzHAckZU BRnobIdof+4ztiW2cCHbn5bJGXq7BTy2HPc60R2rYxLtX2BzitBRZByaCiGfAof/je7r HeoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679472382; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=y398oMGCW8sUIWthLPt7QbY+PIXBtiqTCSkM+5EZVek=; b=w/QoiX15fYcaLRWTAHf1+bShPF7LFk2JnBOYZTxvKBdfCxDnQDgRHm0yHrdrVJmLRR OVymRXocwCOq43D+Cuj81TZ8DuaHnflI5rmAo9nP8uN475syigzVpgN9GWY9GyeiB8dM /lJKHQzXN5wkRJc8Bp+jtzDAtAUDqQTHXyU/0xrlfx0exbJ422ozYnOJQev9ZCs//m0r ZDWtbOfHyXdGaBAnvGQIykvOskSdRiytFyI/zG4WDSXi9LgEDxumP02ToT6CZ+6S04lR t2+kwExGSJa+nwQs6Ffz6/Uh5iuAUbI0OOEAOEQCBGW3hdwl/XdVSUavGF8j3ThXUqSX 0iCQ== X-Gm-Message-State: AO0yUKVkZ9SfyKfNk6n5YHarXW/QN9ueADZgQW1rXlH6enM/7tOFdGj/ VKLDDB1RPKT6s4JkOnPraKf4WfmKVgbkeUDWA6zSfqjg8Kv0Fzd7 X-Google-Smtp-Source: AK7set8jO9ucXesuKy3OTz/vCMA/KlCp2FNo7vI3n296KTbVM2fHmKVM6Zso6dpZAfV1CJWMaRRXHV8mNR2CGzoag9s= X-Received: by 2002:ad4:4f25:0:b0:56f:fe44:f257 with SMTP id fc5-20020ad44f25000000b0056ffe44f257mr562556qvb.1.1679472382453; Wed, 22 Mar 2023 01:06:22 -0700 (PDT) MIME-Version: 1.0 From: Evgeni Kolev Date: Wed, 22 Mar 2023 10:05:56 +0200 Message-ID: Subject: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000c4826c05f778a2f0" Received-SPF: pass client-ip=2607:f8b0:4864:20::f2c; envelope-from=evgenysw@gmail.com; helo=mail-qv1-xf2c.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000c4826c05f778a2f0 Content-Type: text/plain; charset="UTF-8" The docstring inserted with go-ts-mode's C-c C-d was incorrectly prefixed with the receiver "(myStruct).": // (myStruct).act func (m *myStruct) act () {...} The above docstring is not correct because the receiver "myStruct" should not be in the docstring. The issue is caused by imenu and go-ts-mode--defun-name using the same code to determine the defun name. Instead, they should produce different results - imenu should show the "myStruct" prefix, but the docstring should not. This commit fixes the incorrect behavior by introducing an optional SKIP-PREFIX parameter to (go-ts-mode--defun-name). Pressing C-c C-d now inserts just the method name: // act func (m *myStruct) act () {...} * lisp/progmodes/go-ts-mode.el (go-ts-mode--defun-name): New optional parameter SKIP-PREFIX. (go-ts-mode-docstring): Call (go-ts-mode--defun-name t) instead of (treesit-defun-name). --000000000000c4826c05f778a2f0 Content-Type: application/octet-stream; name="0001-Fix-go-ts-mode-incorrect-docstring-inserted-for-meth.patch" Content-Disposition: attachment; filename="0001-Fix-go-ts-mode-incorrect-docstring-inserted-for-meth.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_lfjeg3u30 RnJvbSA0M2VjMDg0MTI4NjgwOTk3MzViMjI5ZTRhZWZmNWViMjc2YzRmMDgyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFdmdlbmkgS29sZXYgPGV2Z2VueXN3QGdtYWlsLmNvbT4KRGF0 ZTogV2VkLCA4IEZlYiAyMDIzIDE3OjE2OjAyICswMjAwClN1YmplY3Q6IFtQQVRDSF0gRml4IGdv LXRzLW1vZGUgaW5jb3JyZWN0IGRvY3N0cmluZyBpbnNlcnRlZCBmb3IgbWV0aG9kcwoKVGhlIGRv Y3N0cmluZyBpbnNlcnRlZCB3aXRoIGdvLXRzLW1vZGUncyBDLWMgQy1kIHdhcyBpbmNvcnJlY3Rs eQpwcmVmaXhlZCB3aXRoIHRoZSByZWNlaXZlciAiKG15U3RydWN0KS4iOgoKICAgIC8vIChteVN0 cnVjdCkuYWN0CiAgICBmdW5jIChtICpteVN0cnVjdCkgYWN0ICgpIHsuLi59CgpUaGUgYWJvdmUg ZG9jc3RyaW5nIGlzIG5vdCBjb3JyZWN0IGJlY2F1c2UgdGhlIHJlY2VpdmVyICJteVN0cnVjdCIK c2hvdWxkIG5vdCBiZSBpbiB0aGUgZG9jc3RyaW5nLgoKVGhlIGlzc3VlIGlzIGNhdXNlZCBieSBp bWVudSBhbmQgZ28tdHMtbW9kZS0tZGVmdW4tbmFtZSB1c2luZyB0aGUgc2FtZQpjb2RlIHRvIGRl dGVybWluZSB0aGUgZGVmdW4gbmFtZS4gSW5zdGVhZCwgdGhleSBzaG91bGQgcHJvZHVjZQpkaWZm ZXJlbnQgcmVzdWx0cyAtIGltZW51IHNob3VsZCBzaG93IHRoZSAibXlTdHJ1Y3QiIHByZWZpeCwg YnV0IHRoZQpkb2NzdHJpbmcgc2hvdWxkIG5vdC4KClRoaXMgY29tbWl0IGZpeGVzIHRoZSBpbmNv cnJlY3QgYmVoYXZpb3IgYnkgaW50cm9kdWNpbmcgYW4gb3B0aW9uYWwKU0tJUC1QUkVGSVggcGFy YW1ldGVyIHRvIChnby10cy1tb2RlLS1kZWZ1bi1uYW1lKS4gUHJlc3NpbmcgQy1jIEMtZApub3cg aW5zZXJ0cyBqdXN0IHRoZSBtZXRob2QgbmFtZToKCiAgICAvLyBhY3QKICAgIGZ1bmMgKG0gKm15 U3RydWN0KSBhY3QgKCkgey4uLn0KCiogbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbCAoZ28t dHMtbW9kZS0tZGVmdW4tbmFtZSk6IE5ldyBvcHRpb25hbApwYXJhbWV0ZXIgU0tJUC1QUkVGSVgu IChnby10cy1tb2RlLWRvY3N0cmluZyk6CkNhbGwgKGdvLXRzLW1vZGUtLWRlZnVuLW5hbWUgdCkg aW5zdGVhZCBvZiAodHJlZXNpdC1kZWZ1bi1uYW1lKS4KLS0tCiBsaXNwL3Byb2dtb2Rlcy9nby10 cy1tb2RlLmVsIHwgMTYgKysrKysrKystLS0tLS0tLQogMSBmaWxlIGNoYW5nZWQsIDggaW5zZXJ0 aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9nby10 cy1tb2RlLmVsIGIvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbAppbmRleCBlNmU4YWJkNjQ0 NS4uZmRhNmEzNmU0MmQgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2dvLXRzLW1vZGUuZWwK KysrIGIvbGlzcC9wcm9nbW9kZXMvZ28tdHMtbW9kZS5lbApAQCAtMjU1LDkgKzI1NSwxMCBAQCBn by10cy1tb2RlCiAoaWYgKHRyZWVzaXQtcmVhZHktcCAnZ28pCiAgICAgKGFkZC10by1saXN0ICdh dXRvLW1vZGUtYWxpc3QgJygiXFwuZ29cXCciIC4gZ28tdHMtbW9kZSkpKQogCi0oZGVmdW4gZ28t dHMtbW9kZS0tZGVmdW4tbmFtZSAobm9kZSkKKyhkZWZ1biBnby10cy1tb2RlLS1kZWZ1bi1uYW1l IChub2RlICZvcHRpb25hbCBza2lwLXByZWZpeCkKICAgIlJldHVybiB0aGUgZGVmdW4gbmFtZSBv ZiBOT0RFLgotUmV0dXJuIG5pbCBpZiB0aGVyZSBpcyBubyBuYW1lIG9yIGlmIE5PREUgaXMgbm90 IGEgZGVmdW4gbm9kZS4iCitSZXR1cm4gbmlsIGlmIHRoZXJlIGlzIG5vIG5hbWUgb3IgaWYgTk9E RSBpcyBub3QgYSBkZWZ1biBub2RlLgorTWV0aG9kcyBhcmUgcHJlZml4ZWQgd2l0aCB0aGUgcmVj ZWl2ZXIgbmFtZSwgdW5sZXNzIFNLSVAtUFJFRklYIGlzIHQuIgogICAocGNhc2UgKHRyZWVzaXQt bm9kZS10eXBlIG5vZGUpCiAgICAgKCJmdW5jdGlvbl9kZWNsYXJhdGlvbiIKICAgICAgKHRyZWVz aXQtbm9kZS10ZXh0CkBAIC0yNjYsMTEgKzI2NywxMCBAQCBnby10cy1tb2RlLS1kZWZ1bi1uYW1l CiAgICAgICB0KSkKICAgICAoIm1ldGhvZF9kZWNsYXJhdGlvbiIKICAgICAgKGxldCogKChyZWNl aXZlci1ub2RlICh0cmVlc2l0LW5vZGUtY2hpbGQtYnktZmllbGQtbmFtZSBub2RlICJyZWNlaXZl ciIpKQotICAgICAgICAgICAgKHR5cGUtbm9kZSAodHJlZXNpdC1zZWFyY2gtc3VidHJlZSByZWNl aXZlci1ub2RlICJ0eXBlX2lkZW50aWZpZXIiKSkKLSAgICAgICAgICAgIChuYW1lLW5vZGUgKHRy ZWVzaXQtbm9kZS1jaGlsZC1ieS1maWVsZC1uYW1lIG5vZGUgIm5hbWUiKSkpCi0gICAgICAgKGNv bmNhdAotICAgICAgICAiKCIgKHRyZWVzaXQtbm9kZS10ZXh0IHR5cGUtbm9kZSkgIikuIgotICAg ICAgICAodHJlZXNpdC1ub2RlLXRleHQgbmFtZS1ub2RlKSkpKQorICAgICAgICAgICAgKHJlY2Vp dmVyICh0cmVlc2l0LW5vZGUtdGV4dCAodHJlZXNpdC1zZWFyY2gtc3VidHJlZSByZWNlaXZlci1u b2RlICJ0eXBlX2lkZW50aWZpZXIiKSkpCisgICAgICAgICAgICAobWV0aG9kICh0cmVlc2l0LW5v ZGUtdGV4dCAodHJlZXNpdC1ub2RlLWNoaWxkLWJ5LWZpZWxkLW5hbWUgbm9kZSAibmFtZSIpKSkp CisgICAgICAgKGlmIHNraXAtcHJlZml4IG1ldGhvZAorICAgICAgICAgKGNvbmNhdCAiKCIgcmVj ZWl2ZXIgIikuIiBtZXRob2QpKSkpCiAgICAgKCJ0eXBlX2RlY2xhcmF0aW9uIgogICAgICAodHJl ZXNpdC1ub2RlLXRleHQKICAgICAgICh0cmVlc2l0LW5vZGUtY2hpbGQtYnktZmllbGQtbmFtZQpA QCAtMzE0LDcgKzMxNCw3IEBAIGdvLXRzLW1vZGUtZG9jc3RyaW5nCiAgICAgICAgIDs7IGdvIHRv IHRvcCBjb21tZW50IGxpbmUKICAgICAgICAgKHdoaWxlIChnby10cy1tb2RlLS1jb21tZW50LW9u LXByZXZpb3VzLWxpbmUtcCkKICAgICAgICAgICAoZm9yd2FyZC1saW5lIC0xKSkKLSAgICAgIChp bnNlcnQgIi8vICIgKHRyZWVzaXQtZGVmdW4tbmFtZSBkZWZ1bi1ub2RlKSkKKyAgICAgIChpbnNl cnQgIi8vICIgKGdvLXRzLW1vZGUtLWRlZnVuLW5hbWUgZGVmdW4tbm9kZSB0KSkKICAgICAgIChu ZXdsaW5lKQogICAgICAgKGJhY2t3YXJkLWNoYXIpKSkpCiAKLS0gCjIuMzkuMQoK --000000000000c4826c05f778a2f0-- ------------=_1679832362-26717-1-- From unknown Sat Jun 21 05:17:39 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62371: [PATCH] Fix go-ts-mode incorrect docstring inserted for methods Resent-From: Evgeni Kolev Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 27 Mar 2023 10:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62371 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Randy Taylor , casouri@gmail.com, 62371-done@debbugs.gnu.org, dgutov@yandex.ru Received: via spool by 62371-done@debbugs.gnu.org id=D62371.167991150222924 (code D ref 62371); Mon, 27 Mar 2023 10:06:01 +0000 Received: (at 62371-done) by debbugs.gnu.org; 27 Mar 2023 10:05:02 +0000 Received: from localhost ([127.0.0.1]:46582 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgjio-0005xg-09 for submit@debbugs.gnu.org; Mon, 27 Mar 2023 06:05:02 -0400 Received: from mail-qt1-f174.google.com ([209.85.160.174]:44734) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pgjil-0005x3-RO for 62371-done@debbugs.gnu.org; Mon, 27 Mar 2023 06:05:00 -0400 Received: by mail-qt1-f174.google.com with SMTP id s12so4375354qtx.11 for <62371-done@debbugs.gnu.org>; Mon, 27 Mar 2023 03:04:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679911494; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eiRz4lqZ4wqQVwIM6aO2wOVtz517anVey94bK765U/w=; b=mYtR4xNJ8CK7OlGX6waIYsd2TaoV+cyqV6JLwbBZShkSly7AOJVPJil2M5I5/1lbwV wvFYuAjJpxV9wvbm1Z6v2fh8sM5R0EvUwZHYtn7QjLprSAxbkc+Scmftv5nvrHfM+w7S 4IeesMQef6bm4or5hzXQCeEAnZBSegccoaWiYfPsF2G4qfuW+zhjfsLOgbXklsKIga6F 2F9/UufR4dHq3dgKI3PhkRkEkQnWZQQqKFfwTn+wgm5zuyJXqMMHVlSUbZgO6sd+L0/F ar4lWYP5wIhNjd09d0Km25AO+nfuig5g1RnCLcveWgC97bazUjbVJmny1wHRdIIqi+4A qY3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679911494; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eiRz4lqZ4wqQVwIM6aO2wOVtz517anVey94bK765U/w=; b=NwemjNmJiRfn5lurWsXH/xvJcn8CIBz0Qg6oHgl0NaEqw0bLJJuaw2tgzEM+pCA36I emspuAGBEIQib+6TrAR+ggJ+QijdHoQHI+tZoxWYDIVDweOish9dLv4q4DZj7qtHlSzT TKeLA0PWFhmVcCiBOHBtJ5u9syAxyYkl//XdM1U8kxdzCMQImkg8YKodkdo2g2+pFzFx Juzq6mxeqVbEEOIeHFkXTcmBDwzSPtNFK3q6Izny5bSDXq6Dk2KBUBEF2s3aS1Shd1bl 1mdBR9UtD8c3gbVGCKuD53X0/7LgpoVTE4P8CTp9IozGk+yZO9WFVaEmeelokSYxCCm3 0DAA== X-Gm-Message-State: AO0yUKXW2KSuSYCW6PeO/fsEN4tss3uSy1g1YAiDZaFPqkbdLw2eD9kB CVLIG4VfyZBAPT1UqK2EA4Yj7KC7yVut0utYGfY= X-Google-Smtp-Source: AK7set+5JZRMyxHj0In6rgxUtz/AA5Dv4UcggGDZD5kwqjK8OYOKa5NNFAAeqbypNxR8QuFpjyTck6fAQdd9u0CijCA= X-Received: by 2002:ac8:5702:0:b0:3e3:93ae:d118 with SMTP id 2-20020ac85702000000b003e393aed118mr4217528qtw.12.1679911493959; Mon, 27 Mar 2023 03:04:53 -0700 (PDT) MIME-Version: 1.0 References: <83o7ohc9eb.fsf@gnu.org> <838rfkb07b.fsf@gnu.org> <9M0ZWnOKfTsq_wcsd-YSG8IwTZiVeTX0qroEGvW3kceThXh65Ok1dPpt2gcbaYS6jayromU9F6PdEetzpqht_nDN55fI_HAkrjtQMT0rQgI=@rjt.dev> <83r0tbafab.fsf@gnu.org> In-Reply-To: <83r0tbafab.fsf@gnu.org> From: Evgeni Kolev Date: Mon, 27 Mar 2023 13:04:28 +0300 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Thank you Eli, and everyone else! The patch was meant for master, not emacs-29 - I should have stated this. I also incorrectly sent the patch from my alternate mail address, but the email in the patch was correct, so no harm done. Thanks again! On Sun, Mar 26, 2023 at 3:05=E2=80=AFPM Eli Zaretskii wrote: > > > Date: Sun, 26 Mar 2023 11:44:05 +0000 > > From: Randy Taylor > > Cc: evgeni.d.kolev@gmail.com, dgutov@yandex.ru, casouri@gmail.com, 6237= 1@debbugs.gnu.org > > > > > > It looks good to me, feel free to install. > > > > > > > > > I tried, but it failed to apply. Evgeni, could you please resubmit, > > > relative to the emacs-29 branch? > > > > It's for master, this feature didn't make it in to emacs-29. > > Thanks, now installed on master, and closing the bug.