GNU bug report logs - #62370
28.1; sieve-mode: faces should inherit from font-lock-X-face faces

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: "Trent W. Buck" <trentbuck <at> gmail.com>
Subject: bug#62370: closed (Re: bug#62370: 28.1; sieve-mode: faces should
 inherit from font-lock-X-face faces)
Date: Tue, 05 Sep 2023 04:44:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 62370 <at> debbugs.gnu.org.

-- 
62370: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62370
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jim Porter <jporterbugs <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: "Trent W. Buck" <trentbuck <at> gmail.com>,
 Philip Kaludercic <philipk <at> posteo.net>, gregory <at> heytings.org,
 Eli Zaretskii <eliz <at> gnu.org>, 62370-done <at> debbugs.gnu.org
Subject: Re: bug#62370: 28.1; sieve-mode: faces should inherit from
 font-lock-X-face faces
Date: Mon, 4 Sep 2023 21:43:25 -0700

On 9/3/2023 3:30 AM, Stefan Kangas wrote:
> Jim Porter <jporterbugs <at> gmail.com> writes:
> 
>> I agree that we shouldn't be changing defaults arbitrarily, but as I found when
>> looking at the face definitions, we could make this change in a way where it
>> just simplifies the job for theme authors but doesn't cause a noticeable change
>> in most cases.
>>
>> Does that sound ok? If not, then I think we can just close this.
> 
> I think the solution that you proposed makes sense: it wouldn't break
> anything, and it would make sieve-mode look better for many users.

I tried my proposal out just to be safe and it does actually change the 
appearance in a few cases with the default theme, but I think it's for 
the better:

1. If you're using a color TTY, sieve-mode picks some very simple colors 
("blue", "magenta", and "cyan"). Normally that's fine, since it uses 
whatever your terminal's color palette uses for those basic ANSI colors. 
However, if you have a terminal that can display 24-bit colors, sieve's 
choices become really bad: it's no longer "the blue you've configured 
for your terminal theme that looks nice", but just regular blue 
(#0000ee), which on my terminal is almost unreadable.

2. The font-lock faces also feature slight tweaks to their colors when 
your system supports at least 88 colors. This is only really noticeable 
if you look closely though.

As such, I've pushed this to the master branch as f08684ab39d. Closing 
this now. (Of course, if this *does* cause some problems, we can revisit 
this.)

[Message part 3 (message/rfc822, inline)]

From: "Trent W. Buck" <trentbuck <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces
Date: Wed, 22 Mar 2023 16:41:07 +1100

[Message part 4 (text/plain, inline)]

sieve-mode as at Emacs 28.1 defines its colors ab initio.
This means they have to be themed by hand.
I think sieve-mode should inherit from font-lock-*-face,
as most other things do.

Here is a quick-and-dirty version I knocked out for personal use:

    (custom-set-faces
     '(sieve-control-commands ((t :inherit font-lock-builtin-face)))
     '(sieve-action-commands  ((t :inherit font-lock-function-name-face)))
     '(sieve-test-commands    ((t :inherit font-lock-variable-name-face)))
     '(sieve-tagged-arguments ((t :inherit font-lock-type-face))))

[Screenshot from 2023-03-22 16-23-48.png (image/png, attachment)]

[Screenshot from 2023-03-22 16-40-15.png (image/png, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.