GNU bug report logs - #62370
28.1; sieve-mode: faces should inherit from font-lock-X-face faces

Previous Next

Package: emacs;

Reported by: "Trent W. Buck" <trentbuck <at> gmail.com>

Date: Wed, 22 Mar 2023 05:42:01 UTC

Severity: normal

Found in version 28.1

Done: Jim Porter <jporterbugs <at> gmail.com>

Bug is archived. No further changes may be made.

Full log


Message #39 received at 62370 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: "Trent W. Buck" <trentbuck <at> gmail.com>, Jim Porter <jporterbugs <at> gmail.com>,
 Eli Zaretskii <eliz <at> gnu.org>, gregory <at> heytings.org, 62370 <at> debbugs.gnu.org
Subject: Re: bug#62370: 28.1; sieve-mode: faces should inherit from
 font-lock-X-face faces
Date: Sun, 03 Sep 2023 11:04:25 +0000
Stefan Kangas <stefankangas <at> gmail.com> writes:

> Jim Porter <jporterbugs <at> gmail.com> writes:
>
>> I agree that we shouldn't be changing defaults arbitrarily, but as I found when
>> looking at the face definitions, we could make this change in a way where it
>> just simplifies the job for theme authors but doesn't cause a noticeable change
>> in most cases.
>>
>> Does that sound ok? If not, then I think we can just close this.
>
> I think the solution that you proposed makes sense: it wouldn't break
> anything, and it would make sieve-mode look better for many users.
>
> ISTR that Philip was planning to look into improving our face
> definitions, so I'm putting him in Cc in case he has any comments.

It is true that I have been looking into proposing more "semantic"
faces for faces.el, but I don't have any comments on this proposal.




This bug report was last modified 1 year and 257 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.