GNU bug report logs - #62370
28.1; sieve-mode: faces should inherit from font-lock-X-face faces

Previous Next

Full log

View this message in rfc822 format

From: Gregory Heytings <gregory <at> heytings.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: "Trent W. Buck" <trentbuck <at> gmail.com>, 62370 <at> debbugs.gnu.org
Subject: bug#62370: 28.1; sieve-mode: faces should inherit from font-lock-X-face faces
Date: Wed, 22 Mar 2023 20:10:37 +0000

>> I think sieve-mode should inherit from font-lock-*-face, as most other 
>> things do.
>
> I'm not sure I agree.  These faces are with us for a long time, so 
> changing their defaults now brings disadvantages: it could cause someone 
> dislike the result.
>
> Does anyone else have an opinion about this?
>

I agree with both Trent and you.

Modes should inherit from font-lock-*-faces, unless there's a good reason 
not to inherit from these faces.  Otherwise customizing the visual 
appearance of Emacs is a nightmare.  This is, by the way, made clear in 
(elisp)Major Mode Conventions: "Each face that the mode defines should, if 
possible, inherit from an existing Emacs face.  See Basic Faces, and see 
Faces for Font Lock."

But the sieve-* faces have existed for twenty years, so it's now too late 
to change them.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.