GNU bug report logs - #62365
'guix style' sometimes makes poor indentation choices

Previous Next

Full log

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: bug-guix <bug-guix <at> gnu.org>
Subject: 'guix style' sometimes makes poor indentation choices
Date: Tue, 21 Mar 2023 22:06:24 -0400

Hi,

Looking at #61263, there's an example of some indentation choice gone
wrong:

--8<---------------cut here---------------start------------->8---
@@ -705,59 +705,63 @@ (define-public dbacl
   (package
     (name "dbacl")
     (version "1.14.1")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (string-append "mirror://sourceforge/dbacl/dbacl/" version "/"
-                           "dbacl-" version ".tar.gz"))
-       (sha256
-        (base32 "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz"))
-       (patches (search-patches "dbacl-include-locale.h.patch"))))
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "mirror://sourceforge/dbacl/dbacl/"
+                                  version
+                                  "/"
+                                  "dbacl-"
+                                  version
+                                  ".tar.gz"))
+              (sha256
+               (base32
+                "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz"))
+              (patches (search-patches "dbacl-include-locale.h.patch"
+                        "dbacl-icheck-multiple-definitions.patch"))))
     (build-system gnu-build-system)
     (arguments
--8<---------------cut here---------------end--------------->8---

The original was superior, at least for the URI part, which is now
overly broken into multiple lines, not making good use of the available
80 characters of width available.

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.