From unknown Fri Jun 13 10:46:26 2025 X-Loop: help-debbugs@gnu.org Subject: bug#62365: 'guix style' sometimes makes poor indentation choices Resent-From: Maxim Cournoyer Original-Sender: "Debbugs-submit" Resent-CC: bug-guix@gnu.org Resent-Date: Wed, 22 Mar 2023 02:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 62365 X-GNU-PR-Package: guix X-GNU-PR-Keywords: To: 62365@debbugs.gnu.org X-Debbugs-Original-To: bug-guix Received: via spool by submit@debbugs.gnu.org id=B.167945079127098 (code B ref -1); Wed, 22 Mar 2023 02:07:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Mar 2023 02:06:31 +0000 Received: from localhost ([127.0.0.1]:33070 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1penrz-000730-4L for submit@debbugs.gnu.org; Tue, 21 Mar 2023 22:06:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:41218) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1penrx-00072s-UA for submit@debbugs.gnu.org; Tue, 21 Mar 2023 22:06:30 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1penrx-0000YN-NS for bug-guix@gnu.org; Tue, 21 Mar 2023 22:06:29 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1penrw-0001Ig-8I for bug-guix@gnu.org; Tue, 21 Mar 2023 22:06:29 -0400 Received: by mail-qt1-x82f.google.com with SMTP id x1so21079268qtr.7 for ; Tue, 21 Mar 2023 19:06:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1679450786; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date:message-id:reply-to; bh=0aDMD5L9W+ypoOZNPXraKaI89JCKTcvLp7cYkyLFieo=; b=B1piFL5Y1Ju/dAcbUyEqHDDU7f/ZPwKxQ/ynn2mVJOuuu438fkmclGod/fI78tPtlg wIxmr6cUC6wjeX2VCQ0T2CAVG8J04H1/1doIn6Gv3nXhssTlfWsXBBsBKwSKGGH68ts/ rGrLm/+3Ms3LYSf+voFsd+DOTLzeES9te/MVZJcmmqaRjzHUzgQnc0NVtCnssrPWh0gT PrT1kjC+UXfRjJfNi/Q9f058QuhCncET6Au3y+rAZ7G8XmpFVDIhwlXaWiz85d+glkof s1FsiojysKUnSLqIcB8SrU8GnZfthoOz9vu41Dl8TrngmLhdcUT02faS7PNAmQIfZFUa r77g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679450786; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=0aDMD5L9W+ypoOZNPXraKaI89JCKTcvLp7cYkyLFieo=; b=vRuAhf1Y2fEii0Ic2Z1XweNmx4N+EHDAo8IVwhiW393FZo56jOpmGm52V8yqrI3AON ZAzKVnhMJDH27Ge7zmfILfV/ax3+Y9KrAXAc/YkYtdpxIsr89n20GIvOWmsMqAyBJkzH 76WPoQq4Ht0HB67UFlnczMYXl1NseBQw2n9quNjS5JGu0xtc7KdUca5Uucia8zGI78AN cwFCqKiOe4qiRF+CoT/PF+XNKb9FnOkcX/BLJnzmDQeZNa6519g3PIS0hboUYsu2w8UE dbE/zP/DOSbEoHFR7Qjj+wmsJsumppttcn2xV7SqCEwkVA99PAukxVnAcvoctoGA2P36 /fGQ== X-Gm-Message-State: AO0yUKVZtFS3CkADEMIpEOPgXbby1hyNGbfSNYstqqAKOa4TrmCkf3Dy vW3lOCkWmPLygjptrEirTQhVWFkW3pIm2g== X-Google-Smtp-Source: AK7set+zPH/TLepFckPLJCTATbjHWj7WVEPGoeKnKAutmY3aaTCu8s1U2LC2xZwnklrpE2V/LLqmpQ== X-Received: by 2002:a05:622a:1445:b0:3bd:6c0:9c8e with SMTP id v5-20020a05622a144500b003bd06c09c8emr1033401qtx.2.1679450786205; Tue, 21 Mar 2023 19:06:26 -0700 (PDT) Received: from hurd (dsl-10-130-195.b2b2c.ca. [72.10.130.195]) by smtp.gmail.com with ESMTPSA id s10-20020a05620a16aa00b0074341cb30d0sm10339090qkj.62.2023.03.21.19.06.25 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 21 Mar 2023 19:06:25 -0700 (PDT) From: Maxim Cournoyer Date: Tue, 21 Mar 2023 22:06:24 -0400 Message-ID: <87wn39ilpb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2607:f8b0:4864:20::82f; envelope-from=maxim.cournoyer@gmail.com; helo=mail-qt1-x82f.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi, Looking at #61263, there's an example of some indentation choice gone wrong: --8<---------------cut here---------------start------------->8--- @@ -705,59 +705,63 @@ (define-public dbacl (package (name "dbacl") (version "1.14.1") - (source - (origin - (method url-fetch) - (uri (string-append "mirror://sourceforge/dbacl/dbacl/" version "/" - "dbacl-" version ".tar.gz")) - (sha256 - (base32 "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz")) - (patches (search-patches "dbacl-include-locale.h.patch")))) + (source (origin + (method url-fetch) + (uri (string-append "mirror://sourceforge/dbacl/dbacl/" + version + "/" + "dbacl-" + version + ".tar.gz")) + (sha256 + (base32 + "1gas0112wqjvwn9qg3hxnawk7h3prr0w9b2h68f3p1ifd1kzn3gz")) + (patches (search-patches "dbacl-include-locale.h.patch" + "dbacl-icheck-multiple-definitions.patch")))) (build-system gnu-build-system) (arguments --8<---------------cut here---------------end--------------->8--- The original was superior, at least for the URI part, which is now overly broken into multiple lines, not making good use of the available 80 characters of width available. -- Thanks, Maxim