GNU bug report logs - #62314
[PATCH] gnu: emacs-buttercup: Fix build with native compilation.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#62314: closed ([PATCH] gnu: emacs-buttercup: Fix build with
 native compilation.)
Date: Fri, 24 Mar 2023 09:18:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Fri, 24 Mar 2023 10:17:26 +0100
with message-id <878rfmzexl.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilation.
has caused the debbugs.gnu.org bug report #62314,
regarding [PATCH] gnu: emacs-buttercup: Fix build with native compilation.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
62314: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=62314
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: John Kehayias <john.kehayias <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: emacs-buttercup: Fix build with native compilation.
Date: Tue, 21 Mar 2023 02:26:44 +0000

[Message part 3 (text/plain, inline)]

Hi Guix,

Here's a patch to fix emacs-buttercup failing with native-comp, i.e. guix build emacs-buttercup --with-input=emacs-minimal=emacs.

Here is the link to the upstream issue: <https://github.com/jorgenschaefer/emacs-buttercup/issues/236>

In short, it should be fixed but the fix used a variable name in current git Emacs which is different in the current release. So this patch adds the older variable name with the same fix.

I checked that it lints and native-comp and regular both build. I'll wait for QA to check for any other breakages. And I welcome any input on the commit message/code comment here.

Thanks!
John

[0001-gnu-emacs-buttercup-Fix-build-with-native-compilatio.patch (text/x-patch, attachment)]

[Message part 5 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 62314-done <at> debbugs.gnu.org
Subject: Re: [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native
 compilation.
Date: Fri, 24 Mar 2023 10:17:26 +0100

Hello,

John Kehayias via Guix-patches via <guix-patches <at> gnu.org> writes:

> Here's a patch to fix emacs-buttercup failing with native-comp, i.e. guix build emacs-buttercup --with-input=emacs-minimal=emacs.

Applied, with my suggested change. Thanks.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.