GNU bug report logs - #62314
[PATCH] gnu: emacs-buttercup: Fix build with native compilation.

Previous Next

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 62314 <at> debbugs.gnu.org
Cc: john.kehayias <at> protonmail.com
Subject: [bug#62314] [PATCH] gnu: emacs-buttercup: Fix build with native compilation.
Date: Tue, 21 Mar 2023 10:34:47 +0100

Hello,

John Kehayias via Guix-patches via <guix-patches <at> gnu.org> writes:

> Subject: [PATCH] gnu: emacs-buttercup: Fix build with native
> compilation.

Thank you.

> +          (add-after 'unpack 'fix-spy-on-test
> +            (lambda _
> +              (substitute* "buttercup.el"
> +                ;; The spy-on test fails with native compilation, which was
> +                ;; fixed in v1.30 but with a variable name for Emacs newer
> +                ;; than 28.2.  Add in the same fix with the current variable
> +                ;; name.  Upstream bug and fix:
> +                ;; <https://github.com/jorgenschaefer/emacs-buttercup/issues/236>
> +                (("61880") "61880\n(comp-enable-subr-trampolines nil)\n"))))

Nitpick: I'm surprised by the choice of your anchor: 61880 is at the end
of a comment. Wouldn't

    (("\\(native-comp-enable-subr-trampolines nil\\)" all)
     (string-append all "\n(comp-enable-subr-trampolines nil)"))

be more explicit?

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.