GNU bug report logs - #62310
[PATCH 0/4] gnu: fdroidcl: Update to 0.7.0.

Previous Next

Full log

Message #20 received at 62310 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Sergey Trofimov <sarg <at> sarg.org.ru>
Cc: 62310 <at> debbugs.gnu.org
Subject: Re: bug#62310: [PATCH 0/4] gnu: fdroidcl: Update to 0.7.0.
Date: Mon, 20 Mar 2023 21:43:57 -0400

Hi!

Sergey Trofimov <sarg <at> sarg.org.ru> writes:

> * gnu/packages/golang.scm (go-github-com-schollz-progressbar-v3):
> New variable.
> ---
>  gnu/packages/golang.scm | 32 ++++++++++++++++++++++++++++++++
>  1 file changed, 32 insertions(+)
>
> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index c75fdb4a31..e9187a14e9 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -11304,6 +11304,38 @@ (define-public go-sigs-k8s-io-yaml
>  @url{https://github.com/ghodss/yaml,ghodss/yaml}.")
>      (license (list license:expat license:bsd-3))))
>  
> +(define-public go-github-com-schollz-progressbar-v3
> +  (package
> +    (name "go-github-com-schollz-progressbar-v3")
> +    (version "3.13.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://github.com/schollz/progressbar")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "1hjahr5r52i7w6iyvl3rpzr46iignhfdh4694fl7m2b4gkaw9gd6"))))
> +    (build-system go-build-system)
> +    (arguments
> +     '(#:import-path "github.com/schollz/progressbar/v3"
> +       #:tests? #f))

There seems to be a simple test included; it'd be preferable to run it.
If there are reasons against running it, they should be explained in a
comment.

> +    (propagated-inputs (list go-golang-org-x-term
> +                             go-github-com-stretchr-testify
> +                             go-github-com-mitchellh-colorstring
> +                             go-github-com-mattn-go-runewidth
> +                             go-github-com-mattn-go-isatty
> +                             go-github-com-k0kubun-go-ansi
> +                             go-github-com-davecgh-go-spew))
> +    (home-page "https://github.com/schollz/progressbar")
> +    (synopsis "Simple cross-platform progress bar.")
> +    (description
> +     "This package provides a very simple thread-safe progress bar which should work
> +on every OS without problems.  In order to be OS agnostic support of multi-line
> +outputs is not provided.")
> +    (license license:expat)))

Cross-platform or Windows-compatible or this kind of qualities are not
useful information for Guix users, as Guix can only run on top of
GNU(/Linux) systems anyway, so I'd remove such text from the
description.

Could you please send a v2?

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.